Re: Review Request 49128: AMBARI-17389. Read 'yarn.nodemanager.resource.memory-mb' and 'yarn.scheduler.minimum-allocation-mb' from 'configurations' if 'changed-configurations' is empty and config is t

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49128/#review139206
---


Ship it!




Ship It!

- Sumit Mohanty


On June 23, 2016, 2:28 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49128/
> ---
> 
> (Updated June 23, 2016, 2:28 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17389
> https://issues.apache.org/jira/browse/AMBARI-17389
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change done in the way we read : 'yarn.nodemanager.resource.memory-mb' and 
> 'yarn.scheduler.minimum-allocation-mb' for calculating LLAP configs.
> 
> - Reads from:
> - configurations (if changed as part of current Stack Advisor invocation 
> (output)), and services["changed-configurations"]
>   is empty  -> Implies 1st invocation of SA, else
> - services['configurations'] (input) -> Subsequent invocations from UI.
> 
> - services["changed-configurations"] would be empty if Stack Advisor call is 
> made from Blueprints (1st invocation). Subsequent
>   Stack Advisor calls will have it non-empty. We do this because in 
> subsequent invocations, even if Stack Advsior calculates this
>   value (configurations), it is finally not recommended, making 'input' value 
> to survive.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 8aa2f5f 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> fce1c1c 
> 
> Diff: https://reviews.apache.org/r/49128/diff/
> 
> 
> Testing
> ---
> 
> Updated Python UTs.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 49128: AMBARI-17389. Read 'yarn.nodemanager.resource.memory-mb' and 'yarn.scheduler.minimum-allocation-mb' from 'configurations' if 'changed-configurations' is empty and config is there

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49128/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17389
https://issues.apache.org/jira/browse/AMBARI-17389


Repository: ambari


Description
---

Change done in the way we read : 'yarn.nodemanager.resource.memory-mb' and 
'yarn.scheduler.minimum-allocation-mb' for calculating LLAP configs.

- Reads from:
- configurations (if changed as part of current Stack Advisor invocation 
(output)), and services["changed-configurations"]
  is empty  -> Implies 1st invocation of SA, else
- services['configurations'] (input) -> Subsequent invocations from UI.

- services["changed-configurations"] would be empty if Stack Advisor call is 
made from Blueprints (1st invocation). Subsequent
  Stack Advisor calls will have it non-empty. We do this because in subsequent 
invocations, even if Stack Advsior calculates this
  value (configurations), it is finally not recommended, making 'input' value 
to survive.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
8aa2f5f 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py fce1c1c 

Diff: https://reviews.apache.org/r/49128/diff/


Testing
---

Updated Python UTs.


Thanks,

Swapan Shridhar

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

[Masahiro Tanaka]

> On 6月 21, 2016, 3:05 p.m., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines 
> > 133-135
> > 
> >
> > We don't hardcode specific workarounds into the alerts framework. It's 
> > not maintainable.

Thank you for reviewing Jonathan! I'll update the patch to respond to your 
comment.


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review138843
---


On 6月 20, 2016, 10:29 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
> 
> (Updated 6月 20, 2016, 10:29 p.m.)
> 
> 
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17253
> https://issues.apache.org/jira/browse/AMBARI-17253
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are too many WARNING in ZooKeeper log.
> ```
> 2016-06-15 21:02:15,405 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
> stream exception
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> at 
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
> at java.lang.Thread.run(Thread.java:745)
> ```
> 
> It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port 
> to do monitoring.
> We should use 'ruok' to monitor zookeepers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
>   ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 
> 
> Diff: https://reviews.apache.org/r/48972/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 49126: AMBARI-17388 - Add Service Wizard stuck on Customize Services step

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49126/#review139192
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On June 23, 2016, 12:34 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49126/
> ---
> 
> (Updated June 23, 2016, 12:34 a.m.)
> 
> 
> Review request for Ambari and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-17388
> https://issues.apache.org/jira/browse/AMBARI-17388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add null check.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7_controller.js 3211974 
> 
> Diff: https://reviews.apache.org/r/49126/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit test passed.
>   28972 tests complete (27 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 49126: AMBARI-17388 - Add Service Wizard stuck on Customize Services step

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49126/
---

Review request for Ambari and Zhe (Joe) Wang.


Bugs: AMBARI-17388
https://issues.apache.org/jira/browse/AMBARI-17388


Repository: ambari


Description
---

Add null check.


Diffs
-

  ambari-web/app/controllers/wizard/step7_controller.js 3211974 

Diff: https://reviews.apache.org/r/49126/diff/


Testing
---

Manually tested on live cluster.
All unit test passed.
  28972 tests complete (27 seconds)
  154 tests pending


Thanks,

Richard Zang

Review Request 49119: AMBARI-17383: User names should be case insensitive

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49119/
---

Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sumit 
Mohanty.


Bugs: AMBARI-17383
https://issues.apache.org/jira/browse/AMBARI-17383


Repository: ambari


Description
---

AMBARI-17383: User names should be case insensitive

** Issue: **
It should not be possible to add user names that differ only by case. 

** Fix: **
1. Make a case insensitive string comparision against the DB Users table to see 
if the input user name already exists.
2. Added a new UT to test this change.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 349668fe57bedbe45be26a03cc92b9fd4a29483b 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
d209cfcfc5ce5a78354220cf084e9a394841af49 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/User.java
 720918b646d4a70b9b53a1d2da05dd391adb03e7 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 1a7b58db3759dff876ca0e909ab62170c8f49955 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 dc22bb914df36bb9b3fbf27d3c2fbf1251489553 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 44fb73c2644a75a8165425b97137dac20042972b 

Diff: https://reviews.apache.org/r/49119/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [5.972s]
[INFO] Apache Ambari Project POM . SUCCESS [0.038s]
[INFO] Ambari Web  SUCCESS [24.668s]
[INFO] Ambari Views .. SUCCESS [1.161s]
[INFO] Ambari Admin View . SUCCESS [9.686s]
[INFO] ambari-metrics  SUCCESS [0.711s]
[INFO] Ambari Metrics Common . SUCCESS [0.868s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.184s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.648s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.671s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.630s]
[INFO] Ambari Metrics Collector .. SUCCESS [9.722s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.332s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.885s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:34.064s]
[INFO] Ambari Server . SUCCESS [3:11.990s]
[INFO] Ambari Functional Tests ... SUCCESS [1.250s]
[INFO] Ambari Agent .. SUCCESS [26.046s]
[INFO] Ambari Client . SUCCESS [0.053s]
[INFO] Ambari Python Client .. SUCCESS [0.975s]
[INFO] Ambari Groovy Client .. SUCCESS [2.234s]
[INFO] Ambari Shell .. SUCCESS [0.047s]
[INFO] Ambari Python Shell ... SUCCESS [0.721s]
[INFO] Ambari Groovy Shell ... SUCCESS [1.045s]
[INFO] ambari-logsearch .. SUCCESS [0.262s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.397s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.177s]
[INFO] Ambari Logsearch Portal ... SUCCESS [6.714s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.364s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.087s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:31.357s
[INFO] Finished at: Wed Jun 22 17:10:48 PDT 2016
[INFO] Final Memory: 327M/1373M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=User*Test **

Results :

Tests run: 62, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 53.870s
[INFO] Finished at: Wed Jun 22 17:12:06 PDT 2016
[INFO] Final Memory: 56M/933M
[INFO] 

** 3. mvn test -DskipSurefireTests **

Review Request 49124: AMBARI-17387 Changing HDP repo URL does not leads to sending written URL to ambari-server while registering new HDP version

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49124/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-17387
https://issues.apache.org/jira/browse/AMBARI-17387


Repository: ambari


Description
---

STR:
  Deploy cluster HDP 2.3
  Register HDP 2.5.0.0 latest (e.g 2.5.0.0-664)
  Try to register 2.5.0.0, but with other URL (e.g for HDP 2.5.0.0-569)
Result: internal server error " Base url 
http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-664 
is already defined for another repository version"
But in this case we were trying to register 
http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-569


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
 6cf6849 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
f896c02 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
1131041 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html 
ea577f6 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
 6268030 

Diff: https://reviews.apache.org/r/49124/diff/


Testing
---

ambari-admin:
Executed 76 of 76 SUCCESS (0.128 secs / 0.378 secs)
Manual testing done


Thanks,

Zhe (Joe) Wang

Review Request 49121: AMBARI-17386. Misc fixes for Atlas, write correct conf files for server and client, use PLAINTEXTSASL, and remove atlas from HADOOP_CLASSPATH in Hive

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49121/
---

Review request for Ambari, Oliver Szabo, Sumit Mohanty, and Suma Shivaprasad.


Repository: ambari


Description
---

Misc fixes for Atlas

* Today, the same config files and directories get written out for both server 
and client, which is incorrect.
* When kerberizing Atlas, change atlas.kafka.security.protocol to PLAINTEXTSASL
* In hive-env, remove all atlas paths from HADOOP_CLASSPATH


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 55a8158 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
 69de51d 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/kerberos.json 
35addc4 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
 7122c3d 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 7ef2e50 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
8aa2f5f 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
c76dfd1 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 8bea7ec 

Diff: https://reviews.apache.org/r/49121/diff/


Testing
---

Verified during fresh install of Atlas.

Python unit tests passed,
--
Total run:1072
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 49114: AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py and KNOX's upgrade.py

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49114/#review139167
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 22, 2016, 10:51 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49114/
> ---
> 
> (Updated June 22, 2016, 10:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17384
> https://issues.apache.org/jira/browse/AMBARI-17384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's 
> alert_llap_app_status.py and KNOX's upgrade.py
> - Use 'Script.get_stack_root()'.
> 
> Also adding check for trimming the 'llapstatus' o/p only if start of JSON 
> blob is > 0th line.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  33bf139 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  d1c8401 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py
>  8c71260 
> 
> Diff: https://reviews.apache.org/r/49114/diff/
> 
> 
> Testing
> ---
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 49114: AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py and KNOX's upgrade.py

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49114/#review139162
---


Ship it!




Ship It!

- Sumit Mohanty


On June 22, 2016, 10:51 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49114/
> ---
> 
> (Updated June 22, 2016, 10:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17384
> https://issues.apache.org/jira/browse/AMBARI-17384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's 
> alert_llap_app_status.py and KNOX's upgrade.py
> - Use 'Script.get_stack_root()'.
> 
> Also adding check for trimming the 'llapstatus' o/p only if start of JSON 
> blob is > 0th line.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  33bf139 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  d1c8401 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py
>  8c71260 
> 
> Diff: https://reviews.apache.org/r/49114/diff/
> 
> 
> Testing
> ---
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 49114: AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py and KNOX's upgrade.py

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49114/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17384
https://issues.apache.org/jira/browse/AMBARI-17384


Repository: ambari


Description
---

AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py 
and KNOX's upgrade.py
- Use 'Script.get_stack_root()'.

Also adding check for trimming the 'llapstatus' o/p only if start of JSON blob 
is > 0th line.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 33bf139 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 d1c8401 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py
 8c71260 

Diff: https://reviews.apache.org/r/49114/diff/


Testing
---

Python UT passes.


Thanks,

Swapan Shridhar

Re: Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49104/#review139142
---


Ship it!




Ship It!

- Robert Levas


On June 22, 2016, 5:25 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49104/
> ---
> 
> (Updated June 22, 2016, 5:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-17380
> https://issues.apache.org/jira/browse/AMBARI-17380
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When using full URI paths for DataNode directories, ie, 
> {{file:///hadoop01/data/dn}}, the DataNode directory alert fails.  
> 
> The script alert needs to accept URI paths for DataNodes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py
>  df85002 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_datanode_unmounted_data_dir.py
>  c9bd187 
> 
> Diff: https://reviews.apache.org/r/49104/diff/
> 
> 
> Testing
> ---
> 
> Used a mixture of file:// and normal paths.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 49106: AuthorizationHelperTest.testAuthName may fail due to residual SecurityContext from previously executed test cases.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49106/#review139140
---


Ship it!




Ship It!

- Jonathan Hurley


On June 22, 2016, 5:22 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49106/
> ---
> 
> (Updated June 22, 2016, 5:22 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-17381
> https://issues.apache.org/jira/browse/AMBARI-17381
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> org.apache.ambari.server.security.authorization.AuthorizationHelperTest#testAuthName
>  may fail due to residual SecurityContext from previously executed test 
> cases. The SecurityContext should be cleared before (and after) each test in 
> the suite.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  8409a6b 
> 
> Diff: https://reviews.apache.org/r/49106/diff/
> 
> 
> Testing
> ---
> 
> Running 
> org.apache.ambari.server.security.authorization.AuthorizationHelperTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.354 sec - 
> in org.apache.ambari.server.security.authorization.AuthorizationHelperTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49104/
---

(Updated June 22, 2016, 5:25 p.m.)


Review request for Ambari, Alejandro Fernandez and Robert Levas.


Changes
---

mvn clean test


Bugs: AMBARI-17380
https://issues.apache.org/jira/browse/AMBARI-17380


Repository: ambari


Description
---

When using full URI paths for DataNode directories, ie, 
{{file:///hadoop01/data/dn}}, the DataNode directory alert fails.  

The script alert needs to accept URI paths for DataNodes.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py
 df85002 
  
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_datanode_unmounted_data_dir.py
 c9bd187 

Diff: https://reviews.apache.org/r/49104/diff/


Testing
---

Used a mixture of file:// and normal paths.


Thanks,

Jonathan Hurley

Review Request 49106: AuthorizationHelperTest.testAuthName may fail due to residual SecurityContext from previously executed test cases.

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49106/
---

Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Yusaku Sako.


Bugs: AMBARI-17381
https://issues.apache.org/jira/browse/AMBARI-17381


Repository: ambari


Description
---

org.apache.ambari.server.security.authorization.AuthorizationHelperTest#testAuthName
 may fail due to residual SecurityContext from previously executed test cases. 
The SecurityContext should be cleared before (and after) each test in the suite.


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
 8409a6b 

Diff: https://reviews.apache.org/r/49106/diff/


Testing
---

Running org.apache.ambari.server.security.authorization.AuthorizationHelperTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.354 sec - in 
org.apache.ambari.server.security.authorization.AuthorizationHelperTest


Thanks,

Robert Levas

Re: Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49104/#review139139
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 22, 2016, 9:18 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49104/
> ---
> 
> (Updated June 22, 2016, 9:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-17380
> https://issues.apache.org/jira/browse/AMBARI-17380
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When using full URI paths for DataNode directories, ie, 
> {{file:///hadoop01/data/dn}}, the DataNode directory alert fails.  
> 
> The script alert needs to accept URI paths for DataNodes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py
>  df85002 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_datanode_unmounted_data_dir.py
>  c9bd187 
> 
> Diff: https://reviews.apache.org/r/49104/diff/
> 
> 
> Testing
> ---
> 
> Used a mixture of file:// and normal paths.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49104/
---

Review request for Ambari, Alejandro Fernandez and Robert Levas.


Bugs: AMBARI-17380
https://issues.apache.org/jira/browse/AMBARI-17380


Repository: ambari


Description
---

When using full URI paths for DataNode directories, ie, 
{{file:///hadoop01/data/dn}}, the DataNode directory alert fails.  

The script alert needs to accept URI paths for DataNodes.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py
 df85002 
  
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_datanode_unmounted_data_dir.py
 c9bd187 

Diff: https://reviews.apache.org/r/49104/diff/


Testing
---

Used a mixture of file:// and normal paths.


Thanks,

Jonathan Hurley

Re: Review Request 49012: AMBARI-17330 Ambari changes to support kerberized Ranger tagsync

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49012/#review139120
---


Ship it!




Ship It!

- Robert Levas


On June 22, 2016, 2:30 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49012/
> ---
> 
> (Updated June 22, 2016, 2:30 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Robert Levas, Srimanth Gunturi, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17330
> https://issues.apache.org/jira/browse/AMBARI-17330
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove below properties from ranger-tagsync-site.xml:
> - ranger.tagsync.atlas.to.ranger.service.mapping
> - ranger.tagsync.atlas.custom.resource.mappers
> 
> Add below property in ranger-tagsync-site.xml:
> - ranger.tagsync.source.atlasrest.username (default - empty)
> 
> Add below properties in tagsync-application-properties.xml only if cluster is 
> kerberized:
> - 
> atlas.jaas.KafkaClient.loginModuleName=com.sun.security.auth.module.Krb5LoginModule
> - atlas.jaas.KafkaClient.loginModuleControlFlag=required
> - atlas.jaas.KafkaClient.option.useKeyTab=true
> - atlas.jaas.KafkaClient.option.storeKey=true
> - atlas.jaas.KafkaClient.option.serviceName=kafka
> - atlas.jaas.KafkaClient.option.keyTab=tagsync_keytab_path
> - atlas.jaas.KafkaClient.option.principal=tagsync_jaas_principal
> - atlas.kafka.sasl.kerberos.service.name=kafka
> - atlas.kafka.security.protocol=SASL_PLAINTEXT
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  9e0fb7c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
>  c5a575d 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> cd34cd9 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  61bdce0 
> 
> Diff: https://reviews.apache.org/r/49012/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation on centos 6 in secure env
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48507: AMBARI-17074: Expose Spark daemon memory in Spark2

[Weiqing Yang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48507/
---

(Updated June 22, 2016, 6:09 p.m.)


Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, and Srimanth Gunturi.


Changes
---

The previous patch makes the unit test, 
org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs,
 failed. Error message is : cvc-complex-type.2.4.a: Invalid content was found 
starting with element 'on-stack-upgrade'. So in spark-env.xml, the element 
'on-stack-upgrade' should not be there any more. In this patch, the element 
'on-stack-upgrade' is removed and the element "on-ambari-upgrade" has also been 
updated.


Bugs: AMBARI-17074
https://issues.apache.org/jira/browse/AMBARI-17074


Repository: ambari


Description
---

Expose Spark daemon memory in Spark2, so that the user can modify its size on 
ambari web UI easily. The change is the same with the patch of jira 
AMBARI-16757, which is for Spark 1.6.1.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 76c670a 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 a0d91c7 

Diff: https://reviews.apache.org/r/48507/diff/


Testing
---

Tests manually passed.


Thanks,

Weiqing Yang

Re: Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49029/
---

(Updated June 22, 2016, 1:57 p.m.)


Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Oliver Szabo, and 
Sandor Magyari.


Bugs: AMBARI-17226
https://issues.apache.org/jira/browse/AMBARI-17226


Repository: ambari


Description
---

When requesting a Kerberos Descriptor via the REST API, 'when' clauses should 
optionally be processed.  If elected to be processed, identities that contain 
`when` clauses will be included or excluded from the resulting descriptor based 
on the result of the evaluation. 

In the event of an _add service_ scenario, the services being added should be 
able to be specified so that they can be included in the data used for 
`when`-clause evaluation.  

#Solution
Add _GET directives_ to specify whether `when` clauses are to be evaluated (or 
not) while building the Kerberos Descriptor using the following API call:
```
GET 
/api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE?evaluate_when=true
```
If new services are being added, the `additional_services` directive should be 
added to the request so the evaluation can be preformed on the _future_ set of 
services, which may evaluate differently then the _current_ set of services.
```
GET 
/api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE?evaluate_when=true@additional_services=HIVE,TEZ,PIG
```

#Notes
- A lot of code was moved from ClusterKerberosDescriptorResourceProvider to 
KerberosHelper to reduce the likelyhood of duplication
- The logic to build a Kerberos descriptor (STACK, USER, COMPOSITE) has been 
consolidated in the KerberosHelper
- Some duplicate code in test cases have been conslidated


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 a2aeffa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 5ffc8a3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 cd79e46 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
 1f5d1d8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
 79b9a55 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
 64d9292 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
 19d3f5e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
 98f8883 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorType.java
 0677de6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
 2631d35 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
 9eeb802 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 7281e85 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java
 898cf46 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
 9f0f7a1 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
 004cd66 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
 e5392c0 

Diff: https://reviews.apache.org/r/49029/diff/


Testing
---

Manually testing...  updated unit tests...

# Local test results: 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:27:14.265s
[INFO] Finished at: Tue Jun 21 12:03:08 EDT 2016
[INFO] Final Memory: 61M/1851M
[INFO] 

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

[Robert Levas]

> On June 22, 2016, 12:43 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java,
> >  line 335
> > 
> >
> > isBlank instead?

yup


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49029/#review139080
---


On June 22, 2016, 10:17 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49029/
> ---
> 
> (Updated June 22, 2016, 10:17 a.m.)
> 
> 
> Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Oliver Szabo, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-17226
> https://issues.apache.org/jira/browse/AMBARI-17226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When requesting a Kerberos Descriptor via the REST API, 'when' clauses should 
> optionally be processed.  If elected to be processed, identities that contain 
> `when` clauses will be included or excluded from the resulting descriptor 
> based on the result of the evaluation. 
> 
> In the event of an _add service_ scenario, the services being added should be 
> able to be specified so that they can be included in the data used for 
> `when`-clause evaluation.  
> 
> #Solution
> Add _GET directives_ to specify whether `when` clauses are to be evaluated 
> (or not) while building the Kerberos Descriptor using the following API call:
> ```
> GET 
> /api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE?evaluate_when=true
> ```
> If new services are being added, the `additional_services` directive should 
> be added to the request so the evaluation can be preformed on the _future_ 
> set of services, which may evaluate differently then the _current_ set of 
> services.
> ```
> GET 
> /api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE?evaluate_when=true@additional_services=HIVE,TEZ,PIG
> ```
> 
> #Notes
> - A lot of code was moved from ClusterKerberosDescriptorResourceProvider to 
> KerberosHelper to reduce the likelyhood of duplication
> - The logic to build a Kerberos descriptor (STACK, USER, COMPOSITE) has been 
> consolidated in the KerberosHelper
> - Some duplicate code in test cases have been conslidated
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  a2aeffa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  5ffc8a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  cd79e46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
>  1f5d1d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  79b9a55 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  64d9292 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  19d3f5e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  98f8883 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorType.java
>  0677de6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  2631d35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
>  9eeb802 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  7281e85 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java
>  898cf46 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  9f0f7a1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  004cd66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  e5392c0 
> 
> Diff: https://reviews.apache.org/r/49029/diff/
> 
> 
> Testing
> ---
> 
> Manually testing...  updated unit tests...
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:27:14.265s
> [INFO] Finished at: Tue Jun 21 12:03:08 EDT 2016
> [INFO] Final Memory: 61M/1851M
> [INFO] 
> 

Re: Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49029/#review139080
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
 (line 247)


isBlank instead?


- Jonathan Hurley


On June 22, 2016, 10:17 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49029/
> ---
> 
> (Updated June 22, 2016, 10:17 a.m.)
> 
> 
> Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Oliver Szabo, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-17226
> https://issues.apache.org/jira/browse/AMBARI-17226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When requesting a Kerberos Descriptor via the REST API, 'when' clauses should 
> optionally be processed.  If elected to be processed, identities that contain 
> `when` clauses will be included or excluded from the resulting descriptor 
> based on the result of the evaluation. 
> 
> In the event of an _add service_ scenario, the services being added should be 
> able to be specified so that they can be included in the data used for 
> `when`-clause evaluation.  
> 
> #Solution
> Add _GET directives_ to specify whether `when` clauses are to be evaluated 
> (or not) while building the Kerberos Descriptor using the following API call:
> ```
> GET 
> /api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE?evaluate_when=true
> ```
> If new services are being added, the `additional_services` directive should 
> be added to the request so the evaluation can be preformed on the _future_ 
> set of services, which may evaluate differently then the _current_ set of 
> services.
> ```
> GET 
> /api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE?evaluate_when=true@additional_services=HIVE,TEZ,PIG
> ```
> 
> #Notes
> - A lot of code was moved from ClusterKerberosDescriptorResourceProvider to 
> KerberosHelper to reduce the likelyhood of duplication
> - The logic to build a Kerberos descriptor (STACK, USER, COMPOSITE) has been 
> consolidated in the KerberosHelper
> - Some duplicate code in test cases have been conslidated
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  a2aeffa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  5ffc8a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  cd79e46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
>  1f5d1d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  79b9a55 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  64d9292 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  19d3f5e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  98f8883 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorType.java
>  0677de6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  2631d35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
>  9eeb802 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  7281e85 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java
>  898cf46 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  9f0f7a1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  004cd66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  e5392c0 
> 
> Diff: https://reviews.apache.org/r/49029/diff/
> 
> 
> Testing
> ---
> 
> Manually testing...  updated unit tests...
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:27:14.265s
> [INFO] Finished at: Tue Jun 21 12:03:08 EDT 2016
> [INFO] Final Memory: 61M/1851M
> [INFO] 
> 
> 
> # Jenkins test 

Re: Review Request 49087: After registering 2.5 HDP repo, it is hidden on UI

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49087/#review139076
---


Ship it!




Ship It!

- Dmytro Grinenko


On June 22, 2016, 4:09 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49087/
> ---
> 
> (Updated June 22, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17370
> https://issues.apache.org/jira/browse/AMBARI-17370
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When repository version is installed from VDF file, it is not shown on UI. 
> Look into DB shows that both repository version name  and version display 
> name look like
> HDP-2.5.0.0-123 . Repository version name formatted like this is not parsed 
> properly on UI, so it should look like 2.5.0.0-123
> 
> Looks like it is a side effect of AMBARI-17282
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  5e5a0a8 
> 
> Diff: https://reviews.apache.org/r/49087/diff/
> 
> 
> Testing
> ---
> 
> checked manually on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 49093: Unable To Delete A Service After Upgrade Due To Foreign Key Violation

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49093/#review139074
---


Ship it!




Ship It!

- Robert Levas


On June 22, 2016, 11:35 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49093/
> ---
> 
> (Updated June 22, 2016, 11:35 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-17371
> https://issues.apache.org/jira/browse/AMBARI-17371
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When deleting a service after an upgrade there is a foreign key violation. 
> This is due to how JPA is caching the collections when creating the 
> bi-directional association. 
> 
> ```
> Exception [EclipseLink-4002] (Eclipse Persistence Services - 
> 2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: org.postgresql.util.PSQLException: ERROR: update or 
> delete on table "servicecomponentdesiredstate" violates foreign key 
> constraint "fk_sc_history_component_id" on table "servicecomponent_history"
>   Detail: Key (id)=(1) is still referenced from table 
> "servicecomponent_history".
> Error Code: 0
> Call: DELETE FROM servicecomponentdesiredstate WHERE (id = ?)
>   bind => [1 parameter bound]
>   at 
> org.eclipse.persistence.exceptions.DatabaseException.sqlException(DatabaseException.java:340)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.processExceptionForCommError(DatabaseAccessor.java:1620)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:900)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeNoSelect(DatabaseAccessor.java:964)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:633)
>   at 
> org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatch(ParameterizedSQLBatchWritingMechanism.java:149)
>   at 
> org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatchedStatements(ParameterizedSQLBatchWritingMechanism.java:134)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.writesCompleted(DatabaseAccessor.java:1845)
>   at 
> org.eclipse.persistence.internal.sessions.AbstractSession.writesCompleted(AbstractSession.java:4300)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.writesCompleted(UnitOfWorkImpl.java:5592)
>   at 
> org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.writeChanges(RepeatableWriteUnitOfWork.java:456)
>   at 
> org.eclipse.persistence.internal.jpa.EntityManagerImpl.flush(EntityManagerImpl.java:874)
>   at 
> org.apache.ambari.server.orm.dao.ServiceComponentDesiredStateDAO.remove(ServiceComponentDesiredStateDAO.java:121)
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
>  7281c01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentHistoryEntity.java
>  e7fef71 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  9088c1c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
>  6b00616 
> 
> Diff: https://reviews.apache.org/r/49093/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 49093: Unable To Delete A Service After Upgrade Due To Foreign Key Violation

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49093/
---

Review request for Ambari, Alejandro Fernandez and Robert Levas.


Bugs: AMBARI-17371
https://issues.apache.org/jira/browse/AMBARI-17371


Repository: ambari


Description
---

When deleting a service after an upgrade there is a foreign key violation. This 
is due to how JPA is caching the collections when creating the bi-directional 
association. 

```
Exception [EclipseLink-4002] (Eclipse Persistence Services - 
2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
Internal Exception: org.postgresql.util.PSQLException: ERROR: update or delete 
on table "servicecomponentdesiredstate" violates foreign key constraint 
"fk_sc_history_component_id" on table "servicecomponent_history"
  Detail: Key (id)=(1) is still referenced from table 
"servicecomponent_history".
Error Code: 0
Call: DELETE FROM servicecomponentdesiredstate WHERE (id = ?)
bind => [1 parameter bound]
at 
org.eclipse.persistence.exceptions.DatabaseException.sqlException(DatabaseException.java:340)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.processExceptionForCommError(DatabaseAccessor.java:1620)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:900)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeNoSelect(DatabaseAccessor.java:964)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:633)
at 
org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatch(ParameterizedSQLBatchWritingMechanism.java:149)
at 
org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatchedStatements(ParameterizedSQLBatchWritingMechanism.java:134)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.writesCompleted(DatabaseAccessor.java:1845)
at 
org.eclipse.persistence.internal.sessions.AbstractSession.writesCompleted(AbstractSession.java:4300)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.writesCompleted(UnitOfWorkImpl.java:5592)
at 
org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.writeChanges(RepeatableWriteUnitOfWork.java:456)
at 
org.eclipse.persistence.internal.jpa.EntityManagerImpl.flush(EntityManagerImpl.java:874)
at 
org.apache.ambari.server.orm.dao.ServiceComponentDesiredStateDAO.remove(ServiceComponentDesiredStateDAO.java:121)
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
 7281c01 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentHistoryEntity.java
 e7fef71 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 9088c1c 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
 6b00616 

Diff: https://reviews.apache.org/r/49093/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Review Request 49092: Zeppelin interpreter config typo

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49092/
---

Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Rohit 
Choudhary.


Bugs: AMBARI-17372
https://issues.apache.org/jira/browse/AMBARI-17372


Repository: ambari


Description
---

typo in update intrepreter function


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 f2899d0 

Diff: https://reviews.apache.org/r/49092/diff/


Testing
---

tested on centOS


Thanks,

Renjith Kamath

Re: Review Request 49087: After registering 2.5 HDP repo, it is hidden on UI

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49087/
---

(Updated June 22, 2016, 5:55 p.m.)


Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-17370
https://issues.apache.org/jira/browse/AMBARI-17370


Repository: ambari


Description
---

When repository version is installed from VDF file, it is not shown on UI. Look 
into DB shows that both repository version name  and version display name look 
like
HDP-2.5.0.0-123 . Repository version name formatted like this is not parsed 
properly on UI, so it should look like 2.5.0.0-123


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 5e5a0a8 

Diff: https://reviews.apache.org/r/49087/diff/


Testing (updated)
---

checked manually on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 49086: hiveserver2-site.xml not created

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49086/#review139066
---


Ship it!




Ship It!

- Robert Levas


On June 22, 2016, 9:41 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49086/
> ---
> 
> (Updated June 22, 2016, 9:41 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17369
> https://issues.apache.org/jira/browse/AMBARI-17369
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by refactoring in AMBARI-17284, when starting hiveserver2, the 
> {{hiveserver2-site.xml}} is not created.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  30cc942 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6a53dca 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ba10939 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json d4310f1 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 
> 808c914 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 
> 9757db6 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
> ef6c021 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 
> f6bf98e 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json fac0649 
> 
> Diff: https://reviews.apache.org/r/49086/diff/
> 
> 
> Testing
> ---
> 
> OK
> --
> Total run:1073
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 49029: When requesting a Kerberos Descriptor via the REST API, 'when' clauses should optionally be processed

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49029/
---

(Updated June 22, 2016, 10:17 a.m.)


Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Oliver Szabo, and 
Sandor Magyari.


Changes
---

Fixed potential NPE when services or components are not specified in Kerberos 
descriptors.


Bugs: AMBARI-17226
https://issues.apache.org/jira/browse/AMBARI-17226


Repository: ambari


Description
---

When requesting a Kerberos Descriptor via the REST API, 'when' clauses should 
optionally be processed.  If elected to be processed, identities that contain 
`when` clauses will be included or excluded from the resulting descriptor based 
on the result of the evaluation. 

In the event of an _add service_ scenario, the services being added should be 
able to be specified so that they can be included in the data used for 
`when`-clause evaluation.  

#Solution
Add _GET directives_ to specify whether `when` clauses are to be evaluated (or 
not) while building the Kerberos Descriptor using the following API call:
```
GET 
/api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE?evaluate_when=true
```
If new services are being added, the `additional_services` directive should be 
added to the request so the evaluation can be preformed on the _future_ set of 
services, which may evaluate differently then the _current_ set of services.
```
GET 
/api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE?evaluate_when=true@additional_services=HIVE,TEZ,PIG
```

#Notes
- A lot of code was moved from ClusterKerberosDescriptorResourceProvider to 
KerberosHelper to reduce the likelyhood of duplication
- The logic to build a Kerberos descriptor (STACK, USER, COMPOSITE) has been 
consolidated in the KerberosHelper
- Some duplicate code in test cases have been conslidated


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 a2aeffa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 5ffc8a3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 cd79e46 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
 1f5d1d8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
 79b9a55 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
 64d9292 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
 19d3f5e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
 98f8883 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorType.java
 0677de6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
 2631d35 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
 9eeb802 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 7281e85 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java
 898cf46 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
 9f0f7a1 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
 004cd66 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
 e5392c0 

Diff: https://reviews.apache.org/r/49029/diff/


Testing
---

Manually testing...  updated unit tests...

# Local test results: 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:27:14.265s
[INFO] Finished at: Tue Jun 21 12:03:08 EDT 2016
[INFO] Final Memory: 61M/1851M
[INFO] 

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/#review139062
---



Can we get some unit tests to cover this case?

- Jonathan Hurley


On June 22, 2016, 4:58 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49072/
> ---
> 
> (Updated June 22, 2016, 4:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17333
> https://issues.apache.org/jira/browse/AMBARI-17333
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for get/create repo call for Ranger KMS.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  05beadb 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  5847984 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  452be86 
> 
> Diff: https://reviews.apache.org/r/49072/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger KMS installation on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49087: After registering 2.5 HDP repo, it is hidden on UI

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49087/
---

(Updated June 22, 2016, 4:45 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-17370
https://issues.apache.org/jira/browse/AMBARI-17370


Repository: ambari


Description
---

When repository version is installed from VDF file, it is not shown on UI. Look 
into DB shows that both repository version name  and version display name look 
like
HDP-2.5.0.0-123 . Repository version name formatted like this is not parsed 
properly on UI, so it should look like 2.5.0.0-123


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 5e5a0a8 

Diff: https://reviews.apache.org/r/49087/diff/


Testing
---

manual verification in progress


Thanks,

Dmitro Lisnichenko

Review Request 49087: After registering 2.5 HDP repo, it is hidden on UI

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49087/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-17370
https://issues.apache.org/jira/browse/AMBARI-17370


Repository: ambari


Description
---

When repository version is installed from VDF file, it is not shown on UI. Look 
into DB shows that both repository version name  and version display name look 
like
HDP-2.5.0.0-123 . Repository version name formatted like this is not parsed 
properly on UI, so it should look like 2.5.0.0-123


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 5e5a0a8 

Diff: https://reviews.apache.org/r/49087/diff/


Testing
---

manual verification in progress


Thanks,

Dmitro Lisnichenko

Re: Review Request 48950: Pig View- Show actual error message thrown by webhcat api

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48950/#review139060
---


Ship it!




Ship It!

- Nitiraj Rathore


On June 22, 2016, 7:13 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48950/
> ---
> 
> (Updated June 22, 2016, 7:13 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17310
> https://issues.apache.org/jira/browse/AMBARI-17310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added Error handling for the rest call.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
>  5e0f3fa 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java
>  c3bd504 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/JSONRequest.java
>  39a595b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/ServiceFormattedException.java
>  7b57bb2 
>   
> contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/JobTest.java 
> f619848 
> 
> Diff: https://reviews.apache.org/r/48950/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 49086: hiveserver2-site.xml not created

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49086/
---

Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sumit Mohanty.


Bugs: AMBARI-17369
https://issues.apache.org/jira/browse/AMBARI-17369


Repository: ambari


Description
---

Caused by refactoring in AMBARI-17284, when starting hiveserver2, the 
{{hiveserver2-site.xml}} is not created.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 30cc942 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 6a53dca 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ba10939 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json d4310f1 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 
808c914 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json 
9757db6 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
ef6c021 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 
f6bf98e 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json fac0649 

Diff: https://reviews.apache.org/r/49086/diff/


Testing
---

OK
--
Total run:1073
Total errors:0
Total failures:0
OK


Thanks,

Jonathan Hurley

Re: Review Request 49081: Ambari-on-LLAP: MetadataSpace memory setting

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49081/#review139056
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 22, 2016, 11:46 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49081/
> ---
> 
> (Updated Червень 22, 2016, 11:46 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17367
> https://issues.apache.org/jira/browse/AMBARI-17367
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> MetadataSpace GC setting is being supplied to LLAP daemons
> started for Hive2 by default. This setting is only valid on JDK8 - it should 
> either be supplied only
> on JDK8, or removed entirely, otherwise the daemon will not start at all on
> JDK7
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  d1c8401 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  d11e3ff 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  b460464 
> 
> Diff: https://reviews.apache.org/r/49081/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49080: Tez install failed

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49080/
---

(Updated Червень 22, 2016, 11:58 до полудня)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.


Bugs: AMBARI-17366
https://issues.apache.org/jira/browse/AMBARI-17366


Repository: ambari


Description
---

{code}
 File 
"/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py",
 line 49, in tez
tez_env_file_path = os.path.join(config_dir, "tez-env.sh")
NameError: global name 'os' is not defined
{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
 67e3c4f 

Diff: https://reviews.apache.org/r/49080/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 49081: Ambari-on-LLAP: MetadataSpace memory setting

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49081/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-17367
https://issues.apache.org/jira/browse/AMBARI-17367


Repository: ambari


Description
---

MetadataSpace GC setting is being supplied to LLAP daemons
started for Hive2 by default. This setting is only valid on JDK8 - it should 
either be supplied only
on JDK8, or removed entirely, otherwise the daemon will not start at all on
JDK7


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 d1c8401 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 d11e3ff 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 b460464 

Diff: https://reviews.apache.org/r/49081/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48722/#review139054
---


Ship it!




Ship It!

- Andrew Onischuk


On June 22, 2016, 11:21 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48722/
> ---
> 
> (Updated June 22, 2016, 11:21 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Laszlo Puskas, Robert Levas, 
> Sandor Magyari, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17248
> https://issues.apache.org/jira/browse/AMBARI-17248
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Commands to be executed by ambari-agents are being sent down by the server in 
> the response message to agent heartbeat messages. 
> The server processes the received heartbeat, it checks if there are next 
> commands scheduled to be executed by ambari-agent and adds those to the 
> heartbeat response for the ambari-agent.
> The server organises the commands that can be executed in parallel into 
> stages. Ambari server ensures that only the commands of a single stage is 
> scheduled to be executed by the agent and starts scheduling the commands of 
> the next stage only after all commands of current stage has finished 
> successfully.
> The processing of command status received with the heartbeat message happens 
> asynchronously to heartbeat response in HeartBeatProcessor and 
> ActionScheduler creation thus when the heartbeat response is created the 
> commands for the next stage are not scheduled yet. This means that the next 
> commands will be sent to agent only with the next heartbeat.
> Agents currently sends a heartbeat to the server on command a completion or 
> at a timeout = self.netutil.HEARTBEAT_IDDLE_INTERVAL_SEC – 
> self.netutil.MINIMUM_INTERVAL_BETWEEN_HEARTBEATS interval which is ~10 
> seconds if there are no commands to be executed.
> This means that when the server receives a heartbeat triggered by the 
> completion of the last command from the current stage the server will send 
> the commands for the next stage only 10 seconds later when the next heartbeat 
> is received. This leads to agents spending considerable amount of time idle 
> when there are multiple stages to be executed.
> Agents should heartbeat at a higher rate while there are still pending stages 
> to be executed.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 8f2ab1b 
>   ambari-agent/conf/unix/upgrade_agent_configs.py 583b5aa 
>   ambari-agent/conf/windows/ambari-agent.ini df88be6 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 89a881a 
>   ambari-agent/src/main/python/ambari_agent/Controller.py e981a76 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 91098e0 
>   ambari-agent/src/main/python/ambari_agent/NetUtil.py 80bf3ae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py f113083 
>   ambari-agent/src/test/python/ambari_agent/TestNetUtil.py d72e319 
>   ambari-agent/src/test/python/ambari_agent/examples/ControllerTester.py 
> 8103872 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  35a37e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
>  1ab7ae9 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> ac0ddd2 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
> bd9de13 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  3d2388e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  c26e1e9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
>  627ade9 
> 
> Diff: https://reviews.apache.org/r/48722/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> Unit tests in succeeded.
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

[Victor Galgo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48722/#review139053
---


Ship it!




Ship It!

- Victor Galgo


On June 22, 2016, 11:21 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48722/
> ---
> 
> (Updated June 22, 2016, 11:21 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Laszlo Puskas, Robert Levas, 
> Sandor Magyari, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17248
> https://issues.apache.org/jira/browse/AMBARI-17248
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Commands to be executed by ambari-agents are being sent down by the server in 
> the response message to agent heartbeat messages. 
> The server processes the received heartbeat, it checks if there are next 
> commands scheduled to be executed by ambari-agent and adds those to the 
> heartbeat response for the ambari-agent.
> The server organises the commands that can be executed in parallel into 
> stages. Ambari server ensures that only the commands of a single stage is 
> scheduled to be executed by the agent and starts scheduling the commands of 
> the next stage only after all commands of current stage has finished 
> successfully.
> The processing of command status received with the heartbeat message happens 
> asynchronously to heartbeat response in HeartBeatProcessor and 
> ActionScheduler creation thus when the heartbeat response is created the 
> commands for the next stage are not scheduled yet. This means that the next 
> commands will be sent to agent only with the next heartbeat.
> Agents currently sends a heartbeat to the server on command a completion or 
> at a timeout = self.netutil.HEARTBEAT_IDDLE_INTERVAL_SEC – 
> self.netutil.MINIMUM_INTERVAL_BETWEEN_HEARTBEATS interval which is ~10 
> seconds if there are no commands to be executed.
> This means that when the server receives a heartbeat triggered by the 
> completion of the last command from the current stage the server will send 
> the commands for the next stage only 10 seconds later when the next heartbeat 
> is received. This leads to agents spending considerable amount of time idle 
> when there are multiple stages to be executed.
> Agents should heartbeat at a higher rate while there are still pending stages 
> to be executed.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 8f2ab1b 
>   ambari-agent/conf/unix/upgrade_agent_configs.py 583b5aa 
>   ambari-agent/conf/windows/ambari-agent.ini df88be6 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 89a881a 
>   ambari-agent/src/main/python/ambari_agent/Controller.py e981a76 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 91098e0 
>   ambari-agent/src/main/python/ambari_agent/NetUtil.py 80bf3ae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py f113083 
>   ambari-agent/src/test/python/ambari_agent/TestNetUtil.py d72e319 
>   ambari-agent/src/test/python/ambari_agent/examples/ControllerTester.py 
> 8103872 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  35a37e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
>  1ab7ae9 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> ac0ddd2 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
> bd9de13 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  3d2388e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  c26e1e9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
>  627ade9 
> 
> Diff: https://reviews.apache.org/r/48722/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> Unit tests in succeeded.
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48722/
---

(Updated June 22, 2016, 1:21 p.m.)


Review request for Ambari, Andrew Onischuk, Laszlo Puskas, Robert Levas, Sandor 
Magyari, and Sumit Mohanty.


Bugs: AMBARI-17248
https://issues.apache.org/jira/browse/AMBARI-17248


Repository: ambari


Description
---

Commands to be executed by ambari-agents are being sent down by the server in 
the response message to agent heartbeat messages. 
The server processes the received heartbeat, it checks if there are next 
commands scheduled to be executed by ambari-agent and adds those to the 
heartbeat response for the ambari-agent.
The server organises the commands that can be executed in parallel into stages. 
Ambari server ensures that only the commands of a single stage is scheduled to 
be executed by the agent and starts scheduling the commands of the next stage 
only after all commands of current stage has finished successfully.
The processing of command status received with the heartbeat message happens 
asynchronously to heartbeat response in HeartBeatProcessor and ActionScheduler 
creation thus when the heartbeat response is created the commands for the next 
stage are not scheduled yet. This means that the next commands will be sent to 
agent only with the next heartbeat.
Agents currently sends a heartbeat to the server on command a completion or at 
a timeout = self.netutil.HEARTBEAT_IDDLE_INTERVAL_SEC – 
self.netutil.MINIMUM_INTERVAL_BETWEEN_HEARTBEATS interval which is ~10 seconds 
if there are no commands to be executed.
This means that when the server receives a heartbeat triggered by the 
completion of the last command from the current stage the server will send the 
commands for the next stage only 10 seconds later when the next heartbeat is 
received. This leads to agents spending considerable amount of time idle when 
there are multiple stages to be executed.
Agents should heartbeat at a higher rate while there are still pending stages 
to be executed.


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 8f2ab1b 
  ambari-agent/conf/unix/upgrade_agent_configs.py 583b5aa 
  ambari-agent/conf/windows/ambari-agent.ini df88be6 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 89a881a 
  ambari-agent/src/main/python/ambari_agent/Controller.py e981a76 
  ambari-agent/src/main/python/ambari_agent/Heartbeat.py 91098e0 
  ambari-agent/src/main/python/ambari_agent/NetUtil.py 80bf3ae 
  ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py f113083 
  ambari-agent/src/test/python/ambari_agent/TestNetUtil.py d72e319 
  ambari-agent/src/test/python/ambari_agent/examples/ControllerTester.py 
8103872 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 35a37e3 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
 1ab7ae9 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
ac0ddd2 
  ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
bd9de13 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 3d2388e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 c26e1e9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
 627ade9 

Diff: https://reviews.apache.org/r/48722/diff/


Testing
---

Manual testing.

Unit tests in succeeded.


Thanks,

Sebastian Toader

Re: Review Request 49080: Tez install failed

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49080/#review139052
---


Ship it!




Ship It!

- Dmytro Sen


On Июнь 22, 2016, 11:12 д.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49080/
> ---
> 
> (Updated Июнь 22, 2016, 11:12 д.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro 
> Sen.
> 
> 
> Bugs: AMBARI-17366
> https://issues.apache.org/jira/browse/AMBARI-17366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
>  File 
> "/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py",
>  line 49, in tez
> tez_env_file_path = os.path.join(config_dir, "tez-env.sh")
> NameError: global name 'os' is not defined
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
>  67e3c4f 
> 
> Diff: https://reviews.apache.org/r/49080/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 49080: Tez install failed

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49080/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.


Bugs: AMBARI-17366
https://issues.apache.org/jira/browse/AMBARI-17366


Repository: ambari


Description
---

{code}
 File 
"/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py",
 line 49, in tez
tez_env_file_path = os.path.join(config_dir, "tez-env.sh")
NameError: global name 'os' is not defined
{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
 67e3c4f 

Diff: https://reviews.apache.org/r/49080/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48722/
---

(Updated June 22, 2016, 1:10 p.m.)


Review request for Ambari, Andrew Onischuk, Laszlo Puskas, Robert Levas, Sandor 
Magyari, and Sumit Mohanty.


Changes
---

Reduce the amount of logs produced during the heartbeat handling in agent.


Bugs: AMBARI-17248
https://issues.apache.org/jira/browse/AMBARI-17248


Repository: ambari


Description
---

Commands to be executed by ambari-agents are being sent down by the server in 
the response message to agent heartbeat messages. 
The server processes the received heartbeat, it checks if there are next 
commands scheduled to be executed by ambari-agent and adds those to the 
heartbeat response for the ambari-agent.
The server organises the commands that can be executed in parallel into stages. 
Ambari server ensures that only the commands of a single stage is scheduled to 
be executed by the agent and starts scheduling the commands of the next stage 
only after all commands of current stage has finished successfully.
The processing of command status received with the heartbeat message happens 
asynchronously to heartbeat response in HeartBeatProcessor and ActionScheduler 
creation thus when the heartbeat response is created the commands for the next 
stage are not scheduled yet. This means that the next commands will be sent to 
agent only with the next heartbeat.
Agents currently sends a heartbeat to the server on command a completion or at 
a timeout = self.netutil.HEARTBEAT_IDDLE_INTERVAL_SEC – 
self.netutil.MINIMUM_INTERVAL_BETWEEN_HEARTBEATS interval which is ~10 seconds 
if there are no commands to be executed.
This means that when the server receives a heartbeat triggered by the 
completion of the last command from the current stage the server will send the 
commands for the next stage only 10 seconds later when the next heartbeat is 
received. This leads to agents spending considerable amount of time idle when 
there are multiple stages to be executed.
Agents should heartbeat at a higher rate while there are still pending stages 
to be executed.


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 8f2ab1b 
  ambari-agent/conf/unix/upgrade_agent_configs.py 583b5aa 
  ambari-agent/conf/windows/ambari-agent.ini df88be6 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 89a881a 
  ambari-agent/src/main/python/ambari_agent/Controller.py e981a76 
  ambari-agent/src/main/python/ambari_agent/Heartbeat.py 91098e0 
  ambari-agent/src/main/python/ambari_agent/NetUtil.py 80bf3ae 
  ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py f113083 
  ambari-agent/src/test/python/ambari_agent/TestNetUtil.py d72e319 
  ambari-agent/src/test/python/ambari_agent/examples/ControllerTester.py 
8103872 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 35a37e3 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
 1ab7ae9 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
ac0ddd2 
  ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
bd9de13 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 3d2388e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 c26e1e9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
 627ade9 

Diff: https://reviews.apache.org/r/48722/diff/


Testing
---

Manual testing.

Unit tests in succeeded.


Thanks,

Sebastian Toader

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139051
---



- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  24f6938 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  759c0f3 

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Sreenath Somarajapuram]

> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.

"versions-table-wrap is used for styling and styles are defined in 
application.less" > Can you share the line number in application.less?


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> 

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139046
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 43)


Where is isNotOperator used?



contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js (line 290)


Where is the values of store passed?


- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Akhil PB]

> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?

versionPanel.hbs itself is a new file and class "versions-table-wrap" is used 
for styling and styles are defined in application.less.
views/queues.js would not break since queues.js uses above as id and 
versionPanel uses as class name.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> 

Review Request 49078: AMBARI-17363: Enable Ranger support for Hive Interactive

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49078/
---

Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, Sumit Mohanty, 
Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17363
https://issues.apache.org/jira/browse/AMBARI-17363


Repository: ambari


Description
---

Make config and stack changes for Hive Interactive to use Ranger authorizer 
when Ranger Hive Plugin is enabled


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 d1c8401 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive_interactive.py
 PRE-CREATION 

Diff: https://reviews.apache.org/r/49078/diff/


Testing
---

Tested by enabling ranger plugin with hive interactive on a centos 3 node 
cluster.


Thanks,

Gautam Borad

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
 (line 25)


Trailing space must be removed.



contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js (line 290)


Technically, store must be a generic implementation without any 
entity/model specific code.
But as this is existing code, guess there is no other alternative.



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 (line 26)


Where is the versions-table-wrap class defined?
Wouldnt it cause the views/queues.js code to break?


- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> 

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Sreenath Somarajapuram]

> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, 
> > line 164
> > 
> >
> > Why are we having the + after ?
> 
> Akhil PB wrote:
> Converting string number to integer number.
> 
> Akhil PB wrote:
> + is for properties[cp]. ie +properties[cp]

Would have been better to use parseFloat. But as it is from an old code, lets 
leave it for the time being.


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> 

Re: Review Request 49077: Could not download Atlas Client configs

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49077/#review139039
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 22, 2016, 9:16 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49077/
> ---
> 
> (Updated Червень 22, 2016, 9:16 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17361
> https://issues.apache.org/jira/browse/AMBARI-17361
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Seen while helping QE to debug the issue. The problem is caused by incorrect
> xml configs in metainfo.xml of Atlas service and should be not hard to fix.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> 84db070 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> 195eb7b 
> 
> Diff: https://reviews.apache.org/r/49077/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 49077: Could not download Atlas Client configs

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49077/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-17361
https://issues.apache.org/jira/browse/AMBARI-17361


Repository: ambari


Description
---

Seen while helping QE to debug the issue. The problem is caused by incorrect
xml configs in metainfo.xml of Atlas service and should be not hard to fix.


Diffs
-

  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
84db070 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
195eb7b 

Diff: https://reviews.apache.org/r/49077/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Akhil PB]

> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, 
> > line 164
> > 
> >
> > Why are we having the + after ?
> 
> Akhil PB wrote:
> Converting string number to integer number.

+ is for properties[cp]. ie +properties[cp]


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> 

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Akhil PB]

> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, 
> > line 164
> > 
> >
> > Why are we having the + after ?

Converting string number to integer number.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> 

Re: Review Request 49032: Hive metastore failed to start

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49032/#review139035
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 21, 2016, 7:28 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49032/
> ---
> 
> (Updated June 21, 2016, 7:28 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17345
> https://issues.apache.org/jira/browse/AMBARI-17345
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1) Add Hive Metastore on hosts that do not have it
> 2) Restart services with stale configs
> It started fine on retrying
> 
> {code}
> ERROR: Unable to connect to the DB. Please check DB connection 
> properties.\njava.lang.ClassNotFoundException: 
> oracle.jdbc.driver.OracleDriver\n2016-06-20 13:18:14,206 - Retrying after 10 
> seconds. Reason: Execution of '/usr/jdk64/jdk1.8.0_77/bin/java -cp 
> /usr/lib/ambari-agent/DBConnectionVerification.jar:/usr/hdp/current/hive-metastore/lib/ojdbc6.jar
>  org.apache.ambari.server.DBConnectionVerification 
> 'jdbc:oracle:thin:@//172.22.124.192:1521/XE' hiveuser [PROTECTED] 
> oracle.jdbc.driver.OracleDriver' returned 1. ERROR: Unable to connect to the 
> DB. Please check DB connection properties.\njava.lang.ClassNotFoundException:
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  30cc942 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6a53dca 
> 
> Diff: https://reviews.apache.org/r/49032/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 49028: Alert mapreduce_history_server_process fails after enabling SSL

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49028/#review139034
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 21, 2016, 6:40 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49028/
> ---
> 
> (Updated June 21, 2016, 6:40 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-17340
> https://issues.apache.org/jira/browse/AMBARI-17340
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove mapreduce_history_server_process , it duplicates 
> mapreduce_history_server_webui
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  1b71230 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json 
> 8561922 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  3eea4d3 
> 
> Diff: https://reviews.apache.org/r/49028/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js (line 
164)


Why are we having the + after ?


- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
>  PRE-CREATION 
>   
> 

Re: Review Request 48950: Pig View- Show actual error message thrown by webhcat api

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48950/
---

(Updated June 22, 2016, 7:13 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Updating patch as suggested


Bugs: AMBARI-17310
https://issues.apache.org/jira/browse/AMBARI-17310


Repository: ambari


Description
---

Added Error handling for the rest call.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
 5e0f3fa 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java
 c3bd504 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/JSONRequest.java
 39a595b 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/ServiceFormattedException.java
 7b57bb2 
  contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/JobTest.java 
f619848 

Diff: https://reviews.apache.org/r/48950/diff/


Testing
---

Manually Tested


Thanks,

Gaurav Nagar

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

[Prajwal Rao]

> On June 22, 2016, 6:32 a.m., Prajwal Rao wrote:
> > Ship It!

Datasource changes look good to me.


- Prajwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48395/#review139022
---


On June 22, 2016, 2:09 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48395/
> ---
> 
> (Updated June 22, 2016, 2:09 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Prajwal Rao, 
> Sriharsha Chintalapani, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17027
> https://issues.apache.org/jira/browse/AMBARI-17027
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS doesn't provide tag so metric is identified by appId, metric name, 
> hostname, instanceId. In this situation metric name is normally consist of 
> origin metric name and tag values, like graphite, but unlike Graphite, AMS 
> also doesn't provide series aggregation functions so aggregation should be 
> done from caller side.
> 
> It would be great if Ambari Metrics Collector provides series aggregation 
> functions, like sumSeries / 
> averageSeries / minSeries / maxSeries on Graphite.
> 
> Query outputs: 
> https://gist.github.com/HeartSaVioR/f4f28b5b8b7bf2e5477e59d7fd56090f
> 
> Attached Grafana screenshots to AMBARI-17027. Please refer 
> https://issues.apache.org/jira/browse/AMBARI-17027 for details.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js b825774 
>   
> ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html
>  b034c03 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js 2eb3613 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  1b2d02f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  e37bc4d 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java
>  7d49070 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/SeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionFactory.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAvgAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMaxAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMinAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesSumAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  ee3a097 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  cfd1f58 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java
>  a94f4c5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48395/diff/
> 
> 
> Testing
> 

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

[Prajwal Rao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48395/#review139022
---


Ship it!




Ship It!

- Prajwal Rao


On June 22, 2016, 2:09 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48395/
> ---
> 
> (Updated June 22, 2016, 2:09 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Prajwal Rao, 
> Sriharsha Chintalapani, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17027
> https://issues.apache.org/jira/browse/AMBARI-17027
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS doesn't provide tag so metric is identified by appId, metric name, 
> hostname, instanceId. In this situation metric name is normally consist of 
> origin metric name and tag values, like graphite, but unlike Graphite, AMS 
> also doesn't provide series aggregation functions so aggregation should be 
> done from caller side.
> 
> It would be great if Ambari Metrics Collector provides series aggregation 
> functions, like sumSeries / 
> averageSeries / minSeries / maxSeries on Graphite.
> 
> Query outputs: 
> https://gist.github.com/HeartSaVioR/f4f28b5b8b7bf2e5477e59d7fd56090f
> 
> Attached Grafana screenshots to AMBARI-17027. Please refer 
> https://issues.apache.org/jira/browse/AMBARI-17027 for details.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js b825774 
>   
> ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html
>  b034c03 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js 2eb3613 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  1b2d02f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  e37bc4d 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java
>  7d49070 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/SeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionFactory.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAvgAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMaxAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMinAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesSumAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  ee3a097 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  cfd1f58 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java
>  a94f4c5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48395/diff/
> 
> 
> Testing
> ---
> 
> > mvn clean install
> 
> > cd ambari-metrics
> 
> > mvn test
> 

Re: Review Request 49012: AMBARI-17330 Ambari changes to support kerberized Ranger tagsync

[Mugdha Varadkar]

> On June 21, 2016, 2:31 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json,
> >  lines 114-122
> > 
> >
> > This should go into a Jinja2 template file, which is comon practice for 
> > JAAS files.  See 
> > https://github.com/apache/ambari/blob/10ad39cfd87a2f11bdfbc3470fdf112bf1d83c1c/ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/templates/zookeeper_jaas.conf.j2

I have kept this logic to match with manual install of Ranger TagSync, there 
also we are not using jaas file format. The above properties need to get 
updated in 'atlas-application.properties'.

Below is the code logic handled from Ambari:
PropertiesFile(format('{ranger_tagsync_conf}/atlas-application.properties'),
properties = params.tagsync_application_properties,
mode=0755,
owner=params.unix_user,
group=params.unix_group
)

where params.tagsync_application_properties = 
dict(config["configurations"]["tagsync-application-properties"])


> On June 21, 2016, 2:31 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py,
> >  line 287
> > 
> >
> > The lower-case form of `current_host` should be forced - 
> > `current_host.lower()`

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49012/#review138836
---


On June 22, 2016, 6:30 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49012/
> ---
> 
> (Updated June 22, 2016, 6:30 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Robert Levas, Srimanth Gunturi, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17330
> https://issues.apache.org/jira/browse/AMBARI-17330
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove below properties from ranger-tagsync-site.xml:
> - ranger.tagsync.atlas.to.ranger.service.mapping
> - ranger.tagsync.atlas.custom.resource.mappers
> 
> Add below property in ranger-tagsync-site.xml:
> - ranger.tagsync.source.atlasrest.username (default - empty)
> 
> Add below properties in tagsync-application-properties.xml only if cluster is 
> kerberized:
> - 
> atlas.jaas.KafkaClient.loginModuleName=com.sun.security.auth.module.Krb5LoginModule
> - atlas.jaas.KafkaClient.loginModuleControlFlag=required
> - atlas.jaas.KafkaClient.option.useKeyTab=true
> - atlas.jaas.KafkaClient.option.storeKey=true
> - atlas.jaas.KafkaClient.option.serviceName=kafka
> - atlas.jaas.KafkaClient.option.keyTab=tagsync_keytab_path
> - atlas.jaas.KafkaClient.option.principal=tagsync_jaas_principal
> - atlas.kafka.sasl.kerberos.service.name=kafka
> - atlas.kafka.security.protocol=SASL_PLAINTEXT
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  9e0fb7c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
>  c5a575d 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> cd34cd9 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  61bdce0 
> 
> Diff: https://reviews.apache.org/r/49012/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation on centos 6 in secure env
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49012: AMBARI-17330 Ambari changes to support kerberized Ranger tagsync

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49012/
---

(Updated June 22, 2016, 6:30 a.m.)


Review request for Ambari, Gautam Borad, Robert Levas, Srimanth Gunturi, and 
Velmurugan Periasamy.


Changes
---

Handle Robert Levas comment


Bugs: AMBARI-17330
https://issues.apache.org/jira/browse/AMBARI-17330


Repository: ambari


Description
---

Remove below properties from ranger-tagsync-site.xml:
- ranger.tagsync.atlas.to.ranger.service.mapping
- ranger.tagsync.atlas.custom.resource.mappers

Add below property in ranger-tagsync-site.xml:
- ranger.tagsync.source.atlasrest.username (default - empty)

Add below properties in tagsync-application-properties.xml only if cluster is 
kerberized:
- 
atlas.jaas.KafkaClient.loginModuleName=com.sun.security.auth.module.Krb5LoginModule
- atlas.jaas.KafkaClient.loginModuleControlFlag=required
- atlas.jaas.KafkaClient.option.useKeyTab=true
- atlas.jaas.KafkaClient.option.storeKey=true
- atlas.jaas.KafkaClient.option.serviceName=kafka
- atlas.jaas.KafkaClient.option.keyTab=tagsync_keytab_path
- atlas.jaas.KafkaClient.option.principal=tagsync_jaas_principal
- atlas.kafka.sasl.kerberos.service.name=kafka
- atlas.kafka.security.protocol=SASL_PLAINTEXT


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 9e0fb7c 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
 c5a575d 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
cd34cd9 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 61bdce0 

Diff: https://reviews.apache.org/r/49012/diff/


Testing
---

Tested Ranger installation on centos 6 in secure env


Thanks,

Mugdha Varadkar

Re: Review Request 48950: Pig View- Show actual error message thrown by webhcat api

[Nitiraj Rathore]

> On June 21, 2016, 7:12 a.m., Nitiraj Rathore wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java,
> >  line 123
> > 
> >
> > is this path being passed just for logging purpose?
> 
> Gaurav Nagar wrote:
> yes. Path is passed for logging.

I don't think its right thing to pass a parameter for logging. I think it 
should be removed.


- Nitiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48950/#review138794
---


On June 20, 2016, 12:30 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48950/
> ---
> 
> (Updated June 20, 2016, 12:30 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17310
> https://issues.apache.org/jira/browse/AMBARI-17310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added Error handling for the rest call.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
>  5e0f3fa 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java
>  c3bd504 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/JSONRequest.java
>  39a595b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/ServiceFormattedException.java
>  7b57bb2 
>   
> contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/JobTest.java 
> f619848 
> 
> Diff: https://reviews.apache.org/r/48950/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>