Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

[Madhuvanthi Radhakrishnan]

> On May 2, 2017, 8:07 p.m., Jonathan Hurley wrote:
> > What's the state of this review? Seems like it's been dormant for a week...

Hi Jonathan,
This patch was scraped for 2.5.1 since the changes were made in the HDF mpack 
instead. But we do want to keep this approach open for discussion for 3.0.0


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58489/#review173637
---


On April 19, 2017, 7:29 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> ---
> 
> (Updated April 19, 2017, 7:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20775
> https://issues.apache.org/jira/browse/AMBARI-20775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All the commands.json files should always contain the versionAdvertised 
> field. If versionAdvertised is not set in command.json then we should assume 
> that versionAdvertised=False when calling stack_tools.py
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
>  463d61f53d 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  93ec0b74f5 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 2c441ad5a0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcbd2a 
>   
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json
>  c6575b51a7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 
> ab5e2cdaf9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 
> 0b5ba6a0ba 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 
> 1550715d72 
>   ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 
> 013bb8b8d2 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 
> 7ded3a01e1 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 
> 7a29ea0c0d 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 
> a9db11c645 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 
> fb561f74f3 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 
> 86ca03a4a3 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> cbe8ebeb15 
>   
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
> dc4c43b9e0 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json 
> 0da58ce2a5 
> 
> 
> Diff: https://reviews.apache.org/r/58489/diff/3/
> 
> 
> Testing
> ---
> 
> Tested for service actions:
> Start
> Stop
> Restart
> Reconfigure
> Service Check
> Enable HA
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58933: AMBARI-20913 : Grafana LLAP overview dashboard showing incorrect metrics

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58933/#review173658
---


Ship it!




Ship It!

- Sid Wagle


On May 2, 2017, 9:43 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58933/
> ---
> 
> (Updated May 2, 2017, 9:43 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20913
> https://issues.apache.org/jira/browse/AMBARI-20913
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> On a 4 node LLAP cluster grafana "LLAP Overview" dashboard shows incorrect 
> data. The metric seems to have been multiplied by a factor of 10.
> 
> BUG
> This issue had been fixed in the V2 aggregation mechanism (Phoenix server 
> side aggregation) through AMBARI-15638. It was missed out on the V1 mechanism 
> of aggregation where the data is read into the Metrics Collector and manual 
> client side aggregation is done.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java
>  02677b9 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/ITClusterAggregator.java
>  590f82a 
> 
> 
> Diff: https://reviews.apache.org/r/58933/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test on ambari-metrics
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 58933: AMBARI-20913 : Grafana LLAP overview dashboard showing incorrect metrics

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58933/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-20913
https://issues.apache.org/jira/browse/AMBARI-20913


Repository: ambari


Description
---

PROBLEM
On a 4 node LLAP cluster grafana "LLAP Overview" dashboard shows incorrect 
data. The metric seems to have been multiplied by a factor of 10.

BUG
This issue had been fixed in the V2 aggregation mechanism (Phoenix server side 
aggregation) through AMBARI-15638. It was missed out on the V1 mechanism of 
aggregation where the data is read into the Metrics Collector and manual client 
side aggregation is done.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java
 02677b9 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/ITClusterAggregator.java
 590f82a 


Diff: https://reviews.apache.org/r/58933/diff/1/


Testing
---

mvn clean test on ambari-metrics
Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 58911: HDP 3.0 TP - Unable to install Spark, cannot find package/scripts dir

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58911/#review173652
---


Ship it!




Ship It!

- Sid Wagle


On May 2, 2017, 2:28 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58911/
> ---
> 
> (Updated May 2, 2017, 2:28 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20910
> https://issues.apache.org/jira/browse/AMBARI-20910
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> * Install Ambari 3.0 (last build was 650)
> * Install HDP 3.0 (last build is 197) with ZK, HDFS, YARN. Note: will fail on 
> RM and Service Checks.
> * Because Hive is not yet compiling, temporarily comment out Hive as a 
> required service for Spark, and HIVE_METASTORE as a required co-hosted 
> component.
> /var/lib/ambari-server/resources/common-services/SPARK/2.2.0/metainfo.xml
> * Restart Ambari Server
> * Attempt to add Spark as a service.
> 
> Error:
> ```
> Caught an exception while executing custom service command:  'exceptions.KeyError'>: 'service_package_folder'; 'service_package_folder'
> ```
> 
> This is coming from CustomServiceOrchestrator.py
> ```
> except Exception, e: # We do not want to let agent fail completely
>   exc_type, exc_obj, exc_tb = sys.exc_info()
>   message = "Caught an exception while executing "\
> "custom service command: {0}: {1}; {2}".format(exc_type, exc_obj, 
> str(e))
>   logger.exception(message)
> ```
> 
> Looks like Spark 2.2.0 doesn't have the package/scripts directory.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/setup_spark.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/spark_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/spark_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/spark_thrift_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/job_history_server.py
>  3937c88 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/livy_server.py
>  269c97d 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/livy_service.py
>  45201db 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/params.py
>  e60cab5 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/service_check.py
>  518c624 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/setup_livy.py
>  adaca87 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/setup_spark.py
>  9329ce0 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_client.py
>  3acde4e 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_service.py
>  536d798 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_thrift_server.py
>  8953b35 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/status_params.py
>  07dcc47 
> 
> 
> Diff: https://reviews.apache.org/r/58911/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test. Verified on a live cluster.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 58823: Trunk patch - Storm Log4J Regex Replacement on Upgrade Fails

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58823/#review173648
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 27, 2017, 11:14 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58823/
> ---
> 
> (Updated April 27, 2017, 11:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20880
> https://issues.apache.org/jira/browse/AMBARI-20880
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since there were changes made to trunk patch for storm worker log directory 
> and not to branch-2.5. There are some extra fixes required in this patch. 
> With this, both 2.5 and trunk will be on same page w.r.t upgrade packs for 
> storm.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  5c0fba7fc6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> ffa8e61f25 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  44367dcc47 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  9362ae6b87 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 698195502b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 0440dd3148 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> f99e764cc2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  3a428765fa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  b812547100 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 50346274ea 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> fbd61eae5a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 1c2ceff053 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  be8b750597 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 210c4e2d39 
> 
> 
> Diff: https://reviews.apache.org/r/58823/diff/1/
> 
> 
> Testing
> ---
> 
> branch2.5 Ref: https://reviews.apache.org/r/58815/
> Total run:1169
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:47 min
> [INFO] Finished at: 2017-04-27T15:42:48-07:00
> [INFO] Final Memory: 71M/1001M
> [INFO] 
> 
> :ambari-server mradhakrishnan$
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58840: AMBARI-20886. Create idempotent Ambari DB Schema SQL script for AzureDB

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58840/#review173647
---


Ship it!




Ship It!

- Jonathan Hurley


On May 2, 2017, 3:24 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58840/
> ---
> 
> (Updated May 2, 2017, 3:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, 
> Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20886
> https://issues.apache.org/jira/browse/AMBARI-20886
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Based on existing SQL Server script generate at compile-time for AzureDB a 
> SQL script that:
>  * runs CREATE TABLE, CREATE INDEX and ADD CONSTRAINT statements only if the 
> objects do not exist yet,
>  * DELETEs rows before running INSERT statements.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml da1f09eceb999650c33729120b6959462445a115 
>   ambari-server/src/main/assemblies/server.xml 
> 51ee14e0bc215ba2fdad24112c7c0ab3ff2d1189 
>   ambari-server/src/main/python/azuredb_create_generator.py PRE-CREATION 
>   ambari-server/src/main/resources/.gitignore PRE-CREATION 
>   ambari-server/src/main/sh/azuredb_create_generator.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58840/diff/5/
> 
> 
> Testing
> ---
> 
> Tested with Microsoft SQL Server on Linux using Docker:
> 
> ```
> $ mvn -q -pl ambari-server clean generate-resources
> $ export MSSQL_PASSWORD='hVn?1AY6b\l&'
> $ docker run -e 'ACCEPT_EULA=Y' -e "SA_PASSWORD=$MSSQL_PASSWORD" --name mssql 
> -p 1433:1433 -v $(PWD):/tmp/ambari -d microsoft/mssql-server-linux
> ba7ad59f747eac75e696cbab8ed7f30af0c98dc81250ee393ebf0e01e71f2965
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD"
> 1> select count(*) from sys.objects;
> 2> go
> 
> ---
> 107
> 
> (1 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD" -i 
> /tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-AzureDB-CREATE.sql
> 
> (0 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD"
> 1> select count(*) from sys.objects;
> 2> go
> 
> ---
> 525
> 
> (1 rows affected)
> 1> select count(*) from ambari_sequences;
> 2> go
> 
> ---
>  54
> 
> (1 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD" -i 
> /tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-AzureDB-CREATE.sql
> 
> (1 rows affected)
> 
> (1 rows affected)
> 
> (184 rows affected)
> 
> (53 rows affected)
> 
> (7 rows affected)
> 
> (1 rows affected)
> 
> (8 rows affected)
> 
> (3 rows affected)
> 
> (1 rows affected)
> 
> (3 rows affected)
> 
> (54 rows affected)
> 
> (54 rows affected)
> 
> (3 rows affected)
> 
> (1 rows affected)
> 
> (3 rows affected)
> 
> (8 rows affected)
> 
> (1 rows affected)
> 
> (7 rows affected)
> 
> (53 rows affected)
> 
> (1 rows affected)
> 
> (14 rows affected)
> 
> (19 rows affected)
> 
> (24 rows affected)
> 
> (31 rows affected)
> 
> (42 rows affected)
> 
> (53 rows affected)
> 
> (1 rows affected)
> 
> (1 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD"
> 1> select count(*) from sys.objects;
> 2> go
> 
> ---
> 525
> 
> (1 rows affected)
> 1> select count(*) from ambari_sequences;
> 2> go
> 
> ---
>  54
> 
> (1 rows affected)
> 
> $ docker rm -f mssql
> mssql
> $ docker run -e 'ACCEPT_EULA=Y' -e "SA_PASSWORD=$MSSQL_PASSWORD" --name mssql 
> -p 1433:1433 -v $(PWD):/tmp/ambari -d microsoft/mssql-server-linux
> 5dfdd09a70b76f5cd9716fff94680b758c92f3850b227c0c274eea800bdf3402
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD" -i 
> /tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
> 
> (54 rows affected)
> 
> (3 rows affected)
> 
> (1 rows affected)
> 
> (3 rows affected)
> 
> (8 rows affected)
> 
> (1 rows affected)
> 
> (7 rows affected)
> 
> (53 rows affected)
> 
> (1 rows affected)
> 
> (14 rows affected)
> 
> (19 rows affected)
> 
> (24 rows affected)
> 
> (31 rows affected)
> 
> (42 rows affected)
> 
> (53 rows affected)
> 
> (1 rows affected)
> 
> (1 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD"
> 1> select count(*) from sys.objects;
> 2> go
> 
> ---
> 525
> 
> (1 rows affected)
> 1> select count(*) from ambari_sequences;
> 2> go
> 
> ---
>  54
> 
> (1 rows affected)
> ```
> 
> 
> Thanks,
> 
> Attila 

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Jonathan Hurley]

> On May 2, 2017, 3:59 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
> > Lines 299 (patched)
> > 
> >
> > try_count ?

Or maybe consecutive_failures


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173633
---


On May 2, 2017, 3:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 3:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58823: Trunk patch - Storm Log4J Regex Replacement on Upgrade Fails

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58823/#review173641
---


Ship it!




Ship It!

- Jonathan Hurley


On April 27, 2017, 7:14 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58823/
> ---
> 
> (Updated April 27, 2017, 7:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20880
> https://issues.apache.org/jira/browse/AMBARI-20880
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since there were changes made to trunk patch for storm worker log directory 
> and not to branch-2.5. There are some extra fixes required in this patch. 
> With this, both 2.5 and trunk will be on same page w.r.t upgrade packs for 
> storm.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  5c0fba7fc6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> ffa8e61f25 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  44367dcc47 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  9362ae6b87 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 698195502b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 0440dd3148 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> f99e764cc2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  3a428765fa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  b812547100 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 50346274ea 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> fbd61eae5a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 1c2ceff053 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  be8b750597 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 210c4e2d39 
> 
> 
> Diff: https://reviews.apache.org/r/58823/diff/1/
> 
> 
> Testing
> ---
> 
> branch2.5 Ref: https://reviews.apache.org/r/58815/
> Total run:1169
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:47 min
> [INFO] Finished at: 2017-04-27T15:42:48-07:00
> [INFO] Final Memory: 71M/1001M
> [INFO] 
> 
> :ambari-server mradhakrishnan$
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Nate Cole]

> On May 2, 2017, 3:58 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 296 (patched)
> > 
> >
> > Oracle 12 allows more than 30 characters for db objects; this name may 
> > be pushing it :)

I should say Oracle 12 allows longer names, but 11 and lower are limited to 30.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173630
---


On May 2, 2017, 3:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 3:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173631
---



FYI see https://reviews.apache.org/r/58840/ for a way to smoke-test the 
SQLServer DB script using Docker.


ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
Line 1160 (original), 1172 (patched)


Column `user_password` is being removed in this patch, so this insert will 
fail.  Based on the next 2 inserts I guess it should be removed.

(Also please adjust the indentation for the 2 new inserts.)



ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
Lines 1179 (patched)


I'm getting

```
Implicit conversion from data type varchar to varbinary(max) is not 
allowed. Use the CONVERT function to run this query.
```

for this insert.


- Attila Doroszlai


On May 2, 2017, 9:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 9:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58489/#review173637
---



What's the state of this review? Seems like it's been dormant for a week...

- Jonathan Hurley


On April 19, 2017, 3:29 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> ---
> 
> (Updated April 19, 2017, 3:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20775
> https://issues.apache.org/jira/browse/AMBARI-20775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All the commands.json files should always contain the versionAdvertised 
> field. If versionAdvertised is not set in command.json then we should assume 
> that versionAdvertised=False when calling stack_tools.py
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
>  463d61f53d 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  93ec0b74f5 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 2c441ad5a0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcbd2a 
>   
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json
>  c6575b51a7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 
> ab5e2cdaf9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 
> 0b5ba6a0ba 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 
> 1550715d72 
>   ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 
> 013bb8b8d2 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 
> 7ded3a01e1 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 
> 7a29ea0c0d 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 
> a9db11c645 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 
> fb561f74f3 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 
> 86ca03a4a3 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> cbe8ebeb15 
>   
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
> dc4c43b9e0 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json 
> 0da58ce2a5 
> 
> 
> Diff: https://reviews.apache.org/r/58489/diff/3/
> 
> 
> Testing
> ---
> 
> Tested for service actions:
> Start
> Stop
> Restart
> Reconfigure
> Service Check
> Enable HA
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Robert Levas]

> On May 2, 2017, 3:58 p.m., Nate Cole wrote:
> > I'm assuming UpgradeCatalog changes are coming?

Yes... since I am doing this in a feature branch, I thought making really small 
patches would be ok.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173630
---


On May 2, 2017, 3:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 3:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58857: Setting Desired Stack Ids to Correct Values During Service and Patch Upgrades

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58857/
---

(Updated May 2, 2017, 4:04 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
Lisnichenko, and Nate Cole.


Bugs: AMBARI-20894
https://issues.apache.org/jira/browse/AMBARI-20894


Repository: ambari


Description
---

Long story short here is that this is the first major breaking change for 
supporting service/patch upgrades. Some highlights:
- Services and components will now track their "desired repository"
- The cluster_version is deprecated and I've removed the use of it in many 
places in order to get this compiling. It will be further removed by a future 
commit
- The host components are now compared to their components to verify if the 
upgrade has succeeded
- Some things are still very wrong
-- I have about 300 unit test compile errors. Once I fix those, I'm sure they 
will all fail. It's something we plan to fix in iterations as more code is 
changed to support service and patch
-- There are DDL changes here; we will do the work to upgrade the database in a 
separate Jira
-- Lots of useless code has been removed
-- The python code still doesn't understand per-component versions; that is a 
follow-up Jira.

Please review and keep in mind that many areas are partially complete since 
there are many other Jiras tracking this work. That's why it's in a feature 
branch :)


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
da47351 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 c1028dc 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
 7dfbe47 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 b2a03e4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 04b72ea 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
 5b6c739 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
 f6993f8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 c3e66fc 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 ff8d0be 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
 46e791b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 6556852 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 623851a 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 abf8e6b 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
 930a535 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
 ea2938b 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
 0b3d8ce 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
 4ed9617 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
 17fd323 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
 885f995 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
 5b65833 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java
 5d73fac 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java
 52c0cf2 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 32d6151 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
 7bcb9d0 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
1ef204d 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
5964e33 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 b5b6821 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
 104e456 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 4cfb250 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java 
a3a041b 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
a0c0db1 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173633
---




ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
Lines 299 (patched)


try_count ?


- Nate Cole


On May 2, 2017, 3:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 3:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173630
---


Fix it, then Ship it!




I'm assuming UpgradeCatalog changes are coming?


ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 284-286 (original), 283-294 (patched)


We usually use BIGINTs for timestamps.  I seem to recall JPA mapping these 
differently for db types.



ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 296 (patched)


Oracle 12 allows more than 30 characters for db objects; this name may be 
pushing it :)


- Nate Cole


On May 2, 2017, 3:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 3:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173629
---




ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 279 (patched)


Typo in "attempts"



ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
Lines 1178 (patched)


Add a comment for the value that was hashed.


- Alejandro Fernandez


On May 2, 2017, 7:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 7:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58886: Smartsense view do not load and shows blank

[Nitiraj Rathore]

> On May 1, 2017, 6:59 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
> > Lines 186 (patched)
> > 
> >
> > Why does the cluster ID change?
> > If that's the root cause, we should fix that instead.
> 
> Nitiraj Rathore wrote:
> So I think if the cluster install fails because of some reason. A 
> reattempt from UI is done and at that time the cluster id is changed. But 
> this change is not propogated to ViewRegistry and it does not delete already 
> created auto view instances or changes their cluster id.
> Yes this solution is not elegant. Although this bug is rare but when it 
> comes it creates problems even in correcting the views from the UI. And so 
> the severity of the bug is high.
> I think a better solution would be to fire one event like 
> "ClusterDeleted" which will be picked up by ViewRegistry and it will delete 
> the views which were created for that cluster id.
> Auto instances will again get created with new cluster id. This solution 
> might take more time to implement as it touches more surface.
> We will log another bug for this change. But the current patch handles 
> the sitution and keeps ambari and views properly running.
> 
> Alejandro Fernandez wrote:
> I'm on the fence about adding code that works around an existing bug, 
> especially since the root-cause may lead to other areas that need similar 
> logic.
> Instead, I think it's better to reuse the existing cluster object 
> (especially if the name coincides with an entity that already exists).
> Furthermore, if a cluster is deleted, shouldn't the views have FKs to the 
> cluster_id so that you can't have orphan views?
> 
> Let's come up with a correct way of fixing this.

ok


- Nitiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58886/#review173490
---


On May 2, 2017, 8:11 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58886/
> ---
> 
> (Updated May 2, 2017, 8:11 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20905
> https://issues.apache.org/jira/browse/AMBARI-20905
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If installation fails and is retried the cluster id changes but some view 
> instances keep older cluster ids which stop views from being displayed later 
> on.
> remove the view instances which contains invalid cluster id before creating 
> any autoview instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
>  061c7223d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  b632c54043 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 24eceb21c6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
>  25afe92ce4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java
>  8836af6ead 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  a3728d46b3 
> 
> 
> Diff: https://reviews.apache.org/r/58886/diff/2/
> 
> 
> Testing
> ---
> 
> updated testcases where ever needed. Manual testing also done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58840: AMBARI-20886. Create idempotent Ambari DB Schema SQL script for AzureDB

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58840/
---

(Updated May 2, 2017, 9:24 p.m.)


Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, 
Sumit Mohanty, Sebastian Toader, and Sid Wagle.


Changes
---

* add overview comment in Python script
* make re.sub calls more readable by using multi-line strings


Bugs: AMBARI-20886
https://issues.apache.org/jira/browse/AMBARI-20886


Repository: ambari


Description
---

Based on existing SQL Server script generate at compile-time for AzureDB a SQL 
script that:
 * runs CREATE TABLE, CREATE INDEX and ADD CONSTRAINT statements only if the 
objects do not exist yet,
 * DELETEs rows before running INSERT statements.


Diffs (updated)
-

  ambari-server/pom.xml da1f09eceb999650c33729120b6959462445a115 
  ambari-server/src/main/assemblies/server.xml 
51ee14e0bc215ba2fdad24112c7c0ab3ff2d1189 
  ambari-server/src/main/python/azuredb_create_generator.py PRE-CREATION 
  ambari-server/src/main/resources/.gitignore PRE-CREATION 
  ambari-server/src/main/sh/azuredb_create_generator.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/58840/diff/5/

Changes: https://reviews.apache.org/r/58840/diff/4-5/


Testing
---

Tested with Microsoft SQL Server on Linux using Docker:

```
$ mvn -q -pl ambari-server clean generate-resources
$ export MSSQL_PASSWORD='hVn?1AY6b\l&'
$ docker run -e 'ACCEPT_EULA=Y' -e "SA_PASSWORD=$MSSQL_PASSWORD" --name mssql 
-p 1433:1433 -v $(PWD):/tmp/ambari -d microsoft/mssql-server-linux
ba7ad59f747eac75e696cbab8ed7f30af0c98dc81250ee393ebf0e01e71f2965
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD"
1> select count(*) from sys.objects;
2> go

---
107

(1 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD" -i 
/tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-AzureDB-CREATE.sql

(0 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD"
1> select count(*) from sys.objects;
2> go

---
525

(1 rows affected)
1> select count(*) from ambari_sequences;
2> go

---
 54

(1 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD" -i 
/tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-AzureDB-CREATE.sql

(1 rows affected)

(1 rows affected)

(184 rows affected)

(53 rows affected)

(7 rows affected)

(1 rows affected)

(8 rows affected)

(3 rows affected)

(1 rows affected)

(3 rows affected)

(54 rows affected)

(54 rows affected)

(3 rows affected)

(1 rows affected)

(3 rows affected)

(8 rows affected)

(1 rows affected)

(7 rows affected)

(53 rows affected)

(1 rows affected)

(14 rows affected)

(19 rows affected)

(24 rows affected)

(31 rows affected)

(42 rows affected)

(53 rows affected)

(1 rows affected)

(1 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD"
1> select count(*) from sys.objects;
2> go

---
525

(1 rows affected)
1> select count(*) from ambari_sequences;
2> go

---
 54

(1 rows affected)

$ docker rm -f mssql
mssql
$ docker run -e 'ACCEPT_EULA=Y' -e "SA_PASSWORD=$MSSQL_PASSWORD" --name mssql 
-p 1433:1433 -v $(PWD):/tmp/ambari -d microsoft/mssql-server-linux
5dfdd09a70b76f5cd9716fff94680b758c92f3850b227c0c274eea800bdf3402
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD" -i 
/tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql

(54 rows affected)

(3 rows affected)

(1 rows affected)

(3 rows affected)

(8 rows affected)

(1 rows affected)

(7 rows affected)

(53 rows affected)

(1 rows affected)

(14 rows affected)

(19 rows affected)

(24 rows affected)

(31 rows affected)

(42 rows affected)

(53 rows affected)

(1 rows affected)

(1 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD"
1> select count(*) from sys.objects;
2> go

---
525

(1 rows affected)
1> select count(*) from ambari_sequences;
2> go

---
 54

(1 rows affected)
```


Thanks,

Attila Doroszlai

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review173621
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 17, 2017, 12:40 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated April 17, 2017, 12:40 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f56617 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/3/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12863418/AMBARI-20443.3.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> 
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> 
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11398//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11398//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/#review173620
---




ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
Line 85 (original), 85 (patched)


I'm not familiar enough with Kafka to comment on this.


- Alejandro Fernandez


On May 2, 2017, 5:28 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58927/
> ---
> 
> (Updated May 2, 2017, 5:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20908
> https://issues.apache.org/jira/browse/AMBARI-20908
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  680dd32 
> 
> 
> Diff: https://reviews.apache.org/r/58927/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with default installation and added advertised.listeners
> and enabled kerberos and then checked advertised.listeners to see if it is 
> same as user provided.
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 58840: AMBARI-20886. Create idempotent Ambari DB Schema SQL script for AzureDB

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58840/#review173618
---


Fix it, then Ship it!





ambari-server/src/main/python/azuredb_create_generator.py
Lines 24 (patched)


Add some documentation for what this file is supposed to do


- Alejandro Fernandez


On May 2, 2017, 10:09 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58840/
> ---
> 
> (Updated May 2, 2017, 10:09 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, 
> Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20886
> https://issues.apache.org/jira/browse/AMBARI-20886
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Based on existing SQL Server script generate at compile-time for AzureDB a 
> SQL script that:
>  * runs CREATE TABLE, CREATE INDEX and ADD CONSTRAINT statements only if the 
> objects do not exist yet,
>  * DELETEs rows before running INSERT statements.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml da1f09eceb999650c33729120b6959462445a115 
>   ambari-server/src/main/assemblies/server.xml 
> 51ee14e0bc215ba2fdad24112c7c0ab3ff2d1189 
>   ambari-server/src/main/python/azuredb_create_generator.py PRE-CREATION 
>   ambari-server/src/main/resources/.gitignore PRE-CREATION 
>   ambari-server/src/main/sh/azuredb_create_generator.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58840/diff/4/
> 
> 
> Testing
> ---
> 
> Tested with Microsoft SQL Server on Linux using Docker:
> 
> ```
> $ mvn -q -pl ambari-server clean generate-resources
> $ export MSSQL_PASSWORD='hVn?1AY6b\l&'
> $ docker run -e 'ACCEPT_EULA=Y' -e "SA_PASSWORD=$MSSQL_PASSWORD" --name mssql 
> -p 1433:1433 -v $(PWD):/tmp/ambari -d microsoft/mssql-server-linux
> ba7ad59f747eac75e696cbab8ed7f30af0c98dc81250ee393ebf0e01e71f2965
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD"
> 1> select count(*) from sys.objects;
> 2> go
> 
> ---
> 107
> 
> (1 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD" -i 
> /tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-AzureDB-CREATE.sql
> 
> (0 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD"
> 1> select count(*) from sys.objects;
> 2> go
> 
> ---
> 525
> 
> (1 rows affected)
> 1> select count(*) from ambari_sequences;
> 2> go
> 
> ---
>  54
> 
> (1 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD" -i 
> /tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-AzureDB-CREATE.sql
> 
> (1 rows affected)
> 
> (1 rows affected)
> 
> (184 rows affected)
> 
> (53 rows affected)
> 
> (7 rows affected)
> 
> (1 rows affected)
> 
> (8 rows affected)
> 
> (3 rows affected)
> 
> (1 rows affected)
> 
> (3 rows affected)
> 
> (54 rows affected)
> 
> (54 rows affected)
> 
> (3 rows affected)
> 
> (1 rows affected)
> 
> (3 rows affected)
> 
> (8 rows affected)
> 
> (1 rows affected)
> 
> (7 rows affected)
> 
> (53 rows affected)
> 
> (1 rows affected)
> 
> (14 rows affected)
> 
> (19 rows affected)
> 
> (24 rows affected)
> 
> (31 rows affected)
> 
> (42 rows affected)
> 
> (53 rows affected)
> 
> (1 rows affected)
> 
> (1 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD"
> 1> select count(*) from sys.objects;
> 2> go
> 
> ---
> 525
> 
> (1 rows affected)
> 1> select count(*) from ambari_sequences;
> 2> go
> 
> ---
>  54
> 
> (1 rows affected)
> 
> $ docker rm -f mssql
> mssql
> $ docker run -e 'ACCEPT_EULA=Y' -e "SA_PASSWORD=$MSSQL_PASSWORD" --name mssql 
> -p 1433:1433 -v $(PWD):/tmp/ambari -d microsoft/mssql-server-linux
> 5dfdd09a70b76f5cd9716fff94680b758c92f3850b227c0c274eea800bdf3402
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD" -i 
> /tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
> 
> (54 rows affected)
> 
> (3 rows affected)
> 
> (1 rows affected)
> 
> (3 rows affected)
> 
> (8 rows affected)
> 
> (1 rows affected)
> 
> (7 rows affected)
> 
> (53 rows affected)
> 
> (1 rows affected)
> 
> (14 rows affected)
> 
> (19 rows affected)
> 
> (24 rows affected)
> 
> (31 rows affected)
> 
> (42 rows affected)
> 
> (53 rows affected)
> 
> (1 rows affected)
> 
> (1 rows affected)
> $ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
> "$MSSQL_PASSWORD"
> 1> select count(*) from 

Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/#review173612
---


Ship it!




Ship It!

- Di Li


On May 2, 2017, 5:28 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58927/
> ---
> 
> (Updated May 2, 2017, 5:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20908
> https://issues.apache.org/jira/browse/AMBARI-20908
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  680dd32 
> 
> 
> Diff: https://reviews.apache.org/r/58927/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with default installation and added advertised.listeners
> and enabled kerberos and then checked advertised.listeners to see if it is 
> same as user provided.
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

[Bharat Viswanadham]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/
---

Review request for Ambari, Alejandro Fernandez and Di Li.


Repository: ambari


Description
---

AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
 680dd32 


Diff: https://reviews.apache.org/r/58927/diff/1/


Testing
---

Tested with default installation and added advertised.listeners
and enabled kerberos and then checked advertised.listeners to see if it is same 
as user provided.


Thanks,

Bharat Viswanadham

Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

[Bharat Viswanadham]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/
---

(Updated May 2, 2017, 5:28 p.m.)


Review request for Ambari, Alejandro Fernandez and Di Li.


Bugs: AMBARI-20908
https://issues.apache.org/jira/browse/AMBARI-20908


Repository: ambari


Description
---

AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
 680dd32 


Diff: https://reviews.apache.org/r/58927/diff/1/


Testing
---

Tested with default installation and added advertised.listeners
and enabled kerberos and then checked advertised.listeners to see if it is same 
as user provided.


Thanks,

Bharat Viswanadham

Re: Review Request 58919: AMBARI-20903 RepoVersion parsing error should be more specific

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58919/#review173603
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 2, 2017, 3:37 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58919/
> ---
> 
> (Updated May 2, 2017, 3:37 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20903
> https://issues.apache.org/jira/browse/AMBARI-20903
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a minor JIRA on updating an error message in case the repoinfo.xml 
> misses any of the three required fields - repo_name, repo_id, and base url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  d3705f3 
> 
> 
> Diff: https://reviews.apache.org/r/58919/diff/1/
> 
> 
> Testing
> ---
> 
> existing unit tests. patch a cluster with the change.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 57610: Filter out kerberos rules in exported blueprint

[Amruta Borkar]

> On May 2, 2017, 4:32 p.m., Sandor Magyari wrote:
> > Ship It!

Thank you Sandor, could you please help me push this to trunk?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57610/#review173600
---


On April 30, 2017, 4:03 a.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57610/
> ---
> 
> (Updated April 30, 2017, 4:03 a.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Levas, Robert Nettleton, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-20366
> https://issues.apache.org/jira/browse/AMBARI-20366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If blueprint is exported from a kerberos enabled cluster Kerberos rules 
> export principal names which contain cluster name and Realm, this patch 
> filter out kerberos rules properties so that hardcoded cluster name and realm 
> are not exported.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  7381387b53 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java
>  13db5f8b56 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  8ff70a1d46 
> 
> 
> Diff: https://reviews.apache.org/r/57610/diff/5/
> 
> 
> Testing
> ---
> 
> Tested manually.
> Modified test cases.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 57610: Filter out kerberos rules in exported blueprint

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57610/#review173600
---


Ship it!




Ship It!

- Sandor Magyari


On April 30, 2017, 4:03 a.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57610/
> ---
> 
> (Updated April 30, 2017, 4:03 a.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Levas, Robert Nettleton, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-20366
> https://issues.apache.org/jira/browse/AMBARI-20366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If blueprint is exported from a kerberos enabled cluster Kerberos rules 
> export principal names which contain cluster name and Realm, this patch 
> filter out kerberos rules properties so that hardcoded cluster name and realm 
> are not exported.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  7381387b53 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java
>  13db5f8b56 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  8ff70a1d46 
> 
> 
> Diff: https://reviews.apache.org/r/57610/diff/5/
> 
> 
> Testing
> ---
> 
> Tested manually.
> Modified test cases.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58919: AMBARI-20903 RepoVersion parsing error should be more specific

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58919/#review173598
---


Ship it!




Ship It!

- Tim Thorpe


On May 2, 2017, 3:37 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58919/
> ---
> 
> (Updated May 2, 2017, 3:37 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20903
> https://issues.apache.org/jira/browse/AMBARI-20903
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a minor JIRA on updating an error message in case the repoinfo.xml 
> misses any of the three required fields - repo_name, repo_id, and base url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  d3705f3 
> 
> 
> Diff: https://reviews.apache.org/r/58919/diff/1/
> 
> 
> Testing
> ---
> 
> existing unit tests. patch a cluster with the change.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 58919: AMBARI-20903 RepoVersion parsing error should be more specific

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58919/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-20903
https://issues.apache.org/jira/browse/AMBARI-20903


Repository: ambari


Description
---

This is a minor JIRA on updating an error message in case the repoinfo.xml 
misses any of the three required fields - repo_name, repo_id, and base url.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 d3705f3 


Diff: https://reviews.apache.org/r/58919/diff/1/


Testing
---

existing unit tests. patch a cluster with the change.


Thanks,

Di Li

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173591
---




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
Lines 752 (patched)


try to use "resource_management.core.exceptions.ExecutionFailed" to make 
sure that is not a syntax error or something else


- Oliver Szabo


On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> ---
> 
> (Updated April 27, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
> need to handle errors and ensure Ranger start works, despite solr service 
> being down.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  e56a705 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  34ce70d 
> 
> 
> Diff: https://reviews.apache.org/r/58797/diff/2/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

[Oliver Szabo]

> On May 2, 2017, 2:50 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
> > Lines 752 (patched)
> > 
> >
> > try to use "resource_management.core.exceptions.ExecutionFailed" to 
> > make sure that is not a syntax error or something else

sorry I mean like runtime errors (with invalid types etc.), not syntax errors. 
those should not be compiled, so tests would fail on those.


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173591
---


On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> ---
> 
> (Updated April 27, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
> need to handle errors and ensure Ranger start works, despite solr service 
> being down.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  e56a705 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  34ce70d 
> 
> 
> Diff: https://reviews.apache.org/r/58797/diff/2/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

[Vishal Suvagia via Review Board]

> On May 2, 2017, 10:10 a.m., Oliver Szabo wrote:
> > Im feeling that is not really the right solution to put the whole code into 
> > a big try catch block. it wont fail with even syntactic errors.

Hi Oliver,
 This is basically done so as to start Ranger irrespective of zookeeper 
error which can come in check_znode, As the error can now be visible to the 
user this may not affect the Ranger service start at all.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173577
---


On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> ---
> 
> (Updated April 27, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
> need to handle errors and ensure Ranger start works, despite solr service 
> being down.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  e56a705 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  34ce70d 
> 
> 
> Diff: https://reviews.apache.org/r/58797/diff/2/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58918: AMBARI-20911 Add property in Ranger for including SSL protocols

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58918/#review173585
---




ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-admin-site.xml
Lines 33 (patched)


cURL on several supported OS's don't support TLSv1.2


- Jonathan Hurley


On May 2, 2017, 7:58 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58918/
> ---
> 
> (Updated May 2, 2017, 7:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20911
> https://issues.apache.org/jira/browse/AMBARI-20911
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add ranger.service.https.attrib.ssl.enabled.protocols property in 
> ranger-admin-site config type for stack 2.6
> 
> For fresh install the value required is: TLSv1.1,TLSv1.2
> For upgrade: SSLv2Hello,TLSv1,TLSv1.1,TLSv1.2
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-admin-site.xml
>  ebf8517 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 8b5c07d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  18c0c15 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> d98bb53 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> b3d19d4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  368bbe2 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 1eb9836 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 559d8dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  c3436b9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 0470b7a 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> a6b7523 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  a74d085 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 35d3da2 
> 
> 
> Diff: https://reviews.apache.org/r/58918/diff/1/
> 
> 
> Testing
> ---
> 
> Tested EU Upgrade with Ranger.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 58884: Mask passwords in Request resource responses

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58884/#review173584
---


Ship it!




Ship It!

- Attila Magyar


On May 1, 2017, 5:30 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58884/
> ---
> 
> (Updated May 1, 2017, 5:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Balázs Bence 
> Sári, Eugene Chekanskiy, Laszlo Puskas, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20874
> https://issues.apache.org/jira/browse/AMBARI-20874
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mask the data for sensitive fields and properties in Request resource 
> responses to protect that data.
> 
> `org.apache.ambari.server.utils.SecretReference#maskPasswordInPropertyMap` is 
> used `org.apache.ambari.server.controller.internal.StageResourceProvider` to 
> protected sensitive data.  The same technique should be used in 
> `org.apache.ambari.server.controller.internal.RequestResourceProvider`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  57e702477d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  feedc74b7c 
> 
> 
> Diff: https://reviews.apache.org/r/58884/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 58918: AMBARI-20911 Add property in Ranger for including SSL protocols

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58918/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
and Sumit Mohanty.


Bugs: AMBARI-20911
https://issues.apache.org/jira/browse/AMBARI-20911


Repository: ambari


Description
---

Add ranger.service.https.attrib.ssl.enabled.protocols property in 
ranger-admin-site config type for stack 2.6

For fresh install the value required is: TLSv1.1,TLSv1.2
For upgrade: SSLv2Hello,TLSv1,TLSv1.1,TLSv1.2


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-admin-site.xml
 ebf8517 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
8b5c07d 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 18c0c15 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
d98bb53 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
b3d19d4 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 368bbe2 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
1eb9836 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
559d8dc 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 c3436b9 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
0470b7a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
a6b7523 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 a74d085 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
35d3da2 


Diff: https://reviews.apache.org/r/58918/diff/1/


Testing
---

Tested EU Upgrade with Ranger.


Thanks,

Mugdha Varadkar

Re: Review Request 58917: Unable to view visual explain details in Firefox browser

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58917/#review173580
---


Ship it!




Ship It!

- Gaurav Nagar


On May 2, 2017, 11:21 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58917/
> ---
> 
> (Updated May 2, 2017, 11:21 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, 
> and venkat sairam.
> 
> 
> Bugs: AMBARI-20912
> https://issues.apache.org/jira/browse/AMBARI-20912
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor sequence change
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  3a23226 
> 
> 
> Diff: https://reviews.apache.org/r/58917/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 58917: Unable to view visual explain details in Firefox browser

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58917/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and 
venkat sairam.


Bugs: AMBARI-20912
https://issues.apache.org/jira/browse/AMBARI-20912


Repository: ambari


Description
---

minor sequence change


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
3a23226 


Diff: https://reviews.apache.org/r/58917/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173577
---



Im feeling that is not really the right solution to put the whole code into a 
big try catch block. it wont fail with even syntactic errors.

- Oliver Szabo


On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> ---
> 
> (Updated April 27, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
> need to handle errors and ensure Ranger start works, despite solr service 
> being down.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  e56a705 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  34ce70d 
> 
> 
> Diff: https://reviews.apache.org/r/58797/diff/2/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58840: AMBARI-20886. Create idempotent Ambari DB Schema SQL script for AzureDB

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58840/
---

(Updated May 2, 2017, 12:09 p.m.)


Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, 
Sumit Mohanty, Sebastian Toader, and Sid Wagle.


Changes
---

re-implemented in Python


Bugs: AMBARI-20886
https://issues.apache.org/jira/browse/AMBARI-20886


Repository: ambari


Description
---

Based on existing SQL Server script generate at compile-time for AzureDB a SQL 
script that:
 * runs CREATE TABLE, CREATE INDEX and ADD CONSTRAINT statements only if the 
objects do not exist yet,
 * DELETEs rows before running INSERT statements.


Diffs (updated)
-

  ambari-server/pom.xml da1f09eceb999650c33729120b6959462445a115 
  ambari-server/src/main/assemblies/server.xml 
51ee14e0bc215ba2fdad24112c7c0ab3ff2d1189 
  ambari-server/src/main/python/azuredb_create_generator.py PRE-CREATION 
  ambari-server/src/main/resources/.gitignore PRE-CREATION 
  ambari-server/src/main/sh/azuredb_create_generator.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/58840/diff/4/

Changes: https://reviews.apache.org/r/58840/diff/3-4/


Testing
---

Tested with Microsoft SQL Server on Linux using Docker:

```
$ mvn -q -pl ambari-server clean generate-resources
$ export MSSQL_PASSWORD='hVn?1AY6b\l&'
$ docker run -e 'ACCEPT_EULA=Y' -e "SA_PASSWORD=$MSSQL_PASSWORD" --name mssql 
-p 1433:1433 -v $(PWD):/tmp/ambari -d microsoft/mssql-server-linux
ba7ad59f747eac75e696cbab8ed7f30af0c98dc81250ee393ebf0e01e71f2965
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD"
1> select count(*) from sys.objects;
2> go

---
107

(1 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD" -i 
/tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-AzureDB-CREATE.sql

(0 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD"
1> select count(*) from sys.objects;
2> go

---
525

(1 rows affected)
1> select count(*) from ambari_sequences;
2> go

---
 54

(1 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD" -i 
/tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-AzureDB-CREATE.sql

(1 rows affected)

(1 rows affected)

(184 rows affected)

(53 rows affected)

(7 rows affected)

(1 rows affected)

(8 rows affected)

(3 rows affected)

(1 rows affected)

(3 rows affected)

(54 rows affected)

(54 rows affected)

(3 rows affected)

(1 rows affected)

(3 rows affected)

(8 rows affected)

(1 rows affected)

(7 rows affected)

(53 rows affected)

(1 rows affected)

(14 rows affected)

(19 rows affected)

(24 rows affected)

(31 rows affected)

(42 rows affected)

(53 rows affected)

(1 rows affected)

(1 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD"
1> select count(*) from sys.objects;
2> go

---
525

(1 rows affected)
1> select count(*) from ambari_sequences;
2> go

---
 54

(1 rows affected)

$ docker rm -f mssql
mssql
$ docker run -e 'ACCEPT_EULA=Y' -e "SA_PASSWORD=$MSSQL_PASSWORD" --name mssql 
-p 1433:1433 -v $(PWD):/tmp/ambari -d microsoft/mssql-server-linux
5dfdd09a70b76f5cd9716fff94680b758c92f3850b227c0c274eea800bdf3402
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD" -i 
/tmp/ambari/ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql

(54 rows affected)

(3 rows affected)

(1 rows affected)

(3 rows affected)

(8 rows affected)

(1 rows affected)

(7 rows affected)

(53 rows affected)

(1 rows affected)

(14 rows affected)

(19 rows affected)

(24 rows affected)

(31 rows affected)

(42 rows affected)

(53 rows affected)

(1 rows affected)

(1 rows affected)
$ docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 
"$MSSQL_PASSWORD"
1> select count(*) from sys.objects;
2> go

---
525

(1 rows affected)
1> select count(*) from ambari_sequences;
2> go

---
 54

(1 rows affected)
```


Thanks,

Attila Doroszlai

Re: Review Request 58886: Smartsense view do not load and shows blank

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58886/#review173574
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 2, 2017, 8:11 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58886/
> ---
> 
> (Updated May 2, 2017, 8:11 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20905
> https://issues.apache.org/jira/browse/AMBARI-20905
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If installation fails and is retried the cluster id changes but some view 
> instances keep older cluster ids which stop views from being displayed later 
> on.
> remove the view instances which contains invalid cluster id before creating 
> any autoview instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
>  061c7223d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  b632c54043 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 24eceb21c6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
>  25afe92ce4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java
>  8836af6ead 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  a3728d46b3 
> 
> 
> Diff: https://reviews.apache.org/r/58886/diff/2/
> 
> 
> Testing
> ---
> 
> updated testcases where ever needed. Manual testing also done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58822: Add Log Level Filter to the Log Search config API

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/
---

(Updated May 2, 2017, 8:57 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

fix doc constants


Bugs: AMBARI-20881
https://issues.apache.org/jira/browse/AMBARI-20881


Repository: ambari


Description
---

Log Level Filters should be handled by the config API too

Also Log Level Filters should be per cluster, not only one for the Log Search 
Server. This means that some UI modifications are also necessary in order to 
query/persist changes of the log level filters for a specific cluster only.


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
 df26920 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
 0bb0b78 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
 969eb30 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
 664ecc9 
  ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
 738fde2 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 074fedb 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
 b70fbd1 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
 a05a916 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java
 12c744c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
 0ece637 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java
 60c8ae8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java
 9199cd3 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
 135fb32 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
 bb2f0a9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java
 266108f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties
 59020cc 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java
 c2d27f9 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 8fb27a7 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 00adb67 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java
 c0c1167 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java
 a60fc5c 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java
 cc7d53d 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LogfeederFilterData.java
 e0f8013 
  

Re: Review Request 58886: Smartsense view do not load and shows blank

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58886/
---

(Updated May 2, 2017, 8:11 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, venkat sairam, and Ashwin Rajeev.


Changes
---

checking that the view should also be LOCAL_AMBARI view.


Bugs: AMBARI-20905
https://issues.apache.org/jira/browse/AMBARI-20905


Repository: ambari


Description
---

If installation fails and is retried the cluster id changes but some view 
instances keep older cluster ids which stop views from being displayed later on.
remove the view instances which contains invalid cluster id before creating any 
autoview instance.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
 061c7223d6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
 b632c54043 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
24eceb21c6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
 25afe92ce4 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java
 8836af6ead 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 
a3728d46b3 


Diff: https://reviews.apache.org/r/58886/diff/2/

Changes: https://reviews.apache.org/r/58886/diff/1-2/


Testing
---

updated testcases where ever needed. Manual testing also done.


Thanks,

Nitiraj Rathore

Re: Review Request 58886: Smartsense view do not load and shows blank

[Nitiraj Rathore]

> On May 1, 2017, 7:13 p.m., Gaurav Nagar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
> > Lines 1012 (patched)
> > 
> >
> > I think, this will be called for each auto instance.
> > Shouldn't we call this before installAutoInstance, so that it will 
> > execute only once.

Should not be a problem, as we are thinking of another better way for next 
release. If I take it out then the code will spread to multiple places.


> On May 1, 2017, 7:13 p.m., Gaurav Nagar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
> > Lines 1050 (patched)
> > 
> >
> > You need to check if viewInstance's clusterType is LOCAL_AMBARI and 
> > Id's not contails in list.
> > Otherwise it will delete REMOTE_AMBARI configured instances.

Ok will do this check and update the patch.


- Nitiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58886/#review173491
---


On May 1, 2017, 6:57 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58886/
> ---
> 
> (Updated May 1, 2017, 6:57 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20905
> https://issues.apache.org/jira/browse/AMBARI-20905
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If installation fails and is retried the cluster id changes but some view 
> instances keep older cluster ids which stop views from being displayed later 
> on.
> remove the view instances which contains invalid cluster id before creating 
> any autoview instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
>  061c7223d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  b632c54043 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 24eceb21c6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
>  25afe92ce4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java
>  8836af6ead 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  a3728d46b3 
> 
> 
> Diff: https://reviews.apache.org/r/58886/diff/1/
> 
> 
> Testing
> ---
> 
> updated testcases where ever needed. Manual testing also done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58886: Smartsense view do not load and shows blank

[Nitiraj Rathore]

> On May 1, 2017, 6:59 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
> > Lines 186 (patched)
> > 
> >
> > Why does the cluster ID change?
> > If that's the root cause, we should fix that instead.

So I think if the cluster install fails because of some reason. A reattempt 
from UI is done and at that time the cluster id is changed. But this change is 
not propogated to ViewRegistry and it does not delete already created auto view 
instances or changes their cluster id.
Yes this solution is not elegant. Although this bug is rare but when it comes 
it creates problems even in correcting the views from the UI. And so the 
severity of the bug is high.
I think a better solution would be to fire one event like "ClusterDeleted" 
which will be picked up by ViewRegistry and it will delete the views which were 
created for that cluster id.
Auto instances will again get created with new cluster id. This solution might 
take more time to implement as it touches more surface.
We will log another bug for this change. But the current patch handles the 
sitution and keeps ambari and views properly running.


- Nitiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58886/#review173490
---


On May 1, 2017, 6:57 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58886/
> ---
> 
> (Updated May 1, 2017, 6:57 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20905
> https://issues.apache.org/jira/browse/AMBARI-20905
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If installation fails and is retried the cluster id changes but some view 
> instances keep older cluster ids which stop views from being displayed later 
> on.
> remove the view instances which contains invalid cluster id before creating 
> any autoview instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
>  061c7223d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  b632c54043 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 24eceb21c6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
>  25afe92ce4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java
>  8836af6ead 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  a3728d46b3 
> 
> 
> Diff: https://reviews.apache.org/r/58886/diff/1/
> 
> 
> Testing
> ---
> 
> updated testcases where ever needed. Manual testing also done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58842/#review173567
---


Ship it!




Ship It!

- venkat sairam


On April 28, 2017, noon, Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58842/
> ---
> 
> (Updated April 28, 2017, noon)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20888
> https://issues.apache.org/jira/browse/AMBARI-20888
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> wrong ZK parent node (hbase-unsecure) getting configured as part of the 
> jdbc(phoenix) URL on ubuntu secured cluster the jdbc(phoenix) url was getting 
> appended as /hbase-unsecure which is not correct
> If you check the hbase-site.xml
> 
> zookeeper.znode.parent
> /hbase-secure
> 
> I think how the phoenix URL is being constructed is not consistent across the 
> configs and we need to see why. On some of the other platforms, I have seen 
> it getting configured correctly (for e.g. Centos6 secured wire-encrypted)
> Options
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fbf2246672 
> 
> 
> Diff: https://reviews.apache.org/r/58842/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on Cent6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58842/#review173565
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On April 28, 2017, noon, Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58842/
> ---
> 
> (Updated April 28, 2017, noon)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20888
> https://issues.apache.org/jira/browse/AMBARI-20888
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> wrong ZK parent node (hbase-unsecure) getting configured as part of the 
> jdbc(phoenix) URL on ubuntu secured cluster the jdbc(phoenix) url was getting 
> appended as /hbase-unsecure which is not correct
> If you check the hbase-site.xml
> 
> zookeeper.znode.parent
> /hbase-secure
> 
> I think how the phoenix URL is being constructed is not consistent across the 
> configs and we need to see why. On some of the other platforms, I have seen 
> it getting configured correctly (for e.g. Centos6 secured wire-encrypted)
> Options
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fbf2246672 
> 
> 
> Diff: https://reviews.apache.org/r/58842/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on Cent6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58842/#review173564
---


Ship it!




Ship It!

- Gaurav Nagar


On April 28, 2017, noon, Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58842/
> ---
> 
> (Updated April 28, 2017, noon)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20888
> https://issues.apache.org/jira/browse/AMBARI-20888
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> wrong ZK parent node (hbase-unsecure) getting configured as part of the 
> jdbc(phoenix) URL on ubuntu secured cluster the jdbc(phoenix) url was getting 
> appended as /hbase-unsecure which is not correct
> If you check the hbase-site.xml
> 
> zookeeper.znode.parent
> /hbase-secure
> 
> I think how the phoenix URL is being constructed is not consistent across the 
> configs and we need to see why. On some of the other platforms, I have seen 
> it getting configured correctly (for e.g. Centos6 secured wire-encrypted)
> Options
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fbf2246672 
> 
> 
> Diff: https://reviews.apache.org/r/58842/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on Cent6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58842/#review173563
---


Ship it!




Ship It!

- Renjith Kamath


On April 28, 2017, noon, Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58842/
> ---
> 
> (Updated April 28, 2017, noon)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20888
> https://issues.apache.org/jira/browse/AMBARI-20888
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> wrong ZK parent node (hbase-unsecure) getting configured as part of the 
> jdbc(phoenix) URL on ubuntu secured cluster the jdbc(phoenix) url was getting 
> appended as /hbase-unsecure which is not correct
> If you check the hbase-site.xml
> 
> zookeeper.znode.parent
> /hbase-secure
> 
> I think how the phoenix URL is being constructed is not consistent across the 
> configs and we need to see why. On some of the other platforms, I have seen 
> it getting configured correctly (for e.g. Centos6 secured wire-encrypted)
> Options
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fbf2246672 
> 
> 
> Diff: https://reviews.apache.org/r/58842/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on Cent6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>