Re: Review Request 64344: AMBARI-22589 Ambari web UI stack version page is empty due to NPE when target stack does not contain all services from the current stack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64344/#review193007 --- Ship it! Ship It! - Sangeeta Ravindran On Dec. 5, 2017, 6:28 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64344/ > --- > > (Updated Dec. 5, 2017, 6:28 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Sangeeta Ravindran. > > > Bugs: AMBARI-22589 > https://issues.apache.org/jira/browse/AMBARI-22589 > > > Repository: ambari > > > Description > --- > > Stack version page where it usually shows the current and target versions is > empty when current stack has services that the to-be-upgraded-to stack does > not have. > this is due to a null pointer error at the ambari web UI level. > > > Diffs > - > > > ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js > ae01feb > > > Diff: https://reviews.apache.org/r/64344/diff/2/ > > > Testing > --- > > patch a trunk cluster to have it be able to install a cluster with IOP 4.2.5 > stack. register HDP 2.6 stack where it doesn;t have solr. verify UI, with the > patch, pops up an alert dialog and also be able to show the stacks registered > instead of an empty page. > > > Thanks, > > Di Li > >
Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60489/ --- Review request for Ambari, Di Li and Tim Thorpe. Bugs: AMBARI-21274 https://issues.apache.org/jira/browse/AMBARI-21274 Repository: ambari Description --- If there are issues with yarn service check queue or mapreduce job queue configurations, service advisor throws an error with a typo. Queue is not exist or not corresponds to existing YARN leaf queue Diffs - ambari-server/src/main/resources/stacks/stack_advisor.py 3a39a34 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py b6f1965 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py e62e00c contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/stack_advisor.py 5a95fe3 Diff: https://reviews.apache.org/r/60489/diff/1/ Testing --- Manual testing. Ran python tests cleanly. Thanks, Sangeeta Ravindran
Review Request 60488: Ability to delete a view instance from view instance list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60488/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-21360 https://issues.apache.org/jira/browse/AMBARI-21360 Repository: ambari Description --- Currently, a view instance is deleted by editing the instance and clicking on 'Deleting instance'. It helps to be able to delete the instance directly from the view instance list without having to edit the view instance. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js c41e5d4 ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html 59c322f Diff: https://reviews.apache.org/r/60488/diff/1/ Testing --- Manual testing. Thanks, Sangeeta Ravindran
Re: Review Request 59756: Delete view privileges from the Groups page
> On June 27, 2017, 12:24 p.m., Sangeeta Ravindran wrote: > > Ship It! > > Anita Jebaraj wrote: > Hi Sangeeta, can you please help in pushing the changes? Done. You can close this review. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59756/#review178979 --- On June 2, 2017, 6:46 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59756/ > --- > > (Updated June 2, 2017, 6:46 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. > > > Bugs: AMBARI-21172 > https://issues.apache.org/jira/browse/AMBARI-21172 > > > Repository: ambari > > > Description > --- > > The view permissions are listed in the groups page, but in order to remove > it, the user has to drill down to the views page and remove the group from > it. To remove the permission for multiple views for one group, we have to > navigate to different Views page to perform the operation > > Including a delete option in the Groups page for views privilege will simply > this > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > 92406e9 > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html > e472ede8 > > > Diff: https://reviews.apache.org/r/59756/diff/1/ > > > Testing > --- > > Ran mvn test > > > File Attachments > > > Image1.PNG > > https://reviews.apache.org/media/uploaded/files/2017/06/02/2963340b-98ed-4b28-9cdc-7d67f21a0775__Image1.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59756: Delete view privileges from the Groups page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59756/#review178979 --- Ship it! Ship It! - Sangeeta Ravindran On June 2, 2017, 6:46 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59756/ > --- > > (Updated June 2, 2017, 6:46 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. > > > Bugs: AMBARI-21172 > https://issues.apache.org/jira/browse/AMBARI-21172 > > > Repository: ambari > > > Description > --- > > The view permissions are listed in the groups page, but in order to remove > it, the user has to drill down to the views page and remove the group from > it. To remove the permission for multiple views for one group, we have to > navigate to different Views page to perform the operation > > Including a delete option in the Groups page for views privilege will simply > this > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > 92406e9 > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html > e472ede8 > > > Diff: https://reviews.apache.org/r/59756/diff/1/ > > > Testing > --- > > Ran mvn test > > > File Attachments > > > Image1.PNG > > https://reviews.apache.org/media/uploaded/files/2017/06/02/2963340b-98ed-4b28-9cdc-7d67f21a0775__Image1.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59913: AMBARI-21197 Disable Kerberos UI step by step panel misalign with the Complete button at the bottom of the page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59913/#review177327 --- Ship it! Ship It! - Sangeeta Ravindran On June 8, 2017, 12:45 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59913/ > --- > > (Updated June 8, 2017, 12:45 p.m.) > > > Review request for Ambari, Sangeeta Ravindran and Tim Thorpe. > > > Bugs: AMBARI-21197 > https://issues.apache.org/jira/browse/AMBARI-21197 > > > Repository: ambari > > > Description > --- > > Disable Kerberos UI step by step panel misalign with the Complete button at > the bottom of the page. See screenshot for details. > > > Diffs > - > > ambari-web/app/templates/common/progress.hbs ab59328 > ambari-web/app/views/main/admin/kerberos/disable_view.js f7b3527 > > > Diff: https://reviews.apache.org/r/59913/diff/1/ > > > Testing > --- > > existing unit tests. patch a trunk cluster, enable kerberos, verify the > common progress pages have the correct width (via the new if/else logic), run > disable kerberos, verify the progress page now has the correct width (via the > new if/else logic) > > > Thanks, > > Di Li > >
Re: Review Request 59609: Export cluster_name in the cluster template file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59609/#review176474 --- Ship it! Ship It! - Sangeeta Ravindran On May 30, 2017, 10:08 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59609/ > --- > > (Updated May 30, 2017, 10:08 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. > > > Bugs: AMBARI-21132 > https://issues.apache.org/jira/browse/AMBARI-21132 > > > Repository: ambari > > > Description > --- > > Blueprint export from UI installer currently does not export cluster_name in > the clustertemplate file. Adding patch to export the same > > > Diffs > - > > ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9 > > > Diff: https://reviews.apache.org/r/59609/diff/1/ > > > Testing > --- > > Tested manually, Attached clustertemplate.json file. > > > File Attachments > > > clustertemplate > > https://reviews.apache.org/media/uploaded/files/2017/05/26/59c6826a-e49a-4210-9079-b93cc0074c6f__clustertemplate_8.json > > > Thanks, > > Amruta Borkar > >
Review Request 59613: Roles below Cluster Administrator should not be allowed to edit repositories and install stack versions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59613/ --- Review request for Ambari, Alexandr Antonenko and Robert Levas. Bugs: AMBARI-21120 https://issues.apache.org/jira/browse/AMBARI-21120 Repository: ambari Description --- Login as a user with a role below Cluster Administrator. For e.g. Service Administrator. Click on Stack and Versions. 1. Try to edit a stack version that is not yet installed on the cluster. Click on Save. The UI reloads and returns to Services Dashboard. On the browser console, you can see a HTTP 403 because the user does not have the privilege to edit stack versions. This happens because for users without MANAGE_STACK_VERSION privilege, the Edit Repository button is disabled only for the current stack version. 2. Click on Install. When you click on on the popup confirming that the packages will be installed on all hosts, you get a popup with an error "Packages could not be installed. You do not have permissions to access this resource". This happens because there is no check for CLUSTER.UPGRADE_DOWNGRADE_STACK privilege when enabling the Install button. Diffs - ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js f102402 ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 153b66f Diff: https://reviews.apache.org/r/59613/diff/1/ Testing --- Manual testing. Updated test case. mvn clean test Thanks, Sangeeta Ravindran
Re: Review Request 59497: Customize services shows inconsistent config-groups after clicking on Back
> On May 26, 2017, 5:31 p.m., Sangeeta Ravindran wrote: > > Ship It! > > Amruta Borkar wrote: > Thank you Sangeeta, could you please help me push this to trunk? I've commited this to trunk. Please close the review. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59497/#review176212 --- On May 23, 2017, 11:06 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59497/ > --- > > (Updated May 23, 2017, 11:06 p.m.) > > > Review request for Ambari, Aleksandr Kovalenko and Sangeeta Ravindran. > > > Bugs: AMBARI-21094 > https://issues.apache.org/jira/browse/AMBARI-21094 > > > Repository: ambari > > > Description > --- > > Steps to reproduce: > 1. Go to Customize Services screen > 2. Create a Custom HostGroup > 3. Click Back button > 4. Click Next Button > 5. See that Custom Hostgroup still exists, but all the data including > assigned hosts is erased. > Ambari typically erases all the changes when clicked on Back button, because > the Custom HostGroup is not deleted but data related to it is deleted by > Ambari, cluster state goes in inconsistent state. > > > Diffs > - > > ambari-web/app/controllers/wizard/step7_controller.js 6685c0189a > > > Diff: https://reviews.apache.org/r/59497/diff/1/ > > > Testing > --- > > Tested manually, > Attached output screenshots > > > File Attachments > > > HostGroupList_BeforeClickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/20029794-04d8-4611-83fe-884e30282ff7__HostGroupList_BeforeClickingBack.png > BeforeCodeChange_ManageHostGroup_Customgroup_AfterClickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/3853d6c3-5fd0-4604-9923-602df062b51f__BeforeCodeChange_ManageHostGroup_Customgroup_AfterClickingBack.png > BeforeCodeChange_ManageHostGroup_Defaultgroup_AfterClickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/2b28debe-b81f-4b25-946b-acdfc69a3042__BeforeCodeChange_ManageHostGroup_Defaultgroup_AfterClickingBack.png > BeforeCodeChange_HostGroupList_AfterlickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/5c9805e0-41ae-42fa-a87d-393f0da8a144__BeforeCodeChange_HostGroupList_AfterlickingBack.png > AfterCodeChange_HostGroupList > > https://reviews.apache.org/media/uploaded/files/2017/05/23/190f83cb-ce1b-4413-a9b3-cd988cd29133__AfterCodeChange_HostGroupList.png > AfterCodeChange_ManageHostGroupPage > > https://reviews.apache.org/media/uploaded/files/2017/05/23/1bb710b5-f5c3-482b-8dca-dd3950ec2fbb__AfterCodeChange_ManageHostGroupPage.png > > > Thanks, > > Amruta Borkar > >
Re: Review Request 59497: Customize services shows inconsistent config-groups after clicking on Back
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59497/#review176212 --- Ship it! Ship It! - Sangeeta Ravindran On May 23, 2017, 11:06 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59497/ > --- > > (Updated May 23, 2017, 11:06 p.m.) > > > Review request for Ambari, Aleksandr Kovalenko and Sangeeta Ravindran. > > > Bugs: AMBARI-21094 > https://issues.apache.org/jira/browse/AMBARI-21094 > > > Repository: ambari > > > Description > --- > > Steps to reproduce: > 1. Go to Customize Services screen > 2. Create a Custom HostGroup > 3. Click Back button > 4. Click Next Button > 5. See that Custom Hostgroup still exists, but all the data including > assigned hosts is erased. > Ambari typically erases all the changes when clicked on Back button, because > the Custom HostGroup is not deleted but data related to it is deleted by > Ambari, cluster state goes in inconsistent state. > > > Diffs > - > > ambari-web/app/controllers/wizard/step7_controller.js 6685c0189a > > > Diff: https://reviews.apache.org/r/59497/diff/1/ > > > Testing > --- > > Tested manually, > Attached output screenshots > > > File Attachments > > > HostGroupList_BeforeClickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/20029794-04d8-4611-83fe-884e30282ff7__HostGroupList_BeforeClickingBack.png > BeforeCodeChange_ManageHostGroup_Customgroup_AfterClickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/3853d6c3-5fd0-4604-9923-602df062b51f__BeforeCodeChange_ManageHostGroup_Customgroup_AfterClickingBack.png > BeforeCodeChange_ManageHostGroup_Defaultgroup_AfterClickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/2b28debe-b81f-4b25-946b-acdfc69a3042__BeforeCodeChange_ManageHostGroup_Defaultgroup_AfterClickingBack.png > BeforeCodeChange_HostGroupList_AfterlickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/5c9805e0-41ae-42fa-a87d-393f0da8a144__BeforeCodeChange_HostGroupList_AfterlickingBack.png > AfterCodeChange_HostGroupList > > https://reviews.apache.org/media/uploaded/files/2017/05/23/190f83cb-ce1b-4413-a9b3-cd988cd29133__AfterCodeChange_HostGroupList.png > AfterCodeChange_ManageHostGroupPage > > https://reviews.apache.org/media/uploaded/files/2017/05/23/1bb710b5-f5c3-482b-8dca-dd3950ec2fbb__AfterCodeChange_ManageHostGroupPage.png > > > Thanks, > > Amruta Borkar > >
Re: Review Request 59532: Add Confirmation pop up for 'Generate Blueprint' button
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59532/#review176025 --- Ship it! Ship It! - Sangeeta Ravindran On May 24, 2017, 10:43 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59532/ > --- > > (Updated May 24, 2017, 10:43 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. > > > Bugs: AMBARI-21104 > https://issues.apache.org/jira/browse/AMBARI-21104 > > > Repository: ambari > > > Description > --- > > Add Confirmation pop up for 'Generate Blueprint' button. > Notify user that two files will be downloaded and provide information on how > to use those files. > > > Diffs > - > > ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9 > ambari-web/app/messages.js 0c15a1935e > ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf > > > Diff: https://reviews.apache.org/r/59532/diff/2/ > > > Testing > --- > > Tested manually. Attached image of the Confirmation box. > > > File Attachments > > > Confirmation pop up > > https://reviews.apache.org/media/uploaded/files/2017/05/24/b708ef1d-6a7f-4525-9dee-ecb11ab6d5fa__Snip20170524_9.png > > > Thanks, > > Amruta Borkar > >
Re: Review Request 59496: Enable opening views in a new tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59496/#review175952 --- Ship it! Ship It! - Sangeeta Ravindran On May 23, 2017, 6:58 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59496/ > --- > > (Updated May 23, 2017, 6:58 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, DIPAYAN BHOWMICK, > Pallav Kulshreshtha, and Sangeeta Ravindran. > > > Bugs: AMBARI-21095 > https://issues.apache.org/jira/browse/AMBARI-21095 > > > Repository: ambari > > > Description > --- > > Enable views to be opened in a new tab instead of being opened in the same > tab, this would help in going between the different tabs to look for > information or for config updates in the services. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/index.html 32f9ba7 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html > b6ec61d > ambari-web/app/controllers/main/views_controller.js 398cdd8 > ambari-web/app/models/view_instance.js d438640 > ambari-web/test/controllers/main/views_controller_test.js 0ab7654 > ambari-web/test/models/view_instance_test.js 0e977e3 > > > Diff: https://reviews.apache.org/r/59496/diff/1/ > > > Testing > --- > > Modified the test cases, > > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir
> On May 19, 2017, 2:56 p.m., Di Li wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > > Lines 150 (patched) > > <https://reviews.apache.org/r/59382/diff/1/?file=1724706#file1724706line150> > > > > nitpicking: remove console.log line. Hi Di, I have removed the console.log statement. I also made on additional change to set the editableDisplayName to also be set based on the number of digits in the version. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59382/#review175503 --- On May 19, 2017, 5:23 a.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59382/ > --- > > (Updated May 19, 2017, 5:23 a.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-21052 > https://issues.apache.org/jira/browse/AMBARI-21052 > > > Repository: ambari > > > Description > --- > > In the Register Version UI, the regex pattern for Version Number is currently > hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two > digits to be entered to make it a valid 4 digit stack version. If the stack > version dir has three digits, Register Version UI throws an error > mystack-x.x.x Invalid. The regex pattern should be based on the number of > digits supplied by the stack's version dir and should not be harcoded. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > 69c35c0 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > fd2c6e5 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > b496987 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > fe08802 > > ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js > 81d3441 > > > Diff: https://reviews.apache.org/r/59382/diff/1/ > > > Testing > --- > > Manual Testing. > I updated the test case because $scope.subversionPattern has been removed as > part of this fix. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59382/ --- (Updated May 19, 2017, 9:16 p.m.) Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-21052 https://issues.apache.org/jira/browse/AMBARI-21052 Repository: ambari Description --- In the Register Version UI, the regex pattern for Version Number is currently hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two digits to be entered to make it a valid 4 digit stack version. If the stack version dir has three digits, Register Version UI throws an error mystack-x.x.x Invalid. The regex pattern should be based on the number of digits supplied by the stack's version dir and should not be harcoded. Diffs (updated) - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 69c35c0 ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js fd2c6e5 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js b496987 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html fe08802 ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js 81d3441 Diff: https://reviews.apache.org/r/59382/diff/2/ Changes: https://reviews.apache.org/r/59382/diff/1-2/ Testing --- Manual Testing. I updated the test case because $scope.subversionPattern has been removed as part of this fix. Thanks, Sangeeta Ravindran
Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir
> On May 19, 2017, 8:23 a.m., Alexandr Antonenko wrote: > > Ship It! Thanks Alexandr. I also made on additional change to set the editableDisplayName to also be set based on the number of digits in the version. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59382/#review175475 --- On May 19, 2017, 5:23 a.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59382/ > --- > > (Updated May 19, 2017, 5:23 a.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-21052 > https://issues.apache.org/jira/browse/AMBARI-21052 > > > Repository: ambari > > > Description > --- > > In the Register Version UI, the regex pattern for Version Number is currently > hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two > digits to be entered to make it a valid 4 digit stack version. If the stack > version dir has three digits, Register Version UI throws an error > mystack-x.x.x Invalid. The regex pattern should be based on the number of > digits supplied by the stack's version dir and should not be harcoded. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > 69c35c0 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > fd2c6e5 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > b496987 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > fe08802 > > ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js > 81d3441 > > > Diff: https://reviews.apache.org/r/59382/diff/1/ > > > Testing > --- > > Manual Testing. > I updated the test case because $scope.subversionPattern has been removed as > part of this fix. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 59373: Address config-groups while exporting blueprint from UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59373/#review175527 --- Ship it! Ship It! - Sangeeta Ravindran On May 19, 2017, 5:01 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59373/ > --- > > (Updated May 19, 2017, 5:01 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and > Sangeeta Ravindran. > > > Bugs: AMBARI-21050 > https://issues.apache.org/jira/browse/AMBARI-21050 > > > Repository: ambari > > > Description > --- > > Exported blueprint should include config-group changes, which should be > exported as host-group level configuration. New host-group will be created > for host having unique config-group. > > > Diffs > - > > ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 > ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 > > > Diff: https://reviews.apache.org/r/59373/diff/2/ > > > Testing > --- > > Tested manually. Updated test cases. > > > File Attachments > > > exported blueprint > > https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json > exported cluster template > > https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json > > > Thanks, > > Amruta Borkar > >
Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59382/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-21052 https://issues.apache.org/jira/browse/AMBARI-21052 Repository: ambari Description --- In the Register Version UI, the regex pattern for Version Number is currently hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two digits to be entered to make it a valid 4 digit stack version. If the stack version dir has three digits, Register Version UI throws an error mystack-x.x.x Invalid. The regex pattern should be based on the number of digits supplied by the stack's version dir and should not be harcoded. Diffs (updated) - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 69c35c0 ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js fd2c6e5 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js b496987 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html fe08802 ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js 81d3441 Diff: https://reviews.apache.org/r/59382/diff/1/ Testing (updated) --- Manual Testing. I updated the test case because $scope.subversionPattern has been removed as part of this fix. Thanks, Sangeeta Ravindran
Review Request 59222: Hive 1.5.0 view does not load in Internet Explorer 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59222/
---
Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
Bugs: AMBARI-21001
https://issues.apache.org/jira/browse/AMBARI-21001
Repository: ambari
Description
---
1. Create a Hive 1.5.0 view instance and execute it in IE 11.
2. A blank page is displayed with the following error message in the web
console:
SCRIPT1002: Syntax error
File: hive.js, Line: 8374, Column: 23
The error is on this line in fetchServiceCheckPolicy in
contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js
this.fetchServiceCheckPolicy()
.then((data) => {
This is because the ES6 arrow (=>) functions are not supported in IE
Diffs
-
contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js
087bab3
Diff: https://reviews.apache.org/r/59222/diff/1/
Testing
---
Manual testing in FF, Chrome and IE
Thanks,
Sangeeta Ravindran
Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58864/#review174230 --- Ship it! Ship It! - Sangeeta Ravindran On May 8, 2017, 9:45 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58864/ > --- > > (Updated May 8, 2017, 9:45 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert > Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-20698 > https://issues.apache.org/jira/browse/AMBARI-20698 > > > Repository: ambari > > > Description > --- > > UI be able to export a blueprint when a user reaches the Deploy page and the > bp can be used to install a cluster later on. > This patch exports blueprint and template. Currently HostGroups are formed > only based on the component mapping. In this patch configGroups are not > addressed. ConfigGroup and other improvements will be addressed in next > revisions of this functionality. > > > Diffs > - > > ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 > ambari-web/app/messages.js 8f8d981af7 > ambari-web/app/templates/wizard/step8.hbs ac32710468 > ambari-web/test/controllers/wizard/step8_test.js 7cdb69ab34 > > > Diff: https://reviews.apache.org/r/58864/diff/3/ > > > Testing > --- > > Manual Testing done. I have attached blueprint.json and clustertemplate.json > files that are currently generated with this patch applied. > > > File Attachments > > > exported_blueprint > > https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json > exported_clustertemplate > > https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json > > > Thanks, > > Amruta Borkar > >
Review Request 58981: Service Auto-Start behavior is incorrect for Service Administrator and Service Operator Roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58981/ --- Review request for Ambari, Alexandr Antonenko and Robert Levas. Bugs: AMBARI-20925 https://issues.apache.org/jira/browse/AMBARI-20925 Repository: ambari Description --- As per the Role based access control list, users with Service Administrator role should be able to manage service auto-start while users with Service Operator role should not have this privilege. Currently, the following 2 issues are seen: 1. Service Operators can view Service Auto Start menu item which is not as per the accesss control list. 2. Service Administrators cannot enable or disable auto-start at service level because clicking on the Service Auto Start menu item returns them to the main services dashboard. The menu item is displayed incorrectly fot Service Operators because we are checking for SERVICE.START_STOP and CLUSTER.MODIFY_CONFIGS privileges. If user has either privilege, we display the menu. To fix this, we need to add a check for SERVICE.MANAGE_AUTO_START and CLUSTER.MANAGE_AUTO_START. If the user has either of these privileges, then the menu item should be enabled. Also, when the menu is clicked, we are checking only for CLUSTER.MANAGE_AUTO_START privilege but not for SERVICE.MANAGE_AUTO_START (which is the privilege that Service Administrators have). Hence, for Service Administrators, clicking on the menu results in incorrect navigation to the dashboard instead of displaying the Service Auto Start page. To fix this, we need to add a check for SERVICE.MANAGE_AUTO_START privilege as well. Diffs - ambari-web/app/routes/main.js 1f881e0 ambari-web/app/views/main/admin.js 0fa84e8 ambari-web/app/views/main/menu.js 6e79aba Diff: https://reviews.apache.org/r/58981/diff/1/ Testing --- Manual Testing with all 5 roles and Ambari admin. mvn clean test. Thanks, Sangeeta Ravindran
Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58864/#review173824
---
ambari-web/app/templates/wizard/step8.hbs
Lines 102 (patched)
<https://reviews.apache.org/r/58864/#comment246864>
You can use the download icon.
- Sangeeta Ravindran
On May 1, 2017, 9:06 p.m., Amruta Borkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58864/
> ---
>
> (Updated May 1, 2017, 9:06 p.m.)
>
>
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert
> Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-20698
> https://issues.apache.org/jira/browse/AMBARI-20698
>
>
> Repository: ambari
>
>
> Description
> ---
>
> UI be able to export a blueprint when a user reaches the Deploy page and the
> bp can be used to install a cluster later on.
> This patch exports blueprint and template. Currently HostGroups are formed
> only based on the component mapping. In this patch configGroups are not
> addressed. ConfigGroup and other improvements will be addressed in next
> revisions of this functionality.
>
>
> Diffs
> -
>
> ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48
> ambari-web/app/messages.js 8f8d981af7
> ambari-web/app/templates/wizard/step8.hbs ac32710468
>
>
> Diff: https://reviews.apache.org/r/58864/diff/1/
>
>
> Testing
> ---
>
> Manual Testing done. I have attached blueprint.json and clustertemplate.json
> files that are currently generated with this patch applied.
>
>
> File Attachments
>
>
> exported_blueprint
>
> https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json
> exported_clustertemplate
>
> https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58864/#review173808 --- ambari-web/app/templates/wizard/step8.hbs Lines 102 (patched) <https://reviews.apache.org/r/58864/#comment246847> If this patch intends to add the functionality only during cluster install and not Add Service wizard, then the button should displayed conditionally. - Sangeeta Ravindran On May 1, 2017, 9:06 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58864/ > --- > > (Updated May 1, 2017, 9:06 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert > Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-20698 > https://issues.apache.org/jira/browse/AMBARI-20698 > > > Repository: ambari > > > Description > --- > > UI be able to export a blueprint when a user reaches the Deploy page and the > bp can be used to install a cluster later on. > This patch exports blueprint and template. Currently HostGroups are formed > only based on the component mapping. In this patch configGroups are not > addressed. ConfigGroup and other improvements will be addressed in next > revisions of this functionality. > > > Diffs > - > > ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 > ambari-web/app/messages.js 8f8d981af7 > ambari-web/app/templates/wizard/step8.hbs ac32710468 > > > Diff: https://reviews.apache.org/r/58864/diff/1/ > > > Testing > --- > > Manual Testing done. I have attached blueprint.json and clustertemplate.json > files that are currently generated with this patch applied. > > > File Attachments > > > exported_blueprint > > https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json > exported_clustertemplate > > https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json > > > Thanks, > > Amruta Borkar > >
Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58864/#review173802 --- ambari-web/app/controllers/wizard/step8_controller.js Lines 21 (patched) <https://reviews.apache.org/r/58864/#comment246838> Good practice to add a semi-colon. - Sangeeta Ravindran On May 1, 2017, 9:06 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58864/ > --- > > (Updated May 1, 2017, 9:06 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert > Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-20698 > https://issues.apache.org/jira/browse/AMBARI-20698 > > > Repository: ambari > > > Description > --- > > UI be able to export a blueprint when a user reaches the Deploy page and the > bp can be used to install a cluster later on. > This patch exports blueprint and template. Currently HostGroups are formed > only based on the component mapping. In this patch configGroups are not > addressed. ConfigGroup and other improvements will be addressed in next > revisions of this functionality. > > > Diffs > - > > ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 > ambari-web/app/messages.js 8f8d981af7 > ambari-web/app/templates/wizard/step8.hbs ac32710468 > > > Diff: https://reviews.apache.org/r/58864/diff/1/ > > > Testing > --- > > Manual Testing done. I have attached blueprint.json and clustertemplate.json > files that are currently generated with this patch applied. > > > File Attachments > > > exported_blueprint > > https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json > exported_clustertemplate > > https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json > > > Thanks, > > Amruta Borkar > >
Re: Review Request 58480: Files View: In non-HA environment, Files view executes with error when "List of NameNodes" property is cleared
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58480/ --- (Updated April 26, 2017, 8:18 p.m.) Review request for Ambari, Alexandr Antonenko, Di Li, DIPAYAN BHOWMICK, and Tim Thorpe. Bugs: AMBARI-20354 https://issues.apache.org/jira/browse/AMBARI-20354 Repository: ambari Description --- 1. In a multi-node cluster where namenode HA is not enabled, create a Files View. Select Custom Configuration and enter the WebHDFS FileSystem URI*. In the "List of NameNodes", enter the namenode information. Save and execute view. There are no errors. 2. Edit the view and delete the values entered in the "List of NameNodes" field. Save and execute the view. The following error is thrown although Namenode HA is not enabled. Service 'hdfs' check failed: HDFS080 webhdfs.ha.namenodes.list namenodes count is not exactly 2 Diffs (updated) - contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java 714e229 Diff: https://reviews.apache.org/r/58480/diff/2/ Changes: https://reviews.apache.org/r/58480/diff/1-2/ Testing --- Manual testing. Thanks, Sangeeta Ravindran
Re: Review Request 58590: Provide an optional attribute for custom commands to specify title used in operations window title
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/ --- (Updated April 25, 2017, 4:51 a.m.) Review request for Ambari, Di Li and Tim Thorpe. Bugs: AMBARI-20616 https://issues.apache.org/jira/browse/AMBARI-20616 Repository: ambari Description --- Some services in our stack have custom commands where the name is a combination of an operation and a component name. For e.g. Remove_Logical_myservice_mycomponent When the custom command is being executed, the operations window title is displayed as "Remove Logical myservice mycomponent mycomponent" It would be useful to provide an optional attribute e.g. opsDisplayName for custom commands to allow specifying the string for the title displayed in the operations window. Remove_Logical_myservice_mycomponent true scripts/mycomponent.py PYTHON 10800 Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java 87a6edf ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 17bc718 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 20b0417 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 86feceb ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java 280a59b ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 633d837 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d ambari-server/src/main/resources/properties.json c2545fe ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 8a52b8a ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java fec041c ambari-web/app/controllers/wizard/step9_controller.js 4697dad ambari-web/app/utils/ajax/ajax.js 5d7108f ambari-web/app/utils/helper.js 03a2e82 ambari-web/app/utils/host_progress_popup.js c615cae ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 ambari-web/test/utils/helper_test.js 4b9ec36 Diff: https://reviews.apache.org/r/58590/diff/3/ Changes: https://reviews.apache.org/r/58590/diff/2-3/ Testing --- Manual Testing. Added new test cases. Thanks, Sangeeta Ravindran
Re: Review Request 58590: Provide an optional attribute for custom commands to specify title used in operations window title
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/ --- (Updated April 24, 2017, 11:35 p.m.) Review request for Ambari, Di Li and Tim Thorpe. Summary (updated) - Provide an optional attribute for custom commands to specify title used in operations window title Bugs: AMBARI-20616 https://issues.apache.org/jira/browse/AMBARI-20616 Repository: ambari Description --- Some services in our stack have custom commands where the name is a combination of an operation and a component name. For e.g. Remove_Logical_myservice_mycomponent When the custom command is being executed, the operations window title is displayed as "Remove Logical myservice mycomponent mycomponent" It would be useful to provide an optional attribute e.g. opsDisplayName for custom commands to allow specifying the string for the title displayed in the operations window. Remove_Logical_myservice_mycomponent true scripts/mycomponent.py PYTHON 10800 Diffs - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java 87a6edf ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 17bc718 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 20b0417 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 86feceb ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java 280a59b ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 633d837 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d ambari-server/src/main/resources/properties.json c2545fe ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 8a52b8a ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java fec041c ambari-web/app/controllers/wizard/step9_controller.js 4697dad ambari-web/app/utils/ajax/ajax.js 2b5e52a ambari-web/app/utils/helper.js 03a2e82 ambari-web/app/utils/host_progress_popup.js c615cae ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 ambari-web/test/utils/helper_test.js 4b9ec36 Diff: https://reviews.apache.org/r/58590/diff/2/ Testing --- Manual Testing. Added new test cases. Thanks, Sangeeta Ravindran
Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title
> On April 20, 2017, 8:06 p.m., Tim Thorpe wrote: > > Has upgrade been tested? Hello Tim, Yes I upgraded an ambari 2.4 cluster and verified that the new column gets added to the host_role_command table. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172542 --- On April 24, 2017, 11:33 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58590/ > --- > > (Updated April 24, 2017, 11:33 p.m.) > > > Review request for Ambari, Di Li and Tim Thorpe. > > > Bugs: AMBARI-20616 > https://issues.apache.org/jira/browse/AMBARI-20616 > > > Repository: ambari > > > Description > --- > > Some services in our stack have custom commands where the name is a > combination of an operation and a component name. > > For e.g. Remove_Logical_myservice_mycomponent > > When the custom command is being executed, the operations window title is > displayed as "Remove Logical myservice mycomponent mycomponent" > > It would be useful to provide an optional attribute e.g. opsDisplayName for > custom commands to allow specifying the string for the title displayed in the > operations window. > > > Remove_Logical_myservice_mycomponent > true > > scripts/mycomponent.py > PYTHON > 10800 > > > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > 87a6edf > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 17bc718 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java > 20b0417 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > 86feceb > > ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java > 280a59b > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 633d837 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d > ambari-server/src/main/resources/properties.json c2545fe > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java > 8a52b8a > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > fec041c > ambari-web/app/controllers/wizard/step9_controller.js 4697dad > ambari-web/app/utils/ajax/ajax.js 2b5e52a > ambari-web/app/utils/helper.js 03a2e82 > ambari-web/app/utils/host_progress_popup.js c615cae > ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 > ambari-web/test/utils/helper_test.js 4b9ec36 > > > Diff: https://reviews.apache.org/r/58590/diff/2/ > > > Testing > --- > > Manual Testing. > Added new test cases. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title
> On April 21, 2017, 5:45 a.m., Attila Doroszlai wrote: > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java > > Lines 24-25 (patched) > > <https://reviews.apache.org/r/58590/diff/1/?file=1695882#file1695882line24> > > > > Unused imports Thanks. I've removed the unused imports. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172586 --- On April 24, 2017, 11:33 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58590/ > --- > > (Updated April 24, 2017, 11:33 p.m.) > > > Review request for Ambari, Di Li and Tim Thorpe. > > > Bugs: AMBARI-20616 > https://issues.apache.org/jira/browse/AMBARI-20616 > > > Repository: ambari > > > Description > --- > > Some services in our stack have custom commands where the name is a > combination of an operation and a component name. > > For e.g. Remove_Logical_myservice_mycomponent > > When the custom command is being executed, the operations window title is > displayed as "Remove Logical myservice mycomponent mycomponent" > > It would be useful to provide an optional attribute e.g. opsDisplayName for > custom commands to allow specifying the string for the title displayed in the > operations window. > > > Remove_Logical_myservice_mycomponent > true > > scripts/mycomponent.py > PYTHON > 10800 > > > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > 87a6edf > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 17bc718 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java > 20b0417 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > 86feceb > > ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java > 280a59b > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 633d837 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d > ambari-server/src/main/resources/properties.json c2545fe > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java > 8a52b8a > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > fec041c > ambari-web/app/controllers/wizard/step9_controller.js 4697dad > ambari-web/app/utils/ajax/ajax.js 2b5e52a > ambari-web/app/utils/helper.js 03a2e82 > ambari-web/app/utils/host_progress_popup.js c615cae > ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 > ambari-web/test/utils/helper_test.js 4b9ec36 > > > Diff: https://reviews.apache.org/r/58590/diff/2/ > > > Testing > --- > > Manual Testing. > Added new test cases. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title
> On April 20, 2017, 9:32 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > > Lines 72 (patched) > > <https://reviews.apache.org/r/58590/diff/1/?file=1695868#file1695868line72> > > > > I would suggest to actually have a field to overwrite the display name > > to use in order to make it more flexible. > > > > The reason being that the custom command name is used to find the > > function in python, which is not necessarily very human readable. > > Alejandro Fernandez wrote: > Sangeeta, what do you think about this? I think it will be more flexible > in the long run. > > Sangeeta Ravindran wrote: > Hi Alejandro, > > Yes I think, it would be better to have a field to allow custom commands > to overwrite the display name. I have created an updated patch based on your > suggestion and will attach it shortly. I've added the updated patch. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172549 --- On April 24, 2017, 11:33 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58590/ > --- > > (Updated April 24, 2017, 11:33 p.m.) > > > Review request for Ambari, Di Li and Tim Thorpe. > > > Bugs: AMBARI-20616 > https://issues.apache.org/jira/browse/AMBARI-20616 > > > Repository: ambari > > > Description > --- > > Some services in our stack have custom commands where the name is a > combination of an operation and a component name. > > For e.g. Remove_Logical_myservice_mycomponent > > When the custom command is being executed, the operations window title is > displayed as "Remove Logical myservice mycomponent mycomponent" > > It would be useful to provide an optional attribute e.g. opsDisplayName for > custom commands to allow specifying the string for the title displayed in the > operations window. > > > Remove_Logical_myservice_mycomponent > true > > scripts/mycomponent.py > PYTHON > 10800 > > > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > 87a6edf > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 17bc718 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java > 20b0417 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > 86feceb > > ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java > 280a59b > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 633d837 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d > ambari-server/src/main/resources/properties.json c2545fe > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java > 8a52b8a > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > fec041c > ambari-web/app/controllers/wizard/step9_controller.js 4697dad > ambari-web/app/utils/ajax/ajax.js 2b5e52a > ambari-web/app/utils/helper.js 03a2e82 > ambari-web/app/utils/host_progress_popup.js c615cae > ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 > ambari-web/test/utils/helper_test.js 4b9ec36 > > > Diff: https://reviews.apache.org/r/58590/diff/2/ > > > Testing > --- > > Manual Testing. > Added new test cases. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/ --- (Updated April 24, 2017, 11:33 p.m.) Review request for Ambari, Di Li and Tim Thorpe. Bugs: AMBARI-20616 https://issues.apache.org/jira/browse/AMBARI-20616 Repository: ambari Description (updated) --- Some services in our stack have custom commands where the name is a combination of an operation and a component name. For e.g. Remove_Logical_myservice_mycomponent When the custom command is being executed, the operations window title is displayed as "Remove Logical myservice mycomponent mycomponent" It would be useful to provide an optional attribute e.g. opsDisplayName for custom commands to allow specifying the string for the title displayed in the operations window. Remove_Logical_myservice_mycomponent true scripts/mycomponent.py PYTHON 10800 Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java 87a6edf ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 17bc718 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 20b0417 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 86feceb ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java 280a59b ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 633d837 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d ambari-server/src/main/resources/properties.json c2545fe ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 8a52b8a ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java fec041c ambari-web/app/controllers/wizard/step9_controller.js 4697dad ambari-web/app/utils/ajax/ajax.js 2b5e52a ambari-web/app/utils/helper.js 03a2e82 ambari-web/app/utils/host_progress_popup.js c615cae ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 ambari-web/test/utils/helper_test.js 4b9ec36 Diff: https://reviews.apache.org/r/58590/diff/2/ Changes: https://reviews.apache.org/r/58590/diff/1-2/ Testing --- Manual Testing. Added new test cases. Thanks, Sangeeta Ravindran
Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title
> On April 20, 2017, 9:32 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > > Lines 72 (patched) > > <https://reviews.apache.org/r/58590/diff/1/?file=1695868#file1695868line72> > > > > I would suggest to actually have a field to overwrite the display name > > to use in order to make it more flexible. > > > > The reason being that the custom command name is used to find the > > function in python, which is not necessarily very human readable. > > Alejandro Fernandez wrote: > Sangeeta, what do you think about this? I think it will be more flexible > in the long run. Hi Alejandro, Yes I think, it would be better to have a field to allow custom commands to overwrite the display name. I have created an updated patch based on your suggestion and will attach it shortly. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172549 --- On April 20, 2017, 7:53 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58590/ > --- > > (Updated April 20, 2017, 7:53 p.m.) > > > Review request for Ambari, Di Li and Tim Thorpe. > > > Bugs: AMBARI-20616 > https://issues.apache.org/jira/browse/AMBARI-20616 > > > Repository: ambari > > > Description > --- > > Some services in our stack have custom commands where the name is a > combination of an operation and a component name. > > For e.g. Remove_Logical_myservice_mycomponent > > When the custom command is being executed, the operations window title is > displayed as "Remove Logical myservice mycomponent mycomponent" > > It would be useful to provide an optional attribute e.g. useNameInOps for > custom commands to allow using the command name itself as the title displayed > in the operations window. > > > Remove_Logical_myservice_mycomponent > true > > scripts/mycomponent.py > PYTHON > 10800 > > > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > 87a6edf > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 17bc718 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java > 20b0417 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > 86feceb > > ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java > 280a59b > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 633d837 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d > ambari-server/src/main/resources/properties.json c2545fe > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java > 8a52b8a > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > fec041c > ambari-web/app/controllers/wizard/step9_controller.js 4697dad > ambari-web/app/utils/ajax/ajax.js 2b5e52a > ambari-web/app/utils/helper.js 03a2e82 > ambari-web/app/utils/host_progress_popup.js c615cae > ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 > ambari-web/test/utils/helper_test.js 4b9ec36 > > > Diff: https://reviews.apache.org/r/58590/diff/1/ > > > Testing > --- > > Manual Testing. > Added new test cases. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/ --- (Updated April 20, 2017, 7:53 p.m.) Review request for Ambari, Di Li and Tim Thorpe. Summary (updated) - Provide an optional attribute for custom commands to allow using command name in operations window title Bugs: AMBARI-20616 https://issues.apache.org/jira/browse/AMBARI-20616 Repository: ambari Description --- Some services in our stack have custom commands where the name is a combination of an operation and a component name. For e.g. Remove_Logical_myservice_mycomponent When the custom command is being executed, the operations window title is displayed as "Remove Logical myservice mycomponent mycomponent" It would be useful to provide an optional attribute e.g. useNameInOps for custom commands to allow using the command name itself as the title displayed in the operations window. Remove_Logical_myservice_mycomponent true scripts/mycomponent.py PYTHON 10800 Diffs - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java 87a6edf ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 17bc718 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 20b0417 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 86feceb ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java 280a59b ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 633d837 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d ambari-server/src/main/resources/properties.json c2545fe ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 8a52b8a ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java fec041c ambari-web/app/controllers/wizard/step9_controller.js 4697dad ambari-web/app/utils/ajax/ajax.js 2b5e52a ambari-web/app/utils/helper.js 03a2e82 ambari-web/app/utils/host_progress_popup.js c615cae ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 ambari-web/test/utils/helper_test.js 4b9ec36 Diff: https://reviews.apache.org/r/58590/diff/1/ Testing --- Manual Testing. Added new test cases. Thanks, Sangeeta Ravindran
Review Request 58590: Provide an optional attribute for custom commands to specify string used in operations window title
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/ --- Review request for Ambari, Di Li and Tim Thorpe. Bugs: AMBARI-20616 https://issues.apache.org/jira/browse/AMBARI-20616 Repository: ambari Description --- Some services in our stack have custom commands where the name is a combination of an operation and a component name. For e.g. Remove_Logical_myservice_mycomponent When the custom command is being executed, the operations window title is displayed as "Remove Logical myservice mycomponent mycomponent" It would be useful to provide an optional attribute e.g. useNameInOps for custom commands to allow using the command name itself as the title displayed in the operations window. Remove_Logical_myservice_mycomponent true scripts/mycomponent.py PYTHON 10800 Diffs - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java 87a6edf ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 17bc718 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 20b0417 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 86feceb ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java 280a59b ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 633d837 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d ambari-server/src/main/resources/properties.json c2545fe ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 8a52b8a ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java fec041c ambari-web/app/controllers/wizard/step9_controller.js 4697dad ambari-web/app/utils/ajax/ajax.js 2b5e52a ambari-web/app/utils/helper.js 03a2e82 ambari-web/app/utils/host_progress_popup.js c615cae ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 ambari-web/test/utils/helper_test.js 4b9ec36 Diff: https://reviews.apache.org/r/58590/diff/1/ Testing --- Manual Testing. Added new test cases. Thanks, Sangeeta Ravindran
Re: Review Request 58534: AMBARI-20784 Able to hide the "Why public repo not selected" when no stacks have repoinfo.xml with the "latest" section
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58534/#review172360 --- Ship it! Ship It! - Sangeeta Ravindran On April 19, 2017, 4:22 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58534/ > --- > > (Updated April 19, 2017, 4:22 p.m.) > > > Review request for Ambari, Jaimin Jetly, Sangeeta Ravindran, and Tim Thorpe. > > > Bugs: Ambari-20784 > https://issues.apache.org/jira/browse/Ambari-20784 > > > Repository: ambari > > > Description > --- > > Able to hide the "Why public repo not selected" when no stacks have > repoinfo.xml with the "latest" section. There is no point of display the > error based on the stackDefault checking when no stacks even offer the > "latest" section in their repoinfo.xml. > > > Diffs > - > > ambari-web/app/controllers/wizard/step1_controller.js 2ac295b > ambari-web/app/mappers/stack_mapper.js 4b6a6f8 > ambari-web/app/models/stack.js dbc2d72 > ambari-web/app/templates/wizard/step1.hbs 769aca3 > ambari-web/app/utils/ajax/ajax.js 2d157fe > > > Diff: https://reviews.apache.org/r/58534/diff/1/ > > > Testing > --- > > existing unit tests > Build Ambari server and agent RPMs off trunk code with the changes, run > install. Modify repoinfo.xml in 2.x and 3.0 stacks to remove > section, verify the "Why not selected" is hidden. and when some stacks have > the section, the link shows up if no stacks have repo with > stackDefault=False. > > > Thanks, > > Di Li > >
Review Request 58480: Files View: In non-HA environment, Files view executes with error when "List of NameNodes" property is cleared
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58480/ --- Review request for Ambari, Di Li and DIPAYAN BHOWMICK. Bugs: AMBARI-20354 https://issues.apache.org/jira/browse/AMBARI-20354 Repository: ambari Description --- 1. In a multi-node cluster where namenode HA is not enabled, create a Files View. Select Custom Configuration and enter the WebHDFS FileSystem URI*. In the "List of NameNodes", enter the namenode information. Save and execute view. There are no errors. 2. Edit the view and delete the values entered in the "List of NameNodes" field. Save and execute the view. The following error is thrown although Namenode HA is not enabled. Service 'hdfs' check failed: HDFS080 webhdfs.ha.namenodes.list namenodes count is not exactly 2 Diffs - contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java 7e174a7 Diff: https://reviews.apache.org/r/58480/diff/1/ Testing --- Manual testing. Thanks, Sangeeta Ravindran
Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58423/#review171908 --- Ship it! Ship It! - Sangeeta Ravindran On April 13, 2017, 6:19 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58423/ > --- > > (Updated April 13, 2017, 6:19 p.m.) > > > Review request for Ambari, Di Li and Sangeeta Ravindran. > > > Bugs: AMBARI-20757 > https://issues.apache.org/jira/browse/AMBARI-20757 > > > Repository: ambari > > > Description > --- > > In order to see what has gone wrong, you need to drill down into the last > step until you find the service check that failed. Ideally there would be a > message above where they normally appear. > > > Diffs > - > > ambari-web/app/messages.js 4513775 > ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs > f6be5d1 > > > Diff: https://reviews.apache.org/r/58423/diff/3/ > > > Testing > --- > > This was tested manually while testing upgrade. > > > Thanks, > > Tim Thorpe > >
Review Request 58425: Remove Server attribute from the HTTP response headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58425/ --- Review request for Ambari, Di Li, Robert Levas, and Tim Thorpe. Bugs: AMBARI-20650 https://issues.apache.org/jira/browse/AMBARI-20650 Repository: ambari Description --- Currently the HTTP response header contains the Jetty version. Server:Jetty(8.1.19.v20160209) To follow best security practices, it would be good to avoid including this information in the response headers. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 4e7af0c Diff: https://reviews.apache.org/r/58425/diff/1/ Testing --- Manual Testing. Verified that "Server" header is removed from the HTTP response headers. Thanks, Sangeeta Ravindran
Re: Review Request 58371: AMBARI-20737 Able to hide the Use Public Repository option on Register Version page on Ambari Admin View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58371/#review171898 --- Ship it! Ship It! - Sangeeta Ravindran On April 11, 2017, 9:26 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58371/ > --- > > (Updated April 11, 2017, 9:26 p.m.) > > > Review request for Ambari, Jaimin Jetly, Sangeeta Ravindran, and Tim Thorpe. > > > Bugs: AMBARI-20737 > https://issues.apache.org/jira/browse/AMBARI-20737 > > > Repository: ambari > > > Description > --- > > The Register Version UI page on Ambari Admin View shows two options related > to adding repo URLs: Use Public Repository and Use Local Repository. > The Use Public Repository is disabled when no stack repos are marked as > "stack_default=false" ( meaning it;s from the stack/repo URL defined in the > "latest" section in the repoinfo.xml) > When repoinfo.xml does not have the latest section, however, the Use Public > Repository should be hidden from the view as it'd be definitely no > non-default stacks, and the "Why is this disabled ?" explanation does not > make sense in this case. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > b3c27dc > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > e028906 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > 3bee2a1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java > 352aa2d > > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java > 507c560 > > > Diff: https://reviews.apache.org/r/58371/diff/1/ > > > Testing > --- > > unit tests > patched a trunk cluster with the change, when all repoinfo.xml from all > stacks do not have the "latest" section, the Use Public Repository radio > button is hidden. When at least one repoinfo.xml has the "latest" section, > the Use Public Repository radio button is shown. > > > Thanks, > > Di Li > >
Re: Review Request 58211: AMBARI-20674 About to hide the Delete menu item from UI for a given service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58211/#review171157 --- Ship it! Ship It! - Sangeeta Ravindran On April 5, 2017, 3:37 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58211/ > --- > > (Updated April 5, 2017, 3:37 p.m.) > > > Review request for Ambari, Sangeeta Ravindran and Tim Thorpe. > > > Bugs: AMBARI-20674 > https://issues.apache.org/jira/browse/AMBARI-20674 > > > Repository: ambari > > > Description > --- > > Stack driven approach to have UI show/hide Delete service menu item for a > given service. > A service's metainfo.xml can have > false set at the service level to > indicate UI should hide the menu item. Directly going thru REST API calls are > always supported and non-restricted. > If the section is missing, it will be treated as "support" UI delete service > operation. In other words, UI only hides the menu item if metainfo.xml has > explicitly set the flag to false. > Example. > "" + > " 2.0" + > " " + > " " + > " HDFS" + > " HDFS" + > " false" + > " " + > " " + > ""; > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > cbff300 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > a30d783 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > fd65268 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 0d0b78b > ambari-server/src/main/resources/properties.json 04d32ea > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java > 1b9296e > ambari-web/app/app.js 9c7d874 > ambari-web/app/mappers/stack_service_mapper.js 4bda89d > ambari-web/app/models/host_component.js 3950f97 > ambari-web/app/models/stack_service.js 4f21288 > ambari-web/test/mappers/stack_service_mapper_test.js 9da8b24 > ambari-web/test/views/main/service/item_test.js 4b2e6f9 > > > Diff: https://reviews.apache.org/r/58211/diff/1/ > > > Testing > --- > > unit testing > Install a trunk cluster with HDP 2.6 stack.Patch it with the code change both > ambari server and UI change, then update metainfo.xml for hbase in common > services (to test inheritance) verify UI does not show Delete service menu > item for HBase after restart Ambari server. > > > Thanks, > > Di Li > >
Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57709/#review169575 --- Ship it! Ship It! - Sangeeta Ravindran On March 16, 2017, 10:40 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57709/ > --- > > (Updated March 16, 2017, 10:40 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta > Ravindran. > > > Bugs: AMBARI-20334 > https://issues.apache.org/jira/browse/AMBARI-20334 > > > Repository: ambari > > > Description > --- > > capacity field in yarn queue manager should allow entering decimal numbers > upto 2 places, > > currently the field allows entering values like > > 1.2.3 > 12... > 1 2.3 > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > b6c419a > > > Diff: https://reviews.apache.org/r/57709/diff/1/ > > > Testing > --- > > Tested manually > > > Thanks, > > Anita Jebaraj > >
Review Request 57525: Assign Slaves and Clients page displays incorrect configuration unless a change is made in Assign Masters page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57525/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-20402 https://issues.apache.org/jira/browse/AMBARI-20402 Repository: ambari Description --- Ambari install wizard seems to give recommendations that are not in line with best practices by default. Furthermore, if you make any change to the master node assignments and then undo it, the recommended configuration seems to change and appears correct. This happens because the initial call to get stack advisor recommendations is made before UI elements have been fully populated on Assign Masters page. As a result, the recommendations returned do not take into account the host configuration. Recommendations are fetched again after UI elements are fully rendered, but because there are existing recommendations, the AJAX call is not made (this check has been put in to avoid repetitive AJAX calls while user moves back and forth between Assign Masters and Assign Slaves and Clients page). Fix is to add a new flag to track the case where user navigates between Step 5 and 6. Only for that specific case, we will not make the AJAX call. If any configuration changes are made however, recommendations are reset and the AJAX call is made again as required. Build failure is unrelated to the patch. I was able to apply the patch successfully to latest 2.5 code and build and test successfully. Diffs - ambari-web/app/mixins/wizard/assign_master_components.js 60c6eeb Diff: https://reviews.apache.org/r/57525/diff/1/ Testing --- Manual Tests. Ran mvn clean test 30367 passing (41s) 157 pending Thanks, Sangeeta Ravindran
Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57467/#review168489 --- Ship it! Ship It! - Sangeeta Ravindran On March 9, 2017, 5:24 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57467/ > --- > > (Updated March 9, 2017, 5:24 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20363 > https://issues.apache.org/jira/browse/AMBARI-20363 > > > Repository: ambari > > > Description > --- > > In the "Access Control and Status, clear the content of Users under the > "Administer Queue". It' still shows the user icon in Effective Administraters. > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js > 513031c > > > Diff: https://reviews.apache.org/r/57467/diff/1/ > > > Testing > --- > > Tested manually > > > File Attachments > > > Before Fix > > https://reviews.apache.org/media/uploaded/files/2017/03/09/6ca6a48d-cde2-4e1b-a209-aa898244c998__beforefix.png > After fix > > https://reviews.apache.org/media/uploaded/files/2017/03/09/062bb336-0706-442d-a638-f07f8f8363b3__afterFix.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/#review168488 --- Ship it! Ship It! - Sangeeta Ravindran On March 8, 2017, 11:15 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57346/ > --- > > (Updated March 8, 2017, 11:15 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20333 > https://issues.apache.org/jira/browse/AMBARI-20333 > > > Repository: ambari > > > Description > --- > > According to yarn documentation, > "yarn.scheduler.capacity..user-limit-factor" should be a float: > https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html > > Hence the user should be allowed to enter decimal values for 'User limit > factor' > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > 8eb06c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > 69f5b3b > > > Diff: https://reviews.apache.org/r/57346/diff/3/ > > > Testing > --- > > Tested manually > > > File Attachments > > > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/06/f55e8f25-b625-4285-96ee-beb4fa6992a4__screenshot-1.png > screenshot-1.png > > https://reviews.apache.org/media/uploaded/files/2017/03/07/aaae7eff-4584-42d4-800b-68b880c68b04__screenshot-1.png > > > Thanks, > > Anita Jebaraj > >
Review Request 57429: WFM: Page numbers on workflow dashboard are not calculated correctly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57429/
---
Review request for Ambari, Di Li and DIPAYAN BHOWMICK.
Bugs: AMBARI-20352
https://issues.apache.org/jira/browse/AMBARI-20352
Repository: ambari
Description
---
When the number of workflows exceeds 15, you can see additional pages in the
workflow dashboard.
The pag number calculation is not correct. On page 2, the page number is
displayed as 1.665.
This is because roundedStart is not calculated based on the number of records a
page holds (jobs.pageSize).
var roundedStart = this.get('jobs.start') - this.get('jobs.start') % 10;
Fix is to use the jobs.pageSize instead.
Diffs
-
contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js
5f92d6f
Diff: https://reviews.apache.org/r/57429/diff/1/
Testing
---
Manual Tessting.
Build failure is unrelated.
Thanks,
Sangeeta Ravindran
Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168317 --- Ship it! Ship It! - Sangeeta Ravindran On March 8, 2017, 5 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > --- > > (Updated March 8, 2017, 5 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr > Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > --- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 0991814 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 51114f8 > > > Diff: https://reviews.apache.org/r/57168/diff/5/ > > > Testing > --- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
Review Request 56503: Cannot change user passwords
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56503/ --- Review request for Ambari, Alexandr Antonenko, Di Li, and Jaimin Jetly. Bugs: AMBARI-19910 https://issues.apache.org/jira/browse/AMBARI-19910 Repository: ambari Description --- 1. Create a user for e.g. test and set a password (that does not match the password of the logged in user). 2. Click on Change Password and enter the old and new passwords. 3. Click on OK. An error is displayed and you cannot change password although the current password is correct. Cannot change password org.apache.ambari.server.controller.spi.SystemException: An internal system exception occurred: Wrong current password provided This seems to happen because in modifyPassword method in Users.java, we compare the current password of the user (test), provided in the "Your Password" field in the UI, with the password of the logged in user (for e.g. admin). passwordEncoder.matches(currentUserPassword, currentUserEntity.getUserPassword()) In this case, currentUserPassword is the old password for "test" while currentUserEntity is the logged-in user "admin". So the old password for "test" gets compared to the password for "admin", the check fails and the error is thrown. Fix is to compare the old password with the password of the userEntity (which is the entity for "test"). I also updated the test cases in TestUsers.java accordingly. Diffs - ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java 4b3237b ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java 875fd46 Diff: https://reviews.apache.org/r/56503/diff/ Testing --- Manual testing. Ran mvn test. Thanks, Sangeeta Ravindran
Review Request 56051: Workflow Manager View : Separate log file into its own directory similar to other views
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56051/ --- Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore. Bugs: AMBARI-19763 https://issues.apache.org/jira/browse/AMBARI-19763 Repository: ambari Description --- Workflow manager view logs entries are currently in the ambari-server.log. It should be separated into its own folder under /var/log/ambari-server similar to the other views. Diffs - contrib/views/wfmanager/pom.xml 8016d7b contrib/views/wfmanager/src/main/resources/view.log4j.properties PRE-CREATION Diff: https://reviews.apache.org/r/56051/diff/ Testing --- Manual testing. Verified that the Workflow Manager view logs are written to wfmanager-view.log under /var/log/ambari-server/wfmanager-view Thanks, Sangeeta Ravindran
Review Request 55993: On Capacity Scheduler view, click "*" button for "Node label Access" the 2nd time should de-select all node labels, but it doesn't
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55993/ --- Review request for Ambari, Di Li and Gaurav Nagar. Bugs: AMBARI-19680 https://issues.apache.org/jira/browse/AMBARI-19680 Repository: ambari Description --- 1. Enable Node Labels and restart Yarn. 2. Add some node labels using the command below: [yarn@turns1 ~]$ yarn rmadmin -addToClusterNodeLabels "high_cpu,high_mem" [yarn@turns1 ~]$ yarn rmadmin -replaceLabelsOnNode "=high_cpu =high_mem" 3. Go to Capacity Scheduler view, click root queue, by default the "Enable node labels" button has been checked. 4. Click "*" button beside "Node Label Access", it will automatically make all node labels (high_cpu, high_mem) selected. Change capacity for the 2 node labels to 100%. 5. Click this button again, it should de-select the node labels, but it doesn't. This seems to happen because the list of labels for the selected queue is not cleared when the "*" button is deselected. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js df0c684 Diff: https://reviews.apache.org/r/55993/diff/ Testing --- Manual Testing. Enabling disabling the * button. Ran mvn test. Thanks, Sangeeta Ravindran
Review Request 55992: Workflow Manager: Path does not get set to selected directory when creating FS action node.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55992/ --- Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore. Bugs: AMBARI-19729 https://issues.apache.org/jira/browse/AMBARI-19729 Repository: ambari Description --- 1. Try to add a FS node to a workflow. 2. Browse and select a path and click on Select button. The Path field is still empty. Error in the browser console: Uncaught TypeError: Cannot set property 'path' of undefined at Object.u [as set] (vendor-4ae345a01092a915fe851b682258b76a.js:11) at n. (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:5) at Object.f [as apply] (vendor-4ae345a01092a915fe851b682258b76a.js:11) at Object.d [as sendEvent] (vendor-4ae345a01092a915fe851b682258b76a.js:10) at n.trigger [as _super] (vendor-4ae345a01092a915fe851b682258b76a.js:14) at n.trigger (vendor-4ae345a01092a915fe851b682258b76a.js:16) at n [as trigger] (vendor-4ae345a01092a915fe851b682258b76a.js:11) at n.closeFileBrowser (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:6) at n.send (vendor-4ae345a01092a915fe851b682258b76a.js:15) at n [as send] (vendor-4ae345a01092a915fe851b682258b76a.js:11) With the changes in AMBARI-19332, the input field for directory path was updated to prep.path (was prep.settings.path before). Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js ba9b91e Diff: https://reviews.apache.org/r/55992/diff/ Testing --- Tested manually. Build failure is unrelated to the patch. Thanks, Sangeeta Ravindran
Re: Review Request 55990: AMBARI-19728: Custom command name rendered incorrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55990/#review163148 --- Ship it! Ship It! - Sangeeta Ravindran On Jan. 26, 2017, 6:28 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55990/ > --- > > (Updated Jan. 26, 2017, 6:28 p.m.) > > > Review request for Ambari and Sangeeta Ravindran. > > > Bugs: AMBARI-19728 > https://issues.apache.org/jira/browse/AMBARI-19728 > > > Repository: ambari > > > Description > --- > > I have a custom command in my Hive service called update-hcat-conf. On the > UI, it's shown with label "Update HCat Client Client Conf". It should have > been displayed as "Update HCat Client Conf" > > > Diffs > - > > ambari-web/app/utils/helper.js 927f8a6 > ambari-web/test/utils/helper_test.js b438a7a > > Diff: https://reviews.apache.org/r/55990/diff/ > > > Testing > --- > > unit tests > patch a trunk cluster with the change, the label showed up on the UI correctly > > > Thanks, > > Di Li > >
Re: Review Request 55847: AMBARI-19657: Downgrade button does not work after restart Ambari server when upgrade wizard was left open
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55847/#review162666 --- Ship it! Ship It! - Sangeeta Ravindran On Jan. 23, 2017, 4:25 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55847/ > --- > > (Updated Jan. 23, 2017, 4:25 p.m.) > > > Review request for Ambari and Sangeeta Ravindran. > > > Bugs: AMBARI-19657 > https://issues.apache.org/jira/browse/AMBARI-19657 > > > Repository: ambari > > > Description > --- > > Run express/rolling upgrade on a trunk cluster. While the upgrade wizard UI > pauses on a manual step or a failed step, restart ambari server. Once the > Ambari Server restarts, reload Ambari web UI, observe that the wizard UI pops > up automatically with the paused step showing the Downgrade button. Clicking > the downgrade button doesn't do anything in this case because the > "currentVersion" variable in the controller isn't set yet. Workaround is to > close the wizard to force the Stack/Version page to reload, then reopen the > wizard and click the Downgrade button. > > > Diffs > - > > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > 4f88d2f > > Diff: https://reviews.apache.org/r/55847/diff/ > > > Testing > --- > > build trunk code, run upgrade, restart ambari server when the upgrade wizard > is opened and paused at a menu step. > existing web UI unit tests. > > > Thanks, > > Di Li > >
Re: Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/ --- (Updated Jan. 17, 2017, 9:45 p.m.) Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore. Bugs: AMBARI-19475 https://issues.apache.org/jira/browse/AMBARI-19475 Repository: ambari Description --- In the Workflow Manager View, when there are no co-ordinator or bundle records, the dashboard message says "Showing 1 to 0 of 0 records". This is because the start record is set to 1 by default. Fix is to set the start record to 0, if the total records is 0. Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js 78bc1c9 Diff: https://reviews.apache.org/r/55516/diff/ Testing --- Manual testing. Thanks, Sangeeta Ravindran
Re: Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records
> On Jan. 17, 2017, 7:25 p.m., DIPAYAN BHOWMICK wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js, > > line 140 > > <https://reviews.apache.org/r/55516/diff/1/?file=1605028#file1605028line140> > > > > Can we conditional ternary operator as an expression and change the > > code like: > > > > res.start = res.total > 0 ? start : 0; > > > > Looks, much cleaner to me. Thanks Dipayan. Uploaded the patch with the suggested change. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/#review161916 ------- On Jan. 17, 2017, 9:45 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55516/ > --- > > (Updated Jan. 17, 2017, 9:45 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore. > > > Bugs: AMBARI-19475 > https://issues.apache.org/jira/browse/AMBARI-19475 > > > Repository: ambari > > > Description > --- > > In the Workflow Manager View, when there are no co-ordinator or bundle > records, the dashboard message says "Showing 1 to 0 of 0 records". This is > because the start record is set to 1 by default. > > Fix is to set the start record to 0, if the total records is 0. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js > 78bc1c9 > > Diff: https://reviews.apache.org/r/55516/diff/ > > > Testing > --- > > Manual testing. > > > Thanks, > > Sangeeta Ravindran > >
Review Request 55586: Cannot change group/user privileges in list view if the user has VIEW.USER privilege
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55586/
---
Review request for Ambari, Oleg Nechiporenko and Richard Zang.
Bugs: AMBARI-19542
https://issues.apache.org/jira/browse/AMBARI-19542
Repository: ambari
Description
---
1. Create a view for e.g. Capacity Scheduler view and grant a group / user
permissions for the view.
2. Go to Roles list view. Try to assign the group / user a different role via
the List view.
There is no response in the UI and the role is not updated. On the browser
console, the following erorr can be seen.
DELETE
http://9.30.56.80:8081/api/v1/clusters/C1/privileges?PrivilegeInfo/privilege_id.in(416)
500 (Internal Server Error)
In the ambari-server.log, the following exception is seen:
Caused by: org.apache.ambari.server.AmbariException: Can't remove VIEW
permission from a CAPACITY-SCHEDULER{1.0.0} resource.
at
org.apache.ambari.server.controller.internal.PrivilegeResourceProvider$2.invoke(PrivilegeResourceProvider.java:460)
This does not happen when roles are assigned via the Block view.
This seems to be because the VIEW.USER privilege is also being passed in as one
of the privileges to be deleted when the role is being changed in the List view.
To fix this, the arrayOfPrivileges passed in for deletion to the backend should
not contain VIEW.USER privilege.
Diffs
-
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
9869d0b
Diff: https://reviews.apache.org/r/55586/diff/
Testing
---
Manual testing
Ran mvn test
Thanks,
Sangeeta Ravindran
Review Request 55523: When viewing details of a group, the group type is sometimes empty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55523/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-19535 https://issues.apache.org/jira/browse/AMBARI-19535 Repository: ambari Description --- When you click on a Group and view its details, sometimes the Type shows an empty value. The following error can be seen on the web console. vendor.js:22245 TypeError: Cannot read property 'LABEL_KEY' of undefined at main.js:2278 at wrappedCallback (vendor.js:23746) at vendor.js:23832 at Scope.$eval (vendor.js:24875) at Scope.$digest (vendor.js:24687) at Scope.$apply (vendor.js:24979) at done (vendor.js:20552) at completeRequest (vendor.js:20766) at XMLHttpRequest.xhr.onreadystatechange (vendor.js:20705) This is happenening because the REST call that fetches group type details (getGroupType) does not always return before the groupTypeName is set in getMembers. To fix this, moved the code for setting groupTypeName to the getGroupType method. The groupTypeName is now set once the group type has been retrieved by the REST call. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js aa6af2a Diff: https://reviews.apache.org/r/55523/diff/ Testing --- Manual testing. Ran mvn test. Thanks, Sangeeta Ravindran
Review Request 55522: Incorrect error message when trying to add a group to multiple roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55522/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-19476 https://issues.apache.org/jira/browse/AMBARI-19476 Repository: ambari Description --- 1. Create a group and assign roles to the group. 2. If you add the same group to multiple roles, the error message says "Only 1 role allowed per user". Updated the error message to say users or groups. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js a01324b ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js c170235 Diff: https://reviews.apache.org/r/55522/diff/ Testing --- Manual test verification. Ran mvn test. Thanks, Sangeeta Ravindran
Review Request 55518: When defining yarn.scheduler.capacity..accessible-node-labels with space, Yarn Queue Manager shows error for the queue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55518/ --- Review request for Ambari, Di Li and Gaurav Nagar. Bugs: AMBARI-19451 https://issues.apache.org/jira/browse/AMBARI-19451 Repository: ambari Description --- Per the Apache documentation for Yarn Node Labels (http://hadoop.apache.org/docs/r2.7.3/hadoop-yarn/hadoop-yarn-site/NodeLabel.html), queues that can only access nodes without labels are defined by setting the property "yarn.scheduler.capacity..accessible-node-labels" with space as the value. Reproduction Steps: 1. In the Capacity Scheduler view (Yarn Queue Manager), create queues q1,q2, and set accessible node labels for root,q1,q2 but not for default queue 2. Since there is no way to specify a "space" as the value for accessible node labels via Yarn Queue Manager, add this property manually via yarn configs. i.e. In Yarn -> Configs -> Scheduler, manually add yarn.scheduler.capacity.root.default.accessible-node-labels= (space after the =) 3. Save the configuration and restart Resource Manager as required 4. Return to Yarn Queue Manager, and click the default queue. It shows an error - Label is not exist on cluster. This seems to happen because in the capacity scheduler code, the value of the yarn.scheduler.capacity..accessible-node-labels..capacity is not trimmed and the " " string is considered to be a label. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js de19cc9 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueContainer.hbs 453bbbc Diff: https://reviews.apache.org/r/55518/diff/ Testing --- Manual test. mvn test Build failure is unrelated to the change. Also, I could not reproduce the build failure. The capacity scheduler code compiles cleanly. Thanks, Sangeeta Ravindran
Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/ --- Review request for Ambari, DIPAYAN BHOWMICK and Nitiraj Rathore. Bugs: AMBARI-19475 https://issues.apache.org/jira/browse/AMBARI-19475 Repository: ambari Description --- In the Workflow Manager View, when there are no co-ordinator or bundle records, the dashboard message says "Showing 1 to 0 of 0 records". This is because the start record is set to 1 by default. Fix is to set the start record to 0, if the total records is 0. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js 78bc1c9 Diff: https://reviews.apache.org/r/55516/diff/ Testing --- Manual testing. Thanks, Sangeeta Ravindran
Re: Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54911/ --- (Updated Dec. 20, 2016, 8:53 p.m.) Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-19206 https://issues.apache.org/jira/browse/AMBARI-19206 Repository: ambari Description --- On a cluster with ambari-metrics in distributed operation mode, after enabling Namenode HA, the amabri-metrics property for hbase.rootdir should point to hdfs://, but it actually still points to the explicit Namenode. In the Enable HA wizard, the updated property with nameservice is shown, but when you go to Ambari Metrics Config properties, hbase.rootdir still points to the old value. This is happening because while enabling name node HA, AMS needs to be reconfigured and the hbase.rootdir config property in ams-hbase-site needs to be updated to use the nameservice similar to other services such as HBase, Accumulo etc. Diffs - ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js fc44724 ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 713e1c3 ambari-web/app/messages.js 8ff4b55 ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js 10989e0 Diff: https://reviews.apache.org/r/54911/diff/ Testing --- Manual Testing. Tested enabling HA with both distributed and embedded operation mode for AMS. Also updated test case. Patch failure with hadoop qa is unrelated. File Attachments AMBARI-19206.patch https://reviews.apache.org/media/uploaded/files/2016/12/20/611ff5b0-1bf2-4b3c-a697-a69e7c1220d2__AMBARI-19206.patch Thanks, Sangeeta Ravindran
Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54911/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-19206 https://issues.apache.org/jira/browse/AMBARI-19206 Repository: ambari Description --- On a cluster with ambari-metrics in distributed operation mode, after enabling Namenode HA, the amabri-metrics property for hbase.rootdir should point to hdfs://, but it actually still points to the explicit Namenode. In the Enable HA wizard, the updated property with nameservice is shown, but when you go to Ambari Metrics Config properties, hbase.rootdir still points to the old value. This is happening because while enabling name node HA, AMS needs to be reconfigured and the hbase.rootdir config property in ams-hbase-site needs to be updated to use the nameservice similar to other services such as HBase, Accumulo etc. Diffs - ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js fc44724 ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 713e1c3 ambari-web/app/messages.js 8ff4b55 ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js 10989e0 Diff: https://reviews.apache.org/r/54911/diff/ Testing --- Manual Testing. Tested enabling HA with both distributed and embedded operation mode for AMS. Also updated test case. Patch failure with hadoop qa is unrelated. File Attachments AMBARI-19206.patch https://reviews.apache.org/media/uploaded/files/2016/12/20/611ff5b0-1bf2-4b3c-a697-a69e7c1220d2__AMBARI-19206.patch Thanks, Sangeeta Ravindran
Review Request 54815: Exception when running Slider view - java.lang.NoClassDefFoundError: org/apache/hadoop/yarn/api/protocolrecords/GetLabelsToNodesResponse
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54815/
---
Review request for Ambari, Di Li and Srimanth Gunturi.
Bugs: AMBARI-19218
https://issues.apache.org/jira/browse/AMBARI-19218
Repository: ambari
Description
---
When a Slider view is executed, the following error is thrown.
15 Dec 2016 10:11:15,645 WARN [ambari-client-thread-28] [SLIDER 2.0.0 S1]
SliderAppsViewControllerImpl:847 - Unable to create SliderClient
java.lang.NoClassDefFoundError:
org/apache/hadoop/yarn/api/protocolrecords/GetLabelsToNodesResponse
This is because the version of hadoop-yarn-api jar under
/var/lib/ambari-server/resources/views/work/SLIDER
{2.0.0}
is 2.6.0.
The GetLabelsToNodesResponse class was added in 2.7.0 version.
Fix involves excluding the hadoop-yarn-api 2.6 jar that is inherited from the
slider-core dependency. With this exclusion, the 2.7 version of hadoop-yarn-api
(inherited via org.apache.ambari.contrib.views.utils dependency) is included in
the slider view jar and view can be executed.
Diffs
-
contrib/views/slider/pom.xml bb1b150
Diff: https://reviews.apache.org/r/54815/diff/
Testing
---
Manual testing. View execution does not throw execption any more and
application can be added.
Thanks,
Sangeeta Ravindran
Re: Review Request 54314: AMBARI-18926: Kerberos Wizard UI creates duplicate radio buttons for FreeIPA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54314/#review157801 --- Ship it! Ship It! - Sangeeta Ravindran On Dec. 2, 2016, 6:18 p.m., Jesus Alvarez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54314/ > --- > > (Updated Dec. 2, 2016, 6:18 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran. > > > Bugs: AMBARI-18926 > https://issues.apache.org/jira/browse/AMBARI-18926 > > > Repository: ambari > > > Description > --- > > AMBARI-18926: Kerberos Wizard UI creates duplicate radio buttons for FreeIPA > > > Diffs > - > > ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2feeb7f > ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js > 9280367f > > Diff: https://reviews.apache.org/r/54314/diff/ > > > Testing > --- > > Tested enabling kerberos using an MIT KDC, and enabling kerberos with freeipa. > Tested navigating back from steps 2,3,4,5 to step 1 and closing wizard all > worked ok. > > > Thanks, > > Jesus Alvarez > >
Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/ --- (Updated Nov. 30, 2016, 6:43 p.m.) Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Juanjo Marron, Pallav Kulshreshtha, Venkat Ranganathan, and Yusaku Sako. Changes --- Updated patch based on latest code Bugs: AMBARI-18600 https://issues.apache.org/jira/browse/AMBARI-18600 Repository: ambari Description --- In the workflow designer view instance, if there is no log available for the workflow, then the spinner is seen giving the impression that logs are still being retrieved. This happens for all the logs, viz. the job log, error log and audit log. A message sould be displayed when there are no messages in the log. The test failure for this patch is caused by an existing issue unrelated to this patch. Failed to execute goal on project wfmanager: Could not resolve dependencies for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: Failure to find org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in https://oss.sonatype.org/content/groups/staging was cached in the local repository, resolution will not be reattempted until the update interval of oss.sonatype.org has elapsed or updates are forced -> [Help 1] Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js e403dc4 Diff: https://reviews.apache.org/r/53103/diff/ Testing --- Manual tests. File Attachments C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18600 https://reviews.apache.org/media/uploaded/files/2016/10/27/5b87e2e8-23e1-456c-ab5d-f157db437624__AMBARI-18600.patch Thanks, Sangeeta Ravindran
Re: Review Request 53788: HTTP responses needs to have the character encoding specified in the content type header
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53788/#review156162 --- Ship it! Ship It! - Sangeeta Ravindran On Nov. 15, 2016, 10:37 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53788/ > --- > > (Updated Nov. 15, 2016, 10:37 p.m.) > > > Review request for Ambari, Di Li, Jonathan Hurley, Robert Levas, and Sangeeta > Ravindran. > > > Bugs: AMBARI-18871 > https://issues.apache.org/jira/browse/AMBARI-18871 > > > Repository: ambari > > > Description > --- > > The charset information(UTF-8) can be added to all the response headers to > harden the security for the client. When the charset information is not > specified the web browser may choose a different encoding by guessing which > encoding is actually being used by the web page. > > This specific issue is mentioned in the section 3.1.1.5 of RFC7231 > > > Diffs > - > > ambari-server/conf/unix/ambari.properties 371653f > ambari-server/conf/windows/ambari.properties e47319e > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 15f186b > > ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java > 423a013 > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java > aa00ac2 > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java > d1be8cc > > ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java > d812ee6 > > Diff: https://reviews.apache.org/r/53788/diff/ > > > Testing > --- > > Ran mvn test. > > The test cases failing in hadoop QA is not related to the patch for this jira > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 52455: Ambari UI changes to support PAM authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/ --- (Updated Nov. 16, 2016, 5:29 p.m.) Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li. Bugs: AMBARI-18476 https://issues.apache.org/jira/browse/AMBARI-18476 Repository: ambari Description --- AMBARI-12263 adds support for PAM as authentication mechanism for accessing Ambari UI/REST. The changes in this review request cover the corresponding changes in the amabri-admin code. Since a new column groupt_type has been added for groups, the UI will display labels for group type and enable/disable group delete/add member functionality based on the group_type instead of the ldap_group flag. Patch includes similar changes for users. The user_type will be used to determine if the user can be deleted or if the user's password can be changed. Diffs (updated) - ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js 2e7830b ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js 1f86393 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js f7ed7ee ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js cd9b922 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js 660306c ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js PRE-CREATION ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js da63c6d ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 78a6884 ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html b359ede ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html e576b28 Diff: https://reviews.apache.org/r/52455/diff/ Testing --- Manual testing. Tests in ambari admin project ran clean. PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs) File Attachments New patch https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch Final patch https://reviews.apache.org/media/uploaded/files/2016/10/04/3d025c3b-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch Patch based on latest code https://reviews.apache.org/media/uploaded/files/2016/11/04/7fa50e96-c66b-4c5e-9321-13b623ab0710__AMBARI-18476.patch Patch for 2.5 https://reviews.apache.org/media/uploaded/files/2016/11/16/0d18da03-21c2-4360-90fa-b144d728ee2d__AMBARI-18476_2.5patch Final patch for ambari trunk https://reviews.apache.org/media/uploaded/files/2016/11/16/72fbbb65-b7f4-4e7b-bbf8-63cf872cc725__AMBARI-18476_0411.patch Thanks, Sangeeta Ravindran
Re: Review Request 52455: Ambari UI changes to support PAM authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/ --- (Updated Nov. 16, 2016, 3:23 p.m.) Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li. Changes --- Hi Di, I have added the trunk patch AMBARI-18476_0411 and AMBARI-18476_2.5 here. Bugs: AMBARI-18476 https://issues.apache.org/jira/browse/AMBARI-18476 Repository: ambari Description --- AMBARI-12263 adds support for PAM as authentication mechanism for accessing Ambari UI/REST. The changes in this review request cover the corresponding changes in the amabri-admin code. Since a new column groupt_type has been added for groups, the UI will display labels for group type and enable/disable group delete/add member functionality based on the group_type instead of the ldap_group flag. Patch includes similar changes for users. The user_type will be used to determine if the user can be deleted or if the user's password can be changed. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js 2e7830b ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js 1f86393 ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js af22d7f ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js 660306c ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js PRE-CREATION ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js da63c6d ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 8271432 ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html b359ede ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html e576b28 Diff: https://reviews.apache.org/r/52455/diff/ Testing --- Manual testing. Tests in ambari admin project ran clean. PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs) File Attachments (updated) New patch https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch Final patch https://reviews.apache.org/media/uploaded/files/2016/10/04/3d025c3b-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch Patch based on latest code https://reviews.apache.org/media/uploaded/files/2016/11/04/7fa50e96-c66b-4c5e-9321-13b623ab0710__AMBARI-18476.patch Patch for 2.5 https://reviews.apache.org/media/uploaded/files/2016/11/16/0d18da03-21c2-4360-90fa-b144d728ee2d__AMBARI-18476_2.5patch Final patch for ambari trunk https://reviews.apache.org/media/uploaded/files/2016/11/16/72fbbb65-b7f4-4e7b-bbf8-63cf872cc725__AMBARI-18476_0411.patch Thanks, Sangeeta Ravindran
Re: Review Request 52455: Ambari UI changes to support PAM authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/ --- (Updated Nov. 16, 2016, 5:27 a.m.) Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li. Bugs: AMBARI-18476 https://issues.apache.org/jira/browse/AMBARI-18476 Repository: ambari Description --- AMBARI-12263 adds support for PAM as authentication mechanism for accessing Ambari UI/REST. The changes in this review request cover the corresponding changes in the amabri-admin code. Since a new column groupt_type has been added for groups, the UI will display labels for group type and enable/disable group delete/add member functionality based on the group_type instead of the ldap_group flag. Patch includes similar changes for users. The user_type will be used to determine if the user can be deleted or if the user's password can be changed. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js 2e7830b ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js 1f86393 ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js af22d7f ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js 660306c ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js PRE-CREATION ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js da63c6d ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 8271432 ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html b359ede ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html e576b28 Diff: https://reviews.apache.org/r/52455/diff/ Testing --- Manual testing. Tests in ambari admin project ran clean. PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs) File Attachments (updated) New patch https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch Final patch https://reviews.apache.org/media/uploaded/files/2016/10/04/3d025c3b-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch Patch based on latest code https://reviews.apache.org/media/uploaded/files/2016/11/04/7fa50e96-c66b-4c5e-9321-13b623ab0710__AMBARI-18476.patch Patch for 2.5 https://reviews.apache.org/media/uploaded/files/2016/11/16/0d18da03-21c2-4360-90fa-b144d728ee2d__AMBARI-18476_2.5patch Thanks, Sangeeta Ravindran
Re: Review Request 52455: Ambari UI changes to support PAM authentication
> On Nov. 4, 2016, 3:03 p.m., Di Li wrote: > > Ship It! Hi Di, Can you please help commit this patch? I haven't pushed changed to trunk before and would appreciate your help. Thanks. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/#review154910 --- On Nov. 4, 2016, 9:23 a.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52455/ > --- > > (Updated Nov. 4, 2016, 9:23 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li. > > > Bugs: AMBARI-18476 > https://issues.apache.org/jira/browse/AMBARI-18476 > > > Repository: ambari > > > Description > --- > > AMBARI-12263 adds support for PAM as authentication mechanism for accessing > Ambari UI/REST. The changes in this review request cover the corresponding > changes in the amabri-admin code. > Since a new column groupt_type has been added for groups, the UI will display > labels for group type and enable/disable group delete/add member > functionality based on the group_type instead of the ldap_group flag. > Patch includes similar changes for users. The user_type will be used to > determine if the user can be deleted or if the user's password can be changed. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > 2e7830b > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js > 1f86393 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > af22d7f > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js > 660306c > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js > da63c6d > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html > 8271432 > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html > b359ede > ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html > e576b28 > > Diff: https://reviews.apache.org/r/52455/diff/ > > > Testing > --- > > Manual testing. > Tests in ambari admin project ran clean. > PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs) > > > File Attachments > > > New patch > > https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch > Final patch > > https://reviews.apache.org/media/uploaded/files/2016/10/04/3d025c3b-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch > Patch based on latest code > > https://reviews.apache.org/media/uploaded/files/2016/11/04/7fa50e96-c66b-4c5e-9321-13b623ab0710__AMBARI-18476.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52455: Ambari UI changes to support PAM authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/ --- (Updated Nov. 4, 2016, 9:23 a.m.) Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li. Bugs: AMBARI-18476 https://issues.apache.org/jira/browse/AMBARI-18476 Repository: ambari Description --- AMBARI-12263 adds support for PAM as authentication mechanism for accessing Ambari UI/REST. The changes in this review request cover the corresponding changes in the amabri-admin code. Since a new column groupt_type has been added for groups, the UI will display labels for group type and enable/disable group delete/add member functionality based on the group_type instead of the ldap_group flag. Patch includes similar changes for users. The user_type will be used to determine if the user can be deleted or if the user's password can be changed. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js 2e7830b ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js 1f86393 ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js af22d7f ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js 660306c ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js PRE-CREATION ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js da63c6d ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 8271432 ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html b359ede ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html e576b28 Diff: https://reviews.apache.org/r/52455/diff/ Testing --- Manual testing. Tests in ambari admin project ran clean. PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs) File Attachments (updated) New patch https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch Final patch https://reviews.apache.org/media/uploaded/files/2016/10/04/3d025c3b-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch Patch based on latest code https://reviews.apache.org/media/uploaded/files/2016/11/04/7fa50e96-c66b-4c5e-9321-13b623ab0710__AMBARI-18476.patch Thanks, Sangeeta Ravindran
Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options
> On Oct. 31, 2016, 7:07 a.m., DIPAYAN BHOWMICK wrote: > > Ship It! Thank you Dipayan. Can you please help push the fix. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53104/#review154241 --- On Oct. 27, 2016, 9:20 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53104/ > --- > > (Updated Oct. 27, 2016, 9:20 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, > Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18604 > https://issues.apache.org/jira/browse/AMBARI-18604 > > > Repository: ambari > > > Description > --- > > The workflow designer view dashboard allows filtering of workflows based on > Status, Name and User. > When filtering by Status, it does not offer PREP status as a suggestion. > > This is because the default value of limit for typeahead.bundle.js is 5. Fix > involves setting it to a higher value, so all options will be displayed. I > set it to 10 because that seemed to cover the maximum number of options > expected for workflow name, status or user. > > The test failure for this patch is caused by an existing issue unrelated to > this patch. > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-war-plugin:2.4:war (default-war) on project > oozie-ui: The specified web.xml file > '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' > does not exist -> [Help 1] > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > c5e1849 > > Diff: https://reviews.apache.org/r/53104/diff/ > > > Testing > --- > > Manual Testing. > > > File Attachments > > > C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18604 > > https://reviews.apache.org/media/uploaded/files/2016/10/27/80dbe88e-524a-4dfa-9a71-2ca31528eb5e__AMBARI-18604.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options
> On Oct. 28, 2016, 4:04 a.m., Di Li wrote: > > Ship It! Thank you Di. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53104/#review154096 --- On Oct. 27, 2016, 9:20 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53104/ > --- > > (Updated Oct. 27, 2016, 9:20 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, > Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18604 > https://issues.apache.org/jira/browse/AMBARI-18604 > > > Repository: ambari > > > Description > --- > > The workflow designer view dashboard allows filtering of workflows based on > Status, Name and User. > When filtering by Status, it does not offer PREP status as a suggestion. > > This is because the default value of limit for typeahead.bundle.js is 5. Fix > involves setting it to a higher value, so all options will be displayed. I > set it to 10 because that seemed to cover the maximum number of options > expected for workflow name, status or user. > > The test failure for this patch is caused by an existing issue unrelated to > this patch. > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-war-plugin:2.4:war (default-war) on project > oozie-ui: The specified web.xml file > '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' > does not exist -> [Help 1] > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > c5e1849 > > Diff: https://reviews.apache.org/r/53104/diff/ > > > Testing > --- > > Manual Testing. > > > File Attachments > > > C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18604 > > https://reviews.apache.org/media/uploaded/files/2016/10/27/80dbe88e-524a-4dfa-9a71-2ca31528eb5e__AMBARI-18604.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser
> On Oct. 24, 2016, 9:37 p.m., Di Li wrote: > > Ship It! Thanks Di. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53143/#review153743 --- On Oct. 27, 2016, 8:24 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53143/ > --- > > (Updated Oct. 27, 2016, 8:24 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, > Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18667 > https://issues.apache.org/jira/browse/AMBARI-18667 > > > Repository: ambari > > > Description > --- > > 1.In the Workflow Designer View instance, click on Create Workflow and add a > FS action > 2. Try to create a new folder by clicking on "Create Folder". > 3. The folder hint "" does not get overwritten when you > type a folder name. > > Expected results: > The hint should disappear when you start typing in the folder name. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js > fc5fd37 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs > d3233b6 > > Diff: https://reviews.apache.org/r/53143/diff/ > > > Testing > --- > > Manual Testing. > Test failures are not related to the changes in this patch. > > > File Attachments > > > C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18667 > > https://reviews.apache.org/media/uploaded/files/2016/10/27/bfd6723e-a042-4d5d-86f9-d7d632a628d9__AMBARI-18667.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser
> On Oct. 28, 2016, 7:09 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Dipayan. Can you please help push the fix? > > DIPAYAN BHOWMICK wrote: > Done, committed to trunk, branch-2.5 Thank you Dipayan. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53143/#review154163 --- On Oct. 27, 2016, 8:24 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53143/ > --- > > (Updated Oct. 27, 2016, 8:24 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, > Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18667 > https://issues.apache.org/jira/browse/AMBARI-18667 > > > Repository: ambari > > > Description > --- > > 1.In the Workflow Designer View instance, click on Create Workflow and add a > FS action > 2. Try to create a new folder by clicking on "Create Folder". > 3. The folder hint "" does not get overwritten when you > type a folder name. > > Expected results: > The hint should disappear when you start typing in the folder name. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js > fc5fd37 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs > d3233b6 > > Diff: https://reviews.apache.org/r/53143/diff/ > > > Testing > --- > > Manual Testing. > Test failures are not related to the changes in this patch. > > > File Attachments > ---- > > C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18667 > > https://reviews.apache.org/media/uploaded/files/2016/10/27/bfd6723e-a042-4d5d-86f9-d7d632a628d9__AMBARI-18667.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser
> On Oct. 28, 2016, 7:09 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Thank you Dipayan. Can you please help push the fix? - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53143/#review154163 --- On Oct. 27, 2016, 8:24 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53143/ > --- > > (Updated Oct. 27, 2016, 8:24 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, > Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18667 > https://issues.apache.org/jira/browse/AMBARI-18667 > > > Repository: ambari > > > Description > --- > > 1.In the Workflow Designer View instance, click on Create Workflow and add a > FS action > 2. Try to create a new folder by clicking on "Create Folder". > 3. The folder hint "" does not get overwritten when you > type a folder name. > > Expected results: > The hint should disappear when you start typing in the folder name. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js > fc5fd37 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs > d3233b6 > > Diff: https://reviews.apache.org/r/53143/diff/ > > > Testing > --- > > Manual Testing. > Test failures are not related to the changes in this patch. > > > File Attachments > > > C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18667 > > https://reviews.apache.org/media/uploaded/files/2016/10/27/bfd6723e-a042-4d5d-86f9-d7d632a628d9__AMBARI-18667.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message
> On Oct. 28, 2016, 4:04 a.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js, > > line 98 > > <https://reviews.apache.org/r/53103/diff/1/?file=1543254#file1543254line98> > > > > Will "No messages present" be displayed in the log textarea ? can it be > > more of an error notification ? Yes. But this will be displayed only when no messages are present in the log. For e.g. when the job is in PREP state and hasn't run yet. Hence, it is not always an error notification. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/#review154095 ------- On Oct. 27, 2016, 9:56 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53103/ > --- > > (Updated Oct. 27, 2016, 9:56 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, > Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18600 > https://issues.apache.org/jira/browse/AMBARI-18600 > > > Repository: ambari > > > Description > --- > > In the workflow designer view instance, if there is no log available for the > workflow, then the spinner is seen giving the impression that logs are still > being retrieved. This happens for all the logs, viz. the job log, error log > and audit log. > > A message sould be displayed when there are no messages in the log. > > The test failure for this patch is caused by an existing issue unrelated to > this patch. > > Failed to execute goal on project wfmanager: Could not resolve dependencies > for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: > Failure to find > org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in > https://oss.sonatype.org/content/groups/staging was cached in the local > repository, resolution will not be reattempted until the update interval of > oss.sonatype.org has elapsed or updates are forced -> [Help 1] > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js > ce78e59 > > Diff: https://reviews.apache.org/r/53103/diff/ > > > Testing > --- > > Manual tests. > > > File Attachments > > > C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18600 > > https://reviews.apache.org/media/uploaded/files/2016/10/27/5b87e2e8-23e1-456c-ab5d-f157db437624__AMBARI-18600.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/ --- (Updated Oct. 27, 2016, 9:56 p.m.) Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Venkat Ranganathan, and Yusaku Sako. Changes --- Updated patch based on latest code. Bugs: AMBARI-18600 https://issues.apache.org/jira/browse/AMBARI-18600 Repository: ambari Description --- In the workflow designer view instance, if there is no log available for the workflow, then the spinner is seen giving the impression that logs are still being retrieved. This happens for all the logs, viz. the job log, error log and audit log. A message sould be displayed when there are no messages in the log. The test failure for this patch is caused by an existing issue unrelated to this patch. Failed to execute goal on project wfmanager: Could not resolve dependencies for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: Failure to find org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in https://oss.sonatype.org/content/groups/staging was cached in the local repository, resolution will not be reattempted until the update interval of oss.sonatype.org has elapsed or updates are forced -> [Help 1] Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js ce78e59 Diff: https://reviews.apache.org/r/53103/diff/ Testing --- Manual tests. File Attachments (updated) C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18600 https://reviews.apache.org/media/uploaded/files/2016/10/27/5b87e2e8-23e1-456c-ab5d-f157db437624__AMBARI-18600.patch Thanks, Sangeeta Ravindran
Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53104/ --- (Updated Oct. 27, 2016, 9:20 p.m.) Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Venkat Ranganathan, and Yusaku Sako. Changes --- Updated patch based on latest code. Bugs: AMBARI-18604 https://issues.apache.org/jira/browse/AMBARI-18604 Repository: ambari Description --- The workflow designer view dashboard allows filtering of workflows based on Status, Name and User. When filtering by Status, it does not offer PREP status as a suggestion. This is because the default value of limit for typeahead.bundle.js is 5. Fix involves setting it to a higher value, so all options will be displayed. I set it to 10 because that seemed to cover the maximum number of options expected for workflow name, status or user. The test failure for this patch is caused by an existing issue unrelated to this patch. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.4:war (default-war) on project oozie-ui: The specified web.xml file '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' does not exist -> [Help 1] Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js c5e1849 Diff: https://reviews.apache.org/r/53104/diff/ Testing --- Manual Testing. File Attachments (updated) C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18604 https://reviews.apache.org/media/uploaded/files/2016/10/27/80dbe88e-524a-4dfa-9a71-2ca31528eb5e__AMBARI-18604.patch Thanks, Sangeeta Ravindran
Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53143/ --- (Updated Oct. 27, 2016, 8:24 p.m.) Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Venkat Ranganathan, and Yusaku Sako. Changes --- I have updated the patch based on the latest code in the repository after AMBARI-18691 was pushed in. Bugs: AMBARI-18667 https://issues.apache.org/jira/browse/AMBARI-18667 Repository: ambari Description --- 1.In the Workflow Designer View instance, click on Create Workflow and add a FS action 2. Try to create a new folder by clicking on "Create Folder". 3. The folder hint "" does not get overwritten when you type a folder name. Expected results: The hint should disappear when you start typing in the folder name. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js fc5fd37 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs d3233b6 Diff: https://reviews.apache.org/r/53143/diff/ Testing --- Manual Testing. Test failures are not related to the changes in this patch. File Attachments (updated) C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18667 https://reviews.apache.org/media/uploaded/files/2016/10/27/bfd6723e-a042-4d5d-86f9-d7d632a628d9__AMBARI-18667.patch Thanks, Sangeeta Ravindran
Re: Review Request 53144: Workflow Designer View: Tooltip for Edit button shows "Back"
> On Oct. 24, 2016, 9:34 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs, > > line 55 > > <https://reviews.apache.org/r/53144/diff/1/?file=1544355#file1544355line55> > > > > can this be externalized to a i18n file instead of hardcoding it at the > > UI level ? Currently all the strings are hardcoded. Will need to open a separate jira to externalize strings. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53144/#review153740 --- On Oct. 24, 2016, 5:20 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53144/ > --- > > (Updated Oct. 24, 2016, 5:20 p.m.) > > > Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18668 > https://issues.apache.org/jira/browse/AMBARI-18668 > > > Repository: ambari > > > Description > --- > > When you click on a workflow in the dashboard and hover over Edit Workflow > button, it shows the tooltip "Back" rather than Edit Workflow as expected. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs > 872cdbb > > Diff: https://reviews.apache.org/r/53144/diff/ > > > Testing > --- > > Manual testing. > > Test failures are unrelated to the changes in this patch. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 53075: Fix JSHint errors in Workflow Manager view
> On Oct. 21, 2016, 7:59 p.m., Venkat Ranganathan wrote: > > There are more changes we are working on (introducing Coordinator, bundle > > etc) and some further refactoring (the use of validator etc). Let me > > review thi a bit more carefully if there are intersections Thank you Venkat. Do you have any jiras that I could refer to for the upcoming changes in the Workflow Designer View code? - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153593 --- On Oct. 21, 2016, 6:28 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53075/ > --- > > (Updated Oct. 21, 2016, 6:28 p.m.) > > > Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18615 > https://issues.apache.org/jira/browse/AMBARI-18615 > > > Repository: ambari > > > Description > --- > > When you compile the Workflow Manager view, you see 94 JSHint errors. > > Fix includes: > > 1) Adding a .jshintrc file for applying /*jshint esversion: 6 */ to the whole > project to address errors similar to 'import' is only available in ES6 (use > 'esversion: 6'). > 2) Adding semi-colons where they are missing. > 3) Using dot notation instead of array > > The patch also fixes the error due to incorrect version of > org.apache.ambari.contrib.views. > > The test failure for this patch is caused by an existing issue unrelated to > this patch. > > Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.4:war > (default-war) on project oozie-ui: The specified web.xml file > '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' > does not exist -> [Help 1] > > > Diffs > - > > contrib/views/wfmanager/.jshintrc PRE-CREATION > contrib/views/wfmanager/pom.xml 1e910e2 > contrib/views/wfmanager/src/main/resources/ui/README.md dcac346 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > bd2944b > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-parameters.js > 1f75e64 > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-sla.js > dac325f > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_handler.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 33204ea > > contrib/views/wfmanager/src/main/resources/ui/app/domain/default-layout-manager.js > e208f83 > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager1.js > 0cd306a > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager2.js > d82b89e > contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js > 7cb82e1 > contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js > 49347d8 > contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js > 9562ae8 > contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js > 76dffbd > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > f29adb6 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > 9fc791c > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 5908de5 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow_xml_mapper.js > d5dc4da > contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js d849609 > > contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js > 17ff9aa > > Diff: https://reviews.apache.org/r/53075/diff/ > > > Testing > --- > > Manual testing > > > File Attachments > > > JSHint errors > > https://reviews.apache.org/media/uploaded/files/2016/10/20/c6a88e6d-d789-4f80-a7ca-9ec7b319331e__buildOutputJSHint_error.txt > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53143/ --- (Updated Oct. 24, 2016, 6:32 p.m.) Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AMBARI-18667 https://issues.apache.org/jira/browse/AMBARI-18667 Repository: ambari Description --- 1.In the Workflow Designer View instance, click on Create Workflow and add a FS action 2. Try to create a new folder by clicking on "Create Folder". 3. The folder hint "" does not get overwritten when you type a folder name. Expected results: The hint should disappear when you start typing in the folder name. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js fc5fd37 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs d3233b6 Diff: https://reviews.apache.org/r/53143/diff/ Testing --- Manual Testing. Test failures are not related to the changes in this patch. Thanks, Sangeeta Ravindran
Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53143/ --- Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AMBARI-18668 https://issues.apache.org/jira/browse/AMBARI-18668 Repository: ambari Description --- 1.In the Workflow Designer View instance, click on Create Workflow and add a FS action 2. Try to create a new folder by clicking on "Create Folder". 3. The folder hint "" does not get overwritten when you type a folder name. Expected results: The hint should disappear when you start typing in the folder name. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js fc5fd37 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs d3233b6 Diff: https://reviews.apache.org/r/53143/diff/ Testing --- Manual Testing. Test failures are not related to the changes in this patch. Thanks, Sangeeta Ravindran
Review Request 53144: Workflow Designer View: Tooltip for Edit button shows "Back"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53144/ --- Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AMBARI-18668 https://issues.apache.org/jira/browse/AMBARI-18668 Repository: ambari Description --- When you click on a workflow in the dashboard and hover over Edit Workflow button, it shows the tooltip "Back" rather than Edit Workflow as expected. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs 872cdbb Diff: https://reviews.apache.org/r/53144/diff/ Testing --- Manual testing. Test failures are unrelated to the changes in this patch. Thanks, Sangeeta Ravindran
Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53104/ --- Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AMBARI-18604 https://issues.apache.org/jira/browse/AMBARI-18604 Repository: ambari Description --- The workflow designer view dashboard allows filtering of workflows based on Status, Name and User. When filtering by Status, it does not offer PREP status as a suggestion. This is because the default value of limit for typeahead.bundle.js is 5. Fix involves setting it to a higher value, so all options will be displayed. I set it to 10 because that seemed to cover the maximum number of options expected for workflow name, status or user. The test failure for this patch is caused by an existing issue unrelated to this patch. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.4:war (default-war) on project oozie-ui: The specified web.xml file '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' does not exist -> [Help 1] Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js c5e1849 Diff: https://reviews.apache.org/r/53104/diff/ Testing --- Manual Testing. Thanks, Sangeeta Ravindran
Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/ --- (Updated Oct. 21, 2016, 9:30 p.m.) Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AMBARI-18600 https://issues.apache.org/jira/browse/AMBARI-18600 Repository: ambari Description --- In the workflow designer view instance, if there is no log available for the workflow, then the spinner is seen giving the impression that logs are still being retrieved. This happens for all the logs, viz. the job log, error log and audit log. A message sould be displayed when there are no messages in the log. The test failure for this patch is caused by an existing issue unrelated to this patch. Failed to execute goal on project wfmanager: Could not resolve dependencies for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: Failure to find org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in https://oss.sonatype.org/content/groups/staging was cached in the local repository, resolution will not be reattempted until the update interval of oss.sonatype.org has elapsed or updates are forced -> [Help 1] Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js ce78e59 Diff: https://reviews.apache.org/r/53103/diff/ Testing --- Manual tests. Thanks, Sangeeta Ravindran
Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/ --- Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AMBARI-18615 https://issues.apache.org/jira/browse/AMBARI-18615 Repository: ambari Description --- In the workflow designer view instance, if there is no log available for the workflow, then the spinner is seen giving the impression that logs are still being retrieved. This happens for all the logs, viz. the job log, error log and audit log. A message sould be displayed when there are no messages in the log. The test failure for this patch is caused by an existing issue unrelated to this patch. Failed to execute goal on project wfmanager: Could not resolve dependencies for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: Failure to find org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in https://oss.sonatype.org/content/groups/staging was cached in the local repository, resolution will not be reattempted until the update interval of oss.sonatype.org has elapsed or updates are forced -> [Help 1] Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js ce78e59 Diff: https://reviews.apache.org/r/53103/diff/ Testing --- Manual tests. Thanks, Sangeeta Ravindran
Re: Review Request 53075: Fix JSHint errors in Workflow Manager view
> On Oct. 21, 2016, 5:27 p.m., Di Li wrote: > > Ship It! Thanks Di. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153564 --- On Oct. 21, 2016, 6:28 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53075/ > --- > > (Updated Oct. 21, 2016, 6:28 p.m.) > > > Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18615 > https://issues.apache.org/jira/browse/AMBARI-18615 > > > Repository: ambari > > > Description > --- > > When you compile the Workflow Manager view, you see 94 JSHint errors. > > Fix includes: > > 1) Adding a .jshintrc file for applying /*jshint esversion: 6 */ to the whole > project to address errors similar to 'import' is only available in ES6 (use > 'esversion: 6'). > 2) Adding semi-colons where they are missing. > 3) Using dot notation instead of array > > The patch also fixes the error due to incorrect version of > org.apache.ambari.contrib.views. > > The test failure for this patch is caused by an existing issue unrelated to > this patch. > > Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.4:war > (default-war) on project oozie-ui: The specified web.xml file > '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' > does not exist -> [Help 1] > > > Diffs > - > > contrib/views/wfmanager/.jshintrc PRE-CREATION > contrib/views/wfmanager/pom.xml 1e910e2 > contrib/views/wfmanager/src/main/resources/ui/README.md dcac346 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > bd2944b > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-parameters.js > 1f75e64 > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-sla.js > dac325f > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_handler.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 33204ea > > contrib/views/wfmanager/src/main/resources/ui/app/domain/default-layout-manager.js > e208f83 > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager1.js > 0cd306a > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager2.js > d82b89e > contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js > 7cb82e1 > contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js > 49347d8 > contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js > 9562ae8 > contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js > 76dffbd > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > f29adb6 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > 9fc791c > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 5908de5 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow_xml_mapper.js > d5dc4da > contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js d849609 > > contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js > 17ff9aa > > Diff: https://reviews.apache.org/r/53075/diff/ > > > Testing > --- > > Manual testing > > > File Attachments > > > JSHint errors > > https://reviews.apache.org/media/uploaded/files/2016/10/20/c6a88e6d-d789-4f80-a7ca-9ec7b319331e__buildOutputJSHint_error.txt > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 53075: Fix JSHint errors in Workflow Manager view
> On Oct. 20, 2016, 9:11 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_handler.js, > > line 1 > > <https://reviews.apache.org/r/53075/diff/1/?file=1542627#file1542627line1> > > > > Why a new file ? The changes are just the different way to referencing > > values in the dictionary, yes ? I created a new file to rename it actionjob_hanlder to actionjob_handler. I had updated contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js where the file is being imported. > On Oct. 20, 2016, 9:11 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/domain/default-layout-manager.js, > > line 30 > > <https://reviews.apache.org/r/53075/diff/1/?file=1542629#file1542629line30> > > > > not really a functional issue though, more of a coding practice. Yes I agree, however JSHint flags it as an error because same variable is reused. > On Oct. 20, 2016, 9:11 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js, line 70 > > <https://reviews.apache.org/r/53075/diff/1/?file=1542640#file1542640line70> > > > > Should this one be checking for falsy instead of an exact null ? params would contain an array of search parameters which is set based on the last search. If no search was previously done, params would be null. > On Oct. 20, 2016, 9:11 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js, > > line 30 > > <https://reviews.apache.org/r/53075/diff/1/?file=1542641#file1542641line30> > > > > Should this one be checking for falsy instead of an exact null ? same as previous comment. matches is a array. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153457 --- On Oct. 20, 2016, 8:41 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53075/ > --- > > (Updated Oct. 20, 2016, 8:41 p.m.) > > > Review request for Ambari, Di Li and Yusaku Sako. > > > Bugs: AMBARI-18615 > https://issues.apache.org/jira/browse/AMBARI-18615 > > > Repository: ambari > > > Description > --- > > When you compile the Workflow Manager view, you see 94 JSHint errors. > > Fix includes: > > 1) Adding a .jshintrc file for applying /*jshint esversion: 6 */ to the whole > project to address errors similar to 'import' is only available in ES6 (use > 'esversion: 6'). > 2) Adding semi-colons where they are missing. > 3) Using dot notation instead of array > > The patch also fixes the error due to incorrect version of > org.apache.ambari.contrib.views. > > The test failure for this patch is caused by an existing issue unrelated to > this patch. > > Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.4:war > (default-war) on project oozie-ui: The specified web.xml file > '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' > does not exist -> [Help 1] > > > Diffs > - > > contrib/views/wfmanager/.jshintrc PRE-CREATION > contrib/views/wfmanager/pom.xml 1e910e2 > contrib/views/wfmanager/src/main/resources/ui/README.md dcac346 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > bd2944b > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-parameters.js > 1f75e64 > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-sla.js > dac325f > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_handler.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 33204ea > > contrib/views/wfmanager/src/main/resources/ui/app/domain/default-layout-manager.js > e208f83 > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager1.js > 0cd306a > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager2.js > d82b89e > contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js > 7cb82e1 > contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js > 49347d8 > contrib/views/wfmanager/src/main/re
Review Request 53075: Fix JSHint errors in Workflow Manager view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/ --- Review request for Ambari, Di Li and Yusaku Sako. Bugs: AMBARI-18615 https://issues.apache.org/jira/browse/AMBARI-18615 Repository: ambari Description --- When you compile the Workflow Manager view, you see 94 JSHint errors. Fix includes: 1) Adding a .jshintrc file for applying /*jshint esversion: 6 */ to the whole project to address errors similar to 'import' is only available in ES6 (use 'esversion: 6'). 2) Adding semi-colons where they are missing. 3) Using dot notation instead of array The patch also fixes the error due to incorrect version of org.apache.ambari.contrib.views. The test failure for this patch is caused by an existing issue unrelated to this patch. Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.4:war (default-war) on project oozie-ui: The specified web.xml file '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' does not exist -> [Help 1] Diffs - contrib/views/wfmanager/.jshintrc PRE-CREATION contrib/views/wfmanager/pom.xml 1e910e2 contrib/views/wfmanager/src/main/resources/ui/README.md dcac346 contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js bd2944b contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-parameters.js 1f75e64 contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-sla.js dac325f contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_handler.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 33204ea contrib/views/wfmanager/src/main/resources/ui/app/domain/default-layout-manager.js e208f83 contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager1.js 0cd306a contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager2.js d82b89e contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 7cb82e1 contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 49347d8 contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js 9562ae8 contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js 76dffbd contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js f29adb6 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js 9fc791c contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 5908de5 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow_xml_mapper.js d5dc4da contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js d849609 contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js 17ff9aa Diff: https://reviews.apache.org/r/53075/diff/ Testing --- Manual testing File Attachments JSHint errors https://reviews.apache.org/media/uploaded/files/2016/10/20/c6a88e6d-d789-4f80-a7ca-9ec7b319331e__buildOutputJSHint_error.txt Thanks, Sangeeta Ravindran
Re: Review Request 52456: Modify HTTP headers to follow best security practices
> On Oct. 9, 2016, 10:39 p.m., Robert Levas wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Robert. > Can you please help push the fix? > > Robert Levas wrote: > Pushed to trunk: > > ``` > commit 34c5686c3a0f80a5c7b78ddf05bb41cb13202438 > Author: Sangeeta Ravindran > Date: Mon Oct 10 11:05:40 2016 -0400 > > AMBARI-17311. Modify HTTP headers to follow best security practices > (Sangeeta Ravindran via rlevas) > ``` Thank you Robert. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/#review151944 --- On Oct. 4, 2016, 4:45 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52456/ > --- > > (Updated Oct. 4, 2016, 4:45 p.m.) > > > Review request for Ambari, Di Li, Robert Levas, and Yusaku Sako. > > > Bugs: AMBARI-17311 > https://issues.apache.org/jira/browse/AMBARI-17311 > > > Repository: ambari > > > Description > --- > > This patch adds the following HTTP headers to follow security best practices. > > X-Content-Type-Options: nosniff > Cache-control: no-store > Pragma: no-cache > > > Diffs > - > > ambari-server/conf/unix/ambari.properties 4dcbe99 > ambari-server/conf/windows/ambari.properties 64cce3b > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 2e850ef > > ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java > 05c9ecb > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java > b40953b > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java > 5bff4e3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java > 7be70a3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilterTest.java > 6537130 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilterTest.java > c9d7974 > > Diff: https://reviews.apache.org/r/52456/diff/ > > > Testing > --- > > Test cases have been updated to test with the new headers added. > Also did manual testing. > > > File Attachments > > > Patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/32920075-a5ab-481b-bc47-e1be6b569605__AMBARI-17311.patch > Updated patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/674db481-c4e0-4afb-98cb-b051d785c710__AMBARI-17311.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52456: Modify HTTP headers to follow best security practices
> On Oct. 9, 2016, 10:39 p.m., Robert Levas wrote: > > Ship It! Thank you Robert. Can you please help push the fix? - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/#review151944 --- On Oct. 4, 2016, 4:45 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52456/ > --- > > (Updated Oct. 4, 2016, 4:45 p.m.) > > > Review request for Ambari, Di Li, Robert Levas, and Yusaku Sako. > > > Bugs: AMBARI-17311 > https://issues.apache.org/jira/browse/AMBARI-17311 > > > Repository: ambari > > > Description > --- > > This patch adds the following HTTP headers to follow security best practices. > > X-Content-Type-Options: nosniff > Cache-control: no-store > Pragma: no-cache > > > Diffs > - > > ambari-server/conf/unix/ambari.properties 4dcbe99 > ambari-server/conf/windows/ambari.properties 64cce3b > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 2e850ef > > ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java > 05c9ecb > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java > b40953b > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java > 5bff4e3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java > 7be70a3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilterTest.java > 6537130 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilterTest.java > c9d7974 > > Diff: https://reviews.apache.org/r/52456/diff/ > > > Testing > --- > > Test cases have been updated to test with the new headers added. > Also did manual testing. > > > File Attachments > > > Patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/32920075-a5ab-481b-bc47-e1be6b569605__AMBARI-17311.patch > Updated patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/674db481-c4e0-4afb-98cb-b051d785c710__AMBARI-17311.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52456: Modify HTTP headers to follow best security practices
> On Oct. 3, 2016, 2:32 p.m., Di Li wrote: > > Ship It! Thank you Di. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/#review151168 --- On Oct. 4, 2016, 4:45 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52456/ > --- > > (Updated Oct. 4, 2016, 4:45 p.m.) > > > Review request for Ambari, Di Li, Robert Levas, and Yusaku Sako. > > > Bugs: AMBARI-17311 > https://issues.apache.org/jira/browse/AMBARI-17311 > > > Repository: ambari > > > Description > --- > > This patch adds the following HTTP headers to follow security best practices. > > X-Content-Type-Options: nosniff > Cache-control: no-store > Pragma: no-cache > > > Diffs > - > > ambari-server/conf/unix/ambari.properties 4dcbe99 > ambari-server/conf/windows/ambari.properties 64cce3b > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 2e850ef > > ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java > 05c9ecb > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java > b40953b > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java > 5bff4e3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java > 7be70a3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilterTest.java > 6537130 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilterTest.java > c9d7974 > > Diff: https://reviews.apache.org/r/52456/diff/ > > > Testing > --- > > Test cases have been updated to test with the new headers added. > Also did manual testing. > > > File Attachments > > > Patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/32920075-a5ab-481b-bc47-e1be6b569605__AMBARI-17311.patch > Updated patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/674db481-c4e0-4afb-98cb-b051d785c710__AMBARI-17311.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52456: Modify HTTP headers to follow best security practices
> On Oct. 3, 2016, 9:10 a.m., Robert Levas wrote: > > This looks good, however I am wondering what implications the no-cache > > headers will have on the UI and the perceived speed of the application > > @yusaku? Thanks Robert. I have addressed the review comments. I did not seen any performance impact in the UI during testing so far. Can you please help push the fix? - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/#review151148 --- On Oct. 4, 2016, 4:45 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52456/ > --- > > (Updated Oct. 4, 2016, 4:45 p.m.) > > > Review request for Ambari, Di Li, Robert Levas, and Yusaku Sako. > > > Bugs: AMBARI-17311 > https://issues.apache.org/jira/browse/AMBARI-17311 > > > Repository: ambari > > > Description > --- > > This patch adds the following HTTP headers to follow security best practices. > > X-Content-Type-Options: nosniff > Cache-control: no-store > Pragma: no-cache > > > Diffs > - > > ambari-server/conf/unix/ambari.properties 4dcbe99 > ambari-server/conf/windows/ambari.properties 64cce3b > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 2e850ef > > ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java > 05c9ecb > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java > b40953b > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java > 5bff4e3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java > 7be70a3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilterTest.java > 6537130 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilterTest.java > c9d7974 > > Diff: https://reviews.apache.org/r/52456/diff/ > > > Testing > --- > > Test cases have been updated to test with the new headers added. > Also did manual testing. > > > File Attachments > > > Patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/32920075-a5ab-481b-bc47-e1be6b569605__AMBARI-17311.patch > Updated patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/674db481-c4e0-4afb-98cb-b051d785c710__AMBARI-17311.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52455: Ambari UI changes to support PAM authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/ --- (Updated Oct. 4, 2016, 4:38 p.m.) Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li. Bugs: AMBARI-18476 https://issues.apache.org/jira/browse/AMBARI-18476 Repository: ambari Description --- AMBARI-12263 adds support for PAM as authentication mechanism for accessing Ambari UI/REST. The changes in this review request cover the corresponding changes in the amabri-admin code. Since a new column groupt_type has been added for groups, the UI will display labels for group type and enable/disable group delete/add member functionality based on the group_type instead of the ldap_group flag. Patch includes similar changes for users. The user_type will be used to determine if the user can be deleted or if the user's password can be changed. Diffs (updated) - ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js 2e7830b ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js 1f86393 ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js af22d7f ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js 660306c ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js PRE-CREATION ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js da63c6d ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 8271432 ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html b359ede ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html e576b28 Diff: https://reviews.apache.org/r/52455/diff/ Testing --- Manual testing. Tests in ambari admin project ran clean. PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs) File Attachments (updated) New patch https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch Final patch https://reviews.apache.org/media/uploaded/files/2016/10/04/3d025c3b-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch Thanks, Sangeeta Ravindran
Re: Review Request 52455: Ambari UI changes to support PAM authentication
> On Oct. 3, 2016, 2:34 p.m., Alexandr Antonenko wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/index.html, line 162 > > <https://reviews.apache.org/r/52455/diff/1/?file=1517321#file1517321line162> > > > > I don't see this newly created file in diff files list. You were able > > to build UI without this files ? UI should fail upon building because of > > declared file that does not exist > > Sangeeta Ravindran wrote: > Hi Aleksandr, > > I accidentally missed adding the file when I created the patch. I have > now added it. New patch has been uplaoded. > > Sangeeta Ravindran wrote: > Hello Alexandr, the patch has been updated with the new file. > > Alexandr Antonenko wrote: > oh I see, but now I see only one file (the one that was misssing), other > files are gone My apologies. I have add the patch updated with all the relevant changes. It contains the new files as well as the original file. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/#review151170 --- On Oct. 4, 2016, 4:38 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52455/ > --- > > (Updated Oct. 4, 2016, 4:38 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li. > > > Bugs: AMBARI-18476 > https://issues.apache.org/jira/browse/AMBARI-18476 > > > Repository: ambari > > > Description > --- > > AMBARI-12263 adds support for PAM as authentication mechanism for accessing > Ambari UI/REST. The changes in this review request cover the corresponding > changes in the amabri-admin code. > Since a new column groupt_type has been added for groups, the UI will display > labels for group type and enable/disable group delete/add member > functionality based on the group_type instead of the ldap_group flag. > Patch includes similar changes for users. The user_type will be used to > determine if the user can be deleted or if the user's password can be changed. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > 2e7830b > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js > 1f86393 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > af22d7f > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js > 660306c > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js > da63c6d > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html > 8271432 > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html > b359ede > ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html > e576b28 > > Diff: https://reviews.apache.org/r/52455/diff/ > > > Testing > --- > > Manual testing. > Tests in ambari admin project ran clean. > PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs) > > > File Attachments > ---- > > New patch > > https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch > Final patch > > https://reviews.apache.org/media/uploaded/files/2016/10/04/3d025c3b-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52456: Modify HTTP headers to follow best security practices
> On Oct. 3, 2016, 9:10 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2234 > > <https://reviews.apache.org/r/52456/diff/1/?file=1517466#file1517466line2234> > > > > "... for Ambari View requests." Thank you Robert. I have updated the patch. > On Oct. 3, 2016, 9:10 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2242 > > <https://reviews.apache.org/r/52456/diff/1/?file=1517466#file1517466line2242> > > > > "... for Ambari View requests." Thank you Robert. I have updated the patch. > On Oct. 3, 2016, 9:10 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2250 > > <https://reviews.apache.org/r/52456/diff/1/?file=1517466#file1517466line2250> > > > > "... for Ambari View requests." Thank you Robert. I have updated the patch. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/#review151148 --- On Oct. 3, 2016, 4:44 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52456/ > --- > > (Updated Oct. 3, 2016, 4:44 p.m.) > > > Review request for Ambari, Di Li, Robert Levas, and Yusaku Sako. > > > Bugs: AMBARI-17311 > https://issues.apache.org/jira/browse/AMBARI-17311 > > > Repository: ambari > > > Description > --- > > This patch adds the following HTTP headers to follow security best practices. > > X-Content-Type-Options: nosniff > Cache-control: no-store > Pragma: no-cache > > > Diffs > - > > ambari-server/conf/unix/ambari.properties 4dcbe99 > ambari-server/conf/windows/ambari.properties 64cce3b > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 2e850ef > > ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java > 05c9ecb > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java > b40953b > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java > 5bff4e3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java > 7be70a3 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilterTest.java > 6537130 > > ambari-server/src/test/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilterTest.java > c9d7974 > > Diff: https://reviews.apache.org/r/52456/diff/ > > > Testing > --- > > Test cases have been updated to test with the new headers added. > Also did manual testing. > > > File Attachments > > > Patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/32920075-a5ab-481b-bc47-e1be6b569605__AMBARI-17311.patch > Updated patch with review comments addressed > > https://reviews.apache.org/media/uploaded/files/2016/10/04/674db481-c4e0-4afb-98cb-b051d785c710__AMBARI-17311.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52456: Modify HTTP headers to follow best security practices
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/ --- (Updated Oct. 4, 2016, 4:45 p.m.) Review request for Ambari, Di Li, Robert Levas, and Yusaku Sako. Bugs: AMBARI-17311 https://issues.apache.org/jira/browse/AMBARI-17311 Repository: ambari Description --- This patch adds the following HTTP headers to follow security best practices. X-Content-Type-Options: nosniff Cache-control: no-store Pragma: no-cache Diffs (updated) - ambari-server/conf/unix/ambari.properties 4dcbe99 ambari-server/conf/windows/ambari.properties 64cce3b ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2e850ef ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java 05c9ecb ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java b40953b ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java 5bff4e3 ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java 7be70a3 ambari-server/src/test/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilterTest.java 6537130 ambari-server/src/test/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilterTest.java c9d7974 Diff: https://reviews.apache.org/r/52456/diff/ Testing --- Test cases have been updated to test with the new headers added. Also did manual testing. File Attachments (updated) Patch with review comments addressed https://reviews.apache.org/media/uploaded/files/2016/10/04/32920075-a5ab-481b-bc47-e1be6b569605__AMBARI-17311.patch Updated patch with review comments addressed https://reviews.apache.org/media/uploaded/files/2016/10/04/674db481-c4e0-4afb-98cb-b051d785c710__AMBARI-17311.patch Thanks, Sangeeta Ravindran
Re: Review Request 52455: Ambari UI changes to support PAM authentication
> On Oct. 3, 2016, 2:34 p.m., Alexandr Antonenko wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/index.html, line 162 > > <https://reviews.apache.org/r/52455/diff/1/?file=1517321#file1517321line162> > > > > I don't see this newly created file in diff files list. You were able > > to build UI without this files ? UI should fail upon building because of > > declared file that does not exist > > Sangeeta Ravindran wrote: > Hi Aleksandr, > > I accidentally missed adding the file when I created the patch. I have > now added it. New patch has been uplaoded. Hello Alexandr, the patch has been updated with the new file. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/#review151170 ------- On Oct. 3, 2016, 4:35 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52455/ > --- > > (Updated Oct. 3, 2016, 4:35 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li. > > > Bugs: AMBARI-18476 > https://issues.apache.org/jira/browse/AMBARI-18476 > > > Repository: ambari > > > Description > --- > > AMBARI-12263 adds support for PAM as authentication mechanism for accessing > Ambari UI/REST. The changes in this review request cover the corresponding > changes in the amabri-admin code. > Since a new column groupt_type has been added for groups, the UI will display > labels for group type and enable/disable group delete/add member > functionality based on the group_type instead of the ldap_group flag. > Patch includes similar changes for users. The user_type will be used to > determine if the user can be deleted or if the user's password can be changed. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/52455/diff/ > > > Testing > --- > > Manual testing. > Tests in ambari admin project ran clean. > PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs) > > > File Attachments > > > New patch > > https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52455: Ambari UI changes to support PAM authentication
> On Oct. 3, 2016, 2:34 p.m., Alexandr Antonenko wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/index.html, line 162 > > <https://reviews.apache.org/r/52455/diff/1/?file=1517321#file1517321line162> > > > > I don't see this newly created file in diff files list. You were able > > to build UI without this files ? UI should fail upon building because of > > declared file that does not exist Hi Aleksandr, I accidentally missed adding the file when I created the patch. I have now added it. New patch has been uplaoded. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/#review151170 --- On Oct. 3, 2016, 4:35 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52455/ > --- > > (Updated Oct. 3, 2016, 4:35 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li. > > > Bugs: AMBARI-18476 > https://issues.apache.org/jira/browse/AMBARI-18476 > > > Repository: ambari > > > Description > --- > > AMBARI-12263 adds support for PAM as authentication mechanism for accessing > Ambari UI/REST. The changes in this review request cover the corresponding > changes in the amabri-admin code. > Since a new column groupt_type has been added for groups, the UI will display > labels for group type and enable/disable group delete/add member > functionality based on the group_type instead of the ldap_group flag. > Patch includes similar changes for users. The user_type will be used to > determine if the user can be deleted or if the user's password can be changed. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/52455/diff/ > > > Testing > --- > > Manual testing. > Tests in ambari admin project ran clean. > PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs) > > > File Attachments > > > New patch > > https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 52456: Modify HTTP headers to follow best security practices
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/ --- (Updated Oct. 3, 2016, 4:44 p.m.) Review request for Ambari, Di Li, Robert Levas, and Yusaku Sako. Bugs: AMBARI-17311 https://issues.apache.org/jira/browse/AMBARI-17311 Repository: ambari Description --- This patch adds the following HTTP headers to follow security best practices. X-Content-Type-Options: nosniff Cache-control: no-store Pragma: no-cache Diffs - ambari-server/conf/unix/ambari.properties 4dcbe99 ambari-server/conf/windows/ambari.properties 64cce3b ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2e850ef ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java 05c9ecb ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java b40953b ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java 5bff4e3 ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java 7be70a3 ambari-server/src/test/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilterTest.java 6537130 ambari-server/src/test/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilterTest.java c9d7974 Diff: https://reviews.apache.org/r/52456/diff/ Testing --- Test cases have been updated to test with the new headers added. Also did manual testing. Thanks, Sangeeta Ravindran
