Re: Review Request 64707: AMBARI-22669 Ranger stack script changes to fix missing directory failure for blueprint installation

2017-12-20 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64707/#review194229
---


Ship it!




- Vishal Suvagia


On Dec. 19, 2017, 10:19 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64707/
> ---
> 
> (Updated Dec. 19, 2017, 10:19 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, and Vishal Suvagia.
> 
> 
> Bugs: AMBARI-22669
> https://issues.apache.org/jira/browse/AMBARI-22669
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updating stack scripts code to remove use of commandParams/version to build 
> system path. For upgrade, using upgrade_summary module to get upgrade-to 
> version ie (target version).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  5731e6c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  d0a725a 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9b1f6e2 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  bbc438b 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
>  0b37489 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 
> e8bacbd 
> 
> 
> Diff: https://reviews.apache.org/r/64707/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Ranger Installation.
> 
> Ran 255 tests in 7.877s
> 
> OK
> --
> Total run:1210
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>



Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.

2017-12-13 Thread Vishal Suvagia via Review Board


> On Dec. 12, 2017, 4:36 p.m., Sid Wagle wrote:
> > Instead of putting empty files on the classpath isn't it easier to check 
> > for file existence on plugin side and defaul to "simple" auth?
> 
> Sid Wagle wrote:
> Correction not empty I meant dummy file.

Thank-you Siddharth, that is the current behaviour for Ranger plugins, which 
will default to simple auth if the file is not found, however once the cluster 
will be kerberized the plugin should make kerberized calls to Ranger for which 
plugin will require core-site.xml to set security as kerberos.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193559
---


On Dec. 13, 2017, 3:42 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> ---
> 
> (Updated Dec. 13, 2017, 3:42 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, 
> Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For Ranger plugins to work properly in kerberised environments where HDFS is 
> not installed. We need to create a core-site.xml for Storm and Kafka plugins 
> so that the plugins can work to fetch latest policies from with kerberised 
> calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached 
> to Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  485c1a6 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py
>  e9719aa 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
>  9aa09df 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  c486ef7 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/setup_ranger_knox.py
>  c486ef7 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  c04496e 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py
>  c04496e 
> 
> 
> Diff: https://reviews.apache.org/r/64537/diff/2/
> 
> 
> Testing
> ---
> 
> Verified with installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.

2017-12-13 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/
---

(Updated Dec. 13, 2017, 3:42 p.m.)


Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, 
Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.


Changes
---

Updating patch to address review comments.
Seperate patch for branch-2.6 is attached on Apache JIRA.


Bugs: AMBARI-22635
https://issues.apache.org/jira/browse/AMBARI-22635


Repository: ambari


Description
---

For Ranger plugins to work properly in kerberised environments where HDFS is 
not installed. We need to create a core-site.xml for Storm and Kafka plugins so 
that the plugins can work to fetch latest policies from with kerberised calls 
from Ranger.
Attached patch is for trunk branch, seperate patch for branch-2.6 is attached 
to Apache JIRA.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 485c1a6 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py
 e9719aa 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
 9aa09df 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
 c486ef7 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/setup_ranger_knox.py
 c486ef7 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
 c04496e 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py
 c04496e 


Diff: https://reviews.apache.org/r/64537/diff/2/

Changes: https://reviews.apache.org/r/64537/diff/1-2/


Testing
---

Verified with installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.

2017-12-12 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/
---

Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, 
Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.


Bugs: AMBARI-22635
https://issues.apache.org/jira/browse/AMBARI-22635


Repository: ambari


Description
---

For Ranger plugins to work properly in kerberised environments where HDFS is 
not installed. We need to create a core-site.xml for Storm and Kafka plugins so 
that the plugins can work to fetch latest policies from with kerberised calls 
from Ranger.
Attached patch is for trunk branch, seperate patch for branch-2.6 is attached 
to Apache JIRA.


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py
 e9719aa 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
 9aa09df 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
 c04496e 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py
 c04496e 


Diff: https://reviews.apache.org/r/64537/diff/1/


Testing
---

Verified with installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 63907: AMBARI-22463 Removing secure reference configs entries from stack for Ranger KMS service

2017-11-19 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63907/#review191479
---


Ship it!




Ship It!

- Vishal Suvagia


On Nov. 17, 2017, 12:48 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63907/
> ---
> 
> (Updated Nov. 17, 2017, 12:48 p.m.)
> 
> 
> Review request for Ambari, Robert Levas and Vishal Suvagia.
> 
> 
> Bugs: AMBARI-22463
> https://issues.apache.org/jira/browse/AMBARI-22463
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removing below properties entries from stack,
> 
> hadoop.kms.authentication.kerberos.keytab
> hadoop.kms.authentication.kerberos.principal
> hadoop.kms.authentication.signer.secret.provider.zookeeper.kerberos.keytab
> hadoop.kms.authentication.signer.secret.provider.zookeeper.kerberos.principal
> 
> These properties will be added in secure cluster using Ranger KMS Kerberos 
> descriptor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
>  59a6952 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/configuration/kms-site.xml
>  1e6f7b5 
> 
> 
> Diff: https://reviews.apache.org/r/63907/diff/1/
> 
> 
> Testing
> ---
> 
> Ran 255 tests in 8.409s
> 
> OK
> --
> Total run:1205
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>



Re: Review Request 62985: AMBARI-22232 : Need to add a new property to support proxy users property for Atlas service

2017-10-14 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62985/
---

(Updated Oct. 14, 2017, 11:17 a.m.)


Review request for Ambari, Gautam Borad, Jonathan Hurley, Madhan Neethiraj, 
Mugdha Varadkar, Nate Cole, and Nixon Rodrigues.


Changes
---

Updating patch to address review comments.
Seperate patch for branch-2.6 is attached on Apache JIRA


Bugs: AMBARI-22232
https://issues.apache.org/jira/browse/AMBARI-22232


Repository: ambari


Description
---

When Atlas is enabled via proxy needs to know the proxy-users to authorize them 
while accessing the Atlas service via proxy support using property 
atlas.proxyusers with default value knox. Additional details on ATLAS-2166.

PS: Attached patch is applicable for trunk branch, patch for branch-2.6 is 
attached on Apache JIRA.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 1af3b18 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
0a01a04 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
 c271dc3 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
94f28db 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 ebb81d9 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
ae5972e 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculationTest.java
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py ade08c1 


Diff: https://reviews.apache.org/r/62985/diff/2/

Changes: https://reviews.apache.org/r/62985/diff/1-2/


Testing
---

Verified with fresh-install and EU on CentOS 6.


Thanks,

Vishal Suvagia



Re: Review Request 62985: AMBARI-22232 : Need to add a new property to support proxy users property for Atlas service

2017-10-14 Thread Vishal Suvagia via Review Board


> On Oct. 14, 2017, 12:18 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java
> > Lines 38 (patched)
> > 
> >
> > Hard coded? This can't be configured by administrators?

I agree, Administrators can configure the value. Here 'knox' is a default value 
required to be provided if Knox is externally configured to use Atlas via 
proxy, eventually if a custom-user is used for the external knox, then this 
value will need to be manually configured.
Here default value is referred from Atlas side implementation where 'knox' is 
the default value.Reference here -> 
https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java#L88


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62985/#review188051
---


On Oct. 13, 2017, 8:21 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62985/
> ---
> 
> (Updated Oct. 13, 2017, 8:21 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Madhan Neethiraj, 
> Mugdha Varadkar, Nate Cole, and Nixon Rodrigues.
> 
> 
> Bugs: AMBARI-22232
> https://issues.apache.org/jira/browse/AMBARI-22232
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Atlas is enabled via proxy needs to know the proxy-users to authorize 
> them while accessing the Atlas service via proxy support using property 
> atlas.proxyusers with default value knox. Additional details on ATLAS-2166.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.6 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  1af3b18 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 0a01a04 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
>  c271dc3 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 94f28db 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  ebb81d9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> ae5972e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculationTest.java
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> ade08c1 
> 
> 
> Diff: https://reviews.apache.org/r/62985/diff/2/
> 
> 
> Testing
> ---
> 
> Verified with fresh-install and EU on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Review Request 62985: AMBARI-22232 : Need to add a new property to support proxy users property for Atlas service

2017-10-13 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62985/
---

Review request for Ambari, Gautam Borad, Jonathan Hurley, Madhan Neethiraj, 
Mugdha Varadkar, Nate Cole, and Nixon Rodrigues.


Bugs: AMBARI-22232
https://issues.apache.org/jira/browse/AMBARI-22232


Repository: ambari


Description
---

When Atlas is enabled via proxy needs to know the proxy-users to authorize them 
while accessing the Atlas service via proxy support using property 
atlas.proxyusers with default value knox. Additional details on ATLAS-2166.

PS: Attached patch is applicable for trunk branch, patch for branch-2.6 is 
attached on Apache JIRA.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 1af3b18 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
0a01a04 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
 c271dc3 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
94f28db 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 ebb81d9 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
ae5972e 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculationTest.java
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py ade08c1 


Diff: https://reviews.apache.org/r/62985/diff/1/


Testing
---

Verified with fresh-install and EU on CentOS 6.


Thanks,

Vishal Suvagia



Review Request 62239: AMBARI-21925 : Facilitate a parameter to provide HBase conf directory for atlas-env configurations.

2017-09-12 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62239/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Madhan Neethiraj, Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-21925
https://issues.apache.org/jira/browse/AMBARI-21925


Repository: ambari


Description
---

Current configuration for Atlas atlas-env contains hbase_conf_dir which is set 
in environment as export HBASE_CONF_DIR=hbase_conf_dir
However, hbase_conf_dir is currently not exposed in ambari and hence its not 
possible to set just hbase_conf_dir instead through blueprints we need to pass 
full atlas-env.sh content to set the hbase_conf_dir.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 96041e6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml
 f97ca98 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/params.py
 61b41d6 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-env.xml
 821fafa 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
4764297 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 0d9a746 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
b5c88de 


Diff: https://reviews.apache.org/r/62239/diff/1/


Testing
---

Verified with fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 61527: AMBARI-21649 : Update Atlas log4j to reflect latest configurations

2017-08-09 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61527/
---

(Updated Aug. 10, 2017, 5:42 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Madhan Neethiraj, Mugdha Varadkar, and Sumit Mohanty.


Changes
---

Adding atlas-log4j changes to 3.0 version.


Bugs: AMBARI-21649
https://issues.apache.org/jira/browse/AMBARI-21649


Repository: ambari


Description
---

Need to update Atlas log4j configurations to reflect latest configurations as 
per update in Atlas.

PS: Attached patch is for trunk, seperate patch for branch-2.6 is attached on 
Apache JIRA.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-log4j.xml
 bafd47d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
ec6ee55 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 e9490b2 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
840b17d 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml
 9e3abcf 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
c2c1532 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 86b3956 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
b376fa7 


Diff: https://reviews.apache.org/r/61527/diff/2/

Changes: https://reviews.apache.org/r/61527/diff/1-2/


Testing
---

Verified with fresh install and upgrade scenarios on CentOS 6.


Thanks,

Vishal Suvagia



Review Request 61527: AMBARI-21649 : Update Atlas log4j to reflect latest configurations

2017-08-09 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61527/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Madhan Neethiraj, Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-21649
https://issues.apache.org/jira/browse/AMBARI-21649


Repository: ambari


Description
---

Need to update Atlas log4j configurations to reflect latest configurations as 
per update in Atlas.

PS: Attached patch is for trunk, seperate patch for branch-2.6 is attached on 
Apache JIRA.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
ec6ee55 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 e9490b2 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
840b17d 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml
 9e3abcf 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
c2c1532 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 86b3956 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
b376fa7 


Diff: https://reviews.apache.org/r/61527/diff/1/


Testing
---

Verified with fresh install and upgrade scenarios on CentOS 6.


Thanks,

Vishal Suvagia



Review Request 61217: AMBARI-21588 : MetadataServer start fails if Atlas service is started with custom service user.

2017-07-28 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61217/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Madhan Neethiraj, Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-21588
https://issues.apache.org/jira/browse/AMBARI-21588


Repository: ambari


Description
---

File permissons for stack_root/current/atlas-server/server/webapp/atlas is 
root:root, when atlas user is custom, Atlas Metadata Server can not start.
After changing permissions to the custom atlas user then Atlas was successfully 
started.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 74b1688 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
d1d8b7f 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 


Diff: https://reviews.apache.org/r/61217/diff/1/


Testing
---

Verified with install on CentOS 6.


Thanks,

Vishal Suvagia



Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-27 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/
---

(Updated July 27, 2017, 6:49 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.


Changes
---

Updating patch to address review comments and skipping deletion of 
core-site.xml.


Bugs: AMBARI-21563
https://issues.apache.org/jira/browse/AMBARI-21563


Repository: ambari


Description
---

Atlas use user groups synced in hadoopUGI for authentication and authorization 
process for LDAP/Kerberos type.
As core-site.xml was available in HBase conf which is in Atlas classpath and so 
core.site.xml configs were available. But now as core-site.xml is not available 
in Hbase conf, to fix this issue hadoop core-site.xml need to be copied to 
Atlas conf directory by Ambari.

PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
attached on Apache JIRA.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 c74e029 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 d424f5b 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 3ed469a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 31cf0c8 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
6e1a52e 


Diff: https://reviews.apache.org/r/61083/diff/2/

Changes: https://reviews.apache.org/r/61083/diff/1-2/


Testing
---

Verified with installation on CentOS 6.


Thanks,

Vishal Suvagia



Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-27 Thread Vishal Suvagia via Review Board


> On July 24, 2017, 4:22 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
> > Lines 210 (patched)
> > 
> >
> > Why do we need to delete?
> 
> Vishal Suvagia wrote:
> Hi Jayush, 
> The core-site.xml file is present in the HBase conf directory for 
> previous stacks, so if we create core-site for previous stacks then this may 
> lead to duplicate configurations for core-site.xml i.e one core-site.xml in 
> HBase conf directory and one in Atlas conf directory, hence the deletion.
> 
> Alejandro Fernandez wrote:
> Can you add a comment explaining this logic? Then ship it.

Updating patch to skipping deletion of core-site.xml.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/#review181221
---


On July 24, 2017, 2:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61083/
> ---
> 
> (Updated July 24, 2017, 2:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21563
> https://issues.apache.org/jira/browse/AMBARI-21563
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas use user groups synced in hadoopUGI for authentication and 
> authorization process for LDAP/Kerberos type.
> As core-site.xml was available in HBase conf which is in Atlas classpath and 
> so core.site.xml configs were available. But now as core-site.xml is not 
> available in Hbase conf, to fix this issue hadoop core-site.xml need to be 
> copied to Atlas conf directory by Ambari.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  d424f5b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3ed469a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  31cf0c8 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> 6e1a52e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> d1d8b7f 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 
> 
> 
> Diff: https://reviews.apache.org/r/61083/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-27 Thread Vishal Suvagia via Review Board


> On July 25, 2017, 8:29 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
> > Lines 210 (patched)
> > 
> >
> > Multiple copies of core-site is fine isn't it. Assuming Atlas is now 
> > marked for restart when core-site is changed.

Having Multiple copies of core-site.xml, in Atlas classpath is working, so 
skipping deletion of core-site.xml


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/#review181373
---


On July 24, 2017, 2:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61083/
> ---
> 
> (Updated July 24, 2017, 2:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21563
> https://issues.apache.org/jira/browse/AMBARI-21563
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas use user groups synced in hadoopUGI for authentication and 
> authorization process for LDAP/Kerberos type.
> As core-site.xml was available in HBase conf which is in Atlas classpath and 
> so core.site.xml configs were available. But now as core-site.xml is not 
> available in Hbase conf, to fix this issue hadoop core-site.xml need to be 
> copied to Atlas conf directory by Ambari.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  d424f5b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3ed469a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  31cf0c8 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> 6e1a52e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> d1d8b7f 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 
> 
> 
> Diff: https://reviews.apache.org/r/61083/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-25 Thread Vishal Suvagia via Review Board


> On July 24, 2017, 4:22 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
> > Lines 210 (patched)
> > 
> >
> > Why do we need to delete?

Hi Jayush, 
The core-site.xml file is present in the HBase conf directory for previous 
stacks, so if we create core-site for previous stacks then this may lead to 
duplicate configurations for core-site.xml i.e one core-site.xml in HBase conf 
directory and one in Atlas conf directory, hence the deletion.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/#review181221
---


On July 24, 2017, 2:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61083/
> ---
> 
> (Updated July 24, 2017, 2:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21563
> https://issues.apache.org/jira/browse/AMBARI-21563
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas use user groups synced in hadoopUGI for authentication and 
> authorization process for LDAP/Kerberos type.
> As core-site.xml was available in HBase conf which is in Atlas classpath and 
> so core.site.xml configs were available. But now as core-site.xml is not 
> available in Hbase conf, to fix this issue hadoop core-site.xml need to be 
> copied to Atlas conf directory by Ambari.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  d424f5b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3ed469a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  31cf0c8 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> 6e1a52e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> d1d8b7f 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 
> 
> 
> Diff: https://reviews.apache.org/r/61083/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-24 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.


Bugs: AMBARI-21563
https://issues.apache.org/jira/browse/AMBARI-21563


Repository: ambari


Description
---

Atlas use user groups synced in hadoopUGI for authentication and authorization 
process for LDAP/Kerberos type.
As core-site.xml was available in HBase conf which is in Atlas classpath and so 
core.site.xml configs were available. But now as core-site.xml is not available 
in Hbase conf, to fix this issue hadoop core-site.xml need to be copied to 
Atlas conf directory by Ambari.

PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
attached on Apache JIRA.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 c74e029 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 d424f5b 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 3ed469a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 31cf0c8 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
6e1a52e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
d1d8b7f 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 


Diff: https://reviews.apache.org/r/61083/diff/1/


Testing
---

Verified with installation on CentOS 6.


Thanks,

Vishal Suvagia



Re: Review Request 60842: AMBARI-21460 : Add new kafka client properties to the ambari managed atlas config

2017-07-14 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60842/
---

(Updated July 14, 2017, 6:34 a.m.)


Review request for Ambari, Alejandro Fernandez, Ayub Pathan, Gautam Borad, 
Jayush Luniya, Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit 
Mohanty.


Changes
---

updating description for atlas.kafka.auto.commit.enable deletion.


Bugs: AMBARI-21460
https://issues.apache.org/jira/browse/AMBARI-21460


Repository: ambari


Description (updated)
---

As part of latest changes in Atlas Kafka configuration below new kafka client 
properties are introduced.

atlas.kafka.enable.auto.commit=false
atlas.kafka.session.timeout.ms=3
atlas.kafka.auto.commit.enable(is deleted)
Need to add this to the Ambari managed Atlas configurations.
PS: Attached patch is for trunk, seperate patch for branch-2.5 is attached on 
Apache JIRA.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
30796cc 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 1f37389 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
22c9a8d 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
 91de1b0 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
6dd2129 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 e262971 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
6b01ce9 


Diff: https://reviews.apache.org/r/60842/diff/1/


Testing
---

Verified with installation on CentOS 6.


Thanks,

Vishal Suvagia



Re: Review Request 60842: AMBARI-21460 : Add new kafka client properties to the ambari managed atlas config

2017-07-13 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60842/
---

(Updated July 13, 2017, 3:24 p.m.)


Review request for Ambari, Alejandro Fernandez, Ayub Pathan, Gautam Borad, 
Jayush Luniya, Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit 
Mohanty.


Bugs: AMBARI-21460
https://issues.apache.org/jira/browse/AMBARI-21460


Repository: ambari


Description (updated)
---

As part of latest changes in Atlas Kafka configuration below new kafka client 
properties are introduced.

atlas.kafka.enable.auto.commit=false
atlas.kafka.session.timeout.ms=3

Need to add this to the Ambari managed Atlas configurations.
PS: Attached patch is for trunk, seperate patch for branch-2.5 is attached on 
Apache JIRA.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
30796cc 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 1f37389 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
22c9a8d 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
 91de1b0 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
6dd2129 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 e262971 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
6b01ce9 


Diff: https://reviews.apache.org/r/60842/diff/1/


Testing
---

Verified with installation on CentOS 6.


Thanks,

Vishal Suvagia



Review Request 60842: AMBARI-21460 : Add new kafka client properties to the ambari managed atlas config

2017-07-13 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60842/
---

Review request for Ambari, Alejandro Fernandez, Ayub Pathan, Gautam Borad, 
Jayush Luniya, Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit 
Mohanty.


Summary (updated)
-

AMBARI-21460 : Add new kafka client properties to the ambari managed atlas 
config


Bugs: AMBARI-21460
https://issues.apache.org/jira/browse/AMBARI-21460


Repository: ambari


Description (updated)
---

As part of latest changes in Atlas Kafka configuration below new kafka client 
properties are introduced.

atlas.kafka.enable.auto.commit=false
atlas.kafka.session.timeout.ms=3

Need to add this to the Ambari managed Atlas configurations.


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
30796cc 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 1f37389 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
22c9a8d 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
 91de1b0 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
6dd2129 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 e262971 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
6b01ce9 


Diff: https://reviews.apache.org/r/60842/diff/1/


Testing (updated)
---

Verified with installation on CentOS 6.


Thanks,

Vishal Suvagia



Re: Review Request 60560: AMBARI-21374 : Replication factor should be configurable in Atlas to create solr collections

2017-07-02 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60560/
---

(Updated July 3, 2017, 5:35 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.


Changes
---

Updating patch to address review comments.


Bugs: AMBARI-21374
https://issues.apache.org/jira/browse/AMBARI-21374


Repository: ambari


Description
---

In current scenarios, Solr collections created for Atlas, has 
replication-factor dependent on the no of Infra-Solr servers present in Ambari, 
However to be more modular we should allow the replication factor to be 
configurable for the user.
PS: Attached patch is for trunk branch, patch for branch-2.5 is attached to 
Apache JIRA.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 111a248 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml
 c5a4fd6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/params.py
 d26df33 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-env.xml
 d54cf15 


Diff: https://reviews.apache.org/r/60560/diff/2/

Changes: https://reviews.apache.org/r/60560/diff/1-2/


Testing
---

Verified with installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Review Request 60560: AMBARI-21374 : Replication factor should be configurable in Atlas to create solr collections

2017-06-30 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60560/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.


Bugs: AMBARI-21374
https://issues.apache.org/jira/browse/AMBARI-21374


Repository: ambari


Description
---

In current scenarios, Solr collections created for Atlas, has 
replication-factor dependent on the no of Infra-Solr servers present in Ambari, 
However to be more modular we should allow the replication factor to be 
configurable for the user.
PS: Attached patch is for trunk branch, patch for branch-2.5 is attached to 
Apache JIRA.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 111a248 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml
 c5a4fd6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/params.py
 d26df33 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-env.xml
 d54cf15 


Diff: https://reviews.apache.org/r/60560/diff/1/


Testing
---

Verified with installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 60388: AMBARI-21256 : As part of START_ALL of services Ranger kms starts after hbase and hive causing operation failure

2017-06-26 Thread Vishal Suvagia via Review Board


> On June 26, 2017, 8:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/role_command_order.json
> > Lines 2 (patched)
> > 
> >
> > This file is also needed for HBase in 3.0

Hi Alejandro, The patch attached for the review is applicable for branch-2.5. 
The file is already present on trunk branch, addendum patch for which is 
attached to the Apache JIRA.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60388/#review178924
---


On June 23, 2017, 1:13 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60388/
> ---
> 
> (Updated June 23, 2017, 1:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-21256
> https://issues.apache.org/jira/browse/AMBARI-21256
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of START_ALL of services Ranger-KMS starts after Hbase and Hive 
> causing their start failure.
> In an encrypted cluster where TDE is on, Hbase service seems to be dependent 
> on the Ranger-KMS service, but for a start-all services action Hbase service 
> starts before Ranger-KMS.
> So Hbase master goes down while connecting to KMS, since at the time of Hbase 
> start KMS is down , connection to KMS fails, and Hbase-Master fails to become 
> active.
> This in-turn causes Atlas service start failure which actually depends on 
> HBase and start_all flow fails for HBASE and HIVE.
> 
> Attached patch is for branch-2.5, addendum trunk patch is attached to Apache 
> JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/role_command_order.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60388/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Review Request 60388: AMBARI-21256 : As part of START_ALL of services Ranger kms starts after hbase and hive causing operation failure

2017-06-23 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60388/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-21256
https://issues.apache.org/jira/browse/AMBARI-21256


Repository: ambari


Description
---

As part of START_ALL of services Ranger-KMS starts after Hbase and Hive causing 
their start failure.
In an encrypted cluster where TDE is on, Hbase service seems to be dependent on 
the Ranger-KMS service, but for a start-all services action Hbase service 
starts before Ranger-KMS.
So Hbase master goes down while connecting to KMS, since at the time of Hbase 
start KMS is down , connection to KMS fails, and Hbase-Master fails to become 
active.
This in-turn causes Atlas service start failure which actually depends on HBase 
and start_all flow fails for HBASE and HIVE.

Attached patch is for branch-2.5, addendum trunk patch is attached to Apache 
JIRA.


Diffs
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/role_command_order.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60388/diff/1/


Testing
---

Verified with installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 59701: AMBARI-21154 : Add JAAS config properties for Atlas Hive hook in HiveCli to use kerberos ticket-cache

2017-06-23 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59701/
---

(Updated June 23, 2017, 1:04 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Nixon Rodrigues, Robert Levas, and Sumit Mohanty.


Bugs: AMBARI-21154
https://issues.apache.org/jira/browse/AMBARI-21154


Repository: ambari


Description
---

In a kerberized environment, Atlas hook uses JAAS configuration section named 
"KakfaClient" to authenticate with Kafka broker. In a typical Hive deployment 
this configuration section is set to use the keytab and principal of 
HiveServer2 process. The hook running in HiveCLI might fail to authenticate 
with Kafka if the user can't read the configured keytab.

Given that HiveCLI users would have performed kinit, the hook in HiveCLI should 
use the ticket-cache generated by kinit. When ticket cache is not available 
(for example in HiveServer2), the hook should use the configuration provided in 
KafkaClient JAAS section

As a solution need to add below in hive atlas-application.properties by default 
if atlas-hive hook is enabled in secure mode

atlas.jaas.ticketBased-KafkaClient.loginModuleControlFlag=required
atlas.jaas.ticketBased-KafkaClient.loginModuleName=com.sun.security.auth.module.Krb5LoginModule
atlas.jaas.ticketBased-KafkaClient.option.useTicketCache=true

The attached patch is for trunk branch, patch for branch-2.5 is attached to 
Apache Jira


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py
 6d3e13d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a29f74b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 8c659ee 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
3054ca3 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
f8bbca5 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1cbd78b 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 ede267a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
b70943b 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py d4d28c9 


Diff: https://reviews.apache.org/r/59701/diff/3/

Changes: https://reviews.apache.org/r/59701/diff/2-3/


Testing
---

Verified fresh install and upgrade on Cent-OS-6.


Thanks,

Vishal Suvagia



Re: Review Request 59701: AMBARI-21154 : Add JAAS config properties for Atlas Hive hook in HiveCli to use kerberos ticket-cache

2017-06-23 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59701/
---

(Updated June 23, 2017, 12:44 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Nixon Rodrigues, Robert Levas, and Sumit Mohanty.


Changes
---

Patch for branch-2.5 is attached to Apache JIRA


Bugs: AMBARI-21154
https://issues.apache.org/jira/browse/AMBARI-21154


Repository: ambari


Description (updated)
---

In a kerberized environment, Atlas hook uses JAAS configuration section named 
"KakfaClient" to authenticate with Kafka broker. In a typical Hive deployment 
this configuration section is set to use the keytab and principal of 
HiveServer2 process. The hook running in HiveCLI might fail to authenticate 
with Kafka if the user can't read the configured keytab.

Given that HiveCLI users would have performed kinit, the hook in HiveCLI should 
use the ticket-cache generated by kinit. When ticket cache is not available 
(for example in HiveServer2), the hook should use the configuration provided in 
KafkaClient JAAS section

As a solution need to add below in hive atlas-application.properties by default 
if atlas-hive hook is enabled in secure mode

atlas.jaas.ticketBased-KafkaClient.loginModuleControlFlag=required
atlas.jaas.ticketBased-KafkaClient.loginModuleName=com.sun.security.auth.module.Krb5LoginModule
atlas.jaas.ticketBased-KafkaClient.option.useTicketCache=true

The attached patch is for trunk branch, patch for branch-2.5 is attached to 
Apache Jira


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py
 6d3e13d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a29f74b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 8c659ee 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
3054ca3 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
f8bbca5 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1cbd78b 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 ede267a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
b70943b 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py d4d28c9 


Diff: https://reviews.apache.org/r/59701/diff/2/


Testing
---

Verified fresh install and upgrade on Cent-OS-6.


Thanks,

Vishal Suvagia



Re: Review Request 59701: AMBARI-21154 : Add JAAS config properties for Atlas Hive hook in HiveCli to use kerberos ticket-cache

2017-06-23 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59701/
---

(Updated June 23, 2017, 12:38 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Nixon Rodrigues, Robert Levas, and Sumit Mohanty.


Changes
---

Updated patch to change approach by removing kerberos.json and adding required 
parameters in stack-advisor logic.


Bugs: AMBARI-21154
https://issues.apache.org/jira/browse/AMBARI-21154


Repository: ambari


Description
---

In a kerberized environment, Atlas hook uses JAAS configuration section named 
"KakfaClient" to authenticate with Kafka broker. In a typical Hive deployment 
this configuration section is set to use the keytab and principal of 
HiveServer2 process. The hook running in HiveCLI might fail to authenticate 
with Kafka if the user can't read the configured keytab.

Given that HiveCLI users would have performed kinit, the hook in HiveCLI should 
use the ticket-cache generated by kinit. When ticket cache is not available 
(for example in HiveServer2), the hook should use the configuration provided in 
KafkaClient JAAS section

As a solution need to add below in hive atlas-application.properties by default 
if atlas-hive hook is enabled in secure mode

atlas.jaas.ticketBased-KafkaClient.loginModuleControlFlag=required
atlas.jaas.ticketBased-KafkaClient.loginModuleName=com.sun.security.auth.module.Krb5LoginModule
atlas.jaas.ticketBased-KafkaClient.option.useTicketCache=true


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py
 6d3e13d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a29f74b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 8c659ee 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
3054ca3 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
f8bbca5 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1cbd78b 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 ede267a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
b70943b 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py d4d28c9 


Diff: https://reviews.apache.org/r/59701/diff/2/

Changes: https://reviews.apache.org/r/59701/diff/1-2/


Testing
---

Verified fresh install and upgrade on Cent-OS-6.


Thanks,

Vishal Suvagia



Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

2017-05-06 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/
---

(Updated May 6, 2017, 6:45 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.


Changes
---

Updated patch to address review comments.


Bugs: AMBARI-20932
https://issues.apache.org/jira/browse/AMBARI-20932


Repository: ambari


Description
---

Add support to enable Ranger Nifi plugin.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 c510dac 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
 661089a 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
 87fccbe 


Diff: https://reviews.apache.org/r/58995/diff/3/

Changes: https://reviews.apache.org/r/58995/diff/2-3/


Testing
---

Verified fresh installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

2017-05-05 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/
---

(Updated May 5, 2017, 1:44 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.


Changes
---

Updated patch to remove hardcoding of stack checks.


Bugs: AMBARI-20932
https://issues.apache.org/jira/browse/AMBARI-20932


Repository: ambari


Description
---

Add support to enable Ranger Nifi plugin.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 c510dac 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
 661089a 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
 87fccbe 


Diff: https://reviews.apache.org/r/58995/diff/2/

Changes: https://reviews.apache.org/r/58995/diff/1-2/


Testing
---

Verified fresh installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 58993: AMBARI-20930 : stackadvisor recommendations for atlas hooks should be disabled for external Atlas

2017-05-05 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58993/
---

(Updated May 5, 2017, 12:17 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, and Sumit Mohanty.


Changes
---

Updating patch to  include service recommendations for Hive service-advisor 3.0.


Bugs: AMBARI-20930
https://issues.apache.org/jira/browse/AMBARI-20930


Repository: ambari


Description
---

In cases where Atlas is not setup on the cluster but the Atlas hooks are 
enabled for external Atlas.
Ambari recommendations show to disable the Atlas hooks.
This behaviour needs to be changed to support externally used Atlas service.

PS: Attached patch is for trunk, patch for branch-2.5 is attached to 
AMBARI-20930 Apache JIRA.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py
 ef3e340 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
eb7389d 


Diff: https://reviews.apache.org/r/58993/diff/2/

Changes: https://reviews.apache.org/r/58993/diff/1-2/


Testing
---

Verified fresh installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

2017-05-04 Thread Vishal Suvagia via Review Board


> On May 4, 2017, 7:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 221 (patched)
> > 
> >
> > We should use stack_root and avoid harcoding HDP or HDF.

Hi Alejandro,
As Nifi will be an HDP add-on service, and bits for Nifi will be 
installed under path /usr/hdf/{stack-version} from HDF repos even in an HDP 
stack cluster. So to differentiate between HDF(for Nifi) and HDP, we will need 
to keep the stack-checks.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review173950
---


On May 4, 2017, 3:16 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> ---
> 
> (Updated May 4, 2017, 3:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add support to enable Ranger Nifi plugin.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  c510dac 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
>  661089a 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
>  87fccbe 
> 
> 
> Diff: https://reviews.apache.org/r/58995/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

2017-05-04 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-20932
https://issues.apache.org/jira/browse/AMBARI-20932


Repository: ambari


Description
---

Add support to enable Ranger Nifi plugin.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 c510dac 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
 661089a 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
 87fccbe 


Diff: https://reviews.apache.org/r/58995/diff/1/


Testing
---

Verified fresh installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Review Request 58993: AMBARI-20930 : stackadvisor recommendations for atlas hooks should be disabled for external Atlas

2017-05-04 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58993/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-20930
https://issues.apache.org/jira/browse/AMBARI-20930


Repository: ambari


Description
---

In cases where Atlas is not setup on the cluster but the Atlas hooks are 
enabled for external Atlas.
Ambari recommendations show to disable the Atlas hooks.
This behaviour needs to be changed to support externally used Atlas service.

PS: Attached patch is for trunk, patch for branch-2.5 is attached to 
AMBARI-20930 Apache JIRA.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
eb7389d 


Diff: https://reviews.apache.org/r/58993/diff/1/


Testing
---

Verified fresh installation on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-05-04 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/
---

(Updated May 4, 2017, 1:27 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, 
Oliver Szabo, and Velmurugan Periasamy.


Changes
---

Updated patch to handle errors using ExecutionFailure instead of Exceptions.


Bugs: AMBARI-20868
https://issues.apache.org/jira/browse/AMBARI-20868


Repository: ambari


Description
---

Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
need to handle errors and ensure Ranger start works, despite solr service being 
down.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 a8b7f24 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
 34ce70d 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
ad44033 


Diff: https://reviews.apache.org/r/58797/diff/3/

Changes: https://reviews.apache.org/r/58797/diff/2-3/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 58965: AMBARI-20920 : Atlas restart fails due to missing hbase dependency in role-command

2017-05-03 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58965/
---

(Updated May 3, 2017, 3:12 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-20920
https://issues.apache.org/jira/browse/AMBARI-20920


Repository: ambari


Description (updated)
---

ATLAS component STARTs or RESTARTs are dependent on HBASE STARTs/RESTARTs, so 
the commands will be scheduled appropriately. These should be captured in (role 
command order) for Atlas.

PS: Attached patch is for branch-2.5, trunk-addendum patch is attached to 
AMBARI-20920 Apache JIRA.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/role_command_order.json
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
58dcf8d 


Diff: https://reviews.apache.org/r/58965/diff/1/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia



Review Request 58965: AMBARI-20920 : Atlas restart fails due to missing hbase dependency in role-command

2017-05-03 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58965/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-20920
https://issues.apache.org/jira/browse/AMBARI-20920


Repository: ambari


Description
---

ATLAS component STARTs or RESTARTs are dependent on HBASE STARTs/RESTARTs, so 
the commands will be scheduled appropriately. These should be captured in (role 
command order) for Atlas.

PS: Attached patch is for branch-2.5, trunk-addendum patch is attached to 
AMBARI-20920 jira.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/role_command_order.json
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
58dcf8d 


Diff: https://reviews.apache.org/r/58965/diff/1/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-05-02 Thread Vishal Suvagia via Review Board


> On May 2, 2017, 10:10 a.m., Oliver Szabo wrote:
> > Im feeling that is not really the right solution to put the whole code into 
> > a big try catch block. it wont fail with even syntactic errors.

Hi Oliver,
 This is basically done so as to start Ranger irrespective of zookeeper 
error which can come in check_znode, As the error can now be visible to the 
user this may not affect the Ranger service start at all.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/#review173577
---


On April 27, 2017, 3:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58797/
> ---
> 
> (Updated April 27, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20868
> https://issues.apache.org/jira/browse/AMBARI-20868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
> need to handle errors and ensure Ranger start works, despite solr service 
> being down.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  e56a705 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  34ce70d 
> 
> 
> Diff: https://reviews.apache.org/r/58797/diff/2/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-04-27 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/
---

(Updated April 27, 2017, 3:51 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, 
Oliver Szabo, and Velmurugan Periasamy.


Changes
---

Updated patch to address review comments


Bugs: AMBARI-20868
https://issues.apache.org/jira/browse/AMBARI-20868


Repository: ambari


Description
---

Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
need to handle errors and ensure Ranger start works, despite solr service being 
down.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 e56a705 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
 34ce70d 


Diff: https://reviews.apache.org/r/58797/diff/2/

Changes: https://reviews.apache.org/r/58797/diff/1-2/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia



Review Request 58798: AMBARI-20873 : Atlas gc-worker logs are not generated due to incorrect configuration

2017-04-27 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58798/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-20873
https://issues.apache.org/jira/browse/AMBARI-20873


Repository: ambari


Description
---

Atlas gc-worker logs are not generated due to missing / in atlas configurations.
Currently it is set as -Xloggc:$ATLAS_LOG_DIRgc-worker.log it should actually 
be -Xloggc:$ATLAS_LOG_DIR/gc-worker.log


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
 bd0da9f 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
1c2ceff 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 be8b750 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 d822778 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
210c4e2 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
9a06dd0 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
f5d87e9 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 f7c276b 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
81757c1 


Diff: https://reviews.apache.org/r/58798/diff/1/


Testing
---

Verified fresh install and upgrade on Cent-OS 6.


Thanks,

Vishal Suvagia



Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-04-27 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58797/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, 
Oliver Szabo, and Velmurugan Periasamy.


Bugs: AMBARI-20868
https://issues.apache.org/jira/browse/AMBARI-20868


Repository: ambari


Description
---

Ranger Admin start fails when Ambari Infra or External Solr service is down,. 
need to handle errors and ensure Ranger start works, despite solr service being 
down.


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 e56a705 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
 34ce70d 


Diff: https://reviews.apache.org/r/58797/diff/1/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia



Review Request 58576: AMBARI-20792 : Atlas admin username and password should be configurable through ambari

2017-04-20 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58576/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-20792
https://issues.apache.org/jira/browse/AMBARI-20792


Repository: ambari


Description
---

Need a feature to configure Atlas admin user-name and password in Ambari.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 c25445c 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 e243662 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-env.xml
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58576/diff/1/


Testing
---

Verified fresh install and upgrade scenario on centos.


Thanks,

Vishal Suvagia



Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

2017-03-30 Thread Vishal Suvagia via Review Board


> On March 26, 2017, 4:47 p.m., Nate Cole wrote:
> > Any other upgrade paths other that 2.5 to 2.5,2.6? 2.4 to 2.6 or anything?

Atlas upgrade from stacks 2.3 / 2.4 to stacks 2.5 and above is not supported.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/#review170115
---


On March 23, 2017, 6:25 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57809/
> ---
> 
> (Updated March 23, 2017, 6:25 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Nate Cole, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20505
> https://issues.apache.org/jira/browse/AMBARI-20505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently zookeeper connect/session timeout values for atlas are set to 
> 200/400 ms respectively which are very low and not practical/recommended 
> values. Due to this atlas startup fails more frequently.Below are recommended 
> configurations.
> 
> For Atlas:
> atlas.kafka.zookeeper.connection.timeout.ms=3
> atlas.kafka.zookeeper.session.timeout.ms=6
> atlas.audit.zookeeper.session.timeout.ms=6
> 
> 
> As fresh installation scenario have already been fixed in AMBARI-19623, This 
> patch is to handle the EU and RU scenarios.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> c13724b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  39cb0dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  57a5203 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> b5b45cb 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 44d0a2a 
> 
> 
> Diff: https://reviews.apache.org/r/57809/diff/2/
> 
> 
> Testing
> ---
> 
> Verified install and upgrade on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

2017-03-30 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/
---

(Updated March 30, 2017, 1:58 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Nate Cole, Oliver Szabo, and Sumit Mohanty.


Changes
---

Updated  patch to fix the title.
Attached trunk addendum patch and branch-2.5 patch seperately to the 
AMBARI-20505 JIRA.


Bugs: AMBARI-20505
https://issues.apache.org/jira/browse/AMBARI-20505


Repository: ambari


Description
---

Currently zookeeper connect/session timeout values for atlas are set to 200/400 
ms respectively which are very low and not practical/recommended values. Due to 
this atlas startup fails more frequently.Below are recommended configurations.

For Atlas:
atlas.kafka.zookeeper.connection.timeout.ms=3
atlas.kafka.zookeeper.session.timeout.ms=6
atlas.audit.zookeeper.session.timeout.ms=6


As fresh installation scenario have already been fixed in AMBARI-19623, This 
patch is to handle the EU and RU scenarios.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 6f7fbd0 


Diff: https://reviews.apache.org/r/57809/diff/3/

Changes: https://reviews.apache.org/r/57809/diff/2-3/


Testing
---

Verified install and upgrade on CentOS-6.


Thanks,

Vishal Suvagia



Review Request 57909: AMBARI-20555 : Add Ambari cluster name for Ranger-Tagsync to sync generated atlas tags.

2017-03-24 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57909/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Nate Cole, Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-20555
https://issues.apache.org/jira/browse/AMBARI-20555


Repository: ambari


Description
---

Need to add ranger.tagsync.atlas.default.cluster.name property to 
ranger-tagsync-site.xml should be set to ambari cluster-name, to sync tags from 
Atlas metadata to Ranger.


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 0fae23e 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-site.xml
 d186625 


Diff: https://reviews.apache.org/r/57909/diff/1/


Testing
---

Verified fresh install and upgrade scenarios on seperate clusters on Cent-OS 6.


Thanks,

Vishal Suvagia



Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

2017-03-22 Thread Vishal Suvagia via Review Board


> On March 21, 2017, 8:06 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
> > Line 164 (original), 164 (patched)
> > 
> >
> > Is this meant to affect existing installs that just upgrade Ambari, or 
> > clusters that upgrade their stack to a specific version?

the patch is updated to change configurations when doing HDP upgrade.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/#review169605
---


On March 21, 2017, 3:23 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57809/
> ---
> 
> (Updated March 21, 2017, 3:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20505
> https://issues.apache.org/jira/browse/AMBARI-20505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently zookeeper connect/session timeout values for atlas are set to 
> 200/400 ms respectively which are very low and not practical/recommended 
> values. Due to this atlas startup fails more frequently.Below are recommended 
> configurations.
> 
> For Atlas:
> atlas.kafka.zookeeper.connection.timeout.ms=3
> atlas.kafka.zookeeper.session.timeout.ms=6
> atlas.audit.zookeeper.session.timeout.ms=6
> 
> For Zookeeper:
> tickTime=3000
> 
> As fresh installation scenario have already been fixed in AMBARI-19623, This 
> patch is to handle the EU and RU scenarios.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  e4fc3de 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  70af02c 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zoo.cfg.xml
>  5877877 
> 
> 
> Diff: https://reviews.apache.org/r/57809/diff/1/
> 
> 
> Testing
> ---
> 
> Verified install and upgrade on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>



Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

2017-03-22 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/
---

(Updated March 22, 2017, 6:22 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.


Changes
---

Updating patch to change configurations on HDP upgrades.
Seperate patch for branch-2.5 is attached to Apache JIRA.


Bugs: AMBARI-20505
https://issues.apache.org/jira/browse/AMBARI-20505


Repository: ambari


Description (updated)
---

Currently zookeeper connect/session timeout values for atlas are set to 200/400 
ms respectively which are very low and not practical/recommended values. Due to 
this atlas startup fails more frequently.Below are recommended configurations.

For Atlas:
atlas.kafka.zookeeper.connection.timeout.ms=3
atlas.kafka.zookeeper.session.timeout.ms=6
atlas.audit.zookeeper.session.timeout.ms=6


As fresh installation scenario have already been fixed in AMBARI-19623, This 
patch is to handle the EU and RU scenarios.


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
c13724b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 39cb0dc 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 57a5203 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
b5b45cb 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
44d0a2a 


Diff: https://reviews.apache.org/r/57809/diff/2/

Changes: https://reviews.apache.org/r/57809/diff/1-2/


Testing
---

Verified install and upgrade on CentOS-6.


Thanks,

Vishal Suvagia



Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

2017-03-21 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-20505
https://issues.apache.org/jira/browse/AMBARI-20505


Repository: ambari


Description
---

Currently zookeeper connect/session timeout values for atlas are set to 200/400 
ms respectively which are very low and not practical/recommended values. Due to 
this atlas startup fails more frequently.Below are recommended configurations.

For Atlas:
atlas.kafka.zookeeper.connection.timeout.ms=3
atlas.kafka.zookeeper.session.timeout.ms=6
atlas.audit.zookeeper.session.timeout.ms=6

For Zookeeper:
tickTime=3000

As fresh installation scenario have already been fixed in AMBARI-19623, This 
patch is to handle the EU and RU scenarios.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 e4fc3de 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
 70af02c 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zoo.cfg.xml
 5877877 


Diff: https://reviews.apache.org/r/57809/diff/1/


Testing
---

Verified install and upgrade on CentOS-6.


Thanks,

Vishal Suvagia



Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

2017-03-02 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/
---

(Updated March 2, 2017, 10:52 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.


Changes
---

Updating code to remove leading and trailing whitespaces, adding testcases to 
cover sasl scenario.


Bugs: AMBARI-20208
https://issues.apache.org/jira/browse/AMBARI-20208


Repository: ambari


Description
---

Adding dependency of kafka broker's listeners config to populate accurate port 
for Atlas atlas.kafka.bootstrap.servers property.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
 15cc73b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
a450d4d 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3 


Diff: https://reviews.apache.org/r/57139/diff/3/

Changes: https://reviews.apache.org/r/57139/diff/2-3/


Testing
---

Verified dependency of : listeners propert for following cases: 

1) Simple environment with listener's value as : PLAINTEXT://localhost:

2) Kerberos environment with listener's value as : 
PLAINTEXTSASL://localhost:

3) Kerberos environment with listener's value as : 
PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:

4) Kerberos environment with listener's value as : PLAINTEXT://localhost: 
:: in this case it will pickup the port given for PLAINTEXT protocol only (as 
SASL port is not specified).


Thanks,

Vishal Suvagia



Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

2017-03-01 Thread Vishal Suvagia via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/
---

(Updated March 1, 2017, 12:36 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.


Changes
---

updating patch to fix overlooked scenarios.


Bugs: AMBARI-20208
https://issues.apache.org/jira/browse/AMBARI-20208


Repository: ambari


Description
---

Adding dependency of kafka broker's listeners config to populate accurate port 
for Atlas atlas.kafka.bootstrap.servers property.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
 15cc73b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
6f3dfa7 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py cf1c0ee 


Diff: https://reviews.apache.org/r/57139/diff/2/

Changes: https://reviews.apache.org/r/57139/diff/1-2/


Testing
---

Verified dependency of : listeners propert for following cases: 

1) Simple environment with listener's value as : PLAINTEXT://localhost:

2) Kerberos environment with listener's value as : 
PLAINTEXTSASL://localhost:

3) Kerberos environment with listener's value as : 
PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:

4) Kerberos environment with listener's value as : PLAINTEXT://localhost: 
:: in this case it will pickup the port given for PLAINTEXT protocol only (as 
SASL port is not specified).


Thanks,

Vishal Suvagia