Re: Review Request 45998: HIVE service_check doesn't work properly

[Andrew Onischuk]

> On April 21, 2016, 12:25 a.m., Masahiro Tanaka wrote:
> > Thanks for the review Nate and Andrew!
> > Could you commit this?

before we can commit we need an apache jira for this change, and +1 from Hadoop 
QA. 

Do you have one? If yes specify its id in "Bugs" field here.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review129845
---


On April 16, 2016, 7:02 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 16, 2016, 7:02 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  9965bfa9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 6c4dc00 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Masahiro Tanaka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review129845
---



Thanks for the review Nate and Andrew!
Could you commit this?

- Masahiro Tanaka


On 4月 16, 2016, 7:02 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated 4月 16, 2016, 7:02 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  9965bfa9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 6c4dc00 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Masahiro Tanaka]

> On 4月 20, 2016, 1:17 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py,
> >  lines 117-119
> > 
> >
> > Given how many things get passed to this script, why not do all this in 
> > python?  Seems a whole lot of setup for a script file that we control 
> > anyway.  We have plenty of knowledge around making curl calls and reading 
> > output etc.  Food for thought; I'm not holding up the review for it.

Yes, this is complicated and buggy. We might should replace these shell script 
with python.


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review129732
---


On 4月 16, 2016, 7:02 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated 4月 16, 2016, 7:02 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  9965bfa9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 6c4dc00 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review129733
---


Ship it!




Ship It!

- Andrew Onischuk


On April 16, 2016, 7:02 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 16, 2016, 7:02 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  9965bfa9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 6c4dc00 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review129732
---


Ship it!





ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
 (lines 117 - 119)


Given how many things get passed to this script, why not do all this in 
python?  Seems a whole lot of setup for a script file that we control anyway.  
We have plenty of knowledge around making curl calls and reading output etc.  
Food for thought; I'm not holding up the review for it.


- Nate Cole


On April 16, 2016, 3:02 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 16, 2016, 3:02 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  9965bfa9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 6c4dc00 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Masahiro Tanaka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review129700
---



Could anyone review this?

- Masahiro Tanaka


On 4月 16, 2016, 7:02 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated 4月 16, 2016, 7:02 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  9965bfa9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 6c4dc00 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Masahiro Tanaka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/
---

(Updated April 16, 2016, 7:02 p.m.)


Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.


Changes
---

Update a patch


Repository: ambari


Description
---

In templetonSmoke.sh, there are
1) unnecessary `exit 0`
2) lack of redirect `>` command
3) unassigned variable

we should correct them all to check the HIVE service properly.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 dd00e02 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
 9965bfa9 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
6c4dc00 

Diff: https://reviews.apache.org/r/45998/diff/


Testing
---

mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0


Thanks,

Masahiro Tanaka

Re: Review Request 45998: HIVE service_check doesn't work properly

[Masahiro Tanaka]

> On April 11, 2016, 4:21 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh,
> >  line 84
> > 
> >
> > I wonder where this $destdir variable comes from
> 
> Andrew Onischuk wrote:
> or was it not working at all?

Thank you for reviewing, I guess this code was not working at all because of 
`exit 0`...


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review128062
---


On April 11, 2016, 3:07 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 11, 2016, 3:07 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review128118
---


Ship it!




Ship It!

- Nate Cole


On April 10, 2016, 11:07 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 10, 2016, 11:07 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review128064
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 (line 59)


/tmp/show_db.post.txt is this a path in local filesystem?

If yes, we should use agent tmp_dir, because some users has non-executable 
tmp.

You will have to get it from params.tmp_dir and pass it into script.


- Andrew Onischuk


On April 11, 2016, 3:07 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 11, 2016, 3:07 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Andrew Onischuk]

> On April 11, 2016, 4:21 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh,
> >  line 84
> > 
> >
> > I wonder where this $destdir variable comes from

or was it not working at all?


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review128062
---


On April 11, 2016, 3:07 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 11, 2016, 3:07 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review128062
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 (line 81)


I wonder where this $destdir variable comes from


- Andrew Onischuk


On April 11, 2016, 3:07 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 11, 2016, 3:07 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>