Re: Review Request 57451: The Installation of hbase-client failed

2017-04-17 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review172097
---




ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
Line 115 (original)


Just curious, did someone from the Hbase project confirm this change?


- Alejandro Fernandez


On April 14, 2017, 4:52 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated April 14, 2017, 4:52 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  20894ec 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/6/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-13 Thread zhangxiaolu zhangxiaolu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
---

(Updated 四月 14, 2017, 4:52 a.m.)


Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Yusaku Sako.


Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368


Repository: ambari


Description
---

The problem is caused by the wrong installation order, which means hbase-client 
will be installed before the installation of hdfs-client. Under such 
circumstance, installation of hdfs-client will fail because the hadoop-conf-dir 
does not exist. 
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when 
adding new host, therefore, in my opinion, the second choice would be more 
appropriate.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 20894ec 


Diff: https://reviews.apache.org/r/57451/diff/6/

Changes: https://reviews.apache.org/r/57451/diff/5-6/


Testing
---

done it


File Attachments


AMBARI-20368.patch
  
https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch


Thanks,

zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-13 Thread zhangxiaolu zhangxiaolu 


> On 四月 12, 2017, 4:35 p.m., Alejandro Fernandez wrote:
> >

In the trunk,the relative code about hadoop_conf_dir has been removed,and there 
is no problem , and I will cancle this jira.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171749
---


On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 四月 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-13 Thread zhangxiaolu zhangxiaolu 


> On 四月 12, 2017, 4:35 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 67 (patched)
> > 
> >
> > I've actually never seen this, so perhaps a more appropriate fix would 
> > be in HDFS Client instead.
> > HDFS Client itself should ensure that the hadoop conf dir exists.

Maybe we can take the Role Command Order rules to handle this scenario.
But I still think creating the config dir is better if not existing the hdfs's 
config dir.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171749
---


On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 四月 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-12 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171749
---




ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
Lines 67 (patched)


I've actually never seen this, so perhaps a more appropriate fix would be 
in HDFS Client instead.
HDFS Client itself should ensure that the hadoop conf dir exists.


- Alejandro Fernandez


On April 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated April 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-12 Thread zhangxiaolu zhangxiaolu 


> On 四月 11, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 67 (patched)
> > 
> >
> > I'm thinking more about this, what happens if Ambari Agent is running 
> > as non-root?
> > 
> > Perhaps we should instead 
> > 1. introduce Role Command Order rules to handle this scenario
> > OR
> > 2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf 
> > dir doesn't exist.
> > 
> > I prefer option #2 since components should all be idempotent.
> > 
> > How frequently does this happen? Is it only during UI, or BP installs?
> 
> zhangxiaolu zhangxiaolu wrote:
> It happened frequently especially installing all services in first time?I 
> hasn't tested it in BP.

And i'm confused if tried again three times and it would passed when installing 
all services in first time.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171602
---


On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 四月 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-12 Thread zhangxiaolu zhangxiaolu 


> On 四月 11, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 67 (patched)
> > 
> >
> > I'm thinking more about this, what happens if Ambari Agent is running 
> > as non-root?
> > 
> > Perhaps we should instead 
> > 1. introduce Role Command Order rules to handle this scenario
> > OR
> > 2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf 
> > dir doesn't exist.
> > 
> > I prefer option #2 since components should all be idempotent.
> > 
> > How frequently does this happen? Is it only during UI, or BP installs?

It happened frequently especially installing all services in first time?I 
hasn't tested it in BP.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171602
---


On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 四月 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-11 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171602
---




ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
Lines 67 (patched)


I'm thinking more about this, what happens if Ambari Agent is running as 
non-root?

Perhaps we should instead 
1. introduce Role Command Order rules to handle this scenario
OR
2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf dir 
doesn't exist.

I prefer option #2 since components should all be idempotent.

How frequently does this happen? Is it only during UI, or BP installs?


- Alejandro Fernandez


On April 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated April 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-11 Thread zhangxiaolu zhangxiaolu 


> On 三月 20, 2017, 5:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 59 (patched)
> > 
> >
> > Python unit tests are failing.
> > Please see comment in Jira

I added some test and all test passed.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review169470
---


On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 四月 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-09 Thread zhangxiaolu zhangxiaolu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
---

(Updated 四月 9, 2017, 6:40 a.m.)


Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Yusaku Sako.


Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368


Repository: ambari


Description
---

The problem is caused by the wrong installation order, which means hbase-client 
will be installed before the installation of hdfs-client. Under such 
circumstance, installation of hdfs-client will fail because the hadoop-conf-dir 
does not exist. 
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when 
adding new host, therefore, in my opinion, the second choice would be more 
appropriate.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 8ad802e 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
9bb0dd7 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
60022e1 


Diff: https://reviews.apache.org/r/57451/diff/4/

Changes: https://reviews.apache.org/r/57451/diff/3-4/


Testing
---

done it


File Attachments


AMBARI-20368.patch
  
https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch


Thanks,

zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-07 Thread zhangxiaolu zhangxiaolu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
---

(Updated 四月 7, 2017, 11:05 p.m.)


Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Yusaku Sako.


Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368


Repository: ambari


Description
---

The problem is caused by the wrong installation order, which means hbase-client 
will be installed before the installation of hdfs-client. Under such 
circumstance, installation of hdfs-client will fail because the hadoop-conf-dir 
does not exist. 
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when 
adding new host, therefore, in my opinion, the second choice would be more 
appropriate.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 8ad802e 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py cffec06 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 42bc989 


Diff: https://reviews.apache.org/r/57451/diff/3/

Changes: https://reviews.apache.org/r/57451/diff/2-3/


Testing
---

done it


File Attachments


AMBARI-20368.patch
  
https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch


Thanks,

zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-20 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review169470
---




ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
Lines 59 (patched)


Python unit tests are failing.
Please see comment in Jira


- Alejandro Fernandez


On March 16, 2017, 12:51 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated March 16, 2017, 12:51 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  20894ec 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/1/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-15 Thread zhangxiaolu zhangxiaolu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
---

(Updated 三月 16, 2017, 12:51 a.m.)


Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Yusaku Sako.


Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368


Repository: ambari


Description
---

The problem is caused by the wrong installation order, which means hbase-client 
will be installed before the installation of hdfs-client. Under such 
circumstance, installation of hdfs-client will fail because the hadoop-conf-dir 
does not exist. 
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when 
adding new host, therefore, in my opinion, the second choice would be more 
appropriate.


Diffs
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 20894ec 


Diff: https://reviews.apache.org/r/57451/diff/1/


Testing
---

done it


Thanks,

zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-14 Thread zhangxiaolu zhangxiaolu 


> On 三月 9, 2017, 8:43 p.m., Alejandro Fernandez wrote:
> > +1. I agree, especially if HBase client is added on this host, and at a 
> > later time HDFS client is added.
> 
> zhangxiaolu zhangxiaolu wrote:
> Thank you so much for reviewing my patch on reviewboard, and could you 
> commit the patch ? Thanks a lot.

Yes, you're right.Thank you so much for reviewing my patch on reviewboard, and 
could you commit the patch ? Thanks a lot.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review168511
---


On 三月 9, 2017, 8 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 三月 9, 2017, 8 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  20894ec 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/1/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-09 Thread zhangxiaolu zhangxiaolu 


> On 三月 9, 2017, 8:43 p.m., Alejandro Fernandez wrote:
> > +1. I agree, especially if HBase client is added on this host, and at a 
> > later time HDFS client is added.

Thank you so much for reviewing my patch on reviewboard, and could you commit 
the patch ? Thanks a lot.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review168511
---


On 三月 9, 2017, 8 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 三月 9, 2017, 8 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  20894ec 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/1/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-09 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review168511
---


Ship it!




+1. I agree, especially if HBase client is added on this host, and at a later 
time HDFS client is added.

- Alejandro Fernandez


On March 9, 2017, 8 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated March 9, 2017, 8 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  20894ec 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/1/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-09 Thread zhangxiaolu zhangxiaolu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
---

(Updated 三月 9, 2017, 8 a.m.)


Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Yusaku Sako.


Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368


Repository: ambari


Description (updated)
---

The problem is caused by the wrong installation order, which means hbase-client 
will be installed before the installation of hdfs-client. Under such 
circumstance, installation of hdfs-client will fail because the hadoop-conf-dir 
does not exist. 
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when 
adding new host, therefore, in my opinion, the second choice would be more 
appropriate.


Diffs
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 20894ec 


Diff: https://reviews.apache.org/r/57451/diff/1/


Testing
---

done it


Thanks,

zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-08 Thread zhangxiaolu zhangxiaolu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
---

(Updated 三月 9, 2017, 7:51 a.m.)


Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Yusaku Sako.


Summary (updated)
-

The Installation of hbase-client failed


Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368


Repository: ambari


Description
---

The problem is that the installtation of hbase-client is before hdfs-client, 
and the dir of hadoop-conf doesn't exist. 
so there are two ways to solve this problem.
the first method is that create the hadoop-conf-dir in hbase.py
the second method is that setting the orders in role_command_order.json.
I think that we can take the first method.The reasons as follows:
the host maybe not install hdfs-client when adding new host especially.


Diffs
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 20894ec 


Diff: https://reviews.apache.org/r/57451/diff/1/


Testing
---

done it


Thanks,

zhangxiaolu zhangxiaolu