Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62377 --- @ReviewBot retry please - Kevin Sweeney On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 18, 2014, 12:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java 19bf162586b90329e764cacf992df37ca68b0dc0 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 9e8ba658144c92eea6d24725ec47a8c0710c69c9 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 48b3d886844622288be4131dfe8f2a77f7e316e7 Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62379 --- Master (6d06d86) is red with this patch. ./build-support/jenkins/build.sh File /usr/lib/python2.7/sysconfig.py, line 355, in _init_posix raise IOError(msg) IOError: invalid Python installation: unable to open /x1/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/local/include/python2.7/pyconfig.h (No such file or directory) Build operating on top level addresses: set([BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD, all)]) Problem executing PythonBuilder for targets OrderedSet([PythonTests(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, api)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, api)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, restarter)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, instance_watcher)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/au th/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, transport)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_mux)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, error_handling_thread)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, task_util)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, base)), PythonLibrary (BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, http_signaler)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater_util)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, sla)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, common)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, aurora_job_key)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster_option)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, clusters)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/ workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-storage)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, job_monitor)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, quota_check)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace /AuroraBot/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD, util)),
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62491 --- @ReviewBot retry - Kevin Sweeney On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 18, 2014, 12:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java 19bf162586b90329e764cacf992df37ca68b0dc0 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 9e8ba658144c92eea6d24725ec47a8c0710c69c9 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 48b3d886844622288be4131dfe8f2a77f7e316e7 Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62504 --- Ship it! Master (ada97bd) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Nov. 18, 2014, 8:26 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 18, 2014, 8:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java 19bf162586b90329e764cacf992df37ca68b0dc0 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 9e8ba658144c92eea6d24725ec47a8c0710c69c9 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 48b3d886844622288be4131dfe8f2a77f7e316e7 Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27757: Replace bindStartupAction with Service registration
On Nov. 11, 2014, 2:34 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java, line 103 https://reviews.apache.org/r/27757/diff/1/?file=755113#file755113line103 remove fixed. On Nov. 11, 2014, 2:34 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java, line 74 https://reviews.apache.org/r/27757/diff/1/?file=755101#file755101line74 remove comment Done. On Nov. 11, 2014, 2:34 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 251 https://reviews.apache.org/r/27757/diff/1/?file=755103#file755103line251 revert Fixed. On Nov. 11, 2014, 2:34 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java, line 72 https://reviews.apache.org/r/27757/diff/1/?file=755101#file755101line72 How about fully untethering here and doing this work in `SchedulerMain`? nowhere immediately jumps out as the right place to put this and I'd like to minimize the ripple here. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review60874 --- On Nov. 7, 2014, 4:06 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 7, 2014, 4:06 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java fef76f5069a80959eaba04f1b4b93ff3f6ba43dd src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java cd5aa17b24209b186314f431c65062d6ed9972cb src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57 src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 662ebdceff580af0a05f9a89d50ca1c90ddc9070 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java e884209fd5965e50847f14b09a43f6aba4946b7e Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review61999 --- Master (c44aa5c) is red with this patch. ./build-support/jenkins/build.sh Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth Found existing installation: setuptools 3.6 Uninstalling setuptools: Successfully uninstalled setuptools Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon requests twitter.common.collections twitter.common.config twitter.common.confluence twitter.common.contextutil twitter.common.decorators twitter.common.dirutil twitter.common.lang twitter.common.log twitter.common.options twitter.common.process twitter.common.string twitter.common.threading twitter.common.util setuptools Cleaning up... Build operating on top level addresses: set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD, all)]) Problem executing PythonBuilder for targets OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, restarter)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, instance_watcher)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au rora/common/auth/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, transport)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_mux)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, error_handling_thread)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, task_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/ BUILD, base)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, http_signaler)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, sla)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, common)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, aurora_job_key)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster_option)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, clusters)), PythonLibrary(B uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-storage)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater)),
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62001 --- @ReviewBot retry - Kevin Sweeney On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 18, 2014, 12:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java 19bf162586b90329e764cacf992df37ca68b0dc0 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 9e8ba658144c92eea6d24725ec47a8c0710c69c9 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 48b3d886844622288be4131dfe8f2a77f7e316e7 Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62005 --- Master (c44aa5c) is red with this patch. ./build-support/jenkins/build.sh Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth Found existing installation: setuptools 3.6 Uninstalling setuptools: Successfully uninstalled setuptools Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon requests twitter.common.collections twitter.common.config twitter.common.confluence twitter.common.contextutil twitter.common.decorators twitter.common.dirutil twitter.common.lang twitter.common.log twitter.common.options twitter.common.process twitter.common.string twitter.common.threading twitter.common.util setuptools Cleaning up... Build operating on top level addresses: set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD, all)]) Problem executing PythonBuilder for targets OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, restarter)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, instance_watcher)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au rora/common/auth/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, transport)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_mux)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, error_handling_thread)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, task_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/ BUILD, base)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, http_signaler)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, sla)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, common)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, aurora_job_key)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster_option)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, clusters)), PythonLibrary(B uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-storage)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater)),
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62007 --- @ReviewBot retry - Kevin Sweeney On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 18, 2014, 12:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java 19bf162586b90329e764cacf992df37ca68b0dc0 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 9e8ba658144c92eea6d24725ec47a8c0710c69c9 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 48b3d886844622288be4131dfe8f2a77f7e316e7 Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62010 --- Master (c44aa5c) is red with this patch. ./build-support/jenkins/build.sh Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth Found existing installation: setuptools 3.6 Uninstalling setuptools: Successfully uninstalled setuptools Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon requests twitter.common.collections twitter.common.config twitter.common.confluence twitter.common.contextutil twitter.common.decorators twitter.common.dirutil twitter.common.lang twitter.common.log twitter.common.options twitter.common.process twitter.common.string twitter.common.threading twitter.common.util setuptools Cleaning up... Build operating on top level addresses: set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD, all)]) Problem executing PythonBuilder for targets OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, restarter)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, instance_watcher)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au rora/common/auth/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, transport)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_mux)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, error_handling_thread)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, task_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/ BUILD, base)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, http_signaler)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, sla)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, common)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, aurora_job_key)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster_option)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, clusters)), PythonLibrary(B uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-storage)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater)),
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62011 --- @ReviewBot retry - Kevin Sweeney On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 18, 2014, 12:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java 19bf162586b90329e764cacf992df37ca68b0dc0 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 9e8ba658144c92eea6d24725ec47a8c0710c69c9 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 48b3d886844622288be4131dfe8f2a77f7e316e7 Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62012 --- Master (c44aa5c) is red with this patch. ./build-support/jenkins/build.sh Uninstalling setuptools: Successfully uninstalled setuptools Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon requests twitter.common.collections twitter.common.config twitter.common.confluence twitter.common.contextutil twitter.common.decorators twitter.common.dirutil twitter.common.lang twitter.common.log twitter.common.options twitter.common.process twitter.common.string twitter.common.threading twitter.common.util setuptools Cleaning up... Build operating on top level addresses: set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD, all)]) Problem executing PythonBuilder for targets OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, restarter)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, instance_watcher)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au rora/common/auth/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, transport)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_mux)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, error_handling_thread)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, task_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/ BUILD, base)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, http_signaler)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, sla)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, common)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, aurora_job_key)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster_option)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, clusters)), PythonLibrary(B uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-storage)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, job_monitor)),
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62015 --- @Reviewbot retry please? - Kevin Sweeney On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 18, 2014, 12:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java 19bf162586b90329e764cacf992df37ca68b0dc0 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 9e8ba658144c92eea6d24725ec47a8c0710c69c9 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 48b3d886844622288be4131dfe8f2a77f7e316e7 Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62017 --- Master (c44aa5c) is red with this patch. ./build-support/jenkins/build.sh Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth Found existing installation: setuptools 3.6 Uninstalling setuptools: Successfully uninstalled setuptools Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon requests twitter.common.collections twitter.common.config twitter.common.confluence twitter.common.contextutil twitter.common.decorators twitter.common.dirutil twitter.common.lang twitter.common.log twitter.common.options twitter.common.process twitter.common.string twitter.common.threading twitter.common.util setuptools Cleaning up... Build operating on top level addresses: set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD, all)]) Problem executing PythonBuilder for targets OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, restarter)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, instance_watcher)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au rora/common/auth/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, transport)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_mux)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, error_handling_thread)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, task_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/ BUILD, base)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, http_signaler)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, sla)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, common)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, aurora_job_key)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster_option)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, clusters)), PythonLibrary(B uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-storage)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater)),
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review60874 --- Ship it! src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java https://reviews.apache.org/r/27757/#comment102284 How about fully untethering here and doing this work in `SchedulerMain`? src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java https://reviews.apache.org/r/27757/#comment102282 remove comment src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java https://reviews.apache.org/r/27757/#comment102286 revert src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java https://reviews.apache.org/r/27757/#comment102287 remove - Bill Farner On Nov. 8, 2014, 12:06 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 8, 2014, 12:06 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java fef76f5069a80959eaba04f1b4b93ff3f6ba43dd src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java cd5aa17b24209b186314f431c65062d6ed9972cb src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57 src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 662ebdceff580af0a05f9a89d50ca1c90ddc9070 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java e884209fd5965e50847f14b09a43f6aba4946b7e Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java fef76f5069a80959eaba04f1b4b93ff3f6ba43dd src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java cd5aa17b24209b186314f431c65062d6ed9972cb src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57 src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 662ebdceff580af0a05f9a89d50ca1c90ddc9070 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java e884209fd5965e50847f14b09a43f6aba4946b7e Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 27757: Replace bindStartupAction with Service registration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review60433 --- Ship it! Master (66bd6fe) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Nov. 8, 2014, 12:06 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- (Updated Nov. 8, 2014, 12:06 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description --- This attempts to kill LifecycleModule in favor of service registration. Diffs - src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 72d3d60c602b2cf01445f64f3be7e4ecf53008ca src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/AppModule.java fef76f5069a80959eaba04f1b4b93ff3f6ba43dd src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 8e9a1dc10998a313ad92e365c739b74f892e82ce src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 22c666e28e03f3c1e5a1d89fda55641526b11162 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java cd5aa17b24209b186314f431c65062d6ed9972cb src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 36706f200e245ea08afa4dd36cb3511d0a63b097 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 354844a2540dec6450724acca18c399bc6c01f44 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57 src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java a7f9401f70b567002c83f4f56407b4e1d3afa5a5 src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 1376237efc8f109d5a57bb8bff1c05026f257418 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 662ebdceff580af0a05f9a89d50ca1c90ddc9070 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 4d58240234b8e48c1f081a8ae647c54095f9dc1d src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java e884209fd5965e50847f14b09a43f6aba4946b7e Diff: https://reviews.apache.org/r/27757/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
