[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10398 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2473/ -- To view, visit http://gerrit.cloudera.org:8080/10398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Gerrit-Change-Number: 10398 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 15 May 2018 06:15:45 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10398 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 1: Code-Review+2 Fix one minor planner tests difference. -- To view, visit http://gerrit.cloudera.org:8080/10398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Gerrit-Change-Number: 10398 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 15 May 2018 06:15:55 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10398 to look at the new patch set (#2). Change subject: IMPALA-6957: calc thread resource requirement in planner .. IMPALA-6957: calc thread resource requirement in planner This only factors in fragment execution threads. E.g. this does *not* try to account for the number of threads on the old Thrift RPC code path if that is enabled. This is loosely related to the old VCores estimate, but is different in that it: * Directly ties into the notion of required threads in ThreadResourceMgr. * Is a strict upper bound on the number of such threads, rather than an estimate. Does not include "optional" threads. ThreadResourceMgr in the backend bounds the number of "optional" threads per impalad, so the number of execution threads on a backend is limited by sum(required threads per query) + CpuInfo::num_cores() * FLAGS_num_threads_per_core DCHECKS in the backend enforce that the calculation is correct. They were actually hit in KuduScanNode because of some races in thread management leading to multiple "required" threads running. Now the first thread in the multithreaded scans never exits, which means that it's always safe for any of the other threads to exit early, which simplifies the logic a lot. Testing: Updated planner tests. Ran core tests. Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Reviewed-on: http://gerrit.cloudera.org:8080/10256 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/exec/hdfs-scan-node.cc M be/src/exec/hdfs-scan-node.h M be/src/exec/kudu-scan-node.cc M be/src/exec/kudu-scan-node.h M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/query-state.cc M be/src/runtime/runtime-state.cc M be/src/runtime/thread-resource-mgr.cc M be/src/runtime/thread-resource-mgr.h M be/src/scheduling/admission-controller.cc M be/src/scheduling/query-schedule.h M be/src/scheduling/scheduler.cc M common/thrift/Frontend.thrift M common/thrift/ImpalaInternalService.thrift M common/thrift/Planner.thrift M fe/src/main/java/org/apache/impala/planner/AggregationNode.java M fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java M fe/src/main/java/org/apache/impala/planner/HashJoinNode.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/main/java/org/apache/impala/planner/PlanFragment.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/main/java/org/apache/impala/planner/ResourceProfile.java M fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java M fe/src/main/java/org/apache/impala/planner/SortNode.java M testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test M testdata/workloads/functional-planner/queries/PlannerTest/disable-codegen.test M testdata/workloads/functional-planner/queries/PlannerTest/fk-pk-join-detection.test M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test M testdata/workloads/functional-planner/queries/PlannerTest/max-row-size.test M testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test M testdata/workloads/functional-planner/queries/PlannerTest/partition-pruning.test M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test M testdata/workloads/functional-planner/queries/PlannerTest/sort-expr-materialization.test M testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test M testdata/workloads/functional-planner/queries/PlannerTest/tablesample.test M testdata/workloads/functional-planner/queries/PlannerTest/union.test M testdata/workloads/functional-query/queries/QueryTest/explain-level0.test M testdata/workloads/functional-query/queries/QueryTest/explain-level1.test M testdata/workloads/functional-query/queries/QueryTest/explain-level2.test M testdata/workloads/functional-query/queries/QueryTest/explain-level3.test 43 files changed, 1,973 insertions(+), 1,927 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/10398/2 -- To view, visit http://gerrit.cloudera.org:8080/10398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Gerrit-Change-Number: 10398 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2468/ -- To view, visit http://gerrit.cloudera.org:8080/10381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8299a8a97ad1f2bd1f2927e3111db8df1d3a3e5 Gerrit-Change-Number: 10381 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Brown Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Tue, 15 May 2018 06:10:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. IMPALA-6916: Implement COMMENT ON DATABASE This patch implements updating comment on a database. Syntax: COMMENT ON DATABASE db IS 'comment' Testing: - Added new front-end tests - Ran all front-end tests - Added new end-to-end tests - Ran end-to-end DDL tests Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Reviewed-on: http://gerrit.cloudera.org:8080/10171 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins --- M common/thrift/CatalogService.thrift M common/thrift/JniCatalog.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java A fe/src/main/java/org/apache/impala/analysis/CommentOnDbStmt.java A fe/src/main/java/org/apache/impala/analysis/CommentOnStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M tests/metadata/test_ddl.py M tests/metadata/test_ddl_base.py 13 files changed, 233 insertions(+), 5 deletions(-) Approvals: Alex Behm: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 12 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 11 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 15 May 2018 04:02:29 + Gerrit-HasComments: No
[Impala-ASF-CR] Put ASAN options in CMakeLists.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10404 ) Change subject: Put ASAN options in CMakeLists. .. Patch Set 1: By way of testing, I ran an ASAN build with test-with-docker (https://gerrit.cloudera.org/#/c/10319/) and didn't see a parquet-reader related failure. The builds I know that use ASAN set this option explicitly in their build script, but it seems better to set it closer to the build configuration. -- To view, visit http://gerrit.cloudera.org:8080/10404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b Gerrit-Change-Number: 10404 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Tue, 15 May 2018 03:41:39 + Gerrit-HasComments: No
[Impala-ASF-CR] Put ASAN options in CMakeLists.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10404 Change subject: Put ASAN options in CMakeLists. .. Put ASAN options in CMakeLists. When running tests with ASAN, you need to set ASAN_OPTIONS explicitly, to avoid various failures. In particular, backend tests fail complaining about memory leaks and tests that use the parquet-reader binary complain similarly. Shoving this into CMakeLists avoids needing to put this into wrapper scripts. Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b --- M be/CMakeLists.txt 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/10404/1 -- To view, visit http://gerrit.cloudera.org:8080/10404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b Gerrit-Change-Number: 10404 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I054a5e76df51b293f4728d30fd3b3cd7640624fb Gerrit-Change-Number: 10385 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 15 May 2018 03:37:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. IMPALA-7018: fix spill-to-disk encryption err handling The EVP_CIPHER_CTX_ctrl() function was being misused: 1. It was called before initialising the context 2. Errors were not being handled (including the error from #1) Testing: Added some checks to assert that the OpenSSL error queue is empty. Change-Id: I054a5e76df51b293f4728d30fd3b3cd7640624fb Reviewed-on: http://gerrit.cloudera.org:8080/10385 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/util/openssl-util-test.cc M be/src/util/openssl-util.cc 2 files changed, 23 insertions(+), 14 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I054a5e76df51b293f4728d30fd3b3cd7640624fb Gerrit-Change-Number: 10385 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10366 ) Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2470/ -- To view, visit http://gerrit.cloudera.org:8080/10366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2df6983a65a50b7efdd482124b70f518ee4c3229 Gerrit-Change-Number: 10366 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Tue, 15 May 2018 02:49:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. Patch Set 2: Is the invariant that the tree of Exprs supposed to have unique object identity? If that's true, could we amend some of the tests to assert that? It's tempting to even make this a runtime assertion, but I don't know if we have the equivalent of DCHECK configured on the Java side. -- To view, visit http://gerrit.cloudera.org:8080/10402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 Gerrit-Change-Number: 10402 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Tue, 15 May 2018 02:31:38 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10398 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2469/ -- To view, visit http://gerrit.cloudera.org:8080/10398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Gerrit-Change-Number: 10398 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 15 May 2018 02:20:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. IMPALA-7029: Clone LHS when rewriting a between predicate Currently when `lhs BETWEEN x AND y` is rewritten, lhs is not cloned but it obviously shoud be. Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 --- M fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/10402/2 -- To view, visit http://gerrit.cloudera.org:8080/10402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 Gerrit-Change-Number: 10402 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. Patch Set 1: (1 comment) > Patch Set 1: > > Do you have a test case that shows what can break? I don't know if it breaks anything in the current state. It breaks things when I was working on IMPALA-4025. http://gerrit.cloudera.org:8080/#/c/10402/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java: http://gerrit.cloudera.org:8080/#/c/10402/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@47 PS1, Line 47: bp.getChild(0).clone(), bp.getChild(1)); > even cleaner to clone all children Done -- To view, visit http://gerrit.cloudera.org:8080/10402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 Gerrit-Change-Number: 10402 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Tue, 15 May 2018 01:22:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. Patch Set 1: Do you have a test case that shows what can break? -- To view, visit http://gerrit.cloudera.org:8080/10402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 Gerrit-Change-Number: 10402 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Tue, 15 May 2018 01:16:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10402/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java: http://gerrit.cloudera.org:8080/#/c/10402/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@47 PS1, Line 47: bp.getChild(0).clone(), bp.getChild(1)); even cleaner to clone all children -- To view, visit http://gerrit.cloudera.org:8080/10402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 Gerrit-Change-Number: 10402 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Tue, 15 May 2018 01:16:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 11: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2472/ -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 11 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 15 May 2018 00:44:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 11 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Fredy Wijaya Gerrit-Comment-Date: Tue, 15 May 2018 00:31:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10401 ) Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dc68dcd395fcd0bd31563ea46229a12553482dc Gerrit-Change-Number: 10401 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 May 2018 00:21:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10401 ) Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor Described how to create a Kudu table with a replication factor that is not the default value of 3. Change-Id: I9dc68dcd395fcd0bd31563ea46229a12553482dc Reviewed-on: http://gerrit.cloudera.org:8080/10401 Reviewed-by: Thomas Tauber-Marshall Tested-by: Impala Public Jenkins --- M docs/topics/impala_create_table.xml M docs/topics/impala_kudu.xml 2 files changed, 32 insertions(+), 9 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9dc68dcd395fcd0bd31563ea46229a12553482dc Gerrit-Change-Number: 10401 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10402 Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. IMPALA-7029: Clone LHS when rewriting a between predicate Currently when `lhs BETWEEN x AND y` is rewritten, lhs is not cloned but it obviously shoud be. Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 --- M fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/10402/1 -- To view, visit http://gerrit.cloudera.org:8080/10402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 Gerrit-Change-Number: 10402 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2471/ -- To view, visit http://gerrit.cloudera.org:8080/10385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I054a5e76df51b293f4728d30fd3b3cd7640624fb Gerrit-Change-Number: 10385 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 15 May 2018 00:10:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I054a5e76df51b293f4728d30fd3b3cd7640624fb Gerrit-Change-Number: 10385 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 15 May 2018 00:10:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml File docs/topics/impala_tutorial.xml: http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@2268 PS1, Line 2268: | 1987 | 1311826 | 1 | 9.32MB | NOT CACHED | NOT CACHED | PARQUET | true This output is different. http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@2458 PS1, Line 2458: The rest of the queries are OK enough. -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Tue, 15 May 2018 00:09:04 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor
Alex Rodoni has abandoned this change. ( http://gerrit.cloudera.org:8080/10400 ) Change subject: IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor .. Abandoned Duplicate with the wrong Jira ID -- To view, visit http://gerrit.cloudera.org:8080/10400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I0ba52de5c9f19623e32a1962a9b51d3b4bab222b Gerrit-Change-Number: 10400 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10401 ) Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/290/ -- To view, visit http://gerrit.cloudera.org:8080/10401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dc68dcd395fcd0bd31563ea46229a12553482dc Gerrit-Change-Number: 10401 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 May 2018 00:02:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10401 ) Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dc68dcd395fcd0bd31563ea46229a12553482dc Gerrit-Change-Number: 10401 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 May 2018 00:01:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 ) Change subject: IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py@735 PS5, Line 735: if not first_exec_summary: > Add comment. Done http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/report_benchmark_results.py@1058 PS5, Line 1058: if exec_summaries[0] is None: > Same as comment above, please add a comment line explaining what this does. Done -- To view, visit http://gerrit.cloudera.org:8080/10100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c Gerrit-Change-Number: 10100 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Mon, 14 May 2018 23:59:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10401 Change subject: IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor .. IMPALA-3813: [DOCS] How to create a Kudu table with a replication factor Described how to create a Kudu table with a replication factor that is not the default value of 3. Change-Id: I9dc68dcd395fcd0bd31563ea46229a12553482dc --- M docs/topics/impala_create_table.xml M docs/topics/impala_kudu.xml 2 files changed, 32 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/10401/1 -- To view, visit http://gerrit.cloudera.org:8080/10401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9dc68dcd395fcd0bd31563ea46229a12553482dc Gerrit-Change-Number: 10401 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/10171/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10171/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3527 PS10, Line 3527: String originalComment = msDb.getDescription(); > I think this needs to go inside the synchronized block to correctly handle That makes sense. Done. -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 11 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Fredy Wijaya Gerrit-Comment-Date: Mon, 14 May 2018 23:54:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. IMPALA-6916: Implement COMMENT ON DATABASE This patch implements updating comment on a database. Syntax: COMMENT ON DATABASE db IS 'comment' Testing: - Added new front-end tests - Ran all front-end tests - Added new end-to-end tests - Ran end-to-end DDL tests Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 --- M common/thrift/CatalogService.thrift M common/thrift/JniCatalog.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java A fe/src/main/java/org/apache/impala/analysis/CommentOnDbStmt.java A fe/src/main/java/org/apache/impala/analysis/CommentOnStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M tests/metadata/test_ddl.py M tests/metadata/test_ddl_base.py 13 files changed, 233 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/10171/11 -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 11 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Fredy Wijaya
[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates
Nithya Janarthanan has posted comments on this change. (
http://gerrit.cloudera.org:8080/10100 )
Change subject: IMPALA-6923: Update scripts in benchmark folder to store
workload and few minor updates
..
Patch Set 8:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10100/8//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10100/8//COMMIT_MSG@7
PS8, Line 7: Update
> Please add a space in front of this.
Done
http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/perf_result_datastore.py
File tests/benchmark/perf_result_datastore.py:
http://gerrit.cloudera.org:8080/#/c/10100/5/tests/benchmark/perf_result_datastore.py@298
PS5, Line 298: LOG.debug('Inserting File Type: {0}, {1}, {2}'.format(
> Fix indentation
Done
http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py
File tests/benchmark/report_benchmark_results.py:
http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py@141
PS8, Line 141: Dont
> I think either "Don't" or "Do not" is better than Dont. This is used for us
Done
http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py@1058
PS8, Line 1058: if exec_summaries[0] is None:
: return ""
> I think this is a redundant special handling. I believe L1054-1055 can be
Done
--
To view, visit http://gerrit.cloudera.org:8080/10100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c
Gerrit-Change-Number: 10100
Gerrit-PatchSet: 8
Gerrit-Owner: Nithya Janarthanan
Gerrit-Reviewer: David Knupp
Gerrit-Reviewer: Jim Apple
Gerrit-Reviewer: Kim Jin Chul
Gerrit-Reviewer: Michael Brown
Gerrit-Reviewer: Mostafa Mokhtar
Gerrit-Reviewer: Nithya Janarthanan
Gerrit-Comment-Date: Mon, 14 May 2018 23:52:05 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10400 ) Change subject: IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10400/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10400/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-6827 IMPALA-3813 -- To view, visit http://gerrit.cloudera.org:8080/10400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ba52de5c9f19623e32a1962a9b51d3b4bab222b Gerrit-Change-Number: 10400 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Mon, 14 May 2018 23:48:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10400 ) Change subject: IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor .. Patch Set 1: Code-Review+1 Thanks for updating this, Alex! -- To view, visit http://gerrit.cloudera.org:8080/10400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ba52de5c9f19623e32a1962a9b51d3b4bab222b Gerrit-Change-Number: 10400 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Mon, 14 May 2018 23:41:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml File docs/topics/impala_tutorial.xml: http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1602 PS1, Line 1602: https://native-toolchain.s3.amazonaws.com/share/airlines_parquet.tar.gz > https://native-toolchain.s3.amazonaws.com/share/airlines_parquet.tar.gz Also uploaded https://native-toolchain.s3.amazonaws.com/share/airlines_parquet.tar.gz.sha512 . Can you add this and demonstrate verification? mikeb@local:0:~ $ wget -q https://native-toolchain.s3.amazonaws.com/share/airlines_parquet.tar.gz.sha512 mikeb@local:0:~ $ shasum -a 512 -c airlines_parquet.tar.gz.sha512 airlines_parquet.tar.gz: OK mikeb@local:0:~ $ http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1611 PS1, Line 1611: airlines_parquet/93459d994898a9ba-77674173b331fa9a_2073981944_data.0.parq File names are different now. 4345e5eef217aa1b-c8f16177f35fd983_1150363067_data.0.parq and friends. http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1622 PS1, Line 1622: $ du -kch *.parq The output below is now different. http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1655 PS1, Line 1655: -rw-r--r-- 3 jrussell supergroup 265107489 2015-08-12 17:18 /user/impala/staging/airlines/93459d994898a9ba-77674173b331fa96_2118228804_data.0.parq This output will be different. http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1689 PS1, Line 1689: WARNINGS: Impala does not have READ_WRITE access to path 'hdfs://demo_host.example.com:8020/user/impala/staging' When I ran a similar command, I didn't get this warning. http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1691 PS1, Line 1691: It's kind of a shame the tutorial does not urge the reader to run COMPUTE STATS on the new table. Our position is to strongly prefer tables with stats. http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1722 PS1, Line 1722: 93459d994898a9ba Output will be different here and elsewhere. http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1735 PS1, Line 1735: inferred from: optional int32 year I get a different output here. All the comments say "Inferred from Parquet file.". http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1851 PS1, Line 1851: [localhost:21000] > select ndv(carrier), ndv(flight_num), ndv(tail_num), : > ndv(origin), ndv(dest) from airlines_external; : +--+-+---+-+---+ : | ndv(carrier) | ndv(flight_num) | ndv(tail_num) | ndv(origin) | ndv(dest) | : +--+-+---+-+---+ : | 29 | 9086| 3 | 340 | 347 | : +--+-+---+-+---+ Awesome. I get slightly different numbers here! +--+-+---+-+---+ | ndv(carrier) | ndv(flight_num) | ndv(tail_num) | ndv(origin) | ndv(dest) | +--+-+---+-+---+ | 29 | 8463| 3 | 342 | 349 | +--+-+---+-+---+ http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@2191 PS1, Line 2191: > STORED AS PARQUET : > PARTITIONED BY (year INT); I had to reverse these two to make it work. The docs agree. https://impala.apache.org/docs/build/html/topics/impala_create_table.html -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 14 May 2018 23:39:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10400 Change subject: IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor .. IMPALA-6827: [DOCS] How to create a Kudu table with a replication factor Described how to create a Kudu table with a replication factor that is not the default value of 3. Change-Id: I0ba52de5c9f19623e32a1962a9b51d3b4bab222b --- M docs/topics/impala_create_table.xml M docs/topics/impala_kudu.xml 2 files changed, 32 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/10400/1 -- To view, visit http://gerrit.cloudera.org:8080/10400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0ba52de5c9f19623e32a1962a9b51d3b4bab222b Gerrit-Change-Number: 10400 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: > Safety is one thing, control is another. We don't have control over > that site, so we can't control their decision to move or take down > the data. We don't have control over the native-toolchain bucket, either. That's controlled by Cloudera, not by Apache Impala. I'd suggest speaking to ASF infra about hosting a large binary like this. They might have a turn-key solution. -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 14 May 2018 23:28:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I054a5e76df51b293f4728d30fd3b3cd7640624fb Gerrit-Change-Number: 10385 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 23:28:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 1: Ping? -- To view, visit http://gerrit.cloudera.org:8080/10364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92b87f370a68a2f695ebbc2520a98dd143730701 Gerrit-Change-Number: 10364 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Mon, 14 May 2018 23:27:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10366 ) Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2470/ -- To view, visit http://gerrit.cloudera.org:8080/10366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2df6983a65a50b7efdd482124b70f518ee4c3229 Gerrit-Change-Number: 10366 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 14 May 2018 23:25:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/10171/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10171/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3527 PS10, Line 3527: msDb.setDescription(comment); I think this needs to go inside the synchronized block to correctly handle several concurrent comment on -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 10 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Fredy Wijaya Gerrit-Comment-Date: Mon, 14 May 2018 23:20:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove IMPALA THRIFT JAVA VERSION and untested Darwin Thrift versions.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10361 ) Change subject: Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. .. Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. The singular use of IMPALA_THRIFT_JAVA_VERSION was in impala-parent/pom.xml. We can reduce complexity by just inlining the version there, like we do with several other Java dependencies. Meanwhile, with the upgrade to Thrift 0.9.3, it doesn't make sense to retain the Darwin path for Thrift 0.9.2. The reality is likely that nobody is building Impala on Darwin. Cherry-picks: not for 2.x Change-Id: I98f8c0b344afd001864653659c045b5d3c3e94ac Reviewed-on: http://gerrit.cloudera.org:8080/10361 Reviewed-by: Tianyi Wang Tested-by: Impala Public Jenkins --- M bin/impala-config.sh M impala-parent/pom.xml 2 files changed, 1 insertion(+), 7 deletions(-) Approvals: Tianyi Wang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I98f8c0b344afd001864653659c045b5d3c3e94ac Gerrit-Change-Number: 10361 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR] Remove IMPALA THRIFT JAVA VERSION and untested Darwin Thrift versions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10361 ) Change subject: Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98f8c0b344afd001864653659c045b5d3c3e94ac Gerrit-Change-Number: 10361 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Mon, 14 May 2018 23:09:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml File docs/topics/impala_tutorial.xml: http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1602 PS1, Line 1602: https://ibis-resources.s3.amazonaws.com/data/airlines/airlines_parquet.tar.gz > https://native-toolchain.s3.amazonaws.com/share/airlines_parquet.tar.gz Done -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 14 May 2018 22:59:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Hello Michael Brown, Harsh J, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10393 to look at the new patch set (#2). Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. IMPALA-6827: [DOCS] Updated the download link for the tutorial data Updated the link to download the Parquet airline files for tutorial. Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 --- M docs/topics/impala_tutorial.xml 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/10393/2 -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml File docs/topics/impala_tutorial.xml: http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1602 PS1, Line 1602: https://ibis-resources.s3.amazonaws.com/data/airlines/airlines_parquet.tar.gz > Who controls this bucket, and what prevents them from deleting this or chan https://native-toolchain.s3.amazonaws.com/share/airlines_parquet.tar.gz -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 14 May 2018 22:50:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. IMPALA-6916: Implement COMMENT ON DATABASE This patch implements updating comment on a database. Syntax: COMMENT ON DATABASE db IS 'comment' Testing: - Added new front-end tests - Ran all front-end tests - Added new end-to-end tests - Ran end-to-end DDL tests Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 --- M common/thrift/CatalogService.thrift M common/thrift/JniCatalog.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java A fe/src/main/java/org/apache/impala/analysis/CommentOnDbStmt.java A fe/src/main/java/org/apache/impala/analysis/CommentOnStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M tests/metadata/test_ddl.py M tests/metadata/test_ddl_base.py 13 files changed, 233 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/10171/10 -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 10 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Fredy Wijaya
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 ) Change subject: IMPALA-6916: Implement COMMENT ON DATABASE .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/10171/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10171/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3543 PS8, Line 3543: // holding the catalog version lock for an atomic operation. Most DB operations are > Thinking about this again, I don't think we need a DB-level lock. It should Done -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 10 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Fredy Wijaya Gerrit-Comment-Date: Mon, 14 May 2018 22:48:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests
Alex Behm has posted comments on this change. (
http://gerrit.cloudera.org:8080/10358 )
Change subject: IMPALA-6802 (part 3): Clean up authorization tests
..
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@96
PS2, Line 96: Set expectedAuthorizables = Sets.newHashSet(
Let's factor this out somewhere, it's repeated many times
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@718
PS2, Line 718: authorize("with t as (select id from functional.alltypes)
select * from t")
Tests are fine, but overall there's still a lot of redundancy. Basically any
"read" query that produces the same privilege requests will have these same
checks. We should think about how we can coalesce them.
We don't need to do that in this patch, but we should not forget.
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@736
PS2, Line 736: authorize("with t as (select id, int_col, 2019 from
functional.alltypesagg) " +
Same here, this is basically the same as INSERT (without WITH)
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@772
PS2, Line 772: authorize("select id from functional.alltypes union all " +
Same as SELECT with a join... also redundancy here
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@842
PS2, Line 842: for (AuthzTest test : new AuthzTest[]{
This is an interesting pattern for handling the redundancy I mentioned above
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@859
PS2, Line 859: for (AuthzTest test : new AuthzTest[]{
redundancy with L842
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@880
PS2, Line 880: .error(refreshError("functional"),
onDatabase("functional", allExcept(
also error with onServer()
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@917
PS2, Line 917: // Show partitions.
Many of these require db or table level show metadata privs. Also add negative
tests that only SELECT on a column is not sufficient.
http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@1053
PS2, Line 1053: return new TPrivilegeLevel[]{TPrivilegeLevel.INSERT,
TPrivilegeLevel.INSERT,
INSERT listed twice, is SELECT missing?
--
To view, visit http://gerrit.cloudera.org:8080/10358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9681cc3c7094db33ab7c5caa69b99dd803b908b7
Gerrit-Change-Number: 10358
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Adam Holley
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Comment-Date: Mon, 14 May 2018 22:43:14 +
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10398 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2469/ -- To view, visit http://gerrit.cloudera.org:8080/10398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Gerrit-Change-Number: 10398 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 May 2018 22:35:16 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10398 to review the following change. Change subject: IMPALA-6957: calc thread resource requirement in planner .. IMPALA-6957: calc thread resource requirement in planner This only factors in fragment execution threads. E.g. this does *not* try to account for the number of threads on the old Thrift RPC code path if that is enabled. This is loosely related to the old VCores estimate, but is different in that it: * Directly ties into the notion of required threads in ThreadResourceMgr. * Is a strict upper bound on the number of such threads, rather than an estimate. Does not include "optional" threads. ThreadResourceMgr in the backend bounds the number of "optional" threads per impalad, so the number of execution threads on a backend is limited by sum(required threads per query) + CpuInfo::num_cores() * FLAGS_num_threads_per_core DCHECKS in the backend enforce that the calculation is correct. They were actually hit in KuduScanNode because of some races in thread management leading to multiple "required" threads running. Now the first thread in the multithreaded scans never exits, which means that it's always safe for any of the other threads to exit early, which simplifies the logic a lot. Testing: Updated planner tests. Ran core tests. Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Reviewed-on: http://gerrit.cloudera.org:8080/10256 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/exec/hdfs-scan-node.cc M be/src/exec/hdfs-scan-node.h M be/src/exec/kudu-scan-node.cc M be/src/exec/kudu-scan-node.h M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/query-state.cc M be/src/runtime/runtime-state.cc M be/src/runtime/thread-resource-mgr.cc M be/src/runtime/thread-resource-mgr.h M be/src/scheduling/admission-controller.cc M be/src/scheduling/query-schedule.h M be/src/scheduling/scheduler.cc M common/thrift/Frontend.thrift M common/thrift/ImpalaInternalService.thrift M common/thrift/Planner.thrift M fe/src/main/java/org/apache/impala/planner/AggregationNode.java M fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java M fe/src/main/java/org/apache/impala/planner/HashJoinNode.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/main/java/org/apache/impala/planner/PlanFragment.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/main/java/org/apache/impala/planner/ResourceProfile.java M fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java M fe/src/main/java/org/apache/impala/planner/SortNode.java M testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test M testdata/workloads/functional-planner/queries/PlannerTest/disable-codegen.test M testdata/workloads/functional-planner/queries/PlannerTest/fk-pk-join-detection.test M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test M testdata/workloads/functional-planner/queries/PlannerTest/max-row-size.test M testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test M testdata/workloads/functional-planner/queries/PlannerTest/partition-pruning.test M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test M testdata/workloads/functional-planner/queries/PlannerTest/sort-expr-materialization.test M testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test M testdata/workloads/functional-planner/queries/PlannerTest/tablesample.test M testdata/workloads/functional-planner/queries/PlannerTest/union.test M testdata/workloads/functional-query/queries/QueryTest/explain-level0.test M testdata/workloads/functional-query/queries/QueryTest/explain-level1.test M testdata/workloads/functional-query/queries/QueryTest/explain-level2.test M testdata/workloads/functional-query/queries/QueryTest/explain-level3.test 43 files changed, 1,973 insertions(+), 1,927 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/10398/1 -- To view, visit http://gerrit.cloudera.org:8080/10398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newchange Gerrit-Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Gerrit-Change-Number: 10398 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10396 to look at the new patch set (#2). Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. IMPALA-3134: Support different proc mem limits among impalads for admission control checks Currently the admission controller assumes that all backends have the same process mem limit as the impalad it itself is running on. With this patch the proc mem limit for each impalad is available to the admission controller and it uses it for making correct admisssion decisions. Testing: Added an e2e test. Change-Id: Idb72eee790cc17466bbfa82e30f369a65f2b060e --- M be/src/scheduling/admission-controller.cc M be/src/scheduling/query-schedule.h M be/src/scheduling/scheduler.cc M be/src/scheduling/scheduler.h M be/src/service/impala-server.cc M bin/start-impala-cluster.py M common/thrift/StatestoreService.thrift M tests/custom_cluster/test_admission_controller.py 8 files changed, 95 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/10396/2 -- To view, visit http://gerrit.cloudera.org:8080/10396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb72eee790cc17466bbfa82e30f369a65f2b060e Gerrit-Change-Number: 10396 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: > I just checked and Cwiki won't work. The file attachment limit is > 20MB. We might as well see if we can use the toolchain bucket. I don't remember the upload mechanics off the top of my head, so give me some time to give you a new URL. -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 14 May 2018 22:25:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10396 Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. IMPALA-3134: Support different proc mem limits among impalads for admission control checks Currently the admission controller assumes that all backends have the same process mem limit as the impalad it itself is running on. With this patch the proc mem limit for each impalad is available to the admission controller and it uses it for making correct admisssion decisions. Testing: Added an e2e test. Change-Id: Idb72eee790cc17466bbfa82e30f369a65f2b060e --- M be/src/scheduling/admission-controller.cc M be/src/scheduling/query-schedule.h M be/src/scheduling/scheduler.cc M be/src/scheduling/scheduler.h M be/src/service/impala-server.cc M bin/start-impala-cluster.py M common/thrift/StatestoreService.thrift M tests/custom_cluster/test_admission_controller.py 8 files changed, 95 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/10396/1 -- To view, visit http://gerrit.cloudera.org:8080/10396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idb72eee790cc17466bbfa82e30f369a65f2b060e Gerrit-Change-Number: 10396 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
[Impala-ASF-CR] IMPALA-7017: deflake/fix test catalog restart test
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10397 Change subject: IMPALA-7017: deflake/fix test_catalog_restart test .. IMPALA-7017: deflake/fix test_catalog_restart test The custom_cluster/test_metadata_replicas.py:test_catalog_restart test has been recently flaky/broken for two reasons: 1) Variable support for Hive and non-hdfs filesystems. Other tests that depend on Hive have disabled tests for non-hdfs filesystems. Since the functionality tested is not intended for all filesystems, this change disables this test for all filesystems other than hdfs. 2) Several builds have been flaky when looking up catalogd's version. This change adds a retry for obtaining the version. Change-Id: Iab6edb01f0bd7f5408cfef28fd05fdc95fb78469 --- M tests/common/impala_service.py M tests/custom_cluster/test_metadata_replicas.py 2 files changed, 22 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/10397/1 -- To view, visit http://gerrit.cloudera.org:8080/10397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iab6edb01f0bd7f5408cfef28fd05fdc95fb78469 Gerrit-Change-Number: 10397 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: > Ibis looked like a legit site. Safety is one thing, control is another. We don't have control over that site, so we can't control their decision to move or take down the data. > If using cwiki, do you have any suggestion where to upload the file > to? I just checked and Cwiki won't work. The file attachment limit is 20MB. -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 14 May 2018 22:22:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10392 ) Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock For consistency with the other locks in this class, use SpinLock rather than boost::mutex. We expect SpinLock to work okay for locks that block since it is adaptive. This came up in the code review for IMPALA-5384, but I wanted to make this change separately, just in case of unforseen side-effects. Change-Id: I48b2e7f819b1180f82811abf5701c8d07e6505e3 Reviewed-on: http://gerrit.cloudera.org:8080/10392 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I48b2e7f819b1180f82811abf5701c8d07e6505e3 Gerrit-Change-Number: 10392 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10392 ) Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48b2e7f819b1180f82811abf5701c8d07e6505e3 Gerrit-Change-Number: 10392 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 22:17:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6957: calc thread resource requirement in planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10256 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 9: This change did not cherrypick successfully into branch 2.x. To resolve this, please do the cherry-pick manually and submit it to Gerrit at refs/for/2.x or add an exception to the branch 2.x copy of bin/ignored_commits.json. Thanks, your friendly bot at https://jenkins.impala.io/job/cherrypick-2.x-and-test/491/ . -- To view, visit http://gerrit.cloudera.org:8080/10256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982837ef883457fa4d2adc3bdbdc727353469140 Gerrit-Change-Number: 10256 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 22:10:18 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10389 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. IMPALA-5384, part 2: Simplify Coordinator locking and clarify state The is the final change to clarify and break up the Coordinator's lock. The state machine for the coordinator is made explicit, distinguishing between executing state and multiple terminal states. Logic to transition into a terminal state is centralized in one location and executes exactly once for each coordinator object. Derived from a patch for IMPALA_5384 by Marcel Kornacker. Testing: - exhaustive functional tests - stress test on minicluster with memory overcommitment. Verified from the logs that this exercises all these paths: - successful queries - client requested cancellation - error from exec FInstances RPC - error reported asynchronously via report status RPC - eos before backend execution completed Change-Id: I1abdfd02163f9356c59d470fe1c64ebe012a9e8e Reviewed-on: http://gerrit.cloudera.org:8080/10158 Reviewed-by: Dan Hecht Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/10389 --- M be/src/runtime/coordinator-backend-state.h M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/service/client-request-state.cc M be/src/service/impala-server.h M be/src/util/counting-barrier.h 6 files changed, 393 insertions(+), 392 deletions(-) Approvals: Dan Hecht: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: I1abdfd02163f9356c59d470fe1c64ebe012a9e8e Gerrit-Change-Number: 10389 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR](2.x) IMPALA-5384, part 2: Simplify Coordinator locking and clarify state
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10389 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I1abdfd02163f9356c59d470fe1c64ebe012a9e8e Gerrit-Change-Number: 10389 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 May 2018 22:00:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: > (1 comment) Ibis looked like a legit site. If using cwiki, do you have any suggestion where to upload the file to? -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 14 May 2018 21:57:32 + Gerrit-HasComments: No
[Impala-ASF-CR] Add a missing PrintId()
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Add a missing PrintId() For consistency, add a PrintId() around a query_id() used in a stream, which was missing from this commit: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state This change was put into the cherry-pick for 2.x, so: Cherry-picks: not for 2.x Change-Id: I701115fb7bc88cd034ddb7f0b99cf067ef2a7078 Reviewed-on: http://gerrit.cloudera.org:8080/10391 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/runtime/coordinator.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I701115fb7bc88cd034ddb7f0b99cf067ef2a7078 Gerrit-Change-Number: 10391 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Add a missing PrintId()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I701115fb7bc88cd034ddb7f0b99cf067ef2a7078 Gerrit-Change-Number: 10391 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 21:54:38 + Gerrit-HasComments: No
[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b Gerrit-Change-Number: 10312 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 May 2018 21:52:56 + Gerrit-HasComments: No
[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b Reviewed-on: http://gerrit.cloudera.org:8080/10312 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins --- M docs/topics/impala_create_view.xml 1 file changed, 69 insertions(+), 49 deletions(-) Approvals: Alex Behm: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b Gerrit-Change-Number: 10312 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml File docs/topics/impala_tutorial.xml: http://gerrit.cloudera.org:8080/#/c/10393/1/docs/topics/impala_tutorial.xml@1602 PS1, Line 1602: https://ibis-resources.s3.amazonaws.com/data/airlines/airlines_parquet.tar.gz Who controls this bucket, and what prevents them from deleting this or changing its contents? A while ago, we suggested trying cwiki as a place to store this. Was that suggestion ever pursued? -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Harsh J Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 14 May 2018 21:48:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/289/ -- To view, visit http://gerrit.cloudera.org:8080/10312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b Gerrit-Change-Number: 10312 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 May 2018 21:43:14 + Gerrit-HasComments: No
[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b Gerrit-Change-Number: 10312 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 May 2018 21:37:32 + Gerrit-HasComments: No
[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10312/2/docs/topics/impala_create_view.xml File docs/topics/impala_create_view.xml: http://gerrit.cloudera.org:8080/#/c/10312/2/docs/topics/impala_create_view.xml@162 PS2, Line 162: CREATE VIEW v7 (c1 COMMENT 'Comment for c1', c2) COMMENT 'Comment for t1' AS SELECT t1.c1, t1.c2 FROM t1; > Comment for v7 Done -- To view, visit http://gerrit.cloudera.org:8080/10312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b Gerrit-Change-Number: 10312 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 May 2018 21:36:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW
Hello Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10312 to look at the new patch set (#3). Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b --- M docs/topics/impala_create_view.xml 1 file changed, 69 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/10312/3 -- To view, visit http://gerrit.cloudera.org:8080/10312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b Gerrit-Change-Number: 10312 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10366 ) Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2df6983a65a50b7efdd482124b70f518ee4c3229 Gerrit-Change-Number: 10366 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 14 May 2018 21:32:24 + Gerrit-HasComments: No
[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10312/2/docs/topics/impala_create_view.xml File docs/topics/impala_create_view.xml: http://gerrit.cloudera.org:8080/#/c/10312/2/docs/topics/impala_create_view.xml@162 PS2, Line 162: CREATE VIEW v7 (c1 COMMENT 'Comment for c1', c2) COMMENT 'Comment for t1' AS SELECT t1.c1, t1.c2 FROM t1; Comment for v7 -- To view, visit http://gerrit.cloudera.org:8080/10312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b Gerrit-Change-Number: 10312 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 May 2018 21:29:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 ) Change subject: IMPALA-6035: Add query options to limit thread reservation .. Patch Set 4: Rebased -- To view, visit http://gerrit.cloudera.org:8080/10365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b5bbbdad5cd6b24442eb6c99a4d38c2ad710007 Gerrit-Change-Number: 10365 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 21:14:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6916: Implement COMMENT ON DATABASE
Alex Behm has posted comments on this change. (
http://gerrit.cloudera.org:8080/10171 )
Change subject: IMPALA-6916: Implement COMMENT ON DATABASE
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10171/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/10171/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3543
PS8, Line 3543: if (!catalog_.tryLockDb(db)) {
Thinking about this again, I don't think we need a DB-level lock. It should be
sufficient to hold the versionLock_ to make incrementing the global version and
setting it on the Db object atomic. That's the purpose of the versionLock_.
Since in this specific case all operations on a Db are of very short duration,
it's ok to not add a finer-grained Db lock.
--
To view, visit http://gerrit.cloudera.org:8080/10171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00
Gerrit-Change-Number: 10171
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Adam Holley
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Dimitris Tsirogiannis
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Comment-Date: Mon, 14 May 2018 21:11:46 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10365 to look at the new patch set (#4). Change subject: IMPALA-6035: Add query options to limit thread reservation .. IMPALA-6035: Add query options to limit thread reservation Adds two options: THREAD_RESERVATION_LIMIT and THREAD_RESERVATION_AGGREGATE_LIMIT, which are both enforced by admission control based on planner resource requirements and the schedule. The mechanism used is the same as the minimum reservation checks. THREAD_RESERVATION_LIMIT limits the total number of reserved threads in fragments scheduled on a single backend. THREAD_RESERVATION_AGGREGATE_LIMIT limits the sum of reserved threads across all fragments. This also slightly improves the minimum reservation error message to include the host name. Testing: Added end-to-end tests that exercise the code paths. Ran core tests. Change-Id: I5b5bbbdad5cd6b24442eb6c99a4d38c2ad710007 --- M be/src/scheduling/admission-controller.cc M be/src/scheduling/query-schedule.h M be/src/scheduling/scheduler.cc M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift M testdata/workloads/functional-query/queries/QueryTest/admission-reject-min-reservation.test A testdata/workloads/functional-query/queries/QueryTest/resource-limits.test M testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test A tests/query_test/test_resource_limits.py 12 files changed, 243 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/10365/4 -- To view, visit http://gerrit.cloudera.org:8080/10365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b5bbbdad5cd6b24442eb6c99a4d38c2ad710007 Gerrit-Change-Number: 10365 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10394 Change subject: PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode .. PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode This patch refactors PartitionedAggregationNode in preparation for supporting multiple distinct operators in a query. The primary goal of the refactor is to separate out the core aggregation functionality into a new type of objects called an Aggregator. For now, each aggregation ExecNode will contain a single Aggregator. Then, future patches will extend the aggregation ExecNode to support taking a single input and processing it with multiple Aggregators, allowing us to support more exotic combinations of aggregate functions and groupings. Specifically, this patch splits PartitionedAggregationNode into five new classes: - Aggregator: a superclass containing the functionality that's shared between GroupingAggregator and NonGroupingAggregator. - GroupingAggregator: this class contains the bulk of the interesting aggregation code, including everything related to creating and updating partitions and hash tables, spilling, etc. - NonGroupingAggregator: this class handles the case of aggregations that don't have grouping exprs. Since these aggregations always result in just a single output row, the functionality here is relatively simple (eg. no spilling or streaming). - StreamingAggregationNode: this node performs a streaming preaggregation, where the input is retrieved from the child during GetNext() and passed to the GroupingAggregator (non-grouping do not support streaming) Eventually, we'll support a list of GroupingAggretors. - AggregationNode: this node performs a final aggregation, where the input is retrieved from the child during Open() and passed to the Aggregator. Currently the Aggregator can be either grouping or non-grouping. Eventually we'll support a list of GroupingAggregator and/or a single NonGroupingAggregator. Testing: - Ran the existing aggregation tests. Change-Id: I9e7bb583f54aa4add3738bde7f57cf3511ac567e --- M be/src/codegen/gen_ir_descriptions.py M be/src/codegen/impala-ir.cc M be/src/exec/CMakeLists.txt A be/src/exec/aggregation-node.cc A be/src/exec/aggregation-node.h A be/src/exec/aggregator.cc A be/src/exec/aggregator.h M be/src/exec/exec-node.cc M be/src/exec/exec-node.h R be/src/exec/grouping-aggregator-ir.cc A be/src/exec/grouping-aggregator-partition.cc A be/src/exec/grouping-aggregator.cc R be/src/exec/grouping-aggregator.h A be/src/exec/non-grouping-aggregator-ir.cc A be/src/exec/non-grouping-aggregator.cc A be/src/exec/non-grouping-aggregator.h D be/src/exec/partitioned-aggregation-node.cc A be/src/exec/streaming-aggregation-node.cc A be/src/exec/streaming-aggregation-node.h 19 files changed, 3,037 insertions(+), 2,199 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/10394/1 -- To view, visit http://gerrit.cloudera.org:8080/10394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9e7bb583f54aa4add3738bde7f57cf3511ac567e Gerrit-Change-Number: 10394 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata
Alex Behm has posted comments on this change. (
http://gerrit.cloudera.org:8080/10116 )
Change subject: IMPALA-6131: Track time of last statistics update in metadata
..
Patch Set 10:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/10116/10/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:
http://gerrit.cloudera.org:8080/#/c/10116/10/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@244
PS10, Line 244: Long.toString(System.currentTimeMillis() / 1000));
> It sets it if the property does not exist, but this would not work well for
Makes sense, please add a comment somewhere stating why we prefer to set the
lastDdlTime in Impala.
http://gerrit.cloudera.org:8080/#/c/10116/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/10116/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@785
PS10, Line 785: msTbl.putToParameters("impala.lastComputeStatsTime",
> I have put the constant to HdfsTable, because all the other property keys r
The Kudu properties are generaly in KuduTable. Which property in HdfsTable also
applies to Kudu tables?
This new last compute stats time property should be in Table.
http://gerrit.cloudera.org:8080/#/c/10116/10/tests/metadata/test_last_ddl_time_update.py
File tests/metadata/test_last_ddl_time_update.py:
http://gerrit.cloudera.org:8080/#/c/10116/10/tests/metadata/test_last_ddl_time_update.py@74
PS10, Line 74: def run_test(self, query, expect_changed_ddl_time,
expect_changed_stats_time):
> The "invalidate metadata %(TBL)s; describe %(TBL)s" combo was used the chec
The vast majority of cases only runs one query at once, and there is no
fundamental reason to provide a multi-query test interface - all testing can be
done just as well without it. The multi-query behavior is subtly different than
running the single-query interface multiple times, so I think overall it's
simpler to think about a single-query interface.
http://gerrit.cloudera.org:8080/#/c/10116/10/tests/metadata/test_last_ddl_time_update.py@93
PS10, Line 93: # Hive uses a seconds granularity on the last ddl time.
> Isn't it an HMS convention in this case? Or is there a reason behind not us
I agree it's an HMS convention. Let's change the comment to state that then.
http://gerrit.cloudera.org:8080/#/c/10116/10/tests/metadata/test_last_ddl_time_update.py@155
PS10, Line 155: h.expect_no_time_change("drop incremental stats %(TBL)s
partition (j=1, s='2012')")
> Are you sure about this? I use DROP INCREMENTAL STATS on purpose to check +
ok wfm
--
To view, visit http://gerrit.cloudera.org:8080/10116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59a671ac29d352bd92ce40d5cb6662bb23f146b5
Gerrit-Change-Number: 10116
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Mon, 14 May 2018 20:58:13 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add a missing PrintId()
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Patch Set 2: > Do we have a way to catch these automatically? > > I started looking at clang-query but I gave up after 5 minutes... Yeah, I had also looked to see if we had something we could add a rule to but also gave up. If we have something and someone can point me in the right direction, I'm happy to look. -- To view, visit http://gerrit.cloudera.org:8080/10391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I701115fb7bc88cd034ddb7f0b99cf067ef2a7078 Gerrit-Change-Number: 10391 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 20:47:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4464: Remove /bin/remote data load.py
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10388 ) Change subject: IMPALA-4464: Remove /bin/remote_data_load.py .. IMPALA-4464: Remove /bin/remote_data_load.py This file was started before the ASF project was set up, and committed as-is. However, it relies on some internal resources not generally available to the external Apache community at large, and so serves no purpose in that context. Change-Id: I002efae6ad538d371680ce23099277708ed67e0e Reviewed-on: http://gerrit.cloudera.org:8080/10388 Reviewed-by: Philip Zeyliger Tested-by: David Knupp --- D bin/remote_data_load.py 1 file changed, 0 insertions(+), 560 deletions(-) Approvals: Philip Zeyliger: Looks good to me, approved David Knupp: Verified -- To view, visit http://gerrit.cloudera.org:8080/10388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I002efae6ad538d371680ce23099277708ed67e0e Gerrit-Change-Number: 10388 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-4464: Remove /bin/remote data load.py
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10388 ) Change subject: IMPALA-4464: Remove /bin/remote_data_load.py .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I002efae6ad538d371680ce23099277708ed67e0e Gerrit-Change-Number: 10388 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 14 May 2018 20:34:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10393 Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. IMPALA-6827: [DOCS] Updated the download link for the tutorial data Updated the link to download the Parquet airline files for tutorial. Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 --- M docs/topics/impala_tutorial.xml 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/10393/1 -- To view, visit http://gerrit.cloudera.org:8080/10393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6823d1688169e0a6f09d5b552026bc18a3770828 Gerrit-Change-Number: 10393 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-4464: Remove /bin/remote data load.py
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10388 ) Change subject: IMPALA-4464: Remove /bin/remote_data_load.py .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I002efae6ad538d371680ce23099277708ed67e0e Gerrit-Change-Number: 10388 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 14 May 2018 20:25:13 + Gerrit-HasComments: No
[Impala-ASF-CR] Add a missing PrintId()
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Patch Set 2: Do we have a way to catch these automatically? I started looking at clang-query but I gave up after 5 minutes... -- To view, visit http://gerrit.cloudera.org:8080/10391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I701115fb7bc88cd034ddb7f0b99cf067ef2a7078 Gerrit-Change-Number: 10391 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 20:20:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2468/ -- To view, visit http://gerrit.cloudera.org:8080/10381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8299a8a97ad1f2bd1f2927e3111db8df1d3a3e5 Gerrit-Change-Number: 10381 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Brown Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Mon, 14 May 2018 20:10:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 2: Code-Review+2 IMPALA-7026 -- To view, visit http://gerrit.cloudera.org:8080/10381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8299a8a97ad1f2bd1f2927e3111db8df1d3a3e5 Gerrit-Change-Number: 10381 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Brown Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Mon, 14 May 2018 20:09:34 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove IMPALA THRIFT JAVA VERSION and untested Darwin Thrift versions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10361 ) Change subject: Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2467/ -- To view, visit http://gerrit.cloudera.org:8080/10361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98f8c0b344afd001864653659c045b5d3c3e94ac Gerrit-Change-Number: 10361 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Mon, 14 May 2018 19:49:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 17: (5 comments) Only a few minor comments, otherwise looks good to me. http://gerrit.cloudera.org:8080/#/c/9693/15/be/src/util/string-util-test.cc File be/src/util/string-util-test.cc: http://gerrit.cloudera.org:8080/#/c/9693/15/be/src/util/string-util-test.cc@68 PS15, Line 68: EvalTruncation(normal_plus_max, "abcdeg", 10, UP); > I had a similar test, when I used the '127' literal. Thx. I don't feel strongly about using decimal vs hex literals. What I was aiming for was the last byte being uchar_max, and the one before being schar_max. LGTM now. http://gerrit.cloudera.org:8080/#/c/9693/17/tests/query_test/test_parquet_page_index.py File tests/query_test/test_parquet_page_index.py: http://gerrit.cloudera.org:8080/#/c/9693/17/tests/query_test/test_parquet_page_index.py@71 PS17, Line 71: column_index = read_serialized_object(ColumnIndex, parquet_file, It might make things faster / more elegant to pass an open file here, otherwise you're opening the same file 3 times for each column. Feel free to ignore though as this is not performance critical code. http://gerrit.cloudera.org:8080/#/c/9693/17/tests/query_test/test_parquet_page_index.py@126 PS17, Line 126: page_is_null is False Why not "not page_is_null"? http://gerrit.cloudera.org:8080/#/c/9693/17/tests/query_test/test_parquet_page_index.py@179 PS17, Line 179: reverse "reverse" seems to rely on everyone thinking of ascending as the default. Maybe rename parameter to "ascending" or "descending"? Or even pass BoundaryOrder, and implement UNORDERED as return not is_sorted(, ASCENDING) and not is_sorted(l, DESCENDING) ? http://gerrit.cloudera.org:8080/#/c/9693/17/tests/util/get_parquet_metadata.py File tests/util/get_parquet_metadata.py: http://gerrit.cloudera.org:8080/#/c/9693/17/tests/util/get_parquet_metadata.py@163 PS17, Line 163: metadata = FileMetaData() If you follow the suggestion in the other file to pass an open file to read_serialized_object, you could use it here, too. -- To view, visit http://gerrit.cloudera.org:8080/9693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbacf7fe3b7672e3ce719261ecef445b16f8dec9 Gerrit-Change-Number: 9693 Gerrit-PatchSet: 17 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Anonymous Coward #248 Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 14 May 2018 19:44:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove IMPALA THRIFT JAVA VERSION and untested Darwin Thrift versions.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10361 ) Change subject: Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98f8c0b344afd001864653659c045b5d3c3e94ac Gerrit-Change-Number: 10361 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Mon, 14 May 2018 19:44:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 1: > Patch Set 1: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2457/ I saw this build failure. Can you rebase the CR and run the Jenkins build again? -- To view, visit http://gerrit.cloudera.org:8080/10381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8299a8a97ad1f2bd1f2927e3111db8df1d3a3e5 Gerrit-Change-Number: 10381 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Brown Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Comment-Date: Mon, 14 May 2018 19:13:34 + Gerrit-HasComments: No
[Impala-ASF-CR] test-with-docker: work with git worktree
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10335 ) Change subject: test-with-docker: work with git worktree .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10335/1/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/10335/1/docker/test-with-docker.py@417 PS1, Line 417: self.git_common_dir = os.path.realpath( : _check_output(["git", "rev-parse", "--git-common-dir"]).strip()) > When I run this on one of my normal checkouts, it does this: Ah, good find. It first showed up in the documentation at https://git-scm.com/docs/git-rev-parse/2.5.1 or so, and first showed up in git in 2.5.0, based on finding the commit and looking for tags that contain it. I added code here that handles both cases. I can imagine someone running RH7/CentOS 7 with an old git but with Docker. -- To view, visit http://gerrit.cloudera.org:8080/10335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9186e0b6f068aacc25f8d691508165c04329fa8b Gerrit-Change-Number: 10335 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 14 May 2018 19:12:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] test-with-docker: work with git worktree
Hello Joe McDonnell, Kim Jin Chul, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10335 to look at the new patch set (#2). Change subject: test-with-docker: work with git worktree .. test-with-docker: work with git worktree This commit adds a little of git-wrangling to allow test-with-docker to work when invoked from git directories managed by "git worktree". These are different in that they reference another git directory elsewhere on the file system, which also needs to be mounted into the container. Change-Id: I9186e0b6f068aacc25f8d691508165c04329fa8b --- M docker/entrypoint.sh M docker/test-with-docker.py 2 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/10335/2 -- To view, visit http://gerrit.cloudera.org:8080/10335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9186e0b6f068aacc25f8d691508165c04329fa8b Gerrit-Change-Number: 10335 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10312 ) Change subject: impala-6233: [DOCS] Documented the COMMENT clause for CREATE VIEW .. Patch Set 2: Hi Alex, Could you please review this change? Or recommend someone to review it? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/10312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I176d525925c8dc5c5b83612da43b349049764d2b Gerrit-Change-Number: 10312 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 May 2018 18:58:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7000: [DOCS] Correct info about dedicated executors
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10357 ) Change subject: IMPALA-7000: [DOCS] Correct info about dedicated executors .. Patch Set 1: Hi Juan, Could you tell me if I can do +2 and resolve the ticket? Thank you! -- To view, visit http://gerrit.cloudera.org:8080/10357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b7e6c57188a41a45d5813882b6dbc37cf47cf1f Gerrit-Change-Number: 10357 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Juan Yu Gerrit-Comment-Date: Mon, 14 May 2018 18:55:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10392 ) Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2466/ -- To view, visit http://gerrit.cloudera.org:8080/10392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48b2e7f819b1180f82811abf5701c8d07e6505e3 Gerrit-Change-Number: 10392 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 18:55:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10392 ) Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48b2e7f819b1180f82811abf5701c8d07e6505e3 Gerrit-Change-Number: 10392 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 18:52:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7024: Convert Coordinator::wait lock to SpinLock
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10392 Change subject: IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock .. IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock For consistency with the other locks in this class, use SpinLock rather than boost::mutex. We expect SpinLock to work okay for locks that block since it is adaptive. This came up in the code review for IMPALA-5384, but I wanted to make this change separately, just in case of unforseen side-effects. Change-Id: I48b2e7f819b1180f82811abf5701c8d07e6505e3 --- M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/10392/1 -- To view, visit http://gerrit.cloudera.org:8080/10392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I48b2e7f819b1180f82811abf5701c8d07e6505e3 Gerrit-Change-Number: 10392 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht
[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I054a5e76df51b293f4728d30fd3b3cd7640624fb Gerrit-Change-Number: 10385 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 18:44:52 + Gerrit-HasComments: No
[Impala-ASF-CR] Add a missing PrintId()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 ) Change subject: Add a missing PrintId() .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2465/ -- To view, visit http://gerrit.cloudera.org:8080/10391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I701115fb7bc88cd034ddb7f0b99cf067ef2a7078 Gerrit-Change-Number: 10391 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 14 May 2018 18:32:21 + Gerrit-HasComments: No
