[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 2: Code-Review+1 LGTM! -- To view, visit http://gerrit.cloudera.org:8080/18838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836 Gerrit-Change-Number: 18838 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 29 Aug 2022 08:29:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Hello Daniel Becker, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18910 to look at the new patch set (#3). Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries .. IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries This patch renames the Exec libraries to distinguish them from external libraries like avro, kudu_client and orc Due to IMPALA-11257, the cmake_minimum_required calls are also removed from the new libraries Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0 --- M be/CMakeLists.txt M be/src/codegen/CMakeLists.txt M be/src/exec/avro/CMakeLists.txt M be/src/exec/hbase/CMakeLists.txt M be/src/exec/kudu/CMakeLists.txt M be/src/exec/orc/CMakeLists.txt M be/src/exec/parquet/CMakeLists.txt M be/src/exec/rcfile/CMakeLists.txt M be/src/exec/sequence/CMakeLists.txt M be/src/exec/text/CMakeLists.txt 10 files changed, 40 insertions(+), 54 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/18910/3 -- To view, visit http://gerrit.cloudera.org:8080/18910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0 Gerrit-Change-Number: 18910 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 ) Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries .. Patch Set 3: > Thanks for putting this together! One other small thing: > Since some IR files moved to a different library, I think we also > should update be/src/codegen/CMakeLists.txt. > > This location refers to Exec, but I think it now needs to refer to > ExecAvro and ExecKudu as well: > https://github.com/apache/impala/blob/master/be/src/codegen/CMakeLists.txt#L88 > https://github.com/apache/impala/blob/master/be/src/codegen/CMakeLists.txt#L98 Done -- To view, visit http://gerrit.cloudera.org:8080/18910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0 Gerrit-Change-Number: 18910 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 29 Aug 2022 09:50:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 ) Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11237/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0 Gerrit-Change-Number: 18910 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 29 Aug 2022 10:10:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18909 to look at the new patch set (#3). Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. IMPALA-11529: FILE__POSITION virtual column for ORC tables IMPALA-11350 implemented the FILE__POSITION virtual column for Parquet files. This ticket does the same but for ORC files. Note, that for full ACID ORC tables there have already been an implementation of row__id that could simply be re-used for this ticket. Testing: - TestScannersVirtualColumns.test_virtual_column_file_position_generic is changed to run now on ORC as well. I don't think further testing is required as this functionality has already been there for row__id we just re-used it for FILE__POSITION. Change-Id: Ie8e951f73ceb910d64cd149192853a4a2131f79b --- M be/src/exec/hdfs-scanner.cc M be/src/exec/orc/hdfs-orc-scanner.cc M be/src/exec/orc/hdfs-orc-scanner.h M be/src/exec/orc/orc-column-readers.cc M be/src/exec/orc/orc-column-readers.h M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-generic.test M tests/query_test/test_scanners.py 7 files changed, 33 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/18909/3 -- To view, visit http://gerrit.cloudera.org:8080/18909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie8e951f73ceb910d64cd149192853a4a2131f79b Gerrit-Change-Number: 18909 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18909/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18909/2//COMMIT_MSG@21 PS2, Line 21: > Remove TODO? Ooops, some leftover :) Done http://gerrit.cloudera.org:8080/#/c/18909/2/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18909/2/be/src/exec/orc/hdfs-orc-scanner.cc@606 PS2, Line 606: file_position_ = slot > nit: maybe we should rename this variable to 'file_position_' Done http://gerrit.cloudera.org:8080/#/c/18909/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/18909/2/tests/query_test/test_scanners.py@161 PS2, Line 161: especially ORC > Would be nice if we could add some tests here as well. Agree, but the underlying .test file uses tables that only exist in Parquet. I figured I'd save the hassle of creating them to ORC as well. I did some manual experimenting based on the tests in mixing-virtual-columns.test to verify that I get the same results between functional_parquet and functional_orc_def. -- To view, visit http://gerrit.cloudera.org:8080/18909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8e951f73ceb910d64cd149192853a4a2131f79b Gerrit-Change-Number: 18909 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 29 Aug 2022 12:36:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11238/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8e951f73ceb910d64cd149192853a4a2131f79b Gerrit-Change-Number: 18909 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 29 Aug 2022 12:54:35 + Gerrit-HasComments: No
[Impala-ASF-CR] Test change to test precommit logic
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18925 Change subject: Test change to test precommit logic .. Test change to test precommit logic Change-Id: I9d50760482961d4804f053e5bcde3e17eaec2f7f --- M README-build.md 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/18925/1 -- To view, visit http://gerrit.cloudera.org:8080/18925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9d50760482961d4804f053e5bcde3e17eaec2f7f Gerrit-Change-Number: 18925 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal
[Impala-ASF-CR] Test change to test precommit logic
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18925 ) Change subject: Test change to test precommit logic .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11239/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d50760482961d4804f053e5bcde3e17eaec2f7f Gerrit-Change-Number: 18925 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Aug 2022 13:53:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11540: Add logs for ALTER TABLE events that trigger slow metadata reload
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18926 Change subject: IMPALA-11540: Add logs for ALTER_TABLE events that trigger slow metadata reload .. IMPALA-11540: Add logs for ALTER_TABLE events that trigger slow metadata reload ALTER_TABLE event could trigger full refresh on the table, which is time consuming and can lead to event-processor lagging behind. We need logs to show the difference between the before and after hmsTables so we can further distinguish the cases that actully don't need a full table refresh, e.g. changing the owner, changing tblproperties, etc. Change-Id: Ibf344e6b423f88c9635ca8d61d53385b88ba4dce --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/18926/1 -- To view, visit http://gerrit.cloudera.org:8080/18926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf344e6b423f88c9635ca8d61d53385b88ba4dce Gerrit-Change-Number: 18926 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
[Impala-ASF-CR] IMPALA-11540: Add logs for ALTER TABLE events that trigger slow metadata reload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18926 ) Change subject: IMPALA-11540: Add logs for ALTER_TABLE events that trigger slow metadata reload .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11240/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf344e6b423f88c9635ca8d61d53385b88ba4dce Gerrit-Change-Number: 18926 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yu-Wen Lai Gerrit-Comment-Date: Mon, 29 Aug 2022 14:32:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18909/3/be/src/exec/orc/hdfs-orc-scanner.h File be/src/exec/orc/hdfs-orc-scanner.h: http://gerrit.cloudera.org:8080/#/c/18909/3/be/src/exec/orc/hdfs-orc-scanner.h@274 PS3, Line 274: original files The term 'original files' is only used in the context of full ACID tables. Now this member is more general as it can serve the synthetic rowid column in original files in full ACID tables, and it can also serve the virtual column FILE__POSITION. -- To view, visit http://gerrit.cloudera.org:8080/18909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8e951f73ceb910d64cd149192853a4a2131f79b Gerrit-Change-Number: 18909 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 29 Aug 2022 15:38:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18898 to look at the new patch set (#4). Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. IMPALA-11496: Push down date literals to Kudu scanner This change enables creating, and pushing down Kudu predicates from DATE type. Kudu planner testcases added for DATE, BIGINT, FLOAT, DOUBLE types to cover all supported type's predicate creation. Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e --- M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test 2 files changed, 77 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/18898/4 -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 ) Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18898/3/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: http://gerrit.cloudera.org:8080/#/c/18898/3/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@583 PS3, Line 583: > You could add a preconditions check here: Done -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 29 Aug 2022 16:02:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 ) Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11241/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 29 Aug 2022 16:21:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10791 Add batch reading for remote temporary files
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/17979 ) Change subject: IMPALA-10791 Add batch reading for remote temporary files .. Patch Set 18: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dcc5d0881ffaeff09c5c514306cd668373ad31b Gerrit-Change-Number: 17979 Gerrit-PatchSet: 18 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 29 Aug 2022 17:16:48 + Gerrit-HasComments: No
[Impala-ASF-CR](branch-4.1.1) IMPALA-11457 Fix regression with unknown disk id
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18914 ) Change subject: IMPALA-11457 Fix regression with unknown disk id .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-4.1.1 Gerrit-MessageType: comment Gerrit-Change-Id: I571ac0669ceb6a42561594c3f96723d5ed293902 Gerrit-Change-Number: 18914 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 29 Aug 2022 17:30:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 ) Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 29 Aug 2022 17:43:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 ) Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 29 Aug 2022 17:44:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 ) Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8505/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 29 Aug 2022 17:44:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 ) Change subject: IMPALA-10213: Add test for local vs remote scheduling .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18841/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/18841/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1384 PS4, Line 1384: // Skip Ozone; it returns NULL storageIds and users can't do anything about it. Created a ticket to revert this once Ozone returns useful storage IDs: https://issues.apache.org/jira/browse/IMPALA-11541 -- To view, visit http://gerrit.cloudera.org:8080/18841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d Gerrit-Change-Number: 18841 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 18:46:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR](branch-4.1.1) IMPALA-11281: Load table metadata for ResetMetadataStmt
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18917 ) Change subject: IMPALA-11281: Load table metadata for ResetMetadataStmt .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-4.1.1 Gerrit-MessageType: comment Gerrit-Change-Id: I0c90b413974223886661697f11844d99a68fdebf Gerrit-Change-Number: 18917 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 29 Aug 2022 18:55:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 2: Code-Review+2 (1 comment) Doc is very clear now, thanks. LGTM conditional on one more spelling fix, please carry the +2 forward http://gerrit.cloudera.org:8080/#/c/18838/2/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/18838/2/docs/topics/impala_iceberg.xml@535 PS2, Line 535: allows automatic metadata file removal after operations that modify metada such as Spelling: "modify metadata" -- To view, visit http://gerrit.cloudera.org:8080/18838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836 Gerrit-Change-Number: 18838 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 29 Aug 2022 18:56:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10214: Ozone remote file handle caching
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214: Ozone remote file handle caching .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18853/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18853/5//COMMIT_MSG@10 PS5, Line 10: Updates : file handle cache enablement to be more stringent about enabling : caching, similar to what's suggested in IMPALA-10375. Nit: I think this addresses IMPALA-10375, so we can modify the language here to say that this resolves IMPALA-10375. I assume we'll close IMPALA-10375 when this goes in. You can include IMPALA-10375 as another JIRA in the title if you want. http://gerrit.cloudera.org:8080/#/c/18853/5/tests/custom_cluster/test_hdfs_fd_caching.py File tests/custom_cluster/test_hdfs_fd_caching.py: http://gerrit.cloudera.org:8080/#/c/18853/5/tests/custom_cluster/test_hdfs_fd_caching.py@182 PS5, Line 182: --max_cached_file_handles=0 If max_cached_file_handles=0, caching can't happen (is_file_handle_caching_enabled() is false) and none of the other flags matter. One option for a test would be to keep max_cached_file_handles non-zero, but then specify all the cache_X_file_handles=false. That would verify that those flags function. -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 19:42:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11467: Force Boost to use /dev/random for UUID generation
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18805 ) Change subject: IMPALA-11467: Force Boost to use /dev/random for UUID generation .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48bd59b0a846bcb91a6faf77156c0a49cd08ae8 Gerrit-Change-Number: 18805 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 20:09:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18853/6/tests/custom_cluster/test_hdfs_fd_caching.py File tests/custom_cluster/test_hdfs_fd_caching.py: http://gerrit.cloudera.org:8080/#/c/18853/6/tests/custom_cluster/test_hdfs_fd_caching.py@191 PS6, Line 191: @ flake8: F811 redefinition of unused 'test_remote_caching_disabled_by_param' from line 180 -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 21:23:22 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18853 to look at the new patch set (#6). Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. IMPALA-10214, IMPALA-10375: Ozone remote file handle caching Enables support for caching remote file handles for Ozone. Local file handles were already cached unintentionally, similar to HDFS. Updates file handle cache enablement to be more stringent about enabling caching. File handle caching is enabled if a max_cached_file_handles is non-zero and any of the following are true - HDFS file is local - HDFS file is remote and cache_remote_file_handles is enabled - Ozone file is local or remote and cache_ozone_file_handles is enabled - S3 file is remote and cache_s3_file_handles is enabled - ABFS file is remote and cache_abfs_file_handles is enabled Enables testing Ozone in test_hdfs_fd_caching, and adds tests that remote caching can be disabled using individual flags. Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 --- M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/handle-cache.inline.h M be/src/runtime/io/scan-range.cc M tests/custom_cluster/test_hdfs_fd_caching.py 4 files changed, 71 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18853/6 -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18853/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18853/5//COMMIT_MSG@10 PS5, Line 10: Updates : file handle cache enablement to be more stringent about enabling : caching. > Nit: I think this addresses IMPALA-10375, so we can modify the language her Done http://gerrit.cloudera.org:8080/#/c/18853/5/tests/custom_cluster/test_hdfs_fd_caching.py File tests/custom_cluster/test_hdfs_fd_caching.py: http://gerrit.cloudera.org:8080/#/c/18853/5/tests/custom_cluster/test_hdfs_fd_caching.py@182 PS5, Line 182: --cache_remote_file_handles > If max_cached_file_handles=0, caching can't happen (is_file_handle_caching_ I don't remember why I included max_cached_file_handles here. Separate tests for each flag disabled with remote storage makes sense to me. -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 21:22:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18853 to look at the new patch set (#7). Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. IMPALA-10214, IMPALA-10375: Ozone remote file handle caching Enables support for caching remote file handles for Ozone. Local file handles were already cached unintentionally, similar to HDFS. Updates file handle cache enablement to be more stringent about enabling caching. File handle caching is enabled if a max_cached_file_handles is non-zero and any of the following are true - HDFS file is local - HDFS file is remote and cache_remote_file_handles is enabled - Ozone file is local or remote and cache_ozone_file_handles is enabled - S3 file is remote and cache_s3_file_handles is enabled - ABFS file is remote and cache_abfs_file_handles is enabled Enables testing Ozone in test_hdfs_fd_caching, and adds tests that remote caching can be disabled using individual flags. Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 --- M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/handle-cache.inline.h M be/src/runtime/io/scan-range.cc M tests/custom_cluster/test_hdfs_fd_caching.py 4 files changed, 71 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18853/7 -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11242/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 21:43:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8506/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 21:47:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11243/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 21:52:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11528: Catalogd should start up even with a corrupt Hive function.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 ) Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18927/1/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/18927/1/tests/custom_cluster/test_permanent_udfs.py@180 PS1, Line 180: = flake8: E225 missing whitespace around operator -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Aug 2022 22:12:38 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11528: Catalogd should start up even with a corrupt Hive function.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18927 Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. .. IMPALA-11528: Catalogd should start up even with a corrupt Hive function. This commit handles the case for a specific kind of corrupt function within the Hive Metastore in the following situation: A valid Hive SQL function gets created in HMS. This UDF is written in Java and must derive from the "UDF" class. After creating this function in Impala, we then replace the underlying jar file with a class that does NOT derive from the "UDF" class. In this scenario, catalogd should reject the function and still start up gracefully. Before this commit, catalogd wasn't coming up. The reason for this was because the Hive function FunctionUtils.getUDFClassType() has a dependency on UDAF and was throwing a LinkageError exception. To fix this, we need to include UDAF in the shaded jar. Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 --- M java/pom.xml M java/shaded-deps/hive-exec/pom.xml A java/test-corrupt-hive-udfs/pom.xml A java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java M tests/custom_cluster/test_permanent_udfs.py 5 files changed, 117 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/18927/1 -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 ) Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8505/ -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 29 Aug 2022 22:28:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11528: Catalogd should start up even with a corrupt Hive function.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 ) Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11244/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Aug 2022 22:34:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11528: Catalogd should start up even with a corrupt Hive function.
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18927 to look at the new patch set (#2). Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. .. IMPALA-11528: Catalogd should start up even with a corrupt Hive function. This commit handles the case for a specific kind of corrupt function within the Hive Metastore in the following situation: A valid Hive SQL function gets created in HMS. This UDF is written in Java and must derive from the "UDF" class. After creating this function in Impala, we then replace the underlying jar file with a class that does NOT derive from the "UDF" class. In this scenario, catalogd should reject the function and still start up gracefully. Before this commit, catalogd wasn't coming up. The reason for this was because the Hive function FunctionUtils.getUDFClassType() has a dependency on UDAF and was throwing a LinkageError exception. To fix this, we need to include UDAF in the shaded jar. Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 --- M java/pom.xml M java/shaded-deps/hive-exec/pom.xml A java/test-corrupt-hive-udfs/pom.xml A java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java M tests/custom_cluster/test_permanent_udfs.py 5 files changed, 117 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/18927/2 -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11528: Catalogd should start up even with a corrupt Hive function.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 ) Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8507/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Aug 2022 23:01:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18853/7/tests/custom_cluster/test_hdfs_fd_caching.py File tests/custom_cluster/test_hdfs_fd_caching.py: http://gerrit.cloudera.org:8080/#/c/18853/7/tests/custom_cluster/test_hdfs_fd_caching.py@124 PS7, Line 124: def get_external_ip(): Since I used this in two different patches, it probably makes sense to pull into its own package. -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 23:12:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11528: Catalogd should start up even with a corrupt Hive function.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 ) Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11245/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 29 Aug 2022 23:16:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18853/8/tests/common/network.py File tests/common/network.py: http://gerrit.cloudera.org:8080/#/c/18853/8/tests/common/network.py@24 PS8, Line 24: def get_external_ip(): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 23:17:38 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18841 to look at the new patch set (#5). Change subject: IMPALA-10213: Add test for local vs remote scheduling .. IMPALA-10213: Add test for local vs remote scheduling Impala already supports locality-aware scheduling with Ozone because it returns location data on partitions. That data doesn't include specific storage ids in getStorageIds, so we skip a warning that will always trigger on Ozone. Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for local development. HDFS translates localhost to 127.0.0.1 for host names in its location data, which Impala will identify as colocated with executors in the dev environment. Ozone doesn't, and the default Impala hostname is the machine hostname - not localhost - so without this change all HDFS access in the minicluster is local but all Ozone access is remote. Adds a test to verify local vs remote assignment by using custom clusters with hostnames that either do or don't match storage hostnames. Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d --- M be/src/runtime/io/disk-io-mgr.cc M be/src/scheduling/executor-group.cc M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java A tests/common/network.py M tests/common/skip.py A tests/custom_cluster/test_scheduler_locality.py M tests/metadata/test_stats_extrapolation.py 7 files changed, 93 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18841/5 -- To view, visit http://gerrit.cloudera.org:8080/18841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d Gerrit-Change-Number: 18841 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 ) Change subject: IMPALA-10213: Add test for local vs remote scheduling .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18841/5/tests/common/network.py File tests/common/network.py: http://gerrit.cloudera.org:8080/#/c/18841/5/tests/common/network.py@24 PS5, Line 24: def get_external_ip(): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/18841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d Gerrit-Change-Number: 18841 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 23:19:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18853 to look at the new patch set (#9). Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. IMPALA-10214, IMPALA-10375: Ozone remote file handle caching Enables support for caching remote file handles for Ozone. Local file handles were already cached unintentionally, similar to HDFS. Updates file handle cache enablement to be more stringent about enabling caching. File handle caching is enabled if a max_cached_file_handles is non-zero and any of the following are true - HDFS file is local - HDFS file is remote and cache_remote_file_handles is enabled - Ozone file is local or remote and cache_ozone_file_handles is enabled - S3 file is remote and cache_s3_file_handles is enabled - ABFS file is remote and cache_abfs_file_handles is enabled Enables testing Ozone in test_hdfs_fd_caching, and adds tests that remote caching can be disabled using individual flags. Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 --- M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/handle-cache.inline.h M be/src/runtime/io/scan-range.cc A tests/common/network.py M tests/custom_cluster/test_hdfs_fd_caching.py 5 files changed, 92 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18853/9 -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18841 to look at the new patch set (#6). Change subject: IMPALA-10213: Add test for local vs remote scheduling .. IMPALA-10213: Add test for local vs remote scheduling Impala already supports locality-aware scheduling with Ozone because it returns location data on partitions. That data doesn't include specific storage ids in getStorageIds, so we skip a warning that will always trigger on Ozone. Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for local development. HDFS translates localhost to 127.0.0.1 for host names in its location data, which Impala will identify as colocated with executors in the dev environment. Ozone doesn't, and the default Impala hostname is the machine hostname - not localhost - so without this change all HDFS access in the minicluster is local but all Ozone access is remote. Adds a test to verify local vs remote assignment by using custom clusters with hostnames that either do or don't match storage hostnames. Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d --- M be/src/runtime/io/disk-io-mgr.cc M be/src/scheduling/executor-group.cc M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java A tests/common/network.py M tests/common/skip.py A tests/custom_cluster/test_scheduler_locality.py M tests/metadata/test_stats_extrapolation.py 7 files changed, 94 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18841/6 -- To view, visit http://gerrit.cloudera.org:8080/18841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d Gerrit-Change-Number: 18841 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18853 to look at the new patch set (#8). Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. IMPALA-10214, IMPALA-10375: Ozone remote file handle caching Enables support for caching remote file handles for Ozone. Local file handles were already cached unintentionally, similar to HDFS. Updates file handle cache enablement to be more stringent about enabling caching. File handle caching is enabled if a max_cached_file_handles is non-zero and any of the following are true - HDFS file is local - HDFS file is remote and cache_remote_file_handles is enabled - Ozone file is local or remote and cache_ozone_file_handles is enabled - S3 file is remote and cache_s3_file_handles is enabled - ABFS file is remote and cache_abfs_file_handles is enabled Enables testing Ozone in test_hdfs_fd_caching, and adds tests that remote caching can be disabled using individual flags. Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 --- M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/handle-cache.inline.h M be/src/runtime/io/scan-range.cc A tests/common/network.py M tests/custom_cluster/test_hdfs_fd_caching.py 5 files changed, 91 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18853/8 -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11246/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 23:31:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 ) Change subject: IMPALA-10213: Add test for local vs remote scheduling .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11247/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d Gerrit-Change-Number: 18841 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 23:39:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11248/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 23:39:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 ) Change subject: IMPALA-10213: Add test for local vs remote scheduling .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11249/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d Gerrit-Change-Number: 18841 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 29 Aug 2022 23:41:05 + Gerrit-HasComments: No
[Impala-ASF-CR](branch-4.1.1) IMPALA-11457 Fix regression with unknown disk id
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18914 ) Change subject: IMPALA-11457 Fix regression with unknown disk id .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-4.1.1 Gerrit-MessageType: comment Gerrit-Change-Id: I571ac0669ceb6a42561594c3f96723d5ed293902 Gerrit-Change-Number: 18914 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Aug 2022 02:15:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 9: Code-Review+1 This makes sense to me. Assuming the tests pass and no other comments, I'll go to +2 tomorrow -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 30 Aug 2022 02:34:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10214, IMPALA-10375: Ozone remote file handle caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 ) Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 30 Aug 2022 02:39:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11528: Catalogd should start up even with a corrupt Hive function.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 ) Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8507/ -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 30 Aug 2022 03:51:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11528: Catalogd should start up even with a corrupt Hive function.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 ) Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. .. Patch Set 2: (2 comments) The build failure looks related: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17408/testReport/junit/custom_cluster.test_permanent_udfs/TestUdfPersistence/test_corrupt_java_bad_function/ http://gerrit.cloudera.org:8080/#/c/18927/2/java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java: http://gerrit.cloudera.org:8080/#/c/18927/2/java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java@25 PS2, Line 25: We import the class NumberParseException from : * Google's phone number library that won't be shaded with the UDF jar Where do we import it? CorruptUdf seems a valid udf to me at the first glance. http://gerrit.cloudera.org:8080/#/c/18927/2/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/18927/2/tests/custom_cluster/test_permanent_udfs.py@183 PS2, Line 183: funcction typo -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 30 Aug 2022 04:18:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 ) Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8508/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 30 Aug 2022 04:24:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Csaba Ringhofer has removed a vote on this change. Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 ) Change subject: IMPALA-11496: Push down date literals to Kudu scanner .. Patch Set 5: The failure looks unrelated, rerunning the tests 19:48:06 docker: Error response from daemon: Get https://registry-1.docker.io/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers). -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 30 Aug 2022 04:23:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables
Hello Quanlong Huang, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18729 to look at the new patch set (#12). Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables .. IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent. Testing: - e2e tests Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M testdata/datasets/functional/functional_schema_template.sql A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test M tests/custom_cluster/test_kudu.py M tests/query_test/test_kudu.py 6 files changed, 189 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/12 -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 12 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 ) Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables .. Patch Set 12: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8509/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 12 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Xiaoqing Gao Gerrit-Comment-Date: Tue, 30 Aug 2022 06:15:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 ) Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 12 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Xiaoqing Gao Gerrit-Comment-Date: Tue, 30 Aug 2022 06:23:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 ) Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables .. Patch Set 12: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11250/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 12 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Xiaoqing Gao Gerrit-Comment-Date: Tue, 30 Aug 2022 06:28:19 + Gerrit-HasComments: No
