[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@87 PS2, Line 87: DEFINE_string(jni_frontend_class, "org/apache/impala/service/JniFrontend", "By default " > They'd need to override this on any impalad and catalogd instances, right? Depending on what they modify, they might be able to skip catalogd. http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@89 PS2, Line 89: "This option allows the class to be overridden by a third party module."); Nit: Should we say something about the specified class being a subclass of JniFrontend? http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: external-frontend > Should we worry about this showing up in releases? Is there a test-only pro Since there is no dependency from fe or executor-deps (or anything else that fe depends on), it shouldn't be on our classpath or ship in our docker image. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Thu, 07 Sep 2023 05:30:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9680/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf Gerrit-Change-Number: 20427 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Thu, 07 Sep 2023 03:34:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20425/1/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/20425/1/tests/query_test/test_cast_with_format.py@2197 PS1, Line 2197: # Compare char to varchar > I didn't identify the specific JIRA or commit. Given that this change is in I tracked this down to http://gerrit.cloudera.org:8080/12481, between Impala 3.2 and 3.3. On first glance, I'd guess this is due to the change in best-fit logic for resolving function calls. I'll have to spend some time with that change to understand why it caused this. -- To view, visit http://gerrit.cloudera.org:8080/20425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib89d0a391bc8f2152ecd9151c8872a01ba19c436 Gerrit-Change-Number: 20425 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 07 Sep 2023 02:21:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12390 (part 2): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20445 ) Change subject: IMPALA-12390 (part 2): Enable some clang-tidy performance related checks .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Thu, 07 Sep 2023 01:41:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles
Fang-Yu Rao has posted comments on this change. (
http://gerrit.cloudera.org:8080/20439 )
Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are
no roles
..
Patch Set 3:
(4 comments)
Thanks for the patch and the new test cases Ji!
I only have some very minor comments.
http://gerrit.cloudera.org:8080/#/c/20439/3/fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java
File
fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java:
http://gerrit.cloudera.org:8080/#/c/20439/3/fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java@48
PS3, Line 48: showRolesParams.setRequesting_user("admin");
nit: It seems that the value of 'requesting_user' does not have to be "admin"
when 'isShowCurrentRole' is true.
In RangerImpaladAuthorizationManager#getRoles(), the operation would be
considered as non-administrative for the SHOW CURRENT ROLES command.
boolean adminOp =
!(groups.contains(params.getGrant_group()) ||
params.is_show_current_roles);
if (adminOp) {
RangerUtil.validateRangerAdmin(plugin_.get(),
params.getRequesting_user());
}
http://gerrit.cloudera.org:8080/#/c/20439/3/fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java@50
PS3, Line 50: }
nit: Add a newline after this right curly bracket.
http://gerrit.cloudera.org:8080/#/c/20439/3/fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java@64
PS3, Line 64: used
nit: thrown
http://gerrit.cloudera.org:8080/#/c/20439/3/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/20439/3/tests/authorization/test_ranger.py@2304
PS3, Line 2304: reset_ranger=True
Thanks! I think this addresses Quanlong's comment at
https://gerrit.cloudera.org/c/20439/2/tests/authorization/test_ranger.py#2321.
When 'reset_ranger' is True, we reset all the policies in the Ranger service
and thus even if there were roles before this test, they will be deleted when
this test runs.
It may be a good idea to add a code comment stating that since the Ranger
policies are reset before this test, we do not have to worry about there could
be existing roles when the test is running.
--
To view, visit http://gerrit.cloudera.org:8080/20439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id80fc2c9152a09194718da1b4266c5f804f0971f
Gerrit-Change-Number: 20439
Gerrit-PatchSet: 3
Gerrit-Owner: ji chen
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Wed, 06 Sep 2023 23:05:10 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12425: Upgrade json-smart to fix CVE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20461 ) Change subject: IMPALA-12425: Upgrade json-smart to fix CVE .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9678/ -- To view, visit http://gerrit.cloudera.org:8080/20461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0090da84e40cf79289ad13cce07127e64f08ad3 Gerrit-Change-Number: 20461 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 22:41:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: external-frontend Should we worry about this showing up in releases? Is there a test-only profile it should be restricted to? I don't see any examples of doing that so far, and we have test-hive-udfs, so :shrug: -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 22:22:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@87 PS2, Line 87: DEFINE_string(jni_frontend_class, "org/apache/impala/service/JniFrontend", "By default " They'd need to override this on any impalad and catalogd instances, right? -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 22:21:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: Code-Review+1 This seems safe enough to me, and doesn't place much maintenance burden on Impala. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 22:21:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 2): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20445 ) Change subject: IMPALA-12390 (part 2): Enable some clang-tidy performance related checks .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9679/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 21:31:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 21:31:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13936/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816 Gerrit-Change-Number: 20379 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 06 Sep 2023 19:20:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13935/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2c814bbad5c04c1d50c2edaa5b910c82a6fd87 Gerrit-Change-Number: 20372 Gerrit-PatchSet: 10 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 06 Sep 2023 19:08:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits
Hello Quanlong Huang, Qifan Chen, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20379 to look at the new patch set (#9). Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. IMPALA-12383: Fix SingleNodePlanner aggregation limits When IMPALA-2581 was implemented, it assumed all aggregation nodes would have a pre-aggregation step that limits could be pushed to and therefore removed limits on the final aggregation step. All distributed aggregations have an exchange, and in practice the exchange would enforce limits. When num_nodes=1, that is not the case. As a result, the following query would incorrectly return 16 rows, not 10: set num_nodes=1; select distinct l_orderkey from tpch.lineitem limit 10; This fix restores limits on the aggregation node; in a distributed plan using fast_limit_check, these should essentially be a no-op. Testing: - added a test case where we assert number of rows returned by an aggregation node (rather than an exchange or top-n). - restores definition of ALL_CLUSTER_SIZES and makes it simpler to enable for individual test suites. Filed IMPALA-12394 to generally re-enable testing with ALL_CLUSTER_SIZES. Enables ALL_CLUSTER_SIZES for aggregation tests. Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816 --- M be/src/exec/aggregation-node-base.cc M be/src/exec/grouping-aggregator.cc M be/src/exec/grouping-aggregator.h M tests/common/impala_test_suite.py M tests/common/test_dimensions.py M tests/query_test/test_aggregation.py 6 files changed, 31 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/20379/9 -- To view, visit http://gerrit.cloudera.org:8080/20379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816 Gerrit-Change-Number: 20379 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore
Wenzhe Zhou has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. IMPALA-12156: Support High Availability for Statestore To support statestore HA, we allow two statestored instances in an Active-Passive HA pair to be added to an Impala cluster. We add the preemptive behavior for statestored. When HA is enabled, the preemptive behavior allows the statestored with the higher priority to become active and the paired statestored becomes standby. The active statestored acts as the owner of Impala cluster and provides statestore service for the cluster members. To enable catalog HA for a cluster, two statestoreds in the HA pair and all subscribers must be started with starting flag "enable_statestored_ha" as true. This patch makes following changes: - Defined new service for Statestore HA. - Statestored negotiates the role for HA with its peer statestore instance on startup. - Create HA monitor thread: Active statestored sends heartbeat to standby statestored. Standby statestored monitors peer's connection states with their subscribers. - Standby statestored sends heartbeat to subscribers with request for connection state between active statestore and subscribers. Standby statestored saves the connection state as failure detecer. - When standby statestored lost connection with active statestore, it checks the connection states for active statestore, and takes over active role if majority of subscribers lost connections with active statestore. - New active statestored sends RPC notification to all subscribers for new active statestored and active catalogd elected by the new active staetstored. - New active statestored starts sending heartbeat to its peer when it receives handshake from its peer. - Active statestored enters recovery mode if it lost connections with its peer statestored and all subscribers. It keeps sending HA handshake to its peer until receiving response. - All subscribers (impalad/catalogd/admissiond) register to two statestoreds. - Subscribers report connection state for the requests from standby statestore. - Subscribers switch to new active statstore when receiving RPC notifications from new active statestored. - Only active statestored sends topic update messages to subscribers. - Add a new option "enable_statestored_ha" in script bin/start-impala-cluster.py for starting Impala mini-cluster with statestored HA enabled. - Add a new Thrift API in statestore service to disable network for statestored. It's only used for unit-test to simulate network failure. For safety, it's only working when the debug action is set in starting flags. Testings: - Added end-to-end unit tests for statestored HA. - Passed core tests Change-Id: Ibd2c814bbad5c04c1d50c2edaa5b910c82a6fd87 --- M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/catalog/catalog-server.cc M be/src/common/global-flags.cc M be/src/rpc/thrift-server-test.cc M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/scheduling/admissiond-env.cc M be/src/statestore/statestore-service-client-wrapper.h M be/src/statestore/statestore-subscriber-catalog.cc M be/src/statestore/statestore-subscriber-catalog.h M be/src/statestore/statestore-subscriber-client-wrapper.h M be/src/statestore/statestore-subscriber.cc M be/src/statestore/statestore-subscriber.h M be/src/statestore/statestore-test.cc M be/src/statestore/statestore.cc M be/src/statestore/statestore.h M be/src/statestore/statestored-main.cc M bin/start-impala-cluster.py M common/thrift/StatestoreService.thrift M common/thrift/metrics.json M tests/common/impala_cluster.py M tests/common/impala_service.py A tests/custom_cluster/test_statestored_ha.py 23 files changed, 2,495 insertions(+), 112 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/20372/10 -- To view, visit http://gerrit.cloudera.org:8080/20372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd2c814bbad5c04c1d50c2edaa5b910c82a6fd87 Gerrit-Change-Number: 20372 Gerrit-PatchSet: 10 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-12420: Bump Kudu version to 1.17.0 release
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20452 ) Change subject: IMPALA-12420: Bump Kudu version to 1.17.0 release .. IMPALA-12420: Bump Kudu version to 1.17.0 release We currently depend on a snapshot version of Kudu between 1.16.0 and 1.17.0. This patch bumps the dependent Kudu version to 1.17.0. Modified the expected error message when inserting to Auto-Incrementing column (changed in KUDU-1945). Tests: - Verified kudu insert tests locally Change-Id: I01ec8928adfbeb0788356b49f1341088dc132e19 Reviewed-on: http://gerrit.cloudera.org:8080/20452 Reviewed-by: Wenzhe Zhou Reviewed-by: Michael Smith Tested-by: Michael Smith --- M bin/impala-config.sh M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I01ec8928adfbeb0788356b49f1341088dc132e19 Gerrit-Change-Number: 20452 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-12420: Bump Kudu version to 1.17.0 release
Michael Smith has removed a vote on this change. Change subject: IMPALA-12420: Bump Kudu version to 1.17.0 release .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/20452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I01ec8928adfbeb0788356b49f1341088dc132e19 Gerrit-Change-Number: 20452 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-12420: Bump Kudu version to 1.17.0 release
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20452 ) Change subject: IMPALA-12420: Bump Kudu version to 1.17.0 release .. Patch Set 3: Verified+1 > Patch Set 3: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9676/ Failures due to IMPALA-12266. Test case had passed in prior run, and new patch only changed an unrelated test file. -- To view, visit http://gerrit.cloudera.org:8080/20452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01ec8928adfbeb0788356b49f1341088dc132e19 Gerrit-Change-Number: 20452 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 06 Sep 2023 18:13:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12425: Upgrade json-smart to fix CVE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20461 ) Change subject: IMPALA-12425: Upgrade json-smart to fix CVE .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9678/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0090da84e40cf79289ad13cce07127e64f08ad3 Gerrit-Change-Number: 20461 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 18:08:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12420: Bump Kudu version to 1.17.0 release
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20452 ) Change subject: IMPALA-12420: Bump Kudu version to 1.17.0 release .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9676/ -- To view, visit http://gerrit.cloudera.org:8080/20452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01ec8928adfbeb0788356b49f1341088dc132e19 Gerrit-Change-Number: 20452 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 06 Sep 2023 18:08:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/20379/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/20379/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@786 PS4, Line 786: > The original version of this method deals with only logical properties. The Joe asked why https://github.com/apache/impala/blob/master/be/src/exec/grouping-aggregator.cc#L156 is set in the first place. That prevents the aggregation node from enforcing a limit, which seems to be the problem here. Removing UnsetLimit would fix this issue, and doesn't seem like it should cause problems since we want the result of the aggregation to be limited. -- To view, visit http://gerrit.cloudera.org:8080/20379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816 Gerrit-Change-Number: 20379 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 06 Sep 2023 17:43:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9677/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 17:10:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. Patch Set 6: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9675/ -- To view, visit http://gerrit.cloudera.org:8080/20427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf Gerrit-Change-Number: 20427 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Wed, 06 Sep 2023 17:10:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12425: Upgrade json-smart to fix CVE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20461 ) Change subject: IMPALA-12425: Upgrade json-smart to fix CVE .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13934/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0090da84e40cf79289ad13cce07127e64f08ad3 Gerrit-Change-Number: 20461 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 17:03:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12425: Upgrade json-smart to fix CVE
Hello Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20461 to look at the new patch set (#2). Change subject: IMPALA-12425: Upgrade json-smart to fix CVE .. IMPALA-12425: Upgrade json-smart to fix CVE Change-Id: Id0090da84e40cf79289ad13cce07127e64f08ad3 --- M bin/impala-config.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/20461/2 -- To view, visit http://gerrit.cloudera.org:8080/20461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id0090da84e40cf79289ad13cce07127e64f08ad3 Gerrit-Change-Number: 20461 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-12425: Upgrade json-smart to fix CVE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20461 ) Change subject: IMPALA-12425: Upgrade json-smart to fix CVE .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13933/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0090da84e40cf79289ad13cce07127e64f08ad3 Gerrit-Change-Number: 20461 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 16:34:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 ) Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3 Gerrit-Change-Number: 20420 Gerrit-PatchSet: 8 Gerrit-Owner: Sai Hemanth Gantasala Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Wed, 06 Sep 2023 16:25:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 2): Enable some clang-tidy performance related checks
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20445 ) Change subject: IMPALA-12390 (part 2): Enable some clang-tidy performance related checks .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20445/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20445/4//COMMIT_MSG@10 PS4, Line 10: performance-inefficient-string-concatenation This looks like it requires a change to .clang-tidy. Presumably it should wait until after https://gerrit.cloudera.org/c/20387/ is merged. -- To view, visit http://gerrit.cloudera.org:8080/20445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 16:24:26 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@15 PS2, Line 15: Fix: Use char rather literals than string literals > "char rather" -> "character"? "Use character literals rather than string literals" http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@23 PS2, Line 23:you can either change the type to the correct one" nit: incomplete sentence fragment, did you leave off the rest of the warning? -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 16:23:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13932/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2c814bbad5c04c1d50c2edaa5b910c82a6fd87 Gerrit-Change-Number: 20372 Gerrit-PatchSet: 9 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 06 Sep 2023 16:26:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@15 PS2, Line 15: Fix: Use char rather literals than string literals "char rather" -> "character"? -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 16:12:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12420: Bump Kudu version to 1.17.0 release
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20452 ) Change subject: IMPALA-12420: Bump Kudu version to 1.17.0 release .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01ec8928adfbeb0788356b49f1341088dc132e19 Gerrit-Change-Number: 20452 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 06 Sep 2023 16:09:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 2): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20445 ) Change subject: IMPALA-12390 (part 2): Enable some clang-tidy performance related checks .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13931/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 16:12:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12425: Upgrade json-smart to fix CVE
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20461 Change subject: IMPALA-12425: Upgrade json-smart to fix CVE .. IMPALA-12425: Upgrade json-smart to fix CVE Change-Id: Id0090da84e40cf79289ad13cce07127e64f08ad3 --- M bin/impala-config.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/20461/1 -- To view, visit http://gerrit.cloudera.org:8080/20461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id0090da84e40cf79289ad13cce07127e64f08ad3 Gerrit-Change-Number: 20461 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith
[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore
Wenzhe Zhou has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. IMPALA-12156: Support High Availability for Statestore To support statestore HA, we allow two statestored instances in an Active-Passive HA pair to be added to an Impala cluster. We add the preemptive behavior for statestored. When HA is enabled, the preemptive behavior allows the statestored with the higher priority to become active and the paired statestored becomes standby. The active statestored acts as the owner of Impala cluster and provides statestore service for the cluster members. To enable catalog HA for a cluster, two statestoreds in the HA pair and all subscribers must be started with starting flag "enable_statestored_ha" as true. This patch makes following changes: - Defined new service for Statestore HA. - Statestored negotiates the role for HA with its peer statestore instance on startup. - Create HA monitor thread: Active statestored sends heartbeat to standby statestored. Standby statestored monitors peer's connection states with their subscribers. - Standby statestored sends heartbeat to subscribers with request for connection state between active statestore and subscribers. Standby statestored saves the connection state as failure detecer. - When standby statestored lost connection with active statestore, it checks the connection states for active statestore, and takes over active role if majority of subscribers lost connections with active statestore. - New active statestored sends RPC notification to all subscribers for new active statestored and active catalogd elected by the new active staetstored. - New active statestored starts sending heartbeat to its peer when it receives handshake from its peer. - Active statestored enters recovery mode if it lost connections with its peer statestored and all subscribers. It keeps sending HA handshake to its peer until receiving response. - All subscribers (impalad/catalogd/admissiond) register to two statestoreds. - Subscribers report connection state for the requests from standby statestore. - Subscribers switch to new active statstore when receiving RPC notifications from new active statestored. - Only active statestored sends topic update messages to subscribers. - Add a new option "enable_statestored_ha" in script bin/start-impala-cluster.py for starting Impala mini-cluster with statestored HA enabled. - Add a new Thrift API in statestore service to disable network for statestored. It's only used for unit-test to simulate network failure. For safety, it's only working when the debug action is set in starting flags. Testings: - Added end-to-end unit tests. - Passed core tests Change-Id: Ibd2c814bbad5c04c1d50c2edaa5b910c82a6fd87 --- M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/catalog/catalog-server.cc M be/src/common/global-flags.cc M be/src/rpc/thrift-server-test.cc M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/scheduling/admissiond-env.cc M be/src/statestore/statestore-service-client-wrapper.h M be/src/statestore/statestore-subscriber-catalog.cc M be/src/statestore/statestore-subscriber-catalog.h M be/src/statestore/statestore-subscriber-client-wrapper.h M be/src/statestore/statestore-subscriber.cc M be/src/statestore/statestore-subscriber.h M be/src/statestore/statestore-test.cc M be/src/statestore/statestore.cc M be/src/statestore/statestore.h M be/src/statestore/statestored-main.cc M bin/start-impala-cluster.py M common/thrift/StatestoreService.thrift M common/thrift/metrics.json M tests/common/impala_cluster.py M tests/common/impala_service.py A tests/custom_cluster/test_statestored_ha.py 23 files changed, 2,488 insertions(+), 112 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/20372/9 -- To view, visit http://gerrit.cloudera.org:8080/20372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd2c814bbad5c04c1d50c2edaa5b910c82a6fd87 Gerrit-Change-Number: 20372 Gerrit-PatchSet: 9 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-12390 (part 2): Enable some clang-tidy performance related checks
gsi...@cloudera.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20445 ) Change subject: IMPALA-12390 (part 2): Enable some clang-tidy performance related checks .. IMPALA-12390 (part 2): Enable some clang-tidy performance related checks This enables the clang tidy performance check: performance-inefficient-string-concatenation "warning: string concatenation results in allocation of unnecessary temporary strings" Fix: Use StrCat() to concatenate multiple strings Testing: - Ran bin/run_clang_tidy.sh with the new checks - Ran GVO Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 --- M be/src/exprs/expr-test.cc M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/timestamp-test.cc M be/src/scheduling/cluster-membership-test-util.cc M be/src/util/runtime-profile.cc 5 files changed, 88 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/20445/4 -- To view, visit http://gerrit.cloudera.org:8080/20445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13930/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 14:56:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20459 to look at the new patch set (#2). Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424: Allow third party JniFrontend interface. This patch allows a third party to inject their own frontend class instead of using the default JniFrontend included in the project. The test case includes an interface that runs queries as normal except for the "select 1" query which gets changed to "select 42". Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 --- M be/src/service/frontend.cc M bin/start-impala-cluster.py A java/external-frontend/pom.xml A java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java M java/pom.xml A tests/custom_cluster/test_external_planner.py 6 files changed, 191 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20459/2 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20460 ) Change subject: IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13929/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I988dc8d7e1074932c460b3702d3381341e5b23c5 Gerrit-Change-Number: 20460 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 14:32:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 06 Sep 2023 14:24:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13928/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 14:09:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20460 to look at the new patch set (#2). Change subject: IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes .. IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes Currently IcebergDeleteNode's cardinality is the same as the LHS's cardinality, i.e. we don't take the RHS into account. The RHS contains the position delete records, so it is a fair assumption that all records at RHS remove a record from RHS (duplicated delete records should be extremely rare). If there are conjuncts on the Iceberg table we can assume that they have the same selectivity on the data records and on the delete records. With the above assumptions this change updates the cardinality of the IcebergDeleteNode with basically the following formula: Card(IcebergDeleteNode) = Card(LHS) - Selectivity(LHS) * Card(RHS); To deal with edge cases when there are lots of duplicated delete records (shouldn't happen in normal usage), we actually use a slightly more complex formula: Card(IcebergDeleteNode) = Max( Min(1, Card(LHS))), Card(LHS) - Selectivity(LHS) * Card(RHS) ); Testing: * updated the planner tests Change-Id: I988dc8d7e1074932c460b3702d3381341e5b23c5 --- M fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-delete.test M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test 3 files changed, 94 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/20460/2 -- To view, visit http://gerrit.cloudera.org:8080/20460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I988dc8d7e1074932c460b3702d3381341e5b23c5 Gerrit-Change-Number: 20460 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20460 Change subject: IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes .. IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes Currently IcebergDeleteNode's cardinality is the same as the LHS's cardinality, i.e. we don't take the RHS into account. The RHS contains the position delete records, so it is a fair assumption that all records at RHS remove a record from RHS (duplicated delete records should be extremely rare). If there are conjuncts on the Iceberg table we can assume that they have the same selectivity on the data records and on the delete records. With the above assumptions this change updates the cardinality of the IcebergDeleteNode with the basically the following formula: Card(IcebergDeleteNode) = Card(LHS) - Selectivity(LHS) * Card(RHS); To deal with edge cases when there are lots of duplicated delete records, we actually use a slightly more complex formula: Card(IcebergDeleteNode) = Max( Min(1, Card(LHS))), Card(LHS) - Selectivity(LHS) * Card(RHS) ); Testing: * updated the planner tests Change-Id: I988dc8d7e1074932c460b3702d3381341e5b23c5 --- M fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-delete.test M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test 3 files changed, 94 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/20460/1 -- To view, visit http://gerrit.cloudera.org:8080/20460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I988dc8d7e1074932c460b3702d3381341e5b23c5 Gerrit-Change-Number: 20460 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13927/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 13:57:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20459 Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424: Allow third party JniFrontend interface. This patch allows a third party to inject their own frontend class instead of using the default JniFrontend included in the project. The test case includes an interface that runs queries as normal except for the "select 1" query which gets changed to "select 42". Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 --- M be/src/service/frontend.cc M bin/start-impala-cluster.py A java/external-frontend/pom.xml A java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java M java/pom.xml A tests/custom_cluster/test_external_planner.py 6 files changed, 192 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20459/1 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin
[Impala-ASF-CR] IMPALA-12420: Bump Kudu version to 1.17.0 release
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20452 ) Change subject: IMPALA-12420: Bump Kudu version to 1.17.0 release .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9676/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01ec8928adfbeb0788356b49f1341088dc132e19 Gerrit-Change-Number: 20452 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 06 Sep 2023 13:53:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/20459 )
Change subject: IMPALA-12424: Allow third party JniFrontend interface.
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/20459/1/be/src/service/frontend.cc
File be/src/service/frontend.cc:
http://gerrit.cloudera.org:8080/#/c/20459/1/be/src/service/frontend.cc@88
PS1, Line 88: "the JniFrontend class included in the repository is used as
the frontend interface. This "
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py
File tests/custom_cluster/test_external_planner.py:
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@21
PS1, Line 21: import shutil
flake8: F401 'shutil' imported but unused
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@42
PS1, Line 42:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@42
PS1, Line 42: assert setup_client.execute("select 2").data == ['2']
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@44
PS1, Line 44:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@44
PS1, Line 44: assert setup_client.execute("select 1").data == ['42']
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/20459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5
Gerrit-Change-Number: 20459
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Wed, 06 Sep 2023 13:51:46 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13926/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 13:51:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Surya Hebbar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. IMPALA-12417: Fix query timeline issue during asynchronous codegen When ASYNC_CODEGEN = 1, async code generation is enabled, this switches the compiled function pointers during runtime. Hence, enabling codegen to run on a parallel thread. In this case, a new event sequence is added to each fragment's profile. These additional events exhaust the default phase's colors available and disturb the corelation between them. AsyncCodegen events can be skipped to render the fragment diagram correctly. Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe --- M www/query_timeline.tmpl 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20458/2 -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen
Surya Hebbar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20458 Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. IMPALA-12417: Fix query timeline issue during asynchronous codegen When ASYNC_CODEGEN = 1, async code generation is enabled, this switches the compiled function pointers during runtime. Hence, enabling codegen to run on a parallel thread. In this case, a new event sequence is added to each fragment's profile. These additional events exhaust the default phase's colors available and disturb the corelation between them. AsyncCodegen events can be skipped to render the fragment diagram correctly. Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe --- M www/query_timeline.tmpl 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20458/1 -- To view, visit http://gerrit.cloudera.org:8080/20458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I01b29b869b16a5f2f2e398ac7e937f137614d6fe Gerrit-Change-Number: 20458 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar
[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13925/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf Gerrit-Change-Number: 20427 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Wed, 06 Sep 2023 12:49:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9675/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf Gerrit-Change-Number: 20427 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Wed, 06 Sep 2023 12:45:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS
k.venureddy2...@gmail.com has posted comments on this change. (
http://gerrit.cloudera.org:8080/20427 )
Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS
..
Patch Set 6:
(2 comments)
Reworked comments
http://gerrit.cloudera.org:8080/#/c/20427/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/20427/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@269
PS3, Line 269: EVENT_SKIP_LI
> nit: The code style prefers uppercase names for static final fields.
Done
http://gerrit.cloudera.org:8080/#/c/20427/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/20427/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@269
PS4, Line 269: private static final List EVENT_SKIP_LIST =
Arrays.asList("OPEN_TXN");
> Can add a test in
added
--
To view, visit http://gerrit.cloudera.org:8080/20427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf
Gerrit-Change-Number: 20427
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Sai Hemanth Gantasala
Gerrit-Comment-Date: Wed, 06 Sep 2023 12:25:28 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS
k.venureddy2...@gmail.com has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. IMPALA-12399: Add filter to skip OPEN_TXN events from HMS Notification events like OPEN_TXN are ignored on catalogd MetastoreEventsProcessor. So, we can pass eventTypeSkipList with OPEN_TXN in NotificationEventRequest while invoking get_next_notification() to avoid reading such notification messages from metastore and then ignoring on catalogd. OPEN_TXN event being more frequent(received even upon describe table operation from beeline), we can significantly reduce unwanted processing on both hive metastore and catalogd. Catalogd reads events in batches of EVENTS_BATCH_SIZE_PER_RPC, skipping such unnecessary events can help catchup the events faster. Testing: - Manually tested in cluster and added a testcase Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf --- M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/20427/6 -- To view, visit http://gerrit.cloudera.org:8080/20427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf Gerrit-Change-Number: 20427 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala
[Impala-ASF-CR] IMPALA-12407: Add test table with Iceberg Equality deletes
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20422 ) Change subject: IMPALA-12407: Add test table with Iceberg Equality deletes .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13924/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d7e5928aff95ed09b1d7725b31a1698e3c31835 Gerrit-Change-Number: 20422 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 06 Sep 2023 07:28:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12407: Add test table with Iceberg Equality deletes
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20422 ) Change subject: IMPALA-12407: Add test table with Iceberg Equality deletes .. IMPALA-12407: Add test table with Iceberg Equality deletes This commit updates the iceberg_v2_delete_equality test table. The previous table was a modified positional delete table and the delete files were actually positional delete files. This table was created with Flink, which is one of the few services that can write equality delete files currently. Testing: - Queried the table manually from Hive/Impala - Ran the related E2E tests Change-Id: I2d7e5928aff95ed09b1d7725b31a1698e3c31835 Reviewed-on: http://gerrit.cloudera.org:8080/20422 Reviewed-by: Gabor Kaszab Tested-by: Impala Public Jenkins --- M testdata/data/README A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-231ec696-613a-4270-a1f1-1f69947622d4-1.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-231ec696-613a-4270-a1f1-1f69947622d4-2.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-931d6d35-d95e-468f-a7d9-d64f7a7b5282-1.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-931d6d35-d95e-468f-a7d9-d64f7a7b5282-2.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-e3ac4bad-51b8-4c65-a20e-4bff5b1726b7-1.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-e3ac4bad-51b8-4c65-a20e-4bff5b1726b7-2.parquet D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-fb178c51-b12a-4c5f-a66e-a8e9375daeba-1.parquet D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/00191-4-6e780302-527b-4911-8c6e-88d416adac57-1.parquet D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/0eadf173-0c84-4378-a9d0-5d7f47183978-m0.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/22029492-dcdb-4ba1-a447-9b9f7200f9e4-m0.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/22029492-dcdb-4ba1-a447-9b9f7200f9e4-m1.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/30efd05a-a329-4420-8592-9fab221add9e-m0.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/30efd05a-a329-4420-8592-9fab221add9e-m1.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/490632c7-54bf-4362-97e7-b75ab18da9ac-m0.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/490632c7-54bf-4362-97e7-b75ab18da9ac-m1.avro D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/8cbef400-daea-478a-858a-2baf2438f644-m0.avro C testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/snap-3207673167795000154-2-30efd05a-a329-4420-8592-9fab221add9e.avro R testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/snap-36159809790235-1-22029492-dcdb-4ba1-a447-9b9f7200f9e4.avro D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/snap-5725822353600261755-1-0eadf173-0c84-4378-a9d0-5d7f47183978.avro C testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/snap-5763349507283783091-3-490632c7-54bf-4362-97e7-b75ab18da9ac.avro M testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/v1.metadata.json M testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/v2.metadata.json A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/v3.metadata.json A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/v4.metadata.json D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/version-hint.text A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/version-hint.txt M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test 29 files changed, 362 insertions(+), 91 deletions(-) Approvals: Gabor Kaszab: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/20422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2d7e5928aff95ed09b1d7725b31a1698e3c31835 Gerrit-Change-Number: 20422 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate
[Impala-ASF-CR] IMPALA-12407: Add test table with Iceberg Equality deletes
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20422 ) Change subject: IMPALA-12407: Add test table with Iceberg Equality deletes .. IMPALA-12407: Add test table with Iceberg Equality deletes This commit updates the iceberg_v2_delete_equality test table. The previous table was a modified positional delete table and the delete files were actually positional delete files. This table was created with Flink, which is one of the few services that can write equality delete files currently. Testing: - Queried the table manually from Hive/Impala - Ran the related E2E tests Change-Id: I2d7e5928aff95ed09b1d7725b31a1698e3c31835 --- M testdata/data/README A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-231ec696-613a-4270-a1f1-1f69947622d4-1.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-231ec696-613a-4270-a1f1-1f69947622d4-2.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-931d6d35-d95e-468f-a7d9-d64f7a7b5282-1.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-931d6d35-d95e-468f-a7d9-d64f7a7b5282-2.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-e3ac4bad-51b8-4c65-a20e-4bff5b1726b7-1.parquet A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-e3ac4bad-51b8-4c65-a20e-4bff5b1726b7-2.parquet D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/0-0-fb178c51-b12a-4c5f-a66e-a8e9375daeba-1.parquet D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/data/00191-4-6e780302-527b-4911-8c6e-88d416adac57-1.parquet D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/0eadf173-0c84-4378-a9d0-5d7f47183978-m0.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/22029492-dcdb-4ba1-a447-9b9f7200f9e4-m0.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/22029492-dcdb-4ba1-a447-9b9f7200f9e4-m1.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/30efd05a-a329-4420-8592-9fab221add9e-m0.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/30efd05a-a329-4420-8592-9fab221add9e-m1.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/490632c7-54bf-4362-97e7-b75ab18da9ac-m0.avro A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/490632c7-54bf-4362-97e7-b75ab18da9ac-m1.avro D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/8cbef400-daea-478a-858a-2baf2438f644-m0.avro C testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/snap-3207673167795000154-2-30efd05a-a329-4420-8592-9fab221add9e.avro R testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/snap-36159809790235-1-22029492-dcdb-4ba1-a447-9b9f7200f9e4.avro D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/snap-5725822353600261755-1-0eadf173-0c84-4378-a9d0-5d7f47183978.avro C testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/snap-5763349507283783091-3-490632c7-54bf-4362-97e7-b75ab18da9ac.avro M testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/v1.metadata.json M testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/v2.metadata.json A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/v3.metadata.json A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/v4.metadata.json D testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/version-hint.text A testdata/data/iceberg_test/hadoop_catalog/ice/iceberg_v2_delete_equality/metadata/version-hint.txt M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test 29 files changed, 362 insertions(+), 91 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/20422/3 -- To view, visit http://gerrit.cloudera.org:8080/20422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2d7e5928aff95ed09b1d7725b31a1698e3c31835 Gerrit-Change-Number: 20422 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13923/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf Gerrit-Change-Number: 20427 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Wed, 06 Sep 2023 06:41:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS
k.venureddy2...@gmail.com has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. IMPALA-12399: Add filter to skip OPEN_TXN events from HMS Notification events like OPEN_TXN are ignored on catalogd MetastoreEventsProcessor. So, we can pass eventTypeSkipList with OPEN_TXN in NotificationEventRequest while invoking get_next_notification() to avoid reading such notification messages from metastore and then ignoring on catalogd. OPEN_TXN event being more frequent(received even upon describe table operation from beeline), we can significantly reduce unwanted processing on both hive metastore and catalogd. Catalogd reads events in batches of EVENTS_BATCH_SIZE_PER_RPC, skipping such unnecessary events can help catchup the events faster. Testing: - Manually tested Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf --- M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/20427/5 -- To view, visit http://gerrit.cloudera.org:8080/20427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id2f2e1040abce0b00a8a07bfe8b46afcd98290bf Gerrit-Change-Number: 20427 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala
