[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18729 to look at the new patch set (#4). Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables .. IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent. Testing: - e2e tests Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test M tests/query_test/test_kudu.py 4 files changed, 154 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/4 -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18729 to look at the new patch set (#3). Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables .. IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent. Testing: - e2e tests Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test M tests/query_test/test_kudu.py 4 files changed, 159 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/3 -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 3 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18729 to look at the new patch set (#2). Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables .. IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent. Testing: - e2e tests Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test M tests/query_test/test_kudu.py 4 files changed, 157 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/2 -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 2 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table c
Xiaoqing Gao has restored this change. ( http://gerrit.cloudera.org:8080/18729 ) Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent. .. Restored -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table c
Xiaoqing Gao has abandoned this change. ( http://gerrit.cloudera.org:8080/18729 ) Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table c
Xiaoqing Gao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18729 Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent. .. IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent. Testing: - e2e tests Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test M tests/query_test/test_kudu.py 4 files changed, 156 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/1 -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/18641/10/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/18641/10/common/thrift/CatalogObjects.thrift@597 PS10, Line 597: stats; > nit: I think we should rename this as well Done http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@85 PS10, Line 85: Stats() > nit: Stats Done http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@585 PS10, Line 585: Stats > nit: Stats Done http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/10/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@168 PS10, Line 168: Stats_; > nit: Stats Done -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 11 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Xiaoqing Gao Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 05 Jul 2022 12:25:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Tamas Mate, Zoltan Borok-Nagy, lipeng...@sensorsdata.cn, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#11).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS ice_ctas_hadoop_tables_part;
'{"d_month":"613"}',4,2
'{"d_month":"614"}',3,1
'{"d_month":"615"}',2,1
Testing:
- Added end-to-end test
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-ctas.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
11 files changed, 267 insertions(+), 103 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/11
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Xiaoqing Gao has posted comments on this change. (
http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
Patch Set 10:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/18641/8/common/thrift/CatalogObjects.thrift
File common/thrift/CatalogObjects.thrift:
http://gerrit.cloudera.org:8080/#/c/18641/8/common/thrift/CatalogObjects.thrift@574
PS8, Line 574: TIcebergPartitionStats {
> nit: maybe a better name would be TIcebergPartitionStats or TIcebergPartiti
Done
http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java:
http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@303
PS8, Line 303: getPartitionStats
> nit: now a better name would be getPartitionStats() or getPartitionInfo()
Done
http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@310
PS8, Line 310: Partition", Ty
> nit: I think it's rather 'Partition' than 'Partition Name'.
Done
http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java:
http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java@264
PS8, Line 264:
> nit: I think we could just return null here, no need for the member.
Thank you very much for your idea.
http://gerrit.cloudera.org:8080/#/c/18641/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
File
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test:
http://gerrit.cloudera.org:8080/#/c/18641/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test@45
PS8, Line 45: ull}',1,1
> nit: Iceberg just uses null here (without quotes): https://github.com/apach
Done
http://gerrit.cloudera.org:8080/#/c/18641/8/tests/custom_cluster/test_iceberg.py
File tests/custom_cluster/test_iceberg.py:
http://gerrit.cloudera.org:8080/#/c/18641/8/tests/custom_cluster/test_iceberg.py@26
PS8, Line 26:
> I'm not strongly against this, but there is no need to put these tests into
Done
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Sat, 02 Jul 2022 06:49:11 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Tamas Mate, Zoltan Borok-Nagy, lipeng...@sensorsdata.cn, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#10).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS ice_ctas_hadoop_tables_part;
'{"d_month":"613"}',4,2
'{"d_month":"614"}',3,1
'{"d_month":"615"}',2,1
Testing:
- Added end-to-end test
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-ctas.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
11 files changed, 267 insertions(+), 103 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/10
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Tamas Mate, Zoltan Borok-Nagy, lipeng...@sensorsdata.cn, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#9).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS ice_ctas_hadoop_tables_part;
'{"d_month":"613"}',4,2
'{"d_month":"614"}',3,1
'{"d_month":"615"}',2,1
Testing:
- Added end-to-end test
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-ctas.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
12 files changed, 269 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/9
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Tamas Mate, Zoltan Borok-Nagy, lipeng...@sensorsdata.cn, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#8).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS ice_ctas_hadoop_tables_part;
'{"d_month":"613"}',4,2
'{"d_month":"614"}',3,1
'{"d_month":"615"}',2,1
Testing:
- Added end-to-end test
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-ctas.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
A tests/custom_cluster/test_iceberg.py
11 files changed, 313 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/8
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/18641/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@575 PS6, Line 575: Returns > nit: Return Done http://gerrit.cloudera.org:8080/#/c/18641/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@576 PS6, Line 576: resulset > nit: result set Done http://gerrit.cloudera.org:8080/#/c/18641/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@585 PS6, Line 585: new TreeMap<>(); > Already ensured that the return value of this method is ordered by the 'par Solved. Forgot to change back. -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 6 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Xiaoqing Gao Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 27 Jun 2022 06:11:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Tamas Mate, Zoltan Borok-Nagy, lipeng...@sensorsdata.cn, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#7).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS ice_ctas_hadoop_tables_part;
'{"d_month":"613"}',4,2
'{"d_month":"614"}',3,1
'{"d_month":"615"}',2,1
Testing:
- Added end-to-end test
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-ctas.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
A tests/custom_cluster/test_iceberg.py
11 files changed, 315 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/7
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Xiaoqing Gao has posted comments on this change. (
http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
Patch Set 4:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java:
http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@310
PS4, Line 310: resultSchema.addToColumns(new TColumn("Number Of Files",
Type.BIGINT.toThrift()));
: resultSchema.addToColumns(new TColumn("Number Of Rows",
Type.BIGINT.toThrift()));
> Seems like Hive outputs "Number of Rows" first, then "Number of Files":
Done
http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@565
PS4, Line 565: loadPartitionContent
> Could you please separate this to two functions?
Done
http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@574
PS4, Line 574: map
> rename it 'fieldNameToPartitionValue' to make a little bit more sense.
Thanks for your suggestion
http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@581
PS4, Line 581: partValueString = table.getNullPartitionKeyValue();
> Please add test for NULL partition key value.
Done
http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java:
http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@77
PS4, Line 77: private Map partitionContent_;
> Seems like it doesn't get initialized anywhere.
Thanks for your suggestion. I added this in e2e
http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@123
PS4, Line 123: defaultPartitionSpecId_ =
tableInfo.getIceberg_table().getDefault_partition_spec_id();
> I think we could initialize 'partitionContent_' somewhere here.
Done
http://gerrit.cloudera.org:8080/#/c/18641/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test:
http://gerrit.cloudera.org:8080/#/c/18641/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test@40
PS4, Line 40: SHOW PARTITIONS iceberg_hadoop_tables;
> Maybe we can keep one 'SHOW PARTITIONS', but the others seem quite unnecess
Done
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Fri, 24 Jun 2022 13:28:52 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Tamas Mate, Zoltan Borok-Nagy, lipeng...@sensorsdata.cn, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#6).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS ice_ctas_hadoop_tables_part;
'{"d_month":"613"}',4,2
'{"d_month":"614"}',3,1
'{"d_month":"615"}',2,1
Testing:
- Added end-to-end test
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-ctas.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
A tests/custom_cluster/test_iceberg.py
11 files changed, 313 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/6
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Tamas Mate, Zoltan Borok-Nagy, lipeng...@sensorsdata.cn, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#5).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS ice_ctas_hadoop_tables_part;
'{"d_month":"613"}',4,2
'{"d_month":"614"}',3,1
'{"d_month":"615"}',2,1
Testing:
- Added end-to-end test
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-ctas.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
A tests/custom_cluster/test_iceberg.py
11 files changed, 304 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/5
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tamas Mate
Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 ) Change subject: IMPALA-11233: Unset all query option .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/18430/14/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/18430/14/tests/shell/test_shell_interactive.py@706 PS14, Line 706: assert "\tMT_DOP: " in result.stdout > This fails in Python3: Thanks for your help. I fixed this case and triggered jenkins job again. -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 14 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao Gerrit-Comment-Date: Wed, 22 Jun 2022 07:59:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#15). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query options, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into effect. We need a feature that a set statement can reset all query option without recreating a new connection. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M shell/impala_shell.py M tests/custom_cluster/test_set_and_unset.py M tests/hs2/test_hs2.py M tests/shell/test_shell_interactive.py 12 files changed, 132 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/15 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 15 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#4).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS iceberg_partitioned;
'{"event_time_hour":"438296","action":"view"}',8,8
'{"event_time_hour":"438297","action":"click"}',6,6
'{"event_time_hour":"438298","action":"download"}',6,6
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
8 files changed, 107 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/4
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#3).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS iceberg_partitioned;
'{"event_time_hour":"438296","action":"view"}',8,8
'{"event_time_hour":"438297","action":"click"}',6,6
'{"event_time_hour":"438298","action":"download"}',6,6
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
8 files changed, 111 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/3
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18641
to look at the new patch set (#2).
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition
spec which is not too useful.
Instead it should output the concrete partitions, number of files, number
of rows in each partitions. E.g.:
SHOW PARTITIONS iceberg_partitioned;
'{"event_time_hour":"438296","action":"view"}',8,8
'{"event_time_hour":"438297","action":"click"}',6,6
'{"event_time_hour":"438298","action":"download"}',6,6
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
8 files changed, 111 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/2
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Xiaoqing Gao has uploaded this change for review. (
http://gerrit.cloudera.org:8080/18641
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the
partitions
..
IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions
Currently, SHOW PARTITIONS on Iceberg tables only outputs the partition spec
which is not too useful.
Instead it should output the concrete partitions, number of files, number of
rows in each partitions,
E.g.:
SHOW PARTITIONS iceberg_partitioned;
'{"event_time_hour":"438296","action":"view"}',8,8
'{"event_time_hour":"438297","action":"click"}',6,6
'{"event_time_hour":"438298","action":"download"}',6,6
Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
---
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
8 files changed, 112 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18641/1
--
To view, visit http://gerrit.cloudera.org:8080/18641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#13). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query options, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into effect. We need a feature that a set statement can reset all query option without recreating a new connection. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M shell/impala_shell.py M tests/custom_cluster/test_set_and_unset.py M tests/hs2/test_hs2.py M tests/shell/test_shell_interactive.py 12 files changed, 132 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/13 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 13 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 ) Change subject: IMPALA-11233: Unset all query option .. Patch Set 11: DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 11 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao Gerrit-Comment-Date: Wed, 08 Jun 2022 10:43:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Xiaoqing Gao has posted comments on this change. (
http://gerrit.cloudera.org:8080/18430 )
Change subject: IMPALA-11233: Unset all query option
..
Patch Set 11:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG@9
PS8, Line 9: options
> nit: options.
Done
http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG@12
PS8, Line 12: effect
> nit: effect?
Done
http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG@13
PS8, Line 13: recreating a ne
> I think users can re-create a connection instead of restarting the impalad.
Done
http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:
http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/client-request-state.cc@284
PS8, Line 284: } else if
(exec_request_->set_query_option_request.__isset.query_option_type
> I think we should also check "exec_request_->set_query_option_request.__iss
Done
http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/query-options.cc
File be/src/service/query-options.cc:
http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/query-options.cc@1309
PS8, Line 1309: TQueryOptions* que
> I think this should be "DCHECK_GE(option, 0)". Query options generated in Q
Thanks for the great suggestion.
http://gerrit.cloudera.org:8080/#/c/18430/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:
http://gerrit.cloudera.org:8080/#/c/18430/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4639
PS8, Line 4639: AnalyzesOk("set");
> Could you add a test here for "unset all"?
Done
http://gerrit.cloudera.org:8080/#/c/18430/8/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/18430/8/shell/impala_shell.py@895
PS8, Line 895: elif option == 'ALL':
> Let's print some info like the above cases.
Done
http://gerrit.cloudera.org:8080/#/c/18430/8/tests/custom_cluster/test_set_and_unset.py
File tests/custom_cluster/test_set_and_unset.py:
http://gerrit.cloudera.org:8080/#/c/18430/8/tests/custom_cluster/test_set_and_unset.py@86
PS8, Line 86:
> Could you add some tests here? We need to test that if impala is launched w
Done
http://gerrit.cloudera.org:8080/#/c/18430/8/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:
http://gerrit.cloudera.org:8080/#/c/18430/8/tests/shell/test_shell_interactive.py@686
PS8, Line 686: assert "\tDEFAULT_FILE_FORMAT: avro" in result.stdout
> Can we add a test for "unset all" here? We currently don't have tests on im
Done
--
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jian Zhang
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Comment-Date: Wed, 08 Jun 2022 10:10:48 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#11). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query options, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into effect. We need a feature that a set statement can reset all query option without recreating a new connection. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M shell/impala_shell.py M tests/custom_cluster/test_set_and_unset.py M tests/hs2/test_hs2.py M tests/shell/test_shell_interactive.py 11 files changed, 131 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/11 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 11 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#10). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query options, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into effect. We need a feature that a set statement can reset all query option without recreating a new connection. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M shell/impala_shell.py M tests/custom_cluster/test_set_and_unset.py M tests/hs2/test_hs2.py M tests/shell/test_shell_interactive.py 11 files changed, 132 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/10 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 10 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#9). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query options, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into effect. We need a feature that a set statement can reset all query option without recreating a new connection. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M shell/impala_shell.py M tests/custom_cluster/test_set_and_unset.py M tests/hs2/test_hs2.py M tests/shell/test_shell_interactive.py 11 files changed, 133 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/9 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 9 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 ) Change subject: IMPALA-11233: Unset all query option .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18430/6/fe/src/main/java/org/apache/impala/analysis/SetStmt.java File fe/src/main/java/org/apache/impala/analysis/SetStmt.java: http://gerrit.cloudera.org:8080/#/c/18430/6/fe/src/main/java/org/apache/impala/analysis/SetStmt.java@30 PS6, Line 30: private final String value_; : private final TQueryOptionTy > Seems like the `SetStmt` can only be one of the following modes: Done -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 8 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Anonymous Coward (339) Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao Gerrit-Comment-Date: Mon, 30 May 2022 08:54:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Quanlong Huang, Anonymous Coward (339), Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#8). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affect. We need a feature that a set statement can reset all query option without restart impalad. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M shell/impala_shell.py M tests/hs2/test_hs2.py 8 files changed, 90 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/8 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 8 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Anonymous Coward (339) Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Quanlong Huang, Anonymous Coward (339), Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#7). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affect. We need a feature that a set statement can reset all query option without restart impalad. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M shell/impala_shell.py M tests/hs2/test_hs2.py 8 files changed, 91 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/7 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 7 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Anonymous Coward (339) Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Quanlong Huang, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#6). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affect. We need a feature that a set statement can reset all query option without restart impalad. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M shell/impala_shell.py M tests/hs2/test_hs2.py 8 files changed, 71 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/6 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 6 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Xiaoqing Gao has posted comments on this change. (
http://gerrit.cloudera.org:8080/18430 )
Change subject: IMPALA-11233: Unset all query option
..
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h
File be/src/service/query-options.h:
http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h@344
PS4, Line 344: /// Reset all query options to its default value if they are not
equal to default value.
> Could you please write some comment for this functions as you see for the o
Done
http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc
File be/src/service/query-options.cc:
http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1301
PS4, Line 1301: set_
> nit: I see at other functions that they call this param as 'set_query_optio
Done
http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1307
PS4, Line 1307: query_options->NAME = defaults.NAME; \
> is there a case when defaults.__isset.NAME is true? Can't we simply set que
Done
http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java
File fe/src/main/java/org/apache/impala/analysis/SetStmt.java:
http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java@55
PS4, Line 55: public SetStmt(String key, String value, boolean isSetAll,
boolean isUnsetAll) {
> At the callsite of this when you see "new SetStmt(true)" it's not really se
Done
--
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Comment-Date: Fri, 27 May 2022 09:53:47 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Quanlong Huang, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#5). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affect. We need a feature that a set statement can reset all query option without restart impalad. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M shell/impala_shell.py M tests/hs2/test_hs2.py 8 files changed, 72 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/5 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#4). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affect. We need a feature that a set statement can reset all query option without restart impalad. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M shell/impala_shell.py M tests/hs2/test_hs2.py 8 files changed, 69 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/4 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18430 to look at the new patch set (#3). Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affect. We need a feature that a set statement can reset all query option without restart impalad. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M shell/impala_shell.py M tests/hs2/test_hs2.py 8 files changed, 69 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/3 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 3 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11233: Unset all query option
Xiaoqing Gao has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18430 ) Change subject: IMPALA-11233: Unset all query option .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affect. We need a feature that a set statement can reset all query option without restart impalad. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M shell/impala_shell.py M tests/hs2/test_hs2.py 8 files changed, 68 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/2 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 2 Gerrit-Owner: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool
Xiaoqing Gao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18430 Change subject: IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affe .. IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affect. We need a feature that a set statement can reset all query option without restart impalad. Support UNSET statements in SQL dialect. UNSET ALL can unset all query option. Testing: - add unset all query option in test_hs2.py Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/Frontend.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/SetStmt.java M shell/impala_shell.py M tests/hs2/test_hs2.py 8 files changed, 68 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/1 -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-11233: a demo for reset all query option
Xiaoqing Gao has abandoned this change. ( http://gerrit.cloudera.org:8080/18408 ) Change subject: IMPALA-11233: a demo for reset all query option .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ib523878710660e419c51c37a83ca79bbf60886b4 Gerrit-Change-Number: 18408 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11233: a demo for reset all query option
Xiaoqing Gao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18408 Change subject: IMPALA-11233: a demo for reset all query option .. IMPALA-11233: a demo for reset all query option Change-Id: Ib523878710660e419c51c37a83ca79bbf60886b4 --- M be/src/service/client-request-state.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/ImpalaService.thrift M common/thrift/Query.thrift 5 files changed, 27 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/18408/1 -- To view, visit http://gerrit.cloudera.org:8080/18408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib523878710660e419c51c37a83ca79bbf60886b4 Gerrit-Change-Number: 18408 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16912 ) Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/16912/6/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test File testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test: http://gerrit.cloudera.org:8080/#/c/16912/6/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test@2520 PS6, Line 2520: | row-size=1B cardinality=9 > My example query mistakenly omitted the parenthesis after the AND predicate Done -- To view, visit http://gerrit.cloudera.org:8080/16912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 Gerrit-Change-Number: 16912 Gerrit-PatchSet: 7 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Xiaoqing Gao Gerrit-Comment-Date: Wed, 06 Jan 2021 09:15:33 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table
Hello Aman Sinha, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16912 to look at the new patch set (#7). Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. IMPALA-10412: ConvertToCNFRule can be applied to view table For OR predicates that reference a view, currently the ConvertToCNFRule does not get applied since it is considered a single table predicate even if the predicate might reference columns from different tables within the view. This patch enables the application of this rule for such predicates by checking the expanded view and if it satisfies the criterion then the rule can be applied and the predicate can be pushed eventually to the scan. Testing: Added planner test in inline-view.test Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 --- M fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test 2 files changed, 81 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16912/7 -- To view, visit http://gerrit.cloudera.org:8080/16912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 Gerrit-Change-Number: 16912 Gerrit-PatchSet: 7 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Xiaoqing Gao
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16912 ) Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16912/5/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java File fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java: http://gerrit.cloudera.org:8080/#/c/16912/5/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@126 PS5, Line 126: tids.clear(); > If the predicate did not change based on the previous trySubstitute() call, Done -- To view, visit http://gerrit.cloudera.org:8080/16912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 Gerrit-Change-Number: 16912 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Xiaoqing Gao Gerrit-Comment-Date: Mon, 04 Jan 2021 08:12:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table
Xiaoqing Gao has posted comments on this change. (
http://gerrit.cloudera.org:8080/16912 )
Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table
..
Patch Set 6:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/16912/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16912/5//COMMIT_MSG@7
PS5, Line 7: applied to view table
:
> nit: 'applied to a view'
Done
http://gerrit.cloudera.org:8080/#/c/16912/5//COMMIT_MSG@9
PS5, Line 9: For OR predicates that reference a view, currently the
ConvertToCNFRule
> This sentence seems to be a continuation of the title summary. In general,
Done
http://gerrit.cloudera.org:8080/#/c/16912/5//COMMIT_MSG@13
PS5, Line 13: suc
> nit: 'Added'
Done
http://gerrit.cloudera.org:8080/#/c/16912/5/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java
File fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java:
http://gerrit.cloudera.org:8080/#/c/16912/5/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@122
PS5, Line 122: if (tbl instanceof InlineViewRef) {
> tids.get(0) could hit index out of bounds if tids was empty .. which is a c
Done
http://gerrit.cloudera.org:8080/#/c/16912/5/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java@124
PS5, Line 124: analyzer, false);
> I think this should use 'cpred' instead of pred since cpred is the the anal
Done
http://gerrit.cloudera.org:8080/#/c/16912/5/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test
File testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test:
http://gerrit.cloudera.org:8080/#/c/16912/5/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test@2487
PS5, Line 2487: appli
> nit: 'applied'
Done
http://gerrit.cloudera.org:8080/#/c/16912/5/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test@2491
PS5, Line 2491: select count(*) from t where t.test_zip = 1 or
(t.test_name='xyz' and t.zip=1);
> Could you also add a test where the inline view itself is joined with anoth
Done
http://gerrit.cloudera.org:8080/#/c/16912/5/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test@2515
PS5, Line 2515: # IMPALA-10412: ConvertToCNFRule can be applied to view table
> It wasn't clear what the purpose of this test was. If it is not really exer
Done
--
To view, visit http://gerrit.cloudera.org:8080/16912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88
Gerrit-Change-Number: 16912
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao
Gerrit-Reviewer: Aman Sinha
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Xiaoqing Gao
Gerrit-Comment-Date: Mon, 04 Jan 2021 08:12:12 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table
Hello Aman Sinha, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16912 to look at the new patch set (#6). Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. IMPALA-10412: ConvertToCNFRule can be applied to view table For OR predicates that reference a view, currently the ConvertToCNFRule does not get applied since it is considered a single table predicate even if the predicate might reference columns from different tables within the view. This patch enables the application of this rule for such predicates by checking the expanded view and if it satisfies the criterion then the rule can be applied and the predicate can be pushed eventually to the scan. Testing: Added planner test in inline-view.test Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 --- M fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test 2 files changed, 78 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16912/6 -- To view, visit http://gerrit.cloudera.org:8080/16912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 Gerrit-Change-Number: 16912 Gerrit-PatchSet: 6 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be apply to view table
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16912 to look at the new patch set (#5). Change subject: IMPALA-10412: ConvertToCNFRule can be apply to view table .. IMPALA-10412: ConvertToCNFRule can be apply to view table if the predicate associated more than one tuples and the predicate can be pushed down to scan node Testing: Add planner test in inline-view.test Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 --- M fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test 2 files changed, 55 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16912/5 -- To view, visit http://gerrit.cloudera.org:8080/16912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 Gerrit-Change-Number: 16912 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be apply to view table
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16912 to look at the new patch set (#4). Change subject: IMPALA-10412: ConvertToCNFRule can be apply to view table .. IMPALA-10412: ConvertToCNFRule can be apply to view table if the predicate associated more than one tuples and the predicate can be pushed down to scan node Testing: Add planner test in inline-view.test Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 --- M fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test 2 files changed, 55 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16912/4 -- To view, visit http://gerrit.cloudera.org:8080/16912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 Gerrit-Change-Number: 16912 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be apply to view table
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16912 to look at the new patch set (#3). Change subject: IMPALA-10412: ConvertToCNFRule can be apply to view table .. IMPALA-10412: ConvertToCNFRule can be apply to view table if the predicate associated more than one tuples and the predicate can be pushed down to scan node Testing: Add planner test in inline-view.test Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 --- M fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test 2 files changed, 55 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16912/3 -- To view, visit http://gerrit.cloudera.org:8080/16912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 Gerrit-Change-Number: 16912 Gerrit-PatchSet: 3 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be apply to view table
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16912 to look at the new patch set (#2). Change subject: IMPALA-10412: ConvertToCNFRule can be apply to view table .. IMPALA-10412: ConvertToCNFRule can be apply to view table if the predicate associated more than one tuples and the predicate can be pushed down to scan node Testing: Add planner test in inline-view.test Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 --- M fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test 2 files changed, 39 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16912/2 -- To view, visit http://gerrit.cloudera.org:8080/16912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 Gerrit-Change-Number: 16912 Gerrit-PatchSet: 2 Gerrit-Owner: Xiaoqing Gao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be apply to view table
Xiaoqing Gao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16912 Change subject: IMPALA-10412: ConvertToCNFRule can be apply to view table .. IMPALA-10412: ConvertToCNFRule can be apply to view table if the predicate associated more than one tuples and the predicate can be pushed down to scan node Testing: Add planner test in inline-view.test Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 --- M fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test 2 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16912/1 -- To view, visit http://gerrit.cloudera.org:8080/16912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88 Gerrit-Change-Number: 16912 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao
