[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7807/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 05 Feb 2022 17:05:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18207 Change subject: IMPALA-11109: Catch class loading error for UDFs. .. IMPALA-11109: Catch class loading error for UDFs. If a UDF fails to load, an exception needs to be caught and logged or else catalogd will not start up. Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf --- M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java 1 file changed, 19 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/18207/1 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10104/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 05 Feb 2022 17:29:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7807/ -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 05 Feb 2022 22:42:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18207 to look at the new patch set (#2). Change subject: IMPALA-11109: Catch class loading error for UDFs. .. IMPALA-11109: Catch class loading error for UDFs. If a UDF fails to load, an exception needs to be caught and logged or else catalogd will not start up. Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf --- M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java M fe/src/test/java/org/apache/impala/hive/executor/HiveLegacyJavaFunctionTest.java 2 files changed, 20 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/18207/2 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/18207 )
Change subject: IMPALA-11109: Catch class loading error for UDFs.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18207/2/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java
File
fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java:
http://gerrit.cloudera.org:8080/#/c/18207/2/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@171
PS2, Line 171: throw new CatalogException("Error loading function " +
hiveFn_.getFunctionName() + ": " + t);
line too long (100 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf
Gerrit-Change-Number: 18207
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Sun, 06 Feb 2022 01:22:42 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18207 to look at the new patch set (#3). Change subject: IMPALA-11109: Catch class loading error for UDFs. .. IMPALA-11109: Catch class loading error for UDFs. If a UDF fails to load, an exception needs to be caught and logged or else catalogd will not start up. Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf --- M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java M fe/src/test/java/org/apache/impala/hive/executor/HiveLegacyJavaFunctionTest.java 2 files changed, 22 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/18207/3 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10107/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 06 Feb 2022 01:45:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10108/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 06 Feb 2022 01:52:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7809/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 06 Feb 2022 04:33:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 06 Feb 2022 11:10:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18207/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18207/3//COMMIT_MSG@9 PS3, Line 9: If a UDF fails to load, an exception needs to be caught I think we should mention that this fixes a regression and where it was introduced. For example, if the original commit is backported to some branch, if the regression is mentioned here we would know that this commit should also be backported. http://gerrit.cloudera.org:8080/#/c/18207/3//COMMIT_MSG@10 PS3, Line 10: logged Where do we log the exception? Don't we just re-throw it in HiveLegacyJavaFunction.java? http://gerrit.cloudera.org:8080/#/c/18207/3/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/18207/3/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@170 PS3, Line 170: Throwable Can we be more specific about what kind of exceptions could be thrown? Or is it deliberately a catch-all clause? How does it help the catalogd if we re-throw the exception? -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 07 Feb 2022 14:51:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Hello Daniel Becker, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18207 to look at the new patch set (#4). Change subject: IMPALA-11109: Catch class loading error for UDFs. .. IMPALA-11109: Catch class loading error for UDFs. Fixes regression caused by IMPALA-10997. If a UDF fails to load, an exception needs to be caught and logged or else catalogd will not start up. The method HiveLegacyJavaFunction.extract() will catch any hidden exception thrown, and rethrow it as a CatalogException. The caller already handles the CatalogException and logs the message appropriately. The specific "hidden" exception thrown in our regression tests was a "ClassNotFoundException", but in case there are other exceptions that are thrown, we catch the generic "Throwable" exception because the "extract" method should not prevent the server from coming up. Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf --- M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java M fe/src/test/java/org/apache/impala/hive/executor/HiveLegacyJavaFunctionTest.java 2 files changed, 22 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/18207/4 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18207/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18207/3//COMMIT_MSG@9 PS3, Line 9: If a UDF fails to load, an exception needs to be caught > I think we should mention that this fixes a regression and where it was int Done http://gerrit.cloudera.org:8080/#/c/18207/3//COMMIT_MSG@10 PS3, Line 10: logged > Where do we log the exception? Don't we just re-throw it in HiveLegacyJavaF The caller will log the exception. The message is now wrapped in a CatalogException error which is already handled by the caller. I changed the commit message to be a bit more detailed, hopefully this explains things better. http://gerrit.cloudera.org:8080/#/c/18207/3/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/18207/3/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@170 PS3, Line 170: Throwable > Can we be more specific about what kind of exceptions could be thrown? Or i It is deliberately a catch-all clause because this method should never cause a runtime exception failure. The caller in our case expects some kind of exception to be thrown. I think it makes more sense to do the catch all here instead of the caller. -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Mon, 07 Feb 2022 15:15:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 4: Code-Review+1 Looks good. I'll let others also have a go before merging it. -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Mon, 07 Feb 2022 17:13:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 4: Code-Review+2 I ran custom cluster tests in exhaustive mode with this change and they all passed. This fix makes sense to me, I think we should go ahead. -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 08 Feb 2022 21:31:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 08 Feb 2022 21:32:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7819/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 08 Feb 2022 21:32:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/18207 )
Change subject: IMPALA-11109: Catch class loading error for UDFs.
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18207/5/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java
File
fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java:
http://gerrit.cloudera.org:8080/#/c/18207/5/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@167
PS5, Line 167: if (result.isEmpty()) {
: throw new CatalogException("No compatible function
signatures found.");
: }
This looks a bit weird - the outer catch will catch the inner Catalog
exception, and rethrow it with a bit different text.
This check could could be moved just before "return result;"
http://gerrit.cloudera.org:8080/#/c/18207/5/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@170
PS5, Line 170: Throwable
Can you add a comment about why we check Throwable?
--
To view, visit http://gerrit.cloudera.org:8080/18207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf
Gerrit-Change-Number: 18207
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Daniel Becker
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Steve Carlin
Gerrit-Comment-Date: Tue, 08 Feb 2022 22:38:04 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Removed Code-Review+2 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18207/7/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/18207/7/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@169 PS7, Line 169: // is ClassNotFoundException thrown by UDF_.getClass(). We want to catch all possible line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 09 Feb 2022 00:01:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7820/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 09 Feb 2022 00:01:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Hello Daniel Becker, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18207 to look at the new patch set (#7). Change subject: IMPALA-11109: Catch class loading error for UDFs. .. IMPALA-11109: Catch class loading error for UDFs. Fixes regression caused by IMPALA-10997. If a UDF fails to load, an exception needs to be caught and logged or else catalogd will not start up. The method HiveLegacyJavaFunction.extract() will catch any hidden exception thrown, and rethrow it as a CatalogException. The caller already handles the CatalogException and logs the message appropriately. The specific "hidden" exception thrown in our regression tests was a "ClassNotFoundException", but in case there are other exceptions that are thrown, we catch the generic "Throwable" exception because the "extract" method should not prevent the server from coming up. Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf --- M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java M fe/src/test/java/org/apache/impala/hive/executor/HiveLegacyJavaFunctionTest.java 2 files changed, 23 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/18207/7 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Steve Carlin has posted comments on this change. (
http://gerrit.cloudera.org:8080/18207 )
Change subject: IMPALA-11109: Catch class loading error for UDFs.
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18207/5/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java
File
fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java:
http://gerrit.cloudera.org:8080/#/c/18207/5/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@167
PS5, Line 167: if (result.isEmpty()) {
: throw new CatalogException("No compatible function
signatures found.");
: }
> This looks a bit weird - the outer catch will catch the inner Catalog excep
Done
http://gerrit.cloudera.org:8080/#/c/18207/5/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@170
PS5, Line 170: Throwable
> Can you add a comment about why we check Throwable?
Done
--
To view, visit http://gerrit.cloudera.org:8080/18207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf
Gerrit-Change-Number: 18207
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Daniel Becker
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Steve Carlin
Gerrit-Comment-Date: Wed, 09 Feb 2022 00:01:31 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10120/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 09 Feb 2022 00:22:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7821/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 09 Feb 2022 03:23:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Hello Daniel Becker, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18207 to look at the new patch set (#8). Change subject: IMPALA-11109: Catch class loading error for UDFs. .. IMPALA-11109: Catch class loading error for UDFs. Fixes regression caused by IMPALA-10997. If a UDF fails to load, an exception needs to be caught and logged or else catalogd will not start up. The method HiveLegacyJavaFunction.extract() will catch any hidden exception thrown, and rethrow it as a CatalogException. The caller already handles the CatalogException and logs the message appropriately. The specific "hidden" exception thrown in our regression tests was a "ClassNotFoundException", but in case there are other exceptions that are thrown, we catch the generic "Throwable" exception because the "extract" method should not prevent the server from coming up. Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf --- M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java M fe/src/test/java/org/apache/impala/hive/executor/HiveLegacyJavaFunctionTest.java 2 files changed, 23 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/18207/8 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/10122/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 09 Feb 2022 03:44:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 09 Feb 2022 04:08:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 09 Feb 2022 06:40:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 09 Feb 2022 09:56:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 09 Feb 2022 10:22:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11109: Catch class loading error for UDFs.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18207 ) Change subject: IMPALA-11109: Catch class loading error for UDFs. .. IMPALA-11109: Catch class loading error for UDFs. Fixes regression caused by IMPALA-10997. If a UDF fails to load, an exception needs to be caught and logged or else catalogd will not start up. The method HiveLegacyJavaFunction.extract() will catch any hidden exception thrown, and rethrow it as a CatalogException. The caller already handles the CatalogException and logs the message appropriately. The specific "hidden" exception thrown in our regression tests was a "ClassNotFoundException", but in case there are other exceptions that are thrown, we catch the generic "Throwable" exception because the "extract" method should not prevent the server from coming up. Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Reviewed-on: http://gerrit.cloudera.org:8080/18207 Tested-by: Impala Public Jenkins Reviewed-by: Csaba Ringhofer --- M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java M fe/src/test/java/org/apache/impala/hive/executor/HiveLegacyJavaFunctionTest.java 2 files changed, 23 insertions(+), 14 deletions(-) Approvals: Impala Public Jenkins: Verified Csaba Ringhofer: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Steve Carlin
