[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20385 )
Change subject: IMPALA-12386: Fix clone constructor in CastExpr
..
IMPALA-12386: Fix clone constructor in CastExpr
This commit addresses an issue in the CastExpr class where the clone
constructor was not properly preserving compatibility settings. The
clone constructor assigned the default compatibility regardless of the
source expression, causing substitution errors for partitioned tables.
Example:
'insert into unsafe_insert_partitioned(int_col, string_col)
values("1", null), (null, "1")'
Throws:
ERROR: IllegalStateException: Failed analysis after expr substitution.
CAUSED BY: IllegalStateException: cast STRING to INT
Tests:
- new test case added to insert-unsafe.test
Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f
Reviewed-on: http://gerrit.cloudera.org:8080/20385
Reviewed-by: Impala Public Jenkins
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M testdata/workloads/functional-query/queries/QueryTest/insert-unsafe.test
M tests/query_test/test_insert.py
3 files changed, 8 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f
Gerrit-Change-Number: 20385
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa
Gerrit-Reviewer: Daniel Becker
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Peter Rozsa
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20385 ) Change subject: IMPALA-12386: Fix clone constructor in CastExpr .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 22 Aug 2023 20:25:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20385 ) Change subject: IMPALA-12386: Fix clone constructor in CastExpr .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9615/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 22 Aug 2023 16:10:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20385 ) Change subject: IMPALA-12386: Fix clone constructor in CastExpr .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9613/ -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 22 Aug 2023 15:57:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20385 ) Change subject: IMPALA-12386: Fix clone constructor in CastExpr .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9613/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 22 Aug 2023 11:30:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20385 ) Change subject: IMPALA-12386: Fix clone constructor in CastExpr .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 22 Aug 2023 11:30:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20385 ) Change subject: IMPALA-12386: Fix clone constructor in CastExpr .. Patch Set 3: Code-Review+2 Thanks Péter! -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 22 Aug 2023 11:29:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20385 ) Change subject: IMPALA-12386: Fix clone constructor in CastExpr .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13800/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 22 Aug 2023 09:21:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Peter Rozsa has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/20385 )
Change subject: IMPALA-12386: Fix clone constructor in CastExpr
..
IMPALA-12386: Fix clone constructor in CastExpr
This commit addresses an issue in the CastExpr class where the clone
constructor was not properly preserving compatibility settings. The
clone constructor assigned the default compatibility regardless of the
source expression, causing substitution errors for partitioned tables.
Example:
'insert into unsafe_insert_partitioned(int_col, string_col)
values("1", null), (null, "1")'
Throws:
ERROR: IllegalStateException: Failed analysis after expr substitution.
CAUSED BY: IllegalStateException: cast STRING to INT
Tests:
- new test case added to insert-unsafe.test
Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M testdata/workloads/functional-query/queries/QueryTest/insert-unsafe.test
M tests/query_test/test_insert.py
3 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/20385/3
--
To view, visit http://gerrit.cloudera.org:8080/20385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f
Gerrit-Change-Number: 20385
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa
Gerrit-Reviewer: Daniel Becker
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Peter Rozsa
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20385 ) Change subject: IMPALA-12386: Fix clone constructor in CastExpr .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13790/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 21 Aug 2023 14:20:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Daniel Becker has posted comments on this change. (
http://gerrit.cloudera.org:8080/20385 )
Change subject: IMPALA-12386: Fix clone constructor in CastExpr
..
Patch Set 2:
(1 comment)
Thanks, just a small suggestion.
http://gerrit.cloudera.org:8080/#/c/20385/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20385/2//COMMIT_MSG@15
PS2, Line 15: 'insert into t01(a, b) values(null, "23"), ("21", null)'
Thinking about it, using the example from the test would be better as the
column names are more informative.
--
To view, visit http://gerrit.cloudera.org:8080/20385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f
Gerrit-Change-Number: 20385
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa
Gerrit-Reviewer: Daniel Becker
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Peter Rozsa
Gerrit-Comment-Date: Mon, 21 Aug 2023 14:10:18 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12386: Fix clone constructor in CastExpr
Peter Rozsa has uploaded a new patch set (#2). (
http://gerrit.cloudera.org:8080/20385 )
Change subject: IMPALA-12386: Fix clone constructor in CastExpr
..
IMPALA-12386: Fix clone constructor in CastExpr
This commit addresses an issue in the CastExpr class where the clone
constructor was not properly preserving compatibility settings. The
clone constructor assigned the default compatibility regardless of the
source expression, causing substitution errors later.
Example:
'insert into t01(a, b) values(null, "23"), ("21", null)'
Throws:
ERROR: IllegalStateException: Failed analysis after expr substitution.
CAUSED BY: IllegalStateException: cast STRING to INT
Tests:
- new test case added to insert-unsafe.test
Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M testdata/workloads/functional-query/queries/QueryTest/insert-unsafe.test
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/20385/2
--
To view, visit http://gerrit.cloudera.org:8080/20385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f
Gerrit-Change-Number: 20385
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa
Gerrit-Reviewer: Daniel Becker
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Peter Rozsa
