[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/20459 )
Change subject: IMPALA-12424: Allow third party JniFrontend interface.
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/20459/1/be/src/service/frontend.cc
File be/src/service/frontend.cc:
http://gerrit.cloudera.org:8080/#/c/20459/1/be/src/service/frontend.cc@88
PS1, Line 88: "the JniFrontend class included in the repository is used as
the frontend interface. This "
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py
File tests/custom_cluster/test_external_planner.py:
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@21
PS1, Line 21: import shutil
flake8: F401 'shutil' imported but unused
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@42
PS1, Line 42:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@42
PS1, Line 42: assert setup_client.execute("select 2").data == ['2']
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@44
PS1, Line 44:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@44
PS1, Line 44: assert setup_client.execute("select 1").data == ['42']
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/20459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5
Gerrit-Change-Number: 20459
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Wed, 06 Sep 2023 13:51:46 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20459 Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424: Allow third party JniFrontend interface. This patch allows a third party to inject their own frontend class instead of using the default JniFrontend included in the project. The test case includes an interface that runs queries as normal except for the "select 1" query which gets changed to "select 42". Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 --- M be/src/service/frontend.cc M bin/start-impala-cluster.py A java/external-frontend/pom.xml A java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java M java/pom.xml A tests/custom_cluster/test_external_planner.py 6 files changed, 192 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20459/1 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13928/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 14:09:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20459 to look at the new patch set (#2). Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424: Allow third party JniFrontend interface. This patch allows a third party to inject their own frontend class instead of using the default JniFrontend included in the project. The test case includes an interface that runs queries as normal except for the "select 1" query which gets changed to "select 42". Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 --- M be/src/service/frontend.cc M bin/start-impala-cluster.py A java/external-frontend/pom.xml A java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java M java/pom.xml A tests/custom_cluster/test_external_planner.py 6 files changed, 191 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20459/2 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13930/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 14:56:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9677/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 17:10:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 06 Sep 2023 21:31:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: Code-Review+1 This seems safe enough to me, and doesn't place much maintenance burden on Impala. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 22:21:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@87 PS2, Line 87: DEFINE_string(jni_frontend_class, "org/apache/impala/service/JniFrontend", "By default " They'd need to override this on any impalad and catalogd instances, right? -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 22:21:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: external-frontend Should we worry about this showing up in releases? Is there a test-only profile it should be restricted to? I don't see any examples of doing that so far, and we have test-hive-udfs, so :shrug: -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 22:22:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@87 PS2, Line 87: DEFINE_string(jni_frontend_class, "org/apache/impala/service/JniFrontend", "By default " > They'd need to override this on any impalad and catalogd instances, right? Depending on what they modify, they might be able to skip catalogd. http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@89 PS2, Line 89: "This option allows the class to be overridden by a third party module."); Nit: Should we say something about the specified class being a subclass of JniFrontend? http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: external-frontend > Should we worry about this showing up in releases? Is there a test-only pro Since there is no dependency from fe or executor-deps (or anything else that fe depends on), it shouldn't be on our classpath or ship in our docker image. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Thu, 07 Sep 2023 05:30:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9687/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 04:02:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Joe McDonnell has uploaded a new patch set (#3) to the change originally created by Steve Carlin. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424: Allow third party JniFrontend interface. This patch allows a third party to inject their own frontend class instead of using the default JniFrontend included in the project. The test case includes an interface that runs queries as normal except for the "select 1" query which gets changed to "select 42". Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 --- M be/src/service/frontend.cc M be/src/service/impala-http-handler.cc M bin/start-impala-cluster.py A java/external-frontend/pom.xml A java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java M java/pom.xml A tests/custom_cluster/test_external_planner.py 7 files changed, 194 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20459/3 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Joe McDonnell has uploaded a new patch set (#4) to the change originally created by Steve Carlin. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424: Allow third party JniFrontend interface. This patch allows a third party to inject their own frontend class instead of using the default JniFrontend included in the project. The test case includes an interface that runs queries as normal except for the "select 1" query which gets changed to "select 42". Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 --- M be/src/service/frontend.cc M bin/start-impala-cluster.py A java/external-frontend/pom.xml A java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java M java/pom.xml A tests/custom_cluster/test_external_planner.py 6 files changed, 191 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20459/4 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Code-Review+1 So sorry, was looking at this locally and got mixed up. Ignore the past couple uploads. Carrying Michael's +1. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 04:02:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: external-frontend > Since there is no dependency from fe or executor-deps (or anything else tha I built this locally and verified that the docker images don't contain it and the fe doesn't have it in build-classpath.txt or fe/target/dependency. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 04:23:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Code-Review+2 I think this is reasonable -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 04:24:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13947/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 04:25:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13948/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 04:27:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9687/ -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 08:26:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20459 to look at the new patch set (#5). Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424: Allow third party JniFrontend interface. This patch allows a third party to inject their own frontend class instead of using the default JniFrontend included in the project. The test case includes an interface that runs queries as normal except for the "select 1" query which gets changed to "select 42". Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 --- M be/src/service/frontend.cc M bin/start-impala-cluster.py A java/external-frontend/pom.xml A java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java M java/pom.xml A tests/custom_cluster/test_external_planner.py 6 files changed, 194 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/20459/5 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@87 PS2, Line 87: DEFINE_string(jni_frontend_class, "org/apache/impala/service/JniFrontend", "By default " > They'd need to override this on any impalad and catalogd instances, right? Done http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@89 PS2, Line 89: "This option allows the class to be overridden by a third party module."); > Nit: Should we say something about the specified class being a subclass of Does it have to be though? I think an implementor can reimplement all the methods specified in the JniMethodDescriptor class and then not derive from JniFrontend. But I'll add this as a "preferred usage" which probably makes sense. http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: external-frontend > Since there is no dependency from fe or executor-deps (or anything else tha Done http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: external-frontend > I built this locally and verified that the docker images don't contain it a Done -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Fri, 08 Sep 2023 14:03:50 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13956/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Fri, 08 Sep 2023 14:29:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@89 PS2, Line 89: "This option allows the class to be overridden by a third party module. Th > Does it have to be though? I think an implementor can reimplement all the You're right, it just needs to implement the appropriate methods. The new message looks good. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Fri, 08 Sep 2023 15:39:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 5: The test failure on the last precommit run doesn't look related to this patch. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Fri, 08 Sep 2023 15:40:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9691/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Fri, 08 Sep 2023 15:57:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Fri, 08 Sep 2023 15:57:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Fri, 08 Sep 2023 20:20:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424: Allow third party JniFrontend interface. This patch allows a third party to inject their own frontend class instead of using the default JniFrontend included in the project. The test case includes an interface that runs queries as normal except for the "select 1" query which gets changed to "select 42". Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Reviewed-on: http://gerrit.cloudera.org:8080/20459 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/service/frontend.cc M bin/start-impala-cluster.py A java/external-frontend/pom.xml A java/external-frontend/src/main/java/org/apache/impala/external/TestJniFrontend.java M java/pom.xml A tests/custom_cluster/test_external_planner.py 6 files changed, 194 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin
