[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. IMPALA-12756: [DOCS] Unicode column name support documentation The patch focuses on documenting that Impala supports unicode column names, consistent with Hive's current support (as we use Hive MetaStore to store table metadata). Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Reviewed-on: http://gerrit.cloudera.org:8080/20950 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M docs/topics/impala_identifiers.xml 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 14:00:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 13:51:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/384/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 13:51:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 5: > Patch Set 5: Code-Review+2 > > (1 comment) > > Carry Michael's +1. Sure, I've filed another jira for the same: https://issues.apache.org/jira/browse/IMPALA-12772 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 10:20:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 5: Code-Review+2 (1 comment) Carry Michael's +1. http://gerrit.cloudera.org:8080/#/c/20950/4/docs/topics/impala_identifiers.xml File docs/topics/impala_identifiers.xml: http://gerrit.cloudera.org:8080/#/c/20950/4/docs/topics/impala_identifiers.xml@62 PS4, Line 62: can start with any unicode cha > Yeah, it can. Should we cover it in the same jira or file it separately? We can do it in a separate DOC JIRA and also verify the the maximum length of other identifiers (e.g. db/table names). -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 09:04:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 5: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/748/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 09:05:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 5: (1 comment) > Patch Set 4: > > (2 comments) http://gerrit.cloudera.org:8080/#/c/20950/4/docs/topics/impala_identifiers.xml File docs/topics/impala_identifiers.xml: http://gerrit.cloudera.org:8080/#/c/20950/4/docs/topics/impala_identifiers.xml@62 PS4, Line 62: can start with any unicode cha > nit: This is talking about the first charactor. Let's use "can start with a Yeah, it can. Should we cover it in the same jira or file it separately? -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 08:56:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 5: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/748/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 08:56:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
pranav.lo...@cloudera.com has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. IMPALA-12756: [DOCS] Unicode column name support documentation The patch focuses on documenting that Impala supports unicode column names, consistent with Hive's current support (as we use Hive MetaStore to store table metadata). Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe --- M docs/topics/impala_identifiers.xml 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/20950/5 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml File docs/topics/impala_identifiers.xml: http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@54 PS2, Line 54: The maximum length of an identifier is currently 128 characters except for column names which > It's 767 characters for column names, the same is applied in hive. Ack. Double checked in Hive codes: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/resources/package.jdo#L24-L25 It's added in HIVE-1364. http://gerrit.cloudera.org:8080/#/c/20950/4/docs/topics/impala_identifiers.xml File docs/topics/impala_identifiers.xml: http://gerrit.cloudera.org:8080/#/c/20950/4/docs/topics/impala_identifiers.xml@62 PS4, Line 62: can contain unicode characters nit: This is talking about the first charactor. Let's use "can start with any unicode character". BTW, is it truth that column names can start with whitespaces? -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 07:47:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 4: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/747/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 06:45:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 3: Verified-1 Build Failed https://jenkins.impala.io/job/gerrit-docs-auto-test/746/ : Doc tests failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 06:39:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 4: (4 comments) > Uploaded patch set 4. http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml File docs/topics/impala_identifiers.xml: http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@54 PS2, Line 54: The maximum length of an identifier is currently 128 characters except for column names which > Could you double check this? What's the longest length we can used when usi It's 767 characters for column names, the same is applied in hive. http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@60 PS2, Line 60: > Add "except for column names which can start with unicode characters" Done http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@67 PS2, Line 67: > Add "except for column names which can contain unicode characters" Done http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@124 PS2, Line 124: > I think we'd better merge this into the previous items. Done -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 06:39:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 4: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/747/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 06:39:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
pranav.lo...@cloudera.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. IMPALA-12756: [DOCS] Unicode column name support documentation The patch focuses on documenting that Impala supports unicode column names, consistent with Hive's current support (as we use Hive MetaStore to store table metadata). Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe --- M docs/topics/impala_identifiers.xml 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/20950/4 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
pranav.lo...@cloudera.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. IMPALA-12756: [DOCS] Unicode column name support documentation The patch focuses on documenting that Impala supports unicode column names, consistent with Hive's current support (as we use Hive MetaStore to store table metadata). Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe --- M docs/topics/impala_identifiers.xml 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/20950/3 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/746/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 30 Jan 2024 06:34:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml File docs/topics/impala_identifiers.xml: http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@54 PS2, Line 54: The maximum length of an identifier is currently 128 characters, enforced by the metastore database. Could you double check this? What's the longest length we can used when using unicode column names? Each Chinese character is encoded into 3 bytes in UTF-8. In such case, is the maximun length for Chinese column names 128/3 = 42 characters, or still 128 characters? http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@60 PS2, Line 60: An identifier must start with an alphanumeric or underscore character Add "except for column names which can start with unicode characters" http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@67 PS2, Line 67: An identifier can contain only ASCII characters. Add "except for column names which can contain unicode characters" http://gerrit.cloudera.org:8080/#/c/20950/2/docs/topics/impala_identifiers.xml@124 PS2, Line 124: Impala column names can both contain and start with unicode characters. I think we'd better merge this into the previous items. -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 26 Jan 2024 01:24:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 25 Jan 2024 17:46:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/745/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 25 Jan 2024 10:49:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/745/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 25 Jan 2024 10:40:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
pranav.lo...@cloudera.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. IMPALA-12756: [DOCS] Unicode column name support documentation The patch focuses on documenting that Impala supports unicode column names, consistent with Hive's current support (as we use Hive MetaStore to store table metadata). Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe --- M docs/topics/impala_identifiers.xml 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/20950/2 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/744/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 25 Jan 2024 08:40:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
pranav.lo...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20950 Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. IMPALA-12756: [DOCS] Unicode column name support documentation The patch focuses on documenting that Impala supports unicode column names, consistent with Hive's current support (as we use Hive MetaStore to store table metadata). Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe --- M docs/topics/impala_identifiers.xml 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/20950/1 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-12756: [DOCS] Unicode column name support documentation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20950 ) Change subject: IMPALA-12756: [DOCS] Unicode column name support documentation .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/744/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/20950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d43d942a3ea069020f06adab6ea77e62ad5ffbe Gerrit-Change-Number: 20950 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Jan 2024 08:33:34 + Gerrit-HasComments: No
