[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Vincent Tran has abandoned this change. ( http://gerrit.cloudera.org:8080/11383 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Abandoned Abandoned for now until I have more time to reevaluate. -- To view, visit http://gerrit.cloudera.org:8080/11383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I82e51e8cd2f6a77c588914242684b885816aa0a0 Gerrit-Change-Number: 11383 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11383 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/11383/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11383/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-6758: Add metric for current catalog version to catalog nit: update the message appropriately http://gerrit.cloudera.org:8080/#/c/11383/2//COMMIT_MSG@11 PS2, Line 11: age I think maybe 'lag' would be better here, since I would consider the "age" of the catalog to be something like the uptime http://gerrit.cloudera.org:8080/#/c/11383/2/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/11383/2/be/src/service/impala-server.h@1047 PS2, Line 1047: int64_t catalog_age; I think the variable name should include the units (is this seconds, millis, micros, etc). Perhaps the metric itself should also include units? http://gerrit.cloudera.org:8080/#/c/11383/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/11383/2/be/src/service/impala-server.cc@1463 PS2, Line 1463: ImpaladMetrics::CATALOG_AGE->SetValue(catalog_age); we should think about how we want to handle negative age -- it's possible if the clocks are slightly out of sync. Maybe we should clamp to zero? Or we should document in the description of the metric that this metric's accuracy relies on wall clock synchronization, and a negative value indicates some potential for lag? http://gerrit.cloudera.org:8080/#/c/11383/2/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/11383/2/common/thrift/CatalogObjects.thrift@593 PS2, Line 593: // The genesis time of the catalog object. The comment and the name of the field should be clearer as to units and reference point (is this seconds since unix epoch?) Also I think the word "genesis" might be a little too fancy, maybe it would be clearer to say something like "publish_timestamp"? http://gerrit.cloudera.org:8080/#/c/11383/2/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/11383/2/common/thrift/Frontend.thrift@717 PS2, Line 717: 4: optional i64 catalog_age same naming concerns as elsewhere http://gerrit.cloudera.org:8080/#/c/11383/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/11383/2/common/thrift/metrics.json@213 PS2, Line 213: elapsed time should this say "in seconds" or does the units below already make it clear? I'm not sure how this JSON is consumed. http://gerrit.cloudera.org:8080/#/c/11383/2/common/thrift/metrics.json@217 PS2, Line 217: The elapsed time since the last consumed catalog update was created I think the label is supposed to be something shorter http://gerrit.cloudera.org:8080/#/c/11383/2/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java File fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java: http://gerrit.cloudera.org:8080/#/c/11383/2/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java@163 PS2, Line 163: long newCatalogGenesis = lastSyncedCatalogGenesis_; is it worth tracking this state? it seems it's only necessary to prevent backward movement, but this whole thing is just for a metric anyway, so backward movement isn't the end of the world. http://gerrit.cloudera.org:8080/#/c/11383/2/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java@225 PS2, Line 225: res.setCatalog_age(elapsedTime); calculating the age here implies that it only gets re-calculated when updates are received. If you were to kill -STOP the statestore, I think you'd find that no updates are getting sent to the catalog, and then the metric would freeze instead of creep up, no? I think you need to publish back the timestamp to the backend so that it can recalculate the lag either periodically or "on demand" when the metric is fetched http://gerrit.cloudera.org:8080/#/c/11383/2/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/11383/2/tests/webserver/test_web_pages.py@228 PS2, Line 228: def test_catalog_age_metric(self): perhaps we can have a more thorough test that does a kill -STOP on the statestore, and watches to make sure the catalog age actually increases after 5-10 seconds? -- To view, visit http://gerrit.cloudera.org:8080/11383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82e51e8cd2f6a77c588914242684b885816aa0a0 Gerrit-Change-Number: 11383 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11383 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/571/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82e51e8cd2f6a77c588914242684b885816aa0a0 Gerrit-Change-Number: 11383 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 04 Sep 2018 16:26:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11383 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/570/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82e51e8cd2f6a77c588914242684b885816aa0a0 Gerrit-Change-Number: 11383 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 04 Sep 2018 16:16:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11383 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11383/1/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java File fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java: http://gerrit.cloudera.org:8080/#/c/11383/1/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java@218 PS1, Line 218: CatalogObjectVersionSet.INSTANCE.getMinimumVersion(), newCatalogVersion); tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/11383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82e51e8cd2f6a77c588914242684b885816aa0a0 Gerrit-Change-Number: 11383 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 04 Sep 2018 16:07:50 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Hello Lars Volker, Tianyi Wang, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11383 to look at the new patch set (#2). Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. IMPALA-6758: Add metric for current catalog version to catalog This change adds a new metric to the impalad web UI under the MetricGroup catalog: - catalog.age It tracks the elapsed time since the last consumed catalog topic update was generated. Testing: * Manually verified that the metric displays in the impalad web UI and that it displays the expected age of the consumed catalog topic update. * Added a web server e2e test to verify that the impalad web UI returns a /metrics page containing the new metric name. Change-Id: I82e51e8cd2f6a77c588914242684b885816aa0a0 --- M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/util/impalad-metrics.cc M be/src/util/impalad-metrics.h M common/thrift/CatalogObjects.thrift M common/thrift/Frontend.thrift M common/thrift/metrics.json M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M tests/webserver/test_web_pages.py 10 files changed, 50 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/11383/2 -- To view, visit http://gerrit.cloudera.org:8080/11383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I82e51e8cd2f6a77c588914242684b885816aa0a0 Gerrit-Change-Number: 11383 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Vincent Tran has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11383 Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. IMPALA-6758: Add metric for current catalog version to catalog This change adds a new metric to the impalad web UI under the MetricGroup catalog: - catalog.age It tracks the elapsed time since the last consumed catalog topic update was generated. Testing: * Manually verified that the metric displays in the impalad web UI and that it displays the expected age of the consumed catalog topic update. * Added a web server e2e test to verify that the impalad web UI returns a /metrics page containing the new metric name. Change-Id: I82e51e8cd2f6a77c588914242684b885816aa0a0 --- M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/util/impalad-metrics.cc M be/src/util/impalad-metrics.h M common/thrift/CatalogObjects.thrift M common/thrift/Frontend.thrift M common/thrift/metrics.json M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M tests/webserver/test_web_pages.py 10 files changed, 50 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/11383/1 -- To view, visit http://gerrit.cloudera.org:8080/11383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I82e51e8cd2f6a77c588914242684b885816aa0a0 Gerrit-Change-Number: 11383 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Tran
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Vincent Tran has abandoned this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Abandoned Abandoning after discussing with Todd and Lars. We are now in favor of tracking a "time since last catalog update" metric on the individual impala daemons. -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 3: I checked commit 572af614d6d2af21dc4d261a3c53ed9b2b05c833 for some precedence and it looks like the distinction between the version set by the catalog and the version that statestore operates on is made by appending the "Catalog" or "Statestore" in front of "topic version", i.e.: "Catalog topic update version" and "Statestore topic update version" respectively. For the sake of consistency, we can follow this same naming pattern without any objection. -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 27 Aug 2018 15:32:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 3: (1 comment) > (1 comment) > > I'm curious: what's the motivation for exposing this as a metric? > Why would the operator want to monitor it? The original motivation stemmed from IMPALA-6075 where I user had to investigate a metadata inconsistency issue. I think it makes sense to expose the metric in all three main daemons to be used via monitoring tools / infrastructure in this scenario. http://gerrit.cloudera.org:8080/#/c/11293/3/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/11293/3/be/src/catalog/catalog-server.cc@185 PS3, Line 185: current_catalog_version_metric_ = catalog_metrics->AddGauge : (CATALOG_CURRENT_TOPIC_VERSION > can you clarify which version this is? Confusingly there are two versions f Yes. I see the ambiguity. This should be the current catalog version set by the catalog. I think my earlier concern was that the existing metric catalog.version - which stores the version string of the Catalog Server - can cause some confusion if this new metric was named catalog-server.current-catalog-version. -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 27 Aug 2018 12:47:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Fri, 24 Aug 2018 20:58:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/465/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 23 Aug 2018 18:57:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/463/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 23 Aug 2018 18:41:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Hello Pranay Singh, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11293 to look at the new patch set (#3). Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. IMPALA-6758: Add metric for current catalog version to catalog This change adds a new metric to the catalogd web UI under the logical MetricGroup catalog-server: - catalog-server.current-topic-version As per its namesake, it tracks the current topic version as per the catalogd. Testing: * Manually verified that the metric displays in the catalogd web UI and that it displays the expected version number. * Added a web server e2e test to verify that the catalogd web UI returns a /metrics page containing the new metric name. Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 --- M be/src/catalog/catalog-server.cc M be/src/catalog/catalog-server.h M common/thrift/metrics.json M tests/webserver/test_web_pages.py 4 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/11293/3 -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 2: FYI: Several of the e2e tests in tests/webserver/test_web_pages.py are failing on the master branch when I ran them locally. -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 23 Aug 2018 18:13:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11293/2/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/11293/2/tests/webserver/test_web_pages.py@213 PS2, Line 213: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/11293/2/tests/webserver/test_web_pages.py@215 PS2, Line 215: T flake8: E501 line too long (97 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 23 Aug 2018 18:11:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Hello Pranay Singh, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11293 to look at the new patch set (#2). Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. IMPALA-6758: Add metric for current catalog version to catalog This change adds a new metric to the catalogd web UI under the logical MetricGroup catalog-server: - catalog-server.current-topic-version As per its namesake, it tracks the current topic version as per the catalogd. Testing: * Manually verified that the metric displays in the catalogd web UI and that it displays the expected version number. * Added a web server e2e test to verify that the catalogd web UI returns a /metrics page containing the new metric name. Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 --- M be/src/catalog/catalog-server.cc M be/src/catalog/catalog-server.h M common/thrift/metrics.json M tests/webserver/test_web_pages.py 4 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/11293/2 -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/451/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 22 Aug 2018 16:06:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog
Vincent Tran has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11293 Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. IMPALA-6758: Add metric for current catalog version to catalog This change adds a new metric to the catalogd web UI: - catalog-server.current-topic-version As per its namesake, it tracks the current topic version as per the catalogd. Testing: Manually verified that the metric displays in the catalogd web UI and that it displays the expected version number. Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 --- M be/src/catalog/catalog-server.cc M be/src/catalog/catalog-server.h M common/thrift/metrics.json 3 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/11293/1 -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Tran
