[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 18 Jul 2018 03:14:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE In DESCRIBE DATABASE, having VIEW_METADATA privilege allows seeing the metadata information on the target database. Similarly, other SQL show commands require VIEW_METADATA privilege on the target database/table. In the prior code, DESCRIBE requires SELECT privilege on the target table and is inconsistent with the rest of other SQL metadata commands. The patch fixes the inconsistency by requiring DESCRIBE to use VIEW_METADATA privilege. Testing: - Updated authorization tests - Ran all FE tests Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Reviewed-on: http://gerrit.cloudera.org:8080/10923 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java 2 files changed, 26 insertions(+), 34 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 23:55:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2829/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 23:55:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 23:52:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE In DESCRIBE DATABASE, having VIEW_METADATA privilege allows seeing the metadata information on the target database. Similarly, other SQL show commands require VIEW_METADATA privilege on the target database/table. In the prior code, DESCRIBE requires SELECT privilege on the target table and is inconsistent with the rest of other SQL metadata commands. The patch fixes the inconsistency by requiring DESCRIBE to use VIEW_METADATA privilege. Testing: - Updated authorization tests - Ran all FE tests Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f --- M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java 2 files changed, 26 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/10923/3 -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10923/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10923/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1065 PS2, Line 1065: checkStrings = > doesn't look like this is used any longer except for L1066 (next line). inl Done http://gerrit.cloudera.org:8080/#/c/10923/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1076 PS2, Line 1076: > why is this null now? perhaps clarify with a comment. Done -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 23:48:59 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10923/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10923/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1065 PS2, Line 1065: locationString doesn't look like this is used any longer except for L1066 (next line). inline? http://gerrit.cloudera.org:8080/#/c/10923/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1076 PS2, Line 1076: null why is this null now? perhaps clarify with a comment. -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 23:36:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 11 Jul 2018 19:58:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE In DESCRIBE DATABASE, having VIEW_METADATA privilege allows seeing the metadata information on the target database. Similarly, other SQL show commands require VIEW_METADATA privilege on the target database/table. In the prior code, DESCRIBE requires SELECT privilege on the target table and is inconsistent with the rest of other SQL metadata commands. The patch fixes the inconsistency by requiring DESCRIBE to use VIEW_METADATA privilege. Testing: - Updated authorization tests - Ran all FE tests Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f --- M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java 2 files changed, 23 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/10923/2 -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1059 PS1, Line 1059: SEL > I think this should stay SELECT since that is the only privilege we allow o Done http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1086 PS1, Line 1086: SEL > Same as above Done http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1134 PS1, Line 1134: SEL > same as above Done http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1145 PS1, Line 1145: SEL > same as above Done -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 11 Jul 2018 19:40:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1059 PS1, Line 1059: ALL I think this should stay SELECT since that is the only privilege we allow on columns. If we're looking to future proof, then it should just be the metadata privileges. http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1086 PS1, Line 1086: ALL Same as above http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1134 PS1, Line 1134: ALL same as above http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1145 PS1, Line 1145: ALL same as above -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 11 Jul 2018 19:25:22 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10923 Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE In DESCRIBE DATABASE, having VIEW_METADATA privilege allows seeing the metadata information on the target database. Similarly, other SQL show commands require VIEW_METADATA privilege on the target database/table. In the prior code, DESCRIBE requires SELECT privilege on the target table and is inconsistent with the rest of other SQL metadata commands. The patch fixes the inconsistency by requiring DESCRIBE to use VIEW_METADATA privilege. Testing: - Updated authorization tests - Ran all FE tests Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f --- M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java 2 files changed, 27 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/10923/1 -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya
