[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Thomas Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/13248 ) Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. Abandoned see https://gerrit.cloudera.org/#/c/13318/ -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 ) Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. Patch Set 3: I think this was folded into another patch: https://gerrit.cloudera.org/c/13318/4/testdata/cluster/node_templates/common/etc/init.d/kudu-master -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Wed, 22 May 2019 02:33:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/13248 )
Change subject: IMPALA-8503: add option to start Kudu cluster with HMS
integration
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin
File testdata/cluster/admin:
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@497
PS1, Line 497: function restart {
: if [[ $# -ne 1 ]]; then
: echo restart must be called with a single argument -- the
service to restart. 1>&2
: exit 1
: fi
: local SERVICE=$1
: stop $SERVICE
: start $SERVICE
: }
:
: function delete_data {
: # Delete namenode, datanode and KMS data while preserving
directory structure.
: rm -rf "$NODES_DIR/$NODE_PREFIX"*/data/dfs/{nn,dn}/*
: rm -f "$NODES_DIR/$NODE_PREFIX"*/data/kms.keystore
: delete_kudu_data
: }
> Yeah, I verified. What is the confusing point?
The confusing piece for me was that restart_with_arg() could take an additional
argument, but restart() doesn't seem to propagate it. Basically, I could not
find where restart_with_arg() is used with two arguments.
--
To view, visit http://gerrit.cloudera.org:8080/13248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2
Gerrit-Change-Number: 13248
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Comment-Date: Tue, 21 May 2019 18:45:06 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 ) Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13248/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13248/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-8503: add option to start Kudu cluster with HMS integration > Like I said before, its difficult to evaluate this patch without seeing how Sure, I can move it to the CREATE TABLE patch. My initial intention is to avoid large patch, and want to separate the patches based on the functionality. http://gerrit.cloudera.org:8080/#/c/13248/3/testdata/cluster/node_templates/common/etc/init.d/kudu-master File testdata/cluster/node_templates/common/etc/init.d/kudu-master: http://gerrit.cloudera.org:8080/#/c/13248/3/testdata/cluster/node_templates/common/etc/init.d/kudu-master@28 PS3, Line 28: if [[ -n "$ENABLE_KUDU_HMS_INTEGRATION" ]]; then > I think its better if this is more generic, eg. call the env variable IMPAL Done -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Mon, 20 May 2019 06:28:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 ) Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13248/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13248/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-8503: add option to start Kudu cluster with HMS integration Like I said before, its difficult to evaluate this patch without seeing how it would actually be used. Especially now that its so short, I think you would be better off just merging it with the other patch you have out that uses this functionality http://gerrit.cloudera.org:8080/#/c/13248/3/testdata/cluster/node_templates/common/etc/init.d/kudu-master File testdata/cluster/node_templates/common/etc/init.d/kudu-master: http://gerrit.cloudera.org:8080/#/c/13248/3/testdata/cluster/node_templates/common/etc/init.d/kudu-master@28 PS3, Line 28: if [[ -n "$ENABLE_KUDU_HMS_INTEGRATION" ]]; then I think its better if this is more generic, eg. call the env variable IMPALA_KUDU_STARTUP_FLAGS and then when you want to enable HMS integration you can set that to the '-hive_metastore_uris=...' value. That way in the future other people can take advantage of it for other tests. -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 17 May 2019 16:45:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 ) Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3259/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 17 May 2019 06:36:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Hello Thomas Marshall, Alexey Serbin, Andrew Wong, Adar Dembo, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13248 to look at the new patch set (#3). Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. IMPALA-8503: add option to start Kudu cluster with HMS integration Currently static template configuration under testdata/cluster/ is used to control Kudu gflags when starting a Kudu cluster. An option to allow custom configuration such as enabling HMS integration is needed to allow tests to run with Kudu clusters with different set of configurations. This commit introduces a new environment variable 'ENABLE_KUDU_HMS_INTEGRATION' to allow starting Kudu master with HMS integration enabled when this variable is set. Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 --- M testdata/cluster/node_templates/common/etc/init.d/kudu-master 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/13248/3 -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/13248 )
Change subject: IMPALA-8503: add option to start Kudu cluster with HMS
integration
..
Patch Set 3:
(4 comments)
> (6 comments)
>
> I don't have enough context for high-level review of this
> changelist, but it seems the comment that Thomas added makes sense.
>
> Also, what is the way to configure the way how services started via
> these scripts? I know that in case of UNIX init.d scripts there
> are configuration files in /etc that are picked up by the scripts.
> Using environment variables makes it look like something similar to
> that approach.
Ok, since both of you think using env is better, I updated the patch
accordingly. Thanks!
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin
File testdata/cluster/admin:
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@425
PS1, Line 425:
> drop
Done
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@427
PS1, Line 427:
> drop
Done
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@428
PS1, Line 428: M
> drop
Done
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@497
PS1, Line 497: function restart {
: if [[ $# -ne 1 ]]; then
: echo restart must be called with a single argument -- the
service to restart. 1>&2
: exit 1
: fi
: local SERVICE=$1
: stop $SERVICE
: start $SERVICE
: }
:
: function delete_data {
: # Delete namenode, datanode and KMS data while preserving
directory structure.
: rm -rf "$NODES_DIR/$NODE_PREFIX"*/data/dfs/{nn,dn}/*
: rm -f "$NODES_DIR/$NODE_PREFIX"*/data/kms.keystore
: delete_kudu_data
: }
> Did you verify this works as expected? I'm a bit confused about check at L
Yeah, I verified. What is the confusing point?
--
To view, visit http://gerrit.cloudera.org:8080/13248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2
Gerrit-Change-Number: 13248
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Comment-Date: Fri, 17 May 2019 05:57:32 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/13248 )
Change subject: IMPALA-8503: add option to start Kudu cluster with HMS
integration
..
Patch Set 1:
(6 comments)
I don't have enough context for high-level review of this changelist, but it
seems the comment that Thomas added makes sense.
Also, what is the way to configure the way how services started via these
scripts? I know that in case of UNIX init.d scripts there are configuration
files in /etc that are picked up by the scripts. Using environment variables
makes it look like something similar to that approach.
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin
File testdata/cluster/admin:
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@425
PS1, Line 425: ;
drop
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@427
PS1, Line 427: ;
drop
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@428
PS1, Line 428: ;
drop
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@497
PS1, Line 497: function restart {
: if [[ $# -ne 1 ]]; then
: echo restart must be called with a single argument -- the
service to restart. 1>&2
: exit 1
: fi
: local SERVICE=$1
: restart_with_arg $SERVICE
: }
:
: function restart_with_arg {
: local SERVICE=$1
: shift
: local ARG="${1:-}"
: stop $SERVICE
: start_with_arg $SERVICE $ARG
: }
Did you verify this works as expected? I'm a bit confused about check at L498
and the code at L508-L509?
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/node_templates/common/etc/init.d/kudu-master
File testdata/cluster/node_templates/common/etc/init.d/kudu-master:
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/node_templates/common/etc/init.d/kudu-master@31
PS1, Line 31: :9083
nit: if that's the default and cannot be configured, maybe drop it?
http://gerrit.cloudera.org:8080/#/c/13248/2/testdata/cluster/node_templates/common/etc/init.d/kudu-master
File testdata/cluster/node_templates/common/etc/init.d/kudu-master:
http://gerrit.cloudera.org:8080/#/c/13248/2/testdata/cluster/node_templates/common/etc/init.d/kudu-master@32
PS2, Line 32: ;
nit: drop
--
To view, visit http://gerrit.cloudera.org:8080/13248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2
Gerrit-Change-Number: 13248
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Comment-Date: Tue, 14 May 2019 00:55:00 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/13248 )
Change subject: IMPALA-8503: add option to start Kudu cluster with HMS
integration
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/node_templates/common/etc/init.d/kudu-master
File testdata/cluster/node_templates/common/etc/init.d/kudu-master:
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/node_templates/common/etc/init.d/kudu-master@31
PS1, Line 31:
KUDU_COMMON_ARGS+=("-hive_metastore_uris=thrift://${INTERNAL_LISTEN_HOST}:9083")
> Instead of doing all of the work of piping an argument all the way through
Yeah, I separated the patches to be one for adding the option to start with HMS
integration and the ones actually using it. Because I think it might be clearer
and simpler to review.
I can see adding an env variable seems to be a bit easier in terms of code
changes to the start script, but it requires extra work of setting the variable
in the test cases (and it will affect all consumers of the variable). I don't
have strong opinion to choose one from the other. So I will keep it the way it
is unless you feel otherwise.
--
To view, visit http://gerrit.cloudera.org:8080/13248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2
Gerrit-Change-Number: 13248
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Comment-Date: Mon, 13 May 2019 06:41:01 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 ) Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3089/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Mon, 06 May 2019 23:01:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Thomas Marshall has posted comments on this change. (
http://gerrit.cloudera.org:8080/13248 )
Change subject: IMPALA-8503: add option to start Kudu cluster with HMS
integration
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/node_templates/common/etc/init.d/kudu-master
File testdata/cluster/node_templates/common/etc/init.d/kudu-master:
http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/node_templates/common/etc/init.d/kudu-master@31
PS1, Line 31:
KUDU_COMMON_ARGS+=("-hive_metastore_uris=thrift://${INTERNAL_LISTEN_HOST}:9083")
Instead of doing all of the work of piping an argument all the way through
testdata/cluster/admin and having this logic here, I wonder if it would be
easier just to add an env variable like EXTRA_KUDU_STARTUP_ARGS or whatever
that if its set we always just append it to KUDU_COMMON_ARGS here.
It also doesn't look like this patch actually uses the functionality that
you've added here, unless I'm missing something. It might be easier for
reviewers to understand how you intend for this to work if you include it in a
patch along with a test that actually exercises this functionality
--
To view, visit http://gerrit.cloudera.org:8080/13248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2
Gerrit-Change-Number: 13248
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Comment-Date: Mon, 06 May 2019 22:20:17 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 ) Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/3087/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Mon, 06 May 2019 21:59:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13248 Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. IMPALA-8503: add option to start Kudu cluster with HMS integration Currently static template configuration under testdata/cluster/ is used to control Kudu gflags when starting a Kudu cluster. An option to allow custom configuration such as enabling HMS integration is needed to allow tests to run with Kudu clusters with different set of configurations. This commit updates 'cluster/admin' script to start a cluster with argument. And adds an option to 'kudu-master' script to allow starting Kudu master with HMS integration using command `admin start_with_arg kudu hms`. Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 --- M testdata/cluster/admin M testdata/cluster/node_templates/common/etc/init.d/kudu-master 2 files changed, 33 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/13248/1 -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao
