[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 01 May 2018 20:40:27 +
Gerrit-HasComments: No

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java 7 can result in some obscure error messages.
This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

   Your development environment is configured for Hadoop 3 and Java 7.
   Hadoop 3 requires at least Java 8. Your JAVA binary currently points
   to /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the
   following version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

It also catches failure of the minicluster start and prints an
additional warning when running with Hadoop 3 and Java 7.

Cherry-picks: not for 2.x

Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Reviewed-on: http://gerrit.cloudera.org:8080/10244
Reviewed-by: Michael Brown 
Tested-by: Impala Public Jenkins 
---
M bin/impala-config.sh
M testdata/bin/run-mini-dfs.sh
2 files changed, 35 insertions(+), 0 deletions(-)

Approvals:
  Michael Brown: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2390/


--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 01 May 2018 16:35:12 +
Gerrit-HasComments: No

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 3:

Thanks for the reviews!


--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 01 May 2018 16:35:18 +
Gerrit-HasComments: No

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 01 May 2018 16:31:08 +
Gerrit-HasComments: No

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10244/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10244/2//COMMIT_MSG@24
PS2, Line 24:
> Please add: "Cherry-picks: not for 2.x"
Done



--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 01 May 2018 16:27:42 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Hello Michael Brown, Philip Zeyliger, Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10244

to look at the new patch set (#3).

Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java 7 can result in some obscure error messages.
This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

   Your development environment is configured for Hadoop 3 and Java 7.
   Hadoop 3 requires at least Java 8. Your JAVA binary currently points
   to /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the
   following version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

It also catches failure of the minicluster start and prints an
additional warning when running with Hadoop 3 and Java 7.

Cherry-picks: not for 2.x

Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
---
M bin/impala-config.sh
M testdata/bin/run-mini-dfs.sh
2 files changed, 35 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/10244/3
--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10244/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10244/2//COMMIT_MSG@24
PS2, Line 24:
Please add: "Cherry-picks: not for 2.x"



--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 01 May 2018 15:48:59 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Joe McDonnell (Code Review)]

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 2: Code-Review+2

This looks reasonable to me.


--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 22:38:50 +
Gerrit-HasComments: No

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh@224
PS1, Line 224:
 :   # Check for minimum required Java version
 :   # Only issue Java version warning when running Java 7.
 :   if $JAVA -version 2>&1 | grep -q 'java version "1.7'; then
 : cat << EOF
 :
 : Your development environment is configured for Hadoop 3 and Java 
7. Hadoop 3 requires at
 : least Java 8. Your JAVA binary currently points to $JAVA
 : and reports the following version:
 :
 : EOF
 : $JAVA -version
 : echo
 :   fi
> If we are warning rather than exiting, then it would be useful to have this
Done



--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:40:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Hello Michael Brown, Philip Zeyliger, Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10244

to look at the new patch set (#2).

Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java 7 can result in some obscure error messages.
This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

   Your development environment is configured for Hadoop 3 and Java 7.
   Hadoop 3 requires at least Java 8. Your JAVA binary currently points
   to /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the
   following version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

It also catches failure of the minicluster start and prints an
additional warning when running with Hadoop 3 and Java 7.

Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
---
M bin/impala-config.sh
M testdata/bin/run-mini-dfs.sh
2 files changed, 35 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/10244/2
--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Joe McDonnell (Code Review)]

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10244 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh@224
PS1, Line 224:
 :   # Check for minimum required Java version
 :   # Only issue Java version warning when running Java 7.
 :   if $JAVA -version 2>&1 | grep -q 'java version "1.7'; then
 : cat << EOF
 :
 : Your development environment is configured for Hadoop 3 and Java 
7. Hadoop 3 requires at
 : least Java 8. Your JAVA binary currently points to $JAVA
 : and reports the following version:
 :
 : EOF
 : $JAVA -version
 : echo
 :   fi
If we are warning rather than exiting, then it would be useful to have this be 
the last thing that a user would see. I think we do a bunch of prints down 
below that would push this off the terminal screen.



--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Mon, 30 Apr 2018 18:38:02 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Lars Volker has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10244


Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java 7 can result in some obscure error messages.
This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

   Your development environment is configured for Hadoop 3 and Java 7.
   Hadoop 3 requires at least Java 8. Your JAVA binary currently points
   to /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the
   following version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

It also catches failure of the minicluster start and prints an
additional warning when running with Hadoop 3 and Java 7.

Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
---
M bin/impala-config.sh
M testdata/bin/run-mini-dfs.sh
2 files changed, 33 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/10244/1
--
To view, visit http://gerrit.cloudera.org:8080/10244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb
Gerrit-Change-Number: 10244
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10222 )

Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java 7 can result in some obscure error messages.
This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

   Your development environment is configured for Hadoop 3 and Java 7.
   Hadoop 3 requires at least Java 8. Your JAVA binary currently points
   to /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the
   following version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Reviewed-on: http://gerrit.cloudera.org:8080/10222
Reviewed-by: Joe McDonnell 
Tested-by: Impala Public Jenkins 
---
M bin/impala-config.sh
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10222 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 6: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Sat, 28 Apr 2018 01:55:44 +
Gerrit-HasComments: No

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10222 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2379/


--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Fri, 27 Apr 2018 21:45:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Joe McDonnell (Code Review)]

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10222 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 6: Code-Review+2

Thanks for making this change


--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Fri, 27 Apr 2018 19:45:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10222 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 4:

(1 comment)

Updated the commit message in PS5, rebased in PS6. Do you want to have a final 
look?

http://gerrit.cloudera.org:8080/#/c/10222/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10222/4//COMMIT_MSG@11
PS4, Line 11: This change adds a warning to impala-config.sh when using Hadoop 
3 with
: Java 7.
:
: It also catches failure of the minicluster start and prints an
: additional warning when running with Hadoop 3 and Java 7.
:
:Start of the minicluster failed. If the error looks similar to
:"Unsupported major.minor version 52.0", make sure you are 
running at
:least Java 8.
:Your JAVA binary currently points to
:/usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the 
following
:version:
:
:java version "1.7.0_75"
:Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
:Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)
> Update this message to reflect removal of minicluster check.
Done



--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Fri, 27 Apr 2018 19:11:11 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Hello Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10222

to look at the new patch set (#6).

Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java 7 can result in some obscure error messages.
This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

   Your development environment is configured for Hadoop 3 and Java 7.
   Hadoop 3 requires at least Java 8. Your JAVA binary currently points
   to /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the
   following version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
---
M bin/impala-config.sh
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10222/6
--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Hello Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10222

to look at the new patch set (#5).

Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java 7 can result in some obscure error messages.
This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

   Your development environment is configured for Hadoop 3 and Java 7.
   Hadoop 3 requires at least Java 8. Your JAVA binary currently points
   to /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the
   following version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
---
M bin/impala-config.sh
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10222/5
--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Joe McDonnell (Code Review)]

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10222 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 4:

(1 comment)

This looks good to me once you fix the commit message.

http://gerrit.cloudera.org:8080/#/c/10222/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10222/4//COMMIT_MSG@11
PS4, Line 11: This change adds a warning to impala-config.sh when using Hadoop 
3 with
: Java 7.
:
: It also catches failure of the minicluster start and prints an
: additional warning when running with Hadoop 3 and Java 7.
:
:Start of the minicluster failed. If the error looks similar to
:"Unsupported major.minor version 52.0", make sure you are 
running at
:least Java 8.
:Your JAVA binary currently points to
:/usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the 
following
:version:
:
:java version "1.7.0_75"
:Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
:Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)
Update this message to reflect removal of minicluster check.



--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Thu, 26 Apr 2018 22:50:04 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10222 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10222/2/testdata/bin/run-mini-dfs.sh
File testdata/bin/run-mini-dfs.sh:

http://gerrit.cloudera.org:8080/#/c/10222/2/testdata/bin/run-mini-dfs.sh@42
PS2, Line 42: if [[ $? != 0 ]]; then
:   # Don't issue Java version warning when not running Hadoop 3.
:   [[ $IMPALA_MINICLUSTER_PROFILE != 3 ]] && exit 1
> The impala-config.sh check would protect buildall.sh cases. It also protect
Done



--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Thu, 26 Apr 2018 22:25:35 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Hello Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10222

to look at the new patch set (#4).

Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java can result in some obscure error messages.

This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

It also catches failure of the minicluster start and prints an
additional warning when running with Hadoop 3 and Java 7.

   Start of the minicluster failed. If the error looks similar to
   "Unsupported major.minor version 52.0", make sure you are running at
   least Java 8.
   Your JAVA binary currently points to
   /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the following
   version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
---
M bin/impala-config.sh
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10222/4
--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Joe McDonnell (Code Review)]

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10222 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10222/2/testdata/bin/run-mini-dfs.sh
File testdata/bin/run-mini-dfs.sh:

http://gerrit.cloudera.org:8080/#/c/10222/2/testdata/bin/run-mini-dfs.sh@42
PS2, Line 42: if [[ $? != 0 ]]; then
:   # Don't issue Java version warning when not running Hadoop 3.
:   [[ $IMPALA_MINICLUSTER_PROFILE != 3 ]] && exit 1
> Good idea. Should we remove the check here then?
The impala-config.sh check would protect buildall.sh cases. It also protects 
any new checkouts using master. Any new session would be protected. I think 
this check would only catch a few other cases, so I would be comfortable 
removing it.



--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Thu, 26 Apr 2018 21:44:19 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10222 )

Change subject: Warn about Hadoop / Java version incompatibility
..


Patch Set 2:

(1 comment)

Added a check to impala-config.sh in PS3.

http://gerrit.cloudera.org:8080/#/c/10222/2/testdata/bin/run-mini-dfs.sh
File testdata/bin/run-mini-dfs.sh:

http://gerrit.cloudera.org:8080/#/c/10222/2/testdata/bin/run-mini-dfs.sh@42
PS2, Line 42: if [[ $? != 0 ]]; then
:   # Don't issue Java version warning when not running Hadoop 3.
:   [[ $IMPALA_MINICLUSTER_PROFILE != 3 ]] && exit 1
> It might also make sense to check the Java version in bin/impala-config.sh
Good idea. Should we remove the check here then?



--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Thu, 26 Apr 2018 18:51:27 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

[Lars Volker (Code Review)]

Hello Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10222

to look at the new patch set (#3).

Change subject: Warn about Hadoop / Java version incompatibility
..

Warn about Hadoop / Java version incompatibility

Running Hadoop 3 with Java can result in some obscure error messages.

This change adds a warning to impala-config.sh when using Hadoop 3 with
Java 7.

It also catches failure of the minicluster start and prints an
additional warning when running with Hadoop 3 and Java 7.

   Start of the minicluster failed. If the error looks similar to
   "Unsupported major.minor version 52.0", make sure you are running at
   least Java 8.
   Your JAVA binary currently points to
   /usr/lib/jvm/java-7-oracle-amd64/bin/java and reports the following
   version:

   java version "1.7.0_75"
   Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
   Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
---
M bin/impala-config.sh
M testdata/bin/run-mini-dfs.sh
2 files changed, 34 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10222/3
--
To view, visit http://gerrit.cloudera.org:8080/10222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd
Gerrit-Change-Number: 10222
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Joe McDonnell