[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/13185/7/bin/set-classpath.sh File bin/set-classpath.sh: http://gerrit.cloudera.org:8080/#/c/13185/7/bin/set-classpath.sh@39 PS7, Line 39: exit 1 > This file is usually sourced, not executed. Calling exit here will exit the Addressed here: https://gerrit.cloudera.org/c/13391/ -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 21 May 2019 19:15:04 + Gerrit-HasComments: Yes
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/13185/7/bin/set-classpath.sh File bin/set-classpath.sh: http://gerrit.cloudera.org:8080/#/c/13185/7/bin/set-classpath.sh@39 PS7, Line 39: exit 1 This file is usually sourced, not executed. Calling exit here will exit the surrounding shell. -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 21 May 2019 16:57:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. fe: set classpath using maven dependency resolution This changes the FE pom to generate a build classpath file in the target/ directory. Then, bin/set-classpath.sh uses this file to generate the classpath to start the cluster. This replaces the former approach of including all of the jars found in target/dependency/ The advantage of this is that a clean build is no longer required when switching artifact versions. Prior to this patch, if you changed an artifact version and rebuilt, both the old and new artifact would be left in the target/dependency/ directory and pollute the classpath. This doesn't fully remove the target/dependency/ directory, because its existence is likely important for downstream packaging of Impala. We can likely assume that such packaging always does a clean build. This also changes the set-classpath script to no longer load jars from testdata/target/dependency/ since it appears that directory doesn't actually get created during the build. Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Reviewed-on: http://gerrit.cloudera.org:8080/13185 Tested-by: Impala Public Jenkins Reviewed-by: Todd Lipcon --- M bin/set-classpath.sh M docker/setup_build_context.py M fe/pom.xml 3 files changed, 36 insertions(+), 16 deletions(-) Approvals: Impala Public Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 6: Code-Review+2 Forwarding +2 -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 14 May 2019 18:23:24 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 14 May 2019 00:12:06 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4240/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 13 May 2019 18:58:00 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Todd Lipcon has removed a vote on this change. Change subject: fe: set classpath using maven dependency resolution .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 5: Verified+1 Test failure was an unrelated apparent flake during query execution. Am assuming that if this patch had a problem we'd have spectacular failures. -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 13 May 2019 18:57:15 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4226/ -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 10 May 2019 23:35:44 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4226/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 10 May 2019 18:31:20 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 10 May 2019 18:31:10 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 10 May 2019 18:31:19 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 3: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4202/ -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Thu, 09 May 2019 13:15:51 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4202/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Thu, 09 May 2019 06:24:05 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4193/ -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 23:35:08 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 3: I killed the test job because it appeared to be stuck. You probably want to rebase and try again. -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 23:35:15 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 21:21:02 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4193/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 20:24:57 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 2: No Builds Executed -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 19:52:27 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Todd Lipcon has posted comments on this change. (
http://gerrit.cloudera.org:8080/13185 )
Change subject: fe: set classpath using maven dependency resolution
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh
File bin/set-classpath.sh:
http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh@34
PS1, Line 34: ="$IMPALA_HOME/fe/target/build-classpath.txt"
> maybe add an error message that if this file does not exist, we should buil
Done
http://gerrit.cloudera.org:8080/#/c/13185/1/docker/setup_build_context.py
File docker/setup_build_context.py:
http://gerrit.cloudera.org:8080/#/c/13185/1/docker/setup_build_context.py@66
PS1, Line 66: }".fo
> nit: use {0} instead of +
Done
--
To view, visit http://gerrit.cloudera.org:8080/13185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94
Gerrit-Change-Number: 13185
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Comment-Date: Wed, 08 May 2019 19:21:34 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Hello Vihang Karajgaonkar, Fredy Wijaya, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13185 to look at the new patch set (#2). Change subject: fe: set classpath using maven dependency resolution .. fe: set classpath using maven dependency resolution This changes the FE pom to generate a build classpath file in the target/ directory. Then, bin/set-classpath.sh uses this file to generate the classpath to start the cluster. This replaces the former approach of including all of the jars found in target/dependency/ The advantage of this is that a clean build is no longer required when switching artifact versions. Prior to this patch, if you changed an artifact version and rebuilt, both the old and new artifact would be left in the target/dependency/ directory and pollute the classpath. This doesn't fully remove the target/dependency/ directory, because its existence is likely important for downstream packaging of Impala. We can likely assume that such packaging always does a clean build. This also changes the set-classpath script to no longer load jars from testdata/target/dependency/ since it appears that directory doesn't actually get created during the build. Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 --- M bin/set-classpath.sh M docker/setup_build_context.py M fe/pom.xml 3 files changed, 36 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/13185/2 -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 1: I think we can +2 once Fredy's comments are addressed. -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 07 May 2019 22:23:08 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh File bin/set-classpath.sh: http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh@a40 PS1, Line 40: > See the commit message -- at least on my machine I couldn't find any trace oh, sorry missed that part. Looks good in that case -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 30 Apr 2019 23:15:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh File bin/set-classpath.sh: http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh@a40 PS1, Line 40: > Does the build-classpath.txt include the testdata/target/dependency/*.jar t See the commit message -- at least on my machine I couldn't find any trace of such files existing, nor is there a 'copy-dependencies' task in testdata/pom.xml. So i'm not sure why this was there in the first place. -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 30 Apr 2019 18:16:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Fredy Wijaya has posted comments on this change. (
http://gerrit.cloudera.org:8080/13185 )
Change subject: fe: set classpath using maven dependency resolution
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh
File bin/set-classpath.sh:
http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh@34
PS1, Line 34: $(cat "$IMPALA_HOME"/fe/target/build-classpath.txt)
maybe add an error message that if this file does not exist, we should build
the fe first
http://gerrit.cloudera.org:8080/#/c/13185/1/docker/setup_build_context.py
File docker/setup_build_context.py:
http://gerrit.cloudera.org:8080/#/c/13185/1/docker/setup_build_context.py@66
PS1, Line 66: + jar
nit: use {0} instead of +
--
To view, visit http://gerrit.cloudera.org:8080/13185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94
Gerrit-Change-Number: 13185
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Comment-Date: Tue, 30 Apr 2019 18:20:29 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh File bin/set-classpath.sh: http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh@a40 PS1, Line 40: Does the build-classpath.txt include the testdata/target/dependency/*.jar too? -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 30 Apr 2019 18:07:38 + Gerrit-HasComments: Yes
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 30 Apr 2019 09:09:24 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 30 Apr 2019 06:47:56 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2992/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 30 Apr 2019 04:33:46 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4110/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 30 Apr 2019 04:12:35 + Gerrit-HasComments: No
[Impala-ASF-CR] fe: set classpath using maven dependency resolution
Hello Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13185 to review the following change. Change subject: fe: set classpath using maven dependency resolution .. fe: set classpath using maven dependency resolution This changes the FE pom to generate a build classpath file in the target/ directory. Then, bin/set-classpath.sh uses this file to generate the classpath to start the cluster. This replaces the former approach of including all of the jars found in target/dependency/ The advantage of this is that a clean build is no longer required when switching artifact versions. Prior to this patch, if you changed an artifact version and rebuilt, both the old and new artifact would be left in the target/dependency/ directory and pollute the classpath. This doesn't fully remove the target/dependency/ directory, because its existence is likely important for downstream packaging of Impala. We can likely assume that such packaging always does a clean build. This also changes the set-classpath script to no longer load jars from testdata/target/dependency/ since it appears that directory doesn't actually get created during the build. Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 --- M bin/set-classpath.sh M docker/setup_build_context.py M fe/pom.xml 3 files changed, 29 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/13185/1 -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Tim Armstrong
