[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Hello Greg Rahn, Matthew Mulder, Michael Brown, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8372 to look at the new patch set (#8). Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE The .test files in this commit are ones held out from IMPALA-5376 because of observed anomalies with returned decimal precision that I previously controlled with TRUNCATE(). This ticket was filed after team members expressed a preference not to use TRUNCATE() and to use actual results generated within numerical range of expected, unless the results could not be controlled otherwise. Rounds of testing for this commit show that the earlier anomalies no longer occur, clearing the way for their inclusion in our TPC-DS suite. It has been observed that these tests tend to fail with the DECIMAL_V2 option set (unless the test does so explicitly). Testing: The gerrit_verify_dryrun_external job passed builds #24, #29, #30 and #31 with this change. The fix (rebased hereon) to IMPALA-6106 (finally) cleared up a source of flapping for these tests. Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a --- A testdata/workloads/tpcds/queries/tpcds-q26.test A testdata/workloads/tpcds/queries/tpcds-q28.test M testdata/workloads/tpcds/queries/tpcds-q39-1.test M testdata/workloads/tpcds/queries/tpcds-q39-2.test A testdata/workloads/tpcds/queries/tpcds-q47.test A testdata/workloads/tpcds/queries/tpcds-q57.test A testdata/workloads/tpcds/queries/tpcds-q59.test M testdata/workloads/tpcds/queries/tpcds-q61.test A testdata/workloads/tpcds/queries/tpcds-q63.test M testdata/workloads/tpcds/queries/tpcds-q77a.test M testdata/workloads/tpcds/queries/tpcds-q78.test M testdata/workloads/tpcds/queries/tpcds-q86a.test M tests/query_test/test_tpcds_queries.py 13 files changed, 851 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/8372/8 -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 7: Dryrun builds #29, #30, #31 all pass. -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Wed, 15 Nov 2017 19:11:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 7: > Patch Set 7: > > > Patch Set 6: > > > > (2 comments) > > > > > Patch Set 5: > > > > > > (2 comments) > > > > > > Do you have 3 runs showing that there is no new flaky test cases? > > > > Yes; two local, and one in progress at > > jenkins.impala.io/job/gerrit-verify-dryrun-external/26/. > > The dryrun build failed due to C++ compilation errors. I rebased and > rebuilt, #29. Build #29 succeeded. -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Tue, 14 Nov 2017 22:12:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 7: > Patch Set 6: > > (2 comments) > > > Patch Set 5: > > > > (2 comments) > > > > Do you have 3 runs showing that there is no new flaky test cases? > > Yes; two local, and one in progress at > jenkins.impala.io/job/gerrit-verify-dryrun-external/26/. The dryrun build failed due to C++ compilation errors. I rebased and rebuilt, #29. -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Tue, 14 Nov 2017 19:39:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 6: (2 comments) > Patch Set 5: > > (2 comments) > > Do you have 3 runs showing that there is no new flaky test cases? Yes; two local, and one in progress at jenkins.impala.io/job/gerrit-verify-dryrun-external/26/. http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q77a.test File testdata/workloads/tpcds/queries/tpcds-q77a.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q77a.test@4 PS5, Line 4: -- FIXED, MADE UNIFORM 1/100 PRECISION. USE ACTUAL RESULT AS EXPECTED RESULT > Please add explanation for what was different. Done http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q86a.test File testdata/workloads/tpcds/queries/tpcds-q86a.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q86a.test@4 PS5, Line 4: -- FIXED, MADE UNIFORM 1/100 PRECISION. USE ACTUAL RESULT AS EXPECTED RESULT > What was the difference? Done -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Tue, 14 Nov 2017 02:02:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Hello Greg Rahn, Matthew Mulder, Michael Brown, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8372 to look at the new patch set (#6). Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE The .test files in this commit are ones held out from IMPALA-5376 because of observed anomalies with returned decimal precision that I previously controlled with TRUNCATE(). This ticket was filed after team members expressed a preference not to use TRUNCATE() and to use actual results generated within numerical range of expected, unless the results could not be controlled otherwise. Rounds of testing for this commit show that the earlier anomalies no longer occur, clearing the way for their inclusion in our TPC-DS suite. It has been observed that these tests tend to fail with the DECIMAL_V2 option set (unless the test does so explicitly). Testing: The gerrit_verify_dryrun_external (build #24) job passes with this change. The fix (rebased hereon) to IMPALA-6106 (finally) cleared up a source of flapping for these tests. Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a --- A testdata/workloads/tpcds/queries/tpcds-q26.test A testdata/workloads/tpcds/queries/tpcds-q28.test M testdata/workloads/tpcds/queries/tpcds-q39-1.test M testdata/workloads/tpcds/queries/tpcds-q39-2.test A testdata/workloads/tpcds/queries/tpcds-q47.test A testdata/workloads/tpcds/queries/tpcds-q57.test A testdata/workloads/tpcds/queries/tpcds-q59.test M testdata/workloads/tpcds/queries/tpcds-q61.test A testdata/workloads/tpcds/queries/tpcds-q63.test M testdata/workloads/tpcds/queries/tpcds-q77a.test M testdata/workloads/tpcds/queries/tpcds-q78.test M testdata/workloads/tpcds/queries/tpcds-q86a.test M tests/query_test/test_tpcds_queries.py 13 files changed, 851 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/8372/6 -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 5: (2 comments) Do you have 3 runs showing that there is no new flaky test cases? http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q77a.test File testdata/workloads/tpcds/queries/tpcds-q77a.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q77a.test@4 PS5, Line 4: -- FIXED. USE ACTUAL RESULT AS EXPECTED RESULT Please add explanation for what was different. http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q86a.test File testdata/workloads/tpcds/queries/tpcds-q86a.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q86a.test@4 PS5, Line 4: -- FIXED. USE ACTUAL RESULT AS EXPECTED RESULT What was the difference? -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Tue, 14 Nov 2017 00:43:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q26.test File testdata/workloads/tpcds/queries/tpcds-q26.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q26.test@5 PS5, Line 5: 78.33 > The TPC-DS spec section 7.5.3.d says "For results from AVG aggregates, the Ack http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q39-1.test File testdata/workloads/tpcds/queries/tpcds-q39-1.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q39-1.test@4 PS5, Line 4: -- ADD ROUND()s TO 4th, 5th, 9th, 10th COLUMNS, USE ACTUAL RESULT AS EXPECTED RESULT. > It looks like this is okay per the TPC-DS standard section 4.2.3.4.f.6: Exp Ack -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Mon, 13 Nov 2017 23:32:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Matthew Mulder has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q26.test File testdata/workloads/tpcds/queries/tpcds-q26.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q26.test@5 PS5, Line 5: 78.33 The TPC-DS spec section 7.5.3.d says "For results from AVG aggregates, the resulting values must be within 1% of the query validation output data when reported to the nearest 1/100th, rounded up." so I guess this is okay. http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q39-1.test File testdata/workloads/tpcds/queries/tpcds-q39-1.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q39-1.test@4 PS5, Line 4: -- ADD ROUND()s TO 4th, 5th, 9th, 10th COLUMNS, USE ACTUAL RESULT AS EXPECTED RESULT. It looks like this is okay per the TPC-DS standard section 4.2.3.4.f.6: Explicit Casting - Scalar functions (such as CAST) whose sole purpose is to affect result precision for operations involving integer columns or values may be applied. The resulting syntax must have equivalent semantic behavior. -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Fri, 10 Nov 2017 03:04:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q47.test File testdata/workloads/tpcds/queries/tpcds-q47.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q47.test@3 PS4, Line 3: -- RESULT MISMATCH FROM ORIGINAL in LSD of DECIMAL values, E.G, > Would be good to use an example to better describe the mismatch Done -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Sat, 04 Nov 2017 00:19:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q26.test File testdata/workloads/tpcds/queries/tpcds-q26.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q26.test@3 PS4, Line 3: -- RESULT MISMATCH FROM ORIGINAL, E.G., > Please use a more descriptive comment. Done http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q26.test@4 PS4, Line 4: -- Expected: 'AAID',78.33,126.37,0.00,61.94 > What does this mean? Done http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q59.test File testdata/workloads/tpcds/queries/tpcds-q59.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q59.test@3 PS4, Line 3: with > Remove line Done http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q63.test File testdata/workloads/tpcds/queries/tpcds-q63.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q63.test@3 PS4, Line 3: select > Remove line Done -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Sat, 04 Nov 2017 00:15:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Hello Greg Rahn, Matthew Mulder, Michael Brown, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8372 to look at the new patch set (#5). Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE The .test files in this commit are ones held out from IMPALA-5376 because of observed anomalies with returned decimal precision that I previously controlled with TRUNCATE(). This ticket was filed after team members expressed a preference not to use TRUNCATE() and to use actual results generated within numerical range of expected, unless the results could not be controlled otherwise. Rounds of testing for this commit show that the earlier anomalies no longer occur, clearing the way for their inclusion in our TPC-DS suite. It has been observed that these tests tend to fail with the DECIMAL_V2 option set (unless the test does so explicitly). Testing: The gerrit_verify_dryrun_external (build #24) job passes with this change. The fix (rebased hereon) to IMPALA-6106 (finally) cleared up a source of flapping for these tests. Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a --- A testdata/workloads/tpcds/queries/tpcds-q26.test A testdata/workloads/tpcds/queries/tpcds-q28.test M testdata/workloads/tpcds/queries/tpcds-q39-1.test M testdata/workloads/tpcds/queries/tpcds-q39-2.test A testdata/workloads/tpcds/queries/tpcds-q47.test A testdata/workloads/tpcds/queries/tpcds-q57.test A testdata/workloads/tpcds/queries/tpcds-q59.test M testdata/workloads/tpcds/queries/tpcds-q61.test A testdata/workloads/tpcds/queries/tpcds-q63.test M testdata/workloads/tpcds/queries/tpcds-q77a.test M testdata/workloads/tpcds/queries/tpcds-q78.test M testdata/workloads/tpcds/queries/tpcds-q86a.test M tests/query_test/test_tpcds_queries.py 13 files changed, 849 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/8372/5 -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q26.test File testdata/workloads/tpcds/queries/tpcds-q26.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q26.test@3 PS4, Line 3: -- RESULT MISMATCH FROM ORIGINAL Please use a more descriptive comment. What kind of mismatch? Which column? Description of mismatch. http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q26.test@4 PS4, Line 4: -- TAKE ACTUAL RESULT AS EXPECTED What does this mean? http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q47.test File testdata/workloads/tpcds/queries/tpcds-q47.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q47.test@3 PS4, Line 3: -- RESULT MISMATCH FROM ORIGINAL in LSD of DECIMAL values Would be good to use an example to better describe the mismatch http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q59.test File testdata/workloads/tpcds/queries/tpcds-q59.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q59.test@3 PS4, Line 3: Remove line http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q63.test File testdata/workloads/tpcds/queries/tpcds-q63.test: http://gerrit.cloudera.org:8080/#/c/8372/4/testdata/workloads/tpcds/queries/tpcds-q63.test@3 PS4, Line 3: Remove line -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Fri, 03 Nov 2017 22:35:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Fri, 03 Nov 2017 20:23:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: > Patch Set 4: > > > Patch Set 4: > > > > What about Mostafa's question: > > > How many iterations did you try for those tests? > > I thought I answered it: > > For example, q47 failed in 4 different test runs on 9/18 because of an LSD > > difference. ...[I]t's passing now that I replaced the old expected output > > with the new > > Am I not understanding "iterations" in this context? Taking a guess at the question, here are the numbers of attempts of each of these tests in my local workspace since I started on this test suite: q26 59 q28 29 q47 39 q57 31 q59 28 q63 28 -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Fri, 03 Nov 2017 00:16:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: > Patch Set 4: > > What about Mostafa's question: > > How many iterations did you try for those tests? I thought I answered it: > For example, q47 failed in 4 different test runs on 9/18 because of an LSD > difference. ...[I]t's passing now that I replaced the old expected output > with the new Am I not understanding "iterations" in this context? -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Thu, 02 Nov 2017 22:40:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: What about Mostafa's question: > How many iterations did you try for those tests? -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Thu, 02 Nov 2017 21:31:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: Any further comments on this review? Any reason not to +2? Thanks. -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Thu, 02 Nov 2017 21:23:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG@14 PS3, Line 14: Rounds of testing : for this commit show that the earlier anomalies no longer occur > This would be back in Sept. when I saw the problems. For example, q47 fail To clarify, it's passing now that I replaced the old expected output with the current actual (diff in some values by .01). -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Tue, 31 Oct 2017 01:13:46 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG@14 PS3, Line 14: Rounds of testing : for this commit show that the earlier anomalies no longer occur > I don't of any code change that got in lately that would result in change i This would be back in Sept. when I saw the problems. For example, q47 failed in 4 different test runs on 9/18 because of an LSD difference. Now it's passing. -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Tue, 31 Oct 2017 01:08:50 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG@14 PS3, Line 14: Rounds of testing : for this commit show that the earlier anomalies no longer occur I don't of any code change that got in lately that would result in change in behavior. How many iterations did you try for those tests? -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Tue, 31 Oct 2017 00:09:22 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG@18 PS3, Line 18: (unless the test does so explicitly). > Better to say, "unless the test does so explicitly." Done -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Mon, 30 Oct 2017 17:50:55 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Hello Greg Rahn, Matthew Mulder, Michael Brown, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8372 to look at the new patch set (#4). Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE The .test files in this commit are ones held out from IMPALA-5376 because of observed anomalies with returned decimal precision that I previously controlled with TRUNCATE(). This ticket was filed after team members expressed a preference not to use TRUNCATE() and to use actual results generated within numerical range of expected, unless the results could not be controlled otherwise. Rounds of testing for this commit show that the earlier anomalies no longer occur, clearing the way for their inclusion in our TPC-DS suite. It has been observed that these tests tend to fail with the DECIMAL_V2 option set (unless the test does so explicitly). Testing: The gerrit_verify_dryrun_external (build #24) job passes with this change. The fix (rebased hereon) to IMPALA-6106 (finally) cleared up a source of flapping for these tests. Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a --- A testdata/workloads/tpcds/queries/tpcds-q26.test A testdata/workloads/tpcds/queries/tpcds-q28.test A testdata/workloads/tpcds/queries/tpcds-q47.test A testdata/workloads/tpcds/queries/tpcds-q57.test A testdata/workloads/tpcds/queries/tpcds-q59.test A testdata/workloads/tpcds/queries/tpcds-q63.test M tests/query_test/test_tpcds_queries.py 7 files changed, 837 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/8372/4 -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8372/3//COMMIT_MSG@18 PS3, Line 18: (unless done so explicitly). Better to say, "unless the test does so explicitly." -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood Gerrit-Comment-Date: Fri, 27 Oct 2017 23:07:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE The .test files in this commit are ones held out from IMPALA-5376 because of observed anomalies with returned decimal precision that I previously controlled with TRUNCATE(). This ticket was filed after team members expressed a preference not to use TRUNCATE() and to use actual results generated within numerical range of expected, unless the results could not be controlled otherwise. Rounds of testing for this commit show that the earlier anomalies no longer occur, clearing the way for their inclusion in our TPC-DS suite. It has been observed that these tests tend to fail with the DECIMAL_V2 option set (unless done so explicitly). Testing: The gerrit_verify_dryrun_external (build #24) job passes with this change. The fix (rebased hereon) to IMPALA-6106 (finally) cleared up a source of flapping for these tests. Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a --- A testdata/workloads/tpcds/queries/tpcds-q26.test A testdata/workloads/tpcds/queries/tpcds-q28.test A testdata/workloads/tpcds/queries/tpcds-q47.test A testdata/workloads/tpcds/queries/tpcds-q57.test A testdata/workloads/tpcds/queries/tpcds-q59.test A testdata/workloads/tpcds/queries/tpcds-q63.test M tests/query_test/test_tpcds_queries.py 7 files changed, 837 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/8372/3 -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wood Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Wood
[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Tim Wood has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8372 Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE The .test files in this commit are ones held out from IMPALA-5376 because of observed anomalies with returned decimal precision that I controlled with TRUNCATE(). This ticket was filed after team members expressed a preference not to use TRUNCATE() and to use actual results generated within numerical range of expected, unless the results could not be controlled otherwise. Rounds of testing for this commit show that the earlier anomalies no longer occur, clearing the way for their inclusion in our TPC-DS suite. Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a --- A testdata/workloads/tpcds/queries/tpcds-q26.test A testdata/workloads/tpcds/queries/tpcds-q28.test A testdata/workloads/tpcds/queries/tpcds-q47.test A testdata/workloads/tpcds/queries/tpcds-q57.test A testdata/workloads/tpcds/queries/tpcds-q59.test A testdata/workloads/tpcds/queries/tpcds-q63.test M tests/query_test/test_tpcds_queries.py 7 files changed, 837 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/8372/1 -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wood