[kudu-CR] KUDU-2542: add initial authorization token impl
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11750 ) Change subject: KUDU-2542: add initial authorization token impl .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token-test.cc File src/kudu/security/token-test.cc: http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token-test.cc@73 PS2, Line 73: Status SignUntilRotatePast(TokenSigner* signer, TokenGenerator generate_token, > warning: the const qualified parameter 'token_type' is copied for each invo Done http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token.proto File src/kudu/security/token.proto: http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token.proto@38 PS2, Line 38: optional bool scan_privilege = 2; > Start at 2 Done -- To view, visit http://gerrit.cloudera.org:8080/11750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f Gerrit-Change-Number: 11750 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 25 Oct 2018 05:58:38 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2542: add initial authorization token impl
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11750 to look at the new patch set (#3). Change subject: KUDU-2542: add initial authorization token impl .. KUDU-2542: add initial authorization token impl This patch adds an authorization token that echoes the authentication token implementation. These tokens contain privileges that will be used authorize specific tablet server requests. By in large, tablet server requests are scoped to a single table, and as such, so are authz tokens. In cases where this is not true (e.g. ListTablets), a reasonable assumption is that the call is being made via tooling, and coarse-grained access control should be used instead of fine-grained. If this ends up being less the case in the future, we can always amend the authz token to support multiple tables. The tokens leverage the same token signer as the authentication tokens, though with the token validity interval configured via the new flag --authz_token_validity_seconds. Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f --- M src/kudu/integration-tests/authn_token_expire-itest.cc M src/kudu/integration-tests/security-unknown-tsk-itest.cc M src/kudu/integration-tests/token_signer-itest.cc M src/kudu/master/master.cc M src/kudu/rpc/negotiation-test.cc M src/kudu/security/token-test.cc M src/kudu/security/token.proto M src/kudu/security/token_signer.cc M src/kudu/security/token_signer.h 9 files changed, 386 insertions(+), 76 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/11750/3 -- To view, visit http://gerrit.cloudera.org:8080/11750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f Gerrit-Change-Number: 11750 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [client] expose location via internal API
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [client] expose location via internal API .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 8 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 05:55:14 + Gerrit-HasComments: No
[kudu-CR] [location awareness] Add ts location to TSInfoPB
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 ) Change subject: [location_awareness] Add ts location to TSInfoPB .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 05:54:12 + Gerrit-HasComments: No
[kudu-CR] [location awareness] Add ts location to TSInfoPB
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11727 to look at the new patch set (#7). Change subject: [location_awareness] Add ts location to TSInfoPB .. [location_awareness] Add ts location to TSInfoPB I added the 'location' field into TSInfoPB so that the tool client can get the ts location info. Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 --- M src/kudu/integration-tests/CMakeLists.txt A src/kudu/integration-tests/scripts/first_argument.sh M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto 5 files changed, 118 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/11727/7 -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [location awareness] Add ts location to TSInfoPB
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 ) Change subject: [location_awareness] Add ts location to TSInfoPB .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11727/6/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/6/src/kudu/integration-tests/table_locations-itest.cc@272 PS6, Line 272: req.set_max_returned_locations(3); > nit: if the sub-scenario verifies just very first location, why to ask for Done -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 05:33:21 + Gerrit-HasComments: Yes
[kudu-CR] [client] expose location via internal API
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [client] expose location via internal API .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/11679/7/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/11679/7/src/kudu/client/meta_cache.h@109 PS7, Line 109: KUDU_NO_EXPORT > nit: I think this extra attribute isn't needed: the whole RemoteTabletServe Oh I see. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 05:00:24 + Gerrit-HasComments: Yes
[kudu-CR] [client] expose location via internal API
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11679 to look at the new patch set (#8). Change subject: [client] expose location via internal API .. [client] expose location via internal API I added location info to client::KuduTabletServer and client::internal::RemoteTabletServer to enable the future work on location-aware C++ and Java clients. Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/scan_token-internal.cc M src/kudu/client/tablet_server-internal.cc M src/kudu/client/tablet_server-internal.h 7 files changed, 29 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/11679/8 -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 8 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [client] expose location via internal API
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [client] expose location via internal API .. Patch Set 7: (1 comment) Looks good: just one small nit. http://gerrit.cloudera.org:8080/#/c/11679/7/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/11679/7/src/kudu/client/meta_cache.h@109 PS7, Line 109: KUDU_NO_EXPORT nit: I think this extra attribute isn't needed: the whole RemoteTabletServer class is in the kudu::client::internal namespace which neither externally exposed in any public API header file nor exported from the kudu_client library. -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 04:16:24 + Gerrit-HasComments: Yes
[kudu-CR] [c++ client] clean up inline doxygen documentation
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11780 ) Change subject: [c++ client] clean up inline doxygen documentation .. [c++ client] clean up inline doxygen documentation This patch cleans up doxygen documentation in client.h. Most importantly, this patch removes the internal API methods (i.e. methods marked with KUDU_NO_EXPORT attribute) from the auto-generated documentation. Fixed other typos and mistakes in doxygen formatting, so now doxygen outputs less warnings. The rest of the doxygen warnings will be addressed in a follow-up patch. Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad Reviewed-on: http://gerrit.cloudera.org:8080/11780 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/client/client.h 1 file changed, 55 insertions(+), 23 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad Gerrit-Change-Number: 11780 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [c++ client] KuduTable::ListPartitions() is private API
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11779 ) Change subject: [c++ client] KuduTable::ListPartitions() is private API .. [c++ client] KuduTable::ListPartitions() is private API Added missing KUDU_NO_EXPORT attribute for KuduTable::ListPartitions() since the method is indented to be a part of private (i.e. non-exported) API of the Kudu C++ client. This is a follow-up for ef714838a8ba4e2a0dbf1d2f7998f8909d591402. Change-Id: Iaaeeda02a8b97e7b963f9f4496e879f999a0d97d Reviewed-on: http://gerrit.cloudera.org:8080/11779 Tested-by: Alexey Serbin Reviewed-by: Adar Dembo --- M src/kudu/client/client.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexey Serbin: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iaaeeda02a8b97e7b963f9f4496e879f999a0d97d Gerrit-Change-Number: 11779 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Will Berkeley
[kudu-CR] [client] expose location via internal API
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [client] expose location via internal API .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 03:41:00 + Gerrit-HasComments: No
[kudu-CR] [location awareness] Add ts location to TSInfoPB
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 ) Change subject: [location_awareness] Add ts location to TSInfoPB .. Patch Set 6: Code-Review+1 Will defer to Alexey. -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 03:40:04 + Gerrit-HasComments: No
[kudu-CR] [c++ client] clean up inline doxygen documentation
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11780 ) Change subject: [c++ client] clean up inline doxygen documentation .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad Gerrit-Change-Number: 11780 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 03:38:45 + Gerrit-HasComments: No
[kudu-CR] [c++ client] KuduTable::ListPartitions() is private API
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11779 ) Change subject: [c++ client] KuduTable::ListPartitions() is private API .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaaeeda02a8b97e7b963f9f4496e879f999a0d97d Gerrit-Change-Number: 11779 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 03:36:57 + Gerrit-HasComments: No
[kudu-CR] [location awareness] Add ts location to TSInfoPB
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 ) Change subject: [location_awareness] Add ts location to TSInfoPB .. Patch Set 6: (1 comment) Looks good, just one small nit. http://gerrit.cloudera.org:8080/#/c/11727/6/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/6/src/kudu/integration-tests/table_locations-itest.cc@272 PS6, Line 272: req.set_max_returned_locations(3); nit: if the sub-scenario verifies just very first location, why to ask for 3 locations? Maybe, set max_returned_locations to 1? -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 02:29:11 + Gerrit-HasComments: Yes
[kudu-CR] [client] expose location via internal API
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 ) Change subject: [client] expose location via internal API .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@7 PS2, Line 7: Add ts location to both client and internal client > Ah, it seems a typo in my last comment was the source of the confusion. I see. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 02:22:55 + Gerrit-HasComments: Yes
[kudu-CR] [client] expose location via internal API
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11679 to look at the new patch set (#7). Change subject: [client] expose location via internal API .. [client] expose location via internal API I added location info to client::KuduTabletServer and client::internal::RemoteTabletServer to enable the future work on location-aware C++ and Java clients. Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/scan_token-internal.cc M src/kudu/client/tablet_server-internal.cc M src/kudu/client/tablet_server-internal.h 7 files changed, 29 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/11679/7 -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [c++ client] clean up inline doxygen documentation
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11780 ) Change subject: [c++ client] clean up inline doxygen documentation .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11780/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11780/1/src/kudu/client/client.h@2168 PS1, Line 2168: static const uint64_t PAD_UNIXTIME_MICROS_TO_16_BYTES = 1 << 0; > warning: invalid case style for global constant 'PAD_UNIXTIME_MICROS_TO_16_ I'm going to ignore this TidyBot's suggestion since the mentioned constant is a part of the Kudu C++ client public API. -- To view, visit http://gerrit.cloudera.org:8080/11780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad Gerrit-Change-Number: 11780 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 01:47:24 + Gerrit-HasComments: Yes
[kudu-CR] [c++ client] KuduTable::ListPartitions() is private API
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11779 ) Change subject: [c++ client] KuduTable::ListPartitions() is private API .. Patch Set 1: Verified+1 Unrelated flake in org.apache.kudu.spark.kudu.DefaultSourceTest -- To view, visit http://gerrit.cloudera.org:8080/11779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaaeeda02a8b97e7b963f9f4496e879f999a0d97d Gerrit-Change-Number: 11779 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 01:40:05 + Gerrit-HasComments: No
[kudu-CR] [c++ client] KuduTable::ListPartitions() is private API
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11779 ) Change subject: [c++ client] KuduTable::ListPartitions() is private API .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Iaaeeda02a8b97e7b963f9f4496e879f999a0d97d Gerrit-Change-Number: 11779 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Will Berkeley
[kudu-CR] [c++ client] clean up inline doxygen documentation
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11780 Change subject: [c++ client] clean up inline doxygen documentation .. [c++ client] clean up inline doxygen documentation This patch cleans up doxygen documentation in client.h. Most importantly, this patch removes the internal API methods (i.e. methods marked with KUDU_NO_EXPORT attribute) from the auto-generated documentation. Fixed other typos and mistakes in doxygen formatting, so now doxygen outputs less warnings. The rest of the doxygen warnings will be addressed in a follow-up patch. Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad --- M src/kudu/client/client.h 1 file changed, 55 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/11780/1 -- To view, visit http://gerrit.cloudera.org:8080/11780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad Gerrit-Change-Number: 11780 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [location awareness] Add ts location to TSInfoPB
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11727 to look at the new patch set (#6). Change subject: [location_awareness] Add ts location to TSInfoPB .. [location_awareness] Add ts location to TSInfoPB I added the 'location' field into TSInfoPB so that the tool client can get the ts location info. Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 --- M src/kudu/integration-tests/CMakeLists.txt A src/kudu/integration-tests/scripts/first_argument.sh M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master.proto 5 files changed, 118 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/11727/6 -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [location awareness] Add ts location to TSInfoPB
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 ) Change subject: [location_awareness] Add ts location to TSInfoPB .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/11727/3/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/3/src/kudu/integration-tests/table_locations-itest.cc@104 PS3, Line 104: > warning: parameter 'tablet_locations_size' is const-qualified in > the function declaration; const-qualification of parameters only > has an effect in function definitions > [readability-avoid-const-params-in-decls] > void CheckMasterTableCreation(const string _name, const int > tablet_locations_size); > ^~ http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@74 PS5, Line 74: > Add a call to SetUpConfig() here. Then you won't need to override SetUp() i Done http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@216 PS5, Line 216: } > You need to surround these calls with NO_FATALS(); otherwise, errors in Che Done http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@294 PS5, Line 294: GetTableLocationsResponsePB resp; > nit: could you add ASSERT_EQ() on the expected number of locations returned Done http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@294 PS5, Line 294: GetTableLocationsResponsePB resp; : RpcController controller; : req.mutable_table()->set_table_name(table_name); > Nit: do this in a loop. Done http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@317 PS5, Line 317: > nit: how many replicas do you expect to be returned in the response? If mu Done -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 25 Oct 2018 01:17:10 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 ) Change subject: Updating web site for Kudu 1.8.0 release .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11772/4//COMMIT_MSG Commit Message: PS4: Woops, I found some issues in the doxygen-generated docs for Kudu C++ client API. The issue is that non-exported methods are documented and the doc claims they are in the public C++ API for the Kudu client. I'm about to post a patch with corresponding fixes. Attila, will it be possible to re-generate docs from the fixed version instead of the HEAD in branch-1.8.0? Also, I found one spillage of an internal API method into public API: https://gerrit.cloudera.org/#/c/11779/ I don't think that a blocker for 1.8.0 release, but just FYI. -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: helifu Gerrit-Comment-Date: Thu, 25 Oct 2018 01:20:57 + Gerrit-HasComments: Yes
[kudu-CR] [c++ client] KuduTable::ListPartitions() is private API
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11779 Change subject: [c++ client] KuduTable::ListPartitions() is private API .. [c++ client] KuduTable::ListPartitions() is private API Added missing KUDU_NO_EXPORT attribute for KuduTable::ListPartitions() since the method is indented to be a part of private (i.e. non-exported) API of the Kudu C++ client. This is a follow-up for ef714838a8ba4e2a0dbf1d2f7998f8909d591402. Change-Id: Iaaeeda02a8b97e7b963f9f4496e879f999a0d97d --- M src/kudu/client/client.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/11779/1 -- To view, visit http://gerrit.cloudera.org:8080/11779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaaeeda02a8b97e7b963f9f4496e879f999a0d97d Gerrit-Change-Number: 11779 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] KUDU-2542: add initial authorization token impl
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11750 ) Change subject: KUDU-2542: add initial authorization token impl .. Patch Set 2: Failures are in LINT and IWYU. -- To view, visit http://gerrit.cloudera.org:8080/11750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f Gerrit-Change-Number: 11750 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 25 Oct 2018 00:30:48 + Gerrit-HasComments: No
[kudu-CR] KUDU-2542: add initial authorization token impl
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11750 ) Change subject: KUDU-2542: add initial authorization token impl .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token.proto File src/kudu/security/token.proto: http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token.proto@38 PS2, Line 38: optional bool scan_privilege = 3; Start at 2 -- To view, visit http://gerrit.cloudera.org:8080/11750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f Gerrit-Change-Number: 11750 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 25 Oct 2018 00:04:36 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Hello Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Andrew Wong, helifu, Adar Dembo, Anonymous Coward (314), Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11772 to look at the new patch set (#4). Change subject: Updating web site for Kudu 1.8.0 release .. Updating web site for Kudu 1.8.0 release Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 --- M apidocs M cpp-client-api A docs D docs/administration.html D docs/background_tasks.html D docs/command_line_tools.html D docs/command_line_tools_reference.html D docs/configuration.html D docs/configuration_reference.html D docs/configuration_reference_unsupported.html D docs/contributing.html D docs/developing.html D docs/export_control.html D docs/index.html D docs/installation.html D docs/known_issues.html D docs/kudu-master_configuration_reference.html D docs/kudu-master_configuration_reference_unsupported.html D docs/kudu-tserver_configuration_reference.html D docs/kudu-tserver_configuration_reference_unsupported.html D docs/kudu_impala_integration.html D docs/prior_release_notes.html D docs/quickstart.html D docs/release_notes.html D docs/scaling_guide.html D docs/schema_design.html D docs/security.html D docs/transaction_semantics.html D docs/troubleshooting.html A releases/1.8.0/apidocs/allclasses-frame.html A releases/1.8.0/apidocs/allclasses-noframe.html A releases/1.8.0/apidocs/constant-values.html A releases/1.8.0/apidocs/deprecated-list.html A releases/1.8.0/apidocs/help-doc.html A releases/1.8.0/apidocs/index-all.html A releases/1.8.0/apidocs/index.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.ColumnSchemaBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.CompressionAlgorithm.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.Encoding.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnTypeAttributes.html A releases/1.8.0/apidocs/org/apache/kudu/Schema.html A releases/1.8.0/apidocs/org/apache/kudu/Type.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-frame.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-summary.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-tree.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-use.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.ColumnSchemaBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.CompressionAlgorithm.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.Encoding.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnTypeAttributes.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/Schema.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/Type.html A releases/1.8.0/apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/AlterTableOptions.html A releases/1.8.0/apidocs/org/apache/kudu/client/AlterTableResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduClient.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduSession.html A releases/1.8.0/apidocs/org/apache/kudu/client/ColumnRangePredicate.html A releases/1.8.0/apidocs/org/apache/kudu/client/CreateTableOptions.html A releases/1.8.0/apidocs/org/apache/kudu/client/Delete.html A releases/1.8.0/apidocs/org/apache/kudu/client/DeleteTableResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/ExternalConsistencyMode.html A releases/1.8.0/apidocs/org/apache/kudu/client/HasFailedRpcException.html A releases/1.8.0/apidocs/org/apache/kudu/client/Insert.html A releases/1.8.0/apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/IsCreateTableDoneResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduClient.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduException.OriginalException.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduException.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduPredicate.html A
[kudu-CR] KUDU-2542: add initial authorization token impl
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/11750 )
Change subject: KUDU-2542: add initial authorization token impl
..
Patch Set 2:
(26 comments)
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token-test.cc
File src/kudu/security/token-test.cc:
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token-test.cc@45
PS1, Line 45:
> warning: using decl 'make_shared' is unused [misc-unused-using-decls]
Done
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token-test.cc@56
PS1, Line 56: namespace security {
> warning: 'kNumBits' is a static definition in anonymous namespace; static i
Done
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token-test.cc@306
PS1, Line 306: ASSERT_OK(signer.CheckNeedKey());
: ASSERT_NE(nullptr, key.get());
: ASSERT_EQ(kE
> I think it's simpler: TokenSigner::AddKey() method requires monotonically i
Nice, thanks!
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token-test.cc@358
PS1, Line 358: // Test importing expired keys. The signer should be OK with
it.
> Also, it would be nice to add a few scenarios related to expired authz toke
Done
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token-test.cc@362
PS1, Line 362: ASSERT_OK(GeneratePrivateKey
> nit: move closer to the point of usage.
Done
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token-test.cc@364
PS1, Line 364: ASSERT_OK(private_key.ToString(
> Is this important for the test case? If not, remove this.
Done
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token-test.cc@395
PS1, Line 395: ST_F(TokenTest, TestGenerateAuthzToken) {
> I'm not sure it's worth adding a method just for this piece.
Done
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token.proto
File src/kudu/security/token.proto:
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token.proto@31
PS1, Line 31: apply.
> 'apply'
Done
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token.proto@37
PS1, Line 37: // privileges specified in `column_privileges`.
> I'm weakly in favor of not having an 'all_privileges' flag, and instead tra
SGTM
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token.proto@39
PS1, Line 39:
: // If set, the user is authorized to insert rows into the table.
: optional bool insert_privilege= 4;
:
: // If set, the user is authorized
> Maybe, use oneof (union-like message) for 'scan_privilege' and 'column_priv
Hrm, I'm somewhat on the fence about this. As implemented, that would make
sense. OTOH, if we ever decide to implement per-column write privileges, or
other kinds of column-level privileges, it might be a hassle to untangle it.
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token.proto@49
PS1, Line 49: // Per-column privileges, indexed b
> We don't support authz on per-column basis for update, right?
Right, if a user wants to update a single column, they will need update
privileges on the entire table.
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token.proto@64
PS1, Line 64: // unix
> That was a generic question regarding current authz token design and whethe
It's a good question; I chatted a bit about this with Dan in person. I think
we're fine leaving it as is, since we don't expect single-table tokens to
change. Generally they're used to authorize requests to tservers, which are
unaware of tables anyway. From there, we can assume requests to tservers are
either scoped to a tablet (and thus scoped to a table), or are not scoped to a
single tablet and in fact originate from tooling.
Also, a nice thing about protobuf is that optional fields are compatible with
repeated fields if we choose to make this repeated in the future. See bullet 10
here: https://developers.google.com/protocol-buffers/docs/proto#updating
optional is compatible with repeated. Given serialized data of a repeated
field as input, clients that expect this field to be optional will take the
last input value if it's a primitive type field or merge all input elements if
it's a message type field.
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token_signer.h
File src/kudu/security/token_signer.h:
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token_signer.h@a119
PS1, Line 119:
:
> I see this piece has been dropped. Does it mean verifiers now enforce some
Ah, no, I was unsure of why this sentence was important so I removed it. I'll
add something to the effect of "It's not crucial so we don't verify the
beginning of the period"
http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token_signer.h@31
PS1, Line 31: namespace kudu {
> although this looks like it may not even be needed; I
[kudu-CR] KUDU-2542: add initial authorization token impl
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11750 to look at the new patch set (#2). Change subject: KUDU-2542: add initial authorization token impl .. KUDU-2542: add initial authorization token impl This patch adds adds an authorization token that echoes the authentication token implementation. These tokens contain privileges that will be used authorize specific tablet server requests. By in large, tablet server requests are scoped to a single table, and as such, so are authz tokens. In cases where this is not true (e.g. ListTablets), a reasonable assumption is that the call is being made via tooling, and coarse-grained access control should be used instead of fine-grained. If this ends up being less the case in the future, we can always amend the authz token to support multiple tables. The tokens leverage the same token signer as the authentication tokens, though with the token validity interval configured via the new flag --authz_token_validity_seconds. Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f --- M src/kudu/integration-tests/authn_token_expire-itest.cc M src/kudu/integration-tests/security-unknown-tsk-itest.cc M src/kudu/integration-tests/token_signer-itest.cc M src/kudu/master/master.cc M src/kudu/rpc/negotiation-test.cc M src/kudu/security/token-test.cc M src/kudu/security/token.proto M src/kudu/security/token_signer.cc M src/kudu/security/token_signer.h 9 files changed, 385 insertions(+), 76 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/11750/2 -- To view, visit http://gerrit.cloudera.org:8080/11750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f Gerrit-Change-Number: 11750 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] docs: Add scripts to automate web site update for releases
Attila Bukor has posted comments on this change. (
http://gerrit.cloudera.org:8080/8800 )
Change subject: docs: Add scripts to automate web site update for releases
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8800/1/docs/support/scripts/prepare_release_docs.sh
File docs/support/scripts/prepare_release_docs.sh:
http://gerrit.cloudera.org:8080/#/c/8800/1/docs/support/scripts/prepare_release_docs.sh@47
PS1, Line 47: for dir in $DOCS_DIRECTORIES; do
the apidocs, cpp-client-api and docs directories in $DEST_DIR should be
symlinks to $DEST_DIR/$RELEASE_DIR/$VERSION/{apidocs,cpp-client-api,docs}
instead of copying them to two places
--
To view, visit http://gerrit.cloudera.org:8080/8800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If55437e0561f0bf8e5e0ec0ae6e5bfca0311fb7d
Gerrit-Change-Number: 8800
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Wed, 24 Oct 2018 23:58:35 +
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 ) Change subject: Updating web site for Kudu 1.8.0 release .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11772/3/releases/index.md File releases/index.md: http://gerrit.cloudera.org:8080/#/c/11772/3/releases/index.md@18 PS3, Line 18: nit: an extra space -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: helifu Gerrit-Comment-Date: Wed, 24 Oct 2018 23:57:18 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [blog] Add post about 1.8.0 release
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11776 ) Change subject: [blog] Add post about 1.8.0 release .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I99fd23683e7417ca9bc836edf49a7e02e36c6b74 Gerrit-Change-Number: 11776 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 24 Oct 2018 23:46:45 + Gerrit-HasComments: No
[kudu-CR](gh-pages) [blog] Add post about 1.8.0 release
Hello Mike Percy, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11776 to look at the new patch set (#2). Change subject: [blog] Add post about 1.8.0 release .. [blog] Add post about 1.8.0 release Change-Id: I99fd23683e7417ca9bc836edf49a7e02e36c6b74 --- A _posts/2018-10-25-apache-kudu-1-8-0-released.md 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11776/2 -- To view, visit http://gerrit.cloudera.org:8080/11776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newpatchset Gerrit-Change-Id: I99fd23683e7417ca9bc836edf49a7e02e36c6b74 Gerrit-Change-Number: 11776 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) [blog] Add post about 1.8.0 release
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11776 ) Change subject: [blog] Add post about 1.8.0 release .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11776/1/_posts/2018-10-25-apache-kudu-1-8-0-released.md File _posts/2018-10-25-apache-kudu-1-8-0-released.md: http://gerrit.cloudera.org:8080/#/c/11776/1/_posts/2018-10-25-apache-kudu-1-8-0-released.md@18 PS1, Line 18: - Multiple tooling improvements make diagnostics and troubleshooting simpler > Maybe we should list Done http://gerrit.cloudera.org:8080/#/c/11776/1/_posts/2018-10-25-apache-kudu-1-8-0-released.md@25 PS1, Line 25: notes](/releases/1.8.0/docs/release_notes.html). > 1.8.0 Done -- To view, visit http://gerrit.cloudera.org:8080/11776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I99fd23683e7417ca9bc836edf49a7e02e36c6b74 Gerrit-Change-Number: 11776 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 24 Oct 2018 23:46:12 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [blog] Add post about 1.8.0 release
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11776 ) Change subject: [blog] Add post about 1.8.0 release .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11776/1/_posts/2018-10-25-apache-kudu-1-8-0-released.md File _posts/2018-10-25-apache-kudu-1-8-0-released.md: http://gerrit.cloudera.org:8080/#/c/11776/1/_posts/2018-10-25-apache-kudu-1-8-0-released.md@18 PS1, Line 18: - Multiple tooling improvements make diagnostics and troubleshooting simpler Maybe we should list - The Kudu Spark connector now supports Spark Streaming DataFrames - Added Pandas support to the Python client http://gerrit.cloudera.org:8080/#/c/11776/1/_posts/2018-10-25-apache-kudu-1-8-0-released.md@25 PS1, Line 25: 1.7.0, follow these steps: 1.8.0 -- To view, visit http://gerrit.cloudera.org:8080/11776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I99fd23683e7417ca9bc836edf49a7e02e36c6b74 Gerrit-Change-Number: 11776 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 24 Oct 2018 23:44:09 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 ) Change subject: Updating web site for Kudu 1.8.0 release .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: helifu Gerrit-Comment-Date: Wed, 24 Oct 2018 23:29:47 + Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Bump version to 1.8.1-SNAPSHOT
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11774 ) Change subject: Bump version to 1.8.1-SNAPSHOT .. Bump version to 1.8.1-SNAPSHOT Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Reviewed-on: http://gerrit.cloudera.org:8080/11774 Reviewed-by: Grant Henke Tested-by: Attila Bukor --- M java/gradle.properties M java/kudu-backup/pom.xml M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-hive/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M python/setup.py M version.txt 13 files changed, 13 insertions(+), 13 deletions(-) Approvals: Grant Henke: Looks good to me, approved Attila Bukor: Verified -- To view, visit http://gerrit.cloudera.org:8080/11774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: merged Gerrit-Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Gerrit-Change-Number: 11774 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy
[kudu-CR](branch-1.8.x) Bump version to 1.8.1-SNAPSHOT
Attila Bukor has removed a vote on this change. Change subject: Bump version to 1.8.1-SNAPSHOT .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: deleteVote Gerrit-Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Gerrit-Change-Number: 11774 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy
[kudu-CR](branch-1.8.x) Bump version to 1.8.1-SNAPSHOT
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11774 ) Change subject: Bump version to 1.8.1-SNAPSHOT .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: comment Gerrit-Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Gerrit-Change-Number: 11774 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 24 Oct 2018 23:28:46 + Gerrit-HasComments: No
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 ) Change subject: Updating web site for Kudu 1.8.0 release .. Patch Set 3: > Patch Set 2: > > Good question. Not sure why I didn't do /docs. I did change it to a symlink as well, tested it locally, site_tool proof works, so does site_tool jekyll build (double verified by starting a webserver in _site and confirmed the website is ok) -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: helifu Gerrit-Comment-Date: Wed, 24 Oct 2018 23:27:28 + Gerrit-HasComments: No
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Hello Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Andrew Wong, helifu, Adar Dembo, Anonymous Coward (314), Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11772 to look at the new patch set (#3). Change subject: Updating web site for Kudu 1.8.0 release .. Updating web site for Kudu 1.8.0 release Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 --- M apidocs M cpp-client-api A docs D docs/administration.html D docs/background_tasks.html D docs/command_line_tools.html D docs/command_line_tools_reference.html D docs/configuration.html D docs/configuration_reference.html D docs/configuration_reference_unsupported.html D docs/contributing.html D docs/developing.html D docs/export_control.html D docs/index.html D docs/installation.html D docs/known_issues.html D docs/kudu-master_configuration_reference.html D docs/kudu-master_configuration_reference_unsupported.html D docs/kudu-tserver_configuration_reference.html D docs/kudu-tserver_configuration_reference_unsupported.html D docs/kudu_impala_integration.html D docs/prior_release_notes.html D docs/quickstart.html D docs/release_notes.html D docs/scaling_guide.html D docs/schema_design.html D docs/security.html D docs/transaction_semantics.html D docs/troubleshooting.html A releases/1.8.0/apidocs/allclasses-frame.html A releases/1.8.0/apidocs/allclasses-noframe.html A releases/1.8.0/apidocs/constant-values.html A releases/1.8.0/apidocs/deprecated-list.html A releases/1.8.0/apidocs/help-doc.html A releases/1.8.0/apidocs/index-all.html A releases/1.8.0/apidocs/index.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.ColumnSchemaBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.CompressionAlgorithm.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.Encoding.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnTypeAttributes.html A releases/1.8.0/apidocs/org/apache/kudu/Schema.html A releases/1.8.0/apidocs/org/apache/kudu/Type.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-frame.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-summary.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-tree.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-use.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.ColumnSchemaBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.CompressionAlgorithm.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.Encoding.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnTypeAttributes.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/Schema.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/Type.html A releases/1.8.0/apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/AlterTableOptions.html A releases/1.8.0/apidocs/org/apache/kudu/client/AlterTableResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduClient.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduSession.html A releases/1.8.0/apidocs/org/apache/kudu/client/ColumnRangePredicate.html A releases/1.8.0/apidocs/org/apache/kudu/client/CreateTableOptions.html A releases/1.8.0/apidocs/org/apache/kudu/client/Delete.html A releases/1.8.0/apidocs/org/apache/kudu/client/DeleteTableResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/ExternalConsistencyMode.html A releases/1.8.0/apidocs/org/apache/kudu/client/HasFailedRpcException.html A releases/1.8.0/apidocs/org/apache/kudu/client/Insert.html A releases/1.8.0/apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/IsCreateTableDoneResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduClient.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduException.OriginalException.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduException.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduPredicate.html A
[kudu-CR](gh-pages) [blog] Add post about 1.8.0 release
Hello Mike Percy, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11776 to review the following change. Change subject: [blog] Add post about 1.8.0 release .. [blog] Add post about 1.8.0 release Change-Id: I99fd23683e7417ca9bc836edf49a7e02e36c6b74 --- A _posts/2018-10-25-apache-kudu-1-8-0-released.md 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11776/1 -- To view, visit http://gerrit.cloudera.org:8080/11776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newchange Gerrit-Change-Id: I99fd23683e7417ca9bc836edf49a7e02e36c6b74 Gerrit-Change-Number: 11776 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 ) Change subject: Updating web site for Kudu 1.8.0 release .. Patch Set 2: Good question. Not sure why I didn't do /docs. -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: helifu Gerrit-Comment-Date: Wed, 24 Oct 2018 23:00:34 + Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Bump version to 1.8.1-SNAPSHOT
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11774 ) Change subject: Bump version to 1.8.1-SNAPSHOT .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: comment Gerrit-Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Gerrit-Change-Number: 11774 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 24 Oct 2018 22:59:46 + Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Bump version to 1.8.1-SNAPSHOT
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11774 ) Change subject: Bump version to 1.8.1-SNAPSHOT .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11774/1/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/11774/1/java/pom.xml@73 PS1, Line 73: 1.8.1-SNAPSHOT > You're right, I used sed and I somehow didn't notice it changed other stuff Not that it's relevant anymore in master but this maven command does it: ` mvn versions:set -DnewVersion=1.x.y-SNAPSHOT` -- To view, visit http://gerrit.cloudera.org:8080/11774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: comment Gerrit-Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Gerrit-Change-Number: 11774 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 24 Oct 2018 22:59:00 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add archived releases section
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/11295 ) Change subject: Add archived releases section .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: abandon Gerrit-Change-Id: I671f58c8c67604876573f31936a5dc764302098b Gerrit-Change-Number: 11295 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [docs] Update release notes after 1.8.0 release
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11773 ) Change subject: [docs] Update release notes after 1.8.0 release .. [docs] Update release notes after 1.8.0 release - add 1.8.0 and 1.7.1 release notes to prior release notes - add missing release notes anchors to prior release notes - bump versions in release notes boilerplate to 1.9 Change-Id: If74d9c8821c16782ecf1ee97d101a90e004d74e2 Reviewed-on: http://gerrit.cloudera.org:8080/11773 Reviewed-by: Grant Henke Tested-by: Kudu Jenkins --- M docs/prior_release_notes.adoc M docs/release_notes.adoc 2 files changed, 381 insertions(+), 28 deletions(-) Approvals: Grant Henke: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If74d9c8821c16782ecf1ee97d101a90e004d74e2 Gerrit-Change-Number: 11773 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [kudu-jepsen] updated jepsen and clojureToolsCli
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11775 Change subject: WIP [kudu-jepsen] updated jepsen and clojureToolsCli .. WIP [kudu-jepsen] updated jepsen and clojureToolsCli Updated a couple of kudu-jepsen dependencies: clojureToolsCli: 0.3.5 --> 0.4.1 jepsen : 0.1.5 --> 0.1.10 As for the motivation behind these updates: * CentOS is now supported for the Jepsen control and DB nodes * Faster network partitioning (up to 20x times) * Multiple improvements on docker-related setup * Other numerous improvements WIP: need to address the deprecation warnings from the Jepsen Kudu tests. WIP: clarify why the Kudu Jepsen test hangs with the updated jepsen Change-Id: I71c9cc1d4fb984533b4ca0af09d6abe8f4e4159f --- M java/gradle/dependencies.gradle M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj 3 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/11775/1 -- To view, visit http://gerrit.cloudera.org:8080/11775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I71c9cc1d4fb984533b4ca0af09d6abe8f4e4159f Gerrit-Change-Number: 11775 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [location awareness] Add ts location to TSInfoPB
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/11727 )
Change subject: [location_awareness] Add ts location to TSInfoPB
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc
File src/kudu/integration-tests/table_locations-itest.cc:
http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@294
PS5, Line 294: EXPECT_EQ("",
resp.tablet_locations(0).replicas(0).ts_info().location());
nit: could you add ASSERT_EQ() on the expected number of locations returned in
the response before trying to access the very first one by
resp.tablet_locations(0)? Similar ASSERT_EQ() for replicas() within each
location.
http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@317
PS5, Line 317: replicas(0)
nit: how many replicas do you expect to be returned in the response? If
multiple, I think it's worth verifying that ts_info for every replica has the
expected location.
--
To view, visit http://gerrit.cloudera.org:8080/11727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259
Gerrit-Change-Number: 11727
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Fengling Wang
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Wed, 24 Oct 2018 22:18:14 +
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Bump version to 1.8.1-SNAPSHOT
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11774 ) Change subject: Bump version to 1.8.1-SNAPSHOT .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11774/1/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/11774/1/java/pom.xml@73 PS1, Line 73: 1.8.0 > I don't think this changes. You're right, I used sed and I somehow didn't notice it changed other stuff too -- To view, visit http://gerrit.cloudera.org:8080/11774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: comment Gerrit-Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Gerrit-Change-Number: 11774 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 24 Oct 2018 22:07:58 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Bump version to 1.8.1-SNAPSHOT
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11774 to look at the new patch set (#2). Change subject: Bump version to 1.8.1-SNAPSHOT .. Bump version to 1.8.1-SNAPSHOT Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 --- M java/gradle.properties M java/kudu-backup/pom.xml M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-hive/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M python/setup.py M version.txt 13 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/11774/2 -- To view, visit http://gerrit.cloudera.org:8080/11774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Gerrit-Change-Number: 11774 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Hello Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Andrew Wong, helifu, Adar Dembo, Anonymous Coward (314), Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11772 to look at the new patch set (#2). Change subject: Updating web site for Kudu 1.8.0 release .. Updating web site for Kudu 1.8.0 release Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 --- M apidocs M cpp-client-api M docs/administration.html M docs/background_tasks.html M docs/command_line_tools.html M docs/command_line_tools_reference.html M docs/configuration.html M docs/configuration_reference.html M docs/configuration_reference_unsupported.html M docs/contributing.html M docs/developing.html M docs/export_control.html M docs/index.html M docs/installation.html M docs/known_issues.html M docs/kudu-master_configuration_reference.html M docs/kudu-master_configuration_reference_unsupported.html M docs/kudu-tserver_configuration_reference.html M docs/kudu-tserver_configuration_reference_unsupported.html M docs/kudu_impala_integration.html M docs/prior_release_notes.html M docs/quickstart.html M docs/release_notes.html M docs/scaling_guide.html M docs/schema_design.html M docs/security.html M docs/transaction_semantics.html M docs/troubleshooting.html A releases/1.8.0/apidocs/allclasses-frame.html A releases/1.8.0/apidocs/allclasses-noframe.html A releases/1.8.0/apidocs/constant-values.html A releases/1.8.0/apidocs/deprecated-list.html A releases/1.8.0/apidocs/help-doc.html A releases/1.8.0/apidocs/index-all.html A releases/1.8.0/apidocs/index.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.ColumnSchemaBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.CompressionAlgorithm.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.Encoding.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnSchema.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/ColumnTypeAttributes.html A releases/1.8.0/apidocs/org/apache/kudu/Schema.html A releases/1.8.0/apidocs/org/apache/kudu/Type.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-frame.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-summary.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-tree.html A releases/1.8.0/apidocs/org/apache/kudu/backup/package-use.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.ColumnSchemaBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.CompressionAlgorithm.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.Encoding.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnSchema.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/ColumnTypeAttributes.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/Schema.html A releases/1.8.0/apidocs/org/apache/kudu/class-use/Type.html A releases/1.8.0/apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/AlterTableOptions.html A releases/1.8.0/apidocs/org/apache/kudu/client/AlterTableResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduClient.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.html A releases/1.8.0/apidocs/org/apache/kudu/client/AsyncKuduSession.html A releases/1.8.0/apidocs/org/apache/kudu/client/ColumnRangePredicate.html A releases/1.8.0/apidocs/org/apache/kudu/client/CreateTableOptions.html A releases/1.8.0/apidocs/org/apache/kudu/client/Delete.html A releases/1.8.0/apidocs/org/apache/kudu/client/DeleteTableResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/ExternalConsistencyMode.html A releases/1.8.0/apidocs/org/apache/kudu/client/HasFailedRpcException.html A releases/1.8.0/apidocs/org/apache/kudu/client/Insert.html A releases/1.8.0/apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/IsCreateTableDoneResponse.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduClient.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduException.OriginalException.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduException.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html A releases/1.8.0/apidocs/org/apache/kudu/client/KuduPredicate.html A
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 ) Change subject: Updating web site for Kudu 1.8.0 release .. Patch Set 1: > Patch Set 1: > > (1 comment) sure, good idea. why not docs though? -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: helifu Gerrit-Comment-Date: Wed, 24 Oct 2018 22:00:09 + Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Bump version to 1.8.1-SNAPSHOT
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11774 ) Change subject: Bump version to 1.8.1-SNAPSHOT .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11774/1/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/11774/1/java/pom.xml@73 PS1, Line 73: 1.8.1-SNAPSHOT I don't think this changes. -- To view, visit http://gerrit.cloudera.org:8080/11774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: comment Gerrit-Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Gerrit-Change-Number: 11774 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 24 Oct 2018 21:59:51 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 ) Change subject: Updating web site for Kudu 1.8.0 release .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11772/1/cpp-client-api File cpp-client-api: http://gerrit.cloudera.org:8080/#/c/11772/1/cpp-client-api@a1 PS1, Line 1: Same for the cpp docs. -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: helifu Gerrit-Comment-Date: Wed, 24 Oct 2018 21:57:56 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Bump version to 1.8.1-SNAPSHOT
Hello Mike Percy, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11774 to review the following change. Change subject: Bump version to 1.8.1-SNAPSHOT .. Bump version to 1.8.1-SNAPSHOT Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 --- M java/gradle.properties M java/kudu-backup/pom.xml M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-hive/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M python/setup.py M version.txt 13 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/11774/1 -- To view, visit http://gerrit.cloudera.org:8080/11774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: newchange Gerrit-Change-Id: I50d679823fda3404b2c5ba95f09f53ead673b2a1 Gerrit-Change-Number: 11774 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 ) Change subject: Updating web site for Kudu 1.8.0 release .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11772/1/apidocs File apidocs: http://gerrit.cloudera.org:8080/#/c/11772/1/apidocs@a1 PS1, Line 1: One of my earlier patches changed from duplicating the API docs to symbolically linking to the versioned ones. Can we keep doing that? -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: helifu Gerrit-Comment-Date: Wed, 24 Oct 2018 21:56:26 + Gerrit-HasComments: Yes
[kudu-CR] [docs] Update release notes after 1.8.0 release
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11773 ) Change subject: [docs] Update release notes after 1.8.0 release .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If74d9c8821c16782ecf1ee97d101a90e004d74e2 Gerrit-Change-Number: 11773 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Oct 2018 21:55:06 + Gerrit-HasComments: No
[kudu-CR] [docs] Update release notes after 1.8.0 release
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11773 to review the following change. Change subject: [docs] Update release notes after 1.8.0 release .. [docs] Update release notes after 1.8.0 release - add 1.8.0 and 1.7.1 release notes to prior release notes - add missing release notes anchors to prior release notes - bump versions in release notes boilerplate to 1.9 Change-Id: If74d9c8821c16782ecf1ee97d101a90e004d74e2 --- M docs/prior_release_notes.adoc M docs/release_notes.adoc 2 files changed, 381 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11773/1 -- To view, visit http://gerrit.cloudera.org:8080/11773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If74d9c8821c16782ecf1ee97d101a90e004d74e2 Gerrit-Change-Number: 11773 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke
[kudu-CR] [kudu-jepsen] standardize layout of test resource files
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11769 ) Change subject: [kudu-jepsen] standardize layout of test resource files .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c Gerrit-Change-Number: 11769 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke
[kudu-CR] [kudu-jepsen] standardize layout of test resource files
Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/11769 )
Change subject: [kudu-jepsen] standardize layout of test resource files
..
[kudu-jepsen] standardize layout of test resource files
The kudu-jepsen resources were located under ./resources sub-directory
(instead of the 'standard' layout of ./src/{main,test}/resources).
After switching to gradle build, the files under ./resources are no
longer put into corresponding JARs since gradle is unaware of the
custom resource sub-directory. Instead adding the ./resources
sub-directory into the list of resources directories for gradle,
let's just move it to comply with the standard resources layout.
Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c
Reviewed-on: http://gerrit.cloudera.org:8080/11769
Reviewed-by: Grant Henke
Tested-by: Alexey Serbin
---
R java/kudu-jepsen/src/test/resources/kudu.flags
R java/kudu-jepsen/src/test/resources/ntp.conf.common
R java/kudu-jepsen/src/test/resources/ntp.conf.server
3 files changed, 0 insertions(+), 0 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c
Gerrit-Change-Number: 11769
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
[kudu-CR] [kudu-jepsen] standardize layout of test resource files
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11769 ) Change subject: [kudu-jepsen] standardize layout of test resource files .. Patch Set 2: Verified+1 Unrelated flake in ConcurrentRebalancersTest.TwoConcurrentRebalancers/1 -- To view, visit http://gerrit.cloudera.org:8080/11769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c Gerrit-Change-Number: 11769 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Oct 2018 21:29:58 + Gerrit-HasComments: No
[kudu-CR](gh-pages) Updating web site for Kudu 1.8.0 release
Hello Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, helifu, Andrew Wong, Anonymous Coward (314), Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11772 to review the following change. Change subject: Updating web site for Kudu 1.8.0 release .. Updating web site for Kudu 1.8.0 release Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 --- D apidocs A apidocs/allclasses-frame.html A apidocs/allclasses-noframe.html A apidocs/constant-values.html A apidocs/deprecated-list.html A apidocs/help-doc.html A apidocs/index-all.html A apidocs/index.html A apidocs/org/apache/kudu/ColumnSchema.ColumnSchemaBuilder.html A apidocs/org/apache/kudu/ColumnSchema.CompressionAlgorithm.html A apidocs/org/apache/kudu/ColumnSchema.Encoding.html A apidocs/org/apache/kudu/ColumnSchema.html A apidocs/org/apache/kudu/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html A apidocs/org/apache/kudu/ColumnTypeAttributes.html A apidocs/org/apache/kudu/Schema.html A apidocs/org/apache/kudu/Type.html A apidocs/org/apache/kudu/backup/package-frame.html A apidocs/org/apache/kudu/backup/package-summary.html A apidocs/org/apache/kudu/backup/package-tree.html A apidocs/org/apache/kudu/backup/package-use.html A apidocs/org/apache/kudu/class-use/ColumnSchema.ColumnSchemaBuilder.html A apidocs/org/apache/kudu/class-use/ColumnSchema.CompressionAlgorithm.html A apidocs/org/apache/kudu/class-use/ColumnSchema.Encoding.html A apidocs/org/apache/kudu/class-use/ColumnSchema.html A apidocs/org/apache/kudu/class-use/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html A apidocs/org/apache/kudu/class-use/ColumnTypeAttributes.html A apidocs/org/apache/kudu/class-use/Schema.html A apidocs/org/apache/kudu/class-use/Type.html A apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html A apidocs/org/apache/kudu/client/AlterTableOptions.html A apidocs/org/apache/kudu/client/AlterTableResponse.html A apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html A apidocs/org/apache/kudu/client/AsyncKuduClient.html A apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html A apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html A apidocs/org/apache/kudu/client/AsyncKuduScanner.html A apidocs/org/apache/kudu/client/AsyncKuduSession.html A apidocs/org/apache/kudu/client/ColumnRangePredicate.html A apidocs/org/apache/kudu/client/CreateTableOptions.html A apidocs/org/apache/kudu/client/Delete.html A apidocs/org/apache/kudu/client/DeleteTableResponse.html A apidocs/org/apache/kudu/client/ExternalConsistencyMode.html A apidocs/org/apache/kudu/client/HasFailedRpcException.html A apidocs/org/apache/kudu/client/Insert.html A apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html A apidocs/org/apache/kudu/client/IsCreateTableDoneResponse.html A apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html A apidocs/org/apache/kudu/client/KuduClient.html A apidocs/org/apache/kudu/client/KuduException.OriginalException.html A apidocs/org/apache/kudu/client/KuduException.html A apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html A apidocs/org/apache/kudu/client/KuduPredicate.html A apidocs/org/apache/kudu/client/KuduScanToken.KuduScanTokenBuilder.html A apidocs/org/apache/kudu/client/KuduScanToken.html A apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html A apidocs/org/apache/kudu/client/KuduScanner.html A apidocs/org/apache/kudu/client/KuduSession.html A apidocs/org/apache/kudu/client/KuduTable.html A apidocs/org/apache/kudu/client/ListTablesResponse.html A apidocs/org/apache/kudu/client/ListTabletServersResponse.html A apidocs/org/apache/kudu/client/LocatedTablet.Replica.html A apidocs/org/apache/kudu/client/LocatedTablet.html A apidocs/org/apache/kudu/client/Operation.html A apidocs/org/apache/kudu/client/OperationResponse.html A apidocs/org/apache/kudu/client/PartialRow.html A apidocs/org/apache/kudu/client/PleaseThrottleException.html A apidocs/org/apache/kudu/client/RangePartitionBound.html A apidocs/org/apache/kudu/client/ReplicaSelection.html A apidocs/org/apache/kudu/client/RowError.html A apidocs/org/apache/kudu/client/RowErrorsAndOverflowStatus.html A apidocs/org/apache/kudu/client/RowResult.html A apidocs/org/apache/kudu/client/RowResultIterator.html A apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html A apidocs/org/apache/kudu/client/SessionConfiguration.html A apidocs/org/apache/kudu/client/Statistics.Statistic.html A apidocs/org/apache/kudu/client/Statistics.html A apidocs/org/apache/kudu/client/Status.html A apidocs/org/apache/kudu/client/Update.html A apidocs/org/apache/kudu/client/Upsert.html A apidocs/org/apache/kudu/client/class-use/AbstractKuduScannerBuilder.html A apidocs/org/apache/kudu/client/class-use/AlterTableOptions.html A apidocs/org/apache/kudu/client/class-use/AlterTableResponse.html A
[kudu-CR] docs: Add scripts to automate web site update for releases
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/8800 ) Change subject: docs: Add scripts to automate web site update for releases .. Patch Set 1: (2 comments) Mike, could you also add this to the RELEASING docs after the make_site.sh paragraph? http://gerrit.cloudera.org:8080/#/c/8800/1/docs/support/scripts/prepare_release_docs.sh File docs/support/scripts/prepare_release_docs.sh: http://gerrit.cloudera.org:8080/#/c/8800/1/docs/support/scripts/prepare_release_docs.sh@68 PS1, Line 68: git commit -m "Updating web site for Kudu $VERSION release" > It assumes you already did that. If we want it to do that we could, with th I think it would be a good idea to document these kind of stuff. It doesn't seem straight-forward. Also, the docs could potentially mention that git worktree can be used to check out the gh-pages branch instead of multiple clones of the repo (Todd mentioned it the other day and it's a game changer) http://gerrit.cloudera.org:8080/#/c/8800/1/docs/support/scripts/release_index.md.template File docs/support/scripts/release_index.md.template: http://gerrit.cloudera.org:8080/#/c/8800/1/docs/support/scripts/release_index.md.template@37 PS1, Line 37: [MD5](https://www.apache.org/dist/kudu/%VERSION%/apache-kudu-%VERSION%.tar.gz.md5), MD5 should be removed too -- To view, visit http://gerrit.cloudera.org:8080/8800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If55437e0561f0bf8e5e0ec0ae6e5bfca0311fb7d Gerrit-Change-Number: 8800 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 24 Oct 2018 21:09:27 + Gerrit-HasComments: Yes
[kudu-CR] [kudu-jepsen] standardize layout of test resource files
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11769 ) Change subject: [kudu-jepsen] standardize layout of test resource files .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c Gerrit-Change-Number: 11769 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Oct 2018 20:37:50 + Gerrit-HasComments: No
[kudu-CR] [kudu-jepsen] standardize layout of test resource files
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11769 ) Change subject: [kudu-jepsen] standardize layout of test resource files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11769/1/java/kudu-jepsen/build.gradle File java/kudu-jepsen/build.gradle: http://gerrit.cloudera.org:8080/#/c/11769/1/java/kudu-jepsen/build.gradle@43 PS1, Line 43: srcDirs "resources" > Perhaps using the standard structure makes more sense? Unless there is valu Done -- To view, visit http://gerrit.cloudera.org:8080/11769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c Gerrit-Change-Number: 11769 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Oct 2018 20:37:25 + Gerrit-HasComments: Yes
[kudu-CR] [kudu-jepsen] standardize layout of test resource files
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11769
to look at the new patch set (#2).
Change subject: [kudu-jepsen] standardize layout of test resource files
..
[kudu-jepsen] standardize layout of test resource files
The kudu-jepsen resources were located under ./resources sub-directory
(instead of the 'standard' layout of ./src/{main,test}/resources).
After switching to gradle build, the files under ./resources are no
longer put into corresponding JARs since gradle is unaware of the
custom resource sub-directory. Instead adding the ./resources
sub-directory into the list of resources directories for gradle,
let's just move it to comply with the standard resources layout.
Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c
---
R java/kudu-jepsen/src/test/resources/kudu.flags
R java/kudu-jepsen/src/test/resources/ntp.conf.common
R java/kudu-jepsen/src/test/resources/ntp.conf.server
3 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/11769/2
--
To view, visit http://gerrit.cloudera.org:8080/11769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c
Gerrit-Change-Number: 11769
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] added derby.log into .gitignore
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11770 Change subject: [java] added derby.log into .gitignore .. [java] added derby.log into .gitignore Change-Id: Ieee340918cb4754554b1fbd1d7d953c101ecd2d6 --- M java/.gitignore 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/11770/1 -- To view, visit http://gerrit.cloudera.org:8080/11770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieee340918cb4754554b1fbd1d7d953c101ecd2d6 Gerrit-Change-Number: 11770 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [kudu-jepsen] added resources to the build rules
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11769 ) Change subject: [kudu-jepsen] added resources to the build rules .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11769/1/java/kudu-jepsen/build.gradle File java/kudu-jepsen/build.gradle: http://gerrit.cloudera.org:8080/#/c/11769/1/java/kudu-jepsen/build.gradle@43 PS1, Line 43: srcDirs "resources" Perhaps using the standard structure makes more sense? Unless there is value in being custom. -- To view, visit http://gerrit.cloudera.org:8080/11769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c Gerrit-Change-Number: 11769 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Oct 2018 19:55:17 + Gerrit-HasComments: Yes
[kudu-CR] [kudu-jepsen] added resources to the build rules
Alexey Serbin has uploaded this change for review. (
http://gerrit.cloudera.org:8080/11769
Change subject: [kudu-jepsen] added resources to the build rules
..
[kudu-jepsen] added resources to the build rules
The kudu-jepsen resources are located under ./resources sub-directory
(instead of the 'standard' layout of ./src/{main,test}/resources).
This patch adds the ./resources sub-directory into the list of
resources directories for gradle.
Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c
---
M java/kudu-jepsen/build.gradle
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/11769/1
--
To view, visit http://gerrit.cloudera.org:8080/11769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf4f6224c301c8246848cad74d8a848b77e9de0c
Gerrit-Change-Number: 11769
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
[kudu-CR] Follow-up for commit fff0da840
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11768 ) Change subject: Follow-up for commit fff0da840 .. Follow-up for commit fff0da840 Change-Id: Ida8c8ee2c0950b3d71aa7f4bbf0b86ef53f567f9 Reviewed-on: http://gerrit.cloudera.org:8080/11768 Reviewed-by: Will Berkeley Tested-by: Kudu Jenkins --- M src/kudu/tablet/transactions/transaction_tracker-test.cc M src/kudu/tablet/transactions/transaction_tracker.cc 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Will Berkeley: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ida8c8ee2c0950b3d71aa7f4bbf0b86ef53f567f9 Gerrit-Change-Number: 11768 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] Follow-up for commit fff0da840
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11768 ) Change subject: Follow-up for commit fff0da840 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida8c8ee2c0950b3d71aa7f4bbf0b86ef53f567f9 Gerrit-Change-Number: 11768 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 24 Oct 2018 18:36:39 + Gerrit-HasComments: No
[kudu-CR] transaction tracker: add more information to the out-of-memory message
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11765 ) Change subject: transaction_tracker: add more information to the out-of-memory message .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc@116 PS2, Line 116: was $2 and the current consumption is $3 > The issue is that (current consumption) + (tx consumption) > (mem tracket l Ah, that's a much better wording; I shouldn't have submitted so fast. Posted a follow-up here: https://gerrit.cloudera.org/c/11768 http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc@115 PS2, Line 115: transaction " : "consumption' > transaction's consumption Done -- To view, visit http://gerrit.cloudera.org:8080/11765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 Gerrit-Change-Number: 11765 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 24 Oct 2018 18:29:59 + Gerrit-HasComments: Yes
[kudu-CR] Follow-up for commit fff0da840
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11768 to review the following change. Change subject: Follow-up for commit fff0da840 .. Follow-up for commit fff0da840 Change-Id: Ida8c8ee2c0950b3d71aa7f4bbf0b86ef53f567f9 --- M src/kudu/tablet/transactions/transaction_tracker-test.cc M src/kudu/tablet/transactions/transaction_tracker.cc 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/11768/1 -- To view, visit http://gerrit.cloudera.org:8080/11768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ida8c8ee2c0950b3d71aa7f4bbf0b86ef53f567f9 Gerrit-Change-Number: 11768 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Will Berkeley
[kudu-CR] transaction tracker: add more information to the out-of-memory message
Will Berkeley has posted comments on this change. (
http://gerrit.cloudera.org:8080/11765 )
Change subject: transaction_tracker: add more information to the out-of-memory
message
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc
File src/kudu/tablet/transactions/transaction_tracker.cc:
http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc@116
PS2, Line 116: was $2 and the current consumption is $3
The issue is that (current consumption) + (tx consumption) > (mem tracket
limit), so the tx is rejected, if I'm understanding it right. Maybe the message
should be:
Substitute("transaction rejected due to memory pressure: the memory usage
of this transaction ($0) plus the current consumption ($1) exceeds the
transaction memory limit ($2) or the limit of an ancestral tracker",
driver_mem_foorprint, mem_tracker_->consumption(), mem_tracker_->limit());
http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc@115
PS2, Line 115: transaction "
: "consumption'
transaction's consumption
--
To view, visit http://gerrit.cloudera.org:8080/11765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9
Gerrit-Change-Number: 11765
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Wed, 24 Oct 2018 18:07:42 +
Gerrit-HasComments: Yes
[kudu-CR] transaction tracker: add more information to the out-of-memory message
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11765 ) Change subject: transaction_tracker: add more information to the out-of-memory message .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11765/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11765/2//COMMIT_MSG@16 PS2, Line 16: As far as I can tell, it can only happen if the failed transaction had : a colossal footprint of its own. > In this particular case, the transaction would repeatedly be retried and fa I mean, this is already pretty pathological from the get-go. See KUDU-2611; this stemmed from an attempt to create a table with 160k tablets, and this error was actually on the _master_. http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc@104 PS2, Line 104: SpaceUsed > nit: it's not related to this particular change, but I see SpaceUsed() is d Eh, since it's unrelated, I'm inclined to punt. -- To view, visit http://gerrit.cloudera.org:8080/11765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 Gerrit-Change-Number: 11765 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 24 Oct 2018 17:54:33 + Gerrit-HasComments: Yes
[kudu-CR] transaction tracker: add more information to the out-of-memory message
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11765 ) Change subject: transaction_tracker: add more information to the out-of-memory message .. transaction_tracker: add more information to the out-of-memory message A Slack user reported seeing an error like this: transaction_tracker.cc:119] Transaction failed, tablet \ transaction memory consumption (0) has \ exceeded its limit (67108864) or the limit of an ancestral tracker This doesn't make sense; how could the limit be exceeded if the consumption is 0? As far as I can tell, it can only happen if the failed transaction had a colossal footprint of its own. This patch changes the generated error to include the footprint of the transaction itself. Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 Reviewed-on: http://gerrit.cloudera.org:8080/11765 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin Reviewed-by: Andrew Wong --- M src/kudu/tablet/transactions/transaction_tracker-test.cc M src/kudu/tablet/transactions/transaction_tracker.cc 2 files changed, 12 insertions(+), 9 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 Gerrit-Change-Number: 11765 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley
[kudu-CR] transaction tracker: add more information to the out-of-memory message
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11765 ) Change subject: transaction_tracker: add more information to the out-of-memory message .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11765/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11765/2//COMMIT_MSG@16 PS2, Line 16: As far as I can tell, it can only happen if the failed transaction had : a colossal footprint of its own. In this particular case, the transaction would repeatedly be retried and failed, since the transaction itself is the problem? If so, I wonder if it's worth adding additional validation and surfacing fatal errors to avoid the retries. -- To view, visit http://gerrit.cloudera.org:8080/11765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 Gerrit-Change-Number: 11765 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 24 Oct 2018 17:49:50 + Gerrit-HasComments: Yes
[kudu-CR] transaction tracker: add more information to the out-of-memory message
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11765 ) Change subject: transaction_tracker: add more information to the out-of-memory message .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc@104 PS2, Line 104: SpaceUsed nit: it's not related to this particular change, but I see SpaceUsed() is declared deprecated and it casts size_t to int. Would it make sense to switch to SpaceUsedLong() here instead or at least verify (i.e. add CHECK()) that driver_mem_footprint is a positive number? -- To view, visit http://gerrit.cloudera.org:8080/11765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 Gerrit-Change-Number: 11765 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 24 Oct 2018 17:46:59 + Gerrit-HasComments: Yes
[kudu-CR] transaction tracker: add more information to the out-of-memory message
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11765 to look at the new patch set (#2). Change subject: transaction_tracker: add more information to the out-of-memory message .. transaction_tracker: add more information to the out-of-memory message A Slack user reported seeing an error like this: transaction_tracker.cc:119] Transaction failed, tablet \ transaction memory consumption (0) has \ exceeded its limit (67108864) or the limit of an ancestral tracker This doesn't make sense; how could the limit be exceeded if the consumption is 0? As far as I can tell, it can only happen if the failed transaction had a colossal footprint of its own. This patch changes the generated error to include the footprint of the transaction itself. Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 --- M src/kudu/tablet/transactions/transaction_tracker-test.cc M src/kudu/tablet/transactions/transaction_tracker.cc 2 files changed, 12 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/11765/2 -- To view, visit http://gerrit.cloudera.org:8080/11765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 Gerrit-Change-Number: 11765 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley
[kudu-CR] transaction tracker: add more information to the out-of-memory message
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11765 to review the following change. Change subject: transaction_tracker: add more information to the out-of-memory message .. transaction_tracker: add more information to the out-of-memory message A Slack user reported seeing an error like this: transaction_tracker.cc:119] Transaction failed, tablet \ transaction memory consumption (0) has \ exceeded its limit (67108864) or the limit of an ancestral tracker This doesn't make sense; how could the limit be exceeded if the consumption is 0? As far as I can tell, it can only happen if the failed transaction had a colossal footprint of its own. This patch changes the generated error to include the footprint of the transaction itself. Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 --- M src/kudu/tablet/transactions/transaction_tracker.cc 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/11765/1 -- To view, visit http://gerrit.cloudera.org:8080/11765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 Gerrit-Change-Number: 11765 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley
[kudu-CR] [location awareness] Add ts location to TSInfoPB
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/11727 )
Change subject: [location_awareness] Add ts location to TSInfoPB
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc
File src/kudu/integration-tests/table_locations-itest.cc:
http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@74
PS5, Line 74:
Add a call to SetUpConfig() here. Then you won't need to override SetUp() in
your new test fixture.
http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@216
PS5, Line 216: CheckMasterTableCreation(table_name, 8);
You need to surround these calls with NO_FATALS(); otherwise, errors in
CheckMasterTableCreation() won't be checked until the end of the test.
http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@294
PS5, Line 294: EXPECT_EQ("",
resp.tablet_locations(0).replicas(0).ts_info().location());
: EXPECT_EQ("",
resp.tablet_locations(0).replicas(1).ts_info().location());
: EXPECT_EQ("",
resp.tablet_locations(0).replicas(2).ts_info().location());
Nit: do this in a loop.
--
To view, visit http://gerrit.cloudera.org:8080/11727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259
Gerrit-Change-Number: 11727
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Fengling Wang
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Wed, 24 Oct 2018 14:17:24 +
Gerrit-HasComments: Yes
[kudu-CR] [sentry] SentryAuthzProvider
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/11659 )
Change subject: [sentry] SentryAuthzProvider
..
Patch Set 3:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider-test.cc
File src/kudu/sentry/sentry_authz_provider-test.cc:
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider-test.cc@72
PS3, Line 72: if (enable_kerberos) {
> I think I've seen this block of code at least 3 times now. Can we consolida
+1, pull this out into some Sentry test base and use it here and in
sentry_client-test, which has almost identical methods.
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider-test.cc@127
PS3, Line 127: ASSERT_TRUE(s.IsNotAuthorized()) << s.ToString();
> This is surprising; shouldn't it be NotFound() or something like that?
Why is this an error at all? Why not just set `authorized` to false? How does
the error make its way back to the user?
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider-test.cc@135
PS3, Line 135: // Authorize create table on a user without required privileges.
:
nit: extra line
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider-test.cc@137
PS3, Line 137: TCreateSentryRoleRequest role_req;
: role_req.__set_requestorUserName("test-admin");
: role_req.__set_roleName("developer");
: ASSERT_OK(sentry_client_->CreateRole(role_req));
:
: TSentryGroup group;
: group.groupName = "user";
: set groups;
: groups.insert(group);
: TAlterSentryRoleAddGroupsRequest group_requset;
: TAlterSentryRoleAddGroupsResponse group_response;
: group_requset.__set_requestorUserName("test-admin");
: group_requset.__set_roleName("developer");
: group_requset.__set_groups(groups);
: ASSERT_OK(sentry_client_->AlterRoleAddGroups(group_requset,
_response));
This is copied in every test, so maybe pull it into its own function (or
functions, if there's a clean division of functionality).
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider-test.cc@204
PS3, Line 204: TSentryPrivilege privilege;
: privilege.__set_privilegeScope("DATABASE");
: privilege.__set_serverName(FLAGS_server_name);
: privilege.__set_dbName("db");
: privilege.__set_action("SELECT");
nit: We're using these _a lot_ so maybe it's worth introducing PrivilegeForDb()
and PrivilegeForTable() methods?
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider.cc
File src/kudu/sentry/sentry_authz_provider.cc:
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider.cc@45
PS3, Line 45: RPC addresses of the Sentry service(s)
nit: Call out that it's a comma-separated list
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider.cc@55
PS3, Line 55: server
Is this a Sentry-specific thing? Hive-specific? Does it make sense to refer to
this as "Sentry server namespace" or "Hive server namespace" instead?
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider.cc@79
PS3, Line 79: SentryAuthzProvider::SentryAuthzProvider() {
: }
Remove
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider.cc@185
PS3, Line 185: privilege
nit: privileges
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider.cc@186
PS3, Line 186: implies
nit: imply (the privileges imply the authorizable, right?)
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider.cc@187
PS3, Line 187: action
nit: actions
http://gerrit.cloudera.org:8080/#/c/11659/3/src/kudu/sentry/sentry_authz_provider.cc@211
PS3, Line 211:
: bool SentryAuthzProvider::ValidateAddresses(const char*
flag_name,
: const string&
addresses) {
: vector host_ports;
: Status s = ParseAddresses(addresses, _ports);
: if (!s.ok()) {
: LOG(ERROR) << "invalid flag " << flag_name << ": " <<
s.ToString();
: }
: return s.ok();
: }
If this is only used as a flag validator, it doesn't need to be a part of this
class at all, right? Could just be a regular static method, or put in an
anonymous namespace.
--
To view, visit http://gerrit.cloudera.org:8080/11659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I254828d640cd905e33dbaf0fe100d660bc9e6772
Gerrit-Change-Number:
