[kudu-CR] [python] Fix Python 3 syntax issues
Adar Dembo has removed a vote on this change. Change subject: [python] Fix Python 3 syntax issues .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] Fix Python 3 syntax issues
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15037 ) Change subject: [python] Fix Python 3 syntax issues .. [python] Fix Python 3 syntax issues This patch fixes many of the Python 3 incompatibilities in the various Kudu Python scripts while still maintiaining Python 2 compatibility. Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Reviewed-on: http://gerrit.cloudera.org:8080/15037 Reviewed-by: Bankim Bhavsar Reviewed-by: Adar Dembo Tested-by: Adar Dembo --- M build-support/build_source_release.py M build-support/check_compatibility.py M build-support/clang_tidy_gerrit.py M build-support/dist_test.py M build-support/iwyu.py M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py M build-support/parse_test_failure.py M build-support/push_to_asf.py M build-support/release/check-rat-report.py M build-support/run_dist_test.py M build-support/test_result_server.py M examples/python/graphite-kudu/kudu/kudu_graphite.py M src/kudu/benchmarks/wal_hiccup-parser.py M src/kudu/experiments/merge-test.py M src/kudu/scripts/get-job-stats-from-mysql.py M src/kudu/scripts/graph-metrics.py M src/kudu/scripts/max_skew_estimate.py M src/kudu/scripts/parse_metrics_log.py M src/kudu/scripts/write-jobs-stats-to-mysql.py 19 files changed, 63 insertions(+), 48 deletions(-) Approvals: Bankim Bhavsar: Looks good to me, but someone else must approve Adar Dembo: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] Fix Python 3 syntax issues
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15037 ) Change subject: [python] Fix Python 3 syntax issues .. Patch Set 2: Verified+1 Overriding Jenkins, unrelated test failure. -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 16 Jan 2020 04:39:28 + Gerrit-HasComments: No
[kudu-CR] [python] Fix Python 3 syntax issues
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15037 ) Change subject: [python] Fix Python 3 syntax issues .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Jan 2020 21:42:10 + Gerrit-HasComments: No
[kudu-CR] [python] Fix Python 3 syntax issues
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15037 ) Change subject: [python] Fix Python 3 syntax issues .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Jan 2020 20:52:44 + Gerrit-HasComments: No
[kudu-CR] [python] Fix Python 3 syntax issues
Grant Henke has posted comments on this change. (
http://gerrit.cloudera.org:8080/15037 )
Change subject: [python] Fix Python 3 syntax issues
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/parse_test_failure.py
File build-support/parse_test_failure.py:
http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/parse_test_failure.py@292
PS1, Line 292: open(os.path.join(self._TEST_DIR, child)).read()
> Nit: In this case I think we are relying on Python's garbage collector to c
Done
http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/release/rat_exclude_files.txt
File build-support/release/rat_exclude_files.txt:
PS1:
> If you're feeling charitable you can break this change out into a separate
Done
PS1:
> Good catch. I meant to. This was just found while testing some of the Pytho
Done
http://gerrit.cloudera.org:8080/#/c/15037/1/src/kudu/scripts/max_skew_estimate.py
File src/kudu/scripts/max_skew_estimate.py:
http://gerrit.cloudera.org:8080/#/c/15037/1/src/kudu/scripts/max_skew_estimate.py@87
PS1, Line 87: print("%02d percentile: %d" % (p, percentile(skews, p)))
> Nit: I think this print formatting is considered old-style and newer style
Done
--
To view, visit http://gerrit.cloudera.org:8080/15037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd
Gerrit-Change-Number: 15037
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2020 20:34:29 +
Gerrit-HasComments: Yes
[kudu-CR] [python] Fix Python 3 syntax issues
Hello Kudu Jenkins, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15037 to look at the new patch set (#2). Change subject: [python] Fix Python 3 syntax issues .. [python] Fix Python 3 syntax issues This patch fixes many of the Python 3 incompatibilities in the various Kudu Python scripts while still maintiaining Python 2 compatibility. Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd --- M build-support/build_source_release.py M build-support/check_compatibility.py M build-support/clang_tidy_gerrit.py M build-support/dist_test.py M build-support/iwyu.py M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py M build-support/parse_test_failure.py M build-support/push_to_asf.py M build-support/release/check-rat-report.py M build-support/run_dist_test.py M build-support/test_result_server.py M examples/python/graphite-kudu/kudu/kudu_graphite.py M src/kudu/benchmarks/wal_hiccup-parser.py M src/kudu/experiments/merge-test.py M src/kudu/scripts/get-job-stats-from-mysql.py M src/kudu/scripts/graph-metrics.py M src/kudu/scripts/max_skew_estimate.py M src/kudu/scripts/parse_metrics_log.py M src/kudu/scripts/write-jobs-stats-to-mysql.py 19 files changed, 63 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/15037/2 -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] Fix Python 3 syntax issues
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15037 ) Change subject: [python] Fix Python 3 syntax issues .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/release/rat_exclude_files.txt File build-support/release/rat_exclude_files.txt: PS1: > If you're feeling charitable you can break this change out into a separate Good catch. I meant to. This was just found while testing some of the Python scripts. -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Jan 2020 19:44:16 + Gerrit-HasComments: Yes
[kudu-CR] [python] Fix Python 3 syntax issues
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15037 ) Change subject: [python] Fix Python 3 syntax issues .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/release/rat_exclude_files.txt File build-support/release/rat_exclude_files.txt: PS1: If you're feeling charitable you can break this change out into a separate patch as it really has nothing to do with py3 compat. -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Jan 2020 19:39:36 + Gerrit-HasComments: Yes
[kudu-CR] [python] Fix Python 3 syntax issues
Bankim Bhavsar has posted comments on this change. (
http://gerrit.cloudera.org:8080/15037 )
Change subject: [python] Fix Python 3 syntax issues
..
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/parse_test_failure.py
File build-support/parse_test_failure.py:
http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/parse_test_failure.py@292
PS1, Line 292: open(os.path.join(self._TEST_DIR, child)).read()
Nit: In this case I think we are relying on Python's garbage collector to close
the file.
Would it be better to explicitly close the file using with clause/finally
close() or this is not long running enough to cause resource leak issue?
Same for couple of other places below.
http://gerrit.cloudera.org:8080/#/c/15037/1/src/kudu/scripts/max_skew_estimate.py
File src/kudu/scripts/max_skew_estimate.py:
http://gerrit.cloudera.org:8080/#/c/15037/1/src/kudu/scripts/max_skew_estimate.py@87
PS1, Line 87: print("%02d percentile: %d" % (p, percentile(skews, p)))
Nit: I think this print formatting is considered old-style and newer style is
to use "".format(). Something to consider changing while making the
compatibility change.
--
To view, visit http://gerrit.cloudera.org:8080/15037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd
Gerrit-Change-Number: 15037
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2020 18:06:09 +
Gerrit-HasComments: Yes
[kudu-CR] [python] Fix Python 3 syntax issues
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15037 Change subject: [python] Fix Python 3 syntax issues .. [python] Fix Python 3 syntax issues This patch fixes many of the Python 3 incompatibilities in the various Kudu Python scripts while still maintiaining Python 2 compatibility. Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd --- M build-support/build_source_release.py M build-support/check_compatibility.py M build-support/clang_tidy_gerrit.py M build-support/dist_test.py M build-support/iwyu.py M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py M build-support/parse_test_failure.py M build-support/push_to_asf.py M build-support/release/check-rat-report.py M build-support/release/rat_exclude_files.txt M build-support/run_dist_test.py M build-support/test_result_server.py M examples/python/graphite-kudu/kudu/kudu_graphite.py M src/kudu/benchmarks/wal_hiccup-parser.py M src/kudu/experiments/merge-test.py M src/kudu/scripts/get-job-stats-from-mysql.py M src/kudu/scripts/graph-metrics.py M src/kudu/scripts/max_skew_estimate.py M src/kudu/scripts/parse_metrics_log.py M src/kudu/scripts/write-jobs-stats-to-mysql.py 20 files changed, 61 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/15037/1 -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
