[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. KUDU-2214 Update logging to differentiate voting while copying/tombstoned Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Reviewed-on: http://gerrit.cloudera.org:8080/10169 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon Reviewed-by: Mike Percy --- M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/tserver/tablet_service.cc 5 files changed, 53 insertions(+), 16 deletions(-) Approvals: Kudu Jenkins: Verified Todd Lipcon: Looks good to me, but someone else must approve Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Patch Set 4: LGTM, I don't think it's critical to add an automated test to validate the log message change. -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 03 May 2018 20:17:42 + Gerrit-HasComments: No
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 03 May 2018 20:16:52 + Gerrit-HasComments: No
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 03 May 2018 19:26:06 + Gerrit-HasComments: No
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10169 to look at the new patch set (#4). Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. KUDU-2214 Update logging to differentiate voting while copying/tombstoned Change-Id: I07007601d0a86d6161065629ba167121a33635d6 --- M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/tserver/tablet_service.cc 5 files changed, 53 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/10169/4 -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10169 to look at the new patch set (#3). Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. KUDU-2214 Update logging to differentiate voting while copying/tombstoned Change-Id: I07007601d0a86d6161065629ba167121a33635d6 --- M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/tserver/tablet_service.cc 5 files changed, 51 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/10169/3 -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 3 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Fengling Wang has posted comments on this change. (
http://gerrit.cloudera.org:8080/10169 )
Change subject: KUDU-2214 Update logging to differentiate voting while
copying/tombstoned
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc@1561
PS1, Line 1561: if (tablet_voting_state.data_state ==
tablet::TABLET_DATA_COPYING) {
> I like Todd's suggestion here and I think it's a good one. From a quick gre
Done
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc
File src/kudu/integration-tests/tablet_copy-itest.cc:
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc@1328
PS1, Line 1328: // last-logged OpId from the tombstoned replica.
> I don't think this test actually tests the change in this patch. Maybe we c
I see. Thanks. I have manually validated the logging. It seems to work. Would
you more likely recommend dropping this test or the alternative you said below?
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc@1385
PS1, Line 1385: ASSERT_GT(cur_mtime, initial_mtime);
> Alternatively, we can use this test for this purpose and instead of Request
I see. Very useful info.
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc@1006
PS1, Line 1006: }
> I think it would be preferable to incorporate this into the code path in ra
Done
--
To view, visit http://gerrit.cloudera.org:8080/10169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6
Gerrit-Change-Number: 10169
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang
Gerrit-Reviewer: Fengling Wang
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Wed, 02 May 2018 18:45:45 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10169 to look at the new patch set (#2). Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. KUDU-2214 Update logging to differentiate voting while copying/tombstoned Change-Id: I07007601d0a86d6161065629ba167121a33635d6 --- M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/tserver/tablet_service.cc 5 files changed, 49 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/10169/2 -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc@1385 PS1, Line 1385: Status s = itest::RequestVote(new_replica_ts, tablet_id, kCandidateUuid, Alternatively, we can use this test for this purpose and instead of RequestVote() calls I think repeated StartElection() calls would be more appropriate and easier to manage. At the end of the test, we can grep the logs located in the external mini cluster directories. See src/kudu/integration-tests/log-rolling-itest.cc for an example of how to build the path to those glog files. So we could grep for the expected messages there. -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 01 May 2018 21:15:10 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Mike Percy has posted comments on this change. (
http://gerrit.cloudera.org:8080/10169 )
Change subject: KUDU-2214 Update logging to differentiate voting while
copying/tombstoned
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc@1561
PS1, Line 1561: LOG_WITH_PREFIX_UNLOCKED(INFO) << "voting based on
last-logged opid "
> Sure. The reason is that the log message today is misleading -- it says tha
I like Todd's suggestion here and I think it's a good one. From a quick grep,
it looks like the only places we call this function directly are
tablet_service.cc and raft_consensus_quorum-test.cc. For
raft_consensus_quorum-test.cc, we can simply pass { boost::none,
TABLET_DATA_READY } to all call-sites, so I don't think it should be very
disruptive to the callers. In tablet_service.cc we already have 'data_state'
available at the call site.
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc
File src/kudu/integration-tests/tablet_copy-itest.cc:
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc@1328
PS1, Line 1328: TEST_F(TabletCopyITest, TestTabletCopyVotingLog) {
I don't think this test actually tests the change in this patch. Maybe we could
parse the logs generated from existing tombstoned voting tests to validate
this. However most of our logging-only changes don't actually come with a test
because as far as I'm aware we haven't built helper infrastructure for that. We
often manually validate logging changes.
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc@1378
PS1, Line 1378: RequestVote
nit: make this a complete sentence or maybe remove this comment?
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc@1006
PS1, Line 1006: LOG(INFO) << "Attempting to vote while "
> yes actually.
I think it would be preferable to incorporate this into the code path in
raft_consensus.cc instead of adding additional log lines, from a performance
perspective as well as a usability perspective (we already have a log-spew
problem)
--
To view, visit http://gerrit.cloudera.org:8080/10169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6
Gerrit-Change-Number: 10169
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang
Gerrit-Reviewer: Fengling Wang
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Tue, 01 May 2018 00:42:43 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc@1561 PS1, Line 1561: LOG_WITH_PREFIX_UNLOCKED(INFO) << "voting based on last-logged opid " > Sounds good. Thanks. I'll try this. Could you tell me why doing this btw? I Sure. The reason is that the log message today is misleading -- it says that it's voting while tombstoned but it's not tombstoned. This may lead the operator to thinking that a tablet is in a different state than it actually is. I would also be OK with just removing the words "while tombstoned" above and not changing anything else. Maybe Mike has an opinion about that. -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 24 Apr 2018 17:09:14 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc@1561 PS1, Line 1561: LOG_WITH_PREFIX_UNLOCKED(INFO) << "voting based on last-logged opid " > One idea here is to change the signature of this method so that instead of Sounds good. Thanks. I'll try this. Could you tell me why doing this btw? I feel like changing the signature is going affect quite a few use cases.? -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 24 Apr 2018 16:49:36 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Todd Lipcon has posted comments on this change. (
http://gerrit.cloudera.org:8080/10169 )
Change subject: KUDU-2214 Update logging to differentiate voting while
copying/tombstoned
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc@1561
PS1, Line 1561: LOG_WITH_PREFIX_UNLOCKED(INFO) << "voting based on
last-logged opid "
One idea here is to change the signature of this method so that instead of just
taking in OpId last_logged_opid, it instead takes some simple struct like:
struct TabletVotingState {
optional last_logged_op_id;
TabletDataState data_state;
};
and then you can modify this message to switch on the passed-in data state.
--
To view, visit http://gerrit.cloudera.org:8080/10169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6
Gerrit-Change-Number: 10169
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang
Gerrit-Reviewer: Fengling Wang
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Tue, 24 Apr 2018 16:21:12 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Patch Set 1: (1 comment) So far I don't know the best approach to solve this issue. Hoping for suggestions. Thanks. http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc@1006 PS1, Line 1006: LOG(INFO) << "Attempting to vote while " > does this end up doubling the number of logs during a vote? yes actually. -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 24 Apr 2018 15:44:47 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc@1006 PS1, Line 1006: LOG(INFO) << "Attempting to vote while " does this end up doubling the number of logs during a vote? -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 24 Apr 2018 01:09:55 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Fengling Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10169 Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. KUDU-2214 Update logging to differentiate voting while copying/tombstoned Change-Id: I07007601d0a86d6161065629ba167121a33635d6 --- M src/kudu/consensus/raft_consensus.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/tserver/tablet_service.cc 3 files changed, 81 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/10169/1 -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Fengling Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/10166 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Abandoned Too many messed up patches -- To view, visit http://gerrit.cloudera.org:8080/10166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I1a2486e4e780f2ab26859d2432f67de49986b511 Gerrit-Change-Number: 10166 Gerrit-PatchSet: 3 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10166 to look at the new patch set (#3). Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. KUDU-2214 Update logging to differentiate voting while copying/tombstoned Change-Id: I1a2486e4e780f2ab26859d2432f67de49986b511 --- M src/kudu/consensus/raft_consensus.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/tserver/tablet_service.cc 3 files changed, 82 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/10166/3 -- To view, visit http://gerrit.cloudera.org:8080/10166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1a2486e4e780f2ab26859d2432f67de49986b511 Gerrit-Change-Number: 10166 Gerrit-PatchSet: 3 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10166 to look at the new patch set (#2). Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. KUDU-2214 Update logging to differentiate voting while copying/tombstoned Change-Id: I1a2486e4e780f2ab26859d2432f67de49986b511 --- M src/kudu/consensus/raft_consensus.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/tserver/tablet_service.cc 3 files changed, 81 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/10166/2 -- To view, visit http://gerrit.cloudera.org:8080/10166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1a2486e4e780f2ab26859d2432f67de49986b511 Gerrit-Change-Number: 10166 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned
Fengling Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10166 Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. KUDU-2214 Update logging to differentiate voting while copying/tombstoned Change-Id: I1a2486e4e780f2ab26859d2432f67de49986b511 --- M src/kudu/consensus/raft_consensus.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/tserver/tablet_service.cc 3 files changed, 84 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/10166/1 -- To view, visit http://gerrit.cloudera.org:8080/10166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1a2486e4e780f2ab26859d2432f67de49986b511 Gerrit-Change-Number: 10166 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang
