[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc@60 PS3, Line 60: DEFINE_uint32(hive_metastore_notification_log_poll_inject_latency_ms, 0, > +1 https://gerrit.cloudera.org/c/13135/ done -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 22:48:42 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. hms: remove experimental tag from hms flags The HMS integration has been in our codebase for a while now. While the behavior of integration may change (a la KUDU-2799), the configuration options themselves aren't likely to do so. This patch tags the necessary configuration flags as "evolving" (the default) to facilitate their usage and testing of the integration. Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Reviewed-on: http://gerrit.cloudera.org:8080/13124 Tested-by: Kudu Jenkins Reviewed-by: Hao Hao Reviewed-by: Adar Dembo --- M src/kudu/hms/hms_catalog.cc M src/kudu/master/hms_notification_log_listener.cc 2 files changed, 0 insertions(+), 10 deletions(-) Approvals: Kudu Jenkins: Verified Hao Hao: Looks good to me, approved Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: remove experimental tag from hms flags
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc@60 PS3, Line 60: DEFINE_uint32(hive_metastore_notification_log_poll_inject_latency_ms, 0, > Not your fault, but this should be tagged as hidden. Separate patch is fine +1 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 22:05:47 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc@60 PS3, Line 60: DEFINE_uint32(hive_metastore_notification_log_poll_inject_latency_ms, 0, Not your fault, but this should be tagged as hidden. Separate patch is fine if you prefer. -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 21:22:24 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 20:58:52 + Gerrit-HasComments: No
[kudu-CR] hms: remove experimental tag from hms flags
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13124 to look at the new patch set (#3). Change subject: hms: remove experimental tag from hms flags .. hms: remove experimental tag from hms flags The HMS integration has been in our codebase for a while now. While the behavior of integration may change (a la KUDU-2799), the configuration options themselves aren't likely to do so. This patch tags the necessary configuration flags as "evolving" (the default) to facilitate their usage and testing of the integration. Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e --- M src/kudu/hms/hms_catalog.cc M src/kudu/master/hms_notification_log_listener.cc 2 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/13124/3 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc@71 PS2, Line 71: DEFINE_string(hive_metastore_kerberos_principal, "hive", : "The service principal of the Hive Metastore server. Must match " : "the primary (user) portion of hive.metastore.kerberos.principal option " : "in the Hive Metastore configuration."); > Of the first three, should this be 'advanced'? Or do you also expect it to I opted to keep it since it seems like a configuration that a user might want to touch, depending on their setup. The ones below seem like they'd require slightly deeper knowledge of the HMS thrift client and the rest of the integration. -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 19:41:07 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc@71 PS2, Line 71: DEFINE_string(hive_metastore_kerberos_principal, "hive", : "The service principal of the Hive Metastore server. Must match " : "the primary (user) portion of hive.metastore.kerberos.principal option " : "in the Hive Metastore configuration."); Of the first three, should this be 'advanced'? Or do you also expect it to be used semi-frequently? -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 18:33:14 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 2: Verified+1 Test Result (2 failures / +1) MultiThreadedHybridClockTabletTest/5.UpdateNoMergeCompaction KuduTsCliTest.TestDumpTablet -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 17:29:07 + Gerrit-HasComments: No
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has removed a vote on this change. Change subject: hms: remove experimental tag from hms flags .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: remove experimental tag from hms flags
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 16:05:39 + Gerrit-HasComments: No
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/1/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/13124/1/src/kudu/hms/hms_catalog.cc@a83 PS1, Line 83: > Adar's suggestion sounds reasonable to me as well. BTW, maybe tag the rest Done. I don't think I'll tag these first three "advanced" though. Usage of the HMS integration will require the user to think about those flags, which kind of goes against the "advanced" description: they're also likely to be used only rarely and should be relegated to more detailed sections of documentation. I.e. I don't think we expect them to be used rarely, whereas we probably don't expect users to have to tune the HMS thrift client configurations very often. -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 06:51:42 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13124 to look at the new patch set (#2). Change subject: hms: remove experimental tag from hms flags .. hms: remove experimental tag from hms flags The HMS integration has been in our codebase for a while now. While the behavior of integration may change (a la KUDU-2799), the configuration options themselves aren't likely to do so. This patch tags the necessary configuration flags as "evolving" (the default) to facilitate their usage and testing of the integration. Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e --- M src/kudu/hms/hms_catalog.cc 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/13124/2 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
