Re: Review Request 37189: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94539 --- Ship it! Ship It! - Alexander Rojas On Aug. 7, 2015, 1:52 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 7, 2015, 1:52 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 Diff: https://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37222: Enable automake maintainer mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37222/#review94573 --- Patch looks great! Reviews applied: [37221, 37222] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 4:16 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37222/ --- (Updated Aug. 7, 2015, 4:16 p.m.) Review request for mesos. Bugs: MESOS-3234 https://issues.apache.org/jira/browse/MESOS-3234 Repository: mesos Description --- Enable automake maintainer mode. Diffs - 3rdparty/libprocess/configure.ac 43c026343d3cc0d10c455480989a94afd069d1b4 Diff: https://reviews.apache.org/r/37222/diff/ Testing --- Run configure --help and check for the --disable-maintainer-mode option. Thanks, James Peach
Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/ --- (Updated Aug. 7, 2015, 3:44 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-3236 https://issues.apache.org/jira/browse/MESOS-3236 Repository: mesos Description (updated) --- If the task being launched has a command executor, there is no way for the hook to determine the executor-id for that task. This update calls the hook _after_ the ExecutorInfo has been created and thus is able to pass in ExecutorInfo to the label decorator. Diffs - include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 Diff: https://reviews.apache.org/r/37228/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/#review94588 --- Ship it! Ship It! - Niklas Nielsen On Aug. 7, 2015, 3:44 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/ --- (Updated Aug. 7, 2015, 3:44 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-3236 https://issues.apache.org/jira/browse/MESOS-3236 Repository: mesos Description --- If the task being launched has a command executor, there is no way for the hook to determine the executor-id for that task. This update calls the hook _after_ the ExecutorInfo has been created and thus is able to pass in ExecutorInfo to the label decorator. Diffs - include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 Diff: https://reviews.apache.org/r/37228/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 37198: Add Docker image provisioner and copy backend.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review94584 --- Could you consider my comment on MESOS-2968 w.r.t the Backend API: https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859 Does it make sense? Thanks! - Jiang Yan Xu On Aug. 6, 2015, 1:37 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 6, 2015, 1:37 p.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Add Docker image provisioner and copy backend. Diffs - src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac src/slave/containerizer/provisioner.cpp df52e36b23ad3cd28f50e96865d0b163cc245cb2 src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37198/diff/ Testing --- make check Thanks, Lily Chen
Review Request 37236: Added the linux filesystem isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/ --- Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-2794 https://issues.apache.org/jira/browse/MESOS-2794 Repository: mesos Description --- Added the linux filesystem isolator. Note that the persistent volume part (i.e., update) hasn't been implemented yet. This review is derived from https://reviews.apache.org/r/36429/ Tests are in the subsequent review. Diffs - src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 Diff: https://reviews.apache.org/r/37236/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review94576 --- Patch looks great! Reviews applied: [35711] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 6:50 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated Aug. 7, 2015, 6:50 p.m.) Review request for mesos, Adam B, Jie Yu, and Michael Park. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs - include/mesos/roles.hpp PRE-CREATION src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/roles.cpp PRE-CREATION src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756 src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/roles_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Re: Review Request 37190: WIP: Added /maintenance.schedule, /maintenance.start, /maintenance.stop and /maintenance.status endpoints.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37190/ --- (Updated Aug. 7, 2015, 1:40 p.m.) Review request for Benjamin Hindman, Joris Van Remoortere and Joseph Wu. Changes --- Addressed comments; added more endpoints. Summary (updated) - WIP: Added /maintenance.schedule, /maintenance.start, /maintenance.stop and /maintenance.status endpoints. Bugs: MESOS-2067 https://issues.apache.org/jira/browse/MESOS-2067 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/maintenance/maintenance.proto PRE-CREATION src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 src/master/maintenance.hpp PRE-CREATION src/master/maintenance.cpp PRE-CREATION src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702 Diff: https://reviews.apache.org/r/37190/diff/ Testing --- Manual testing of the endpoint. Thanks, Artem Harutyunyan
Re: Review Request 37198: Add Docker image provisioner and copy backend.
On Aug. 7, 2015, 1:45 a.m., Timothy Chen wrote: src/slave/flags.cpp, line 81 https://reviews.apache.org/r/37198/diff/1/?file=1033693#file1033693line81 Is this going to be the same with appc? Should we just have one config? Changed to /tmp/mesos/containers/docker, to match the structure of other default configured directories in Docker provisioner On Aug. 7, 2015, 1:45 a.m., Timothy Chen wrote: src/slave/containerizer/provisioners/docker.cpp, line 202 https://reviews.apache.org/r/37198/diff/1/?file=1033689#file1033689line202 Remove extra space between [] and ( And also seems like we're doing duplicate functionality here with appc? Should be consolidate? This part is pretty much the same functionality as with appc. How might we consolidate? With a common provision function? - Lily --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review94475 --- On Aug. 6, 2015, 8:37 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 6, 2015, 8:37 p.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Add Docker image provisioner and copy backend. Diffs - src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac src/slave/containerizer/provisioner.cpp df52e36b23ad3cd28f50e96865d0b163cc245cb2 src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37198/diff/ Testing --- make check Thanks, Lily Chen
Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/ --- Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-2794 https://issues.apache.org/jira/browse/MESOS-2794 Repository: mesos Description --- Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator. This adds the tests for https://reviews.apache.org/r/37236/ Diffs - src/tests/containerizer/mesos_containerizer_tests.cpp 213fa4b0b9c50eba941ef6b52497eb32d539 src/tests/containerizer/provisioner.hpp PRE-CREATION Diff: https://reviews.apache.org/r/37237/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 36979: Updating all references to os::shell
On Aug. 6, 2015, 10:26 p.m., Guangya Liu wrote: src/hdfs/hdfs.hpp, line 110 https://reviews.apache.org/r/36979/diff/3/?file=1033647#file1033647line110 Why not use the following? return !out.get().empty(); Actually, that was exactly what I originally typed :) However, if you see the original code, the semantic is subtly different: it only checked for a non-zero exit code (which would be now guaranteed by the `! isError()`). So, changing as you suggest (which, incidentally, I agree on) would in fact require that the `version` command emits something non-trivial to stdout: as the method is sadly not commented, I don't know whether changing that would break existing code. I'll wait to hear what @BenH (or someone else more knowledgeable than me on this matter, at any rate) has to say. - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94453 --- On Aug. 6, 2015, 6:24 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/ --- (Updated Aug. 6, 2015, 6:24 p.m.) Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-3142 https://issues.apache.org/jira/browse/MESOS-3142 Repository: mesos Description --- Updating all references to os::shell For more details see MESOS-3142. Diffs - src/hdfs/hdfs.hpp a070c3200f0a0ac48ec86451749c7faf10c7f6a7 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/slave/containerizer/isolators/network/port_mapping.cpp 8244c345b84108af7fa18d20e71401d6e1a0aeb0 src/tests/containerizer/isolator_tests.cpp ff6e2b7e190a58a4809d6e71addb15dabe418e17 src/tests/containerizer/port_mapping_tests.cpp 4bee74acba2b1472c80cabbc9d0384bd04c543aa Diff: https://reviews.apache.org/r/36979/diff/ Testing --- make check *Note*: this patch fixes breakages introduce by the refactoring in: https://reviews.apache.org/r/36978 Thanks, Marco Massenzio
Re: Review Request 37165: Introduced v1 API.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37165/
---
(Updated Aug. 7, 2015, 6:38 a.m.)
Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
Repository: mesos
Description
---
Perhaps the right thing is to move internal/{d|e}volve.hpp|cpp to
v1/{d|e}volve.hpp|cpp?
Note that Anand can fix up src/scheduler/scheduler.cpp to just use the HTTP API
once it's finished and can kill all authenticating code and 'install', 'send',
'evolve', 'devolve' code and update src/tests/scheduler_tests.cpp as well.
Diffs (updated)
-
include/mesos/scheduler.hpp cd235a11e63a5df742057be8e27629db4cf9
include/mesos/v1/attributes.hpp PRE-CREATION
include/mesos/v1/mesos.hpp PRE-CREATION
include/mesos/v1/mesos.proto PRE-CREATION
include/mesos/v1/resources.hpp PRE-CREATION
include/mesos/v1/scheduler.hpp PRE-CREATION
include/mesos/v1/scheduler/scheduler.hpp PRE-CREATION
include/mesos/v1/scheduler/scheduler.proto PRE-CREATION
include/mesos/v1/values.hpp PRE-CREATION
src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81
src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a
src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a
src/examples/event_call_framework.cpp
0093363ea7b70230d5cbd29599cb0f4dc8a91d68
src/internal/devolve.hpp PRE-CREATION
src/internal/devolve.cpp PRE-CREATION
src/internal/evolve.hpp PRE-CREATION
src/internal/evolve.cpp PRE-CREATION
src/master/contender.hpp 62bcff4aaf44936815c23f50b8066497af66fcd3
src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255
src/scheduler/scheduler.cpp a0df048bddd3f0682518eb50944895a728ec4eb7
src/tests/mesos.hpp 20418d4fbd2f4ae35ee0c707472cbf37125883b0
src/tests/scheduler_driver_tests.cpp PRE-CREATION
src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca
src/tests/slave_tests.cpp cb5a01ed771e66d75091ca33523dbe673e16a86e
src/v1/attributes.cpp PRE-CREATION
src/v1/mesos.cpp PRE-CREATION
src/v1/resources.cpp PRE-CREATION
src/v1/values.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37165/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94503 --- Patch looks great! Reviews applied: [36837] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 3:24 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 37114: MESOS-3187, support docker host command line option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review94509 --- Patch looks great! Reviews applied: [37114] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 5:04 a.m., Vaibhav Khanduja wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 7, 2015, 5:04 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and Vinod Kone. Bugs: MESOS-3187 https://issues.apache.org/jira/browse/MESOS-3187 Repository: mesos Description --- MESOS-3187, support docker host command line option. Docker daemon supports starting on a non-default port. Such scenarios would needed when starting Docker daemon on TCP or non-default unix port. Mesos slave does not work if Docker daemon is started on any of such non-default port. The code change is needed in Mesos slave to accept this parameter so as connect for its operations to the right Docker daemon. The change is made in Mesos slave, so as it is available to any framework making using Docker executor. The code is added to start slave binary with --docker_host, instructing it to connect on port as specified in the parameter. The default value of --default_host is unix:///var/run/docker.sock, which is default port for Docker daemon. The main class src/docker.cpp/.hpp is kept backward compartible to make Docker cli execute on default Docker port. Diffs - src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc Diff: https://reviews.apache.org/r/37114/diff/ Testing --- Following scenarios were executed to test the code changes. Kindly suggest if more test-cases are required: a) Mesos slave with unix port : unix:///var/run/docker_myport.sock i) Start slave with --docker_host parameter unix:///var/run/docker_myport.sock ii) Using a framework, in my case Marathon, post a Docker job iii) The docker job does get started on the slave, confirmed with docker ps command output docker -H unix:///var/run/docker_myport.sock ps CONTAINER IDIMAGE COMMANDCREATED STATUS PORTS NAMES 07fc4ec86bacmygoserver /bin/sh -c /mygoser 19 minutes ago Up 19 minutes */tcp, */udp mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c iv) Stop or destroy the job from Marathon GUI b) Two mesos slave with non-default docker port i) On two different hosts, start slave, with one running on default port and other non-default. The start slaves with attributes - default and or non-default. ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting slave - non-default default iii) Stop/destroy the jobs d) Modified unit test-case taking docker port value - make check Thanks, Vaibhav Khanduja
Review Request 37208: Fix the spell error in help message of slave component.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37208/ --- Review request for mesos and Zhiwei Chen. Bugs: MESOS-3228 https://issues.apache.org/jira/browse/MESOS-3228 Repository: mesos Description --- Fix the spell error in help message of slave component. Diffs - src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37208/diff/ Testing --- Thanks, Yong Qiao Wang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94510 --- Ship it! Ship It! - Michael Park On Aug. 7, 2015, 3:24 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94496 --- Ship it! I left some comments here so you could see the issues I noticed as I went over this, mostly around upgrading and downgrading across pid and http. I've applied fixes for all of these to avoid more round-trips and will get this committed shortly, nice work! src/master/master.cpp (line 4950) https://reviews.apache.org/r/36720/#comment149133 Much like when we remove a pid-based framework, we need to wipe the authentication related data here. src/master/master.cpp (lines 4963 - 4968) https://reviews.apache.org/r/36720/#comment149135 Perhaps we should just push the unsetting of the other connection into updateConnection and have one for both http and pid. src/master/master.cpp (line 4967) https://reviews.apache.org/r/36720/#comment149136 We need to remove the old one from `authenticated` and `principals` here when updrading to http, much like we do when a pid based framework is removed. Yes.. this stuff is a nasty mess, we need to make failover as simple as the composition of: disconnect - reconnect! src/master/master.cpp (line 4983) https://reviews.apache.org/r/36720/#comment149129 This check will crash when an http scheduler is downgrading to a pid framework. src/master/master.cpp (lines 5010 - 5015) https://reviews.apache.org/r/36720/#comment149132 This won't work for downgrades from http to pid, since there was no principal in the map yet. src/master/master.cpp (lines 5039 - 5040) https://reviews.apache.org/r/36720/#comment149138 Could we do this before reactivating? Note that your comment seems to hint that it must come after for some reason, but it doesn't need to. - Ben Mahler On Aug. 7, 2015, 2:27 a.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 7, 2015, 2:27 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- Split review out of r36318. This change adds the functionality of making a http call for subscribe and the master responding with a subscribed event on the persistent stream. Also added functionality for framework failover equivalent of re-register. It should now be possible to merge the subscribed(...) introduced in this review and the re-factor that happened in MESOS-3182. - Made a new function for exited()/failoverFramework for http frameworks that invoke into the common continuation function for pid/http frameworks thereafter. - The re-register functionality equivalent goes in _subscribe(...) Diffs - src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702 Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + adding tests in a different patch. Thanks, Anand Mazumdar
Re: Review Request 37160: Add GTEST_LANG_CXX11 to StoutTestsConfigure when compile.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37160/#review94511 --- Ship it! Ship It! - Michael Park On Aug. 6, 2015, 5:13 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37160/ --- (Updated Aug. 6, 2015, 5:13 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake d69920689932d2afc8416d0f8ba289695444d8b2 Diff: https://reviews.apache.org/r/37160/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 37097: Fix 'Accept-Encoding' parsing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/#review94513 --- Ship it! 3rdparty/libprocess/src/http.cpp (line 133) https://reviews.apache.org/r/37097/#comment149139 s/2606/2616/ - Alexander Rojas On Aug. 6, 2015, 7:35 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/ --- (Updated Aug. 6, 2015, 7:35 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- Currently parsing only compares the begining of the header making 'gzipbug' match with candidate 'gzip' Diffs - 3rdparty/libprocess/include/process/http.hpp b8d9300 3rdparty/libprocess/src/http.cpp 4dcbd74 3rdparty/libprocess/src/tests/encoder_tests.cpp 0032137 Diff: https://reviews.apache.org/r/37097/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37162/#review94512 --- Ship it! Ship It! - Michael Park On Aug. 7, 2015, 3:30 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37162/ --- (Updated Aug. 7, 2015, 3:30 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - LICENSE 8757c208f91e9fa000574489bdb7432a0777d923 configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 Diff: https://reviews.apache.org/r/37162/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 11:45 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Summary (updated) - Added std::hash template specializations. Repository: mesos Description (updated) --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp be216db823160f5db1dfb4502bf832246fb3df6d 3rdparty/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 36837: Update gmock to 1.7.0.
On Aug. 7, 2015, 8:43 a.m., Michael Park wrote: Ship It! Thank you for your great help. LoL - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94510 --- On Aug. 7, 2015, 3:24 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36431: Show stdout/stderr when using mesos-execute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/ --- (Updated Aug. 7, 2015, 10:30 a.m.) Review request for mesos, Adam B and Michael Park. Changes --- rebase from current master. Bugs: MESOS-1084 https://issues.apache.org/jira/browse/MESOS-1084 Repository: mesos Description --- Show stdout/stderr when using mesos-execute. Diffs (updated) - src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc Diff: https://reviews.apache.org/r/36431/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36431: Show stdout/stderr when using mesos-execute.
On Aug. 6, 2015, 11:43 p.m., Marco Massenzio wrote: Before we go too far down this path, can you please see https://reviews.apache.org/r/36424/ and see whether it does what you are trying to achieve here? (maybe not, I'm not familiar at all with `cli` - just asking) Hi, @marco .Thank you for your remind. I take a look of [r36424](https://reviews.apache.org/r/36424/) . This review is to execute command in local and get its stdout/stderr, right? If so, it is different with my patch. My patch is try to get stdout/stderr of task from slave. It fetch stdout/stderr from slave, maybe in remote machine. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/#review94460 --- On Aug. 4, 2015, 9:33 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/ --- (Updated Aug. 4, 2015, 9:33 a.m.) Review request for mesos, Adam B and Michael Park. Bugs: MESOS-1084 https://issues.apache.org/jira/browse/MESOS-1084 Repository: mesos Description --- Show stdout/stderr when using mesos-execute. Diffs - src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc Diff: https://reviews.apache.org/r/36431/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 37189: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 7, 2015, 12:28 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 Diff: https://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---
(Updated Aug. 7, 2015, 12:27 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
---
Changed hashmap, hashset to use std::unordered_{set,map} instead of
boost::unordered_{set,map}.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp
ecab60a21765c58b0732de747509aa6382d31c06
3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp
e969b09efc4ce6b080c6c7bea1a8a8d445c6a279
3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce
3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp
341c5e09acb4c4f9da3cee3f35b4f2028552fca3
Diff: https://reviews.apache.org/r/37187/diff/
Testing
---
make check
Thanks,
Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 12:28 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp be216db823160f5db1dfb4502bf832246fb3df6d 3rdparty/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94523 --- Patch looks great! Reviews applied: [37187, 37188, 37189] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 10:28 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 7, 2015, 10:28 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 Diff: https://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 7, 2015, 11:46 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Summary (updated) - Added std::hash template specializations. Repository: mesos Description (updated) --- Added std::hash template specializations. Diffs - include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 Diff: https://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/#review94516
---
Ship it!
Ship It!
- Alexander Rojas
On Aug. 7, 2015, 11:45 a.m., Jan Schlicht wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---
(Updated Aug. 7, 2015, 11:45 a.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Repository: mesos
Description
---
Changed hashmap, hashset to use std::unordered_{set,map} instead of
boost::unordered_{set,map}.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp
ecab60a21765c58b0732de747509aa6382d31c06
3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp
e969b09efc4ce6b080c6c7bea1a8a8d445c6a279
3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce
3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp
341c5e09acb4c4f9da3cee3f35b4f2028552fca3
Diff: https://reviews.apache.org/r/37187/diff/
Testing
---
make check
Thanks,
Jan Schlicht
Re: Review Request 37208: Fix the spell error in help message of slave component.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37208/#review94518 --- Patch looks great! Reviews applied: [37208] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 8:12 a.m., Yong Qiao Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37208/ --- (Updated Aug. 7, 2015, 8:12 a.m.) Review request for mesos and Zhiwei Chen. Bugs: MESOS-3228 https://issues.apache.org/jira/browse/MESOS-3228 Repository: mesos Description --- Fix the spell error in help message of slave component. Diffs - src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37208/diff/ Testing --- Thanks, Yong Qiao Wang
Re: Review Request 36431: Show stdout/stderr when using mesos-execute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/ --- (Updated Aug. 7, 2015, 10:37 a.m.) Review request for mesos, Adam B and Michael Park. Bugs: MESOS-1084 https://issues.apache.org/jira/browse/MESOS-1084 Repository: mesos Description --- Show stdout/stderr when using mesos-execute. Diffs - src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc Diff: https://reviews.apache.org/r/36431/diff/ Testing (updated) --- make check  Thanks, haosdent huang
Re: Review Request 37187: WIP Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---
(Updated Aug. 7, 2015, 11:44 a.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Repository: mesos
Description (updated)
---
Changed hashmap, hashset to use std::unordered_{set,map} instead of
boost::unordered_{set,map}.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp
ecab60a21765c58b0732de747509aa6382d31c06
3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp
e969b09efc4ce6b080c6c7bea1a8a8d445c6a279
3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce
3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp
341c5e09acb4c4f9da3cee3f35b4f2028552fca3
Diff: https://reviews.apache.org/r/37187/diff/
Testing
---
make check
Thanks,
Jan Schlicht
Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---
(Updated Aug. 7, 2015, 11:45 a.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Summary (updated)
-
Changed hashmap, hashset to use std::unordered_{set,map} instead of
boost::unordered_{set,map}.
Repository: mesos
Description
---
Changed hashmap, hashset to use std::unordered_{set,map} instead of
boost::unordered_{set,map}.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp
ecab60a21765c58b0732de747509aa6382d31c06
3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp
e969b09efc4ce6b080c6c7bea1a8a8d445c6a279
3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce
3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp
341c5e09acb4c4f9da3cee3f35b4f2028552fca3
Diff: https://reviews.apache.org/r/37187/diff/
Testing
---
make check
Thanks,
Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review94517 --- Ship it! 3rdparty/libprocess/src/tests/http_tests.cpp (lines 677 - 687) https://reviews.apache.org/r/37188/#comment149141 Can you explain why these two comparisons in each case need to be done. - Alexander Rojas On Aug. 7, 2015, 11:45 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 11:45 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Repository: mesos Description --- Added std::hash template specializations. Diffs - 3rdparty/libprocess/include/process/address.hpp be216db823160f5db1dfb4502bf832246fb3df6d 3rdparty/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94519 --- include/mesos/type_utils.hpp (line 515) https://reviews.apache.org/r/37189/#comment149142 Perhaps add a summarized version of this comment into the code? include/mesos/type_utils.hpp (line 555) https://reviews.apache.org/r/37189/#comment149143 Sometimes is useful to use a large prime number as a seed. Don't know if this heuristic has any value here. src/tests/containerizer.hpp (lines 56 - 59) https://reviews.apache.org/r/37189/#comment149144 I think is better to use `boost::hash_combine` here. - Alexander Rojas On Aug. 7, 2015, 11:46 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 7, 2015, 11:46 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Repository: mesos Description --- Added std::hash template specializations. Diffs - include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 Diff: https://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 2:31 p.m.) Review request for mesos, Benjamin Hindman, Marco Massenzio, and Sebastien Pahl. Changes --- rebase code Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs (updated) - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.
On Aug. 5, 2015, 3:38 a.m., Cody Maloney wrote: configure.ac, line 548 https://reviews.apache.org/r/36811/diff/6/?file=1025039#file1025039line548 The check should come before we do the AC_SUBST. I don't want to just move the AC_SUBST way away from the rest of the protobuf checking code though. I think it would be better moving the whole protobuf / protobuf.jar check section to after the java check, then just update the if java check around the AC_CHECK_FILE where it was previously. Hi, @cmaloney thank you for your review. I update it and move the protobuf check after python and java. Could you help review again? - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/#review94176 --- On Aug. 7, 2015, 3:21 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/ --- (Updated Aug. 7, 2015, 3:21 p.m.) Review request for mesos, Adam B, Cody Maloney, Michael Park, and Timothy St. Clair. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar when --disable-java flag. Diffs - configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 Diff: https://reviews.apache.org/r/36811/diff/ Testing --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check ``` [--] Global test environment tear-down [==] 644 tests from 91 test cases ran. (431596 ms total) [ PASSED ] 644 tests. ``` ../configure make -j4 make check ``` [--] Global test environment tear-down [==] 685 tests from 98 test cases ran. (554759 ms total) [ PASSED ] 685 tests. ``` ../configure --disable-java make -j4 make check ``` [--] Global test environment tear-down [==] 644 tests from 91 test cases ran. (427688 ms total) [ PASSED ] 644 tests. ``` ../configure --with-protobuf=/usr/local make -j4 make check ``` [--] Global test environment tear-down [==] 685 tests from 98 test cases ran. (551493 ms total) [ PASSED ] 685 tests. ``` Thanks, haosdent huang
Re: Review Request 36816: Support HTTP checks in Mesos health check program
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 7, 2015, 3:35 p.m.) Review request for mesos, Adam B and Michael Park. Bugs: MESOS-2533 https://issues.apache.org/jira/browse/MESOS-2533 Repository: mesos Description --- Support HTTP checks in Mesos health check program Diffs (updated) - include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/36816/diff/ Testing --- * Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp make check Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated Aug. 7, 2015, 3:48 p.m.) Review request for mesos, Adam B, Jie Yu, and Michael Park. Changes --- rebase from current master Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs (updated) - include/mesos/roles.hpp PRE-CREATION src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/roles.cpp PRE-CREATION src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756 src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/roles_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Review Request 37222: Enable automake maintainer mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37222/ --- Review request for mesos. Bugs: MESOS-3234 https://issues.apache.org/jira/browse/MESOS-3234 Repository: mesos Description --- Enable automake maintainer mode. Diffs - 3rdparty/libprocess/configure.ac 43c026343d3cc0d10c455480989a94afd069d1b4 Diff: https://reviews.apache.org/r/37222/diff/ Testing --- Run configure --help and check for the --disable-maintainer-mode option. Thanks, James Peach
Review Request 37221: Enable automake maintainer mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37221/ --- Review request for mesos. Bugs: MESOS-3234 https://issues.apache.org/jira/browse/MESOS-3234 Repository: mesos Description --- Enable automake maintainer mode. Diffs - configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 Diff: https://reviews.apache.org/r/37221/diff/ Testing --- Run configure --help and check for the --disable-maintainer-mode option. Thanks, James Peach
Review Request 35712: u
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35712/ --- Review request for mesos. Repository: mesos Description --- u Diffs (updated) - CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 Diff: https://reviews.apache.org/r/35712/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review94554 --- Patch looks great! Reviews applied: [36819] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/ --- (Updated Aug. 7, 2015, 3:21 p.m.) Review request for mesos, Adam B, Cody Maloney, Michael Park, and Timothy St. Clair. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar when --disable-java flag. Diffs (updated) - configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 Diff: https://reviews.apache.org/r/36811/diff/ Testing --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check ``` [--] Global test environment tear-down [==] 644 tests from 91 test cases ran. (431596 ms total) [ PASSED ] 644 tests. ``` ../configure make -j4 make check ``` [--] Global test environment tear-down [==] 685 tests from 98 test cases ran. (554759 ms total) [ PASSED ] 685 tests. ``` ../configure --disable-java make -j4 make check ``` [--] Global test environment tear-down [==] 644 tests from 91 test cases ran. (427688 ms total) [ PASSED ] 644 tests. ``` ../configure --with-protobuf=/usr/local make -j4 make check ``` [--] Global test environment tear-down [==] 685 tests from 98 test cases ran. (551493 ms total) [ PASSED ] 685 tests. ``` Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated Aug. 7, 2015, 3:40 p.m.) Review request for mesos, Adam B, Jie Yu, and Michael Park. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs (updated) - include/mesos/roles.hpp PRE-CREATION src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/roles.cpp PRE-CREATION src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756 src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/roles_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/#review94562 --- Patch looks great! Reviews applied: [36810, 36811] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 3:21 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/ --- (Updated Aug. 7, 2015, 3:21 p.m.) Review request for mesos, Adam B, Cody Maloney, Michael Park, and Timothy St. Clair. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar when --disable-java flag. Diffs - configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 Diff: https://reviews.apache.org/r/36811/diff/ Testing --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check ``` [--] Global test environment tear-down [==] 644 tests from 91 test cases ran. (431596 ms total) [ PASSED ] 644 tests. ``` ../configure make -j4 make check ``` [--] Global test environment tear-down [==] 685 tests from 98 test cases ran. (554759 ms total) [ PASSED ] 685 tests. ``` ../configure --disable-java make -j4 make check ``` [--] Global test environment tear-down [==] 644 tests from 91 test cases ran. (427688 ms total) [ PASSED ] 644 tests. ``` ../configure --with-protobuf=/usr/local make -j4 make check ``` [--] Global test environment tear-down [==] 685 tests from 98 test cases ran. (551493 ms total) [ PASSED ] 685 tests. ``` Thanks, haosdent huang
Re: Review Request 37097: Fix 'Accept-Encoding' parsing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/ --- (Updated Aug. 7, 2015, 6:52 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- Currently parsing only compares the begining of the header making 'gzipbug' match with candidate 'gzip' Diffs (updated) - 3rdparty/libprocess/include/process/http.hpp b8d9300 3rdparty/libprocess/src/http.cpp 4dcbd74 3rdparty/libprocess/src/tests/encoder_tests.cpp 0032137 Diff: https://reviews.apache.org/r/37097/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94568 --- Ship it! Ship It! - Vinod Kone On Aug. 7, 2015, 2:56 a.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 7, 2015, 2:56 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Description --- This implements the tests for http framework subscribe/failover/upgrade from a pid based framework. The test are parameterized on content type and hence test both json/protobuf responses. Diffs - src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar
Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/ --- Review request for mesos and Niklas Nielsen. Repository: mesos Description --- If that task being launched has a command executor, there is no way for the hook to determine the executor-id for that task. This update calls the hook _after_ the ExecutorInfo has been created and thus is able to pass in ExecutorInfo to the label decorator. Diffs - include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 Diff: https://reviews.apache.org/r/37228/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated Aug. 7, 2015, 6:50 p.m.) Review request for mesos, Adam B, Jie Yu, and Michael Park. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs (updated) - include/mesos/roles.hpp PRE-CREATION src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/roles.cpp PRE-CREATION src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756 src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/roles_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Re: Review Request 37190: WIP: Added POST support for /maintenance endpoint. Performed initial verification of the input.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37190/ --- (Updated Aug. 7, 2015, 10:05 a.m.) Review request for Benjamin Hindman, Joris Van Remoortere and Joseph Wu. Changes --- Added maintenance state endpoint. Addressed remaining comment. Bugs: MESOS-2067 https://issues.apache.org/jira/browse/MESOS-2067 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/maintenance/maintenance.proto PRE-CREATION src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 src/master/maintenance.hpp PRE-CREATION src/master/maintenance.cpp PRE-CREATION src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702 Diff: https://reviews.apache.org/r/37190/diff/ Testing --- Manual testing of the endpoint. Thanks, Artem Harutyunyan
Re: Review Request 36816: Support HTTP checks in Mesos health check program
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review94569 --- Patch looks great! Reviews applied: [36816] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 3:35 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 7, 2015, 3:35 p.m.) Review request for mesos, Adam B and Michael Park. Bugs: MESOS-2533 https://issues.apache.org/jira/browse/MESOS-2533 Repository: mesos Description --- Support HTTP checks in Mesos health check program Diffs - include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/36816/diff/ Testing --- * Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp make check Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review94571
---
Bad patch!
Reviews applied: [35711]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d mesos-0.24.0; then find mesos-0.24.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.24.0 || { sleep 5 rm -rf
mesos-0.24.0; }; else :; fi
test -d mesos-0.24.0 || mkdir mesos-0.24.0
(cd 3rdparty make top_distdir=../mesos-0.24.0
distdir=../mesos-0.24.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess make top_distdir=../../mesos-0.24.0
distdir=../../mesos-0.24.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d ../../mesos-0.24.0/3rdparty/libprocess || mkdir
../../mesos-0.24.0/3rdparty/libprocess
(cd 3rdparty make top_distdir=../../../mesos-0.24.0
distdir=../../../mesos-0.24.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout make top_distdir=../../../../mesos-0.24.0
distdir=../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d ../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout || mkdir
../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout
(cd include make top_distdir=../../../../../mesos-0.24.0
distdir=../../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[6]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
make[6]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
test -n : \
|| find ../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout
-type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r
../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout
make[5]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd include make top_distdir=../../../mesos-0.24.0
distdir=../../../mesos-0.24.0/3rdparty/libprocess/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
test -n : \
|| find ../../mesos-0.24.0/3rdparty/libprocess -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r ../../mesos-0.24.0/3rdparty/libprocess
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd src make top_distdir=../mesos-0.24.0 distdir=../mesos-0.24.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[2]: *** No rule to make target `common/thread.cpp', needed by `distdir'.
Stop.
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make: *** [dist] Error 2
- Mesos
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing (updated) --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/#review94578 --- Patch looks great! Reviews applied: [37228] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 6:51 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/ --- (Updated Aug. 7, 2015, 6:51 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos Description --- If that task being launched has a command executor, there is no way for the hook to determine the executor-id for that task. This update calls the hook _after_ the ExecutorInfo has been created and thus is able to pass in ExecutorInfo to the label decorator. Diffs - include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 Diff: https://reviews.apache.org/r/37228/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 37114: MESOS-3187, support docker host command line option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 7, 2015, 9:19 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Timothy Chen, and Vinod Kone. Changes --- Addressed Comments Bugs: MESOS-3187 https://issues.apache.org/jira/browse/MESOS-3187 Repository: mesos Description --- MESOS-3187, support docker host command line option. Docker daemon supports starting on a non-default port. Such scenarios would needed when starting Docker daemon on TCP or non-default unix port. Mesos slave does not work if Docker daemon is started on any of such non-default port. The code change is needed in Mesos slave to accept this parameter so as connect for its operations to the right Docker daemon. The change is made in Mesos slave, so as it is available to any framework making using Docker executor. The code is added to start slave binary with --docker_host, instructing it to connect on port as specified in the parameter. The default value of --default_host is unix:///var/run/docker.sock, which is default port for Docker daemon. The main class src/docker.cpp/.hpp is kept backward compartible to make Docker cli execute on default Docker port. Diffs (updated) - src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e src/tests/containerizer/docker_containerizer_tests.cpp 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f src/tests/flags.hpp 364495695c5915e54257014aeebb1e212d3da6fc Diff: https://reviews.apache.org/r/37114/diff/ Testing --- Following scenarios were executed to test the code changes. Kindly suggest if more test-cases are required: a) Mesos slave with unix port : unix:///var/run/docker_myport.sock i) Start slave with --docker_host parameter unix:///var/run/docker_myport.sock ii) Using a framework, in my case Marathon, post a Docker job iii) The docker job does get started on the slave, confirmed with docker ps command output docker -H unix:///var/run/docker_myport.sock ps CONTAINER IDIMAGE COMMANDCREATED STATUS PORTS NAMES 07fc4ec86bacmygoserver /bin/sh -c /mygoser 19 minutes ago Up 19 minutes */tcp, */udp mesos-20150731-104052-1051068938-5050-7913-S33.17b355cd-2754-4fb2-a558-66820dff033c iv) Stop or destroy the job from Marathon GUI b) Two mesos slave with non-default docker port i) On two different hosts, start slave, with one running on default port and other non-default. The start slaves with attributes - default and or non-default. ii) Give jobs to these slaves, using Marathon UNIQUE attribute, selecting slave - non-default default iii) Stop/destroy the jobs d) Modified unit test-case taking docker port value - make check Thanks, Vaibhav Khanduja
Re: Review Request 36431: Show stdout/stderr when using mesos-execute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/#review94530 --- Patch looks great! Reviews applied: [36431] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 10:37 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/ --- (Updated Aug. 7, 2015, 10:37 a.m.) Review request for mesos, Adam B and Michael Park. Bugs: MESOS-1084 https://issues.apache.org/jira/browse/MESOS-1084 Repository: mesos Description --- Show stdout/stderr when using mesos-execute. Diffs - src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc Diff: https://reviews.apache.org/r/36431/diff/ Testing --- make check  Thanks, haosdent huang
Re: Review Request 37189: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94533 --- Patch looks great! Reviews applied: [37187, 37188, 37189] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 11:52 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 7, 2015, 11:52 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 Diff: https://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 7, 2015, 1:52 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs (updated) - include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 Diff: https://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37188: Added std::hash template specializations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 1:53 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Add comment describing hashmap behaviour. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs (updated) - 3rdparty/libprocess/include/process/address.hpp be216db823160f5db1dfb4502bf832246fb3df6d 3rdparty/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
On Aug. 7, 2015, 12:06 p.m., Alexander Rojas wrote: include/mesos/type_utils.hpp, line 515 https://reviews.apache.org/r/37189/diff/1/?file=1033607#file1033607line515 Perhaps add a summarized version of this comment into the code? I've added a comment to every occurence to explain the static_cast. We should keep the other options mentioned in the former comment in mind. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94519 --- On Aug. 7, 2015, 12:28 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 7, 2015, 12:28 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Added std::hash template specializations. Diffs - include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 Diff: https://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/ --- (Updated Aug. 7, 2015, 11:30 p.m.) Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Changes --- Moved the tests to a new file and added a few comments. Bugs: MESOS-2794 https://issues.apache.org/jira/browse/MESOS-2794 Repository: mesos Description --- Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator. This adds the tests for https://reviews.apache.org/r/37236/ Diffs (updated) - src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION src/tests/containerizer/provisioner.hpp PRE-CREATION Diff: https://reviews.apache.org/r/37237/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37142: Removed the unneeded ExecutorInfo from Container struct in MesosContainerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37142/#review94594 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 5, 2015, 2:22 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37142/ --- (Updated Aug. 5, 2015, 2:22 p.m.) Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Repository: mesos Description --- Removed the unneeded ExecutorInfo from Container struct in MesosContainerizer. This is no longer needed since we are going to call provisioner-destory(containerId) for every provisioners. See r37105 for more details. Diffs - src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 Diff: https://reviews.apache.org/r/37142/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 37197: Docker image store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review94582 --- src/slave/containerizer/provisioners/docker/store.hpp (line 125) https://reviews.apache.org/r/37197/#comment149188 Layers no longer in store. src/slave/containerizer/provisioners/docker/store.hpp (line 128) https://reviews.apache.org/r/37197/#comment149189 fetcher is actually never used, maybe I should just get rid of it - Lily Chen On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 6, 2015, 10:51 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Stored images currently kept indefinitely. Diffs - src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37197/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37197: Docker image store.
On Aug. 6, 2015, 9:34 p.m., Timothy Chen wrote: src/slave/containerizer/provisioners/docker/store.hpp, line 123 https://reviews.apache.org/r/37197/diff/1/?file=1033680#file1033680line123 End comment with period. And why not use ImageName as keys, or basically everywhere else in the provisioner? ImageName had no hash function, also images functionality will be moved to reference store. - Lily --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review94448 --- On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 6, 2015, 10:51 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Stored images currently kept indefinitely. Diffs - src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37197/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37241: Renamed master's /call endpoint to /api/v1/scheduler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37241/#review94595 --- Ship it! Ship It! - Isabel Jimenez On Aug. 7, 2015, 11:44 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37241/ --- (Updated Aug. 7, 2015, 11:44 p.m.) Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler. Bugs: MESOS-2860 https://issues.apache.org/jira/browse/MESOS-2860 Repository: mesos Description --- See summary. Diffs - src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90 src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37241/diff/ Testing --- make check Thanks, Vinod Kone
Review Request 37241: Renamed master's /call endpoint to /api/v1/scheduler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37241/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler. Bugs: MESOS-2860 https://issues.apache.org/jira/browse/MESOS-2860 Repository: mesos Description --- See summary. Diffs - src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90 src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37241/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 37105: Removed the code of checkpointing container root filesystem path.
On Aug. 6, 2015, 11:16 p.m., Jiang Yan Xu wrote: src/slave/containerizer/mesos/containerizer.hpp, line 184 https://reviews.apache.org/r/37105/diff/2/?file=1032855#file1032855line184 Simple documentation on the return value? This code will be removed soon. So I'll just leave as it is right now. On Aug. 6, 2015, 11:16 p.m., Jiang Yan Xu wrote: src/slave/containerizer/mesos/containerizer.cpp, lines 637-643 https://reviews.apache.org/r/37105/diff/2/?file=1032856#file1032856line637 Why can't `prepare()` be chained by `then()` anymore? Same as above, this code will be removed in the subsequent patch. On Aug. 6, 2015, 11:16 p.m., Jiang Yan Xu wrote: src/slave/containerizer/mesos/containerizer.cpp, lines 689-690 https://reviews.apache.org/r/37105/diff/2/?file=1032856#file1032856line689 This doesn't get implicitly converted to Option? No. I tried. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37105/#review94153 --- On Aug. 5, 2015, 9:16 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37105/ --- (Updated Aug. 5, 2015, 9:16 p.m.) Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-3205 https://issues.apache.org/jira/browse/MESOS-3205 Repository: mesos Description --- Removed the code of checkpointing container root filesystem path. See ticket for the motivation. Diffs - include/mesos/slave/isolator.proto 3d9222be5e9bd9e9f665fb2e57db6b7e925c8fbd src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac src/slave/paths.cpp 404c2143e70771747d356b15eac9137495fd9a75 src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c Diff: https://reviews.apache.org/r/37105/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 37105: Removed the code of checkpointing container root filesystem path.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37105/#review94598 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 5, 2015, 2:16 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37105/ --- (Updated Aug. 5, 2015, 2:16 p.m.) Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-3205 https://issues.apache.org/jira/browse/MESOS-3205 Repository: mesos Description --- Removed the code of checkpointing container root filesystem path. See ticket for the motivation. Diffs - include/mesos/slave/isolator.proto 3d9222be5e9bd9e9f665fb2e57db6b7e925c8fbd src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac src/slave/paths.cpp 404c2143e70771747d356b15eac9137495fd9a75 src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c Diff: https://reviews.apache.org/r/37105/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 37159: Delegated the container root filesystem provisioning to the filesystem isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37159/#review94601 --- Ship it! Ship It! - Timothy Chen On Aug. 6, 2015, 4:20 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37159/ --- (Updated Aug. 6, 2015, 4:20 a.m.) Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Repository: mesos Description --- Delegated the container root filesystem provisioning to the filesystem isolator. The motivation is that: currently, container rootfs provisioning is done by the containerizer while preparing the rest of the filesystem (i.e., bind mount volumes) is done by the filesystem isolator. It'll be more natural if all filesystem related preparation is done by one component. Another reason is that we are going to provision images specified in the volumes as well. So provisining rootfs in filesystem isolator makes it more easy to implement. Turns out that this change simplify the containerizer quite a bit. Diffs - include/mesos/slave/isolator.hpp 22f1e3686f50c3b9290561aa7e5073e24a702824 include/mesos/slave/isolator.proto 3d9222be5e9bd9e9f665fb2e57db6b7e925c8fbd src/slave/containerizer/isolator.hpp 710c584f95d60c1931b40ca041409aa819a06cba src/slave/containerizer/isolator.cpp ed610f9f8fe328fb3b73f620858dc632725e51f8 src/slave/containerizer/isolators/cgroups/cpushare.hpp 6b980f26fe8bb51dd989a0578337bc13dbd087ad src/slave/containerizer/isolators/cgroups/cpushare.cpp 907d7e78bfb591197e150ac053bb857d15a1e6dc src/slave/containerizer/isolators/cgroups/mem.hpp e831878ab47b8455a4831ebe305373130b194a40 src/slave/containerizer/isolators/cgroups/mem.cpp e343d0b9751b46bc5a4a8ccd32c0b2745e110e6b src/slave/containerizer/isolators/cgroups/perf_event.hpp 73f245bc9166e1f7550466ddd97113c63ce44e73 src/slave/containerizer/isolators/cgroups/perf_event.cpp 0e421cb6ad3e04b71746033ab15d0f1695fcd5e7 src/slave/containerizer/isolators/filesystem/posix.hpp 4c7a6f2b7530c88c34d533dba9593006ad5284b2 src/slave/containerizer/isolators/filesystem/posix.cpp 4861ee13fc34eef03d28f26d57a7d11aebed81a6 src/slave/containerizer/isolators/filesystem/shared.hpp 45e4ba09993e7b77f2df45a5c86bc00fa2d83977 src/slave/containerizer/isolators/filesystem/shared.cpp b30ab3fd0013045a2843fe1e8843cc120ce180c6 src/slave/containerizer/isolators/namespaces/pid.hpp 858e43683c88ac62abfc74ff28e8073895cf6f64 src/slave/containerizer/isolators/namespaces/pid.cpp 8e643f4afae8c24cd4d68aa349148b6f402b286b src/slave/containerizer/isolators/network/port_mapping.hpp 2599c9800e3edf12ec883b31c280324b24b195c5 src/slave/containerizer/isolators/network/port_mapping.cpp 8244c345b84108af7fa18d20e71401d6e1a0aeb0 src/slave/containerizer/isolators/posix.hpp ef19749c0d5b795fee54d67cfc0d983b0f7084ec src/slave/containerizer/isolators/posix/disk.hpp 9fa584ff4a2f3c90c4d81aecefbcba57fa2294ad src/slave/containerizer/isolators/posix/disk.cpp 6dda77bad7ab135b6d339a80b98a291ea7120e95 src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 src/tests/containerizer/isolator.hpp fa2fc9bd6a59de130870f1ab199e05e85579d8dd src/tests/containerizer/isolator_tests.cpp ff6e2b7e190a58a4809d6e71addb15dabe418e17 src/tests/containerizer/mesos_containerizer_tests.cpp 213fa4b0b9c50eba941ef6b52497eb32d539 src/tests/containerizer/port_mapping_tests.cpp 4bee74acba2b1472c80cabbc9d0384bd04c543aa Diff: https://reviews.apache.org/r/37159/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37194: Fixed a bug in the MesosContainerizer creation logic.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37194/ --- (Updated Aug. 8, 2015, 12:18 a.m.) Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-2794 https://issues.apache.org/jira/browse/MESOS-2794 Repository: mesos Description --- Fixed a bug in the MesosContainerizer creation logic. I did a few small style fixes and added a few more comments in the patch as well. The bug is that currently we only put filesystem isolator to the front if it's coming from modules. Diffs - src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 Diff: https://reviews.apache.org/r/37194/diff/ Testing --- make check Thanks, Jie Yu
Review Request 37244: Fixed scheduler message metrics to work with scheduler Calls.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37244/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-3195 https://issues.apache.org/jira/browse/MESOS-3195 Repository: mesos Description --- The one difference between the old code and this code is that metrics are not updated if we drop the call (e.g., framework is unknown or wrong framework). But I think that's reasonable. Diffs - src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 Diff: https://reviews.apache.org/r/37244/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 37241: Renamed master's /call endpoint to /api/v1/scheduler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37241/#review94605 --- Patch looks great! Reviews applied: [37240, 37241] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 11:44 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37241/ --- (Updated Aug. 7, 2015, 11:44 p.m.) Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler. Bugs: MESOS-2860 https://issues.apache.org/jira/browse/MESOS-2860 Repository: mesos Description --- See summary. Diffs - src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90 src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37241/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 37196: Add Docker Image type to Container Image protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37196/ --- (Updated Aug. 8, 2015, 1:29 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. Bugs: MESOS-2851 https://issues.apache.org/jira/browse/MESOS-2851 Repository: mesos Description --- Add Docker Image type to Container Image protobuf. Diffs (updated) - include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 Diff: https://reviews.apache.org/r/37196/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37197: Docker image store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 8, 2015, 1:30 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Stored images currently kept indefinitely. Diffs (updated) - src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37197/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37198: Add Docker image provisioner and copy backend.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 8, 2015, 1:31 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Add Docker image provisioner and copy backend. Diffs (updated) - src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 src/slave/containerizer/provisioner.cpp efc7e6996ff6663bebaf61989a7e040bd2ad7a5e src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37198/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37199/ --- (Updated Aug. 8, 2015, 1:32 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added store interface and moved store implementation to LocalStore subclass. Diffs (updated) - src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37199/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 8, 2015, 1:33 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers. Diffs (updated) - src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37200/diff/ Testing --- make check Thanks, Lily Chen
Review Request 37245: Refactor Docker Image to exclude path and manifest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37245/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Refactor Docker Image to exclude path and manifest. Diffs - src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37245/diff/ Testing --- make check Thanks, Lily Chen
Review Request 37246: Refactor store to use updated DockerImage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37246/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Refactor local store to use updated DockerImage. Diffs - src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37246/diff/ Testing --- make check Thanks, Lily Chen
Review Request 37247: Added Docker image reference store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3021 https://issues.apache.org/jira/browse/MESOS-3021 Repository: mesos Description --- Added Docker image reference store. Diffs - include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37247/diff/ Testing --- make check Tests will be added in a later review. Thanks, Lily Chen
Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/#review94611 --- Patch looks great! Reviews applied: [36929, 36930, 36954, 36956, 37054, 37055, 37091, 37105, 37142, 37159, 37194, 37236, 37237] All tests passed. - Mesos ReviewBot On Aug. 8, 2015, 12:32 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/ --- (Updated Aug. 8, 2015, 12:32 a.m.) Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-2794 https://issues.apache.org/jira/browse/MESOS-2794 Repository: mesos Description --- Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator. This adds the tests for https://reviews.apache.org/r/37236/ Diffs - src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION src/tests/containerizer/provisioner.hpp PRE-CREATION Diff: https://reviews.apache.org/r/37237/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37244: Fixed scheduler message metrics to work with scheduler Calls.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37244/#review94612 --- Patch looks great! Reviews applied: [37244] All tests passed. - Mesos ReviewBot On Aug. 8, 2015, 12:53 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37244/ --- (Updated Aug. 8, 2015, 12:53 a.m.) Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-3195 https://issues.apache.org/jira/browse/MESOS-3195 Repository: mesos Description --- The one difference between the old code and this code is that metrics are not updated if we drop the call (e.g., framework is unknown or wrong framework). But I think that's reasonable. Diffs - src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 Diff: https://reviews.apache.org/r/37244/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 37023: Add an endpoint that exposes component flags.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
---
(Updated Aug. 8, 2015, 3:49 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
---
Add an endpoint that exposes component flags.
Diffs (updated)
-
3rdparty/libprocess/include/process/http.hpp
04c2274bbd53b7e7ed770ea201555218559af078
include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807
include/mesos/slave/isolator.hpp 970730f0ffc7f3359685ccf81452856bea1c4a06
include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec
src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33
src/common/protobuf_utils.hpp 312bc61ebb612be64fc5cfbcda8dcaf9663be6c7
src/common/protobuf_utils.cpp 4de176b5b1d7fe71bdb895b19a90a1d9d33d37db
src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90
src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
src/slave/containerizer/isolator.hpp fbb7c8ab908192ae64f34e466c0c24705b3a134b
src/slave/containerizer/isolator.cpp 7973100ea1a58938c50962120b9ecb6722b2ee4e
src/slave/containerizer/isolators/cgroups/cpushare.hpp
54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263
src/slave/containerizer/isolators/cgroups/cpushare.cpp
ba748c6caec7253b42167e8a4f9b4535da858259
src/slave/containerizer/isolators/cgroups/mem.hpp
47f73c3b75eb550f766b4ee245731fd3b62fdaee
src/slave/containerizer/isolators/cgroups/mem.cpp
48d7fbdff1e733b7d2200b766670e3b6f9902cb3
src/slave/containerizer/isolators/cgroups/perf_event.hpp
c1578b11ea1afd30929b4ea6f2c8272fb65454ce
src/slave/containerizer/isolators/cgroups/perf_event.cpp
8c3018de8e77a2a00c90559a995eae2b3678e42f
src/slave/containerizer/isolators/filesystem/posix.hpp
61b81dda8124e15433f27e1683e037bb641d2e8e
src/slave/containerizer/isolators/filesystem/posix.cpp
eec510c4f7655d67b33ad90210eeb57fcc910684
src/slave/containerizer/isolators/filesystem/shared.hpp
a21bc79d342ece50c4924fc0ebd2186e57b3e899
src/slave/containerizer/isolators/filesystem/shared.cpp
4b4520e30ce1d1818bd3a13260f6dd55ab3900c9
src/slave/containerizer/isolators/namespaces/pid.hpp
b22f5ba8e3743bb243ed2c5d204ab4ba21088630
src/slave/containerizer/isolators/namespaces/pid.cpp
35cb6645c9abc0cf533b844e2b2cccf4374bfd68
src/slave/containerizer/isolators/network/port_mapping.hpp
4bca0b81bf69fb4cd75e05aacd02d3e818e32d09
src/slave/containerizer/isolators/network/port_mapping.cpp
88c0cbc61f3f97b084cc3b3fae8999b07d4aa1c7
src/slave/containerizer/isolators/posix.hpp
ee9d275e7fe5fc22c1bab86dd0a558cc8ab9044e
src/slave/containerizer/isolators/posix/disk.hpp
85df5d2855513c760b4f767ea105a547f630a5bf
src/slave/containerizer/isolators/posix/disk.cpp
c324c79f8d598095d07fbcb26e806a0978c2a520
src/slave/containerizer/mesos/containerizer.hpp
4c1419290645ad4c44360a81618a6cea7ad190df
src/slave/containerizer/mesos/containerizer.cpp
2cbb879888baf6aff76fbd7c1e19027300fb86e3
src/slave/containerizer/provisioner.hpp
541dd4e0b2f0c92a45c00cab6132a2be69654838
src/slave/containerizer/provisioner.cpp
efc7e6996ff6663bebaf61989a7e040bd2ad7a5e
src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2
src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp f8a9514f52bf9f886171c2a0e674e5a89f8dbea7
src/tests/containerizer/isolator.hpp 56ac27b0fab35a03888c906d7d7167bb71f06061
src/tests/containerizer/isolator_tests.cpp
dd1ae22865ce4467da5ed819e7f0a1cbb834371d
src/tests/containerizer/launch_tests.cpp
d211fc0f665988068c67836ef80916828a0df2bd
src/tests/containerizer/mesos_containerizer_tests.cpp
5bc7d408bda0c249e1b66747d8bd87e688362e6c
src/tests/containerizer/port_mapping_tests.cpp
3c9b7c816a03e2994a353674c5963f1dda043124
src/tests/containerizer/rootfs.hpp 55dd4964cfb1ca0e5f7b7616ccc6d5ad2be135d7
Diff: https://reviews.apache.org/r/37023/diff/
Testing
---
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags.json 2/dev/null|jq .
{
flags: {
allocation_interval: 1secs,
allocator: HierarchicalDRF,
authenticate: false,
authenticate_slaves: false,
authenticators: crammd5,
framework_sorter: drf,
help: true,
initialize_driver_logging: true,
log_auto_initialize: true,
logbufsecs: 0,
logging_level: INFO,
max_slave_ping_timeouts: 5,
quiet: false,
recovery_slave_removal_limit: 100%,
registry: replicated_log,
registry_fetch_timeout: 1mins,
registry_store_timeout: 5secs,
registry_strict:
Re: Review Request 37023: Add an endpoint that exposes component flags.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
---
(Updated Aug. 8, 2015, 3:50 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
---
Add an endpoint that exposes component flags.
Diffs (updated)
-
src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90
src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9
Diff: https://reviews.apache.org/r/37023/diff/
Testing
---
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags.json 2/dev/null|jq .
{
flags: {
allocation_interval: 1secs,
allocator: HierarchicalDRF,
authenticate: false,
authenticate_slaves: false,
authenticators: crammd5,
framework_sorter: drf,
help: true,
initialize_driver_logging: true,
log_auto_initialize: true,
logbufsecs: 0,
logging_level: INFO,
max_slave_ping_timeouts: 5,
quiet: false,
recovery_slave_removal_limit: 100%,
registry: replicated_log,
registry_fetch_timeout: 1mins,
registry_store_timeout: 5secs,
registry_strict: false,
root_submissions: true,
slave_ping_timeout: 15secs,
slave_reregister_timeout: 10mins,
user_sorter: drf,
version: false,
webui_dir: /home/haosdent/mesos/build/../src/webui,
work_dir: /tmp/mesos,
zk_session_timeout: 10secs
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags.json 2/dev/null|jq .
{
flags: {
authenticatee: crammd5,
cgroups_cpu_enable_pids_and_tids_count: false,
cgroups_enable_cfs: false,
cgroups_hierarchy: /sys/fs/cgroup,
cgroups_limit_swap: false,
cgroups_root: mesos,
container_disk_watch_interval: 15secs,
containerizers: mesos,
default_role: *,
disk_watch_interval: 1mins,
docker: docker,
docker_kill_orphans: true,
docker_remove_delay: 6hrs,
docker_socket: /var/run/docker.sock,
docker_stop_timeout: 0ns,
enforce_container_disk_quota: false,
executor_registration_timeout: 1mins,
executor_shutdown_grace_period: 5secs,
fetcher_cache_dir: /tmp/mesos/fetch,
fetcher_cache_size: 2GB,
frameworks_home: ,
gc_delay: 1weeks,
gc_disk_headroom: 0.1,
hadoop_home: ,
help: false,
initialize_driver_logging: true,
isolation: posix/cpu,posix/mem,
launcher_dir: /home/haosdent/mesos/build/src,
logbufsecs: 0,
logging_level: INFO,
oversubscribed_resources_interval: 15secs,
perf_duration: 10secs,
perf_interval: 1mins,
qos_correction_interval_min: 0ns,
quiet: false,
recover: reconnect,
recovery_timeout: 15mins,
registration_backoff_factor: 1secs,
resource_monitoring_interval: 1secs,
revocable_cpu_low_priority: true,
sandbox_directory: /mnt/mesos/sandbox,
strict: true,
switch_user: true,
version: false,
work_dir: /tmp/mesos/0
}
}
```
Thanks,
haosdent huang
Review Request 37252: Fix typos in master endpoint help messages.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37252/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3238 https://issues.apache.org/jira/browse/MESOS-3238 Repository: mesos Description --- Fix typos in master endpoint help messages. Diffs - src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90 Diff: https://reviews.apache.org/r/37252/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 37252: Fix typos in master endpoint help messages.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37252/ --- (Updated Aug. 8, 2015, 4:14 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-3238 https://issues.apache.org/jira/browse/MESOS-3238 Repository: mesos Description --- Fix typos in master endpoint help messages. Diffs - src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90 Diff: https://reviews.apache.org/r/37252/diff/ Testing (updated) --- make check Thanks, haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component flags.
On Aug. 3, 2015, 7:45 p.m., Ben Mahler wrote:
src/master/http.cpp, line 958
https://reviews.apache.org/r/37023/diff/2/?file=1027280#file1027280line958
Could you fix this in a separate patch?
I split here. https://reviews.apache.org/r/37252/ Thank you very much!
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review93952
---
On Aug. 8, 2015, 3:50 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
---
(Updated Aug. 8, 2015, 3:50 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
---
Add an endpoint that exposes component flags.
Diffs
-
src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90
src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9
Diff: https://reviews.apache.org/r/37023/diff/
Testing
---
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags.json 2/dev/null|jq .
{
flags: {
allocation_interval: 1secs,
allocator: HierarchicalDRF,
authenticate: false,
authenticate_slaves: false,
authenticators: crammd5,
framework_sorter: drf,
help: true,
initialize_driver_logging: true,
log_auto_initialize: true,
logbufsecs: 0,
logging_level: INFO,
max_slave_ping_timeouts: 5,
quiet: false,
recovery_slave_removal_limit: 100%,
registry: replicated_log,
registry_fetch_timeout: 1mins,
registry_store_timeout: 5secs,
registry_strict: false,
root_submissions: true,
slave_ping_timeout: 15secs,
slave_reregister_timeout: 10mins,
user_sorter: drf,
version: false,
webui_dir: /home/haosdent/mesos/build/../src/webui,
work_dir: /tmp/mesos,
zk_session_timeout: 10secs
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags.json 2/dev/null|jq .
{
flags: {
authenticatee: crammd5,
cgroups_cpu_enable_pids_and_tids_count: false,
cgroups_enable_cfs: false,
cgroups_hierarchy: /sys/fs/cgroup,
cgroups_limit_swap: false,
cgroups_root: mesos,
container_disk_watch_interval: 15secs,
containerizers: mesos,
default_role: *,
disk_watch_interval: 1mins,
docker: docker,
docker_kill_orphans: true,
docker_remove_delay: 6hrs,
docker_socket: /var/run/docker.sock,
docker_stop_timeout: 0ns,
enforce_container_disk_quota: false,
executor_registration_timeout: 1mins,
executor_shutdown_grace_period: 5secs,
fetcher_cache_dir: /tmp/mesos/fetch,
fetcher_cache_size: 2GB,
frameworks_home: ,
gc_delay: 1weeks,
gc_disk_headroom: 0.1,
hadoop_home: ,
help: false,
initialize_driver_logging: true,
isolation: posix/cpu,posix/mem,
launcher_dir: /home/haosdent/mesos/build/src,
logbufsecs: 0,
logging_level: INFO,
oversubscribed_resources_interval: 15secs,
perf_duration: 10secs,
perf_interval: 1mins,
qos_correction_interval_min: 0ns,
quiet: false,
recover: reconnect,
recovery_timeout: 15mins,
registration_backoff_factor: 1secs,
resource_monitoring_interval: 1secs,
revocable_cpu_low_priority: true,
sandbox_directory: /mnt/mesos/sandbox,
strict: true,
switch_user: true,
version: false,
work_dir: /tmp/mesos/0
}
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Add an endpoint that exposes component version.
On Aug. 3, 2015, 7:37 p.m., Ben Mahler wrote:
Thanks! Let's include the git / build information as well.
Another question, how are you planning to add this to the scheduler driver
and executor driver? In these cases, it is likely better to create a
'Version' Process with process id version that routes an endpoint at /
(so just /version should route to this). If we go with this approach, we
just have to start a 'Version' Process from the master/slave entrypoints
and the drivers' initialization.
Thank you very much. Let me use VersionProcess
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review93947
---
On Aug. 2, 2015, 10:16 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
---
(Updated Aug. 2, 2015, 10:16 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
---
Add an endpoint that exposes component version.
Diffs
-
src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f
src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
Diff: https://reviews.apache.org/r/37024/diff/
Testing
---
Manual test result:
```
$ curl http://localhost:5050/slave(1)/version.json 2/dev/null|jq .
{
version: 0.24.0
}
```
```
$ curl http://localhost:5050/master/version.json 2/dev/null|jq .
{
version: 0.24.0
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component flags.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review94618
---
Patch looks great!
Reviews applied: [37023]
All tests passed.
- Mesos ReviewBot
On Aug. 8, 2015, 3:50 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
---
(Updated Aug. 8, 2015, 3:50 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
---
Add an endpoint that exposes component flags.
Diffs
-
src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90
src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9
Diff: https://reviews.apache.org/r/37023/diff/
Testing
---
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags.json 2/dev/null|jq .
{
flags: {
allocation_interval: 1secs,
allocator: HierarchicalDRF,
authenticate: false,
authenticate_slaves: false,
authenticators: crammd5,
framework_sorter: drf,
help: true,
initialize_driver_logging: true,
log_auto_initialize: true,
logbufsecs: 0,
logging_level: INFO,
max_slave_ping_timeouts: 5,
quiet: false,
recovery_slave_removal_limit: 100%,
registry: replicated_log,
registry_fetch_timeout: 1mins,
registry_store_timeout: 5secs,
registry_strict: false,
root_submissions: true,
slave_ping_timeout: 15secs,
slave_reregister_timeout: 10mins,
user_sorter: drf,
version: false,
webui_dir: /home/haosdent/mesos/build/../src/webui,
work_dir: /tmp/mesos,
zk_session_timeout: 10secs
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags.json 2/dev/null|jq .
{
flags: {
authenticatee: crammd5,
cgroups_cpu_enable_pids_and_tids_count: false,
cgroups_enable_cfs: false,
cgroups_hierarchy: /sys/fs/cgroup,
cgroups_limit_swap: false,
cgroups_root: mesos,
container_disk_watch_interval: 15secs,
containerizers: mesos,
default_role: *,
disk_watch_interval: 1mins,
docker: docker,
docker_kill_orphans: true,
docker_remove_delay: 6hrs,
docker_socket: /var/run/docker.sock,
docker_stop_timeout: 0ns,
enforce_container_disk_quota: false,
executor_registration_timeout: 1mins,
executor_shutdown_grace_period: 5secs,
fetcher_cache_dir: /tmp/mesos/fetch,
fetcher_cache_size: 2GB,
frameworks_home: ,
gc_delay: 1weeks,
gc_disk_headroom: 0.1,
hadoop_home: ,
help: false,
initialize_driver_logging: true,
isolation: posix/cpu,posix/mem,
launcher_dir: /home/haosdent/mesos/build/src,
logbufsecs: 0,
logging_level: INFO,
oversubscribed_resources_interval: 15secs,
perf_duration: 10secs,
perf_interval: 1mins,
qos_correction_interval_min: 0ns,
quiet: false,
recover: reconnect,
recovery_timeout: 15mins,
registration_backoff_factor: 1secs,
resource_monitoring_interval: 1secs,
revocable_cpu_low_priority: true,
sandbox_directory: /mnt/mesos/sandbox,
strict: true,
switch_user: true,
version: false,
work_dir: /tmp/mesos/0
}
}
```
Thanks,
haosdent huang
Re: Review Request 37252: Fix typos in master endpoint help messages.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37252/#review94619 --- Patch looks great! Reviews applied: [37252] All tests passed. - Mesos ReviewBot On Aug. 8, 2015, 4:14 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37252/ --- (Updated Aug. 8, 2015, 4:14 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-3238 https://issues.apache.org/jira/browse/MESOS-3238 Repository: mesos Description --- Fix typos in master endpoint help messages. Diffs - src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90 Diff: https://reviews.apache.org/r/37252/diff/ Testing --- make check Thanks, haosdent huang
