Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/ --- (Updated Aug. 24, 2015, 4:02 p.m.) Review request for mesos, Joerg Schad, Michael Park, and Jan Schlicht. Changes --- Removes for range loops. R-Value references shouldn't be const. Bugs: MESOS-2924 https://issues.apache.org/jira/browse/MESOS-2924 Repository: mesos Description --- Adds extra template parameters to `multihashmap` which offer control over the hash function to use as well as the equality operator. Implements initializer_list, copy and move constructors for both, `multihashmap` and `Multimap` in a similar way as it was done for `hashmap` and `hashset`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp fb3e7a1d0377001389980302342813217f49cf5f 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37714/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/#review96143 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp (line 59) https://reviews.apache.org/r/37714/#comment151418 s/for/foreach. We don't use range-based for loops (yet). Below is another one. 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp (line 45) https://reviews.apache.org/r/37714/#comment151419 s/2/2u - Jan Schlicht On Aug. 24, 2015, 3:28 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/ --- (Updated Aug. 24, 2015, 3:28 p.m.) Review request for mesos, Joerg Schad, Michael Park, and Jan Schlicht. Bugs: MESOS-2924 https://issues.apache.org/jira/browse/MESOS-2924 Repository: mesos Description --- Adds extra template parameters to `multihashmap` which offer control over the hash function to use as well as the equality operator. Implements initializer_list, copy and move constructors for both, `multihashmap` and `Multimap` in a similar way as it was done for `hashmap` and `hashset`. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp fb3e7a1d0377001389980302342813217f49cf5f 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37714/diff/ Testing --- make check Thanks, Alexander Rojas
Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/ --- Review request for mesos, Joerg Schad and Michael Park. Bugs: MESOS-2924 https://issues.apache.org/jira/browse/MESOS-2924 Repository: mesos Description --- Adds extra template parameters to `multihashmap` which offer control over the hash function to use as well as the equality operator. Implements initializer_list, copy and move constructors for both, `multihashmap` and `Multimap` in a similar way as it was done for `hashmap` and `hashset`. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp fb3e7a1d0377001389980302342813217f49cf5f 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37714/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36620: Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96139 --- Given the rather complicated setup of this ( destroy - Destroyer -...- TasksKiller/s ), I think we really need tests here and also specifically tests that cover your addition (freezer-less cgroup destruction). src/linux/cgroups.cpp (lines 1626 - 1632) https://reviews.apache.org/r/36620/#comment151417 Why would the freezer component not be available -- can you please mention that e.g. a root owned cgroup wont have freezer.state available? Not sure if there are other expected reasons for a missing freezer though. src/linux/cgroups.cpp (lines 1696 - 1697) https://reviews.apache.org/r/36620/#comment151406 Kill one line plz. src/linux/cgroups.cpp (lines 1735 - 1737) https://reviews.apache.org/r/36620/#comment151409 Wouldn't this be a bit better in terms of preventing jaggedness? ``` promise.fail( Failed to kill all processes in cgroup: + (processes.isError() ? processes.error() : processes remain)); ``` src/linux/cgroups.cpp (line 1778) https://reviews.apache.org/r/36620/#comment151407 s/freezerCheckError/verify/ src/linux/cgroups.cpp (line 1854) https://reviews.apache.org/r/36620/#comment151408 s/move/Move/ - Till Toenshoff On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 24, 2015, 9:33 a.m.) Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad
Re: Review Request 36620: Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96144 --- src/linux/cgroups.cpp (lines 1486 - 1487) https://reviews.apache.org/r/36620/#comment151420 How about something along the lines of: The process uses the cgroups freezer component, which works similar to send a STOP signal to the task but without notifying the task about the signal, to stop execution of tasks before atomically kill the tasks in the group. See https://www.kernel.org/doc/Documentation/cgroups/freezer-subsystem.txt src/linux/cgroups.cpp (line 1488) https://reviews.apache.org/r/36620/#comment151421 Not sure about the name of this class, doesn't offer any relevant information: Does it kill freezer tasks, i.e. tasks of type freezer? Doest it kill frozen tasks, i.e. unresponsive tasks? After reading the documentation from the cgroups freezer on realizes that it uses a freezing mechanism to stop the tasks before killinh them, but this is not clear neither from the documentation nor from the name of the class. How about: `CgroupsFreezerTaskKiller` src/linux/cgroups.cpp (line 1642) https://reviews.apache.org/r/36620/#comment151422 weird mix of active and passive voice here. How about: … Failure occurs if any process in the cgroup cannot be killed. src/linux/cgroups.cpp (line 1691) https://reviews.apache.org/r/36620/#comment151425 This is what I meant when I wrote the comment which appears next, it just makes little sense to me to discard a future which already failed, since discard purpose is to signal we are not interested in the result, but if `onFailed` is called, we have the future in a final state already. src/linux/cgroups.cpp (line 1698) https://reviews.apache.org/r/36620/#comment151423 Since there's no control of `processes` being an error (which shouldn't), it makes more sense for the signature of the method to be `FutureNothing kill(setpid_t)`. And let the called to `kill(processes.get())`. It just prevent's someone in the future from making an error and passing a failed `Try` to `kill()`. src/linux/cgroups.cpp (lines 1700 - 1701) https://reviews.apache.org/r/36620/#comment151426 How about: Collect futures to the exit statuses of the processes before sending the kill signal ensures we actually caught all exit statuses. src/linux/cgroups.cpp (line 1708) https://reviews.apache.org/r/36620/#comment151424 This may be a pattern we use, but I think setting a `Future` to `Failure` to send status about the content of the `Future` is wrong. Another common pattern is to return a `TryNothing` or `OptionError`, so the failed future indicates an error with the future mechanics (e.g. the promise when out of scope before setting its value) and the `Try` will pass information about the operation that it performs. src/linux/cgroups.cpp (line 1749) https://reviews.apache.org/r/36620/#comment151428 Do they need to be actual attributes? For example `kill()` could return a `FuturelistFutureOptionint`, and `reap()` could take a `listFutureOptionint` as parameter, then line 1686 will look: ``` chain = kill(processes).then(defer(self(), Self::reap, lambda::_1)); ``` and you don't need statuses to be an attribute nor do you need line 1672. src/linux/cgroups.cpp (line 1750) https://reviews.apache.org/r/36620/#comment151429 Not sure if `chain` needs to be an attribute. The only reason I see is the discard call in `finalize()`. But if it needs to be, I feel the name of the attribute and the documentation are a little bit unfortunate since chain is not a list of reaped processes (their needed of type process, nor pid_t) but it is actually the exit statuses of those processes. Note that you cannot even assign which status came from which process. src/linux/cgroups.cpp (line 1778) https://reviews.apache.org/r/36620/#comment151431 Again the name, without looking anywhere else, if feels as if we where checking for frozen tasks and that were an error. - Alexander Rojas On Aug. 24, 2015, 11:33 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 24, 2015, 11:33 a.m.) Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make
Re: Review Request 36620: Added Non-Freezeer Task Killer.
On Aug. 24, 2015, 3:05 p.m., Alexander Rojas wrote: src/linux/cgroups.cpp, line 1750 https://reviews.apache.org/r/36620/diff/13/?file=1039336#file1039336line1750 Not sure if `chain` needs to be an attribute. The only reason I see is the discard call in `finalize()`. But if it needs to be, I feel the name of the attribute and the documentation are a little bit unfortunate since chain is not a list of reaped processes (their needed of type process, nor pid_t) but it is actually the exit statuses of those processes. Note that you cannot even assign which status came from which process. As discussed we need to be able to access the chain in the finalize call (if interrupted from by external timeout). - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96144 --- On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 24, 2015, 9:33 a.m.) Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad
Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review96166 --- src/linux/perf.cpp (line 418) https://reviews.apache.org/r/37416/#comment151460 This is not expected, right? src/linux/perf.cpp (line 477) https://reviews.apache.org/r/37416/#comment151461 Make it complete, Perf version is not available. - Cong Wang On Aug. 21, 2015, 6:46 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 21, 2015, 6:46 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- Perf supported() should be based on the version of perf, not the version of the kernel. Diffs - src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 Diff: https://reviews.apache.org/r/37416/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 37427: Docker registry: adding TokenManager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 24, 2015, 5:16 p.m.) Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. Changes --- more style changes. Repository: mesos Description --- Changes: - Added Token implementation (RFC 7519). - Added TokenManager implementation. This component keeps a cache of tokens requested for any future requests. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37427/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review96172 --- src/linux/perf.cpp (line 418) https://reviews.apache.org/r/37416/#comment151479 It would be a rare event but not completly unexpected. After all, perf can be upgraded while mesos is running. - Paul Brett On Aug. 21, 2015, 6:46 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 21, 2015, 6:46 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- Perf supported() should be based on the version of perf, not the version of the kernel. Diffs - src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 Diff: https://reviews.apache.org/r/37416/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 37722: Added definitions of container rootfs directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/ --- (Updated Aug. 24, 2015, 11:26 a.m.) Review request for mesos, Lily Chen, Chi Zhang, Jie Yu, and Timothy Chen. Changes --- Minor fix. Bugs: MESOS-3308 https://issues.apache.org/jira/browse/MESOS-3308 Repository: mesos Description --- More context in /r/37382/ and MESOS-3308. I will add the appc backend + provisioner implementation shortly but would like to seek feedback about this design early. Diffs (updated) - src/slave/containerizer/provisioners/appc/paths.hpp e35805179e67770c6eff7406668caecabefe4fea src/slave/containerizer/provisioners/appc/paths.cpp a244d9a40e7143134b7bf883514bfcd04d6a6af5 src/slave/paths.hpp dbb1f68d8a789303b595d9e455e2f6f1f0de5c5b src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 Diff: https://reviews.apache.org/r/37722/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 24, 2015, 11:26 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes --- Added Resources list back to InverseOffer. Added to comment about InverseOffer Unavailability, noting the expectations of resources after unavailability. Bugs: MESOS-2061 and MESOS-2066 https://issues.apache.org/jira/browse/MESOS-2061 https://issues.apache.org/jira/browse/MESOS-2066 Repository: mesos Description --- MESOS-2061: Add Unavailability and InverseOffer protobufs declarations. MESOS-2066: Add the Unavailability field to Offers. No integration with other components (that part is tracked in separate JIRAs, see MESOS-1474). Diffs (updated) - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 Diff: https://reviews.apache.org/r/36321/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.
On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote: src/linux/perf.cpp, line 418 https://reviews.apache.org/r/37416/diff/5/?file=1045148#file1045148line418 This is not expected, right? Paul Brett wrote: It would be a rare event but not completly unexpected. After all, perf can be upgraded while mesos is running. I meant your s/is/it/ change is not expected... - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review96166 --- On Aug. 21, 2015, 6:46 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 21, 2015, 6:46 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- Perf supported() should be based on the version of perf, not the version of the kernel. Diffs - src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 Diff: https://reviews.apache.org/r/37416/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.
On Aug. 21, 2015, 11:35 a.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 917-920 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line917 I think the name `Unavailability` is too specific to maintenance, how about something more generic, like `Period`? I'm thinking about a use case, when a custom allocator uses InverseOffers to ask a framework to release resources. In this case, we need a timeout, which is naturally expressed by `unavailability.start`. Given we don't need duration in this case, the name can be misleading for users. Joseph Wu wrote: A while ago, I posted a few diffs where this object was called `Interval` (https://reviews.apache.org/r/36321/diff/7/). The reason why it was changed back to `Unavailability` is that we may wish to extend this object to be more specific, in the future. (We've already removed all the maintenance-specific language in the comments for `Unavailability` and `InverseOffer`.) Taking your example, the custom allocator asks for resources back. It says that these will be unavailable by the `start` time. Duration is optional; in the case of maintenance, when `duration` is omitted, it means the duration is forever or unknown. I think the term also works for non-maintenance uses. Alexander Rukletsov wrote: For me unavailability implies the resources will be given back once the period (interval) is over. Unless resource are reserved, this is not the case, since allocator has no obligations to offer resources to prior users once unavailability period is over. In an offline conversation, Joris pointed out, that unavailability events are mostly interesting for stateful frameworks, which most probably will have reservations for resources. If you plan to leave current term, could you please reflect in the comment what unavailability guarantees and what it does not? Updated the comments. Let me know what you think. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96073 --- On Aug. 24, 2015, 11:26 a.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 24, 2015, 11:26 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Bugs: MESOS-2061 and MESOS-2066 https://issues.apache.org/jira/browse/MESOS-2061 https://issues.apache.org/jira/browse/MESOS-2066 Repository: mesos Description --- MESOS-2061: Add Unavailability and InverseOffer protobufs declarations. MESOS-2066: Add the Unavailability field to Offers. No integration with other components (that part is tracked in separate JIRAs, see MESOS-1474). Diffs - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 Diff: https://reviews.apache.org/r/36321/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop
On June 15, 2015, 12:07 p.m., Niklas Nielsen wrote: Hey Robert; BenH helped out and wrote a PoC patch here https://reviews.apache.org/r/35405 In short; it is not safe to delete the detector at this point. The patch above does it in join() and has a good descriptive block of comment explaining the issue. What we need to do is try it out and test it. We are working on another approach, suggested by BenH. Do you want to close this RR and continue in the other one? - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33208/#review87958 --- On April 14, 2015, 10:23 p.m., Robert Lacroix wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33208/ --- (Updated April 14, 2015, 10:23 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone. Bugs: MESOS-1634 https://issues.apache.org/jira/browse/MESOS-1634 Repository: mesos Description --- When the Mesos Scheduler Driver stops, it does not delete the detector process before the object is garbage collected, which leaves ZooKeeper connections hanging around unnecessarily. This deletes the process on stop as well, not only on destruction. Diffs - src/sched/sched.cpp 66fd2b3146568900356cc48e0f17c6720665ae80 Diff: https://reviews.apache.org/r/33208/diff/ Testing --- make check, manual testing Thanks, Robert Lacroix
Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review96168 --- src/tests/containerizer/perf_tests.cpp (line 52) https://reviews.apache.org/r/37466/#comment151466 I think this should still be in perf.hpp even though it is just for testing. - Cong Wang On Aug. 21, 2015, 4:06 a.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Aug. 21, 2015, 4:06 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2834 https://issues.apache.org/jira/browse/MESOS-2834 Repository: mesos Description --- Update perf tests to including testing the supported perf output formats. Diffs - src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett
Review Request 37722: Added definitions of container rootfs directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/ --- Review request for mesos, Lily Chen, Chi Zhang, Jie Yu, and Timothy Chen. Bugs: MESOS-3308 https://issues.apache.org/jira/browse/MESOS-3308 Repository: mesos Description --- More context in /r/37382/ and MESOS-3308. I will add the appc backend + provisioner implementation shortly but would like to seek feedback about this design early. Diffs - src/slave/containerizer/provisioners/appc/paths.hpp e35805179e67770c6eff7406668caecabefe4fea src/slave/containerizer/provisioners/appc/paths.cpp a244d9a40e7143134b7bf883514bfcd04d6a6af5 src/slave/paths.hpp dbb1f68d8a789303b595d9e455e2f6f1f0de5c5b src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 Diff: https://reviews.apache.org/r/37722/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/#review96170 --- Ship it! LGTM, sorry for the long turn around time on this review - a few style nits in the make file, but otherwise good to go. src/Makefile.am (line 476) https://reviews.apache.org/r/37479/#comment151475 Is the indentation of the '\' right here? Set tabstop to 8 and use hard tabs. Also, is this sorted correctly? src/Makefile.am (line 754) https://reviews.apache.org/r/37479/#comment151476 Same comments as above - Niklas Nielsen On Aug. 14, 2015, 6:44 p.m., Guangya Liu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated Aug. 14, 2015, 6:44 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.
On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote: src/linux/perf.cpp, line 418 https://reviews.apache.org/r/37416/diff/5/?file=1045148#file1045148line418 This is not expected, right? It would be a rare event but not completly unexpected. After all, perf can be upgraded while mesos is running. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review96166 --- On Aug. 21, 2015, 6:46 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 21, 2015, 6:46 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- Perf supported() should be based on the version of perf, not the version of the kernel. Diffs - src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 Diff: https://reviews.apache.org/r/37416/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 34361: converted hard-coded strings to consts
On June 9, 2015, 6:25 p.m., Ben Mahler wrote: src/tests/master_tests.cpp, lines 3031-3034 https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031 Why bother with all this? Why not just have `key1`, `value1`, `key2`, `value2` inlined appropriately throughout these tests. Very straightforward to read. Colin Williams wrote: I think the issue with the changes remaining is that the test depends on the same value occurring in several places. By consolidating to a variable it's no longer possible for these values to get out of sync. Niklas Nielsen wrote: Colin: exactly Ben: We have label tests three places; in the master, slave and in the modules and they use the same foo, bar, baz, qux key value pairs. The idea was to centralize them, so they don't get out of date and to avoid code duplication. Does that make sense? Ben Mahler wrote: Well, then let's just keep it simple and get rid of these special strings by just making the tests use key1, value1, key2, value2, etc. I'm not following your code duplication point, this introduces more code (now there are additional global constants, which we like to avoid if unnecessary). Also, each test is ideally independent, why does the master's test for labels affect the slave's test for labels? Let's say I need a test with 5 labels, you want to have 5x2=10 global constants to address this? Niklas Nielsen wrote: Try to see how testLabelKey and testLabelValue was used previously and foo, bar, qux was used on others and I created this ticket to unify the way we do this, along with seeing these key value pair being created in the slave and master tests. Dispite the current patch, I do think we can simply and unify the test label creation. Maybe create a CREATE_LABEL_PAIR(id) to make it more obvious which key pairs are being tested. The comments in the test code need to carry a bunch of context, to make sense out of the label transformations (especially across the library border for the hooks tests). This is all in spirit of reducing the tech debt we introduced. We are on the same page on not introducing more lines/key pairs than before. Let us iterate on this and get back to you. Colin Williams wrote: Ben: I'm more in agreement with your sentiment, I'm not sure I see the point of unifying label names into a centralized variable that aren't at all related. Niklas: I was a little confused by the original task description, so I thought a sample patch would be a good discussion point. I don't entirely understand the tech debt you're trying to solve. For example, it seems like you're asking to have some constants defined somewhere that are used by both master_test and slave_test, but the the similarities between these two only seem incidental. I'm concerned that creating something like CREATE_LABEL_PAIR(id) would instead obfuscate the intent of the code. Niklas Nielsen wrote: Okay - thinking about this; I am on board with key1, value1 etc. Colin: the tech debt is that we have some inlined constants (like foo, bar, etc) and some which are constants (which have to be kept in sync between hooks modules and test body). The idea was to unify the way we name the key value pairs. Do you want to update this ticket to reflect this, or come with a new patch set which tackles streaming the two? Niklas Nielsen wrote: Ping :) Colin Williams wrote: Sorry, my day job's been really all-consuming the last few days. I was planning to update the ticket. Colin Williams wrote: Ticket updated Niklas Nielsen wrote: Colin; thanks! should we keep this patch then, or will you be providing a new one? Colin Williams wrote: I'm not planning on providing a new one. Sorry for the long turn around time, Colin! To BenM's point; let's just rename to key1,value1 consistently instead of just hoisting the constants inline. Would you be up for doing this? We can land that immediately. - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review87331 --- On June 8, 2015, 12:05 p.m., Colin Williams wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/ --- (Updated June 8, 2015, 12:05 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2637 https://issues.apache.org/jira/browse/MESOS-2637 Repository: mesos Description --- converted hard-coded strings to consts Diffs - src/tests/hook_tests.cpp 3ffde6d
Re: Review Request 35405: Enable deleting MasterDetector in MesosSchedulerDriver::join.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35405/#review96176 --- Robert; did you still run into problems with the current patch? If so, let's close this for now and rethink the approach. If not, let's see if we can verify it (think a test if hard, but maybe we can come up with something). - Niklas Nielsen On Aug. 24, 2015, 11:25 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35405/ --- (Updated Aug. 24, 2015, 11:25 a.m.) Review request for mesos, Niklas Nielsen and Robert Lacroix. Repository: mesos Description --- This is a proof of concept to help folks out in https://reviews.apache.org/r/33208. Diffs - src/sched/sched.cpp bc76c71ae9d44b291049223366e38cb0fd0c src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 Diff: https://reviews.apache.org/r/35405/diff/ Testing --- NOT YET Thanks, Benjamin Hindman
Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 24, 2015, 11:33 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes --- Rebase and update diff. No other changes. Bugs: MESOS-3066 https://issues.apache.org/jira/browse/MESOS-3066 Repository: mesos Description --- * MachineInfo - Describes a single box that holds one or more agents. * MachineInfos - A list of boxes. * maintenance::Window - A set of machines and a planned downtime period. * maintenance::Schedule - A set of maintenance windows. * maintenance::Mode - An enum for the three states of maintenance: Normal, Draining, Deactivated. * Registry::MaintenanceStatus - Holds the maintenance mode of a machine. Diffs (updated) - include/mesos/maintenance/maintenance.hpp PRE-CREATION include/mesos/maintenance/maintenance.proto PRE-CREATION include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 Diff: https://reviews.apache.org/r/36571/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into Normal mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37362/ --- (Updated Aug. 24, 2015, 12:08 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes --- Rebased and updated diff. No other changes. Bugs: MESOS-2067 and MESOS-3069 https://issues.apache.org/jira/browse/MESOS-2067 https://issues.apache.org/jira/browse/MESOS-3069 Repository: mesos Description --- Endpoint: /maintenance.stop Registry operation = maintenance::StopMaintenance Sets the list of machines back to Normal mode. Removes those machines from the maintenance schedule. Diffs (updated) - src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 src/master/maintenance.hpp PRE-CREATION src/master/maintenance.cpp PRE-CREATION src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/tests/master_maintenance_tests.cpp PRE-CREATION src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 Diff: https://reviews.apache.org/r/37362/diff/ Testing --- `make check` New Tests: RegistrarTest.StopMaintenance Schedules some machines. Deactivates some. Reactivates some. MasterMaintenanceTest.ReactivateMachines Tests some invalid lists. Schedules some machines. Deactivates some. Tests some valid and invalid lists. Checks that the schedule is modified. Thanks, Joseph Wu
Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/ --- (Updated Aug. 24, 2015, 11:48 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes --- Rebased and updated diff. No other changes. Bugs: MESOS-2067 and MESOS-3069 https://issues.apache.org/jira/browse/MESOS-2067 https://issues.apache.org/jira/browse/MESOS-3069 Repository: mesos Description --- Endpoint: /maintenance.schedule Registry operation = maintenance::UpdateSchedule Replaces the schedule with the given one. Also sets all scheduled machines into Draining mode. Other changes: Added a note about the strict flag. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 src/master/maintenance.hpp PRE-CREATION src/master/maintenance.cpp PRE-CREATION src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/master/registrar.hpp c6a0655c212646618d93c9c85918af482a9ffd50 src/tests/maintenance.hpp PRE-CREATION src/tests/master_maintenance_tests.cpp PRE-CREATION src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 Diff: https://reviews.apache.org/r/37325/diff/ Testing --- `make check` New Tests: RegistrarTest.UpdateMaintenanceSchedule Schedules 3 machines, 1 at a time. Rearranges schedules. Checks that machines are put into Draining mode. Removes machines. MasterMaintenanceTest.UpdateSchedule Hits the new endpoint with some valid and invalid schedules. Only tests a subset of invalid schedules (requires other endpoints to fully test). Thanks, Joseph Wu
Re: Review Request 37364: Maintenance Primitives: Adds an endpoint for retrieving the maintenance status for machines.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37364/
---
(Updated Aug. 24, 2015, 12:09 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan,
Joris Van Remoortere, and Vinod Kone.
Changes
---
Rebased and updated diff. No other changes.
Bugs: MESOS-2067
https://issues.apache.org/jira/browse/MESOS-2067
Repository: mesos
Description (updated)
---
Endpoint: /maintenance.status
Returns a JSON object like:
```
{
draining: [
{ hostname: foo, ip: 0.0.0.1 },
{ hostname: bar, ip: 0.0.0.2 },
],
deactivated: [
{ hostname: baz, ip: 0.0.0.3 },
]
}
```
Diffs (updated)
-
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37364/diff/
Testing
---
`make check`
New Tests:
MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines
Extra test case for the /maintenance.schedule endpoint, which requires all
three endpoints to work.
MasterMaintenanceTest.MachineStatus
Schedules, starts, and stops maintenance. Checks machine statuses after
each step.
Thanks,
Joseph Wu
Re: Review Request 37197: Docker image store.
On Aug. 19, 2015, 6:11 a.m., Timothy Chen wrote: src/slave/containerizer/provisioners/docker/store.cpp, line 1 https://reviews.apache.org/r/37197/diff/6/?file=1041380#file1041380line1 Btw this is actually renamed to be local store later right? How about just remove the impl completely in this review so later review we introduce the local store? Squashed commit that moves store implementation to LocalStore into this commit. - Lily --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review95830 --- On Aug. 19, 2015, 6:41 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 19, 2015, 6:41 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Stored images currently kept indefinitely. Diffs - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 Diff: https://reviews.apache.org/r/37197/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.
On Aug. 12, 2015, 10:31 a.m., Joseph Wu wrote: src/master/maintenance.cpp, lines 126-130 https://reviews.apache.org/r/37325/diff/2/?file=1037747#file1037747line126 Note: Considering the machine field in the master's local state (https://reviews.apache.org/r/37170/diff/2#0.8), it may be helpful/necessary to fill in the hostname/ip for some machines before doing this check. For now, we'll document that Machine(A,B) != Machine(A), even if A resolves to B. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/#review95125 --- On Aug. 24, 2015, 11:48 a.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/ --- (Updated Aug. 24, 2015, 11:48 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Bugs: MESOS-2067 and MESOS-3069 https://issues.apache.org/jira/browse/MESOS-2067 https://issues.apache.org/jira/browse/MESOS-3069 Repository: mesos Description --- Endpoint: /maintenance.schedule Registry operation = maintenance::UpdateSchedule Replaces the schedule with the given one. Also sets all scheduled machines into Draining mode. Other changes: Added a note about the strict flag. Diffs - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 src/master/maintenance.hpp PRE-CREATION src/master/maintenance.cpp PRE-CREATION src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/master/registrar.hpp c6a0655c212646618d93c9c85918af482a9ffd50 src/tests/maintenance.hpp PRE-CREATION src/tests/master_maintenance_tests.cpp PRE-CREATION src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 Diff: https://reviews.apache.org/r/37325/diff/ Testing --- `make check` New Tests: RegistrarTest.UpdateMaintenanceSchedule Schedules 3 machines, 1 at a time. Rearranges schedules. Checks that machines are put into Draining mode. Removes machines. MasterMaintenanceTest.UpdateSchedule Hits the new endpoint with some valid and invalid schedules. Only tests a subset of invalid schedules (requires other endpoints to fully test). Thanks, Joseph Wu
Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/ --- (Updated Aug. 24, 2015, 11:54 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes --- Rebased and updated diff. No other changes. Bugs: MESOS-2067 and MESOS-3069 https://issues.apache.org/jira/browse/MESOS-2067 https://issues.apache.org/jira/browse/MESOS-3069 Repository: mesos Description --- Endpoint: /maintenance.start Registry operation = maintenance::StartMaintenance Sets the list of machines as Deactivated. Diffs (updated) - src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 src/master/maintenance.hpp PRE-CREATION src/master/maintenance.cpp PRE-CREATION src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/tests/master_maintenance_tests.cpp PRE-CREATION src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 Diff: https://reviews.apache.org/r/37358/diff/ Testing --- `make check` New Tests: RegistrarTest.StartMaintenance Schedules some machines. Deactivates some. MasterMaintenanceTest.StartMaintenance Tests some invalid lists. Schedules some machines. Tests some valid and invalid lists. Thanks, Joseph Wu
Re: Review Request 37268: Style checker checking for { on newline
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96138
---
Ship it!
Ship It!
- Guangya Liu
On 八月 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
---
(Updated 八月 12, 2015, 1:15 a.m.)
Review request for mesos.
Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578
Repository: mesos
Description
---
As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp
30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
---
Thanks,
Jose Guilherme Vanz
Re: Review Request 37540: Add PerfEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Aug. 24, 2015, 9:31 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Changes --- Cleanup Bugs: MESOS-2769 https://issues.apache.org/jira/browse/MESOS-2769 Repository: mesos Description --- Abstract Linux kernel perf event API and provide API to collect schedule events. Diffs (updated) - src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37540/diff/ Testing --- make check Thanks, Cong Wang
Review Request 37726: Added support for preparing images specified in volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-3310 https://issues.apache.org/jira/browse/MESOS-3310 Repository: mesos Description --- Added support for preparing images specified in volumes. Diffs - src/slave/containerizer/isolators/filesystem/linux.hpp ee5b33d14208770b474e0cb4ab4422381ceb8a3c src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612 src/tests/containerizer/filesystem_isolator_tests.cpp 7003b03f1da2fee53592bc23799f59eabcd913a2 Diff: https://reviews.apache.org/r/37726/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 24, 2015, 2:14 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes --- Add a sentence under Scheduling Maintenance - Important Note; to describe what happens when a machine has multiple IPs/hostnames. Bugs: MESOS-2083 https://issues.apache.org/jira/browse/MESOS-2083 Repository: mesos Description --- Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/). Includes a diagram of the maintenance mode transitions. This documents the current working prototype (MVP), which starts here: https://reviews.apache.org/r/36321/ One TODO remaining: Update with the release version that maintenance primitives will be released in. Diffs (updated) - docs/images/maintenance-primitives-modes.png PRE-CREATION docs/maintenance.md PRE-CREATION Diff: https://reviews.apache.org/r/37585/diff/ Testing --- Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2 Checked for markdown correctness. Thanks, Joseph Wu
Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/ --- (Updated Aug. 24, 2015, 11:43 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes --- Rebased and updated diff. No other changes. Bugs: MESOS-3045 https://issues.apache.org/jira/browse/MESOS-3045 Repository: mesos Description --- Note: Tests will be added with the related HTTP endpoints and registrar operations, later in this review chain. Diffs (updated) - include/mesos/maintenance/maintenance.hpp PRE-CREATION include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf Diff: https://reviews.apache.org/r/37314/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37268: Style checker checking for { on newline
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96194
---
Ship it!
Ship It!
- Jose Guilherme Vanz
On Aug. 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
---
(Updated Aug. 12, 2015, 1:15 a.m.)
Review request for mesos.
Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578
Repository: mesos
Description
---
As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp
30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
---
Thanks,
Jose Guilherme Vanz
Re: Review Request 37268: Style checker checking for { on newline
On Aug. 24, 2015, 8:34 p.m., Jose Guilherme Vanz wrote:
Ship It!
Jose Guilherme Vanz wrote:
Ops... sorry.
My Ship it is not valid. I'm the author... sorry
- Jose Guilherme
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96194
---
On Aug. 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
---
(Updated Aug. 12, 2015, 1:15 a.m.)
Review request for mesos.
Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578
Repository: mesos
Description
---
As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp
30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
---
Thanks,
Jose Guilherme Vanz
Re: Review Request 37268: Style checker checking for { on newline
On Aug. 24, 2015, 8:34 p.m., Jose Guilherme Vanz wrote:
Ship It!
Ops... sorry.
- Jose Guilherme
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96194
---
On Aug. 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
---
(Updated Aug. 12, 2015, 1:15 a.m.)
Review request for mesos.
Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578
Repository: mesos
Description
---
As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp
30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
---
Thanks,
Jose Guilherme Vanz
Review Request 37729: Remove extraneous IsolatorProcess declaration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37729/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and Kapil Arya. Repository: mesos Description --- Some refactoring in https://reviews.apache.org/r/36763 missed these lines. Diffs - include/mesos/slave/isolator.hpp 970730f0ffc7f3359685ccf81452856bea1c4a06 Diff: https://reviews.apache.org/r/37729/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37729: Remove extraneous IsolatorProcess declaration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37729/#review96215 --- Ship it! Ship It! - Jie Yu On Aug. 24, 2015, 9:09 p.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37729/ --- (Updated Aug. 24, 2015, 9:09 p.m.) Review request for mesos, Jie Yu, Joris Van Remoortere, and Kapil Arya. Repository: mesos Description --- Some refactoring in https://reviews.apache.org/r/36763 missed these lines. Diffs - include/mesos/slave/isolator.hpp 970730f0ffc7f3359685ccf81452856bea1c4a06 Diff: https://reviews.apache.org/r/37729/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37101: Remove unused sched API's
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/ --- (Updated Aug. 24, 2015, 9:30 p.m.) Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone. Changes --- Rebase Repository: mesos Description --- We don't use SCHED_IDLE any more. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1 src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8 Diff: https://reviews.apache.org/r/37101/diff/ Testing --- make Thanks, Cong Wang
Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/ --- (Updated Aug. 24, 2015, 9:54 p.m.) Review request for mesos, Cody Maloney and Timothy St. Clair. Bugs: MESOS-2537 https://issues.apache.org/jira/browse/MESOS-2537 Repository: mesos Description --- In a number of places, the Mesos configure script passes $foo=yes to the 2nd argument of AC_ARG_ENABLED. However, the 2nd argument is invoked when the option is provided in any form, not just when the --enable-foo form is used. One result of this is that --disable-optimize doesn't work. The correct handling of the 2nd argument is to save the value of $enableval. This change sets the value of all the enable variables using $enableval, and sets the default value based on the option name. There are a number of enable options that were internally named $with_foo and $without_foo. Rename these to $enable_foo for clarity and to remove the need for both a with_ and a without_ version. Finally, emit the compilation flags at the end of the configure phase so it is easier to see the results of your configuration options. Diffs (updated) - configure.ac db0632d60a6d82ab396931b4d913f34b625a45a7 Diff: https://reviews.apache.org/r/33752/diff/ Testing --- Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify that the status summary reflects the expected compiler flags. Verify that --enable-foo and --disable-foo do different things. Thanks, James Peach
Re: Review Request 37729: Remove extraneous IsolatorProcess declaration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37729/#review96214 --- Ship it! Ship It! - Kapil Arya On Aug. 24, 2015, 5:09 p.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37729/ --- (Updated Aug. 24, 2015, 5:09 p.m.) Review request for mesos, Jie Yu, Joris Van Remoortere, and Kapil Arya. Repository: mesos Description --- Some refactoring in https://reviews.apache.org/r/36763 missed these lines. Diffs - include/mesos/slave/isolator.hpp 970730f0ffc7f3359685ccf81452856bea1c4a06 Diff: https://reviews.apache.org/r/37729/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review96218 --- Patch looks great! Reviews applied: [36127] All tests passed. - Mesos ReviewBot On Aug. 23, 2015, 5:45 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Aug. 23, 2015, 5:45 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs - docs/configuration.md 2b23d48 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp a94a5ee src/master/flags.cpp 230c1dc src/slave/flags.cpp b36710d src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 37541: Add TraceEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 24, 2015, 9:32 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Changes --- Cleanup Bugs: MESOS-2769 https://issues.apache.org/jira/browse/MESOS-2769 Repository: mesos Description --- Based on the PerfEvent API's, add API for Linux kernel trace events, especially the schedule trace events. Diffs (updated) - src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37541/diff/ Testing --- make check Thanks, Cong Wang
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review96244 --- Ship it! Ship It! include/mesos/mesos.proto (line 98) https://reviews.apache.org/r/37655/#comment151584 Can you expand the comment to make it clean that nanoseconds is the remainder, not a more precise representation of the full amount of time. - Joris Van Remoortere On Aug. 20, 2015, 5:03 p.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/ --- (Updated Aug. 20, 2015, 5:03 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Bugs: MESOS-3299 https://issues.apache.org/jira/browse/MESOS-3299 Repository: mesos Description --- Instead of using doubles, seconds and nanoseconds can be represented like `struct timespec`, with one field for seconds and one for nanoseconds. This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives). Note about the naming: * Time will conflict with the Time class. * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration. Diffs - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 Diff: https://reviews.apache.org/r/37655/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37722: Added definitions of container rootfs directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/#review96252 --- The slave provisioners path LGTM! src/slave/containerizer/provisioners/appc/paths.hpp (line 55) https://reviews.apache.org/r/37722/#comment151586 Suggestion: It might make sense to nest one more directory rootfs so you can add metadata about that rootfs besides it, also allow more flexibility in the long run. - Timothy Chen On Aug. 24, 2015, 6:26 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/ --- (Updated Aug. 24, 2015, 6:26 p.m.) Review request for mesos, Lily Chen, Chi Zhang, Jie Yu, and Timothy Chen. Bugs: MESOS-3308 https://issues.apache.org/jira/browse/MESOS-3308 Repository: mesos Description --- More context in /r/37382/ and MESOS-3308. I will add the appc backend + provisioner implementation shortly but would like to seek feedback about this design early. Diffs - src/slave/containerizer/provisioners/appc/paths.hpp e35805179e67770c6eff7406668caecabefe4fea src/slave/containerizer/provisioners/appc/paths.cpp a244d9a40e7143134b7bf883514bfcd04d6a6af5 src/slave/paths.hpp dbb1f68d8a789303b595d9e455e2f6f1f0de5c5b src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 Diff: https://reviews.apache.org/r/37722/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review96251 --- Bad patch! Reviews applied: [37585] Failed command: ./support/apply-review.sh -n -r 37585 Error: 2015-08-25 00:20:09 URL:https://reviews.apache.org/r/37585/diff/raw/ [12769/12769] - 37585.patch [1] error: missing binary patch data for 'docs/images/maintenance-primitives-modes.png' error: binary patch does not apply to 'docs/images/maintenance-primitives-modes.png' error: docs/images/maintenance-primitives-modes.png: patch does not apply Failed to apply patch - Mesos ReviewBot On Aug. 24, 2015, 9:14 p.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 24, 2015, 9:14 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Bugs: MESOS-2083 https://issues.apache.org/jira/browse/MESOS-2083 Repository: mesos Description --- Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/). Includes a diagram of the maintenance mode transitions. This documents the current working prototype (MVP), which starts here: https://reviews.apache.org/r/36321/ One TODO remaining: Update with the release version that maintenance primitives will be released in. Diffs - docs/images/maintenance-primitives-modes.png PRE-CREATION docs/maintenance.md PRE-CREATION Diff: https://reviews.apache.org/r/37585/diff/ Testing --- Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2 Checked for markdown correctness. Thanks, Joseph Wu
Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated Aug. 25, 2015, 1:28 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs (updated) - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
Re: Review Request 37501: Add support for removing capabilities.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37501/#review96232 --- Ship it! Ship It! - Vinod Kone On Aug. 15, 2015, 4:35 p.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37501/ --- (Updated Aug. 15, 2015, 4:35 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3258 https://issues.apache.org/jira/browse/MESOS-3258 Repository: mesos Description --- The allocator automatically assumes non-revocable resources whenever a framework registers or re-registers, unless it is defined in the FrameworkInfo. Diffs - src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/tests/oversubscription_tests.cpp d41f030c1bc259c86dab0d268d2f36ce410cd505 Diff: https://reviews.apache.org/r/37501/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 37427: Docker registry: adding TokenManager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review96233 --- Patch looks great! Reviews applied: [37426, 37427] All tests passed. - Mesos ReviewBot On Aug. 24, 2015, 5:16 p.m., Jojy Varghese wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 24, 2015, 5:16 p.m.) Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. Repository: mesos Description --- Changes: - Added Token implementation (RFC 7519). - Added TokenManager implementation. This component keeps a cache of tokens requested for any future requests. Diffs - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37427/diff/ Testing --- make check. Thanks, Jojy Varghese
Review Request 37738: Added a filesystem isolator test to test image in volume while the container root filesystem is also specified.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37738/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Repository: mesos Description --- Added a filesystem isolator test to test image in volume while the container root filesystem is also specified. Diffs - src/tests/containerizer/filesystem_isolator_tests.cpp 7003b03f1da2fee53592bc23799f59eabcd913a2 Diff: https://reviews.apache.org/r/37738/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96240 --- This review is a bit hard to follow because it's doing multiple things. I would recommend you to split this into multiple reviews #1) Expose framework user in state.json #2) Update framework user on re-registration (need a test for this!) src/master/master.hpp https://reviews.apache.org/r/37500/#comment151577 So you are not updating the 'info.user' at all? How come? src/master/master.cpp (lines 1879 - 1886) https://reviews.apache.org/r/37500/#comment151579 Per the design doc, we don't need a new message. You should be able to augment the existing UpdateFrameworkMessage to include FrameworkInfo. Any particular reason you introduced a new one? src/slave/slave.cpp (lines 446 - 450) https://reviews.apache.org/r/37500/#comment151581 no need for this if you just use the existing handler for update framework message. src/tests/master_tests.cpp (line 2973) https://reviews.apache.org/r/37500/#comment151582 s/FrameworkWebUIUrlCapabilitiesAndUser/FrameworkState/ - Vinod Kone On Aug. 15, 2015, 8:03 a.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 15, 2015, 8:03 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3240 https://issues.apache.org/jira/browse/MESOS-3240 Repository: mesos Description --- Added user to master's state, slave's state (not exposed) and updated user in all slaves that have the registered framework. Added the test too. Diffs - src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9 src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 Diff: https://reviews.apache.org/r/37500/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 37197: Docker image store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 25, 2015, 1:31 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. Changes --- Addressed comment on log message. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Stored images currently kept indefinitely. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 Diff: https://reviews.apache.org/r/37197/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/ --- (Updated Aug. 24, 2015, 5:14 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes --- Update comments. Copy to V1 API too. Bugs: MESOS-3299 https://issues.apache.org/jira/browse/MESOS-3299 Repository: mesos Description --- Instead of using doubles, seconds and nanoseconds can be represented like `struct timespec`, with one field for seconds and one for nanoseconds. This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives). Note about the naming: * Time will conflict with the Time class. * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration. Diffs (updated) - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 Diff: https://reviews.apache.org/r/37655/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37101: Remove unused sched API's
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/#review96263 --- Patch looks great! Reviews applied: [36410, 36411, 36412, 36413, 37101] All tests passed. - Mesos ReviewBot On Aug. 24, 2015, 9:30 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/ --- (Updated Aug. 24, 2015, 9:30 p.m.) Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone. Repository: mesos Description --- We don't use SCHED_IDLE any more. Diffs - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1 src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8 Diff: https://reviews.apache.org/r/37101/diff/ Testing --- make Thanks, Cong Wang
Re: Review Request 37198: Add Docker image provisioner and copy backend.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 25, 2015, 1:32 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Changes --- Moved validation of images to process. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Add Docker image provisioner and copy backend. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612 src/slave/containerizer/provisioner.hpp 541dd4e0b2f0c92a45c00cab6132a2be69654838 src/slave/containerizer/provisioner.cpp efc7e6996ff6663bebaf61989a7e040bd2ad7a5e src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 src/tests/containerizer/provisioner.hpp c4ba46794fe5d7875fda11155367f521c34ea339 Diff: https://reviews.apache.org/r/37198/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37247: Added Docker image reference store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 25, 2015, 1:33 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3021 https://issues.apache.org/jira/browse/MESOS-3021 Repository: mesos Description --- Added Docker image reference store. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/messages/docker_provisioner.hpp PRE-CREATION src/messages/docker_provisioner.proto PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37247/diff/ Testing --- make check Tests will be added in a later review. Thanks, Lily Chen
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review96269 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 12:14 a.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/ --- (Updated Aug. 25, 2015, 12:14 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Bugs: MESOS-3299 https://issues.apache.org/jira/browse/MESOS-3299 Repository: mesos Description --- Instead of using doubles, seconds and nanoseconds can be represented like `struct timespec`, with one field for seconds and one for nanoseconds. This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives). Note about the naming: * Time will conflict with the Time class. * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration. Diffs - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 Diff: https://reviews.apache.org/r/37655/diff/ Testing --- `make check` Thanks, Joseph Wu
Review Request 37735: Refactored filesystem isolator tests to allow multiple rootfses.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37735/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Repository: mesos Description --- Refactored filesystem isolator tests to allow multiple rootfses. Diffs - src/tests/containerizer/filesystem_isolator_tests.cpp 7003b03f1da2fee53592bc23799f59eabcd913a2 src/tests/containerizer/provisioner.hpp c4ba46794fe5d7875fda11155367f521c34ea339 Diff: https://reviews.apache.org/r/37735/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37722: Added definitions of container rootfs directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/#review96246 --- Patch looks great! Reviews applied: [37722] All tests passed. - Mesos ReviewBot On Aug. 24, 2015, 6:26 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/ --- (Updated Aug. 24, 2015, 6:26 p.m.) Review request for mesos, Lily Chen, Chi Zhang, Jie Yu, and Timothy Chen. Bugs: MESOS-3308 https://issues.apache.org/jira/browse/MESOS-3308 Repository: mesos Description --- More context in /r/37382/ and MESOS-3308. I will add the appc backend + provisioner implementation shortly but would like to seek feedback about this design early. Diffs - src/slave/containerizer/provisioners/appc/paths.hpp e35805179e67770c6eff7406668caecabefe4fea src/slave/containerizer/provisioners/appc/paths.cpp a244d9a40e7143134b7bf883514bfcd04d6a6af5 src/slave/paths.hpp dbb1f68d8a789303b595d9e455e2f6f1f0de5c5b src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 Diff: https://reviews.apache.org/r/37722/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 37726: Added support for preparing images specified in volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/#review96254 --- src/tests/containerizer/filesystem_isolator_tests.cpp (line 485) https://reviews.apache.org/r/37726/#comment151588 How about trying multiple rootfs in the same container? - Timothy Chen On Aug. 24, 2015, 7:49 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/ --- (Updated Aug. 24, 2015, 7:49 p.m.) Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-3310 https://issues.apache.org/jira/browse/MESOS-3310 Repository: mesos Description --- Added support for preparing images specified in volumes. Diffs - src/slave/containerizer/isolators/filesystem/linux.hpp ee5b33d14208770b474e0cb4ab4422381ceb8a3c src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612 src/tests/containerizer/filesystem_isolator_tests.cpp 7003b03f1da2fee53592bc23799f59eabcd913a2 Diff: https://reviews.apache.org/r/37726/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/#review96265 --- include/mesos/scheduler/scheduler.proto (line 70) https://reviews.apache.org/r/37178/#comment151604 I think that the comments also needs to be updated to reflect inverse offer. include/mesos/v1/scheduler/scheduler.proto (line 70) https://reviews.apache.org/r/37178/#comment151605 ditto - Guangya Liu On 八月 18, 2015, 7:02 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/ --- (Updated 八月 18, 2015, 7:02 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs - include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 include/mesos/v1/scheduler/scheduler.proto bd5e82a614b1163b29f9b20e562208efa1ba4b55 Diff: https://reviews.apache.org/r/37178/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.
On Aug. 18, 2015, 9:33 p.m., Joseph Wu wrote: src/master/master.hpp, line 478 https://reviews.apache.org/r/37175/diff/3/?file=1043316#file1043316line478 Why is this return type `Nothing`, instead of `void`? It was `Nothing` as I was calling this function from the tests before. It needed to be `Nothing` for `dispatch` to work as `Futurevoid` is invalid. This is no longer necessary due to your helper functions. - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review95783 --- On Aug. 18, 2015, 6:57 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Aug. 18, 2015, 6:57 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs - include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/tests/master_maintenance_tests.cpp PRE-CREATION src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c Diff: https://reviews.apache.org/r/37175/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37726: Added support for preparing images specified in volumes.
On Aug. 25, 2015, 12:33 a.m., Timothy Chen wrote: src/tests/containerizer/filesystem_isolator_tests.cpp, line 485 https://reviews.apache.org/r/37726/diff/1/?file=1048647#file1048647line485 How about trying multiple rootfs in the same container? Yeah, that needs a few refactor on the test fixture. See the subsequent patches. I'll add a test you suggested in a followup patch. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/#review96254 --- On Aug. 24, 2015, 7:49 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/ --- (Updated Aug. 24, 2015, 7:49 p.m.) Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-3310 https://issues.apache.org/jira/browse/MESOS-3310 Repository: mesos Description --- Added support for preparing images specified in volumes. Diffs - src/slave/containerizer/isolators/filesystem/linux.hpp ee5b33d14208770b474e0cb4ab4422381ceb8a3c src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612 src/tests/containerizer/filesystem_isolator_tests.cpp 7003b03f1da2fee53592bc23799f59eabcd913a2 Diff: https://reviews.apache.org/r/37726/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37585: Maintenance primitives: Add a user doc.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 24, 2015, 5:59 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes --- Updated with a binary patch. Bugs: MESOS-2083 https://issues.apache.org/jira/browse/MESOS-2083 Repository: mesos Description --- Heavily based on the design doc (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/). Includes a diagram of the maintenance mode transitions. This documents the current working prototype (MVP), which starts here: https://reviews.apache.org/r/36321/ One TODO remaining: Update with the release version that maintenance primitives will be released in. Diffs (updated) - docs/images/maintenance-primitives-modes.png PRE-CREATION docs/maintenance.md PRE-CREATION Diff: https://reviews.apache.org/r/37585/diff/ Testing --- Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2 Checked for markdown correctness. Thanks, Joseph Wu
Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.
On Aug. 12, 2015, 9:16 p.m., Joseph Wu wrote: Why are the InverseOffers (and Offers) hashed as pointers? Can you point to an example. I don't understand your question. - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review95172 --- On Aug. 18, 2015, 6:58 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Aug. 18, 2015, 6:58 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs - src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf Diff: https://reviews.apache.org/r/37180/diff/ Testing --- The tests break as expected. With the scheduler API change there are CHECKs that fail. Once we update the API these will be resolved. Thanks, Joris Van Remoortere
Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37621/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 src/tests/master_maintenance_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37621/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37281/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 Diff: https://reviews.apache.org/r/37281/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf Diff: https://reviews.apache.org/r/37180/diff/ Testing --- The tests break as expected. With the scheduler API change there are CHECKs that fail. Once we update the API these will be resolved. Thanks, Joris Van Remoortere
Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb Diff: https://reviews.apache.org/r/37280/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37622: Maintenance Primitives: Shutdown remove slave when maintenance is started.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Aug. 25, 2015, 2:14 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 src/tests/master_maintenance_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37622/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 include/mesos/v1/scheduler/scheduler.proto bd5e82a614b1163b29f9b20e562208efa1ba4b55 Diff: https://reviews.apache.org/r/37178/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37198: Add Docker image provisioner and copy backend.
On Aug. 19, 2015, 6:21 a.m., Timothy Chen wrote: src/slave/containerizer/provisioners/docker.hpp, line 81 https://reviews.apache.org/r/37198/diff/6/?file=1041387#file1041387line81 Did we introduce DockerImageName later? A pair of strings is pretty confusing, how about pulling it earlier to here? The ImageName struct is introduced in 37200, but it also has other changes to the store implementation that wouldn't be relevant in this commit. On Aug. 19, 2015, 6:21 a.m., Timothy Chen wrote: src/slave/containerizer/provisioners/docker.hpp, line 84 https://reviews.apache.org/r/37198/diff/6/?file=1041387#file1041387line84 Actually it's valid to have a registry name with a custom port in the image name: localhost:5050/ubuntu:14.04 You need to first split on /, then do this check. And we should actually include a optional registry name in the DockerImageName struct too. If there are more than 2 path components, what would constitute as the registry name? Simply the first path component? - Lily --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review95831 --- On Aug. 19, 2015, 6:42 p.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 19, 2015, 6:42 p.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Add Docker image provisioner and copy backend. Diffs - src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612 src/slave/containerizer/provisioner.hpp 541dd4e0b2f0c92a45c00cab6132a2be69654838 src/slave/containerizer/provisioner.cpp efc7e6996ff6663bebaf61989a7e040bd2ad7a5e src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 src/tests/containerizer/provisioner.hpp c4ba46794fe5d7875fda11155367f521c34ea339 Diff: https://reviews.apache.org/r/37198/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37541: Add TraceEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 25, 2015, 12:17 a.m.) Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Bugs: MESOS-2769 https://issues.apache.org/jira/browse/MESOS-2769 Repository: mesos Description --- Based on the PerfEvent API's, add API for Linux kernel trace events, especially the schedule trace events. Diffs (updated) - src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37541/diff/ Testing --- make check Thanks, Cong Wang
Re: Review Request 37540: Add PerfEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Aug. 25, 2015, 12:16 a.m.) Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Bugs: MESOS-2769 https://issues.apache.org/jira/browse/MESOS-2769 Repository: mesos Description --- Abstract Linux kernel perf event API and provide API to collect schedule events. Diffs (updated) - src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37540/diff/ Testing --- make check Thanks, Cong Wang
Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96259 --- include/mesos/mesos.proto (line 125) https://reviews.apache.org/r/36321/#comment151594 Unavailability is a time interval or period, but from the name of Unavailability, someone may not able to understand it specifies the time interval or period for maintain. What about using name UnavailableInterval or UnavailablePeriod which might be more meaningful? include/mesos/mesos.proto (line 914) https://reviews.apache.org/r/36321/#comment151597 s/(i.e. which slave)/(i.e. which framework) I think that the comments for this may need to be updated as here if no framework id is specified, then all framework's resources will be request back. include/mesos/mesos.proto (line 939) https://reviews.apache.org/r/36321/#comment151598 Can you please elaborate more for why in maintaince purpose, this field is always empty? Why cannot an operator set the resources that s/he want to inverse? - Guangya Liu On 八月 24, 2015, 6:26 p.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated 八月 24, 2015, 6:26 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Bugs: MESOS-2061 and MESOS-2066 https://issues.apache.org/jira/browse/MESOS-2061 https://issues.apache.org/jira/browse/MESOS-2066 Repository: mesos Description --- MESOS-2061: Add Unavailability and InverseOffer protobufs declarations. MESOS-2066: Add the Unavailability field to Offers. No integration with other components (that part is tracked in separate JIRAs, see MESOS-1474). Diffs - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 Diff: https://reviews.apache.org/r/36321/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37496: Move docker provisioner local store into dedicated folders.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 25, 2015, 1:34 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Move docker provisioner local store into dedicated folders. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37496/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 1:35 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Changes --- Moved staging path into docker store path. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37495: Docker provisioner local store unit tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- (Updated Aug. 25, 2015, 1:34 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Docker provisioner local store unit tests. Diffs (updated) - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37495/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37101: Remove unused sched API's
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/#review96266 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 9:30 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/ --- (Updated Aug. 24, 2015, 9:30 p.m.) Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone. Repository: mesos Description --- We don't use SCHED_IDLE any more. Diffs - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1 src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8 Diff: https://reviews.apache.org/r/37101/diff/ Testing --- make Thanks, Cong Wang
Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf Diff: https://reviews.apache.org/r/37234/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - src/tests/master_maintenance_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37283/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/ --- (Updated Aug. 25, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/maintenance/maintenance.hpp PRE-CREATION src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/tests/master_maintenance_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37172/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Aug. 25, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/tests/master_maintenance_tests.cpp PRE-CREATION src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb Diff: https://reviews.apache.org/r/37175/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf Diff: https://reviews.apache.org/r/37284/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37177: Maintenance Primitives: Added inverse offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/maintenance/maintenance.hpp PRE-CREATION include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/tests/hierarchical_allocator_tests.cpp 9748ca0b3fee25dcec51c64d8ba84dbd4aaf src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc Diff: https://reviews.apache.org/r/37177/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6 src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9 src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9 src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765 src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c Diff: https://reviews.apache.org/r/37282/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/ --- (Updated Aug. 25, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf Diff: https://reviews.apache.org/r/37170/diff/ Testing --- Thanks, Joris Van Remoortere
Review Request 37734: Used recursive bind mounts for volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37734/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Repository: mesos Description --- Used recursive bind mounts for volumes. This is for the case where the volume source itself contains mounts. This will become common when we start to support image as the source of a volume. Diffs - src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612 Diff: https://reviews.apache.org/r/37734/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96272 --- src/messages/messages.proto (line 350) https://reviews.apache.org/r/37500/#comment151607 It is better to add some comments here. i.e. This message is sent to the slave to update framework user info for a slave. src/slave/slave.cpp (line 2173) https://reviews.apache.org/r/37500/#comment151608 Update the indent here - Guangya Liu On Aug. 15, 2015, 8:03 a.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 15, 2015, 8:03 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3240 https://issues.apache.org/jira/browse/MESOS-3240 Repository: mesos Description --- Added user to master's state, slave's state (not exposed) and updated user in all slaves that have the registered framework. Added the test too. Diffs - src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9 src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 Diff: https://reviews.apache.org/r/37500/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 37738: Added a filesystem isolator test to test image in volume while the container root filesystem is also specified.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37738/#review96277 --- Patch looks great! Reviews applied: [37726, 37734, 37735, 37738] All tests passed. - Mesos ReviewBot On Aug. 24, 2015, 11:22 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37738/ --- (Updated Aug. 24, 2015, 11:22 p.m.) Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Repository: mesos Description --- Added a filesystem isolator test to test image in volume while the container root filesystem is also specified. Diffs - src/tests/containerizer/filesystem_isolator_tests.cpp 7003b03f1da2fee53592bc23799f59eabcd913a2 Diff: https://reviews.apache.org/r/37738/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96280 --- Bad patch! Reviews applied: [37196, 37197, 37198, 37200] Failed command: ./support/apply-review.sh -n -r 37200 Error: 2015-08-25 02:27:51 URL:https://reviews.apache.org/r/37200/diff/raw/ [31109/31109] - 37200.patch [1] error: patch failed: src/slave/containerizer/provisioners/docker.cpp:160 error: src/slave/containerizer/provisioners/docker.cpp: patch does not apply error: patch failed: src/slave/containerizer/provisioners/docker/store.cpp:264 error: src/slave/containerizer/provisioners/docker/store.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Aug. 25, 2015, 1:35 a.m., Lily Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 1:35 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/#review96281 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs - include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 include/mesos/v1/scheduler/scheduler.proto bd5e82a614b1163b29f9b20e562208efa1ba4b55 Diff: https://reviews.apache.org/r/37178/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/#review96294 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:44 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/ --- (Updated Aug. 25, 2015, 2:44 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs - include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/tests/master_maintenance_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37623/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/ --- (Updated Aug. 25, 2015, 2:44 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Changes --- Rebased. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/tests/master_maintenance_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37623/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review96285 --- Patch looks great! Reviews applied: [37655] All tests passed. - Mesos ReviewBot On Aug. 25, 2015, 12:14 a.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/ --- (Updated Aug. 25, 2015, 12:14 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Bugs: MESOS-3299 https://issues.apache.org/jira/browse/MESOS-3299 Repository: mesos Description --- Instead of using doubles, seconds and nanoseconds can be represented like `struct timespec`, with one field for seconds and one for nanoseconds. This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives). Note about the naming: * Time will conflict with the Time class. * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration. Diffs - include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 Diff: https://reviews.apache.org/r/37655/diff/ Testing --- `make check` Thanks, Joseph Wu
Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37621/#review96296 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37621/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs - src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 src/tests/master_maintenance_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37621/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review96284 --- include/mesos/v1/mesos.proto (line 907) https://reviews.apache.org/r/37282/#comment151616 There is a patch for non V1 API here: https://reviews.apache.org/r/36321/diff/10#index_header I think that here should be which framework but not which agent? One question want to get your confirm: In V1 api, we changed SlaveId to AgentId, right? - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs - include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6 src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9 src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9 src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765 src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c Diff: https://reviews.apache.org/r/37282/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/#review96291 --- Patch looks great! Reviews applied: [36321, 36571, 37314, 37325, 37358, 37362, 37364, 37170, 37172, 37173, 37175, 37176, 37177, 37582, 37178, 37281, 37282, 37280, 37180, 37234, 37283, 37284, 37621, 37622, 37623] All tests passed. - Mesos ReviewBot On Aug. 25, 2015, 2:44 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/ --- (Updated Aug. 25, 2015, 2:44 a.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. Bugs: MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474 Repository: mesos Description --- See summary. Diffs - include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf src/tests/master_maintenance_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37623/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 36908: Added QuotaInfo Protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review96299 --- include/mesos/master/quota.proto (line 19) https://reviews.apache.org/r/36908/#comment151622 Yes, does v1 API will be supportted for quota? src/Makefile.am (line 182) https://reviews.apache.org/r/36908/#comment151621 It is better consider the alpha order of those files, we can add quota related files under module related files. - Guangya Liu On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/ --- (Updated Aug. 5, 2015, 2:03 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff. Bugs: MESOS-3164 https://issues.apache.org/jira/browse/MESOS-3164 Repository: mesos Description --- Added QuotaInfo Protobuf. Diffs - include/mesos/master/quota.hpp PRE-CREATION include/mesos/master/quota.proto PRE-CREATION src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec Diff: https://reviews.apache.org/r/36908/diff/ Testing --- make distcheck Thanks, Joerg Schad
