Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 一月 6, 2016, 7:43 a.m.)


Review request for mesos and Alexander Rukletsov.


Summary (updated)
-

Speed up SlaveRecoveryTest.*.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs
-

  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 39923: Cleaned up configuration.md.

[Guangya Liu]

> On 一月 6, 2016, 12:26 a.m., Neil Conway wrote:
> > This introduces some inconsistencies between the text in `configuration.md` 
> > and the content of the various `flags.cpp` files (first thing I checked: 
> > "api" still appears in `src/logging/flags.cpp` but we now use "API" in 
> > `configuration.md`; likely other instances as well).

@Neil, please refer to https://reviews.apache.org/r/41933/ , all of the issues 
you mentioned are being fixed there.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review112974
---


On 一月 5, 2016, 7:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated 一月 5, 2016, 7:53 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, Kapil Arya, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review113016
---


Patch looks great!

Reviews applied: [41787]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 1:48 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> ---
> 
> (Updated Jan. 6, 2016, 1:48 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some tests are sped up by using clock, while some relies on the fix of 
> MESOS-4111 and a comment is put.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 
> 
> Diff: https://reviews.apache.org/r/41787/diff/
> 
> 
> Testing
> ---
> 
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41892/#review113019
---



src/docker/docker.cpp (lines 410 - 420)


Instead of doing that in this way, I would suggest we modify 
'containerInfo' in docker containerizer. 

In other words, add additional containerInfo.volumes() in 
DockerContainerizerProcess::Container::create().


- Jie Yu


On Jan. 4, 2016, 9:15 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41892/
> ---
> 
> (Updated Jan. 4, 2016, 9:15 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This diff makes DockerContainerizer infers hostPath for persistent volumes 
> from resources passed-in.
> 
> This allows current DockerContainerizer to use persistent volumes w/o hard 
> code slave's work_dir. I also checked that the inferred directory actually 
> exists to avoid framework messing up role or persistent id.
> 
> Note that some validation on the resource part should be done before we start 
> the container, which seems to belong to slave.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1 
>   src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8 
>   src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 
>   src/docker/executor.cpp 7512d07de6c8324340e6b5f3e5162ef00efc47fc 
>   src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> cb58b7183c36d96b9ac4803c63980c278a50c97b 
>   src/tests/containerizer/docker_tests.cpp 
> 83eceacaddc38d0ccfc42e65e700a09406d8df36 
>   src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
>   src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 
> 
> Diff: https://reviews.apache.org/r/41892/diff/
> 
> 
> Testing
> ---
> 
> New unit test.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 41961: Added an HTTP decode response method.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/#review113009
---


Patch looks great!

Reviews applied: [41956, 41957, 41960, 41961]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 1:44 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41961/
> ---
> 
> (Updated Jan. 6, 2016, 1:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an HTTP decode response method. This will be used to decode the 
> response returned from curl.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ed708fe4b0006782a19f9c61603f152e32a02e8e 
>   3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 
> 
> Diff: https://reviews.apache.org/r/41961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41933: Updated master help message for acls.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41933/
---

(Updated 一月 6, 2016, 3:37 a.m.)


Review request for mesos and Adam B.


Changes
---

Rebase


Bugs: MESOS-4293
https://issues.apache.org/jira/browse/MESOS-4293


Repository: mesos


Description (updated)
---

The ACL messages now moved from mesos.proto to authorizer.proto,
the mesos master help message and authorization.md should also
be updated to reflect this.


Diffs (updated)
-

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 

Diff: https://reviews.apache.org/r/41933/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 41953: Exposed docker v1/v2 spec protobuf and headers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41953/#review113005
---


Bad patch!

Reviews applied: [41953]

Failed command: ./support/apply-review.sh -n -r 41953

Error:
 2016-01-06 03:34:34 URL:https://reviews.apache.org/r/41953/diff/raw/ 
[6983/6983] -> "41953.patch" [1]
error: include/mesos/docker/v1.hpp: already exists in index
error: include/mesos/docker/v2.hpp: already exists in index
error: patch failed: src/Makefile.am:174
error: src/Makefile.am: patch does not apply
error: patch failed: src/docker/spec.hpp:21
error: src/docker/spec.hpp: patch does not apply
error: patch failed: src/docker/v1.hpp:14
error: src/docker/v1.hpp: patch does not apply
error: src/docker/v1.proto: does not exist in index
error: patch failed: src/docker/v2.hpp:14
error: src/docker/v2.hpp: patch does not apply
error: src/docker/v2.proto: does not exist in index

- Mesos ReviewBot


On Jan. 5, 2016, 11:48 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41953/
> ---
> 
> (Updated Jan. 5, 2016, 11:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed docker v1/v2 spec protobuf and headers.
> 
> This will be exposed in ContainerConfig and passed to all isolators so that a 
> docker isolator can properly isolate the runtime based on the image manifest 
> returned from the provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/docker/v1.hpp PRE-CREATION 
>   include/mesos/docker/v2.hpp PRE-CREATION 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/docker/spec.hpp 74968f2e776e52e3225db63c8dbd5b3c88a71c8f 
>   src/docker/v1.hpp b7ec35f409d7b578d58f2150c56ff2e8c949da7c 
>   src/docker/v1.proto  
>   src/docker/v2.hpp 4b14969ff09bc3bd20cda8231e41f170fa52353d 
>   src/docker/v2.proto 5d10bd3a6c077d34dd6921cdfd378b9fafe29a15 
> 
> Diff: https://reviews.apache.org/r/41953/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41952: Added recommendations for programming with persistent volumes.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41952/#review113002
---


Patch looks great!

Reviews applied: [41952]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 12:04 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41952/
> ---
> 
> (Updated Jan. 6, 2016, 12:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Bugs: MESOS-4209
> https://issues.apache.org/jira/browse/MESOS-4209
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added recommendations for programming with persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 
> 
> Diff: https://reviews.apache.org/r/41952/diff/
> 
> 
> Testing
> ---
> 
> Previewed with site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41946: Added a `Representation` abstraction to stout.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41946/
---

(Updated Jan. 6, 2016, 2:48 a.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41946/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41595/
---

(Updated Jan. 6, 2016, 2:48 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Rebased.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/common/http.hpp 4f4cbf6e53588b72204f9628dea5696c71eb66a5 
  src/common/http.cpp 7165551321bedb8a4d711a64d0d6d8fd15215424 
  src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 

Diff: https://reviews.apache.org/r/41595/diff/


Testing
---

# Some preliminery numbers

These numbers are from my Ubuntu VM on my Mac OS X with @vinodkone's benchmark 
test: [r40844](https://reviews.apache.org/r/40844/).

### Before

```
[==] Running 36 tests from 1 test case.
[--] Global test environment set-up.
[--] 36 tests from SlaveAndFrameworkCount/MasterState_BENCHMARK_Test
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0
Added 1000 slaves and 1 frameworks
Received state.json response in 683.138216ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0 (1436 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1
Added 1000 slaves and 50 frameworks
Received state.json response in 550.636939ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1 (1474 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2
Added 1000 slaves and 100 frameworks
Received state.json response in 632.835236ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2 (1491 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3
Added 1000 slaves and 200 frameworks
Received state.json response in 584.035771ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3 (1431 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4
Added 1000 slaves and 500 frameworks
Received state.json response in 688.404348ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4 (1586 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5
Added 1000 slaves and 1000 frameworks
Received state.json response in 666.713683ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5 (1590 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6
Added 5000 slaves and 1 frameworks
Received state.json response in 3.916201532secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6 (7852 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7
Added 5000 slaves and 50 frameworks
Received state.json response in 3.362618796secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7 (8315 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8
Added 5000 slaves and 100 frameworks
Received state.json response in 3.126815189secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8 (7153 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9
Added 5000 slaves and 200 frameworks
Received state.json response in 3.079956539secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9 (7534 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10
Added 5000 slaves and 500 frameworks
Received state.json response in 3.222014521secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10 (8129 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11
Added 5000 slaves and 1000 frameworks
Received state.json response in 3.286657158secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11 (8133 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12
Added 1 slaves and 1 frameworks
Received state.json response in 7.332592151secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12 (15639 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/13
Added 1 slaves and 50 frameworks
Received state.json response in 6.998751033secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/13 (17175 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/14
Added 1 slaves and 100 frameworks
Received state.json response in 6.807456891secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/14 (15974 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/15
Added 1 slaves and 200 frameworks
Received state.json response in 6.371190971secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/15 (15772 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/16
Added 1 slaves and 500 frameworks
Received state.json response in 6.613739531secs
[   OK ] SlaveAndFrameworkC

Re: Review Request 41462: Used SFINAE-friendly `result_of` in libprocess.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/
---

(Updated Jan. 6, 2016, 2:28 a.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
Remoortere.


Changes
---

Rebased.


Bugs: MESOS-4220
https://issues.apache.org/jira/browse/MESOS-4220


Repository: mesos


Description
---

Used the SFINAE `result_of` implemented in 
[r41461](https://reviews.apache.org/r/41461/).

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs (updated)
-

  3rdparty/libprocess/include/process/async.hpp 
b80b60a7ceb5e87eed8cdab17144ae9617485a04 
  3rdparty/libprocess/include/process/future.hpp 
bcb5668565298825056f1b48d48efe12d2e56e7c 

Diff: https://reviews.apache.org/r/41462/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41460/
---

(Updated Jan. 6, 2016, 2:27 a.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
Remoortere.


Changes
---

Reverted to using forwarding references and added comments.


Bugs: MESOS-4228
https://issues.apache.org/jira/browse/MESOS-4228


Repository: mesos


Description
---

The Standard (C++11 through 17) does not require `std::bind`'s function call 
operator to SFINAE, and VS 2015's doesn't. `std::is_bind_expression` can be 
used to manually reroute bind expressions to the 1-arg overload, where 
(conveniently) the argument will be ignored if necessary.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs (updated)
-

  3rdparty/libprocess/include/process/future.hpp 
bcb5668565298825056f1b48d48efe12d2e56e7c 

Diff: https://reviews.apache.org/r/41460/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

[Michael Park]

> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 226
> > 
> >
> > I'd love to see a comment here that says:
> > 
> > This is the less prefered `onReady`, we prefer the `onReady` method 
> > which has `f` taking a `const T&` parameter. Unfortunately, to complicate 
> > matters, if `F` is a `std::bind` expression we need to SFINAE out this 
> > version of `onReady` and force the use of the preferred `onReady` (which 
> > thankfully works because `std::bind` will just ignore the `const T&` 
> > argument). This is necessary because Visual Studio 2015 doesn't support 
> > using the `std::bind` call operator with `std::result_of` as it's 
> > technically not a requirement by the C++ standard.
> > 
> > And then let's add a comment over the other `LessPrefer` variants that 
> > points up to the `onReady(F f, LessPrefer)` that includes this comment.

Added.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41460/#review112480
---


On Jan. 5, 2016, 11:58 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41460/
> ---
> 
> (Updated Jan. 5, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4228
> https://issues.apache.org/jira/browse/MESOS-4228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Standard (C++11 through 17) does not require `std::bind`'s function call 
> operator to SFINAE, and VS 2015's doesn't. `std::is_bind_expression` can be 
> used to manually reroute bind expressions to the 1-arg overload, where 
> (conveniently) the argument will be ignored if necessary.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41460/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

[Michael Park]

> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 291
> > 
> >
> > This is another spot that looks like we could have a double copy?

See above: https://reviews.apache.org/r/41460/#comment172929


> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 300
> > 
> >
> > Do you know which compilers will elide this `std::move`?

See above: https://reviews.apache.org/r/41460/#comment172929


> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/future.hpp, lines 220-223
> > 
> >
> > Now that we're not taking `f` as a universal reference for each of 
> > these methods it seems that we might make two copies (one when we invoke 
> > the function and the second when we capture `f` in the lambda)?
> > 
> > Can we add a TODO to move capture `f` once we have C++14? Or 
> > alternatively should we use `std::bind` here so we can explicitly move it 
> > and then convert back to lambda syntax once we have C++14?
> 
> Michael Park wrote:
> Yeah, there are a few places where we potentially copy twice. I guess my 
> understanding was that we typically don't worry about performance unless it 
> becomes a clear problem. I think maybe what we do in this review is keep the 
> forwarding references for now and talk about the "pass-by-value & move" 
> pattern separately.

Reverted to using forwarding references as before. We'll have a discussion 
around whether we want to adopt the "pass-by-value + move" pattern project-wide.


> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 312
> > 
> >
> > Double copy?

See above: https://reviews.apache.org/r/41460/#comment172929


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41460/#review112480
---


On Jan. 5, 2016, 11:58 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41460/
> ---
> 
> (Updated Jan. 5, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4228
> https://issues.apache.org/jira/browse/MESOS-4228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Standard (C++11 through 17) does not require `std::bind`'s function call 
> operator to SFINAE, and VS 2015's doesn't. `std::is_bind_expression` can be 
> used to manually reroute bind expressions to the 1-arg overload, where 
> (conveniently) the argument will be ignored if necessary.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41460/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

[Michael Park]

> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/future.hpp, lines 228-230
> > 
> >
> > Why do we need to capture/alias the type `F` as `G` again and then use 
> > it in `std::result_of::type`? Why can't we just use `F` there again?

We could if there was a guarantee that the default template arguments are 
instantiated left-to-right. I'm not sure whether such guarantee exists and 
would prefer not rely on it even if it did.

This way, it's required that the default argument to `G` be instantiated first, 
and there's no chance of `std::result_of` being instantiated with `F` if `F` is 
the result of a `std::bind`.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41460/#review112480
---


On Jan. 5, 2016, 11:58 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41460/
> ---
> 
> (Updated Jan. 5, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4228
> https://issues.apache.org/jira/browse/MESOS-4228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Standard (C++11 through 17) does not require `std::bind`'s function call 
> operator to SFINAE, and VS 2015's doesn't. `std::is_bind_expression` can be 
> used to manually reroute bind expressions to the 1-arg overload, where 
> (conveniently) the argument will be ignored if necessary.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41460/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41962/
---

Review request for mesos, Benjamin Hindman, Gilbert Song, Artem Harutyunyan, 
Jie Yu, and Timothy Chen.


Bugs: MESOS-4150
https://issues.apache.org/jira/browse/MESOS-4150


Repository: mesos


Description
---

Adds two heavily-mocked tests for the Mesos containerizer and Docker 
containerizer.  Each checks that `ContainerLogger::recover` is called during 
`Containerizer::recover`.


Diffs
-

  src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41962/diff/


Testing
---

make (OSX & Centos7)

Tests are run in the next review.


Thanks,

Joseph Wu

Review Request 41963: Logger Module: Implement ContainerLogger recovery.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41963/
---

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Timothy Chen.


Bugs: MESOS-4150
https://issues.apache.org/jira/browse/MESOS-4150


Repository: mesos


Description
---

Adds a call to `ContainerLogger::recover` inside each containerizer's 
`Containerizer::recover`.


Diffs
-

  src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
  src/slave/containerizer/mesos/containerizer.cpp 
f3c370aeb331beb6202fd30cd0278877da0b42e0 

Diff: https://reviews.apache.org/r/41963/diff/


Testing
---

make check (OSX & Centos7)

sudo bin/mesos-tests.sh --gtest_filter="*ROOT*" (Centos7)


Thanks,

Joseph Wu

Re: Review Request 41789: Expose the http::internal::request function.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/
---

(Updated Jan. 6, 2016, 2:15 a.m.)


Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil 
Conway, and Qian Zhang.


Changes
---

Fix the build error.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Expose the internal::http::request function in the header and not add an 
additional method/overload for put function.

(TODO): Clean the other instances of post/get to use the http::request method.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
ed708fe4b0006782a19f9c61603f152e32a02e8e 
  3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 

Diff: https://reviews.apache.org/r/41789/diff/


Testing
---

Make & Make check successfully.


Thanks,

Yongqiao Wang

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/
---

(Updated Jan. 6, 2016, 2:15 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Introduce HTTP endpoint /weights for updating weight.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
f61613948b7b5c5c2118f1782a0c5f8ff7e8e057 
  include/mesos/authorizer/authorizer.proto 
7b729e19484d92be48bbde4dff2c833a4109936e 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
  src/master/weights_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41681/diff/


Testing
---

Make & Make check successfully!

$ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/Users/yqwyq/tmp/mesos-master  
>> /tmp/mesos-master.log 2>&1 &)
$ curl -d 
weights="[{\"weight\":1.0,\"role\":\"role1\"},{\"weight\":8.0,\"role\":\"role2\"}]"
 -X PUT http://localhost:5050/weights
$ curl http://localhost:5050/roles
{
"roles": [
{
"frameworks": [ ], 
"name": "*", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role1", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role2", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 8
}
]
}


Thanks,

Yongqiao Wang

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Jan. 6, 2016, 2:14 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
  include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Re: Review Request 41959: Statically initializing fetcher plugins.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41959/
---

(Updated Jan. 6, 2016, 2:14 a.m.)


Review request for mesos and Jie Yu.


Changes
---

added flag to retry on error


Repository: mesos


Description
---

Since fetcher plugins are not dynamically pluggable today, simplified the
factory method to use the statically intitalized plugins. This would be
useful when Fetchers are created multiple times.


Diffs (updated)
-

  src/uri/fetcher.cpp ac13fbdc7399045d183cbdcc48dc5cf9969e8ad5 

Diff: https://reviews.apache.org/r/41959/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 41461: Added SFINAE-friendly `result_of` to stout.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41461/
---

(Updated Jan. 6, 2016, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
Remoortere.


Summary (updated)
-

Added SFINAE-friendly `result_of` to stout.


Bugs: MESOS-4220
https://issues.apache.org/jira/browse/MESOS-4220


Repository: mesos


Description
---

VS 2015 won't support C++14 `std::result_of` SFINAE until Update 2, so 
`result_of` must be replaced with `decltype(invoke)`.

Here, we implement SFINAE `result_of` in `stout`.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41461/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41462: Used SFINAE-friendly `result_of` in libprocess.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/
---

(Updated Jan. 6, 2016, 2:12 a.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
Remoortere.


Summary (updated)
-

Used SFINAE-friendly `result_of` in libprocess.


Bugs: MESOS-4220
https://issues.apache.org/jira/browse/MESOS-4220


Repository: mesos


Description
---

Used the SFINAE `result_of` implemented in 
[r41461](https://reviews.apache.org/r/41461/).

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs
-

  3rdparty/libprocess/include/process/async.hpp 
b80b60a7ceb5e87eed8cdab17144ae9617485a04 
  3rdparty/libprocess/include/process/future.hpp 
bcb5668565298825056f1b48d48efe12d2e56e7c 

Diff: https://reviews.apache.org/r/41462/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41462: libprocess: Used SFINAE-friendly `result_of`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/#review112992
---


Bad patch!

Reviews applied: [41459, 41460, 41461]

Failed command: ./support/apply-review.sh -n -r 41461

Error:
 2016-01-06 02:01:54 URL:https://reviews.apache.org/r/41461/diff/raw/ 
[3411/3411] -> "41461.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.

- Mesos ReviewBot


On Jan. 5, 2016, 11:58 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41462/
> ---
> 
> (Updated Jan. 5, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4220
> https://issues.apache.org/jira/browse/MESOS-4220
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used the SFINAE `result_of` implemented in 
> [r41461](https://reviews.apache.org/r/41461/).
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/async.hpp 
> b80b60a7ceb5e87eed8cdab17144ae9617485a04 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41462/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41790: Add tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
---

(Updated Jan. 6, 2016, 2:07 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Using the common functions.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add tests for /weights endpoint.


Diffs (updated)
-

  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/tests/dynamic_weights_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41790/diff/


Testing
---

Make and Make check successfully!

./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==] Running 10 tests from 1 test case.
[--] Global test environment set-up.
[--] 10 tests from DynamicWeightsTest
[ RUN  ] DynamicWeightsTest.PutInvalidRequest
[   OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN  ] DynamicWeightsTest.NegativeWeight
[   OK ] DynamicWeightsTest.NegativeWeight (42 ms)
[ RUN  ] DynamicWeightsTest.MissingRole
[   OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN  ] DynamicWeightsTest.NonExistentRole
[   OK ] DynamicWeightsTest.NonExistentRole (30 ms)
[ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
[ RUN  ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[   OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
[ RUN  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[   OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
[ RUN  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[   OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
[ RUN  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[   OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
(44 ms)
[ RUN  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[   OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[--] 10 tests from DynamicWeightsTest (443 ms total)

[--] Global test environment tear-down
[==] 10 tests from 1 test case ran. (452 ms total)
[  PASSED  ] 10 tests.


Thanks,

Yongqiao Wang

Re: Review Request 41789: Expose the http::internal::request function.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/
---

(Updated Jan. 6, 2016, 2:07 a.m.)


Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil 
Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Expose the internal::http::request function in the header and not add an 
additional method/overload for put function.

(TODO): Clean the other instances of post/get to use the http::request method.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
ed708fe4b0006782a19f9c61603f152e32a02e8e 
  3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 

Diff: https://reviews.apache.org/r/41789/diff/


Testing
---

Make & Make check successfully.


Thanks,

Yongqiao Wang

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/
---

(Updated Jan. 6, 2016, 2:06 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Introduce HTTP endpoint /weights for updating weight.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
f61613948b7b5c5c2118f1782a0c5f8ff7e8e057 
  include/mesos/authorizer/authorizer.proto 
7b729e19484d92be48bbde4dff2c833a4109936e 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
  src/master/weights_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41681/diff/


Testing
---

Make & Make check successfully!

$ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/Users/yqwyq/tmp/mesos-master  
>> /tmp/mesos-master.log 2>&1 &)
$ curl -d 
weights="[{\"weight\":1.0,\"role\":\"role1\"},{\"weight\":8.0,\"role\":\"role2\"}]"
 -X PUT http://localhost:5050/weights
$ curl http://localhost:5050/roles
{
"roles": [
{
"frameworks": [ ], 
"name": "*", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role1", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role2", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 8
}
]
}


Thanks,

Yongqiao Wang

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Jan. 6, 2016, 2:06 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
  include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Re: Review Request 41789: Expose the http::internal::request function.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/
---

(Updated Jan. 6, 2016, 1:54 a.m.)


Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil 
Conway, and Qian Zhang.


Changes
---

Add a common function to let caller to generate the Request object.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Expose the internal::http::request function in the header and not add an 
additional method/overload for put function.

(TODO): Clean the other instances of post/get to use the http::request method.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
ed708fe4b0006782a19f9c61603f152e32a02e8e 
  3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 

Diff: https://reviews.apache.org/r/41789/diff/


Testing
---

Make & Make check successfully.


Thanks,

Yongqiao Wang

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/
---

(Updated Jan. 6, 2016, 1:53 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Introduce HTTP endpoint /weights for updating weight.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
f61613948b7b5c5c2118f1782a0c5f8ff7e8e057 
  include/mesos/authorizer/authorizer.proto 
7b729e19484d92be48bbde4dff2c833a4109936e 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
  src/master/weights_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41681/diff/


Testing
---

Make & Make check successfully!

$ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/Users/yqwyq/tmp/mesos-master  
>> /tmp/mesos-master.log 2>&1 &)
$ curl -d 
weights="[{\"weight\":1.0,\"role\":\"role1\"},{\"weight\":8.0,\"role\":\"role2\"}]"
 -X PUT http://localhost:5050/weights
$ curl http://localhost:5050/roles
{
"roles": [
{
"frameworks": [ ], 
"name": "*", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role1", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role2", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 8
}
]
}


Thanks,

Yongqiao Wang

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Jan. 6, 2016, 1:53 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
  include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Re: Review Request 39614: Quota: Added Status Validation Tests.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review112991
---

Ship it!


- Joris Van Remoortere


On Jan. 5, 2016, 6:25 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> ---
> 
> (Updated Jan. 5, 2016, 6:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4218
> https://issues.apache.org/jira/browse/MESOS-4218
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 41959: Statically initializing fetcher plugins.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41959/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Since fetcher plugins are not dynamically pluggable today, simplified the
factory method to use the statically intitalized plugins. This would be
useful when Fetchers are created multiple times.


Diffs
-

  src/uri/fetcher.cpp ac13fbdc7399045d183cbdcc48dc5cf9969e8ad5 

Diff: https://reviews.apache.org/r/41959/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39492: Added status endpoint for quota master endpoint.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review112665
---

Ship it!


- Joris Van Remoortere


On Dec. 22, 2015, 9:40 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> ---
> 
> (Updated Dec. 22, 2015, 9:40 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4013
> https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
>   src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> ---
> 
> Tests are in Review 39614.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/#review112990
---


Patch looks great!

Reviews applied: [41896]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 11:10 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41896/
> ---
> 
> (Updated Jan. 5, 2016, 11:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3936
> https://issues.apache.org/jira/browse/MESOS-3936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added guide to writing highly available Mesos frameworks.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/high-availability-framework-guide.md PRE-CREATION 
>   docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
> 
> Diff: https://reviews.apache.org/r/41896/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> Note that there's a lot more that could be said here; also, at some point we 
> should probably unify the "reconciliation" page with this page, and perhaps 
> move some of the content in the "high-availability" page here (leaving the 
> "high-availability" page for the operator-centric parts of configuring Mesos 
> to run in HA mode).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 一月 6, 2016, 1:48 a.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Review Request 41961: Added an HTTP decode response method.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/
---

Review request for mesos, Ben Mahler and Timothy Chen.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
---

Added an HTTP decode response method. This will be used to decode the response 
returned from curl.


Diffs
-

  3rdparty/libprocess/include/process/http.hpp 
ed708fe4b0006782a19f9c61603f152e32a02e8e 
  3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 

Diff: https://reviews.apache.org/r/41961/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 一月 6, 2016, 1:44 a.m.)


Review request for mesos and Alexander Rukletsov.


Summary (updated)
-

Speed up Speed up SlaveRecoveryTest.*.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs (updated)
-

  docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
  docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
  docs/home.md bc22d3126f49e0213e6bb3a0e23e156cd2b247f1 
  docs/mesos-provisioner.md 06094f572a7917ddd1f7d73a6d855a9c9932cbab 
  include/mesos/docker/v1.hpp a155a8ec8e1895a793b98ac015b18ce6ac52956d 
  include/mesos/docker/v1.proto  
  include/mesos/docker/v2.hpp abab12b8f73564a6da1a0265a503d407a2849b3f 
  include/mesos/docker/v2.proto e2c0a131b8429ca086bc5cd09dccfe3e8d2e50ac 
  include/mesos/executor/executor.proto 
cc6b4f67da62dacf2fc649f00ba15a3fba98910b 
  include/mesos/v1/executor/executor.proto 
4ecdaa0a468da1b271aa382a945d7e2a59c32449 
  include/mesos/v1/scheduler.hpp fc8ae50fa1a27ce1c52b2b51de54d2c54551f85e 
  src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d 
  src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
  src/docker/v1.hpp a155a8ec8e1895a793b98ac015b18ce6ac52956d 
  src/docker/v2.hpp abab12b8f73564a6da1a0265a503d407a2849b3f 
  src/examples/event_call_framework.cpp 
8cfe1a0794b476bc099b067a9aeb79f099bbc18c 
  src/master/allocator/mesos/hierarchical.cpp 
df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
  src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
  src/scheduler/scheduler.cpp a17872b46ec600e0fae6c43247ccb63f5ee55ac0 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
7f441de097719114f81716caade44388720273f6 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
6ae920a820a7604c97debf9fd21de24dda8e4d36 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
5650f2f51c0ea31527c6c51eb498d87ddf2a4fec 
  src/slave/flags.hpp 6857fde027fd57b4934cb43ddf435d12900e0b87 
  src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/tests/containerizer/provisioner_docker_tests.cpp 
8d6a06057c7600aeb1aca76d4dfadc45b6eae99d 
  src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67 
  src/tests/master_maintenance_tests.cpp 
2da6a2d4b786d9c5f64be8b5ab95f70ef3d98f92 
  src/tests/mesos.hpp 49a4c48e6887e6f0921d96c359746e39be10e222 
  src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
  src/tests/persistent_volume_endpoints_tests.cpp 
f0cce190abc90f0fae84d6c3db20e8215c2d8132 
  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 
  src/webui/master/static/framework.html 
9b28820dc93de1f66942b9b1f62a3288ee7609ac 
  src/webui/master/static/frameworks.html 
15ff1e9cb6c70df8df47a1b939681abde591e010 
  src/webui/master/static/home.html f6d2f7d0923553ba0bb88e52f541c4e8c740c7c1 
  src/webui/master/static/js/controllers.js 
36865f1cd6a4518ba30cd6e64d4d7347762066ec 
  src/webui/master/static/js/dashboard.js 
d6cbb3cc5aa92249c4b17c6d77260b215203d008 
  src/webui/master/static/js/services.js 
fa5cc35c1ef0e8ec149ed88852837058ec6ab13c 
  src/webui/master/static/offers.html 25e487193ae5244dde40d1de1d96ce892a7c67b9 
  src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3 
  src/webui/master/static/slave_executor.html 
9d582d54ce97f1b395f60acb28df95e4f9a48b3b 
  src/webui/master/static/slave_framework.html 
96d788f04235b8e3881308818acba8f22d08e2ec 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Review Request 41960: Added the Docker URI fetcher plugin interface.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41960/
---

Review request for mesos, Timothy Chen and Vinod Kone.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
---

Added the Docker URI fetcher plugin interface. See the motivation in the ticket.

This patch just introduces the interface. The implementation will be added in 
the subsequent patches.


Diffs
-

  src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d 
  src/uri/fetcher.hpp d5182a51809b901b5c22dc66cd48e0068caf89a0 
  src/uri/fetcher.cpp ac13fbdc7399045d183cbdcc48dc5cf9969e8ad5 
  src/uri/fetchers/docker.hpp PRE-CREATION 
  src/uri/fetchers/docker.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41960/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 41958: Removed unwanted forward declaration in Fetcher header.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41958/#review112989
---

Ship it!


Ship It!

- Jie Yu


On Jan. 6, 2016, 1:33 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41958/
> ---
> 
> (Updated Jan. 6, 2016, 1:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unwanted forward declaration in Fetcher header.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp 4223f9e1f304b167d0fe7c2f914f3d3e897033c0 
> 
> Diff: https://reviews.apache.org/r/41958/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Review Request 41958: Removed unwanted forward declaration in Fetcher header.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41958/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Removed unwanted forward declaration in Fetcher header.


Diffs
-

  include/mesos/uri/fetcher.hpp 4223f9e1f304b167d0fe7c2f914f3d3e897033c0 

Diff: https://reviews.apache.org/r/41958/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Review Request 41957: Style fix for curl URI fetcher plugin.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41957/
---

Review request for mesos, Timothy Chen and Vinod Kone.


Repository: mesos


Description
---

Style fix for curl URI fetcher plugin.


Diffs
-

  src/uri/fetchers/curl.cpp 0ff9833dc5ca53ddc137fd2013b4dc5420ae4eb1 

Diff: https://reviews.apache.org/r/41957/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 41956: Removed an unnecessary os::exists check in curl URI fetcher plugin.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41956/
---

Review request for mesos, Timothy Chen and Vinod Kone.


Repository: mesos


Description
---

Removed an unnecessary os::exists check in curl URI fetcher plugin.


Diffs
-

  src/uri/fetchers/curl.cpp 0ff9833dc5ca53ddc137fd2013b4dc5420ae4eb1 

Diff: https://reviews.apache.org/r/41956/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/
---

(Updated Jan. 6, 2016, 1:29 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Modified env variable name.


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description
---

This change introduces the implementation for the executor library. 

This uses the new HTTP Connection interface to ensure calls are properly 
pipelined.

`connected` -> Callback invoked when a TCP connection is established with the 
agent.
`disconnected` -> When the TCP connection is interrupted possibly due to an 
agent restart.
`received` -> When the executor receives events from the agent upon subscribing.


Diffs (updated)
-

  src/Makefile.am 8af0115caa67ac8f3193d8f0d0f1a4ae739af275 
  src/executor/executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41283/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41277: Added environment variables to be used by HTTP executors for connection/retrying disconnections.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41277/
---

(Updated Jan. 6, 2016, 1:22 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Modified environment variable name for `Backoff` and got rid of other variables.


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description
---

This change adds some environment variables that are used by the HTTP executors 
upon startup for connecting/retrying to the agent. These variables are 
discussed in more detail in the Executor HTTP API Design Doc.


Diffs (updated)
-

  src/slave/containerizer/containerizer.cpp 
dcdf98fea4ca6f96658886db5d09c99f3bff501d 

Diff: https://reviews.apache.org/r/41277/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

[Michael Park]

> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/future.hpp, lines 220-223
> > 
> >
> > Now that we're not taking `f` as a universal reference for each of 
> > these methods it seems that we might make two copies (one when we invoke 
> > the function and the second when we capture `f` in the lambda)?
> > 
> > Can we add a TODO to move capture `f` once we have C++14? Or 
> > alternatively should we use `std::bind` here so we can explicitly move it 
> > and then convert back to lambda syntax once we have C++14?

Yeah, there are a few places where we potentially copy twice. I guess my 
understanding was that we typically don't worry about performance unless it 
becomes a clear problem. I think maybe what we do in this review is keep the 
forwarding references for now and talk about the "pass-by-value & move" pattern 
separately.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41460/#review112480
---


On Jan. 5, 2016, 11:58 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41460/
> ---
> 
> (Updated Jan. 5, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4228
> https://issues.apache.org/jira/browse/MESOS-4228
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Standard (C++11 through 17) does not require `std::bind`'s function call 
> operator to SFINAE, and VS 2015's doesn't. `std::is_bind_expression` can be 
> used to manually reroute bind expressions to the 1-arg overload, where 
> (conveniently) the argument will be ignored if necessary.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41460/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

[Michael Park]

> On Jan. 4, 2016, 5:30 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp, line 41
> > 
> >
> > my question here is, why does `result_of_type` needs to take 
> > parameters?, just so `fail result_of_type` can take and then ignore them?
> 
> Alexander Rukletsov wrote:
> Looks like the compiler cannot disambiguate between ` foo(...)` 
> and ` foo()` because there is no conversion happening (my guess is 
> based on a note in 
> http://en.cppreference.com/w/cpp/language/variadic_arguments). MPark, looks 
> like a comment here can be really helpful : ).

If the expression SFINAEs out the non-`fail` version, then we're only left with 
the `fail` version and we use that. If the expression __does not__ SFINAE out 
the non-`fail` version, then we have both overloads in the overload set, and we 
want the non-`fail` version to win. In order to achieve this we pass `int` is a 
better match than `...` with `0` as the argument, so it wins overload 
resolution.

I've updated this to use the pattern in `future.hpp` instead, which is `Prefer` 
and `LessPrefer`. It's the same concept. `Prefer` inherits from `LessPrefer`, 
so they are both viable, but `Prefer` is a better match than `LessPrefer` with 
`Prefer()` as the argument.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41461/#review112599
---


On Jan. 6, 2016, 12:55 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41461/
> ---
> 
> (Updated Jan. 6, 2016, 12:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4220
> https://issues.apache.org/jira/browse/MESOS-4220
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::result_of` SFINAE until Update 2, so 
> `result_of` must be replaced with `decltype(invoke)`.
> 
> Here, we implement SFINAE `result_of` in `stout`.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41461/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

[Michael Park]

> On Dec. 28, 2015, 5:33 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp, lines 21-22
> > 
> >
> > Do you want to reference MESOS-3993? Maybe update the ticket as well, 
> > once this lands.

Done. I think we'll probably turn MESOS-3993 into a more general, "switch back 
to `std::result_of`"


> On Dec. 28, 2015, 5:33 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp, lines 33-34
> > 
> >
> > Let's make a note that `std::invoke()`, which is c++17 AFAIK, is 
> > supported by msvc 2015 and it's not in .

Done.

```
// `std::invoke` is a C++17 feature, but we only compile this code for Windows,
// which has it implemented in VS 2015 Update 1. It is also supposed to be
// defined in ``, but is included in `` in VS.
```


> On Dec. 28, 2015, 5:33 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp, line 41
> > 
> >
> > `int` is dummy here, right? Mind writing a comment about it?

I changed it to using the `Prefer`, and `LessPrefer` which already exists in 
``. Left a comment to factor these out later.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41461/#review111984
---


On Jan. 6, 2016, 12:55 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41461/
> ---
> 
> (Updated Jan. 6, 2016, 12:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4220
> https://issues.apache.org/jira/browse/MESOS-4220
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::result_of` SFINAE until Update 2, so 
> `result_of` must be replaced with `decltype(invoke)`.
> 
> Here, we implement SFINAE `result_of` in `stout`.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41461/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41454: Added initial draft of executor HTTP API user doc.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41454/#review112982
---

Ship it!


Ship It!

- Vinod Kone


On Jan. 6, 2016, 12:55 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41454/
> ---
> 
> (Updated Jan. 6, 2016, 12:55 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4177
> https://issues.apache.org/jira/browse/MESOS-4177
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is an initial draft for the user doc of Executor HTTP API. Some details 
> might change due to the pending executor library review chain: 
> https://reviews.apache.org/r/41275
> 
> 
> Diffs
> -
> 
>   docs/executor-http-api.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41454/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/d35fdaa667203bf34a78
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41461/
---

(Updated Jan. 6, 2016, 12:55 a.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
Remoortere.


Changes
---

Addressed comments.


Bugs: MESOS-4220
https://issues.apache.org/jira/browse/MESOS-4220


Repository: mesos


Description
---

VS 2015 won't support C++14 `std::result_of` SFINAE until Update 2, so 
`result_of` must be replaced with `decltype(invoke)`.

Here, we implement SFINAE `result_of` in `stout`.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41461/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41454: Added initial draft of executor HTTP API user doc.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41454/
---

(Updated Jan. 6, 2016, 12:55 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4177
https://issues.apache.org/jira/browse/MESOS-4177


Repository: mesos


Description
---

This is an initial draft for the user doc of Executor HTTP API. Some details 
might change due to the pending executor library review chain: 
https://reviews.apache.org/r/41275


Diffs (updated)
-

  docs/executor-http-api.md PRE-CREATION 
  docs/home.md d929838206817a6c49cc2343b4de82fa085da682 

Diff: https://reviews.apache.org/r/41454/diff/


Testing
---

https://gist.github.com/hatred/d35fdaa667203bf34a78


Thanks,

Anand Mazumdar

Re: Review Request 41454: Added initial draft of executor HTTP API user doc.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41454/#review112961
---



docs/executor-http-api.md (line 33)


Can you replace this with:

* **Unacknowledged Tasks**:

The executor is expected to maintain a list of tasks that have not been 
acknowledged by the agent. A task is considered acknowledged if atleast one of 
the status updates for this task is acknowledged by the slave.



docs/executor-http-api.md (line 334)


lets call this

MESOS_RECOVERY_TIMEOUT like what we currently have in the driver. I think 
it makes it obvious that this is the same as --recovery_timeout set on the 
agent.



docs/executor-http-api.md (line 335)


Lets keep the MESOS prefix like you did for all the above. Sorry for the 
run around.

MESOS_SUBSCRIPTION_BACKOFF_MAX


- Vinod Kone


On Jan. 5, 2016, 9:28 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41454/
> ---
> 
> (Updated Jan. 5, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4177
> https://issues.apache.org/jira/browse/MESOS-4177
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is an initial draft for the user doc of Executor HTTP API. Some details 
> might change due to the pending executor library review chain: 
> https://reviews.apache.org/r/41275
> 
> 
> Diffs
> -
> 
>   docs/executor-http-api.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41454/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/d35fdaa667203bf34a78
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41906: Fixed docker containerizer usage to check for cgroup result.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41906/#review112977
---

Ship it!


Ship It!

- Jojy Varghese


On Jan. 5, 2016, 4:47 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41906/
> ---
> 
> (Updated Jan. 5, 2016, 4:47 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Bugs: MESOS-4031
> https://issues.apache.org/jira/browse/MESOS-4031
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed docker containerizer usage to check for cgroup result.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
> 
> Diff: https://reviews.apache.org/r/41906/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41934: Added `DEFAULT_CREDENTIAL_2` to the tests.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41934/#review112976
---

Ship it!


Ship It!

- Jie Yu


On Jan. 5, 2016, 5:34 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41934/
> ---
> 
> (Updated Jan. 5, 2016, 5:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3903
> https://issues.apache.org/jira/browse/MESOS-3903
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `DEFAULT_CREDENTIAL_2` to the tests.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
>   src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 
> 
> Diff: https://reviews.apache.org/r/41934/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This new constant is utilized in the tests included in 
> https://reviews.apache.org/r/41935/
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41935: Added persistent volume HTTP endpoint authorization.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41935/#review112975
---

Ship it!


Ship It!

- Jie Yu


On Jan. 5, 2016, 5:34 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41935/
> ---
> 
> (Updated Jan. 5, 2016, 5:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3903
> https://issues.apache.org/jira/browse/MESOS-3903
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added persistent volume HTTP endpoint authorization.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> c0feedee393b8475fd27b0af9344d306a392893e 
> 
> Diff: https://reviews.apache.org/r/41935/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test.
> 
> New tests were added to the persistent volume endpoint tests which exercise 
> the authorization features in a variety of scenarios.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39923: Cleaned up configuration.md.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review112974
---


This introduces some inconsistencies between the text in `configuration.md` and 
the content of the various `flags.cpp` files (first thing I checked: "api" 
still appears in `src/logging/flags.cpp` but we now use "API" in 
`configuration.md`; likely other instances as well).

- Neil Conway


On Jan. 5, 2016, 7:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated Jan. 5, 2016, 7:53 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, Kapil Arya, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41953: Exposed docker v1/v2 spec protobuf and headers.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41953/#review112973
---

Ship it!


Ship It!

- Timothy Chen


On Jan. 5, 2016, 11:48 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41953/
> ---
> 
> (Updated Jan. 5, 2016, 11:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed docker v1/v2 spec protobuf and headers.
> 
> This will be exposed in ContainerConfig and passed to all isolators so that a 
> docker isolator can properly isolate the runtime based on the image manifest 
> returned from the provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/docker/v1.hpp PRE-CREATION 
>   include/mesos/docker/v2.hpp PRE-CREATION 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/docker/spec.hpp 74968f2e776e52e3225db63c8dbd5b3c88a71c8f 
>   src/docker/v1.hpp b7ec35f409d7b578d58f2150c56ff2e8c949da7c 
>   src/docker/v1.proto  
>   src/docker/v2.hpp 4b14969ff09bc3bd20cda8231e41f170fa52353d 
>   src/docker/v2.proto 5d10bd3a6c077d34dd6921cdfd378b9fafe29a15 
> 
> Diff: https://reviews.apache.org/r/41953/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41954: Renamed `tasks` and `updates` to `unacknowledged_tasks` and `unacknowledged_updates` in executor's Subscribe proto.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41954/#review112972
---

Ship it!


Ship It!

- Anand Mazumdar


On Jan. 6, 2016, 12:14 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41954/
> ---
> 
> (Updated Jan. 6, 2016, 12:14 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Just name change. This make it more obvious what these fields are when 
> executor subscribes.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor/executor.proto 
> 8f97ad8952b3156e9c299a5a297693c8d2ffccd4 
>   include/mesos/v1/executor/executor.proto 
> 7eaa40bf38845befeba477d074396e7660a7b231 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41954/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/#review112971
---


Patch looks great!

Reviews applied: [41002, 41003, 41004, 41061, 4, 41166, 41167, 41169, 
41560, 41294, 41370, 41378, 41779, 41780, 41781, 41782, 41783]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 7:05 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41783/
> ---
> 
> (Updated Jan. 5, 2016, 7:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a non-default ContainerLogger that constrains total log size by rotating 
> logs (i.e. renaming the head log file).
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/rotate.hpp PRE-CREATION 
>   src/slave/container_loggers/rotate.cpp PRE-CREATION 
>   src/slave/container_loggers/rotating.hpp PRE-CREATION 
>   src/slave/container_loggers/rotating.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41783/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 41954: Renamed `tasks` and `updates` to `unacknowledged_tasks` and `unacknowledged_updates` in executor's Subscribe proto.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41954/
---

Review request for mesos and Anand Mazumdar.


Repository: mesos


Description
---

Just name change. This make it more obvious what these fields are when executor 
subscribes.


Diffs
-

  include/mesos/executor/executor.proto 
8f97ad8952b3156e9c299a5a297693c8d2ffccd4 
  include/mesos/v1/executor/executor.proto 
7eaa40bf38845befeba477d074396e7660a7b231 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41954/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 41933: Updated master help message for acls.

[Adam B]

> On Jan. 5, 2016, 4:06 p.m., Adam B wrote:
> > Thanks for noticing and fixing this.
> > - You missed a couple of references in authorization.md as well though. 
> > Could you fix those too?

(probably need a rebase after Greg's recent change to configuration.md)


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41933/#review112966
---


On Jan. 5, 2016, 7:33 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41933/
> ---
> 
> (Updated Jan. 5, 2016, 7:33 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4293
> https://issues.apache.org/jira/browse/MESOS-4293
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The ACL messages now moved from mesos.proto to authorizer.proto,
> the mesos master help message should also be updated to reflect this.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
> 
> Diff: https://reviews.apache.org/r/41933/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41933: Updated master help message for acls.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41933/#review112966
---


Thanks for noticing and fixing this.
- You missed a couple of references in authorization.md as well though. Could 
you fix those too?

- Adam B


On Jan. 5, 2016, 7:33 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41933/
> ---
> 
> (Updated Jan. 5, 2016, 7:33 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4293
> https://issues.apache.org/jira/browse/MESOS-4293
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The ACL messages now moved from mesos.proto to authorizer.proto,
> the mesos master help message should also be updated to reflect this.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
> 
> Diff: https://reviews.apache.org/r/41933/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41952: Added recommendations for programming with persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41952/
---

(Updated Jan. 6, 2016, 12:04 a.m.)


Review request for mesos, Adam B, Jie Yu, Joris Van Remoortere, and Michael 
Park.


Changes
---

Clarify text.


Bugs: MESOS-4209
https://issues.apache.org/jira/browse/MESOS-4209


Repository: mesos


Description
---

Added recommendations for programming with persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 

Diff: https://reviews.apache.org/r/41952/diff/


Testing
---

Previewed with site-docker.


Thanks,

Neil Conway

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/
---

(Updated Jan. 5, 2016, 11:58 p.m.)


Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
Remoortere.


Changes
---

Rebased.


Bugs: MESOS-4221
https://issues.apache.org/jira/browse/MESOS-4221


Repository: mesos


Description
---

VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
converting `_Deferred` to `std::function` must be done by explicitly calling 
`_Deferred`'s conversion function.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs (updated)
-

  3rdparty/libprocess/include/process/future.hpp 
bcb5668565298825056f1b48d48efe12d2e56e7c 

Diff: https://reviews.apache.org/r/41459/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41460/
---

(Updated Jan. 5, 2016, 11:58 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
---

Rebased.


Bugs: MESOS-4228
https://issues.apache.org/jira/browse/MESOS-4228


Repository: mesos


Description
---

The Standard (C++11 through 17) does not require `std::bind`'s function call 
operator to SFINAE, and VS 2015's doesn't. `std::is_bind_expression` can be 
used to manually reroute bind expressions to the 1-arg overload, where 
(conveniently) the argument will be ignored if necessary.

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs (updated)
-

  3rdparty/libprocess/include/process/future.hpp 
bcb5668565298825056f1b48d48efe12d2e56e7c 

Diff: https://reviews.apache.org/r/41460/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41462: libprocess: Used SFINAE-friendly `result_of`.

[Michael Park]

> On Dec. 28, 2015, 5:38 p.m., Alexander Rukletsov wrote:
> > I see some `result_of` in "async.hpp" and "lambda.hpp". Do you want to 
> > update those as well?

Synced with Alex Clemmer and decided to include `async.hpp` changes in this 
patch. I'm planning to remove `lambda::result_of` in a separate patch, since 
`result_of` is not really related to `lambda` anyway.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/#review112021
---


On Jan. 5, 2016, 11:56 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41462/
> ---
> 
> (Updated Jan. 5, 2016, 11:56 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4220
> https://issues.apache.org/jira/browse/MESOS-4220
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used the SFINAE `result_of` implemented in 
> [r41461](https://reviews.apache.org/r/41461/).
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/async.hpp 
> b80b60a7ceb5e87eed8cdab17144ae9617485a04 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41462/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41462: libprocess: Used SFINAE-friendly `result_of`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/
---

(Updated Jan. 5, 2016, 11:56 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
---

Updated `async.hpp`.


Bugs: MESOS-4220
https://issues.apache.org/jira/browse/MESOS-4220


Repository: mesos


Description
---

Used the SFINAE `result_of` implemented in 
[r41461](https://reviews.apache.org/r/41461/).

Follow-up from [r40114](https://reviews.apache.org/r/40114/).


Diffs (updated)
-

  3rdparty/libprocess/include/process/async.hpp 
b80b60a7ceb5e87eed8cdab17144ae9617485a04 
  3rdparty/libprocess/include/process/future.hpp 
bcb5668565298825056f1b48d48efe12d2e56e7c 

Diff: https://reviews.apache.org/r/41462/diff/


Testing
---

`make check` on OS X, compiled on Windows.


Thanks,

Michael Park

Re: Review Request 41648: Used initializer list c-tor for brevity.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/#review112962
---

Ship it!


Ship It!

- Cong Wang


On Jan. 5, 2016, 11:45 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41648/
> ---
> 
> (Updated Jan. 5, 2016, 11:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used initializer list c-tor for brevity.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
> 
> Diff: https://reviews.apache.org/r/41648/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 41953: Exposed docker v1/v2 spec protobuf and headers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41953/
---

Review request for mesos, Gilbert Song and Timothy Chen.


Repository: mesos


Description
---

Exposed docker v1/v2 spec protobuf and headers.

This will be exposed in ContainerConfig and passed to all isolators so that a 
docker isolator can properly isolate the runtime based on the image manifest 
returned from the provisioner.


Diffs
-

  include/mesos/docker/v1.hpp PRE-CREATION 
  include/mesos/docker/v2.hpp PRE-CREATION 
  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/docker/spec.hpp 74968f2e776e52e3225db63c8dbd5b3c88a71c8f 
  src/docker/v1.hpp b7ec35f409d7b578d58f2150c56ff2e8c949da7c 
  src/docker/v1.proto  
  src/docker/v2.hpp 4b14969ff09bc3bd20cda8231e41f170fa52353d 
  src/docker/v2.proto 5d10bd3a6c077d34dd6921cdfd378b9fafe29a15 

Diff: https://reviews.apache.org/r/41953/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 41952: Added recommendations for programming with persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41952/
---

Review request for mesos, Adam B, Jie Yu, Joris Van Remoortere, and Michael 
Park.


Bugs: MESOS-4209
https://issues.apache.org/jira/browse/MESOS-4209


Repository: mesos


Description
---

Added recommendations for programming with persistent volumes.


Diffs
-

  docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 

Diff: https://reviews.apache.org/r/41952/diff/


Testing
---

Previewed with site-docker.


Thanks,

Neil Conway

Review Request 41950: Cleaned up hierarchical allocator tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41950/
---

Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Repository: mesos


Description
---

Changes made:
- empty resource map promoted to a const class field;
- removed variable numeric suffixes where appropriate;
- added const where appropriate.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
e044f832c2c16e53e663c6ced5452649bb0dcb59 

Diff: https://reviews.apache.org/r/41950/diff/


Testing
---

`make check` on Mac OS 10.10.5


Thanks,

Alexander Rukletsov

Re: Review Request 41648: Used initializer list c-tor for brevity.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/
---

(Updated Jan. 5, 2016, 11:45 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
---

Rebased.


Repository: mesos


Description
---

Used initializer list c-tor for brevity.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 

Diff: https://reviews.apache.org/r/41648/diff/


Testing
---

`make check` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov

Review Request 41949: Replaced `QuotaInfo` with `Quota` in allocator.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41949/
---

Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-3979
https://issues.apache.org/jira/browse/MESOS-3979


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
  src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 
  src/tests/hierarchical_allocator_tests.cpp 
e044f832c2c16e53e663c6ced5452649bb0dcb59 
  src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 

Diff: https://reviews.apache.org/r/41949/diff/


Testing
---

`make check` on Mac OS 10.10.5


Thanks,

Alexander Rukletsov

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > I assume you've gotten all of them?

I've gotten all of the ones in `Future`. I think as they work through rest of 
the codebase, there may be more contexts in which this comes up.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review112481
---


On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> ---
> 
> (Updated Dec. 28, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4221
> https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
> converting `_Deferred` to `std::function` must be done by explicitly calling 
> `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 
> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

[Michael Park]

> On Dec. 28, 2015, 11:31 p.m., Daniel Pravat wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 347
> > 
> >
> > Other similar constructs will be converted when the code using them 
> > will compile on Windows.

Sorry, I don't think I understand what this means. Could you elaborate/clarify?


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review112086
---


On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> ---
> 
> (Updated Dec. 28, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4221
> https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so 
> converting `_Deferred` to `std::function` must be done by explicitly calling 
> `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c 
> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41938: Cleaned up quota tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41938/
---

(Updated Jan. 5, 2016, 11:39 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
---

Cleaned up registrar tests as well.


Repository: mesos


Description
---

Changes made:
  - removed extra ';' in resources string;
  - renamed variables for clarity;
  - updated comments;
  - removed explicit conversion to `Resources`;
  - wrapped test cases in {} blocks.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
  src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 

Diff: https://reviews.apache.org/r/41938/diff/


Testing
---

`make check` on Mac OS 10.10.5


Thanks,

Alexander Rukletsov

Re: Review Request 41939: Simplified quota tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41939/
---

(Updated Jan. 5, 2016, 11:39 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
---

Rebased.


Repository: mesos


Description
---

For clarity and in order not to distract a reader with copy-paste code:
  - some tests were merged together;
  - removed creation of agents where possible and used force flag
in quota request instead.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 

Diff: https://reviews.apache.org/r/41939/diff/


Testing
---

`make check` on Mac OS 10.10.5


Thanks,

Alexander Rukletsov

Review Request 41947: Changed signature of `QuotaInfo` validation.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41947/
---

Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-4058
https://issues.apache.org/jira/browse/MESOS-4058


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/quota.hpp 7a728e3d2e66c4d0fd3b5dbf0fdc854363bae53e 
  src/master/quota.cpp df2cc5877160df101222756739f042895ceacc95 
  src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498 

Diff: https://reviews.apache.org/r/41947/diff/


Testing
---

`make check` on Mac OS 10.10.5


Thanks,

Alexander Rukletsov

Review Request 41948: Ensured `QuotaInfo` is valid in registrar tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41948/
---

Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-4058
https://issues.apache.org/jira/browse/MESOS-4058


Repository: mesos


Description
---

Resources in `QuotaInfo` protobuf must not specify role, hence
remove all occurrences of `flatten()` and add explicit validation.


Diffs
-

  src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 

Diff: https://reviews.apache.org/r/41948/diff/


Testing
---

`make check` on Mac OS 10.10.5


Thanks,

Alexander Rukletsov

Re: Review Request 39805: Moved filesystems tests to their own file.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39805/
---

(Updated Jan. 5, 2016, 11:21 p.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Moved filesystems tests to their own file.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
5ab7bc4966fe32eaddd573a4dbfd997f98b5d481 
  3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 
3cff837886d94d623c732371380f1c62750022f4 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
62ad461eb228b688f1ceac16cfb003561ed5a806 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
e0a898d91e3521d4b228621a81412e1dd5ddf63d 

Diff: https://reviews.apache.org/r/39805/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Yi Sun]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review112953
---

Ship it!


Ship It!

- Yi Sun


On Jan. 5, 2016, 11:04 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> ---
> 
> (Updated Jan. 5, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::rmdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> e738cdbf5846950c475c159fb9a770acc45159f5 
> 
> Diff: https://reviews.apache.org/r/39584/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 41945: Fixed remaining flakiness in MasterMaintenanceTest.InverseOffersFilters.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41945/#review112952
---

Ship it!


Ship It!

- Ben Mahler


On Jan. 5, 2016, 9:23 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41945/
> ---
> 
> (Updated Jan. 5, 2016, 9:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4059
> https://issues.apache.org/jira/browse/MESOS-4059
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There were three inverse offer updates in the test body, but only two 
> `FUTURE_DISPATCH` expectations on `updateInverseOffer`.  This patch adds the 
> missing `FUTURE_DISPATCH` after the first inverse offer update.
> 
> Prior to this change, the first `FUTURE_DISPATCH` was expected to correspond 
> to the second inverse offer.  In some cases, the first inverse offer would 
> trigger the expectation instead (and/or the test would reach the 
> `Clock::settle()` prior to one of the `Call` 's reaching the master).
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 2ca1e878254ec411220226e5d0ed48d6ae54a0db 
> 
> Diff: https://reviews.apache.org/r/41945/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX & Centos7)
> 
> # Run 8 instances of `openssl speed` somewhere else on the computer.
> # Then:
> bin/mesos-test.sh --gtest_filter="*InverseOffersFilters*" --gtest_repeat=5000 
> --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/
---

(Updated Jan. 5, 2016, 11:10 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
Remoortere.


Changes
---

Fix typo.


Bugs: MESOS-3936
https://issues.apache.org/jira/browse/MESOS-3936


Repository: mesos


Description
---

Added guide to writing highly available Mesos frameworks.


Diffs (updated)
-

  docs/app-framework-development-guide.md 
4a43a93d080bdac37b8aee91748fea7552a1cc67 
  docs/high-availability-framework-guide.md PRE-CREATION 
  docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
  docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 

Diff: https://reviews.apache.org/r/41896/diff/


Testing
---

Previewed via site-docker.

Note that there's a lot more that could be said here; also, at some point we 
should probably unify the "reconciliation" page with this page, and perhaps 
move some of the content in the "high-availability" page here (leaving the 
"high-availability" page for the operator-centric parts of configuring Mesos to 
run in HA mode).


Thanks,

Neil Conway

Re: Review Request 40429: Report executor exit to framework schedulers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review112951
---


Patch looks great!

Reviews applied: [40429]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 7:01 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Jan. 5, 2016, 7:01 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 2aa083c85ae2a2f1392121b1d30d71376c01ffd7 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/upgrades.md aebdc1e1b7a73c93b5a14867214eb852de89ad24 
>   include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
>   src/java/src/org/apache/mesos/Scheduler.java 
> 4f048830a2c47f747033c60730cc770cb2578815 
>   src/python/interface/src/mesos/interface/__init__.py 
> 4be502fd83029ad5fc798696caf9e27fd95f7482 
>   src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
>   src/tests/fault_tolerance_tests.cpp 
> ba657d0e1d8515cffd1b37925bf91a84b2feaef1 
>   src/tests/gc_tests.cpp f939d27c58177fba052fbcd9d6c9a572d052df52 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 9afa826006fa7129da1a9c1ac8c389c0e051f717 
>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/scheduler_event_call_tests.cpp 
> 03f0332ef75bbe7c4947bd6daf55d40384570f18 
>   src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/
---

(Updated Jan. 5, 2016, 11:06 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
Remoortere.


Changes
---

Address TODO, add a bit more text.


Bugs: MESOS-3936
https://issues.apache.org/jira/browse/MESOS-3936


Repository: mesos


Description
---

Added guide to writing highly available Mesos frameworks.


Diffs (updated)
-

  docs/app-framework-development-guide.md 
4a43a93d080bdac37b8aee91748fea7552a1cc67 
  docs/high-availability-framework-guide.md PRE-CREATION 
  docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
  docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 

Diff: https://reviews.apache.org/r/41896/diff/


Testing
---

Previewed via site-docker.

Note that there's a lot more that could be said here; also, at some point we 
should probably unify the "reconciliation" page with this page, and perhaps 
move some of the content in the "high-availability" page here (leaving the 
"high-availability" page for the operator-centric parts of configuring Mesos to 
run in HA mode).


Thanks,

Neil Conway

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/
---

(Updated Jan. 5, 2016, 11:04 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented `os::rmdir.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
e738cdbf5846950c475c159fb9a770acc45159f5 

Diff: https://reviews.apache.org/r/39584/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/
---

(Updated Jan. 5, 2016, 10:43 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
Remoortere.


Changes
---

Various improvements.


Bugs: MESOS-3936
https://issues.apache.org/jira/browse/MESOS-3936


Repository: mesos


Description
---

Added guide to writing highly available Mesos frameworks.


Diffs (updated)
-

  docs/app-framework-development-guide.md 
4a43a93d080bdac37b8aee91748fea7552a1cc67 
  docs/high-availability-framework-guide.md PRE-CREATION 
  docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
  docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 

Diff: https://reviews.apache.org/r/41896/diff/


Testing
---

Previewed via site-docker.

Note that there's a lot more that could be said here; also, at some point we 
should probably unify the "reconciliation" page with this page, and perhaps 
move some of the content in the "high-availability" page here (leaving the 
"high-availability" page for the operator-centric parts of configuring Mesos to 
run in HA mode).


Thanks,

Neil Conway

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

[Michael Park]

> On Dec. 21, 2015, 5:04 a.m., Michael Park wrote:
> > src/master/http.cpp, lines 134-150
> > 
> >
> > @benh: How does this pattern look to you? If you're ok with it, we 
> > should find a better home for it. Otherwise, we should talk about what we 
> > want to adopt as the pattern.

Introduced `Representation` to stout and used it here instead.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41595/#review111439
---


On Jan. 5, 2016, 10:39 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41595/
> ---
> 
> (Updated Jan. 5, 2016, 10:39 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 4f4cbf6e53588b72204f9628dea5696c71eb66a5 
>   src/common/http.cpp 7165551321bedb8a4d711a64d0d6d8fd15215424 
>   src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
> 
> Diff: https://reviews.apache.org/r/41595/diff/
> 
> 
> Testing
> ---
> 
> # Some preliminery numbers
> 
> These numbers are from my Ubuntu VM on my Mac OS X with @vinodkone's 
> benchmark test: [r40844](https://reviews.apache.org/r/40844/).
> 
> ### Before
> 
> ```
> [==] Running 36 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 36 tests from SlaveAndFrameworkCount/MasterState_BENCHMARK_Test
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0
> Added 1000 slaves and 1 frameworks
> Received state.json response in 683.138216ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0 (1436 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1
> Added 1000 slaves and 50 frameworks
> Received state.json response in 550.636939ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1 (1474 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2
> Added 1000 slaves and 100 frameworks
> Received state.json response in 632.835236ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2 (1491 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3
> Added 1000 slaves and 200 frameworks
> Received state.json response in 584.035771ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3 (1431 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4
> Added 1000 slaves and 500 frameworks
> Received state.json response in 688.404348ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4 (1586 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5
> Added 1000 slaves and 1000 frameworks
> Received state.json response in 666.713683ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5 (1590 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6
> Added 5000 slaves and 1 frameworks
> Received state.json response in 3.916201532secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6 (7852 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7
> Added 5000 slaves and 50 frameworks
> Received state.json response in 3.362618796secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7 (8315 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8
> Added 5000 slaves and 100 frameworks
> Received state.json response in 3.126815189secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8 (7153 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9
> Added 5000 slaves and 200 frameworks
> Received state.json response in 3.079956539secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9 (7534 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10
> Added 5000 slaves and 500 frameworks
> Received state.json response in 3.222014521secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10 (8129 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11
> Added 5000 slaves and 1000 frameworks
> Received state.json response in 3.286657158secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11 (8133 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12
> Added 1 slaves and 1 frameworks
> Received state.json response in 7.332592151secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12 
> (15639 m

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41595/
---

(Updated Jan. 5, 2016, 10:39 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Used `Representation`.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/common/http.hpp 4f4cbf6e53588b72204f9628dea5696c71eb66a5 
  src/common/http.cpp 7165551321bedb8a4d711a64d0d6d8fd15215424 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 

Diff: https://reviews.apache.org/r/41595/diff/


Testing
---

# Some preliminery numbers

These numbers are from my Ubuntu VM on my Mac OS X with @vinodkone's benchmark 
test: [r40844](https://reviews.apache.org/r/40844/).

### Before

```
[==] Running 36 tests from 1 test case.
[--] Global test environment set-up.
[--] 36 tests from SlaveAndFrameworkCount/MasterState_BENCHMARK_Test
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0
Added 1000 slaves and 1 frameworks
Received state.json response in 683.138216ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0 (1436 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1
Added 1000 slaves and 50 frameworks
Received state.json response in 550.636939ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1 (1474 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2
Added 1000 slaves and 100 frameworks
Received state.json response in 632.835236ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2 (1491 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3
Added 1000 slaves and 200 frameworks
Received state.json response in 584.035771ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3 (1431 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4
Added 1000 slaves and 500 frameworks
Received state.json response in 688.404348ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4 (1586 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5
Added 1000 slaves and 1000 frameworks
Received state.json response in 666.713683ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5 (1590 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6
Added 5000 slaves and 1 frameworks
Received state.json response in 3.916201532secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6 (7852 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7
Added 5000 slaves and 50 frameworks
Received state.json response in 3.362618796secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7 (8315 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8
Added 5000 slaves and 100 frameworks
Received state.json response in 3.126815189secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8 (7153 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9
Added 5000 slaves and 200 frameworks
Received state.json response in 3.079956539secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9 (7534 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10
Added 5000 slaves and 500 frameworks
Received state.json response in 3.222014521secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10 (8129 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11
Added 5000 slaves and 1000 frameworks
Received state.json response in 3.286657158secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11 (8133 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12
Added 1 slaves and 1 frameworks
Received state.json response in 7.332592151secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12 (15639 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/13
Added 1 slaves and 50 frameworks
Received state.json response in 6.998751033secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/13 (17175 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/14
Added 1 slaves and 100 frameworks
Received state.json response in 6.807456891secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/14 (15974 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/15
Added 1 slaves and 200 frameworks
Received state.json response in 6.371190971secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/15 (15772 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/16
Added 1 slaves and 500 frameworks
Received state.json response in 6.613739531secs
[   OK ] Sla

Review Request 41946: Added a `Representation` abstraction to stout.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41946/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41946/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 41593: Added `jsonify` function to stout.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/
---

(Updated Jan. 5, 2016, 10:38 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
5ab7bc4966fe32eaddd573a4dbfd997f98b5d481 
  3rdparty/libprocess/3rdparty/stout/README.md 
a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
98ea47794b3a7c99b3cbd2418ba6e36eb5951259 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
62ad461eb228b688f1ceac16cfb003561ed5a806 
  3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0 

Diff: https://reviews.apache.org/r/41593/diff/


Testing (updated)
---

Added tests to ``


Thanks,

Michael Park

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review112944
---


Patch looks great!

Reviews applied: [40539, 37999, 38000, 38094, 38950, 39043]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 4:20 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Jan. 5, 2016, 4:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
>   src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498 
>   src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 41945: Fixed remaining flakiness in MasterMaintenanceTest.InverseOffersFilters.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41945/#review112940
---

Ship it!


LGTM !

- Anand Mazumdar


On Jan. 5, 2016, 9:23 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41945/
> ---
> 
> (Updated Jan. 5, 2016, 9:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4059
> https://issues.apache.org/jira/browse/MESOS-4059
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There were three inverse offer updates in the test body, but only two 
> `FUTURE_DISPATCH` expectations on `updateInverseOffer`.  This patch adds the 
> missing `FUTURE_DISPATCH` after the first inverse offer update.
> 
> Prior to this change, the first `FUTURE_DISPATCH` was expected to correspond 
> to the second inverse offer.  In some cases, the first inverse offer would 
> trigger the expectation instead (and/or the test would reach the 
> `Clock::settle()` prior to one of the `Call` 's reaching the master).
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 2ca1e878254ec411220226e5d0ed48d6ae54a0db 
> 
> Diff: https://reviews.apache.org/r/41945/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX & Centos7)
> 
> # Run 8 instances of `openssl speed` somewhere else on the computer.
> # Then:
> bin/mesos-test.sh --gtest_filter="*InverseOffersFilters*" --gtest_repeat=5000 
> --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41939: Simplified quota tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41939/#review112932
---


Patch looks great!

Reviews applied: [41936, 41937, 41938, 41939]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 6:09 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41939/
> ---
> 
> (Updated Jan. 5, 2016, 6:09 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For clarity and in order not to distract a reader with copy-paste code:
>   - some tests were merged together;
>   - removed creation of agents where possible and used force flag
> in quota request instead.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
> 
> Diff: https://reviews.apache.org/r/41939/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.5
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41454: Added initial draft of executor HTTP API user doc.

[Anand Mazumdar]

> On Jan. 5, 2016, 12:20 a.m., Vinod Kone wrote:
> > docs/executor-http-api.md, lines 52-70
> > 
> >
> > looking at just the JSON, it's not very clear that `tasks` and 
> > `updates` correspond to unacknowledged tasks and updates. we should 
> > probably rename these fields as `unacknowledged_tasks` and 
> > `unacknowledged_updates`. what do you think?

sgtm, modified the name of the fields as per our discussion.


> On Jan. 5, 2016, 12:20 a.m., Vinod Kone wrote:
> > docs/executor-http-api.md, line 131
> > 
> >
> > Is the retry by executor necessary? The current driver doesn't do 
> > retries for example. Are you anticipating a scenario where the executor is 
> > connected but messages are lost?

My bad, Fixed. This got copied over verbatim from the corresponding scheduler 
docs.


> On Jan. 5, 2016, 12:20 a.m., Vinod Kone wrote:
> > docs/executor-http-api.md, line 343
> > 
> >
> > what's the relation between MESOS_RETRY_INTERVAL_MAX and the duration 
> > after which the agent deems recovery process complete 
> > (EXECUTOR_REREGISTER_TIMEOUT)? AFAICT, currently the former is set to 15 
> > min and the latter is 2s.

As per our discussion, I modified the name of the variable to 
`EXECUTOR_REGISTRATION_BACKOFF_MAX`. This variable is equal in value to 
`EXECUTOR_REREGISTER_TIMEOUT`. 

It essentially denotes that upon agent recovery, the agent would wait for 
`EXECUTOR_REREGISTER_TIMEOUT` before killing the executor and marking the 
recovery process as complete. Hence, the executor should retry atleast once 
within `EXECUTOR_REGISTRATION_BACKOFF_MAX` to avoid being killed.

Also, let me know if this new name looks good to you.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41454/#review112636
---


On Jan. 5, 2016, 9:28 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41454/
> ---
> 
> (Updated Jan. 5, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4177
> https://issues.apache.org/jira/browse/MESOS-4177
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is an initial draft for the user doc of Executor HTTP API. Some details 
> might change due to the pending executor library review chain: 
> https://reviews.apache.org/r/41275
> 
> 
> Diffs
> -
> 
>   docs/executor-http-api.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41454/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/d35fdaa667203bf34a78
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41454: Added initial draft of executor HTTP API user doc.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41454/
---

(Updated Jan. 5, 2016, 9:28 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4177
https://issues.apache.org/jira/browse/MESOS-4177


Repository: mesos


Description
---

This is an initial draft for the user doc of Executor HTTP API. Some details 
might change due to the pending executor library review chain: 
https://reviews.apache.org/r/41275


Diffs (updated)
-

  docs/executor-http-api.md PRE-CREATION 
  docs/home.md d929838206817a6c49cc2343b4de82fa085da682 

Diff: https://reviews.apache.org/r/41454/diff/


Testing
---

https://gist.github.com/hatred/d35fdaa667203bf34a78


Thanks,

Anand Mazumdar

Review Request 41945: Fixed remaining flakiness in MasterMaintenanceTest.InverseOffersFilters.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41945/
---

Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van 
Remoortere.


Bugs: MESOS-4059
https://issues.apache.org/jira/browse/MESOS-4059


Repository: mesos


Description
---

There were three inverse offer updates in the test body, but only two 
`FUTURE_DISPATCH` expectations on `updateInverseOffer`.  This patch adds the 
missing `FUTURE_DISPATCH` after the first inverse offer update.

Prior to this change, the first `FUTURE_DISPATCH` was expected to correspond to 
the second inverse offer.  In some cases, the first inverse offer would trigger 
the expectation instead (and/or the test would reach the `Clock::settle()` 
prior to one of the `Call` 's reaching the master).


Diffs
-

  src/tests/master_maintenance_tests.cpp 
2ca1e878254ec411220226e5d0ed48d6ae54a0db 

Diff: https://reviews.apache.org/r/41945/diff/


Testing
---

make check (OSX & Centos7)

# Run 8 instances of `openssl speed` somewhere else on the computer.
# Then:
bin/mesos-test.sh --gtest_filter="*InverseOffersFilters*" --gtest_repeat=5000 
--gtest_break_on_failure


Thanks,

Joseph Wu

Re: Review Request 41593: Added `jsonify` function to stout.

[Michael Park]

> On Jan. 5, 2016, 9:28 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 107
> > 
> >
> > Here and in all dtrs below: Given that we don't know whether exceptions 
> > are enabled for `stream` (this is stout), could we wrap this in a `try` 
> > block?, e.g., imagine an underlying `fstream` becoming `bad` because there 
> > is no space left on the device.

Hm... that's a good point. I'm not particularly worried about it for our use 
case since we don't use exception-enabled streams but it is an issue in the 
general case. One approach would be to make it a requirement that the stream 
not be exception-enabled (We can `CHECK` this on construction). If we were to 
wrap it in a `try` block, the best we can do is swallow the exception with no 
way to propagate the information which is generally a bad idea...


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/#review112802
---


On Jan. 5, 2016, 10:20 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41593/
> ---
> 
> (Updated Jan. 5, 2016, 10:20 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 5ab7bc4966fe32eaddd573a4dbfd997f98b5d481 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 62ad461eb228b688f1ceac16cfb003561ed5a806 
>   3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0 
> 
> Diff: https://reviews.apache.org/r/41593/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41593: Added `jsonify` function to stout.

[Michael Park]

> On Jan. 5, 2016, 2:56 p.m., Alexander Rojas wrote:
> > Pretty clever code, it would be nice if some of the techniques were at 
> > least explained in a blog post with a link in the code. I'm mostly 
> > concerend about the use of C++17 functions (`std::rank`). Does that mean we 
> > are pumping the minimum required version for the compiler? otherwise, could 
> > we investigate the compiler and/or stdlib support?

Yeah, perhaps we should write a blog post. `std::rank` in specific is a C++11 
feature. Which other ones are you concerned about?


> On Jan. 5, 2016, 2:56 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 561
> > 
> >
> > Doesn't the `std::result_of` has the same problem in windows as when 
> > used in `Future`?

Yeah, it does. But since we're blocked on other reviewers for that one, I'm 
planning to follow-up and update whichever one gets committed later.
I think changes are, this one will get committed first and I'll follow-up to 
use `` when it gets committed.


> On Jan. 5, 2016, 2:56 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 368-371
> > 
> >
> > I have a couple of questions here:
> > 
> > 1. Why do you use a `U&`.
> > 2. Can you add a comment on how this work, it is definitely not clear 
> > for even an intermediate level C++ programmer.

1. We're checking the conditions for a range-for loop. The `begin` and `end` 
are called on lvalue arguments, rather than r-value arguments (if you're asking 
why not `std::declval()`) and they are not necessarily called on 
const-lvalue arguments (if you're asking why not `std::declval()`). 
Having said that, it would have been more accurate for me to use 
`IsSequence` below at the call-site.
2. Yep, I can add more comments.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/#review112845
---


On Jan. 5, 2016, 10:20 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41593/
> ---
> 
> (Updated Jan. 5, 2016, 10:20 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 5ab7bc4966fe32eaddd573a4dbfd997f98b5d481 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 62ad461eb228b688f1ceac16cfb003561ed5a806 
>   3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0 
> 
> Diff: https://reviews.apache.org/r/41593/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41935: Added persistent volume HTTP endpoint authorization.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41935/#review112924
---


Patch looks great!

Reviews applied: [41934, 41935]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 5:34 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41935/
> ---
> 
> (Updated Jan. 5, 2016, 5:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3903
> https://issues.apache.org/jira/browse/MESOS-3903
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added persistent volume HTTP endpoint authorization.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> c0feedee393b8475fd27b0af9344d306a392893e 
> 
> Diff: https://reviews.apache.org/r/41935/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test.
> 
> New tests were added to the persistent volume endpoint tests which exercise 
> the authorization features in a variety of scenarios.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>