Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Kevin Klues]

> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote:
> > docs/home.md, line 12
> > 
> >
> > FYI: The links from 
> > http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't 
> > seem to work for me... e.g.
> > http://c99.millennium.berkeley.edu/documentation/latest/version/
> 
> Kevin Klues wrote:
> I don't know how you generated the link for: 
> http://c99.millennium.berkeley.edu/documentation/latest/version/
> It should be 
> http://c99.millennium.berkeley.edu/documentation/latest/version/endpoints/version
> which is correct on the site.
> 
> Joerg Schad wrote:
> That is the link which I get from 
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints for version.

Strange...

With:
http://c99.millennium.berkeley.edu/documentation/latest/endpoints
I get the same as you.

But with:
http://c99.millennium.berkeley.edu/documentation/latest/endpoints/
(notice the / at the end) I get the correct links

Will look into it.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
---


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42186/#review116556
---



Patch looks great!

Reviews applied: [42181, 42843, 42844, 42185, 42186]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 4:14 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42186/
> ---
> 
> (Updated Jan. 27, 2016, 4:14 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 
> 
> Diff: https://reviews.apache.org/r/42186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42516: Add support for user-defined networks.

[Ezra Silvera]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/
---

(Updated Jan. 27, 2016, 7:05 a.m.)


Review request for mesos and TimothyIL TimothyIL.


Changes
---

fix type smpty-->empty


Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369


Repository: mesos


Description
---

Signed-off-by: Ezra Silvera 


Diffs (updated)
-

  include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
  include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
  src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 

Diff: https://reviews.apache.org/r/42516/diff/


Testing
---

Using Swarm running on Mesos create a network with "docker  network create 
--driver=bridge myNetwork"   and then create a container on that network:  
"docker run --net=myNetwork"


Thanks,

Ezra Silvera

Re: Review Request 42516: Add support for user-defined networks.

[Ezra Silvera]

> On Jan. 24, 2016, 6:58 a.m., Shuai Lin wrote:
> > src/docker/docker.cpp, line 519
> > 
> >
> > typo, s/sempty/empty :)

good catch. thanks :-)


- Ezra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review116010
---


On Jan. 24, 2016, 6:42 a.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated Jan. 24, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos and TimothyIL TimothyIL.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Joerg Schad]

> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote:
> > docs/home.md, line 12
> > 
> >
> > FYI: The links from 
> > http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't 
> > seem to work for me... e.g.
> > http://c99.millennium.berkeley.edu/documentation/latest/version/
> 
> Kevin Klues wrote:
> I don't know how you generated the link for: 
> http://c99.millennium.berkeley.edu/documentation/latest/version/
> It should be 
> http://c99.millennium.berkeley.edu/documentation/latest/version/endpoints/version
> which is correct on the site.

That is the link which I get from 
http://c99.millennium.berkeley.edu/documentation/latest/endpoints for version.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
---


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Joerg Schad]

> On Jan. 26, 2016, 8:44 a.m., Joerg Schad wrote:
> > docs/home.md, line 17
> > 
> >
> > With https://issues.apache.org/jira/browse/MESOS-4295 we changed the 
> > link structure [label](file.md). I.e. s/endpoints/ /endpoints.md
> 
> Kevin Klues wrote:
> Even if there is no endpoints.md file?  It is a folder with a bunch of 
> .md files inside of it.

I see.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116327
---


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116547
---



Patch looks great!

Reviews applied: [42696]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 3:04 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 27, 2016, 3:04 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42685: Added roles validation to master.

[Qian Zhang]

> On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote:
> > src/master/master.cpp, lines 1980-1983
> > 
> >
> > This should probably be replaced with `strings::join("'", 
> > frameworkInfo.roles())` which could be used directly when creating the 
> > `Error` below.
> 
> Benjamin Bannier wrote:
> I meant `strings::join(",", frameworkInfo.roles())` of course, sorry.

Agree and fixed, thanks Ben!


> On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote:
> > src/master/master.cpp, lines 2250-2253
> > 
> >
> > Use `strings::join`, w/o introducing a named var.

Agree and fixed, thanks Ben!


> On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote:
> > src/tests/role_tests.cpp, lines 97-98
> > 
> >
> > This constructor seems to be deprecated (even though it is used above). 
> > Instead you should be able to use
> > 
> > MesosSchedulerDriver driver(
> > &sched, frameworkInfo, master.get(), false);

Agree and fixed, thanks Ben!


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42685/#review116243
---


On Jan. 27, 2016, 1:26 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42685/
> ---
> 
> (Updated Jan. 27, 2016, 1:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Bugs: MESOS-4364
> https://issues.apache.org/jira/browse/MESOS-4364
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validated either role or roles in FrameworkInfo can be set,
> but never both.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
> 
> Diff: https://reviews.apache.org/r/42685/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 42685: Added roles validation to master.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42685/
---

(Updated Jan. 27, 2016, 1:26 p.m.)


Review request for mesos, Benjamin Bannier and Vinod Kone.


Bugs: MESOS-4364
https://issues.apache.org/jira/browse/MESOS-4364


Repository: mesos


Description
---

Validated either role or roles in FrameworkInfo can be set,
but never both.


Diffs (updated)
-

  src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 

Diff: https://reviews.apache.org/r/42685/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 42806: Added the fetcher plugin module interface.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/#review116537
---



Patch looks great!

Reviews applied: [42806]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 2:55 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42806/
> ---
> 
> (Updated Jan. 27, 2016, 2:55 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3926
> https://issues.apache.org/jira/browse/MESOS-3926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the fetcher plugin module interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/fetcher_plugin.hpp PRE-CREATION 
>   src/Makefile.am bdb34020043f64c07721b3e8b29b221e5b99 
>   src/examples/test_fetcher_plugin_module.cpp PRE-CREATION 
>   src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 
>   src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
>   src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b 
> 
> Diff: https://reviews.apache.org/r/42806/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42836: Quota: Only used scalars for lay-away calculations.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42836/#review116533
---


Ship it!




Ship It!

- Michael Park


On Jan. 27, 2016, 4:04 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42836/
> ---
> 
> (Updated Jan. 27, 2016, 4:04 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4505
> https://issues.apache.org/jira/browse/MESOS-4505
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also used cached values from update sorter API.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
> 
> Diff: https://reviews.apache.org/r/42836/diff/
> 
> 
> Testing
> ---
> 
> make check
> callgrind with optimized build
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 42844: Drop `404 NotFound` responses in the executor library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42844/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

Previously, we did not use to drop `404 NotFound` responses in the library and 
send `Event::Error` to executor. However, this can be trigerred upon an agent 
restart when it has not yet set up HTTP routes.


Diffs
-

  src/executor/executor.cpp 92334ffb8af83b1c86c44bd406147893c7c6daa3 

Diff: https://reviews.apache.org/r/42844/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42186/
---

(Updated Jan. 27, 2016, 4:14 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added another test for recovery mode `cleanup`


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 

Diff: https://reviews.apache.org/r/42186/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42185: Added an example executor based on the new V1 API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42185/
---

(Updated Jan. 27, 2016, 4:13 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Modified the example executor to retry `Subscribe` calls.


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

This change adds a custom executor based on the new executor library.


Diffs (updated)
-

  src/Makefile.am bdb34020043f64c07721b3e8b29b221e5b99 
  src/examples/test_http_executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/42185/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 42843: Ensure `ServiceUnavailable` is not received for `Subscribe` calls.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42843/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

The agent does not return an `ServiceUnavailable` response for `Subscribe` 
calls. Added a `CHECK` to ensure this.


Diffs
-

  src/executor/executor.cpp 92334ffb8af83b1c86c44bd406147893c7c6daa3 

Diff: https://reviews.apache.org/r/42843/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42836: Quota: Only used scalars for lay-away calculations.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42836/
---

(Updated Jan. 27, 2016, 4:04 a.m.)


Review request for mesos and Michael Park.


Changes
---

simplified arithmetic.


Bugs: MESOS-4505
https://issues.apache.org/jira/browse/MESOS-4505


Repository: mesos


Description
---

Also used cached values from update sorter API.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42836/diff/


Testing
---

make check
callgrind with optimized build


Thanks,

Joris Van Remoortere

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[haosdent huang]

> On Jan. 26, 2016, 9:18 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 196
> > 
> >
> > Good idea, but then we need to set checkpointing to true for the 
> > recovery test below.

@bernd, thank you very much. Could you help review again?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116330
---


On Jan. 27, 2016, 3:04 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 27, 2016, 3:04 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42835: Updated the allocator to not offer unreserved resources beyond quota.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42835/#review116528
---



Patch looks great!

Reviews applied: [42711, 42738, 42834, 42739, 42741, 42835]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 1:31 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42835/
> ---
> 
> (Updated Jan. 27, 2016, 1:31 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Eventually, we will also want to offer unreserved resources as revocable 
> beyond
> the role's quota. In the short term, we do not offer unreserved, non-revocable
> resources beyond a role's quota.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42835/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

(Updated Jan. 27, 2016, 3:04 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Address @bernd's comments.


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test cases.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 

Diff: https://reviews.apache.org/r/42696/diff/


Testing (updated)
---

Before apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2524 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
```


After apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (873 ms)
[   OK ] FetcherCacheTest.LocalCached (1609 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
```

Also test the recovery test manually:

```
sudo ./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Re: Review Request 42754: Added support for labels to resource reservations.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/#review116526
---




src/tests/resources_tests.cpp (line 1714)


Just a nit, do we really need update here? I think that this case was 
already covered in `SubtractionWithDistinctLabels`


- Guangya Liu


On 一月 26, 2016, 6:34 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42754/
> ---
> 
> (Updated 一月 26, 2016, 6:34 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4479
> https://issues.apache.org/jira/browse/MESOS-4479
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Labels are free-form key-value pairs that can be used to associate
> metadata with reserved resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a54411 
>   include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
>   include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
>   src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
>   src/v1/mesos.cpp 9264752c6b82eaa844ce356b879f92d562ed4e45 
>   src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 
> 
> Diff: https://reviews.apache.org/r/42754/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42806: Added the fetcher plugin module interface.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/
---

(Updated Jan. 27, 2016, 2:55 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Install fetcher_plugin.hpp as module header files


Bugs: MESOS-3926
https://issues.apache.org/jira/browse/MESOS-3926


Repository: mesos


Description
---

Added the fetcher plugin module interface.


Diffs (updated)
-

  include/mesos/module/fetcher_plugin.hpp PRE-CREATION 
  src/Makefile.am bdb34020043f64c07721b3e8b29b221e5b99 
  src/examples/test_fetcher_plugin_module.cpp PRE-CREATION 
  src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 
  src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b 

Diff: https://reviews.apache.org/r/42806/diff/


Testing
---

make check


Thanks,

Shuai Lin

Re: Review Request 42837: Ignored MOUNT type disk for disk quota enforcement.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42837/#review116525
---



Patch looks great!

Reviews applied: [42837]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 1:23 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42837/
> ---
> 
> (Updated Jan. 27, 2016, 1:23 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4506
> https://issues.apache.org/jira/browse/MESOS-4506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored MOUNT type disk for disk quota enforcement.
> 
> For MOUNT type disk, the quota should be enforced by the underlying fs 
> isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 5ed93534330567bbac965faf53feb105045ef390 
> 
> Diff: https://reviews.apache.org/r/42837/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42754: Added support for labels to resource reservations.

[Guangya Liu]

> On 一月 26, 2016, 8:03 a.m., Guangya Liu wrote:
> > src/tests/reservation_endpoints_tests.cpp, line 782
> > 
> >
> > why does the offerResources contain the labeledResources2? The 
> > labeledResources2 should be filtered when allocate?
> 
> Neil Conway wrote:
> Sorry, I'm not sure what you mean. Can you clarify?

This is just a question and want to get some cofirmation from you, we can take 
a look at the scenario for the test case:
1) Created two reservations with labels (1,512) with label1 and label2.
2) Allocate this resources in one offer
3) deline this offer with 1000
4) unreserve resources with label1
5) The filter will not take effect because resources does not match, so here 
will still offer unreserved (1, 512) and reserved (1, 512) with label2.

yes, your case is right.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/#review116304
---


On 一月 26, 2016, 6:34 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42754/
> ---
> 
> (Updated 一月 26, 2016, 6:34 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4479
> https://issues.apache.org/jira/browse/MESOS-4479
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Labels are free-form key-value pairs that can be used to associate
> metadata with reserved resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a54411 
>   include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
>   include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
>   src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
>   src/v1/mesos.cpp 9264752c6b82eaa844ce356b879f92d562ed4e45 
>   src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 
> 
> Diff: https://reviews.apache.org/r/42754/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42792: Fix compile error in container logger tests.

[Joseph Wu]

> On Jan. 26, 2016, 11:33 a.m., Joseph Wu wrote:
> > Sorry about that.  Till already committed an identical patch.  
> > https://reviews.apache.org/r/42803/
> 
> Jian Qiu wrote:
> Thanks for doing this. There is also a race in DefaultToSandbox when it 
> runs on ubuntu. Sometimes it cannot read string from stdout. We may need to 
> wait until task finished. Mind taking a look at it?

Sure.  Here's the patch, in case its blocking you: 
https://reviews.apache.org/r/42842/


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42792/#review116427
---


On Jan. 26, 2016, 12:12 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42792/
> ---
> 
> (Updated Jan. 26, 2016, 12:12 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-4508
> https://issues.apache.org/jira/browse/MESOS-4508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use unsigned value when comparing with kilobytes.
> 
> 
> Diffs
> -
> 
>   src/tests/container_logger_tests.cpp 
> ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 
> 
> Diff: https://reviews.apache.org/r/42792/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX and Ubuntu 15.04
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Klaus Ma]

> On Jan. 26, 2016, 3:05 p.m., Klaus Ma wrote:
> > I agree to include `reserved` reosurces in DRF; but just one question, why 
> > are we going to have this patch now?
> 
> Qian Zhang wrote:
> My understanding is, we are going to include reserved resources in the 
> fairness calculation the role sorter gradually in 2 phases.
> Phase 1 (this patch): Only include the allocated portion of reserved 
> resources.
> Phase 2: Include the whole reserved resources regardless they are 
> allocated or not.
> I think that's why there is a TODO added in this patch.
> 
> Joris Van Remoortere wrote:
> That's right!

Thanks Qian/Joris, that's what we are going to do; I'd like to know why we did 
not include `reserved` resources before but include it by those patches. When I 
was drafting the idea of MESOS-4303, it confused me that why we did not include 
`reserved` resources in DRF.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/#review116296
---


On Jan. 27, 2016, 7:14 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42711/
> ---
> 
> (Updated Jan. 27, 2016, 7:14 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2d01034f43c3653f6233792ee6614fa311249e5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42711/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42836: Quota: Only used scalars for lay-away calculations.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42836/#review116512
---




src/master/allocator/mesos/hierarchical.cpp (lines 1275 - 1281)


Can we test to see what the perf is like if we were to do:

```cpp
Resources remainingClusterResources = roleSorter->totalScalars();
foreachkey (const string& role, activeRoles) {
  remainingClusterResources -= roleSorter->allocationScalars(role);
}
```


- Michael Park


On Jan. 27, 2016, 1:16 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42836/
> ---
> 
> (Updated Jan. 27, 2016, 1:16 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4505
> https://issues.apache.org/jira/browse/MESOS-4505
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also used cached values from update sorter API.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
> 
> Diff: https://reviews.apache.org/r/42836/diff/
> 
> 
> Testing
> ---
> 
> make check
> callgrind with optimized build
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 42792: Fix compile error in container logger tests.

[Jian Qiu]

> On 一月 26, 2016, 7:33 p.m., Joseph Wu wrote:
> > Sorry about that.  Till already committed an identical patch.  
> > https://reviews.apache.org/r/42803/

Thanks for doing this. There is also a race in DefaultToSandbox when it runs on 
ubuntu. Sometimes it cannot read string from stdout. We may need to wait until 
task finished. Mind taking a look at it?


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42792/#review116427
---


On 一月 26, 2016, 8:12 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42792/
> ---
> 
> (Updated 一月 26, 2016, 8:12 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-4508
> https://issues.apache.org/jira/browse/MESOS-4508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use unsigned value when comparing with kilobytes.
> 
> 
> Diffs
> -
> 
>   src/tests/container_logger_tests.cpp 
> ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 
> 
> Diff: https://reviews.apache.org/r/42792/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX and Ubuntu 15.04
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42810: Added the CgroupInfo protobuf.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/#review116511
---




include/mesos/v1/mesos.proto (line 1533)


Could you please make it nested in CgroupInfo?


- Jie Yu


On Jan. 26, 2016, 10:05 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42810/
> ---
> 
> (Updated Jan. 26, 2016, 10:05 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4488
> https://issues.apache.org/jira/browse/MESOS-4488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the CgroupInfo protobuf. The agent can use this message to reflect any 
> cgroup configuration that might have been applied to a container.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
>   include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd 
> 
> Diff: https://reviews.apache.org/r/42810/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42835: Updated the allocator to not offer unreserved resources beyond quota.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42835/
---

(Updated Jan. 27, 2016, 1:31 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Joris' comments.


Repository: mesos


Description
---

Eventually, we will also want to offer unreserved resources as revocable beyond
the role's quota. In the short term, we do not offer unreserved, non-revocable
resources beyond a role's quota.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42835/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42741: Included reserved resources in stage 1 of allocation.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42741/#review116493
---


Ship it!




- Joris Van Remoortere


On Jan. 26, 2016, 10:10 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42741/
> ---
> 
> (Updated Jan. 26, 2016, 10:10 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
> 
> Diff: https://reviews.apache.org/r/42741/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42739: Accounted for reserved resources in the quota guarantee check.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42739/#review116492
---


Ship it!




- Joris Van Remoortere


On Jan. 27, 2016, 12:16 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42739/
> ---
> 
> (Updated Jan. 27, 2016, 12:16 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42739/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42834: Added more getters to the `Sorter`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42834/#review116490
---


Ship it!




- Joris Van Remoortere


On Jan. 27, 2016, 12:15 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42834/
> ---
> 
> (Updated Jan. 27, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds the following getters:
>   - `total` (similar to `allocation`)
>   - `allocationScalars`
>   - `totalScalars`
> 
> The scalar versions are necessary to improve perf of the allocator.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 050896e8b12cd4097ccd137d5284d6b39b0f06ab 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 3a442f121f3a1505513877a5c78458a4b8d0a824 
>   src/master/allocator/sorter/sorter.hpp 
> 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
> 
> Diff: https://reviews.apache.org/r/42834/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42837: Ignored MOUNT type disk for disk quota enforcement.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42837/#review116510
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 27, 2016, 1:23 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42837/
> ---
> 
> (Updated Jan. 27, 2016, 1:23 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4506
> https://issues.apache.org/jira/browse/MESOS-4506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored MOUNT type disk for disk quota enforcement.
> 
> For MOUNT type disk, the quota should be enforced by the underlying fs 
> isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 5ed93534330567bbac965faf53feb105045ef390 
> 
> Diff: https://reviews.apache.org/r/42837/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42835: Updated the allocator to not offer unreserved resources beyond quota.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42835/#review116508
---


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.cpp (line 1344)


of the allocation algorithm in stage 1.



src/tests/hierarchical_allocator_tests.cpp (lines 1808 - 1809)


according to the DRF algorithm for non-quota'd frameworks.

?


- Joris Van Remoortere


On Jan. 27, 2016, 1:20 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42835/
> ---
> 
> (Updated Jan. 27, 2016, 1:20 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Eventually, we will also want to offer unreserved resources as revocable 
> beyond
> the role's quota. In the short term, we do not offer unreserved, non-revocable
> resources beyond a role's quota.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42835/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 42837: Ignored MOUNT type disk for disk quota enforcement.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42837/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4506
https://issues.apache.org/jira/browse/MESOS-4506


Repository: mesos


Description
---

Ignored MOUNT type disk for disk quota enforcement.

For MOUNT type disk, the quota should be enforced by the underlying fs isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
5ed93534330567bbac965faf53feb105045ef390 

Diff: https://reviews.apache.org/r/42837/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 42835: Updated the allocator to not offer unreserved resources beyond quota.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42835/
---

(Updated Jan. 27, 2016, 1:20 a.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Eventually, we will also want to offer unreserved resources as revocable beyond
the role's quota. In the short term, we do not offer unreserved, non-revocable
resources beyond a role's quota.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42835/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42183: Introduced HttpEvent based filters in libprocess.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/#review116507
---


Ship it!




Ship It!

- Vinod Kone


On Jan. 27, 2016, 1:17 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42183/
> ---
> 
> (Updated Jan. 27, 2016, 1:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4425
> https://issues.apache.org/jira/browse/MESOS-4425
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces the ability to filter `HTTPEvent` in libprocess 
> similar to the already existing `MessageEvent` and `DispatchEvent`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gmock.hpp 
> 53fdb15ef8d0c6bb95a974be416ce1922a211064 
> 
> Diff: https://reviews.apache.org/r/42183/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42183: Introduced HttpEvent based filters in libprocess.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/
---

(Updated Jan. 27, 2016, 1:17 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comment from Vinod


Bugs: MESOS-4425
https://issues.apache.org/jira/browse/MESOS-4425


Repository: mesos


Description
---

This change introduces the ability to filter `HTTPEvent` in libprocess similar 
to the already existing `MessageEvent` and `DispatchEvent`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/gmock.hpp 
53fdb15ef8d0c6bb95a974be416ce1922a211064 

Diff: https://reviews.apache.org/r/42183/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42184: Introduced `FUTURE_HTTP_*` for filtering HTTP based events.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42184/
---

(Updated Jan. 27, 2016, 1:17 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4425
https://issues.apache.org/jira/browse/MESOS-4425


Repository: mesos


Description
---

This change introduces `FUTURE_HTTP_*` for filtering HTTP based events similar 
to the already existing filters for Messages/Dispatch events. Also, added 
`FUTURE_HTTP_CALL_*` for union based protobufs.


Diffs (updated)
-

  src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 

Diff: https://reviews.apache.org/r/42184/diff/


Testing (updated)
---

make check + added tests in r42186 for testing recovery of HTTP based executors.


Thanks,

Anand Mazumdar

Review Request 42836: Quota: Only used scalars for lay-away calculations.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42836/
---

Review request for mesos and Michael Park.


Bugs: MESOS-4505
https://issues.apache.org/jira/browse/MESOS-4505


Repository: mesos


Description
---

Also used cached values from update sorter API.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42836/diff/


Testing
---

make check
callgrind with optimized build


Thanks,

Joris Van Remoortere

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42828/#review116506
---



Patch looks great!

Reviews applied: [42828]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 10:14 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42828/
> ---
> 
> (Updated Jan. 26, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-1469 and MESOS-4478
> https://issues.apache.org/jira/browse/MESOS-1469
> https://issues.apache.org/jira/browse/MESOS-4478
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fixes 2 issues
> 
> 1) Stream output to the console when build is in progress. 
> https://issues.apache.org/jira/browse/MESOS-1469
> 
> 2) Make sure the full build output (and not just truncated build output) is 
> output to the console. This was a bug introduced while fixing 
> https://issues.apache.org/jira/browse/MESOS-4478
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 
> 
> Diff: https://reviews.apache.org/r/42828/diff/
> 
> 
> Testing
> ---
> 
> ?  mesos git:(vinod/review_bot_tee_output) 
> BUILD_URL=https://builds.apache.org/job/mesos-reviewbot/10980/ 
> ./support/verify_reviews.py vinod kone 1
> git rev-parse HEAD
> Checking if review: 41092 needs verification
> Latest diff timestamp: 2016-01-26 13:53:35
> Verifying review 41092
> Dependent review: https://reviews.apache.org/api/review-requests/41090/ 
> Dependent review: https://reviews.apache.org/api/review-requests/40951/ 
> Applying review 41092
> ./support/apply-review.sh -n -r 41092
> + : ubuntu:14.04
> + : gcc
> + : --verbose
> +++ dirname ./support/docker_build.sh
> ++ cd ./support/..
> ++ pwd
> + MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
> + cd /Users/vinodkone/workspace/mesos
> + DOCKERFILE=Dockerfile
> + rm -f Dockerfile
> + case $OS in
> + append_dockerfile 'FROM ubuntu:14.04'
> + echo FROM ubuntu:14.04
> + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
> + echo RUN rm -rf '/var/lib/apt/lists/*'
> + append_dockerfile 'RUN apt-get update'
> + echo RUN apt-get update
> + append_dockerfile 'RUN apt-get -y install build-essential clang git maven 
> autoconf libtool'
> + echo RUN apt-get -y install build-essential clang git maven autoconf libtool
> + append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev 
> python-boto libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev 
> libev-dev'
> + echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto 
> libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev
> + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
> + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
> + append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead'
> + echo ENV GTEST_FILTER -FsTest.FileSystemTableRead
> + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml'
> + echo ENV GTEST_OUTPUT xml:report.xml
> + case $COMPILER in
> + append_dockerfile 'ENV CC gcc'
> + echo ENV CC gcc
> + append_dockerfile 'ENV CXX g++'
> + echo ENV CXX g++
> + append_dockerfile 'WORKDIR mesos'
> + echo WORKDIR mesos
> + append_dockerfile 'COPY . /mesos/'
> + echo COPY . /mesos/
> + append_dockerfile 'RUN chown -R mesos /mesos'
> + echo RUN chown -R mesos /mesos
> + append_dockerfile 'USER mesos'
> + echo USER mesos
> + append_dockerfile 'CMD ./bootstrap && ./configure --verbose && 
> DISTCHECK_CONFIGURE_FLAGS="--verbose" GLOG_v=1 MESOS_VERBOSE=1 make -j8 
> distcheck'
> + echo CMD ./bootstrap '&&' ./configure --verbose '&&' 
> 'DISTCHECK_CONFIGURE_FLAGS="--verbose"' GLOG_v=1 MESOS_VERBOSE=1 make -j8 
> distcheck
> ++ date +%s
> + TAG=mesos-1453845969-21946
> + docker build --no-cache=true -t mesos-1453845969-21946 .
> ./support/docker_build.sh: line 117: docker: command not found
> Posting review: Bad patch!
> 
> Reviews applied: [40951, 41090, 41092]
> 
> Failed command: ['bash', '-c', 'set -o pipefail; export 
> OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; 
> ./support/docker_build.sh 2>&1 | tee build_41092']
> 
> Error:
>  ..
> + : ubuntu:14.04
> + : gcc
> + : --verbose
> +++ dirname ./support/docker_build.sh
> ++ cd ./support/..
> ++ pwd
> + MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
> + cd /Users/vinodkone/workspace/mesos
> + DOCKERFILE=Dockerfile
> + rm -f Dockerfile
> + case $OS in
> + append_dockerfile 'FROM ubuntu:14.04'
> + echo FROM ubuntu:14.04
> + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
> + echo RUN rm -rf '/var/lib/apt/lists/*'
> + append_dockerfi

Review Request 42835: Updated the allocator to not offer unreserved resources beyond quota.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42835/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Eventually, we will also want to offer unreserved resources as revocable beyond
the role's quota. In the short term, we do not offer unreserved, non-revocable
resources beyond a role's quota.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42835/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apach

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review116503
---


Fix it, then Ship it!




Based on how we'd like to address the floating point behavior in the 
short-term, this will be a useful test to add.


src/tests/reservation_tests.cpp (line 173)


Whitespace.



src/tests/reservation_tests.cpp (line 181)


This shouldn't be necessary now that we have implicit roles.


- Neil Conway


On Jan. 20, 2016, 6:08 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> ---
> 
> (Updated Jan. 20, 2016, 6:08 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a fixture to test the floating point precision during CPU resource 
> allocation. This patch is based on the commit submitted by : Mandeep 
> (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> ---
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Kevin Klues]

> On Jan. 26, 2016, 8:44 a.m., Joerg Schad wrote:
> > docs/home.md, line 17
> > 
> >
> > With https://issues.apache.org/jira/browse/MESOS-4295 we changed the 
> > link structure [label](file.md). I.e. s/endpoints/ /endpoints.md

Even if there is no endpoints.md file?  It is a folder with a bunch of .md 
files inside of it.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116327
---


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Kevin Klues]

> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote:
> > docs/home.md, line 12
> > 
> >
> > FYI: The links from 
> > http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't 
> > seem to work for me... e.g.
> > http://c99.millennium.berkeley.edu/documentation/latest/version/

I don't know how you generated the link for: 
http://c99.millennium.berkeley.edu/documentation/latest/version/
It should be 
http://c99.millennium.berkeley.edu/documentation/latest/version/endpoints/version
which is correct on the site.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
---


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116499
---




docs/home.md (line 17)


Should capitalize "HTTP" (both times).


- Neil Conway


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Joris Van Remoortere]

> On Jan. 26, 2016, 7:05 a.m., Klaus Ma wrote:
> > I agree to include `reserved` reosurces in DRF; but just one question, why 
> > are we going to have this patch now?
> 
> Qian Zhang wrote:
> My understanding is, we are going to include reserved resources in the 
> fairness calculation the role sorter gradually in 2 phases.
> Phase 1 (this patch): Only include the allocated portion of reserved 
> resources.
> Phase 2: Include the whole reserved resources regardless they are 
> allocated or not.
> I think that's why there is a TODO added in this patch.

That's right!


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/#review116296
---


On Jan. 26, 2016, 11:14 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42711/
> ---
> 
> (Updated Jan. 26, 2016, 11:14 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2d01034f43c3653f6233792ee6614fa311249e5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42711/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Qian Zhang]

> On Jan. 26, 2016, 3:05 p.m., Klaus Ma wrote:
> > I agree to include `reserved` reosurces in DRF; but just one question, why 
> > are we going to have this patch now?

My understanding is, we are going to include reserved resources in the fairness 
calculation the role sorter gradually in 2 phases.
Phase 1 (this patch): Only include the allocated portion of reserved resources.
Phase 2: Include the whole reserved resources regardless they are allocated or 
not.
I think that's why there is a TODO added in this patch.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/#review116296
---


On Jan. 27, 2016, 7:14 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42711/
> ---
> 
> (Updated Jan. 27, 2016, 7:14 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2d01034f43c3653f6233792ee6614fa311249e5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42711/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42739: Accounted for reserved resources in the quota guarantee check.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42739/
---

(Updated Jan. 27, 2016, 12:16 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Joris' comment.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42739/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42810: Added the CgroupInfo protobuf.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/#review116487
---



Patch looks great!

Reviews applied: [42810]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 10:05 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42810/
> ---
> 
> (Updated Jan. 26, 2016, 10:05 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4488
> https://issues.apache.org/jira/browse/MESOS-4488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the CgroupInfo protobuf. The agent can use this message to reflect any 
> cgroup configuration that might have been applied to a container.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
>   include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd 
> 
> Diff: https://reviews.apache.org/r/42810/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 42834: Added more getters to the `Sorter`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42834/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

This patch adds the following getters:
  - `total` (similar to `allocation`)
  - `allocationScalars`
  - `totalScalars`

The scalar versions are necessary to improve perf of the allocator.


Diffs
-

  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 

Diff: https://reviews.apache.org/r/42834/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42739: Accounted for reserved resources in the quota guarantee check.

[Michael Park]

> On Jan. 26, 2016, 8:06 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1153-1157
> > 
> >
> > Can we use `flatten`? And add helper functions to clearup disk?

I think with the introduction of other types of `*Info` messages being added to 
`Resource` and such, we'll have to figure out a long-term plan for how we want 
to address the various types of resources. I saw that there are patches out to 
add helpers such as `flattenDisk`, but we might want to move to using 
`removeDisk`, etc for example.

Within this context we also don't want to be creating new `Resources` 
instances, which `flatten` does, since we're in a critical path in terms of 
perf implications.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42739/#review116315
---


On Jan. 26, 2016, 11:01 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42739/
> ---
> 
> (Updated Jan. 26, 2016, 11:01 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42739/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/#review116484
---


Ship it!




Ship It!

- Benjamin Hindman


On Jan. 26, 2016, 11:45 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42820/
> ---
> 
> (Updated Jan. 26, 2016, 11:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4515
> https://issues.apache.org/jira/browse/MESOS-4515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `logrotate --version` flag is actually a very recent addition (3.9.1).  
> The `--help` flag is more likely to be present on a supported 
> system-with-logrotate, given logrotate's usage of popopt.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
>   src/slave/container_loggers/logrotate.hpp 
> fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 
> 
> Diff: https://reviews.apache.org/r/42820/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX & Centos6.7 & Centos7)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42477: Corrected example in quota user doc.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42477/#review116483
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 22, 2016, 3:43 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42477/
> ---
> 
> (Updated Jan. 22, 2016, 3:43 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
> 
> Diff: https://reviews.apache.org/r/42477/diff/
> 
> 
> Testing
> ---
> 
> None: Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42476: Introduced protobuf for set quota requests.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/#review116482
---


Fix it, then Ship it!





src/master/quota.cpp (lines 94 - 95)


Wrapping.


- Joris Van Remoortere


On Jan. 26, 2016, 8:48 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> ---
> 
> (Updated Jan. 26, 2016, 8:48 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
> Van Remoortere.
> 
> 
> Bugs: MESOS-4410
> https://issues.apache.org/jira/browse/MESOS-4410
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
>   src/master/quota.hpp 9ac390777946047978a00aa59082e78ce3997441 
>   src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 
>   src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
>   src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
>   src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 
> 
> Diff: https://reviews.apache.org/r/42476/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/
---

(Updated Jan. 26, 2016, 3:45 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Changes
---

Changed back to the --help version (diff #1).


Summary (updated)
-

Fixed logrotate ContainerLogger on Centos6.


Bugs: MESOS-4515
https://issues.apache.org/jira/browse/MESOS-4515


Repository: mesos


Description (updated)
---

The `logrotate --version` flag is actually a very recent addition (3.9.1).  
The `--help` flag is more likely to be present on a supported 
system-with-logrotate, given logrotate's usage of popopt.


Diffs (updated)
-

  src/slave/container_loggers/lib_logrotate.hpp 
5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
  src/slave/container_loggers/logrotate.hpp 
fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 

Diff: https://reviews.apache.org/r/42820/diff/


Testing
---

make check (OSX & Centos6.7 & Centos7)


Thanks,

Joseph Wu

Re: Review Request 42183: Introduced HttpEvent based filters in libprocess.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/#review116480
---




3rdparty/libprocess/include/process/gmock.hpp (line 369)


Use the same/similar comment as at #331.


- Vinod Kone


On Jan. 22, 2016, 8:24 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42183/
> ---
> 
> (Updated Jan. 22, 2016, 8:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4425
> https://issues.apache.org/jira/browse/MESOS-4425
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces the ability to filter `HTTPEvent` in libprocess 
> similar to the already existing `MessageEvent` and `DispatchEvent`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gmock.hpp 
> 53fdb15ef8d0c6bb95a974be416ce1922a211064 
> 
> Diff: https://reviews.apache.org/r/42183/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42184: Introduced `FUTURE_HTTP_*` for filtering HTTP based events.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42184/#review116481
---


Fix it, then Ship it!





src/tests/mesos.hpp (line 1511)


why do you need a default?



src/tests/mesos.hpp (line 1532)


why do you need a default?



src/tests/mesos.hpp (line 1582)


ditto. why default?



src/tests/mesos.hpp (line 1600)


why default?



src/tests/mesos.hpp (line 1638)


ditto.



src/tests/mesos.hpp (line 1656)


ditto.


- Vinod Kone


On Jan. 22, 2016, 8:17 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42184/
> ---
> 
> (Updated Jan. 22, 2016, 8:17 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4425
> https://issues.apache.org/jira/browse/MESOS-4425
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces `FUTURE_HTTP_*` for filtering HTTP based events 
> similar to the already existing filters for Messages/Dispatch events. Also, 
> added `FUTURE_HTTP_CALL_*` for union based protobufs.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
> 
> Diff: https://reviews.apache.org/r/42184/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41292: Corrected `Event::Error` documentation for the HTTP Scheduler API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41292/#review116479
---


Ship it!




Ship It!

- Vinod Kone


On Dec. 12, 2015, 12:02 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41292/
> ---
> 
> (Updated Dec. 12, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 7d5322e8a34efd223bed745b58371ef819dbd9ec 
>   include/mesos/v1/scheduler/scheduler.proto 
> 6b40910006c93318638ef07b39564e0b65f0 
> 
> Diff: https://reviews.apache.org/r/41292/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42738: Included reserved resources in the quota role sorter for DRF.

[Michael Park]

> On Jan. 26, 2016, 7:34 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1195
> > 
> >
> > And another question: which resources should be used firstly, 
> > `reserved` or `unreserved`? If `reserved` > `Quota`, should be also assign 
> > `unreserved` resources to it?
> > 
> > My suggestion is to allocate `reserved` resource as `Quota` firstly, 
> > then assign `Quota` for `unreserved`, the latest action is DRF for other 
> > `unreserved` resources. Any comments?
> 
> Joris Van Remoortere wrote:
> Why do we need to add an extra level here?
> If we account `reserved` resources towards quota (see subsequent 
> patches), then we would only allocate `unreserved` resources if `quota` > 
> `reserved`.
> 
> Klaus Ma wrote:
> I'm OK if we have handled such cases :). Let me go through all patches.

I think that the following TODO will address this issue.

```
  // TODO(mpark): Reserved resources should be accounted for fairness
  // calculation whether they are allocated or not, since they model a long or
  // forever running task. That is, the effect of reserving resources is
  // equivalent to launching a task in that the resources that make up the
  // reservation are not available to other roles as non-revocable.
```

However, let's continue the discussion outside of this review.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/#review116306
---


On Jan. 26, 2016, 11:04 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42738/
> ---
> 
> (Updated Jan. 26, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2d01034f43c3653f6233792ee6614fa311249e5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
> 
> Diff: https://reviews.apache.org/r/42738/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/
---

(Updated Jan. 26, 2016, 11:14 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Joris' comment.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42711/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 42821: Cleaned up namespace-qualified identifiers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42821/#review116473
---



Patch looks great!

Reviews applied: [42477, 42476, 42821]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 8:48 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42821/
> ---
> 
> (Updated Jan. 26, 2016, 8:48 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 
> 
> Diff: https://reviews.apache.org/r/42821/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42738: Included reserved resources in the quota role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/
---

(Updated Jan. 26, 2016, 11:04 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42738/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42738: Included reserved resources in the quota role sorter for DRF.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/#review116470
---


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.cpp (lines 1353 - 1358)


You moved this to the header so we can take it out here.


- Joris Van Remoortere


On Jan. 26, 2016, 10:29 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42738/
> ---
> 
> (Updated Jan. 26, 2016, 10:29 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2d01034f43c3653f6233792ee6614fa311249e5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
> 
> Diff: https://reviews.apache.org/r/42738/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42739: Accounted for reserved resources in the quota guarantee check.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42739/
---

(Updated Jan. 26, 2016, 11:01 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Joris' comment.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42739/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42820: Relaxed the logrotate ContainerLogger's --logrotate_path validation.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/
---

(Updated Jan. 26, 2016, 3:01 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Changes
---

Relax the check on `--logrotate_path` and changed to an Option.


Summary (updated)
-

Relaxed the logrotate ContainerLogger's --logrotate_path validation.


Bugs: MESOS-4515
https://issues.apache.org/jira/browse/MESOS-4515


Repository: mesos


Description (updated)
---

The `logrotate --version` flag is actually a very recent addition (3.9.1).  As 
such, most `logrotate` binaries may not have the flag.

Changed the `--logrotate_path` validation to take an Option instead.
If specified, checks if the path is absolute and that it is executable.
If not specified, checks if logrotate exists.


Diffs (updated)
-

  src/slave/container_loggers/lib_logrotate.hpp 
5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
  src/slave/container_loggers/logrotate.hpp 
fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 

Diff: https://reviews.apache.org/r/42820/diff/


Testing (updated)
---

make check (OSX & Centos6.7 & Centos7)


Thanks,

Joseph Wu

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/#review116468
---




src/master/allocator/mesos/hierarchical.hpp (lines 400 - 402)


That is, the effect of reserving resources is equivalent to launching a 
task in that the resources that make up the reservation are not available to 
other roles as non-revocable.


- Joris Van Remoortere


On Jan. 26, 2016, 10:34 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42711/
> ---
> 
> (Updated Jan. 26, 2016, 10:34 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2d01034f43c3653f6233792ee6614fa311249e5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42711/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/#review116466
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 288)


Nit-pick: Replace `Setting ... . Neither` with `This has an effect only for 
child processes launched after calling setPaths; neither`.


- Benjamin Bannier


On Jan. 26, 2016, 8:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39782/
> ---
> 
> (Updated Jan. 26, 2016, 8:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3725
> https://issues.apache.org/jira/browse/MESOS-3725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a comment for os::libraries::setPaths.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> ed3bb2c5ab035d8c0bbf9f44baa2b0b8fb1f79b6 
> 
> Diff: https://reviews.apache.org/r/39782/diff/
> 
> 
> Testing
> ---
> 
> No code changes.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39781/#review116465
---


Fix it, then Ship it!





src/tests/module_tests.cpp (line 167)


Drop unnecessary parentheses.


- Benjamin Bannier


On Jan. 26, 2016, 8:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39781/
> ---
> 
> (Updated Jan. 26, 2016, 8:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3725
> https://issues.apache.org/jira/browse/MESOS-3725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update ModuleTest to not assume dynamic dlopen search.
> 
> 
> Diffs
> -
> 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
> 
> Diff: https://reviews.apache.org/r/39781/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39780/#review116467
---


Ship it!




- Benjamin Bannier


On Jan. 26, 2016, 8:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39780/
> ---
> 
> (Updated Jan. 26, 2016, 8:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3725
> https://issues.apache.org/jira/browse/MESOS-3725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update OversubscriptionTest to not assume dynamic dlopen search.
> 
> 
> Diffs
> -
> 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
> 
> Diff: https://reviews.apache.org/r/39780/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6.

[Joseph Wu]

> On Jan. 26, 2016, 1:13 p.m., Anand Mazumdar wrote:
> > src/slave/container_loggers/lib_logrotate.hpp, line 104
> > 
> >
> > hmmm .. why can't we just use `os::access` here to find out if we have 
> > permissions to read the file?

Sounds reasonable.  I'll relax the check so that its easier to drop in a script 
replacement (i.e. something that wraps `logrotate`).


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/#review116450
---


On Jan. 26, 2016, 12:36 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42820/
> ---
> 
> (Updated Jan. 26, 2016, 12:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4515
> https://issues.apache.org/jira/browse/MESOS-4515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `logrotate --version` flag is actually a very recent addition (3.9.1).  
> The `--help` flag is more likely to be present on a supported 
> system-with-logrotate, given logrotate's usage of popopt.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
>   src/slave/container_loggers/logrotate.hpp 
> fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 
> 
> Diff: https://reviews.apache.org/r/42820/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX & Centos6
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Michael Park]

> On Jan. 26, 2016, 1:37 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 402
> > 
> >
> > s/oversubscription/revocable since MESOS-1607 introducing allocation 
> > slack and we have two kinds of revocable resources for now: usage slack and 
> > allocation slack

I've updated this to say:

```
... the effect of reserving resources is equivalent to launching
a task in that those non-revocable resources are not available to
other roles.
```


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/#review116249
---


On Jan. 26, 2016, 10:34 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42711/
> ---
> 
> (Updated Jan. 26, 2016, 10:34 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2d01034f43c3653f6233792ee6614fa311249e5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42711/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/
---

(Updated Jan. 26, 2016, 10:34 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Guangya's comment.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42711/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 42738: Included reserved resources in the quota role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/
---

(Updated Jan. 26, 2016, 10:29 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Joris' comments.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42738/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/#review116459
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 26, 2016, 9:56 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42711/
> ---
> 
> (Updated Jan. 26, 2016, 9:56 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2d01034f43c3653f6233792ee6614fa311249e5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42711/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/
---

(Updated Jan. 26, 2016, 10:29 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description
---

This change introduces the implementation for the executor library. 

This uses the new HTTP Connection interface to ensure calls are properly 
pipelined. 

`connected` -> Callback invoked when a TCP connection is established with the 
agent for the Subscribe call.
`disconnected` -> When the Subscribe TCP connection is interrupted possibly due 
to an agent restart.
`received` -> When the executor receives events from the agent upon subscribing.


Diffs (updated)
-

  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/executor/executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41283/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 42828: Updated ReviewBot to tee build output to a file.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42828/
---

Review request for mesos and Michael Park.


Bugs: MESOS-1469 and MESOS-4478
https://issues.apache.org/jira/browse/MESOS-1469
https://issues.apache.org/jira/browse/MESOS-4478


Repository: mesos


Description
---

This fixes 2 issues

1) Stream output to the console when build is in progress. 
https://issues.apache.org/jira/browse/MESOS-1469

2) Make sure the full build output (and not just truncated build output) is 
output to the console. This was a bug introduced while fixing 
https://issues.apache.org/jira/browse/MESOS-4478


Diffs
-

  support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 

Diff: https://reviews.apache.org/r/42828/diff/


Testing
---

?  mesos git:(vinod/review_bot_tee_output) 
BUILD_URL=https://builds.apache.org/job/mesos-reviewbot/10980/ 
./support/verify_reviews.py vinod kone 1
git rev-parse HEAD
Checking if review: 41092 needs verification
Latest diff timestamp: 2016-01-26 13:53:35
Verifying review 41092
Dependent review: https://reviews.apache.org/api/review-requests/41090/ 
Dependent review: https://reviews.apache.org/api/review-requests/40951/ 
Applying review 41092
./support/apply-review.sh -n -r 41092
+ : ubuntu:14.04
+ : gcc
+ : --verbose
+++ dirname ./support/docker_build.sh
++ cd ./support/..
++ pwd
+ MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
+ cd /Users/vinodkone/workspace/mesos
+ DOCKERFILE=Dockerfile
+ rm -f Dockerfile
+ case $OS in
+ append_dockerfile 'FROM ubuntu:14.04'
+ echo FROM ubuntu:14.04
+ append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
+ echo RUN rm -rf '/var/lib/apt/lists/*'
+ append_dockerfile 'RUN apt-get update'
+ echo RUN apt-get update
+ append_dockerfile 'RUN apt-get -y install build-essential clang git maven 
autoconf libtool'
+ echo RUN apt-get -y install build-essential clang git maven autoconf libtool
+ append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev 
python-boto libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev 
libev-dev'
+ echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto 
libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev
+ append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
+ echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
+ append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead'
+ echo ENV GTEST_FILTER -FsTest.FileSystemTableRead
+ append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml'
+ echo ENV GTEST_OUTPUT xml:report.xml
+ case $COMPILER in
+ append_dockerfile 'ENV CC gcc'
+ echo ENV CC gcc
+ append_dockerfile 'ENV CXX g++'
+ echo ENV CXX g++
+ append_dockerfile 'WORKDIR mesos'
+ echo WORKDIR mesos
+ append_dockerfile 'COPY . /mesos/'
+ echo COPY . /mesos/
+ append_dockerfile 'RUN chown -R mesos /mesos'
+ echo RUN chown -R mesos /mesos
+ append_dockerfile 'USER mesos'
+ echo USER mesos
+ append_dockerfile 'CMD ./bootstrap && ./configure --verbose && 
DISTCHECK_CONFIGURE_FLAGS="--verbose" GLOG_v=1 MESOS_VERBOSE=1 make -j8 
distcheck'
+ echo CMD ./bootstrap '&&' ./configure --verbose '&&' 
'DISTCHECK_CONFIGURE_FLAGS="--verbose"' GLOG_v=1 MESOS_VERBOSE=1 make -j8 
distcheck
++ date +%s
+ TAG=mesos-1453845969-21946
+ docker build --no-cache=true -t mesos-1453845969-21946 .
./support/docker_build.sh: line 117: docker: command not found
Posting review: Bad patch!

Reviews applied: [40951, 41090, 41092]

Failed command: ['bash', '-c', 'set -o pipefail; export OS=ubuntu:14.04;export 
CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh 2>&1 | 
tee build_41092']

Error:
 ..
+ : ubuntu:14.04
+ : gcc
+ : --verbose
+++ dirname ./support/docker_build.sh
++ cd ./support/..
++ pwd
+ MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
+ cd /Users/vinodkone/workspace/mesos
+ DOCKERFILE=Dockerfile
+ rm -f Dockerfile
+ case $OS in
+ append_dockerfile 'FROM ubuntu:14.04'
+ echo FROM ubuntu:14.04
+ append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
+ echo RUN rm -rf '/var/lib/apt/lists/*'
+ append_dockerfile 'RUN apt-get update'
+ echo RUN apt-get update
+ append_dockerfile 'RUN apt-get -y install build-essential clang git maven 
autoconf libtool'
+ echo RUN apt-get -y install build-essential clang git maven autoconf libtool
+ append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev 
python-boto libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev 
libev-dev'
+ echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto 
libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev
+ append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
+ echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
+ append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead'
+ echo ENV GTEST_FILTER -FsTest.FileSyst

Re: Review Request 42741: Included reserved resources in stage 1 of allocation.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42741/
---

(Updated Jan. 26, 2016, 10:10 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42741/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42810: Added the CgroupInfo protobuf.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/
---

(Updated Jan. 26, 2016, 10:05 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4488
https://issues.apache.org/jira/browse/MESOS-4488


Repository: mesos


Description
---

Added the CgroupInfo protobuf. The agent can use this message to reflect any 
cgroup configuration that might have been applied to a container.


Diffs
-

  include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
  include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd 

Diff: https://reviews.apache.org/r/42810/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/#review116455
---


Fix it, then Ship it!




Looking good. Just some minor things.


src/executor/executor.cpp (lines 353 - 355)


Move this to #364.

How about:

// NOTE: We will be here if either subscribe or non-subscribe connection is 
disconnected. We explicitly
// disconnect both the connections here for simplicity.



src/executor/executor.cpp (line 430)


just do 

```
// Ignore if this timeout is for a stale connection.
if (connections != _connections) {
   return;
}
```

to be consistent with what you did in `disconnected(()`


- Vinod Kone


On Jan. 26, 2016, 9:19 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41283/
> ---
> 
> (Updated Jan. 26, 2016, 9:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces the implementation for the executor library. 
>   
> This uses the new HTTP Connection interface to ensure calls are properly 
> pipelined.   
>   
> `connected` -> Callback invoked when a TCP connection is established with the 
> agent for the Subscribe call.
> `disconnected` -> When the Subscribe TCP connection is interrupted possibly 
> due to an agent restart.
> `received` -> When the executor receives events from the agent upon 
> subscribing.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
>   src/executor/executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41283/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42738: Included reserved resources in the quota role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/
---

(Updated Jan. 26, 2016, 10:02 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42738/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/
---

(Updated Jan. 26, 2016, 9:56 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Joris' comments.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42711/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

[Artem Harutyunyan]

> On Jan. 26, 2016, 12:26 p.m., Jie Yu wrote:
> > src/tests/disk_quota_tests.cpp, lines 144-147
> > 
> >
> > This should be wrapped with ifdef linux. I fixed it for you.

Thanks Jie, there is a ticket to make sure we handle excludes correctly on Mac 
OS https://issues.apache.org/jira/browse/MESOS-4516.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/#review116424
---


On Jan. 26, 2016, 10:48 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41818/
> ---
> 
> (Updated Jan. 26, 2016, 10:48 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Jie Yu.
> 
> 
> Bugs: MESOS-4281
> https://issues.apache.org/jira/browse/MESOS-4281
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Handled quota when volumes are bind mounted into the sandbox.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 
> 31808c1e8199fbf2cea36c273860fdbf0a2388f8 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 248c34adb63907911d89bed5b1519682a852bb2d 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 5bb85034c22caef64054c1629f6fd55d227e48b1 
>   src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 
> 
> Diff: https://reviews.apache.org/r/41818/diff/
> 
> 
> Testing
> ---
> 
> sudo mesos-tests.sh
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review116453
---



Patch looks great!

Reviews applied: [42470, 42471, 42472, 42473, 42474, 42503, 42683, 42504, 
42593, 42505, 42506, 42684]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 8:20 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> ---
> 
> (Updated Jan. 26, 2016, 8:20 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
> 
> Diff: https://reviews.apache.org/r/42684/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 42789: Added support file to autogenerate docs from endpoint help strings.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42789/#review116417
---



Thanks for writing this, Kevin! I'm going to extend it to output the 
configuration flags documentation to disk. For this reason, I wonder if you 
could give the file a more generic name?


support/endpoint-docs.cpp (line 91)


Perhaps use a more descriptive name for this typedef?



support/endpoint-docs.cpp (line 102)


You can omit the `void` parameter here, and below.



support/endpoint-docs.cpp (line 150)


s/standad/standard/



support/endpoint-docs.cpp (line 211)


Could use `foreach ( ... )` here, and below.


- Greg Mann


On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42789/
> ---
> 
> (Updated Jan. 26, 2016, 7:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After building mesos from source, an executable called
> mesos-endpoint-docs will be created in build/src. Invoke this executable
> with the flag --dirname=../docs/endpoints to autogenerate documentation
> for all endpoint strings and install it into the proper location.  In a
> subsequent commit we will add a link to this directory in home.md.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   support/endpoint-docs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42789/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

[Greg Mann]

> On Jan. 26, 2016, 8:34 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/include/process/help.hpp, line 111
> > 
> >
> > Returning a raw pointer here is unfortunate. I wonder if it would be 
> > better to return the map by value (since performance is unlikely to matter 
> > for most callers), or else return a `shared_ptr`.

Also, since I don't imagine we want anyone modifying the helps through this 
pointer, perhaps it should be a `shared_ptr`-to-const.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/#review116432
---


On Jan. 26, 2016, 7:40 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42786/
> ---
> 
> (Updated Jan. 26, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, there was no way to extract the help strings from the help
> process once they had been installed into it.  The only way to get at
> them was to visit the http endpoint they were associated with and pull
> it from there.
> 
> This commit adds API calls to the process::Help class to get at these
> strings more easily.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/help.hpp 
> 2e76a6a5b1069abce879374a88cea65036873f1d 
>   3rdparty/libprocess/include/process/process.hpp 
> 1e4126f1082c24debd9d713b490d18f5ed83f0be 
>   3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 
> 
> Diff: https://reviews.apache.org/r/42786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/
---

(Updated Jan. 26, 2016, 9:19 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Updated Summary/Description back again.


Summary (updated)
-

Introduced an Executor Library based on the new executor HTTP API.


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description (updated)
---

This change introduces the implementation for the executor library. 

This uses the new HTTP Connection interface to ensure calls are properly 
pipelined. 

`connected` -> Callback invoked when a TCP connection is established with the 
agent for the Subscribe call.
`disconnected` -> When the Subscribe TCP connection is interrupted possibly due 
to an agent restart.
`received` -> When the executor receives events from the agent upon subscribing.


Diffs
-

  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/executor/executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41283/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/#review116450
---




src/slave/container_loggers/lib_logrotate.hpp (line 104)


hmmm .. why can't we just use `os::access` here to find out if we have 
permissions to read the file?


- Anand Mazumdar


On Jan. 26, 2016, 8:36 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42820/
> ---
> 
> (Updated Jan. 26, 2016, 8:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4515
> https://issues.apache.org/jira/browse/MESOS-4515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `logrotate --version` flag is actually a very recent addition (3.9.1).  
> The `--help` flag is more likely to be present on a supported 
> system-with-logrotate, given logrotate's usage of popopt.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
>   src/slave/container_loggers/logrotate.hpp 
> fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 
> 
> Diff: https://reviews.apache.org/r/42820/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX & Centos6
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 42821: Cleaned up namespace-qualified identifiers.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42821/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 

Diff: https://reviews.apache.org/r/42821/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov

Re: Review Request 42476: Introduced protobuf for set quota requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/
---

(Updated Jan. 26, 2016, 8:48 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
Van Remoortere.


Changes
---

Addressed issues.


Bugs: MESOS-4410
https://issues.apache.org/jira/browse/MESOS-4410


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
  include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
  src/master/quota.hpp 9ac390777946047978a00aa59082e78ce3997441 
  src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 
  src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
  src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
  src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 

Diff: https://reviews.apache.org/r/42476/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/#review116447
---



Bad patch!

Reviews applied: [39850, 39851, 39852, 39888, 39889, 40102, 40851]

Failed command: ./support/apply-review.sh -n -r 40851

Error:
 ..
2016-01-26 20:47:03 URL:https://reviews.apache.org/r/40851/diff/raw/ 
[27690/27690] -> "40851.patch" [1]
40851.patch:211: trailing whitespace.
 
40851.patch:286: trailing whitespace.
-lock xadd dword ptr [eax], ecx; 
40851.patch:287: trailing whitespace.
-   lock xadd dword ptr [eax], ebx; 
40851.patch:288: trailing whitespace.
-mov result, ecx; // result = ebx;
40851.patch:290: trailing whitespace.
- return result;
warning: 5 lines add whitespace errors.
3rdparty/zookeeper-3.4.5.patch:202: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:277: trailing whitespace.
+-lock xadd dword ptr [eax], ecx; 
3rdparty/zookeeper-3.4.5.patch:278: trailing whitespace.
+-   lock xadd dword ptr [eax], ebx; 
3rdparty/zookeeper-3.4.5.patch:279: trailing whitespace.
+-mov result, ecx; // result = ebx;
3rdparty/zookeeper-3.4.5.patch:281: trailing whitespace.
+- return result;

Full log: https://builds.apache.org/job/mesos-reviewbot/11058/console

- Mesos ReviewBot


On Jan. 26, 2016, 8:18 p.m., M Lawindi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40851/
> ---
> 
> (Updated Jan. 26, 2016, 8:18 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Dario Bazan, Daniel Pravat, Alex 
> Clemmer, and M Lawindi.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
> 
> Diff: https://reviews.apache.org/r/40851/diff/
> 
> 
> Testing
> ---
> 
> - Applied patch to original zookeeper 3.4.5
> - Successfully opened 2015 solution in VS2015
> - Cli and Zookeeper build successfully
> 
> 
> Thanks,
> 
> M Lawindi
> 
>

Re: Review Request 42476: Introduced protobuf for set quota requests.

[Alexander Rukletsov]

> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote:
> > include/mesos/quota/quota.proto, line 56
> > 
> >
> > I feel that optimizing here (with = 16) is more confusing than helpful, 
> > especially as this protobuf is mostly used as the schema for the json 
> > request.
> 
> Joris Van Remoortere wrote:
> What are we optimizing here? Room for more fields?
> 
> Alexander Rukletsov wrote:
> Yep, future fields.
> 
> "Tag numbers 1-15 require one less byte to encode than higher numbers, so 
> as an optimization you can decide to use those tags for the commonly used or 
> repeated elements, leaving tags 16 and higher for less-commonly used optional 
> elements. Each element in a repeated field requires re-encoding the tag 
> number, so repeated fields are particularly good candidates for this 
> optimization."
> 
> https://developers.google.com/protocol-buffers/docs/cpptutorial?hl=en

After an offline conversation with Joris we decided not to introduce this 
optimization.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/#review115127
---


On Jan. 26, 2016, 4:33 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> ---
> 
> (Updated Jan. 26, 2016, 4:33 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
> Van Remoortere.
> 
> 
> Bugs: MESOS-4410
> https://issues.apache.org/jira/browse/MESOS-4410
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
>   src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 
>   src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
>   src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
>   src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 
> 
> Diff: https://reviews.apache.org/r/42476/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42789: Added support file to autogenerate docs from endpoint help strings.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42789/#review116436
---




support/endpoint-docs.cpp (line 80)


Should probably add `using std::string;`



support/endpoint-docs.cpp (line 86)


Typo in comment.



support/endpoint-docs.cpp (line 87)


Comment should end in a period.



support/endpoint-docs.cpp (line 103)


Better to use `foreach` or a range-based `for`, probably.



support/endpoint-docs.cpp (line 150)


Typo



support/endpoint-docs.cpp (line 160)


This comment is confusing.



support/endpoint-docs.cpp (line 177)


If the string's length is < 5 characters, seems like this would overflow 
and throw an exception.



support/endpoint-docs.cpp (line 251)


Comment should end in a period.



support/endpoint-docs.cpp (line 267)


Comment should end in a period.



support/endpoint-docs.cpp (line 328)


Comment should end in a period.



support/endpoint-docs.cpp (line 383)


Comment should end in a period.


- Neil Conway


On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42789/
> ---
> 
> (Updated Jan. 26, 2016, 7:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After building mesos from source, an executable called
> mesos-endpoint-docs will be created in build/src. Invoke this executable
> with the flag --dirname=../docs/endpoints to autogenerate documentation
> for all endpoint strings and install it into the proper location.  In a
> subsequent commit we will add a link to this directory in home.md.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   support/endpoint-docs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42789/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 42820: Fixed logrotate ContainerLogger on Centos6.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/
---

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Bugs: MESOS-4515
https://issues.apache.org/jira/browse/MESOS-4515


Repository: mesos


Description
---

The `logrotate --version` flag is actually a very recent addition (3.9.1).  The 
`--help` flag is more likely to be present on a supported 
system-with-logrotate, given logrotate's usage of popopt.


Diffs
-

  src/slave/container_loggers/lib_logrotate.hpp 
5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
  src/slave/container_loggers/logrotate.hpp 
fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 

Diff: https://reviews.apache.org/r/42820/diff/


Testing
---

make check on OSX & Centos6


Thanks,

Joseph Wu

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/#review116432
---




3rdparty/libprocess/include/process/help.hpp (line 111)


Returning a raw pointer here is unfortunate. I wonder if it would be better 
to return the map by value (since performance is unlikely to matter for most 
callers), or else return a `shared_ptr`.



3rdparty/libprocess/src/help.cpp (line 104)


Should just be `string`, not `std::string`.


- Neil Conway


On Jan. 26, 2016, 7:40 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42786/
> ---
> 
> (Updated Jan. 26, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, there was no way to extract the help strings from the help
> process once they had been installed into it.  The only way to get at
> them was to visit the http endpoint they were associated with and pull
> it from there.
> 
> This commit adds API calls to the process::Help class to get at these
> strings more easily.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/help.hpp 
> 2e76a6a5b1069abce879374a88cea65036873f1d 
>   3rdparty/libprocess/include/process/process.hpp 
> 1e4126f1082c24debd9d713b490d18f5ed83f0be 
>   3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 
> 
> Diff: https://reviews.apache.org/r/42786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41283: V1 Executor Library over HTTP

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/
---

(Updated Jan. 26, 2016, 8:33 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments from Vinod


Summary (updated)
-

V1 Executor Library over HTTP


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description (updated)
---

V1 Executor Library over HTTP


Diffs (updated)
-

  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/executor/executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41283/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Anand Mazumdar]

> On Jan. 25, 2016, 9:58 p.m., Vinod Kone wrote:
> > src/executor/executor.cpp, line 361
> > 
> >
> > dont you want to set `subscribe` and `nonSubscribe` to None()?

As per our discussion, we don't set them to `None()` since we need them later 
when `_recoveryTimeout` is invoked.


> On Jan. 25, 2016, 9:58 p.m., Vinod Kone wrote:
> > src/executor/executor.cpp, line 368
> > 
> >
> > Why is this outside the `if (state == CONNECTED)` block? I'm guessing 
> > you don't want to fire multiple delays one for subscribe disconnection and 
> > nonSubscribe disconnection for example?
> > 
> > If yes, you might just want to do the below at the top of this method.
> > 
> > ```
> > if (state == DISCONNECTED) {
> >   return;
> > }
> > ```
> > 
> > and merge this if block with the one at #352.

Fixed. Previously, we used to fire 2 retries for both the 
subscribe/non-subscribe connections. Thanks for noticing it. As per our 
discussion, now we retry inside the `backoff` function instead of 
`disconnected` only once per disconnection.


> On Jan. 25, 2016, 9:58 p.m., Vinod Kone wrote:
> > src/executor/executor.cpp, line 299
> > 
> >
> > Maybe mention when state transitions from/to CONNECTED/DISCONNECTED?

We mention them when we define the `enum`. Let me know if that is not enough.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/#review116179
---


On Jan. 22, 2016, 1:36 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41283/
> ---
> 
> (Updated Jan. 22, 2016, 1:36 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces the implementation for the executor library. 
> 
> This uses the new HTTP Connection interface to ensure calls are properly 
> pipelined.
> 
> `connected` -> Callback invoked when a TCP connection is established with the 
> agent for the `Subscribe` call.
> `disconnected` -> When the `Subscribe` TCP connection is interrupted possibly 
> due to an agent restart.
> `received` -> When the executor receives events from the agent upon 
> subscribing.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
>   src/executor/executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41283/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/#review116424
---


Fix it, then Ship it!





src/tests/disk_quota_tests.cpp (lines 144 - 147)


This should be wrapped with ifdef linux. I fixed it for you.


- Jie Yu


On Jan. 26, 2016, 6:48 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41818/
> ---
> 
> (Updated Jan. 26, 2016, 6:48 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Jie Yu.
> 
> 
> Bugs: MESOS-4281
> https://issues.apache.org/jira/browse/MESOS-4281
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Handled quota when volumes are bind mounted into the sandbox.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 
> 31808c1e8199fbf2cea36c273860fdbf0a2388f8 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 248c34adb63907911d89bed5b1519682a852bb2d 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 5bb85034c22caef64054c1629f6fd55d227e48b1 
>   src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 
> 
> Diff: https://reviews.apache.org/r/41818/diff/
> 
> 
> Testing
> ---
> 
> sudo mesos-tests.sh
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
---

(Updated Jan. 26, 2016, 8:20 p.m.)


Review request for mesos, Jie Yu and Michael Park.


Changes
---

fixed non-linux compilation issue.


Bugs: MESOS-191
https://issues.apache.org/jira/browse/MESOS-191


Repository: mesos


Description
---

Multiple Disk: Added persistent volumes tests for `MOUNT` type.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 
  src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 

Diff: https://reviews.apache.org/r/42684/diff/


Testing
---

sudo make check


Thanks,

Joris Van Remoortere

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

[M Lawindi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/
---

(Updated Jan. 26, 2016, 8:18 p.m.)


Review request for mesos, Alex Naparu, Dario Bazan, Daniel Pravat, Alex 
Clemmer, and M Lawindi.


Repository: mesos


Description
---

Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.


Diffs (updated)
-

  3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 

Diff: https://reviews.apache.org/r/40851/diff/


Testing
---

- Applied patch to original zookeeper 3.4.5
- Successfully opened 2015 solution in VS2015
- Cli and Zookeeper build successfully


Thanks,

M Lawindi