Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

[Joerg Schad]

> On March 10, 2016, 8:47 p.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/mesos/linux_launcher.cpp, line 301
> > 
> >
> > We now rely on the hook logic to do this right?
> > Let's document this.

This is actually one thing I wanted to discuss with you: We do (here as well as 
in extendLifetime) a kill inside the hook as well as one from the subprocess 
logic calling the hook (on receiving an error). Are we sure that we are always 
killing the right process (as there might have been a new process with the same 
pid) when killing it from the subprocess?


> On March 10, 2016, 8:47 p.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/mesos/linux_launcher.cpp, lines 298-302
> > 
> >
> > What should we do here now that the hook infrastructure is in place?
> > Should we log an error as well as return one? or return a more 
> > meaningful error message?

See my comment below. In general I would prefere a logic where we just return 
an error (from the Hook) and the subprocess logic takes care of killing and 
logging.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44087/#review122977
---


On March 3, 2016, 3:39 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44087/
> ---
> 
> (Updated March 3, 2016, 3:39 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved logic to assign process to freezer hierarchy into parentHook.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 9c80cfb621ef2e28aabfb2649846892964d2d4f3 
> 
> Diff: https://reviews.apache.org/r/44087/diff/
> 
> 
> Testing
> ---
> 
> sudo make check (on Linux)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44087/
---

(Updated March 11, 2016, 8:39 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed reviews.


Repository: mesos


Description
---

Moved logic to assign process to freezer hierarchy into parentHook.


Diffs (updated)
-

  src/slave/containerizer/mesos/linux_launcher.cpp 
9c80cfb621ef2e28aabfb2649846892964d2d4f3 

Diff: https://reviews.apache.org/r/44087/diff/


Testing
---

sudo make check (on Linux)


Thanks,

Joerg Schad

Re: Review Request 41333: Added helper functions to filter usage slack resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41333/
---

(Updated 三月 11, 2016, 9:06 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4146
https://issues.apache.org/jira/browse/MESOS-4146


Repository: mesos


Description
---

Added helper functions to filter usage slack resources.


Diffs (updated)
-

  include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176 
  include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e 
  src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54 
  src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0 
  src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d 

Diff: https://reviews.apache.org/r/41333/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41334/
---

(Updated 三月 11, 2016, 9:06 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4146
https://issues.apache.org/jira/browse/MESOS-4146


Repository: mesos


Description
---

This helper function is used to filter out allocation slack resources.


Diffs (updated)
-

  include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176 
  include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e 
  src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54 
  src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0 
  src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d 

Diff: https://reviews.apache.org/r/41334/diff/


Testing
---

make
make check
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="RevocableResourceTest.Filter" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 40529: Added helper function to get stateless resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
---

(Updated 三月 11, 2016, 9:07 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955


Repository: mesos


Description
---

Added helper function to get stateless resources.


Diffs (updated)
-

  include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176 
  include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e 
  src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54 
  src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0 
  src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d 

Diff: https://reviews.apache.org/r/40529/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 42547: Added helper function to get non usage slack resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42547/
---

(Updated 三月 11, 2016, 9:07 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4146
https://issues.apache.org/jira/browse/MESOS-4146


Repository: mesos


Description
---

Added helper function to get non usage slack resources.


Diffs (updated)
-

  include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176 
  include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e 
  src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54 
  src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0 
  src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d 

Diff: https://reviews.apache.org/r/42547/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 42590: Removed reserved() API.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/
---

(Updated 三月 11, 2016, 9:08 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4447
https://issues.apache.org/jira/browse/MESOS-4447


Repository: mesos


Description
---

Removed reserved() API.


Diffs (updated)
-

  include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176 
  include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e 
  src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54 
  src/master/http.cpp 54a2569ff5b10388177a9bd29c6ddc0387e5e8fd 
  src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0 
  src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d 

Diff: https://reviews.apache.org/r/42590/diff/


Testing
---

make
make check
./bin/mesos-tests.sh  --gtest_filter="ResourcesTest.*"


Thanks,

Guangya Liu

Re: Review Request 41772: Added helper function to flatten resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41772/
---

(Updated 三月 11, 2016, 9:10 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4267
https://issues.apache.org/jira/browse/MESOS-4267


Repository: mesos


Description (updated)
---

Added helper function to flatten resources.


Diffs (updated)
-

  include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176 
  include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e 
  src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54 
  src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0 
  src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d 

Diff: https://reviews.apache.org/r/41772/diff/


Testing
---

make
make check

GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="ResourcesOperationTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/
---

(Updated 三月 11, 2016, 9:10 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description
---

Enabled oversubscribed resources for reservations in allocator.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
70291075c00a9a557529c2562dedcfc6c6c3ec32 
  src/tests/hierarchical_allocator_tests.cpp 
459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/40632/diff/


Testing
---

make
make check
GLOG_v=2  ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose --gtest_repeat=100 --gtest_shuffle


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 三月 11, 2016, 9:10 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/
---

(Updated 三月 11, 2016, 9:10 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-3887
https://issues.apache.org/jira/browse/MESOS-3887


Repository: mesos


Description
---

Added a flag to master to enable oversubscription for reservations.


Diffs (updated)
-

  include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
  src/master/allocator/mesos/allocator.hpp 
64bce0fb143b109c26f923cd97d5facb393dee9d 
  src/master/allocator/mesos/hierarchical.hpp 
52b3a9bfbe73d24968f7ddb0672aee1e05636ab0 
  src/master/allocator/mesos/hierarchical.cpp 
70291075c00a9a557529c2562dedcfc6c6c3ec32 
  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/flags.cpp c1dd127109f1ba96a8f9b95f3eb99dfeb43f7d28 
  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 
  src/tests/hierarchical_allocator_tests.cpp 
459e02576f6d05abbbcc83ae5cabac5c66e93f05 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_quota_tests.cpp 4fabc1473ec3e048afe7171abbb8d6e49e863847 
  src/tests/persistent_volume_endpoints_tests.cpp 
81185a161498394020a27f1f5bf747bac5425f43 
  src/tests/reservation_endpoints_tests.cpp 
f95ae7a32c3809d150adf1e9e515a3b527e61699 
  src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c 

Diff: https://reviews.apache.org/r/40339/diff/


Testing
---

Ubuntu 14.04
make
make check


Thanks,

Guangya Liu

Re: Review Request 42113: Added test cases for updateAllocation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42113/
---

(Updated 三月 11, 2016, 9:11 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description
---

Added test cases for updateAllocation.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42113/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41791: Updated allocation slack when dynamic reserve called.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41791/
---

(Updated 三月 11, 2016, 9:11 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description
---

Updated allocation slack when dynamic reserve called.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
52b3a9bfbe73d24968f7ddb0672aee1e05636ab0 
  src/master/allocator/mesos/hierarchical.cpp 
70291075c00a9a557529c2562dedcfc6c6c3ec32 

Diff: https://reviews.apache.org/r/41791/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 42491: Updated allocatable() to distinguish different resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42491/
---

(Updated 三月 11, 2016, 9:12 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4426
https://issues.apache.org/jira/browse/MESOS-4426


Repository: mesos


Description
---

Updated allocatable() to distinguish different resources.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
70291075c00a9a557529c2562dedcfc6c6c3ec32 
  src/tests/hierarchical_allocator_tests.cpp 
459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42491/diff/


Testing
---

make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose --gtest_repeat=100 --gtest_shuffle


Thanks,

Guangya Liu

Re: Review Request 41848: Do not enable task and executor run on different resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/
---

(Updated 三月 11, 2016, 9:12 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-3931
https://issues.apache.org/jira/browse/MESOS-3931


Repository: mesos


Description
---

Do not enable task and executor run on different resources.


Diffs (updated)
-

  src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
  src/tests/master_validation_tests.cpp 
c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 

Diff: https://reviews.apache.org/r/41848/diff/


Testing
---

make
make check
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="TaskValidationTest.*" --verbose


Thanks,

Guangya Liu

Re: Review Request 42194: Added test cases for updateAvailable.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42194/
---

(Updated 三月 11, 2016, 9:12 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description
---

Added test cases for updateAvailable.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42194/diff/


Testing
---

make
make check
GLOG_v=2  ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose --gtest_repeat=100 --gtest_shuffle


Thanks,

Guangya Liu

Re: Review Request 44694: Enabled multiple calls to ModuleManager::load().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44694/#review123119
---



Patch looks great!

Reviews applied: [44694]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 7:50 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44694/
> ---
> 
> (Updated March 11, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Michael Park, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4903
> https://issues.apache.org/jira/browse/MESOS-4903
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As long as the module manifest(s) being loaded don't conflict with the
> already loaded manifests, the module manager will allow multiple calls
> to `load()`.
> 
> 
> Diffs
> -
> 
>   src/module/manager.hpp 89dd06097a355c6455e8f8af7d3d98847a304c90 
>   src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 
>   src/tests/module_tests.cpp 497ed87bddce23bb457373da40dc87111c04136d 
> 
> Diff: https://reviews.apache.org/r/44694/diff/
> 
> 
> Testing
> ---
> 
> Added new tests and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 44702: Added missing blank line in reservation_test.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44702/
---

Review request for mesos and Bernd Mathiske.


Repository: mesos


Description
---

Added missing blank line in reservation_test.


Diffs
-

  src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 

Diff: https://reviews.apache.org/r/44702/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44076/
---

(Updated March 11, 2016, 9:24 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3632
https://issues.apache.org/jira/browse/MESOS-3632


Repository: mesos


Description
---

Windows: [2/3] Used `os::execlp` in launch.cpp.


Diffs (updated)
-

  src/slave/containerizer/mesos/launch.cpp 
9fb55aa342559d2f982e7e6ccfef2f0e702bc214 

Diff: https://reviews.apache.org/r/44076/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/
---

(Updated March 11, 2016, 9:24 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4704
https://issues.apache.org/jira/browse/MESOS-4704


Repository: mesos


Description
---

This review was originally at #40582, put up by Dario Bazan. Dario went
on paternity leave, so I've dusted it off, rebased it against the state
of the art, and gotten it ready for submission. It remains mostly
unchanged, with only minor alterations from the original.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake 
40482e6c604d7a1f20d896b08f530c66910979a9 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
c10c6d9d7c68a2d5b27d68736a49d212e70dcd05 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
3d074a5296b4435b29792201cb9a1b021673fd97 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp 
eb52beb2bcdfbdb71e1456f3286e087e7bbf524e 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
8698e997965add14e0a8a268b0ebcf1a5ab4d49d 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
03e09fb33bf038930a2be0370883511e93f94753 

Diff: https://reviews.apache.org/r/43709/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43708/
---

(Updated March 11, 2016, 9:24 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4704
https://issues.apache.org/jira/browse/MESOS-4704


Repository: mesos


Description
---

This review was originally at #40568, put up by Dario Bazan. Dario went
on paternity leave, so I've dusted it off, rebased it against the state
of the art, and gotten it ready for submission. It remains mostly
unchanged, with only minor alterations from the original.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
b8351ad0181d885a984580ae8de208ea0524b0e7 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
e42cf190bd0d0a768002ca8b28d53aa910543fb7 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
61edad985a74528bfb1f8935040670a802587061 

Diff: https://reviews.apache.org/r/43708/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

[Alex Clemmer]

> On March 11, 2016, 4 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, lines 70-71
> > 
> >
> > What does setting it twice do?

It appends `${ZLIB_ROOT}-build` to a list with `${ZLIB_ROOT}` in it. This is 
required becaues `zconfig.h` is in the `-build` folder.

We can make it a one-liner though: ` set(ZLIB_INCLUDE_DIR ${ZLIB_ROOT} 
${ZLIB_ROOT}-build)`.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43708/#review123086
---


On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43708/
> ---
> 
> (Updated Feb. 18, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review was originally at #40568, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 9b61376ea6aad304607c20c9823d9ef19013eca0 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 
> 
> Diff: https://reviews.apache.org/r/43708/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44678/
---

(Updated March 11, 2016, 9:39 a.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Addressed comment.


Bugs: MESOS-4850
https://issues.apache.org/jira/browse/MESOS-4850


Repository: mesos


Description
---

Modified basic HTTP authenticator creator to accept realm.

To accommodate different authentication realms for the master and agent, the 
default basic HTTP authenticator needs to accept its authentication realm as a 
parameter. This patch adds this parameter and modifies the HTTP authentication 
tests to validate it appropriately.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 
  src/authentication/http/basic_authenticator_factory.cpp 
62f851685db3b42c52bbcb7cff3e4f4703004ed7 
  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/tests/http_authentication_tests.cpp 
cf2bb762272fa38e04e5c26aef2858300bbd0459 

Diff: https://reviews.apache.org/r/44678/diff/


Testing
---

`make check` was used to test on both OSX and CentOS 7.


Thanks,

Greg Mann

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

[Greg Mann]

> On March 11, 2016, 5:23 a.m., Alexander Rojas wrote:
> > src/authentication/http/basic_authenticator_factory.cpp, lines 58-60
> > 
> >
> > This is exactly the reason why I didn't do it this way, since now we 
> > cannot have a user name _authentication_realm_ so we effectively introduced 
> > a keyword.
> > 
> > Come to thing about it, I really went the lazy way and a better 
> > solution would be to accept an entry called _credentials_ which is a list 
> > of key value pairs, i.e.
> > 
> > ```js
> > {
> >   // … other module entries.
> >   "parameters" : [
> >  {
> >"key" : "authentication_realm",
> >"value" : "tatooine"
> >  },
> >  {
> >"key" : "credentials",
> >"value" : "user1 passwd1\nuser2 passwd2"
> >  }
> >   ]
> > }
> > ```

Good call! I added the parameter as JSON, so that it matches the format of the 
`--credentials` flag.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44678/#review123102
---


On March 11, 2016, 9:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44678/
> ---
> 
> (Updated March 11, 2016, 9:39 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified basic HTTP authenticator creator to accept realm.
> 
> To accommodate different authentication realms for the master and agent, the 
> default basic HTTP authenticator needs to accept its authentication realm as 
> a parameter. This patch adds this parameter and modifies the HTTP 
> authentication tests to validate it appropriately.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 
>   src/authentication/http/basic_authenticator_factory.cpp 
> 62f851685db3b42c52bbcb7cff3e4f4703004ed7 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/tests/http_authentication_tests.cpp 
> cf2bb762272fa38e04e5c26aef2858300bbd0459 
> 
> Diff: https://reviews.apache.org/r/44678/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on both OSX and CentOS 7.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/
---

Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Added Doxygen docs for basic HTTP authenticator.

The structure of the module parameters for the basic HTTP authenticator has 
changed, so Doxygen comments were added to the module's header file to provide 
an example.


Diffs
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 

Diff: https://reviews.apache.org/r/44703/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 44515: Added agent flags for HTTP authentication.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/
---

(Updated March 11, 2016, 9:48 a.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Added agent flags for HTTP authentication.

Three command-line flags have been added to the agent to enable HTTP 
authentication: `--authenticate_http`, `--http_credentials`, and 
`--http_authenticators`.


Diffs (updated)
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 

Diff: https://reviews.apache.org/r/44515/diff/


Testing
---

`sudo make check` was used to test on both OSX and Ubuntu 14.04.


Thanks,

Greg Mann

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/
---

(Updated March 11, 2016, 9:52 a.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Bugs: MESOS-4850
https://issues.apache.org/jira/browse/MESOS-4850


Repository: mesos


Description
---

Added authentication to agent HTTP endpoints.

This patch adds HTTP authentication to the `/state`, `/state.json`, and 
`/flags` endpoints. Tests are also updated to use authentication when hitting 
these endpoints, and new tests were added to probe these endpoints' behavior 
when bad credentials are supplied: `SlaveTest.StateEndpointBadCredential` and 
`SlaveTest.FlagsEndpointBadCredential`.


Diffs (updated)
-

  src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
  src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/tests/containerizer/docker_containerizer_tests.cpp 
6aecd912fc84b72d2b64f7a842891fddcbc469ac 
  src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 
  src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
  src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 

Diff: https://reviews.apache.org/r/44553/diff/


Testing
---

Tests were updated to use authentication when hitting the affected agent 
endpoints, and new tests were added to probe the endpoint behavior when invalid 
credentials are supplied.

`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new tests 
were run 1000 times to look for flakiness.


Thanks,

Greg Mann

Re: Review Request 44319: Removed initialize method from the authorizer interface.

[Alexander Rojas]

> On March 10, 2016, 8:32 p.m., Vinod Kone wrote:
> > src/master/main.cpp, line 372
> > 
> >
> > So, we create non-default authorizer if --authorizers specifies a 
> > non-default name but create the default authorizer only if --acls is 
> > present (irrespective of whether --authorizers says "local)". 
> > 
> > I think those semantics are a bit weird to grok. IIRC, we did it that 
> > way for backwards compatibility with old releases that didn't have 
> > "--authorizers" flag? We should atleast mention this behavior in the flags 
> > help.
> 
> Alexander Rojas wrote:
> That is not how the block reads, that block is equivalent to:
> 
> ```c++
> if (authorizerName != master::DEFAULT_AUTHORIZER) {
> LOG(INFO) << "Creating '" << authorizerName << "' authorizer";
> 
> create = Authorizer::create(authorizerName);
>   } else { // authorizerName is the default authorizer at this point!
> if (flags.acls.isSome()) {
>   LOG(INFO) << "Creating default '" << authorizerName << "' 
> authorizer";
> 
>   create = Authorizer::create(flags.acls.get());
> } 
>   }
> ```
> 
> So `--authorizer` has to say _local_ **and** `--acls` have to be present.

I changed the code to the snippet above, so there are no confusions in the 
future.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/#review122961
---


On March 9, 2016, 3:06 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44319/
> ---
> 
> (Updated March 9, 2016, 3:06 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed initialize method from the authorizer interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/authorizer/local/authorizer.hpp 
> c87a9915bae6bae7744bd57abd12e8d857181051 
>   src/authorizer/local/authorizer.cpp 
> 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
>   src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
>   src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
>   src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
> 
> Diff: https://reviews.apache.org/r/44319/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44087/#review123125
---



Patch looks great!

Reviews applied: [44247, 44087]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 8:39 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44087/
> ---
> 
> (Updated March 11, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved logic to assign process to freezer hierarchy into parentHook.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 9c80cfb621ef2e28aabfb2649846892964d2d4f3 
> 
> Diff: https://reviews.apache.org/r/44087/diff/
> 
> 
> Testing
> ---
> 
> sudo make check (on Linux)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/
---

(Updated March 11, 2016, 12:26 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Mention volumes to mount SSL files in dockerized environments.


Bugs: MESOS-4750
https://issues.apache.org/jira/browse/MESOS-4750


Repository: mesos


Description (updated)
---

Documented how to make executors work with SSL.


Diffs (updated)
-

  docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 

Diff: https://reviews.apache.org/r/44620/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 44620: Documented how to make executors work with SSL.

[Jan Schlicht]

> On March 10, 2016, 10:32 p.m., Joseph Wu wrote:
> > docs/ssl.md, line 102
> > 
> >
> > Not sure exactly how much detail we want to add here about specific 
> > configurations (especially considering the upcoming change to the 
> > containerizer's environment variables).  But here's some more specifics:
> > 
> > * When using the DockerContainerizer + normal Mesos agent, the docker 
> > executor shares the same root as the agent.  So as long as the environment 
> > variables are passed on (via the methods you listed), this will work.
> > * When using the DockerContainerizer + dockerized Mesos agent, you will 
> > need to add an additional `ContainerInfo.volumes` which mounts from the 
> > host (*not the agent*) to the executor.  In this case, the task will have 
> > access to the keys/certs :(
> > * The UnifiedContainerizer + normal Mesos agent case will probably be 
> > similar to the DockerContainerizer + normal Mesos agent case (I haven't 
> > tried this).
> > * UnifiedContainerizer + Mesos launched via UnifiedContainerizer ???

Thanks for mentioning the need for volumes for dockerized executors!
I've updated the documentation without going too much into detail and 
mentioning a more general "containerized" environment. I hope that this is 
enough information, not too less.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review122997
---


On March 11, 2016, 12:26 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 11, 2016, 12:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44421: Added support for "overlay" keyword.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44421/
---

(Updated 三月 11, 2016, 11:58 a.m.)


Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin.


Bugs: MESOS-4874
https://issues.apache.org/jira/browse/MESOS-4874


Repository: mesos


Description
---

The "overlayfs" was renamed to "overlay" in kernel 4.2, for overlay
support check function, it should check both "overlay" and "overlayfs"
in "/proc/filesystems".


Diffs (updated)
-

  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/provisioner/backend.cpp 
55652540e35f9c451ad85cfead575a788aa3eba1 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
5cc0f8b5a8cd4c945023f874056a8184113186c5 
  src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 

Diff: https://reviews.apache.org/r/44421/diff/


Testing
---

root@mesos002:~/src/mesos/m1/mesos/build# uname -r
4.2.3-040203-generic
root@mesos002:~/src/mesos/m1/mesos/build# lsmod  | grep over
overlay45056  1 
root@mesos002:~/src/mesos/m1/mesos/build# cat /proc/filesystems | grep over
nodev   overlay
root@mesos002:~/src/

make
make check
./bin/mesos-tests.sh 
--gtest_filter="OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend" --verbose


Thanks,

Guangya Liu

Re: Review Request 44431: Do not check overlayfs when create overlay backend.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44431/
---

(Updated 三月 11, 2016, 12:02 p.m.)


Review request for mesos, Jie Yu and Shuai Lin.


Repository: mesos


Description
---

The overlayfs support was already checked when creating the
backends creators.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
5cc0f8b5a8cd4c945023f874056a8184113186c5 

Diff: https://reviews.apache.org/r/44431/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 44620: Documented how to make executors work with SSL.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review123130
---



Patch looks great!

Reviews applied: [44620]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 11:26 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 11, 2016, 11:26 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

> On March 10, 2016, 10:06 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 158
> > 
> >
> > any reason why this should be exposed in the include directory?
> 
> Alexander Rojas wrote:
> Main reason is because of this `static Try 
> mesos::Authorizer::create(const ACLs& acls);` which is already part of the 
> public API, although it can be forward declared there (It is, actually).
> 
> But it is mentioned in the public API so I thought it should go there 
> anyway.

Moreover, in this patch we have not yet change the signature of the 
`Authorizer`, so every method requires as a parameter one of the `ACL` sub 
messages (whichcannot be forward declared because `ACL` is not a namespace).

This however can be done in a later patch.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review122988
---


On March 10, 2016, 3:09 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> ---
> 
> (Updated March 10, 2016, 3:09 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto  
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44421: Added support for "overlay" keyword.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44421/#review123133
---


Ship it!




Ship It!

- haosdent huang


On March 11, 2016, 11:58 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44421/
> ---
> 
> (Updated March 11, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin.
> 
> 
> Bugs: MESOS-4874
> https://issues.apache.org/jira/browse/MESOS-4874
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The "overlayfs" was renamed to "overlay" in kernel 4.2, for overlay
> support check function, it should check both "overlay" and "overlayfs"
> in "/proc/filesystems".
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 55652540e35f9c451ad85cfead575a788aa3eba1 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 5cc0f8b5a8cd4c945023f874056a8184113186c5 
>   src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 
> 
> Diff: https://reviews.apache.org/r/44421/diff/
> 
> 
> Testing
> ---
> 
> root@mesos002:~/src/mesos/m1/mesos/build# uname -r
> 4.2.3-040203-generic
> root@mesos002:~/src/mesos/m1/mesos/build# lsmod  | grep over
> overlay45056  1 
> root@mesos002:~/src/mesos/m1/mesos/build# cat /proc/filesystems | grep over
> nodev overlay
> root@mesos002:~/src/
> 
> make
> make check
> ./bin/mesos-tests.sh 
> --gtest_filter="OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44431: Do not check overlayfs when create overlay backend.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44431/#review123135
---



Patch looks great!

Reviews applied: [44421, 44431]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 12:02 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44431/
> ---
> 
> (Updated March 11, 2016, 12:02 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Shuai Lin.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The overlayfs support was already checked when creating the
> backends creators.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 5cc0f8b5a8cd4c945023f874056a8184113186c5 
> 
> Diff: https://reviews.apache.org/r/44431/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44319: Removed initialize method from the authorizer interface.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/
---

(Updated March 11, 2016, 2:45 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Addresses Vinod's issues.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description
---

Removed initialize method from the authorizer interface.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051 
  src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
  src/examples/test_authorizer_module.cpp 
95d77fbff0cdfdb360a8597fbba28404b59d0042 
  src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 

Diff: https://reviews.apache.org/r/44319/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/
---

(Updated March 11, 2016, 2:47 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Added TODO.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description
---

This is the first step towards separating the language used to define
the ACLs from the mechanism to query them.


Diffs (updated)
-

  include/mesos/authorizer/acls.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  include/mesos/authorizer/authorizer.proto 
d65377c6c4ed9364efdc531b885c1a8af962ec34 
  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/authorizer/acls.cpp PRE-CREATION 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
  src/examples/persistent_volume_framework.cpp 
4218b1563e10aaefe9abcdc20c90c13651959790 
  src/examples/test_authorizer_module.cpp 
95d77fbff0cdfdb360a8597fbba28404b59d0042 
  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 

Diff: https://reviews.apache.org/r/44320/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
---

(Updated March 11, 2016, 2:54 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Addresses most of Vinod's comments.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description (updated)
---

Implements the [Generic Authorizer Interface v 
0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).

It effectively separates the language used to define ACLs from the
language used to query it allowing for arbitrary identity server
backends.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  include/mesos/authorizer/authorizer.proto PRE-CREATION 
  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051 
  src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
  src/master/http.cpp 54a2569ff5b10388177a9bd29c6ddc0387e5e8fd 
  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
  src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5 
  src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581 
  src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 

Diff: https://reviews.apache.org/r/44322/diff/


Testing
---

make -j4 check


Thanks,

Alexander Rojas

Re: Review Request 44620: Documented how to make executors work with SSL.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review123136
---




docs/ssl.md (line 101)


_You need to make sure… …and the files these variables are refering to…_

Remove _…to the respective values…_ (ask a native speaker about this one).

Change to: _…of the slave's command line f lags…_(Ask Bernd for the correct 
word here)

Don't mix _slave_ and _agents_.


- Alexander Rojas


On March 11, 2016, 12:26 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 11, 2016, 12:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Review Request 44706: Implemented isolate() method of "network/cni" isolator.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44706/
---

Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Implemented isolate() method of "network/cni" isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44706/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/#review123137
---


Ship it!




Ship It!

- Alexander Rojas


On March 11, 2016, 10:52 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44553/
> ---
> 
> (Updated March 11, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added authentication to agent HTTP endpoints.
> 
> This patch adds HTTP authentication to the `/state`, `/state.json`, and 
> `/flags` endpoints. Tests are also updated to use authentication when hitting 
> these endpoints, and new tests were added to probe these endpoints' behavior 
> when bad credentials are supplied: `SlaveTest.StateEndpointBadCredential` and 
> `SlaveTest.FlagsEndpointBadCredential`.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 6aecd912fc84b72d2b64f7a842891fddcbc469ac 
>   src/tests/fault_tolerance_tests.cpp 
> d193897e636efd0e3ef67bf67fcd6255a3de0341 
>   src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
>   src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 
> 
> Diff: https://reviews.apache.org/r/44553/diff/
> 
> 
> Testing
> ---
> 
> Tests were updated to use authentication when hitting the affected agent 
> endpoints, and new tests were added to probe the endpoint behavior when 
> invalid credentials are supplied.
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04. The new 
> tests were run 1000 times to look for flakiness.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/#review123139
---


Fix it, then Ship it!





src/tests/containerizer/docker_containerizer_tests.cpp (line 529)


Add blank line.



src/tests/health_check_tests.cpp (line 273)


http::get() should be sufficient here (namespace http = process::http;)



src/tests/health_check_tests.cpp (line 566)


http::get() see above.



src/tests/health_check_tests.cpp (line 604)


http::get() see above.



src/tests/slave_tests.cpp (line 1433)


I would test querying the endpoint without credentials as well.



src/tests/slave_tests.cpp (line 1435)


Should we add a comment that authn is required by default?



src/tests/slave_tests.cpp (line 1469)


I would combine both test cases into a single one, saves code and setup 
time. Feel free to drop with good reason to keep them seperate.


- Joerg Schad


On March 11, 2016, 9:52 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44553/
> ---
> 
> (Updated March 11, 2016, 9:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added authentication to agent HTTP endpoints.
> 
> This patch adds HTTP authentication to the `/state`, `/state.json`, and 
> `/flags` endpoints. Tests are also updated to use authentication when hitting 
> these endpoints, and new tests were added to probe these endpoints' behavior 
> when bad credentials are supplied: `SlaveTest.StateEndpointBadCredential` and 
> `SlaveTest.FlagsEndpointBadCredential`.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 6aecd912fc84b72d2b64f7a842891fddcbc469ac 
>   src/tests/fault_tolerance_tests.cpp 
> d193897e636efd0e3ef67bf67fcd6255a3de0341 
>   src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
>   src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 
> 
> Diff: https://reviews.apache.org/r/44553/diff/
> 
> 
> Testing
> ---
> 
> Tests were updated to use authentication when hitting the affected agent 
> endpoints, and new tests were added to probe the endpoint behavior when 
> invalid credentials are supplied.
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04. The new 
> tests were run 1000 times to look for flakiness.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

[Joerg Schad]

> On March 11, 2016, 2:29 p.m., Joerg Schad wrote:
> > src/tests/slave_tests.cpp, line 1435
> > 
> >
> > Should we add a comment that authn is required by default?

required -> enabled by default in testcases.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/#review123139
---


On March 11, 2016, 9:52 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44553/
> ---
> 
> (Updated March 11, 2016, 9:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added authentication to agent HTTP endpoints.
> 
> This patch adds HTTP authentication to the `/state`, `/state.json`, and 
> `/flags` endpoints. Tests are also updated to use authentication when hitting 
> these endpoints, and new tests were added to probe these endpoints' behavior 
> when bad credentials are supplied: `SlaveTest.StateEndpointBadCredential` and 
> `SlaveTest.FlagsEndpointBadCredential`.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 6aecd912fc84b72d2b64f7a842891fddcbc469ac 
>   src/tests/fault_tolerance_tests.cpp 
> d193897e636efd0e3ef67bf67fcd6255a3de0341 
>   src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
>   src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 
> 
> Diff: https://reviews.apache.org/r/44553/diff/
> 
> 
> Testing
> ---
> 
> Tests were updated to use authentication when hitting the affected agent 
> endpoints, and new tests were added to probe the endpoint behavior when 
> invalid credentials are supplied.
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04. The new 
> tests were run 1000 times to look for flakiness.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review123143
---



Patch looks great!

Reviews applied: [44318, 44319, 44320, 44322]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 1:54 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> ---
> 
> (Updated March 11, 2016, 1:54 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implements the [Generic Authorizer Interface v 
> 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
> 
> It effectively separates the language used to define ACLs from the
> language used to query it allowing for arbitrary identity server
> backends.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto PRE-CREATION 
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/authorizer/local/authorizer.hpp 
> c87a9915bae6bae7744bd57abd12e8d857181051 
>   src/authorizer/local/authorizer.cpp 
> 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
>   src/master/http.cpp 54a2569ff5b10388177a9bd29c6ddc0387e5e8fd 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
>   src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5 
>   src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
>   src/tests/master_authorization_tests.cpp 
> 29c89fb11da792c3e71eb880a19657ea225b3cc8 
>   src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581 
>   src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 
>   src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
> 
> Diff: https://reviews.apache.org/r/44322/diff/
> 
> 
> Testing
> ---
> 
> make -j4 check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/#review123142
---




src/tests/health_check_tests.cpp (line 642)


http::get()


- Joerg Schad


On March 11, 2016, 9:52 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44553/
> ---
> 
> (Updated March 11, 2016, 9:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added authentication to agent HTTP endpoints.
> 
> This patch adds HTTP authentication to the `/state`, `/state.json`, and 
> `/flags` endpoints. Tests are also updated to use authentication when hitting 
> these endpoints, and new tests were added to probe these endpoints' behavior 
> when bad credentials are supplied: `SlaveTest.StateEndpointBadCredential` and 
> `SlaveTest.FlagsEndpointBadCredential`.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 6aecd912fc84b72d2b64f7a842891fddcbc469ac 
>   src/tests/fault_tolerance_tests.cpp 
> d193897e636efd0e3ef67bf67fcd6255a3de0341 
>   src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
>   src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 
> 
> Diff: https://reviews.apache.org/r/44553/diff/
> 
> 
> Testing
> ---
> 
> Tests were updated to use authentication when hitting the affected agent 
> endpoints, and new tests were added to probe the endpoint behavior when 
> invalid credentials are supplied.
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04. The new 
> tests were run 1000 times to look for flakiness.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44678/#review123144
---




src/authentication/http/basic_authenticator_factory.cpp (lines 70 - 71)


Wouldn't it be better to just get a `Credentials` object?

Or at least in the documentation add an example of how exactly a module 
protobuf would look like. (see my comment's in the next patch)


- Alexander Rojas


On March 11, 2016, 10:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44678/
> ---
> 
> (Updated March 11, 2016, 10:39 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified basic HTTP authenticator creator to accept realm.
> 
> To accommodate different authentication realms for the master and agent, the 
> default basic HTTP authenticator needs to accept its authentication realm as 
> a parameter. This patch adds this parameter and modifies the HTTP 
> authentication tests to validate it appropriately.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 
>   src/authentication/http/basic_authenticator_factory.cpp 
> 62f851685db3b42c52bbcb7cff3e4f4703004ed7 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/tests/http_authentication_tests.cpp 
> cf2bb762272fa38e04e5c26aef2858300bbd0459 
> 
> Diff: https://reviews.apache.org/r/44678/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on both OSX and CentOS 7.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/#review123140
---




include/mesos/authentication/http/basic_authenticator_factory.hpp (lines 46 - 
54)


I think this might be a bit confusing because this json is not a valid 
parameter value, while one gains in the sense that it reflects the intention, I 
can imagine people using this as an example, feeding it into the `--modules` 
flag, and then failing. So I rather use the actual json users have to write 
even if it looks worse.


- Alexander Rojas


On March 11, 2016, 10:47 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44703/
> ---
> 
> (Updated March 11, 2016, 10:47 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Doxygen docs for basic HTTP authenticator.
> 
> The structure of the module parameters for the basic HTTP authenticator has 
> changed, so Doxygen comments were added to the module's header file to 
> provide an example.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 
> 
> Diff: https://reviews.apache.org/r/44703/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41791: Updated allocation slack when dynamic reserve called.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41791/
---

(Updated 三月 11, 2016, 3:01 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description
---

Updated allocation slack when dynamic reserve called.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
52b3a9bfbe73d24968f7ddb0672aee1e05636ab0 
  src/master/allocator/mesos/hierarchical.cpp 
70291075c00a9a557529c2562dedcfc6c6c3ec32 

Diff: https://reviews.apache.org/r/41791/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 44554: Added agent HTTP authentication to the docs.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44554/#review123146
---




docs/authentication.md (line 12)


s/certain/most (I can also change that while adding authn to master 
endpoints).



docs/configuration.md (line 1005)


We should add a clarification what this credential is used for (because 
otherwise we have have twice the same text): "This credential is used to 
identify the slave to the master."



docs/configuration.md (line 1276)


Here the use of the credentials is more obvious (compared to credential 
flag above). Maybe we should still add a description like:
These credentials are used to


- Joerg Schad


On March 11, 2016, 10:04 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44554/
> ---
> 
> (Updated March 11, 2016, 10:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent HTTP authentication to the docs.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 
>   docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
>   docs/home.md fd7794f56b4a95268dbb82288d99cab19a89f5cd 
> 
> Diff: https://reviews.apache.org/r/44554/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/
---

(Updated March 11, 2016, 4:21 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Addressed Alexander's comments.


Bugs: MESOS-4750
https://issues.apache.org/jira/browse/MESOS-4750


Repository: mesos


Description
---

Documented how to make executors work with SSL.


Diffs (updated)
-

  docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 

Diff: https://reviews.apache.org/r/44620/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44549/#review123148
---




src/CMakeLists.txt (line 52)


Should we have a sub-directory called `cni` and add thes spec to the 
sub-directory. Just in case there are other specs that come around and we want 
to support them?



src/CMakeLists.txt (line 275)


Ditto on the `cni` path?



src/Makefile.am (lines 234 - 235)


Ditto on the `cni` path?



src/slave/containerizer/mesos/isolators/network/spec.proto (line 46)


Can we list the required field before the optional fields? We can keep the 
position identifiers as is, if required.



src/slave/containerizer/mesos/isolators/network/spec.proto (line 57)


Ditto on arrangement of required followed by optional fields.


- Avinash sridharan


On March 10, 2016, 2:44 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44549/
> ---
> 
> (Updated March 10, 2016, 2:44 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced a protobuf message "NetworkConfig".
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44549/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44706/#review123150
---



Patch looks great!

Reviews applied: [44004, 44200, 44549, 44555, 44514, 44622, 44706]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 2:10 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44706/
> ---
> 
> (Updated March 11, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented isolate() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44706/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 44710: Fixed placement of mock call expectation for fetcher cache tests.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44710/
---

Review request for mesos.


Repository: mesos


Description
---

The EXPECT_CALL() statement in question should not be repeated in the loop once 
per task. It should only be called exactly once before the driver is started.


Diffs
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/44710/diff/


Testing
---

make check - all fetcher cache tests succeeded.


Thanks,

Bernd Mathiske

Re: Review Request 44554: Added agent HTTP authentication to the docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44554/
---

(Updated March 11, 2016, 3:52 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Addressed comment.


Bugs: MESOS-4850
https://issues.apache.org/jira/browse/MESOS-4850


Repository: mesos


Description
---

Added agent HTTP authentication to the docs.


Diffs (updated)
-

  docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 
  docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
  docs/home.md fd7794f56b4a95268dbb82288d99cab19a89f5cd 

Diff: https://reviews.apache.org/r/44554/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 44710: Fixed placement of mock call expectation for fetcher cache tests.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44710/
---

(Updated March 11, 2016, 7:53 a.m.)


Review request for mesos, Jie Yu, Jan Schlicht, and Till Toenshoff.


Changes
---

Bug ID, potential reviewers added.


Bugs: MESOS-2858
https://issues.apache.org/jira/browse/MESOS-2858


Repository: mesos


Description
---

The EXPECT_CALL() statement in question should not be repeated in the loop once 
per task. It should only be called exactly once before the driver is started.


Diffs
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/44710/diff/


Testing
---

make check - all fetcher cache tests succeeded.


Thanks,

Bernd Mathiske

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
---

(Updated March 11, 2016, 4:57 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Addresses last issue in Vinod's review.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description (updated)
---

Implements the [Generic Authorizer Interface v 
0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).

It effectively separates the language used to define ACLs from the
language used to query it allowing for arbitrary identity server
backends.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  include/mesos/authorizer/authorizer.proto PRE-CREATION 
  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051 
  src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
  src/master/http.cpp 54a2569ff5b10388177a9bd29c6ddc0387e5e8fd 
  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
  src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5 
  src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581 
  src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 

Diff: https://reviews.apache.org/r/44322/diff/


Testing
---

make -j4 check


Thanks,

Alexander Rojas

Re: Review Request 44554: Added agent HTTP authentication to the docs.

[Greg Mann]

> On March 11, 2016, 3:10 p.m., Joerg Schad wrote:
> > docs/authentication.md, line 12
> > 
> >
> > s/certain/most (I can also change that while adding authn to master 
> > endpoints).

I'll let you make this change if you want in your patch, since I'm only adding 
authN to two endpoints (three if you count `/state.json`) here; I think the 
more important change is to add more documentation on which endpoints have 
authentication enabled, which you just brought up as well! Good idea :-)


> On March 11, 2016, 3:10 p.m., Joerg Schad wrote:
> > docs/configuration.md, line 1005
> > 
> >
> > We should add a clarification what this credential is used for (because 
> > otherwise we have have twice the same text): "This credential is used to 
> > identify the slave to the master."

Good call; I added these changes to the docs here in this patch, and the 
corresponding changes to the flags source code in 
https://reviews.apache.org/r/44515/


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44554/#review123146
---


On March 11, 2016, 3:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44554/
> ---
> 
> (Updated March 11, 2016, 3:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent HTTP authentication to the docs.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 
>   docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
>   docs/home.md fd7794f56b4a95268dbb82288d99cab19a89f5cd 
> 
> Diff: https://reviews.apache.org/r/44554/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

[Greg Mann]

> On March 11, 2016, 2:52 p.m., Alexander Rojas wrote:
> > src/authentication/http/basic_authenticator_factory.cpp, lines 70-71
> > 
> >
> > Wouldn't it be better to just get a `Credentials` object?
> > 
> > Or at least in the documentation add an example of how exactly a module 
> > protobuf would look like. (see my comment's in the next patch)

My reasoning for doing it this way was to avoid having nested "credentials" 
keys. i.e., if we parse directly to `Credentials` here we end up with 
parameters like:

{
  "key": "credentials",
  "value": {
"credentials": [
  {
"principal": "user",
"secret": "password"
  }
]
  }
}

Though, the way I've implemented it, it doesn't exactly mirror the structure of 
the `--credentials` flag due to the structure of the `Parameters` message. I 
think I still prefer the current solution, however. I updated the Doxygen 
comments as you suggested :-)


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44678/#review123144
---


On March 11, 2016, 9:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44678/
> ---
> 
> (Updated March 11, 2016, 9:39 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified basic HTTP authenticator creator to accept realm.
> 
> To accommodate different authentication realms for the master and agent, the 
> default basic HTTP authenticator needs to accept its authentication realm as 
> a parameter. This patch adds this parameter and modifies the HTTP 
> authentication tests to validate it appropriately.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 
>   src/authentication/http/basic_authenticator_factory.cpp 
> 62f851685db3b42c52bbcb7cff3e4f4703004ed7 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/tests/http_authentication_tests.cpp 
> cf2bb762272fa38e04e5c26aef2858300bbd0459 
> 
> Diff: https://reviews.apache.org/r/44678/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on both OSX and CentOS 7.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44627: Removed a stale comment in the 1.0 mesos.proto.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44627/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 

Diff: https://reviews.apache.org/r/44627/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44634: Updated the log message in the HTTP API executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44634/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/executor/executor.cpp c3e95ea7e4edf78f2a65ddc15e213aba66e69db2 

Diff: https://reviews.apache.org/r/44634/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44635: Corrected the log message and variable name in executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44635/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/44635/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44629: Fixed ordering and inconsistencies in slave constants.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44629/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 

Diff: https://reviews.apache.org/r/44629/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44628: Fixed a comment and ordering in mesos.proto.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44628/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a 
  include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 

Diff: https://reviews.apache.org/r/44628/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44652: Omitted names of unused parameters in command executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44652/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos, Ben Mahler and Joerg Schad.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44652/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44626: Fixed whitespaces in mesos.proto.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44626/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a 
  include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 

Diff: https://reviews.apache.org/r/44626/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44650: Omitted names of unused parameters in executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44650/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos, Ben Mahler and Joerg Schad.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/44650/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44657: Used `KillPolicy` in command executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44657/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos, Ben Mahler and Gilbert Song.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/44657/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44707: Added validation for task's kill policy.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44707/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b 
  src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 

Diff: https://reviews.apache.org/r/44707/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44653: Fixed formatting in command executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44653/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

[Avinash sridharan]

> On March 11, 2016, 3:43 p.m., Avinash sridharan wrote:
> >

Can you remove the dependency from 44200?


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44549/#review123148
---


On March 10, 2016, 2:44 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44549/
> ---
> 
> (Updated March 10, 2016, 2:44 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced a protobuf message "NetworkConfig".
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44549/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44659: Updated the comment about docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44659/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44659/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44709: Allowed unknown flags in command and docker executors.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44709/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44709/diff/


Testing
---

`make check` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44661/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Bugs: MESOS-4910
https://issues.apache.org/jira/browse/MESOS-4910


Repository: mesos


Description
---

Instead, a combination of `executor_shutdown_grace_period`
agent flag and task kill policies should be used.


Diffs (updated)
-

  docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
  src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 

Diff: https://reviews.apache.org/r/44661/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44662: Added kill policies and shutdown grace period to the CHANGELOG.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44662/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  CHANGELOG 1fbf3029d35207041b5204ed5754a412d5870b3c 

Diff: https://reviews.apache.org/r/44662/diff/


Testing (updated)
---

`make check` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/
---

(Updated March 11, 2016, 4:04 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Addressed comment.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Added Doxygen docs for basic HTTP authenticator.

The structure of the module parameters for the basic HTTP authenticator has 
changed, so Doxygen comments were added to the module's header file to provide 
an example.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 

Diff: https://reviews.apache.org/r/44703/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/
---

(Updated March 11, 2016, 4:06 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Addressed comments.


Bugs: MESOS-4850
https://issues.apache.org/jira/browse/MESOS-4850


Repository: mesos


Description
---

Added authentication to agent HTTP endpoints.

This patch adds HTTP authentication to the `/state`, `/state.json`, and 
`/flags` endpoints. Tests are also updated to use authentication when hitting 
these endpoints, and new tests were added to probe these endpoints' behavior 
when bad credentials are supplied: `SlaveTest.StateEndpointBadCredential` and 
`SlaveTest.FlagsEndpointBadCredential`.


Diffs (updated)
-

  src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
  src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/tests/containerizer/docker_containerizer_tests.cpp 
6aecd912fc84b72d2b64f7a842891fddcbc469ac 
  src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 
  src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
  src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 

Diff: https://reviews.apache.org/r/44553/diff/


Testing
---

Tests were updated to use authentication when hitting the affected agent 
endpoints, and new tests were added to probe the endpoint behavior when invalid 
credentials are supplied.

`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new tests 
were run 1000 times to look for flakiness.


Thanks,

Greg Mann

Review Request 44708: Fixed signed / unsigned comparison in docker.cpp.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44708/
---

Review request for mesos, Ben Mahler and Timothy Chen.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 

Diff: https://reviews.apache.org/r/44708/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 43763: Passed `Duration` as const reference in the executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43763/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/43763/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44630: Renamed `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44630/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-1571
https://issues.apache.org/jira/browse/MESOS-1571


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 
  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 

Diff: https://reviews.apache.org/r/44630/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44631: Cleaned up the comment around executor shutdown event.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44631/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/executor/executor.proto 
a67dbad458e24b22875cf15b73b64c14a084b1ea 
  include/mesos/v1/executor/executor.proto 
c4ad0b4ac6a4e8def013b276877a9c0a5264d4e9 

Diff: https://reviews.apache.org/r/44631/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44658: Removed unused signal escalation constant.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44658/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-1571
https://issues.apache.org/jira/browse/MESOS-1571


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 

Diff: https://reviews.apache.org/r/44658/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44655/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-1571
https://issues.apache.org/jira/browse/MESOS-1571


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a 
  include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 
  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 
  src/executor/executor.cpp c3e95ea7e4edf78f2a65ddc15e213aba66e69db2 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/44655/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44651: Fixed formatting in executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44651/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/44651/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44656/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a 
  include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 

Diff: https://reviews.apache.org/r/44656/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44654/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4911
https://issues.apache.org/jira/browse/MESOS-4911


Repository: mesos


Description
---

Executor shutdown grace period, which configured on the agent, is
propagated to executors via the `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`
environment variable. The executor library uses this timeout to delay
the hard shutdown of the related executor.


Diffs (updated)
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/44654/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44515: Added agent flags for HTTP authentication.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/
---

(Updated March 11, 2016, 4:07 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Edited endpoint help strings to match docs.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Added agent flags for HTTP authentication.

Three command-line flags have been added to the agent to enable HTTP 
authentication: `--authenticate_http`, `--http_credentials`, and 
`--http_authenticators`.


Diffs (updated)
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 

Diff: https://reviews.apache.org/r/44515/diff/


Testing
---

`sudo make check` was used to test on both OSX and Ubuntu 14.04.


Thanks,

Greg Mann

Re: Review Request 44515: Added agent flags for HTTP authentication.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/
---

(Updated March 11, 2016, 4:17 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Addressed comment.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Added agent flags for HTTP authentication.

Three command-line flags have been added to the agent to enable HTTP 
authentication: `--authenticate_http`, `--http_credentials`, and 
`--http_authenticators`.


Diffs (updated)
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 

Diff: https://reviews.apache.org/r/44515/diff/


Testing
---

`sudo make check` was used to test on both OSX and Ubuntu 14.04.


Thanks,

Greg Mann

Re: Review Request 44515: Added agent flags for HTTP authentication.

[Greg Mann]

> On March 10, 2016, 8:45 a.m., Adam B wrote:
> > src/tests/mesos.cpp, lines 182-184
> > 
> >
> > Any reason you can't reuse the previous `path` and `fd` variables?
> 
> Greg Mann wrote:
> We could do that; reusing the variables does improve efficiency, but also 
> reduces readability. Especially in tests, I would consider readability to be 
> the priority, so I decided to declare new variables for these. I've received 
> feedback in the past to declare new variables in similar situations, but I 
> would be interested to hear if you prefer reuse here.
> 
> Alexander Rojas wrote:
> I concur with you Gregg, however I think probably `path` and `fd` should 
> change (not on this review though). Another option would be to separate 
> logical blocks into their own scopes, or a third one, is to have each logical 
> block into a different function. Though for this short method I would go for 
> the scopes solution.

I like the scoping solution too, so I went with that. Thanks Alex!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/#review122892
---


On March 11, 2016, 4:17 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44515/
> ---
> 
> (Updated March 11, 2016, 4:17 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flags for HTTP authentication.
> 
> Three command-line flags have been added to the agent to enable HTTP 
> authentication: `--authenticate_http`, `--http_credentials`, and 
> `--http_authenticators`.
> 
> 
> Diffs
> -
> 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 
> 
> Diff: https://reviews.apache.org/r/44515/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/#review123158
---




include/mesos/authentication/http/basic_authenticator_factory.hpp (lines 54 - 
61)


s/"value:"/"value":/

also, the contents of value are free strings.


- Alexander Rojas


On March 11, 2016, 5:04 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44703/
> ---
> 
> (Updated March 11, 2016, 5:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Doxygen docs for basic HTTP authenticator.
> 
> The structure of the module parameters for the basic HTTP authenticator has 
> changed, so Doxygen comments were added to the module's header file to 
> provide an example.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 
> 
> Diff: https://reviews.apache.org/r/44703/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/
---

(Updated March 11, 2016, 4:41 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Addressed comment.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Added Doxygen docs for basic HTTP authenticator.

The structure of the module parameters for the basic HTTP authenticator has 
changed, so Doxygen comments were added to the module's header file to provide 
an example.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 

Diff: https://reviews.apache.org/r/44703/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

[Greg Mann]

> On March 11, 2016, 4:22 p.m., Alexander Rojas wrote:
> > include/mesos/authentication/http/basic_authenticator_factory.hpp, lines 
> > 54-61
> > 
> >
> > s/"value:"/"value":/
> > 
> > also, the contents of value are free strings.

Ah yea, since the value has to be a string it looks a bit messy with a string 
representing a JSON array as its value. I think I still like the current 
format, since we'll be deprecating the space-delimited format. I changed the 
comments to include the JSON array in a string representation.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/#review123158
---


On March 11, 2016, 4:41 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44703/
> ---
> 
> (Updated March 11, 2016, 4:41 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Doxygen docs for basic HTTP authenticator.
> 
> The structure of the module parameters for the basic HTTP authenticator has 
> changed, so Doxygen comments were added to the module's header file to 
> provide an example.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 
> 
> Diff: https://reviews.apache.org/r/44703/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 44711: Updated authentication.md after most endpoints enable authentication.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44711/
---

Review request for mesos, Adam B and Greg Mann.


Bugs: MESOS-4844
https://issues.apache.org/jira/browse/MESOS-4844


Repository: mesos


Description
---

Reflected default authentication of endpoints in documentation.


Diffs
-

  docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 

Diff: https://reviews.apache.org/r/44711/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44200/#review123161
---


Fix it, then Ship it!





src/slave/flags.hpp (lines 133 - 134)


Can you put these right under `network_enable_snmp_statistics` so that all 
network related knobs are grouped together?



src/slave/flags.cpp (line 694)


Ditto on ordering.


- Jie Yu


On March 4, 2016, 4:14 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44200/
> ---
> 
> (Updated March 4, 2016, 4:14 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4761
> https://issues.apache.org/jira/browse/MESOS-4761
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add agent flags for specifying CNI plugin and config directories.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/44200/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123154
---




src/slave/containerizer/mesos/isolators/network/cni.cpp (line 133)


kill this. `pluginPath` already has the location information?



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 146)


Missing `'` after `path`



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 157)


kill this.



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 170)


Missing `'` after `path`


- Avinash sridharan


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123162
---


Ship it!




Ship It!

- Avinash sridharan


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123164
---


Ship it!




- Avinash sridharan


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44709: Allowed unknown flags in command and docker executors.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44709/#review123165
---



Patch looks great!

Reviews applied: [44626, 44627, 44628, 44629, 44630, 44631, 44634, 44635, 
43763, 44650, 44651, 44652, 44653, 44654, 44655, 44656, 44707, 44657, 44658, 
44659, 44708, 44660, 44661, 44662, 44709]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 4 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44709/
> ---
> 
> (Updated March 11, 2016, 4 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
> 
> Diff: https://reviews.apache.org/r/44709/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>