Re: Review Request 65298: Split test flags into header and source files.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65298/#review196218
---




src/tests/flags.hpp
Line 23 (original)


Since we are cleaning this up anyway, let's add missing includes 
(`stout/option.hpp`).



src/tests/flags.cpp
Lines 18 (patched)


Let's add missing includes (`stout/result.hpp`).


- Benjamin Bannier


On Jan. 23, 2018, 10:58 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65298/
> ---
> 
> (Updated Jan. 23, 2018, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
> 
> 
> Bugs: MESOS-7016
> https://issues.apache.org/jira/browse/MESOS-7016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Split the test flags into header and source files to reduce the amount
> of recompilation necessary when the implementation changes.
> 
> 
> Diffs
> -
> 
>   src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae 
>   src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c 
> 
> 
> Diff: https://reviews.apache.org/r/65298/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65202/#review196219
---




src/tests/fetcher_cache_tests.cpp
Lines 77 (patched)


Could you include `process/gtest.hpp` here?



src/tests/flags.hpp
Lines 47 (patched)


Let's include `stout/duration.hpp`.



src/tests/flags.cpp
Lines 164 (patched)


Let's include `process/gtest.hpp` for this one.



src/tests/gc_tests.cpp
Line 992 (original), 992 (patched)


Could you include `process/gtest.hpp` here?



src/tests/main.cpp
Lines 107 (patched)


Could you include `process/gtest.hpp` here?



src/tests/master_contender_detector_tests.cpp
Line 472 (original), 472 (patched)


Could you include `process/gtest.hpp` here?



src/tests/slave_recovery_tests.cpp
Line 939 (original), 939 (patched)


Could you include `process/gtest.hpp` here?



src/tests/slave_tests.cpp
Line 8270 (original), 8270 (patched)


Could you include `process/gtest.hpp` here?


- Benjamin Bannier


On Jan. 23, 2018, 10:58 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65202/
> ---
> 
> (Updated Jan. 23, 2018, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
> 
> 
> Bugs: MESOS-7016
> https://issues.apache.org/jira/browse/MESOS-7016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Rather than hard-coding a 15sec test timeout, use the libprocess
> `DEFAULT_TEST_TIMEOUT` variable so that this can be globally
> tuned. Added a test flag `--default_timeout` that can be used
> to set the `DEFAULT_TEST_TIMEOUT` on a test run.
> 
> 
> Diffs
> -
> 
>   src/tests/agent_container_api_tests.cpp 
> 618569277545205017320aaf1f3a70e540d35e30 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> 5412a7eccaa836a7f182772f1eb33b10298c96a1 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> d761ea46fd4f12c6bed74090bf5ead7587f16811 
>   src/tests/disk_quota_tests.cpp 4e25e32bf784ea818e18497fe3ebc9f94c5861ff 
>   src/tests/fetcher_cache_tests.cpp 7db7b7dcef27b1686ccae5a7408ff2811a3b9255 
>   src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae 
>   src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c 
>   src/tests/gc_tests.cpp 0e34c017f2c629b527915218f517b88d8392aa4b 
>   src/tests/main.cpp f945ac9e8858998174b4c2785f6a5612bae66a41 
>   src/tests/master_contender_detector_tests.cpp 
> 015d310b72a152829641d436f7cb558f72dfd77c 
>   src/tests/registrar_tests.cpp cbb58c1cd72dc13ed16b5465452d17526255c763 
>   src/tests/slave_recovery_tests.cpp 6d8a57138903637d3cf9e5b19a466961d2c120d7 
>   src/tests/slave_tests.cpp 3a6546b07ac202c461b5c5e8bfcf1eb4f3fe6b4e 
> 
> 
> Diff: https://reviews.apache.org/r/65202/diff/2/
> 
> 
> Testing
> ---
> 
> make check (Fedora 27).
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65322/#review196220
---



PASS: Mesos patch 65322 was successfully built and tested.

Reviews applied: `['65322']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65322

- Mesos Reviewbot Windows


On Jan. 25, 2018, 6:32 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65322/
> ---
> 
> (Updated Jan. 25, 2018, 6:32 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Till Toenshoff, and Cong Wang.
> 
> 
> Bugs: MESOS-8484
> https://issues.apache.org/jira/browse/MESOS-8484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously we relied on Boost to never successfully parse hexadecimal
> numbers, and only performed rejection of hexadecimal floating point
> numbers before entering our custom parser for hexadecimal numbers.
> This was not reliable as on some platforms `boost::lexical_cast` ended
> up successfully parsing literals of hexadecimal floating point numbers
> leading us to never rejecting hexadecimal floating point numbers.
> 
> This patch moves the rejection of hexadecimal floating point numbers
> to a point before attempting a parse with `boost::lexical_cast`. While
> this decouples us in some regards from Boost's parsing behavior, we
> also might end up performing more work than needed. Should this become
> a concern we should revisit and optimize the implementation here.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/numify.hpp 
> 6db9a78145b7e90cc975786ca83f7acb7fdc3e0a 
> 
> 
> Diff: https://reviews.apache.org/r/65322/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on a collection of Linux, macos and Windows setups in internal 
> CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

[Benjamin Bannier]

> On Jan. 22, 2018, 10:08 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/include/process/gtest.hpp
> > Line 249 (original), 251 (patched)
> > 
> >
> > We don't really fully qualify the names here, but instead use just 
> > `process::...` elsewhere. Let's stick to that, and potentially clean up 
> > globally if we really want it.
> > 
> > Here and below.

I didn't see the edit replacing `::process::` with `process::`, could you make 
sure all your changes are here?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65201/#review195938
---


On Jan. 23, 2018, 10:57 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65201/
> ---
> 
> (Updated Jan. 23, 2018, 10:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
> 
> 
> Bugs: MESOS-7016
> https://issues.apache.org/jira/browse/MESOS-7016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a global `DEFAULT_TEST_TIMEOUT` variable that applications
> can use to globally tune the default timeout in the `AWAIT_READY`
> family of test macros. The default remains 15sec.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am ba9e78148932304ce1961b88e5f97180abd35586 
>   3rdparty/libprocess/include/process/gtest.hpp 
> eee726653d52af2e4a148819e420ebd22e5123a9 
>   3rdparty/libprocess/src/CMakeLists.txt 
> f002c157dc2ca64da66bc4e61f5095f2b533ae1f 
>   3rdparty/libprocess/src/gtest.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65201/diff/3/
> 
> 
> Testing
> ---
> 
> make check (Fedora 27).
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65322/
---

(Updated Jan. 25, 2018, 7:32 a.m.)


Review request for mesos, Benno Evers, Till Toenshoff, and Cong Wang.


Bugs: MESOS-8484
https://issues.apache.org/jira/browse/MESOS-8484


Repository: mesos


Description
---

Previously we relied on Boost to never successfully parse hexadecimal
numbers, and only performed rejection of hexadecimal floating point
numbers before entering our custom parser for hexadecimal numbers.
This was not reliable as on some platforms `boost::lexical_cast` ended
up successfully parsing literals of hexadecimal floating point numbers
leading us to never rejecting hexadecimal floating point numbers.

This patch moves the rejection of hexadecimal floating point numbers
to a point before attempting a parse with `boost::lexical_cast`. While
this decouples us in some regards from Boost's parsing behavior, we
also might end up performing more work than needed. Should this become
a concern we should revisit and optimize the implementation here.


Diffs
-

  3rdparty/stout/include/stout/numify.hpp 
6db9a78145b7e90cc975786ca83f7acb7fdc3e0a 


Diff: https://reviews.apache.org/r/65322/diff/1/


Testing
---

`make check` on a collection of Linux, macos and Windows setups in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 65334: Added quota limit to the master API protos.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65334/#review196200
---



PASS: Mesos patch 65334 was successfully built and tested.

Reviews applied: `['65334']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65334

- Mesos Reviewbot Windows


On Jan. 25, 2018, 2:45 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65334/
> ---
> 
> (Updated Jan. 25, 2018, 2:45 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Meng Zhu.
> 
> 
> Bugs: MESOS-8487
> https://issues.apache.org/jira/browse/MESOS-8487
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This introduces a `limit` in `QuotaInfo` and `QuotaRequest`.
> 
> A new `UPDATE_QUOTA` master call is added as a replacement of
> `SET_QUOTA` and `REMOVE_QUOTA`, which provides the new semantics
> of unset limit meaning "no limit" and unset guarantee meaning
> "no guarantee".
> 
> The new APIs are marked as experimental for now.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd 
>   include/mesos/quota/quota.proto f2ed6f555e1e7b0290fefa3e301c9bdbf550bd11 
>   include/mesos/v1/master/master.proto 
> 6759c3004e7e04c0044360b0c54f4438c2f6ec8a 
>   include/mesos/v1/quota/quota.proto 5dd772fee46f740b062827ed7c9704c26187cb12 
>   src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
>   src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 
> 
> 
> Diff: https://reviews.apache.org/r/65334/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 65223: Removed duplicated "/help" prefix in links in /help response.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65223/#review196197
---



Hm.. I couldn't really follow from the ticket and desription here what the 
impact of the bug is, are there broken links?

I just tested out /help on a cluster and the links are working, so is the issue 
something else? What am I missing? :)

- Benjamin Mahler


On Jan. 18, 2018, 5:46 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65223/
> ---
> 
> (Updated Jan. 18, 2018, 5:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8458
> https://issues.apache.org/jira/browse/MESOS-8458
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to that patch, links generated as part of the /help endpoint
> response had the "/help/help/" format, which is incorrect.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/help.cpp 4e1faff7e2a0fb73ed444ce645613c98fb513e1c 
> 
> 
> Diff: https://reviews.apache.org/r/65223/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on MacOS 10.13.2
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 65334: Added quota limit to the master API protos.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65334/
---

Review request for mesos, Alexander Rukletsov, Michael Park, and Meng Zhu.


Bugs: MESOS-8487
https://issues.apache.org/jira/browse/MESOS-8487


Repository: mesos


Description
---

This introduces a `limit` in `QuotaInfo` and `QuotaRequest`.

A new `UPDATE_QUOTA` master call is added as a replacement of
`SET_QUOTA` and `REMOVE_QUOTA`, which provides the new semantics
of unset limit meaning "no limit" and unset guarantee meaning
"no guarantee".

The new APIs are marked as experimental for now.


Diffs
-

  include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd 
  include/mesos/quota/quota.proto f2ed6f555e1e7b0290fefa3e301c9bdbf550bd11 
  include/mesos/v1/master/master.proto 6759c3004e7e04c0044360b0c54f4438c2f6ec8a 
  include/mesos/v1/quota/quota.proto 5dd772fee46f740b062827ed7c9704c26187cb12 
  src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
  src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 


Diff: https://reviews.apache.org/r/65334/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 65333: Fixed errors in comments.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65333/
---

Review request for mesos, Gaston Kleiman and Greg Mann.


Repository: mesos


Description
---

Fixed errors in comments.


Diffs
-

  src/tests/storage_local_resource_provider_tests.cpp 
5ac91802e7c79e769c59c8418502ccc9d41f51b4 


Diff: https://reviews.apache.org/r/65333/diff/1/


Testing
---

N/A


Thanks,

Chun-Hung Hsiao

Review Request 65332: Tested that a CSI persistent volume can be used after recovery.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65332/
---

Review request for mesos, Gaston Kleiman and Greg Mann.


Repository: mesos


Description
---

This patch changes the `ROOT_PublishResourcesRecovery` test to verify
that after agent recovery, a task is able to access the data in a CSI
persistent volume created before agent failover.


Diffs
-

  src/tests/storage_local_resource_provider_tests.cpp 
5ac91802e7c79e769c59c8418502ccc9d41f51b4 


Diff: https://reviews.apache.org/r/65332/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65000/
---

(Updated Jan. 25, 2018, 1:44 a.m.)


Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.


Changes
---

Addressed Greg's comments and did some renaming for consistency.


Bugs: MESOS-8409
https://issues.apache.org/jira/browse/MESOS-8409


Repository: mesos


Description
---

Added an SLRP test for agent being registered with a new ID.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
5ac91802e7c79e769c59c8418502ccc9d41f51b4 


Diff: https://reviews.apache.org/r/65000/diff/3/

Changes: https://reviews.apache.org/r/65000/diff/2-3/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

[Chun-Hung Hsiao]

> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 981 (patched)
> > 
> >
> > s/becomes a pre-existing volume/become pre-existing volumes/

s/volumes/volume/ instead.


> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1003-1011 (patched)
> > 
> >
> > Can you do something like:
> > 
> > ```
> > agentFlags.agent_features = SlaveCapabilities();
> > agentFlags.agent_features->add_capabilities()->set_type(
> > SlaveInfo::Capability::RESOURCE_PROVIDER);
> > ```

Did this because `slave::AGENT_CAPABILITIES()` contains a set of capabilities 
that not yet become default.


> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1039-1040 (patched)
> > 
> >
> > Same question here as in a previous review, regarding potential 
> > raciness of the first offer. Have you tested this under load?

This is handled by `DeclineOffers` by default.


> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1051 (patched)
> > 
> >
> > s/volume/volumes/

Fixed by making the subject singular.


> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1041-1043 (original), 1240-1242 (patched)
> > 
> >
> > Are these changes, and the rest below, meant to go in this RR?

Have split them into other patches.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65000/#review195635
---


On Jan. 25, 2018, 1:44 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65000/
> ---
> 
> (Updated Jan. 25, 2018, 1:44 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8409
> https://issues.apache.org/jira/browse/MESOS-8409
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an SLRP test for agent being registered with a new ID.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 5ac91802e7c79e769c59c8418502ccc9d41f51b4 
> 
> 
> Diff: https://reviews.apache.org/r/65000/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`.

[Qian Zhang]

> On Jan. 24, 2018, 10:11 a.m., Jie Yu wrote:
> > Looks like this is related to
> > https://github.com/apache/mesos/pull/221
> > 
> > Qian, can you commit the patch by tweaking the PR above and using his name?

The code base of that PR is too old. So I will commit this patch and then close 
that PR.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65306/#review196093
---


On Jan. 24, 2018, 9:18 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65306/
> ---
> 
> (Updated Jan. 24, 2018, 9:18 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-6822
> https://issues.apache.org/jira/browse/MESOS-6822
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the way to output error messages in `NetworkCniIsolatorSetup`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> af1d477324e498c2627f6787c8ae7e9e8e3e8fd5 
> 
> 
> Diff: https://reviews.apache.org/r/65306/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 65245: Renamed `LOG` by `Stream logs` in Web UI.

[Vinod Kone]

> On Jan. 22, 2018, 7:33 p.m., Vinod Kone wrote:
> > src/webui/master/static/agent.html
> > Line 45 (original), 45 (patched)
> > 
> >
> > Hmm. This is inconsistent with how we did the stream vs download for 
> > sandboxes. The stream is just a hyper link with the filename followed by a 
> > Download button.
> > 
> > Can we do the same with these logs for consistency? A hyperlink "LOG" 
> > that opens up pailer (which is what it is today) and a "Download" button 
> > next to it with some space (like we did for sandboxes).
> 
> Armand Grillet wrote:
> I imagine that your comment concerns /r/65246/ where I have changed the 
> front-end to have a multi-button instead of links.
> 
> Our sandboxes provide a way to see/download any file in a sandbox 
> (everything is clickable) whereas the masters/agents UI provide a list of 
> information with only one actionnable element: getting the logs. The current 
> UI with a single link showing "LOG" in the middle of a list could be more 
> descriptive and that is why I have changed it.
> 
> I will discard /r/65245/ and put its content in /r/65246/ and update the 
> UI according to your comment. I will leave the first screenshot in the 
> "Testing Done" part and add a second one with the UI after the patch update 
> so that you and Benjamin can decide.

SGTM.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65245/#review195926
---


On Jan. 20, 2018, 4:14 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65245/
> ---
> 
> (Updated Jan. 20, 2018, 4:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-8454
> https://issues.apache.org/jira/browse/MESOS-8454
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The home and agents Web UI are now more descriptive. The name of the
> functions called when clicking these two links have also been updated.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 908d01d1d28f2a4fc595b581fa16515c5be1410a 
>   src/webui/master/static/home.html df3eef61eb9564dbdfc3d138ecfd18e85f747f11 
>   src/webui/master/static/js/controllers.js 
> 59665869dbea77c00740e42f2590473181dfe2fe 
> 
> 
> Diff: https://reviews.apache.org/r/65245/diff/1/
> 
> 
> Testing
> ---
> 
> Checked manually that the feature was still working on the home and agents 
> endpoints.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65208/#review196188
---


Ship it!




Ship It!

- Till Toenshoff


On Jan. 18, 2018, 10:53 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65208/
> ---
> 
> (Updated Jan. 18, 2018, 10:53 a.m.)
> 
> 
> Review request for mesos, Armand Grillet and Till Toenshoff.
> 
> 
> Bugs: MESOS-7979
> https://issues.apache.org/jira/browse/MESOS-7979
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reviewboard's `rbt` can be configured to guess field when creating
> review requests. With that setting it e.g., uses the first line of a
> commit as description, and the remainder as description. If the commit
> message has no body it will use the summary as description as well,
> leading to redundant information in commit messages which committers
> usually remove again manually before committing.
> 
> This patch prevents reusing a reviewboard description which is
> identical to the summary when synthesising commit message with
> `apply_reviews.py`.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65208/diff/1/
> 
> 
> Testing
> ---
> 
> Applied a commit with redundant description; the commit message only contains 
> the reviewboard URL as body.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65261/#review196185
---


Fix it, then Ship it!





src/slave/containerizer/mesos/io/switchboard.cpp
Lines 839-840 (original), 840-847 (patched)


Let's do the following for brevity and clarity:
```
const string socketPath = address.isSome()
  ? address->path()
  : getContainerIOSwitchboardSocketProvisionalPath(
flags.runtime_dir, containerId);
```



src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1054 (patched)


const string?



src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1078 (patched)


s/"to '"/" to '"



src/slave/containerizer/mesos/paths.hpp
Lines 147 (patched)


Add "See comments in IOSwitchboardServer::create()".



src/slave/containerizer/mesos/paths.hpp
Lines 152 (patched)


Add "See comments in IOSwitchboardServer::create()".


- Alexander Rukletsov


On Jan. 22, 2018, 1 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65261/
> ---
> 
> (Updated Jan. 22, 2018, 1 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7742
> https://issues.apache.org/jira/browse/MESOS-7742
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Once IOSwitchboard's unix socket appears in the file system, the agent
> can try to connect to it. If the agent attempts to connect to the
> socket before `listen` has been called, then it gets connection refused
> error. To address this, we initialize a unix socket using a provisional
> path and rename it after `listen` has been called.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 45b615be60af9af839309011eea85912c01ff451 
>   src/slave/containerizer/mesos/paths.hpp 
> 65830a153f765c74bb0399bca9b2941390eeb531 
>   src/slave/containerizer/mesos/paths.cpp 
> 0df4cf5f50aee94a2758ce885389fb488a85fdbd 
> 
> 
> Diff: https://reviews.apache.org/r/65261/diff/2/
> 
> 
> Testing
> ---
> 
> make check (Fedora 25)
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 65180: Removed a comment in io switchboard.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65180/#review196184
---


Ship it!




Ship It!

- Alexander Rukletsov


On Jan. 17, 2018, 11:36 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65180/
> ---
> 
> (Updated Jan. 17, 2018, 11:36 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The comment is incorrect since io switchboard allows reconnects
> after agent restarts.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 4ef640616d69b91c225206444737a40f9571da55 
> 
> 
> Diff: https://reviews.apache.org/r/65180/diff/2/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 65317: Used a namespace for paths in IOSwitchboard.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65317/#review196183
---


Ship it!




Ship It!

- Alexander Rukletsov


On Jan. 24, 2018, 6:10 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65317/
> ---
> 
> (Updated Jan. 24, 2018, 6:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used a namespace for paths in IOSwitchboard.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 45b615be60af9af839309011eea85912c01ff451 
> 
> 
> Diff: https://reviews.apache.org/r/65317/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65306/#review196180
---


Ship it!




Ship It!

- Jie Yu


On Jan. 24, 2018, 1:18 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65306/
> ---
> 
> (Updated Jan. 24, 2018, 1:18 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-6822
> https://issues.apache.org/jira/browse/MESOS-6822
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the way to output error messages in `NetworkCniIsolatorSetup`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> af1d477324e498c2627f6787c8ae7e9e8e3e8fd5 
> 
> 
> Diff: https://reviews.apache.org/r/65306/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support.

[Benjamin Mahler]

> On Jan. 24, 2018, 11:10 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/process.cpp
> > Lines 893-899 (original), 901-910 (patched)
> > 
> >
> > Checking `__s__ != nullptr` here no longer serves any purpose, as the 
> > `Future& socket` will always be discarded before the `__s__` is 
> > deleted.
> > 
> > Perhaps change it to:
> > ```
> > if (!stopped) {
> >   synchronized (socket_mutex) {
> > CHECK_NOTNULL(__s__);
> > future_accept = ...
> >   }
> > }
> > ```

Hm.. I don't think that works. The discard will always be *requested* before 
__s__ is set to nullptr. However, if finalize requests a discard on an already 
completed future_accept, then the discard request has no effect and we must 
rely on the nullptr check.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65183/#review196174
---


On Jan. 24, 2018, 8:47 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65183/
> ---
> 
> (Updated Jan. 24, 2018, 8:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Once discard support for Queue::get was introduced, this makes it
> possible for the finalization logic in libprocess to try to acquire
> the `socket_mutex` recursively:
> 
>   (1) process::finalize acquires socket_mutex, and discards __s__.
>   (2) The get from LibeventSSLSocket::accept_queue gets discarded.
>   (3) This then executes the process.cpp logic in on_accept, which
>   will always re-aquire the `socket_mutex`, even though the
>   accepted socket came out as discarded.
> 
> The fix applied here is to also stop the accept loop when the socket
> was discarded. This avoids acquiring the `socket_mutex` in the
> discarded case.
> 
> Also, this avoids logging a failure message in the discarded case,
> and instead consistently logs when the accept loop is stopped.
> 
> Also, wrote a comment within `LibeventSSLSocket::accept` that
> explains a potential issue due to MESOS-8448.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 1c95ebabfefd07aaeb053b965ab8e4550dfccaef 
>   3rdparty/libprocess/src/process.cpp 
> 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad 
> 
> 
> Diff: https://reviews.apache.org/r/65183/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 65326: Fixed conversion warning.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65326/#review196178
---


Ship it!




I am not a native speaker, but maybe we could make the commit message clearer, 
e.g., something along the lines of

Fixed a conversion warning.

A "possible loss of data" warning was triggered with MSVC since
`process.run(int)` implicitly converted an `unsigned` argument to
`int`. This patch fixes the type of the passed values.

- Benjamin Bannier


On Jan. 24, 2018, 11:16 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65326/
> ---
> 
> (Updated Jan. 24, 2018, 11:16 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A "possible loss of data" warning was introduced because `process.run()`
> implicitly converts to an `int`. Since we have a finite set of ints,
> we can just use the `int` type.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 10fd492951fb1133d057eb3576f93a5f10e178f3 
> 
> 
> Diff: https://reviews.apache.org/r/65326/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65183/#review196174
---


Ship it!




LGTM.


3rdparty/libprocess/src/process.cpp
Lines 893-899 (original), 901-910 (patched)


Checking `__s__ != nullptr` here no longer serves any purpose, as the 
`Future& socket` will always be discarded before the `__s__` is deleted.

Perhaps change it to:
```
if (!stopped) {
  synchronized (socket_mutex) {
CHECK_NOTNULL(__s__);
future_accept = ...
  }
}
```


- Joseph Wu


On Jan. 24, 2018, 12:47 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65183/
> ---
> 
> (Updated Jan. 24, 2018, 12:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Once discard support for Queue::get was introduced, this makes it
> possible for the finalization logic in libprocess to try to acquire
> the `socket_mutex` recursively:
> 
>   (1) process::finalize acquires socket_mutex, and discards __s__.
>   (2) The get from LibeventSSLSocket::accept_queue gets discarded.
>   (3) This then executes the process.cpp logic in on_accept, which
>   will always re-aquire the `socket_mutex`, even though the
>   accepted socket came out as discarded.
> 
> The fix applied here is to also stop the accept loop when the socket
> was discarded. This avoids acquiring the `socket_mutex` in the
> discarded case.
> 
> Also, this avoids logging a failure message in the discarded case,
> and instead consistently logs when the accept loop is stopped.
> 
> Also, wrote a comment within `LibeventSSLSocket::accept` that
> explains a potential issue due to MESOS-8448.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 1c95ebabfefd07aaeb053b965ab8e4550dfccaef 
>   3rdparty/libprocess/src/process.cpp 
> 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad 
> 
> 
> Diff: https://reviews.apache.org/r/65183/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 65326: Fixed conversion warning.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65326/#review196177
---



PASS: Mesos patch 65326 was successfully built and tested.

Reviews applied: `['65326']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65326

- Mesos Reviewbot Windows


On Jan. 24, 2018, 2:16 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65326/
> ---
> 
> (Updated Jan. 24, 2018, 2:16 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A "possible loss of data" warning was introduced because `process.run()`
> implicitly converts to an `int`. Since we have a finite set of ints,
> we can just use the `int` type.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 10fd492951fb1133d057eb3576f93a5f10e178f3 
> 
> 
> Diff: https://reviews.apache.org/r/65326/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65324/#review196176
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65320', '65323', '65324']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65324

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65324/logs/mesos-tests-build-cmake-stdout.log):

```
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,R (__cdecl T::* )(void))': expects 2 arguments - 3 provided 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
&,R (__cdecl T::* )(void))': expects 2 arguments - 3 provided 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::PID &,R 
(__cdecl T::* )(void))': expects 2 arguments - 3 provided 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10,P11),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&,A11 &&)': 
expects 14 arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10,P11),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&,A11 &&)': 
expects 14 arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::PID 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10,P11),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&,A11 &&)': 
expects 14 arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&)': expects 13 
arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&)': expects 13 
arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::PID 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&)': expects 13 
arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9),A0 &&,A1 
&&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&)': expects 12 arguments - 3 
provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9),A0 &&,A1 
&&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&)': expects 12 arguments - 3 
provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::PID 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9),A0 &&,A1 
&&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&)': expects 12 arguments - 3 
provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8),A0 &&,A1 &&,A2 
&&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&)': expects 11 arguments - 3 provided 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\me

Re: Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65324/#review196175
---



Do we really want to make Mesos aware of DC/OS's adminrouter and its routes?

I think a cleaner approach would be to make it easier for a javascript module 
or file that overrides the URL generation.


configure.ac
Lines 297 (patched)


`adminrouter` is a DC/OS concept. We might want to say "allow accessing the 
web UI via a reverse proxy"? I'd probably also rename the flag.


- Gaston Kleiman


On Jan. 24, 2018, 1:40 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65324/
> ---
> 
> (Updated Jan. 24, 2018, 1:40 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   configure.ac b48c80db4d01bf975168398865a12b700bd3d33c 
>   src/webui/master/static/js/controllers.js 
> 59665869dbea77c00740e42f2590473181dfe2fe 
> 
> 
> Diff: https://reviews.apache.org/r/65324/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 65326: Fixed conversion warning.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65326/
---

(Updated Jan. 24, 2018, 2:16 p.m.)


Review request for mesos and Benjamin Bannier.


Repository: mesos


Description (updated)
---

A "possible loss of data" warning was introduced because `process.run()`
implicitly converts to an `int`. Sinnce we have a finite set, we can
ignore this warning and so silence it with a `static_cast`.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/benchmarks.cpp 
10fd492951fb1133d057eb3576f93a5f10e178f3 


Diff: https://reviews.apache.org/r/65326/diff/2/

Changes: https://reviews.apache.org/r/65326/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 65326: Fixed conversion warning.

[Andrew Schwartzmeyer]

> On Jan. 24, 2018, 1:56 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/src/tests/benchmarks.cpp
> > Line 677 (original), 677 (patched)
> > 
> >
> > We do not seem to depend on this being a `size_t`, so I'd suggest to 
> > adjust the type here instead of casting below.

I'm fine with that.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65326/#review196171
---


On Jan. 24, 2018, 1:48 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65326/
> ---
> 
> (Updated Jan. 24, 2018, 1:48 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A "possible loss of data" warning was introduced because `process.run()`
> implicitly converts to an `int`. Since we have a finite set, we can
> ignore this warning and so silence it with a `static_cast`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 10fd492951fb1133d057eb3576f93a5f10e178f3 
> 
> 
> Diff: https://reviews.apache.org/r/65326/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65323: WIP: Updated mesos containerizer to conditionally to ignore GPU isolator creation failure.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65323/#review196172
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65320', '65323']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65323

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65323/logs/mesos-tests-build-cmake-stdout.log):

```
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,R (__cdecl T::* )(void))': expects 2 arguments - 3 provided 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
&,R (__cdecl T::* )(void))': expects 2 arguments - 3 provided 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::PID &,R 
(__cdecl T::* )(void))': expects 2 arguments - 3 provided 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10,P11),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&,A11 &&)': 
expects 14 arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10,P11),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&,A11 &&)': 
expects 14 arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::PID 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10,P11),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&,A11 &&)': 
expects 14 arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&)': expects 13 
arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&)': expects 13 
arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::PID 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9,P10),A0 
&&,A1 &&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&,A10 &&)': expects 13 
arguments - 3 provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9),A0 &&,A1 
&&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&)': expects 12 arguments - 3 
provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9),A0 &&,A1 
&&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&)': expects 12 arguments - 3 
provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::PID 
&,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8,P9),A0 &&,A1 
&&,A2 &&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&,A9 &&)': expects 12 arguments - 3 
provided [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(572): 
error C2780: 'process::Future process::dispatch(const process::Process 
*,process::Future (__cdecl T::* )(P0,P1,P2,P3,P4,P5,P6,P7,P8),A0 &&,A1 &&,A2 
&&,A3 &&,A4 &&,A5 &&,A6 &&,A7 &&,A8 &&)': expects 11 arguments - 3 provided 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\containerizer\mesos\conta

Re: Review Request 65326: Fixed conversion warning.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65326/#review196171
---




3rdparty/libprocess/src/tests/benchmarks.cpp
Line 677 (original), 677 (patched)


We do not seem to depend on this being a `size_t`, so I'd suggest to adjust 
the type here instead of casting below.


- Benjamin Bannier


On Jan. 24, 2018, 10:48 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65326/
> ---
> 
> (Updated Jan. 24, 2018, 10:48 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A "possible loss of data" warning was introduced because `process.run()`
> implicitly converts to an `int`. Since we have a finite set, we can
> ignore this warning and so silence it with a `static_cast`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 10fd492951fb1133d057eb3576f93a5f10e178f3 
> 
> 
> Diff: https://reviews.apache.org/r/65326/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 65326: Fixed conversion warning.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65326/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

A "possible loss of data" warning was introduced because `process.run()`
implicitly converts to an `int`. Since we have a finite set, we can
ignore this warning and so silence it with a `static_cast`.


Diffs
-

  3rdparty/libprocess/src/tests/benchmarks.cpp 
10fd492951fb1133d057eb3576f93a5f10e178f3 


Diff: https://reviews.apache.org/r/65326/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65324/
---

Review request for mesos, Gaston Kleiman, Greg Mann, and Kapil Arya.


Repository: mesos


Description
---

see summary.


Diffs
-

  configure.ac b48c80db4d01bf975168398865a12b700bd3d33c 
  src/webui/master/static/js/controllers.js 
59665869dbea77c00740e42f2590473181dfe2fe 


Diff: https://reviews.apache.org/r/65324/diff/1/


Testing
---


Thanks,

Till Toenshoff

Review Request 65323: WIP: Updated mesos containerizer to conditionally to ignore GPU isolator creation failure.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65323/
---

Review request for mesos, Greg Mann, Kapil Arya, and Kevin Klues.


Repository: mesos


Description
---

see summary.


Diffs
-

  configure.ac b48c80db4d01bf975168398865a12b700bd3d33c 
  src/Makefile.am fb2961e11af01070ff44601ad951a5972000d6d4 
  src/slave/containerizer/mesos/containerizer.cpp 
cd1e9ae8b8925cb97396dde22b6a3eb63ab65536 


Diff: https://reviews.apache.org/r/65323/diff/1/


Testing
---


Thanks,

Till Toenshoff

Review Request 65320: WIP: Conditionally set LIBPROCESS_IP into docker container.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65320/
---

Review request for mesos, Greg Mann and Kapil Arya.


Repository: mesos


Description
---

See summary.


Diffs
-

  configure.ac b48c80db4d01bf975168398865a12b700bd3d33c 
  src/Makefile.am fb2961e11af01070ff44601ad951a5972000d6d4 
  src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 


Diff: https://reviews.apache.org/r/65320/diff/1/


Testing
---


Thanks,

Till Toenshoff

Re: Review Request 65316: Added test for delayed authorization during operator events.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/#review196165
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65315', '65316']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65316

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65316/logs/mesos-tests-build-cmake-stdout.log):

```
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): 
warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _strdup. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): 
warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): 
warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
 warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.v

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

[Benjamin Mahler]

> On Jan. 24, 2018, 5:18 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/process.cpp
> > Lines 506 (patched)
> > 
> >
> > Any specific reason why this is not a value, i.e.,
> > ```
> > static std::mutex authorization_callbacks_mutex;
> > ```

No static non-PODs due to destruction issues:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65305/#review196143
---


On Jan. 24, 2018, 12:54 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65305/
> ---
> 
> (Updated Jan. 24, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Joseph Wu.
> 
> 
> Bugs: MESOS-8453
> https://issues.apache.org/jira/browse/MESOS-8453
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The authorization callbacks are not mutated in a thread-safe manner:
> a `Process` may be calling a callback while the callbacks are being
> deleted by another thread.
> 
> The fix here for now is to make the mutation and access synchronized
> under a mutex. The mutex is non-recursive, which means that the
> callbacks must not be cleared or re-set from within a callback. This
> is already a requirement, since a callback calling in to clear or
> re-set the callbacks is thereby deleting itself!
> 
> Some TODOs were left for performance improvements. Since the HTTP
> likely has much more significant bottlenecks, I left these as TODOs.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad 
> 
> 
> Diff: https://reviews.apache.org/r/65305/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 65319: Implement os::eraseenv on Windows.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65319/#review196162
---



PASS: Mesos patch 65319 was successfully built and tested.

Reviews applied: `['65319']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65319

- Mesos Reviewbot Windows


On Jan. 24, 2018, 7:06 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65319/
> ---
> 
> (Updated Jan. 24, 2018, 7:06 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8140
> https://issues.apache.org/jira/browse/MESOS-8140
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For compatibility with the POSIX API, add a Windows os::eraseenv
> implementation as a synonym for os::unsetenv.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 8c6f7a302b3bce8b88ed83dccc1ffd46c23b39ec 
> 
> 
> Diff: https://reviews.apache.org/r/65319/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 65316: Added test for delayed authorization during operator events.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
---

(Updated Jan. 24, 2018, 8:04 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.


Changes
---

Addressed Gaston's comment.


Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469


Repository: mesos


Description (updated)
---

Until the fix for MESOS-8469, it was possible for the master
operator event stream to drop events, if event-related state in
the master changed in between asynchronous calls.

This patch adds `MasterAPITest.EventAuthorizationDelayed` to
verify the fix for that issue.


Diffs (updated)
-

  src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 


Diff: https://reviews.apache.org/r/65316/diff/3/

Changes: https://reviews.apache.org/r/65316/diff/2-3/


Testing
---

Confirmed that the test fails without the fix for MESOS-8469.

When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh 
--gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" 
--gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.


Thanks,

Greg Mann

Re: Review Request 65316: Added test for delayed authorization during operator events.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/#review196161
---




src/tests/api_tests.cpp
Lines 2598-2600 (patched)


Please use this instead:

```
  EXPECT_CALL(*scheduler, connected(_))
.WillOnce(v1::scheduler::SendSubscribe(v1::DEFAULT_FRAMEWORK_INFO));
```



src/tests/api_tests.cpp
Lines 2620 (patched)


You don't need this if you remove the `connected` future and make the 
expectation use `v1::scheduler::SendSubscribe`.



src/tests/api_tests.cpp
Lines 2742-2757 (patched)


You can use:

```
  mesos.send(
  v1::createCallAccept(
  frameworkId,
  offer,
  {v1::LAUNCH({taskInfo}));
```


- Gaston Kleiman


On Jan. 24, 2018, 11:38 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65316/
> ---
> 
> (Updated Jan. 24, 2018, 11:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
> 
> 
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Until the fix for MESOS-8469, it was possible for the master
> operator event stream to drop events, if event-related state in
> the master changed in between asynchronous calls.
> 
> This patch adds `MasterAPITest.EventAuthorizationDelayed` to
> verify the fix for that issue.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 
> 
> 
> Diff: https://reviews.apache.org/r/65316/diff/1/
> 
> 
> Testing
> ---
> 
> Confirmed that the test fails without the fix for MESOS-8469.
> 
> When the fix is included, the test passes. Successfully ran 
> `bin/mesos-tests.sh 
> --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" 
> --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 65316: Added test for delayed authorization during operator events.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
---

(Updated Jan. 24, 2018, 7:50 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.


Changes
---

Implemented suggestions from Gaston.


Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469


Repository: mesos


Description (updated)
---

Added test for delayed authorization during operator events.


Diffs (updated)
-

  src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 


Diff: https://reviews.apache.org/r/65316/diff/2/

Changes: https://reviews.apache.org/r/65316/diff/1-2/


Testing
---

Confirmed that the test fails without the fix for MESOS-8469.

When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh 
--gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" 
--gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.


Thanks,

Greg Mann

Re: Review Request 65316: Added test for delayed authorization during operator events.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
---

(Updated Jan. 24, 2018, 7:38 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.


Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469


Repository: mesos


Description (updated)
---

Until the fix for MESOS-8469, it was possible for the master
operator event stream to drop events, if event-related state in
the master changed in between asynchronous calls.

This patch adds `MasterAPITest.EventAuthorizationDelayed` to
verify the fix for that issue.


Diffs
-

  src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 


Diff: https://reviews.apache.org/r/65316/diff/1/


Testing (updated)
---

Confirmed that the test fails without the fix for MESOS-8469.

When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh 
--gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" 
--gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.


Thanks,

Greg Mann

Review Request 65316: Added test for delayed authorization during operator events.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
---

Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.


Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469


Repository: mesos


Description
---

Added test for delayed authorization during operator events.


Diffs
-

  src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 


Diff: https://reviews.apache.org/r/65316/diff/1/


Testing
---

Confirmed that the test fails without the fix for MESOS-8469.

When the fix is included, the test passes. Successfully ran `` to rule out any 
flakiness.


Thanks,

Greg Mann

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65044/#review196152
---




src/master/http.cpp
Lines 741-742 (patched)


The case statements here seem to follow the order of the `Call.type` enum, 
so I'd move this block to line 734 (above `GET_TASKS`).



src/master/http.cpp
Line 3933 (original), 3961 (patched)


Shouldn't we add a similar method: `Master:Http:OPERATIONS_HELP()`?



src/master/validation.cpp
Lines 133-134 (patched)


Ditto, move this above `GET_TASKS`.


- Gaston Kleiman


On Jan. 24, 2018, 1:36 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65044/
> ---
> 
> (Updated Jan. 24, 2018, 1:36 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The 'GET_OPERATIONS' call lists all operations known to master or agent.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 315820041990d28e5cdae71c8385d4551d56558c 
>   include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd 
>   include/mesos/v1/agent/agent.proto 9e8b49defb83ffd4dd240ebb3a09b2dd3610ab2a 
>   include/mesos/v1/master/master.proto 
> 6759c3004e7e04c0044360b0c54f4438c2f6ec8a 
>   src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
>   src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 
>   src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 
>   src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 
>   src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a 
>   src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 
>   src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 
> 
> 
> Diff: https://reviews.apache.org/r/65044/diff/7/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65261/#review196156
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65317', '65261']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65261

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65261/logs/mesos-tests-build-cmake-stdout.log):

```
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): 
warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _strdup. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): 
warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): 
warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
 warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.v

Re: Review Request 65319: Implement os::eraseenv on Windows.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65319/#review196154
---


Ship it!




Ship It!

- Akash Gupta


On Jan. 24, 2018, 7:06 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65319/
> ---
> 
> (Updated Jan. 24, 2018, 7:06 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For compatibility with the POSIX API, add a Windows os::eraseenv
> implementation as a synonym for os::unsetenv.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 8c6f7a302b3bce8b88ed83dccc1ffd46c23b39ec 
> 
> 
> Diff: https://reviews.apache.org/r/65319/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 65319: Implement os::eraseenv on Windows.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65319/#review196153
---


Ship it!




Nit: two lines around functions in a namespace.

LGTM, thanks!

- Andrew Schwartzmeyer


On Jan. 24, 2018, 11:06 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65319/
> ---
> 
> (Updated Jan. 24, 2018, 11:06 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For compatibility with the POSIX API, add a Windows os::eraseenv
> implementation as a synonym for os::unsetenv.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 8c6f7a302b3bce8b88ed83dccc1ffd46c23b39ec 
> 
> 
> Diff: https://reviews.apache.org/r/65319/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 65319: Implement os::eraseenv on Windows.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65319/
---

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
---

For compatibility with the POSIX API, add a Windows os::eraseenv
implementation as a synonym for os::unsetenv.


Diffs
-

  3rdparty/stout/include/stout/windows/os.hpp 
8c6f7a302b3bce8b88ed83dccc1ffd46c23b39ec 


Diff: https://reviews.apache.org/r/65319/diff/1/


Testing
---

make check


Thanks,

James Peach

Re: Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/#review196150
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65315']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65315

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65315/logs/mesos-tests-build-cmake-stdout.log):

```
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): 
warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _strdup. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): 
warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): 
warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
 warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
 

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

[Andrew Schwartzmeyer]

> On Jan. 24, 2018, 8:47 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos tests failed to build.
> > 
> > Reviews applied: `['65308', '62447']`
> > 
> > Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447
> > 
> > Relevant logs:
> > 
> > - 
> > [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-build-cmake-stdout.log):
> > 
> > ```
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799):
> >  warning C4996: 'strcat': This function or variable may be unsafe. Consider 
> > using strcat_s instead. To disable deprecation, use 
> > _CRT_SECURE_NO_WARNINGS. See online help for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814):
> >  warning C4996: 'strcat': This function or variable may be unsafe. Consider 
> > using strcat_s instead. To disable deprecation, use 
> > _CRT_SECURE_NO_WARNINGS. See online help for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818):
> >  warning C4996: 'strcat': This function or variable may be unsafe. Consider 
> > using strcat_s instead. To disable deprecation, use 
> > _CRT_SECURE_NO_WARNINGS. See online help for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826):
> >  warning C4996: 'strcat': This function or variable may be unsafe. Consider 
> > using strcat_s instead. To disable deprecation, use 
> > _CRT_SECURE_NO_WARNINGS. See online help for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363):
> >  warning C4996: 'strdup': The POSIX name for this item is deprecated. 
> > Instead, use the ISO C and C++ conformant name: _strdup. See online help 
> > for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377):
> >  warning C4996: 'stricmp': The POSIX name for this item is deprecated. 
> > Instead, use the ISO C and C++ conformant name: _stricmp. See online help 
> > for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189):
> >  warning C4996: 'strerror': This function or variable may be unsafe. 
> > Consider using strerror_s instead. To disable deprecation, use 
> > _CRT_SECURE_NO_WARNINGS. See online help for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236):
> >  warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
> > using strcpy_s instead. To disable deprecation, use 
> > _CRT_SECURE_NO_WARNINGS. See online help for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241):
> >  warning C4996: 'strcat': This function or variable may be unsafe. Consider 
> > using strcat_s instead. To disable deprecation, use 
> > _CRT_SECURE_NO_WARNINGS. See online help for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253):
> >  warning C4996: 'strcat': This function or variable may be unsafe. Consider 
> > using strcat_s instead. To disable deprecation, use 
> > _CRT_SECURE_NO_WARNINGS. See online help for details. 
> > [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
> >  [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >   
> > D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
> >  warning C4996: 'stricmp': The POSIX name for this item is deprecated. 
> > Instead, use the ISO C an

Re: Review Request 65314: Removed code which is not used.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65314/#review196148
---



FAIL: Mesos stout-tests failed to build.

Reviews applied: `['65310', '65311', '65312', '65313', '65314']`

Failed command: `cmake.exe --build . --target stout-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65314

Relevant logs:

- 
[stout-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65314/logs/stout-tests-build-cmake-stdout.log):

```
  Unknown compiler version - please run the configure tests and report the 
results
  env_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  filesystem_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  process_tests.cpp
  rmdir_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  socket_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  Unknown compiler version - please run the configure tests and report the 
results
  strerror_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  Unknown compiler version - please run the configure tests and report the 
results
Done Building Project "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" 
(default targets) -- FAILED.

Build FAILED.

"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
(ClCompile target) -> 
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(115): error C2672: 
'lambda::zip': no matching overloaded function found 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(115): error C2783: 
'MapIterable lambda::zip(const InputIterable1 &,const 
InputIterable2 &)': could not deduce template argument for 
'MapIterable' [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(129): error C2672: 
'lambda::zipto': no matching overloaded function found 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(129): error C2783: 
'OutputIterable> lambda::zipto(const 
InputIterable1 &,const InputIterable2 &)': could not 
deduce template argument for 'HeterogeneusContainer' 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]

0 Warning(s)
4 Error(s)

Time Elapsed 00:01:12.97
```

- 
[stout-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65314/logs/stout-tests-CMakeOutput.log):

```
  Creating directory "cmTC_f098a.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_f098a.dir\Debug\cmTC_f098a.tlog\".

InitializeBuildStatus:

  Creating "cmTC_f098a.dir\Debug\cmTC_f098a.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi 
/W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_f098a.dir\Debug\" /Fd"cmTC_f098a.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_f098a.dir\Debug\" /Fd"cmTC_f098a.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe 
/ERRORREPORT:QUEUE 
/OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_f098a.exe" /INCREMENTAL 
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib 
oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST 
/MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG 
/PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_f098a.pdb" 
/SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT 
/IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_f098a.lib" /MACHINE:X64  
/machine:x64 cmTC_f098a.dir\Debug\src.obj

  cmTC_f098a.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_f098a.exe

FinalizeBuildStatus:

  Deleting file "cmTC_f098a.dir\Debug\cmTC_f098a.tlog\unsuccessfulbuild".

  Touching "cmTC_f0

Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.

[Andrei Budnik]

> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote:
> > src/slave/containerizer/mesos/paths.hpp
> > Lines 147-149 (patched)
> > 
> >
> > Let's find a more descriptive word for this, "temp" can mean anything. 
> > We want to say, that this is a path that exists before the socket is being 
> > listend on, or, in other words, fully initialized.
> > 
> > How about "prefatory" or "preparatory". Maybe "prep" is sufficient. Can 
> > you please consult a native English speaker?

Renamed "temporary" to "provisional".


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65261/#review196009
---


On Jan. 22, 2018, 1 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65261/
> ---
> 
> (Updated Jan. 22, 2018, 1 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7742
> https://issues.apache.org/jira/browse/MESOS-7742
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Once IOSwitchboard's unix socket appears in the file system, the agent
> can try to connect to it. If the agent attempts to connect to the
> socket before `listen` has been called, then it gets connection refused
> error. To address this, we initialize a unix socket using a provisional
> path and rename it after `listen` has been called.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 45b615be60af9af839309011eea85912c01ff451 
>   src/slave/containerizer/mesos/paths.hpp 
> 65830a153f765c74bb0399bca9b2941390eeb531 
>   src/slave/containerizer/mesos/paths.cpp 
> 0df4cf5f50aee94a2758ce885389fb488a85fdbd 
> 
> 
> Diff: https://reviews.apache.org/r/65261/diff/2/
> 
> 
> Testing
> ---
> 
> make check (Fedora 25)
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 65317: Used a namespace for paths in IOSwitchboard.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65317/
---

Review request for mesos, Alexander Rukletsov and Kevin Klues.


Repository: mesos


Description
---

Used a namespace for paths in IOSwitchboard.


Diffs
-

  src/slave/containerizer/mesos/io/switchboard.cpp 
45b615be60af9af839309011eea85912c01ff451 


Diff: https://reviews.apache.org/r/65317/diff/1/


Testing
---

make check


Thanks,

Andrei Budnik

Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/
---

Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.


Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469


Repository: mesos


Description
---

Moved 'ObjectApproverAll' into a header for use in tests.


Diffs
-

  src/tests/mesos.hpp a35c68e8645384f6244d17e37cad71373aba6893 
  src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908 


Diff: https://reviews.apache.org/r/65315/diff/1/


Testing
---

Testing details in the child review.


Thanks,

Greg Mann

Re: Review Request 65310: Added lambda::zip.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/#review196146
---



FAIL: Mesos stout-tests failed to build.

Reviews applied: `['65310']`

Failed command: `cmake.exe --build . --target stout-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65310

Relevant logs:

- 
[stout-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65310/logs/stout-tests-build-cmake-stdout.log):

```
  copyfile_tests.cpp
  env_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  Unknown compiler version - please run the configure tests and report the 
results
  filesystem_tests.cpp
  process_tests.cpp
  rmdir_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  socket_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  Unknown compiler version - please run the configure tests and report the 
results
  strerror_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  Unknown compiler version - please run the configure tests and report the 
results
Done Building Project "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" 
(default targets) -- FAILED.

Build FAILED.

"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
(ClCompile target) -> 
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(115): error C2672: 
'lambda::zip': no matching overloaded function found 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(115): error C2783: 
'MapIterable lambda::zip(const InputIterable1 &,const 
InputIterable2 &)': could not deduce template argument for 
'MapIterable' [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(129): error C2672: 
'lambda::zipto': no matching overloaded function found 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(129): error C2783: 
'OutputIterable> lambda::zipto(const 
InputIterable1 &,const InputIterable2 &)': could not 
deduce template argument for 'HeterogeneusContainer' 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]

0 Warning(s)
4 Error(s)

Time Elapsed 00:01:08.90
```

- 
[stout-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65310/logs/stout-tests-CMakeOutput.log):

```
  Creating directory "cmTC_4bc2c.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_4bc2c.dir\Debug\cmTC_4bc2c.tlog\".

InitializeBuildStatus:

  Creating "cmTC_4bc2c.dir\Debug\cmTC_4bc2c.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi 
/W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_4bc2c.dir\Debug\" /Fd"cmTC_4bc2c.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_4bc2c.dir\Debug\" /Fd"cmTC_4bc2c.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe 
/ERRORREPORT:QUEUE 
/OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_4bc2c.exe" /INCREMENTAL 
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib 
oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST 
/MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG 
/PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_4bc2c.pdb" 
/SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT 
/IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_4bc2c.lib" /MACHINE:X64  
/machine:x64 cmTC_4bc2c.dir\Debug\src.obj

  cmTC_4bc2c.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_4bc2c.exe

FinalizeBuildStatus:

  Deleting file "cmTC_4bc2c.dir\Debug\cmTC_4bc2c.tlog\unsuccessfulbuild".

  Touching "cmTC_4bc2c.dir\Debug\cmTC_4bc2c.tlog\cmTC_4bc2c.lastbuildstate".

Done Building Project "D:\DCOS\mesos\CMa

Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65311/
---

Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

Introduces the class `ObjectApprovers` which unifies the different
mechanisms used in Mesos in order to perform authorization.

This new class will supersede the `Acceptor` interfaces and their
logic.

Follow up patches will make use of this interface and remove
deprecated code.


Diffs
-

  src/common/http.hpp 750d3bfba1647624983108bdd23295a3b3091fe4 
  src/common/http.cpp 728fc554917ed031f9cb3d811fbbc064307b3e32 


Diff: https://reviews.apache.org/r/65311/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas

Review Request 65312: Refactored authorization logic in the master.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65312/
---

Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

This patch makes uses of the new `ObjectApprovers` class which greatly
simplifies the logic for constructing and using authorization.


Diffs
-

  src/common/protobuf_utils.hpp 0ff7239dd6b8f74119fdd97531d94af21fd0500c 
  src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
  src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
  src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 
  src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 


Diff: https://reviews.apache.org/r/65312/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas

Review Request 65313: Refactored authorization logic in the agent.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65313/
---

Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

This patch makes uses of the new `ObjectApprovers` class which greatly
simplifies the logic for constructing and using authorization.


Diffs
-

  src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 
  src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a 
  src/slave/slave.cpp 43c7955237655accdf869db1b6494a35f77acdb3 


Diff: https://reviews.apache.org/r/65313/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas

Review Request 65314: Removed code which is not used.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65314/
---

Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

The introduction of the `ObjectApprovers` abstraction rendered the
`AuthorizationAcceptor` class oboslete. After the refactor of the code
the acceptor class was no longer used, nor were the helper functions
built around it.

This patch removes that obsolete code.


Diffs
-

  src/common/http.hpp 750d3bfba1647624983108bdd23295a3b3091fe4 
  src/common/http.cpp 728fc554917ed031f9cb3d811fbbc064307b3e32 


Diff: https://reviews.apache.org/r/65314/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas

Review Request 65310: Added lambda::zip.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/
---

Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

Introduces the abstraction `zip` and `zipto` which allow for sets of
heterogeneus containers to be merged into a single container of
heterogeneus tuples (or pairs).

`zip` is an specialization which focuses on zipping to map style of
containers, such as `hashmap`, `unordered_map` and `map`, while
`zipto` creates linear containers like `vector` and `list`.

This patch supersedes the staled review
https://reviews.apache.org/r/63292/.


Diffs
-

  3rdparty/stout/include/stout/lambda.hpp 
c9212be27b45da45f15371689f2aabf18c98657b 
  3rdparty/stout/tests/lambda_tests.cpp 
11b034306b11b95efa9bcd9811c5145ad39314a5 


Diff: https://reviews.apache.org/r/65310/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review196142
---



FAIL: Failed to apply the dependent review: 63366.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63366`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372

Relevant logs:

- 
[apply-review-63366-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372/logs/apply-review-63366-stdout.log):

```
error: missing binary patch data for '3rdparty/jemalloc-5.0.1.tar.bz2'
error: binary patch does not apply to '3rdparty/jemalloc-5.0.1.tar.bz2'
error: 3rdparty/jemalloc-5.0.1.tar.bz2: patch does not apply
```

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65305/#review196143
---




3rdparty/libprocess/src/process.cpp
Lines 506 (patched)


Any specific reason why this is not a value, i.e.,
```
static std::mutex authorization_callbacks_mutex;
```


- Alexander Rukletsov


On Jan. 24, 2018, 12:54 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65305/
> ---
> 
> (Updated Jan. 24, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Joseph Wu.
> 
> 
> Bugs: MESOS-8453
> https://issues.apache.org/jira/browse/MESOS-8453
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The authorization callbacks are not mutated in a thread-safe manner:
> a `Process` may be calling a callback while the callbacks are being
> deleted by another thread.
> 
> The fix here for now is to make the mutation and access synchronized
> under a mutex. The mutex is non-recursive, which means that the
> callbacks must not be cleared or re-set from within a callback. This
> is already a requirement, since a callback calling in to clear or
> re-set the callbacks is thereby deleting itself!
> 
> Some TODOs were left for performance improvements. Since the HTTP
> likely has much more significant bottlenecks, I left these as TODOs.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad 
> 
> 
> Diff: https://reviews.apache.org/r/65305/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 65290: Reverted usage of the -isystem flag for includes (3/3).

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65290/#review196141
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65308', '62447', '65289', '65290']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65290

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65290/logs/mesos-tests-build-cmake-stdout.log):

```
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): 
warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _strdup. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): 
warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): 
warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
 warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63367/#review196140
---



I would prefer a more general, systematic approach to this situation.
I really don't want to be deal with adding `string` and `const char []`
overloads everywhere. Ideally, we'd have a `string_view` class that we
could use instead of `string` here.

Now, as far as performance goes, there are a couple of things to note.
  (1) It seems like the claim is that it speeds up the tests? by how much?
  (2) The claim that we avoid an unnecessary allocation isn't actually
  true considering that the strings (at least in our tests) probably
  fit within the short-string optimization.
  (3) Is this change by itself a big win somewhere? or will it require
  a systematic change where `string` can be a `string_view`?
  If the former, I'd be fine with optimizing these functions, but
  if it's the former, I'd say we should invest in a `string_view` class.

I quite like performance, but some more evidence would be helpful here.

Now, under the assumption that the performance argument to be justified,
we can simply make the existing function a template and generalize the logic:

```cpp
template 
bool startsWith(const string& s, const Stringish& prefix) {
  return s.size() >= distance(begin(prefix), end(prefix)) &&
 equal(begin(prefix), end(prefix), begin(s));
}
```

- Michael Park


On Jan. 24, 2018, 7:12 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63367/
> ---
> 
> (Updated Jan. 24, 2018, 7:12 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This saves an unnecessary memory allocation when
> testing if a string starts or ends with a string literal,
> which accounts for almost all usages of these functions
> in Mesos and in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/strings.hpp 
> 067a7923c02342bccd9be1136a981fd6b0e0e9b4 
>   3rdparty/stout/tests/strings_tests.cpp 
> 395540aad88c76a66a43a54edfe9ca1a2d46d3b4 
> 
> 
> Diff: https://reviews.apache.org/r/63367/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review196137
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65308', '62447']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-build-cmake-stdout.log):

```
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): 
warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _strdup. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): 
warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): 
warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
 warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.v

Re: Review Request 65307: Cleaned up interface defintion in duration header.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65307/#review196136
---


Ship it!




Ship It!

- Alexander Rukletsov


On Jan. 24, 2018, 4:38 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65307/
> ---
> 
> (Updated Jan. 24, 2018, 4:38 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved a function definition out of the class to not clutter
> the class definition.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/duration.hpp 
> 930e4819c206ede7a41725bfae9360b17e69bf7a 
> 
> 
> Diff: https://reviews.apache.org/r/65307/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63366: Added jemalloc release tarball and build rules.

[Benno Evers]

> On Nov. 10, 2017, 3:52 p.m., Alexander Rukletsov wrote:
> > configure.ac
> > Lines 213 (patched)
> > 
> >
> > Maybe "jemalloc-allocator"? Or "bundled-jemalloc"?

I think 'jemalloc-allocator' sounds good, changed.


> On Nov. 10, 2017, 3:52 p.m., Alexander Rukletsov wrote:
> > configure.ac
> > Lines 1144-1147 (original), 1206-1209 (patched)
> > 
> >
> > Is this change on purpose?

Nope. (Actually, I don't even know how to do this accidentally)


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/#review190721
---


On Jan. 24, 2018, 4:37 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63366/
> ---
> 
> (Updated Jan. 24, 2018, 4:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows building and linking against the bundled
> version of jemalloc when the --enable-jemalloc-allocator
> configuration flag is specified.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda 
>   3rdparty/Makefile.am f4cb731198e271b967b920235ed2785e9296f9e1 
>   3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d 
>   3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> f002c157dc2ca64da66bc4e61f5095f2b533ae1f 
>   3rdparty/versions.am 3e008d5a7bdc029de23950463c295b968b3280c8 
>   cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
>   configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6 
>   src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54 
>   src/master/CMakeLists.txt ec552110509d17628107f4ad98f2d04675ed3ce3 
>   src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 
> 
> 
> Diff: https://reviews.apache.org/r/63366/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/
---

(Updated Jan. 24, 2018, 4:40 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rewritten for API change.


Summary (updated)
-

Added documentation for memory profiling.


Repository: mesos


Description (updated)
---

Added documentation for memory profiling.


Diffs (updated)
-

  docs/memory-profiling.md PRE-CREATION 


Diff: https://reviews.apache.org/r/63372/diff/2/

Changes: https://reviews.apache.org/r/63372/diff/1-2/


Testing
---


Thanks,

Benno Evers

Review Request 65307: Cleaned up interface defintion in duration header.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65307/
---

Review request for mesos.


Repository: mesos


Description
---

Moved a function definition out of the class to not clutter
the class definition.


Diffs
-

  3rdparty/stout/include/stout/duration.hpp 
930e4819c206ede7a41725bfae9360b17e69bf7a 


Diff: https://reviews.apache.org/r/65307/diff/1/


Testing
---


Thanks,

Benno Evers

Re: Review Request 63366: Added jemalloc release tarball and build rules.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/
---

(Updated Jan. 24, 2018, 4:37 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Changes
---

Renamed option to jemalloc-allocator


Repository: mesos


Description (updated)
---

This allows building and linking against the bundled
version of jemalloc when the --enable-jemalloc-allocator
configuration flag is specified.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda 
  3rdparty/Makefile.am f4cb731198e271b967b920235ed2785e9296f9e1 
  3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d 
  3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
f002c157dc2ca64da66bc4e61f5095f2b533ae1f 
  3rdparty/versions.am 3e008d5a7bdc029de23950463c295b968b3280c8 
  cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
  configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6 
  src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54 
  src/master/CMakeLists.txt ec552110509d17628107f4ad98f2d04675ed3ce3 
  src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 


Diff: https://reviews.apache.org/r/63366/diff/2/

Changes: https://reviews.apache.org/r/63366/diff/1-2/


Testing
---


Thanks,

Benno Evers

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65305/#review196133
---


Ship it!




Ship It!

- Alexander Rukletsov


On Jan. 24, 2018, 12:54 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65305/
> ---
> 
> (Updated Jan. 24, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Joseph Wu.
> 
> 
> Bugs: MESOS-8453
> https://issues.apache.org/jira/browse/MESOS-8453
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The authorization callbacks are not mutated in a thread-safe manner:
> a `Process` may be calling a callback while the callbacks are being
> deleted by another thread.
> 
> The fix here for now is to make the mutation and access synchronized
> under a mutex. The mutex is non-recursive, which means that the
> callbacks must not be cleared or re-set from within a callback. This
> is already a requirement, since a callback calling in to clear or
> re-set the callbacks is thereby deleting itself!
> 
> Some TODOs were left for performance improvements. Since the HTTP
> likely has much more significant bottlenecks, I left these as TODOs.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad 
> 
> 
> Diff: https://reviews.apache.org/r/65305/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 65290: Reverted usage of the -isystem flag for includes (3/3).

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65290/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

This flag break the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129


Diffs
-

  3rdparty/stout/Makefile.am 313e4fef61ad73276a5636c31a009f813e37263b 
  3rdparty/stout/configure.ac 6db22877ca518ff47853f9c49e30d78f5b8c240d 


Diff: https://reviews.apache.org/r/65290/diff/1/


Testing
---


Thanks,

Benno Evers

Review Request 65289: Reverted usage of the -isystem flag for includes (2/3).

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65289/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

This flag break the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129


Diffs
-

  3rdparty/libprocess/Makefile.am ba9e78148932304ce1961b88e5f97180abd35586 
  3rdparty/libprocess/configure.ac 1069d5740e9adc8c0510dc8cb0268da02abe0d9e 


Diff: https://reviews.apache.org/r/65289/diff/1/


Testing
---


Thanks,

Benno Evers

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/
---

(Updated Jan. 24, 2018, 4:18 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Repository: mesos


Description
---

This flag break the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129


Diffs (updated)
-

  3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda 
  configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6 
  docs/cmake-examples.md e7274a48a9b73abce4e5c00fc9b5bef6e9a9ad82 
  m4/libnl3.m4 238ac6e01ea6d1897bd307a84ca522250f34c0fa 
  src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54 


Diff: https://reviews.apache.org/r/62447/diff/5/

Changes: https://reviews.apache.org/r/62447/diff/4-5/


Testing
---


Thanks,

Benno Evers

Re: Review Request 65308: Fix shadowed sign-compare and enum-compare warnings in tests.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65308/
---

(Updated Jan. 24, 2018, 4:17 p.m.)


Review request for mesos and Benjamin Bannier.


Summary (updated)
-

Fix shadowed sign-compare and enum-compare warnings in tests.


Bugs: MESOS-8482
https://issues.apache.org/jira/browse/MESOS-8482


Repository: mesos


Description (updated)
---

These warnings were hidden due to the usage of the '-isystem'
flag to include the gtest headers.


Diffs (updated)
-

  src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 
  src/tests/check_tests.cpp 0163e3a2fe9d28d0579fb454f2f1c1912c57b0f8 
  src/tests/containerizer/cni_isolator_tests.cpp 
364e2e30a76daff7eaa2b2acaada05b4124ef7a4 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
0729464a7a9b290c8634536e58909f9b38b58a9c 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
db60bfb143765be6d3eeab6a54663774ea14b8fa 
  src/tests/default_executor_tests.cpp f8ae0379998898aefcac930f410f67cdb2c08f66 
  src/tests/disk_quota_tests.cpp 4e25e32bf784ea818e18497fe3ebc9f94c5861ff 
  src/tests/fault_tolerance_tests.cpp 2dfd00938d0d46135ece77cec45a8fd28867b055 
  src/tests/hierarchical_allocator_tests.cpp 
9bc939d8be4d029ef9ca996ce2a074e3af512f6f 
  src/tests/master_slave_reconciliation_tests.cpp 
26ff6893a9d6bbc34bcdcad9c9304f75ab283d9f 
  src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
  src/tests/master_validation_tests.cpp 
ed8f9bd31828035c19e5a38d3ad459649027b5b6 
  src/tests/oversubscription_tests.cpp e6139b0d353ad268ae2d09d47c43ff27a4af4c1e 
  src/tests/slave_tests.cpp 3a6546b07ac202c461b5c5e8bfcf1eb4f3fe6b4e 
  src/tests/sorter_tests.cpp 6ca724d35da13bd1ceb19f87af9a7950a5a982cf 


Diff: https://reviews.apache.org/r/65308/diff/2/

Changes: https://reviews.apache.org/r/65308/diff/1-2/


Testing
---


Thanks,

Benno Evers

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review196127
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65308', '62447']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62447/logs/mesos-tests-build-cmake-stdout.log):

```
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): 
warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _strdup. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): 
warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): 
warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
 warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.v

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63367/
---

(Updated Jan. 24, 2018, 3:12 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Changes
---

Add symmetric overload for `strings::startsWith()`


Summary (updated)
-

Added overloads for strings::startsWith and strings::endsWith().


Repository: mesos


Description (updated)
---

This saves an unnecessary memory allocation when
testing if a string starts or ends with a string literal,
which accounts for almost all usages of these functions
in Mesos and in libprocess.


Diffs (updated)
-

  3rdparty/stout/include/stout/strings.hpp 
067a7923c02342bccd9be1136a981fd6b0e0e9b4 
  3rdparty/stout/tests/strings_tests.cpp 
395540aad88c76a66a43a54edfe9ca1a2d46d3b4 


Diff: https://reviews.apache.org/r/63367/diff/3/

Changes: https://reviews.apache.org/r/63367/diff/2-3/


Testing
---


Thanks,

Benno Evers

Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/
---

(Updated Jan. 24, 2018, 2:57 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Summary (updated)
-

Reverted usage of the -isystem flag for includes (1/3).


Repository: mesos


Description (updated)
---

This flag break the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129


Diffs (updated)
-

  3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda 
  configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6 
  m4/libnl3.m4 238ac6e01ea6d1897bd307a84ca522250f34c0fa 
  src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54 


Diff: https://reviews.apache.org/r/62447/diff/4/

Changes: https://reviews.apache.org/r/62447/diff/3-4/


Testing
---


Thanks,

Benno Evers

Review Request 65308: WIP: Fix warnings in tests.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65308/
---

Review request for mesos.


Repository: mesos


Description
---

WIP: Fix warnings in tests.


Diffs
-

  src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 
  src/tests/check_tests.cpp 0163e3a2fe9d28d0579fb454f2f1c1912c57b0f8 
  src/tests/containerizer/cni_isolator_tests.cpp 
364e2e30a76daff7eaa2b2acaada05b4124ef7a4 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
0729464a7a9b290c8634536e58909f9b38b58a9c 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
db60bfb143765be6d3eeab6a54663774ea14b8fa 
  src/tests/default_executor_tests.cpp f8ae0379998898aefcac930f410f67cdb2c08f66 
  src/tests/disk_quota_tests.cpp 4e25e32bf784ea818e18497fe3ebc9f94c5861ff 
  src/tests/fault_tolerance_tests.cpp 2dfd00938d0d46135ece77cec45a8fd28867b055 
  src/tests/hierarchical_allocator_tests.cpp 
9bc939d8be4d029ef9ca996ce2a074e3af512f6f 
  src/tests/master_slave_reconciliation_tests.cpp 
26ff6893a9d6bbc34bcdcad9c9304f75ab283d9f 
  src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
  src/tests/master_validation_tests.cpp 
ed8f9bd31828035c19e5a38d3ad459649027b5b6 
  src/tests/oversubscription_tests.cpp e6139b0d353ad268ae2d09d47c43ff27a4af4c1e 
  src/tests/slave_tests.cpp 3a6546b07ac202c461b5c5e8bfcf1eb4f3fe6b4e 
  src/tests/sorter_tests.cpp 6ca724d35da13bd1ceb19f87af9a7950a5a982cf 


Diff: https://reviews.apache.org/r/65308/diff/1/


Testing
---


Thanks,

Benno Evers

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

[Benno Evers]

> On Jan. 24, 2018, 2:24 p.m., Benno Evers wrote:
> > Ship It!

Modulo Ben Mahlers comments, of course.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64574/#review196115
---


On Jan. 18, 2018, 5:46 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64574/
> ---
> 
> (Updated Jan. 18, 2018, 5:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5333
> https://issues.apache.org/jira/browse/MESOS-5333
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this patch, adding a trailing '/' to a valid URL path, e.g.,
> "/state/", yielded a 404 response. This patch ensures that two URLs
> which differ only in trailing '/' produce the same result.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> f79d366baecc73e6b14df593a906264f5fd1d72b 
> 
> 
> Diff: https://reviews.apache.org/r/64574/diff/2/
> 
> 
> Testing
> ---
> 
> Ensured the modified test fails without the fix.
> `make check` on Mac OS 10.11.6 and several Linux distributions.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 64574: Ensured trailing '/' in URL is insignificant.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64574/#review196115
---


Ship it!




Ship It!

- Benno Evers


On Jan. 18, 2018, 5:46 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64574/
> ---
> 
> (Updated Jan. 18, 2018, 5:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5333
> https://issues.apache.org/jira/browse/MESOS-5333
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this patch, adding a trailing '/' to a valid URL path, e.g.,
> "/state/", yielded a 404 response. This patch ensures that two URLs
> which differ only in trailing '/' produce the same result.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> f79d366baecc73e6b14df593a906264f5fd1d72b 
> 
> 
> Diff: https://reviews.apache.org/r/64574/diff/2/
> 
> 
> Testing
> ---
> 
> Ensured the modified test fails without the fix.
> `make check` on Mac OS 10.11.6 and several Linux distributions.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 63365: Re-ordered some configuration options alphabetically.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63365/
---

(Updated Jan. 24, 2018, 1:58 p.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description (updated)
---

Re-ordered some configuration options alphabetically.


Diffs (updated)
-

  configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6 
  src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54 


Diff: https://reviews.apache.org/r/63365/diff/2/

Changes: https://reviews.apache.org/r/63365/diff/1-2/


Testing
---


Thanks,

Benno Evers

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65305/#review196106
---


Ship it!




Ship It!

- Alexander Rojas


On Jan. 24, 2018, 1:54 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65305/
> ---
> 
> (Updated Jan. 24, 2018, 1:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Joseph Wu.
> 
> 
> Bugs: MESOS-8453
> https://issues.apache.org/jira/browse/MESOS-8453
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The authorization callbacks are not mutated in a thread-safe manner:
> a `Process` may be calling a callback while the callbacks are being
> deleted by another thread.
> 
> The fix here for now is to make the mutation and access synchronized
> under a mutex. The mutex is non-recursive, which means that the
> callbacks must not be cleared or re-set from within a callback. This
> is already a requirement, since a callback calling in to clear or
> re-set the callbacks is thereby deleting itself!
> 
> Some TODOs were left for performance improvements. Since the HTTP
> likely has much more significant bottlenecks, I left these as TODOs.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad 
> 
> 
> Diff: https://reviews.apache.org/r/65305/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65044/
---

(Updated Jan. 24, 2018, 10:36 a.m.)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jie 
Yu.


Changes
---

Addressed issues.


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

The 'GET_OPERATIONS' call lists all operations known to master or agent.


Diffs (updated)
-

  include/mesos/agent/agent.proto 315820041990d28e5cdae71c8385d4551d56558c 
  include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd 
  include/mesos/v1/agent/agent.proto 9e8b49defb83ffd4dd240ebb3a09b2dd3610ab2a 
  include/mesos/v1/master/master.proto 6759c3004e7e04c0044360b0c54f4438c2f6ec8a 
  src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
  src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 
  src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 
  src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 
  src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a 
  src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 
  src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 


Diff: https://reviews.apache.org/r/65044/diff/7/

Changes: https://reviews.apache.org/r/65044/diff/6-7/


Testing
---

make check


Thanks,

Jan Schlicht