Re: Review Request 71333: Avoided copying the clientPath in the sorter.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71333/#review217344
---



Patch looks great!

Reviews applied: [71333]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 21, 2019, 12:59 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71333/
> ---
> 
> (Updated Aug. 21, 2019, 12:59 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Avoided copying the clientPath in the sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/sorter/drf/sorter.hpp 
> 537086039fd804453ea8c682cda775d8fdff038f 
>   src/master/allocator/mesos/sorter/random/sorter.hpp 
> f18b014ed15ff8906fbdbd3248becefde896651c 
> 
> 
> Diff: https://reviews.apache.org/r/71333/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 71333: Avoided copying the clientPath in the sorter.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71333/
---

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Repository: mesos


Description
---

Avoided copying the clientPath in the sorter.


Diffs
-

  src/master/allocator/mesos/sorter/drf/sorter.hpp 
537086039fd804453ea8c682cda775d8fdff038f 
  src/master/allocator/mesos/sorter/random/sorter.hpp 
f18b014ed15ff8906fbdbd3248becefde896651c 


Diff: https://reviews.apache.org/r/71333/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 71303: Tracked frameworks in the role sorter.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71303/#review217341
---



Bad review!

Reviews applied: [71303, 71301, 71269, 71258, 71257, 71255, 71254]

Error:
2019-08-20 23:14:47 URL:https://reviews.apache.org/r/71254/diff/raw/ 
[5967/5967] -> "71254.patch" [1]
error: patch failed: src/master/allocator/mesos/sorter/drf/sorter.cpp:17
error: src/master/allocator/mesos/sorter/drf/sorter.cpp: patch does not apply
error: patch failed: src/master/allocator/mesos/sorter/random/sorter.cpp:17
error: src/master/allocator/mesos/sorter/random/sorter.cpp: patch does not apply

- Mesos Reviewbot


On Aug. 16, 2019, 5 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71303/
> ---
> 
> (Updated Aug. 16, 2019, 5 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9917
> https://issues.apache.org/jira/browse/MESOS-9917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This paves the way for removing the framework sorters.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 580d35a3b71c1f7e851fa0504c6b9f037c05c378 
>   src/master/allocator/mesos/sorter/drf/sorter.hpp 
> 537086039fd804453ea8c682cda775d8fdff038f 
>   src/master/allocator/mesos/sorter/drf/sorter.cpp 
> 09889cdf3dc8c0e773b8e2e24154fb0edd2cc254 
>   src/master/allocator/mesos/sorter/random/sorter.hpp 
> f18b014ed15ff8906fbdbd3248becefde896651c 
>   src/master/allocator/mesos/sorter/random/sorter.cpp 
> 60a5797472460a8d3d9be938af9f6711ea51d484 
>   src/master/allocator/mesos/sorter/sorter.hpp 
> 52b8a7b57bf17759311b32aa56c26e614119b773 
> 
> 
> Diff: https://reviews.apache.org/r/71303/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/
---

(Updated Aug. 20, 2019, 4:10 p.m.)


Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Repository: mesos


Description
---

This provides easy lookup.

Also refactored related functions to take in `Framework&`
instead of `FrameworkId&`.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
035fd3d7892d4280e299a29f99e8cf6a4c2afb30 
  src/master/allocator/mesos/hierarchical.cpp 
b8b9241eae20691ed52c9b5759b17f88a0d8931f 


Diff: https://reviews.apache.org/r/71301/diff/5/

Changes: https://reviews.apache.org/r/71301/diff/4-5/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 71174: Recovered network info for nested/standalone containers in CNI isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71174/#review217339
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 542-547 (original), 542-556 (patched)


We distinguish the top level container from nested container by 
has_executor_info and has_container_info. Please add comments because people 
may not know it if they don't check ContainerState proto.


- Gilbert Song


On July 29, 2019, 1:40 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71174/
> ---
> 
> (Updated July 29, 2019, 1:40 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9909
> https://issues.apache.org/jira/browse/MESOS-9909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Recovered network info for nested/standalone containers in CNI isolator.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> a60c96302a6cec90ecd0a0885b844fff8d37db71 
>   src/common/protobuf_utils.hpp 5d6a35d6e3bae35b83e87827724206f7c5dfb2d8 
>   src/common/protobuf_utils.cpp 7778e7f2475e9d6125d1c599715c91715f3654d3 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a01edc8793a2eaa655f1729a01a01f1f61fbf7cb 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> f2989cf7a2161154bb7d9bf2112bee8dd3cc5cf5 
> 
> 
> Diff: https://reviews.apache.org/r/71174/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71318/#review217336
---



Patch looks great!

Reviews applied: [71314, 71315, 71316, 71317, 71318]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 20, 2019, 5:28 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71318/
> ---
> 
> (Updated Aug. 20, 2019, 5:28 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9892
> https://issues.apache.org/jira/browse/MESOS-9892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds an extra step to a couple of the agent draining tests,
> which calls REACTIVATE_AGENT at the end.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71318/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71318/
---

(Updated Aug. 20, 2019, 10:28 a.m.)


Review request for mesos, Benno Evers and Greg Mann.


Changes
---

The extra `Clock::advance()` was triggering an additional status update if the 
agent did not receive the ACK in time.  This makes the tests wait for the ACK.


Bugs: MESOS-9892
https://issues.apache.org/jira/browse/MESOS-9892


Repository: mesos


Description
---

This adds an extra step to a couple of the agent draining tests,
which calls REACTIVATE_AGENT at the end.


Diffs (updated)
-

  src/tests/master_draining_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71318/diff/2/

Changes: https://reviews.apache.org/r/71318/diff/1-2/


Testing
---

make check


Thanks,

Joseph Wu

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

[Andrei Sekretenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/#review217335
---




src/master/allocator/mesos/hierarchical.cpp
Line 556 (original), 557 (patched)


Hmm... honestly, I didn't realize that this signature (and also 
`updateFramework()`'s) had the same issue for a long time (likely since the 
moment when the "id" field was added into `FrameworkInfo`).

Makes me wonder if we can change these signatures. 
If we cannot - maybe it makes more sense to 
`CHECK_EQ(frameworkInfo.id(), frameworkId);`
instead of 
`CHECK(frameworkInfo.has_id()); CHECK(frameworkInfo.id().value() != "");` ?


- Andrei Sekretenko


On Aug. 16, 2019, 10:53 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71301/
> ---
> 
> (Updated Aug. 16, 2019, 10:53 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This provides easy lookup.
> 
> Also refactored related functions to take in `Framework&`
> instead of `FrameworkId&`.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 035fd3d7892d4280e299a29f99e8cf6a4c2afb30 
>   src/master/allocator/mesos/hierarchical.cpp 
> b8b9241eae20691ed52c9b5759b17f88a0d8931f 
> 
> 
> Diff: https://reviews.apache.org/r/71301/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 71297: Fixed a flaky operation reconciliation test.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71297/#review217334
---



Patch looks great!

Reviews applied: [71297]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 19, 2019, 8:36 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71297/
> ---
> 
> (Updated Aug. 19, 2019, 8:36 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Greg Mann, Joseph Wu, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-9928
> https://issues.apache.org/jira/browse/MESOS-9928
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The FrameworkReconciliationRaceWithUpdateSlave test from the
> operation reconciliation tests was flaky since we did not wait
> for the scheduler to reconnect before attempting to send a
> subscribe call.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 9d084c027ec2f910515cafebf715f7428c43f1a9 
> 
> 
> Diff: https://reviews.apache.org/r/71297/diff/2/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests 
> --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" 
> --gtest_repeat=200` while simultaneously running `stress-ng` in the 
> background.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71329: Updated CentOS 6 dockerfile to properly install devtoolset-7.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71329/#review217333
---


Ship it!




Ship It!

- Benjamin Bannier


On Aug. 20, 2019, 2:52 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71329/
> ---
> 
> (Updated Aug. 20, 2019, 2:52 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previously used yum command was not able to properly install
> the required `devtoolset-7` package since the containing repository
> was only visible after the first `yum` invocation finished.
> 
> This would result in `yum` silently ignoring the package, producing
> a broken CentOS 6 docker image.
> 
> 
> Diffs
> -
> 
>   support/packaging/centos/centos6.dockerfile 
> bb8d591ce6d41a70bde64020d18aac739021e88e 
> 
> 
> Diff: https://reviews.apache.org/r/71329/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 71329: Updated CentOS 6 dockerfile to properly install devtoolset-7.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71329/
---

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
---

The previously used yum command was not able to properly install
the required `devtoolset-7` package since the containing repository
was only visible after the first `yum` invocation finished.

This would result in `yum` silently ignoring the package, producing
a broken CentOS 6 docker image.


Diffs
-

  support/packaging/centos/centos6.dockerfile 
bb8d591ce6d41a70bde64020d18aac739021e88e 


Diff: https://reviews.apache.org/r/71329/diff/1/


Testing
---


Thanks,

Benno Evers

Re: Review Request 71300: Removed mesos-style transition script.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71300/#review217330
---



Bad review!

Reviews applied: [71300, 71209, 71208, 71207, 71206, 71205, 71299, 71204, 
71203, 70096]

Error:
2019-08-20 12:24:32 URL:https://reviews.apache.org/r/71300/diff/raw/ 
[1506/1506] -> "71300.patch" [1]
error: patch failed: support/mesos-style.py:1
error: support/mesos-style.py: patch does not apply

- Mesos Reviewbot


On Aug. 16, 2019, 7:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71300/
> ---
> 
> (Updated Aug. 16, 2019, 7:42 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed mesos-style transition script.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 
> 
> 
> Diff: https://reviews.apache.org/r/71300/diff/2/
> 
> 
> Testing
> ---
> 
> n/a
> 
> THIS PATCH SHOULD ONLY BE COMMITTED AFTER THE PRECEEDING CHAIN HAS BEEN 
> LANDED FOR SOME TIME TO GIVE CONTRIBUTORS A CHANCE TO ADJUST THEIR WORKFLOW.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/
---

(Updated Aug. 20, 2019, 1:49 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.

This patch was necessary when we were running cpplint via
`support/mesos-style.py` to prevent it from cluttering up the hook
output. When running under pre-commit linter output is not shown if no
errors occur so we can undo our change to stay closer to upstream.


Diffs (updated)
-

  support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8 


Diff: https://reviews.apache.org/r/71207/diff/3/

Changes: https://reviews.apache.org/r/71207/diff/2-3/


Testing
---

* used for development for a couple of months
* reports no issues in the current source tree


Thanks,

Benjamin Bannier

Re: Review Request 71206: Removed old mesos-style and references.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/
---

(Updated Aug. 20, 2019, 1:49 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Address comments from bennoe & jpeach offline


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch removes references to `support/mesos-style.py` which was
replaced with a pre-commit setup in a previous commit. We also remove
the tool itself.


Diffs (updated)
-

  docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5 
  support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3 
  support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725 
  support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a 
  support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d 
  support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900 
  support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 


Diff: https://reviews.apache.org/r/71206/diff/5/

Changes: https://reviews.apache.org/r/71206/diff/4-5/


Testing
---

n/a


Thanks,

Benjamin Bannier

Re: Review Request 71299: Added separate script to install developer setup.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/
---

(Updated Aug. 20, 2019, 1:48 p.m.)


Review request for mesos, Benno Evers and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch breaks the installation of developer tools (i.e., linter
configuration files and git hooks) out of `./bootstrap`. This not only
simplifies and streamlines the setup, but will allow us to add
developer-only features without breaking users who are just interested
in building a distribution tarball.


Diffs (updated)
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
  docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71299/diff/5/

Changes: https://reviews.apache.org/r/71299/diff/4-5/


Testing
---


Thanks,

Benjamin Bannier

Re: Review Request 71205: Switched commit hooks to pre-commit.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 20, 2019, 1:48 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/8/

Changes: https://reviews.apache.org/r/71205/diff/7-8/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier

Re: Review Request 71299: Added separate script to install developer setup.

[Benjamin Bannier]

> On Aug. 19, 2019, 12:56 p.m., Benno Evers wrote:
> > docs/advanced-contribution.md
> > Line 69 (original), 69 (patched)
> > 
> >
> > This became a bit ambiguous now, i.e. is only the second step or the 
> > whole step only required if building from git?
> > 
> > (also, I'm not sure why we have this qualification at all in a 
> > contributors guide)

I agree, removed the part in parentheses (this seems to have appeared with 
https://reviews.apache.org/r/36472/ w/o much discussion).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217278
---


On Aug. 20, 2019, 1:48 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> ---
> 
> (Updated Aug. 20, 2019, 1:48 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 
>   docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71299/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71303: Tracked frameworks in the role sorter.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71303/#review217328
---



Bad review!

Reviews applied: [71303, 71301, 71269, 71258, 71257, 71255, 71254]

Error:
2019-08-20 11:33:32 URL:https://reviews.apache.org/r/71254/diff/raw/ 
[5967/5967] -> "71254.patch" [1]
error: patch failed: src/master/allocator/mesos/sorter/drf/sorter.cpp:17
error: src/master/allocator/mesos/sorter/drf/sorter.cpp: patch does not apply
error: patch failed: src/master/allocator/mesos/sorter/random/sorter.cpp:17
error: src/master/allocator/mesos/sorter/random/sorter.cpp: patch does not apply

- Mesos Reviewbot


On Aug. 17, 2019, midnight, Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71303/
> ---
> 
> (Updated Aug. 17, 2019, midnight)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9917
> https://issues.apache.org/jira/browse/MESOS-9917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This paves the way for removing the framework sorters.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 580d35a3b71c1f7e851fa0504c6b9f037c05c378 
>   src/master/allocator/mesos/sorter/drf/sorter.hpp 
> 537086039fd804453ea8c682cda775d8fdff038f 
>   src/master/allocator/mesos/sorter/drf/sorter.cpp 
> 09889cdf3dc8c0e773b8e2e24154fb0edd2cc254 
>   src/master/allocator/mesos/sorter/random/sorter.hpp 
> f18b014ed15ff8906fbdbd3248becefde896651c 
>   src/master/allocator/mesos/sorter/random/sorter.cpp 
> 60a5797472460a8d3d9be938af9f6711ea51d484 
>   src/master/allocator/mesos/sorter/sorter.hpp 
> 52b8a7b57bf17759311b32aa56c26e614119b773 
> 
> 
> Diff: https://reviews.apache.org/r/71303/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71285/#review217327
---



Patch looks great!

Reviews applied: [71284, 71285]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 19, 2019, 10:54 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71285/
> ---
> 
> (Updated Aug. 19, 2019, 10:54 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, James Peach, and Joseph Wu.
> 
> 
> Bugs: MESOS-9875
> https://issues.apache.org/jira/browse/MESOS-9875
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed recovery of agent resources and operations after crash.
> 
> 
> Diffs
> -
> 
>   src/slave/paths.hpp e077587fd02bd8e35fee7ce12ae436e3dca25e47 
>   src/slave/paths.cpp 28a7cf9f9c70fb31eeefe2e823cd7e19ffcf126a 
>   src/slave/slave.cpp 1d0ec9d2428c3ffa28ad3e960b74f171013cf0c2 
>   src/slave/state.cpp cd3fac72dd57da21ed5ac46b17066531af26d42a 
> 
> 
> Diff: https://reviews.apache.org/r/71285/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually by doing the following:
> 
> 1) Run a master
> 2) Run an agent with statically reserved resources for use in the following 
> step
> 3) Run the persistent volume example framework to create a volume on the 
> agent, which leads to checkpointing of resources
> 4) Use `chattr -R +i /agent/volumes/dir` to make the agent's persistent 
> volume directory immutable
> 5) Run the persistent volume example framework again; it will fail and the 
> agent will crash
> 6) Restart the agent; confirm that it continues to crash
> 7) Use `chattr -R -i /agent/volumes/dir` to remove the immutable attribute
> 8) Restart the agent; confirm that it recovers successfully, with the 
> persistent volume created on disk
> 9) Run the persistent volume example framework again; it should succeed
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71151/
---

(Updated Aug. 20, 2019, 11:26 a.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Address comments from Chun


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

Performed periodic storage local provider reconciliations.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
6d632606f411d3ca99d3573a57c9f68b02ba8072 
  src/tests/storage_local_resource_provider_tests.cpp 
69b59d48ceefebbb7accefe411c54ac5cecff1c3 


Diff: https://reviews.apache.org/r/71151/diff/7/

Changes: https://reviews.apache.org/r/71151/diff/6-7/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 71150: Factored out storage provider method to update resources.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71150/
---

(Updated Aug. 20, 2019, 11:25 a.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Address comments from Chun


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

Factored out storage provider method to update resources.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
6d632606f411d3ca99d3573a57c9f68b02ba8072 
  src/tests/storage_local_resource_provider_tests.cpp 
69b59d48ceefebbb7accefe411c54ac5cecff1c3 


Diff: https://reviews.apache.org/r/71150/diff/6/

Changes: https://reviews.apache.org/r/71150/diff/5-6/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71318/#review217325
---



Bad patch!

Reviews applied: [71314, 71315, 71316, 71317, 71318]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71318"]

Error:
..
ing HTTP event for process 'slave(1240)' with path: 
'/slave(1240)/api/v1/resource_provider'
I0820 07:50:11.134178 18977 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I0820 07:50:11.136255 18983 http.cpp:1115] HTTP POST for /master/api/v1 from 
172.17.0.2:46860
I0820 07:50:11.136601 18983 http.cpp:263] Processing call UNRESERVE_RESOURCES
I0820 07:50:11.137399 18983 master.cpp:3890] Authorizing principal 
'test-principal' to unreserve resources 
'[{"disk":{"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_4LEQKF/2GB-4bfda151-3c6d-428e-9b92-057a0bcd0189","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"}},"name":"disk","provider_id":{"value":"ef3efb14-ec6b-4a26-8592-a333164a26c0"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I0820 07:50:11.139417 18990 master.cpp:12724] Removing offer 
ff5d03c7-8ace-4ac1-9805-a49e0efcef9a-O5
I0820 07:50:11.139562 18978 sched.cpp:960] Rescinded offer 
ff5d03c7-8ace-4ac1-9805-a49e0efcef9a-O5
I0820 07:50:11.139645 18978 sched.cpp:971] Scheduler::offerRescinded took 
24196ns
I0820 07:50:11.140141 18984 hierarchical.cpp:1454] Recovered disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_4LEQKF/2GB-4bfda151-3c6d-428e-9b92-057a0bcd0189,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024; 
ports(allocated: storage/default-role):[31000-32000] (total: cpus:2; mem:1024; 
disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_4LEQKF/2GB-4bfda151-3c6d-428e-9b92-057a0bcd0189,test)]:2048,
 allocated: {}) on agent ff5d03c7-8ace-4ac1-9805-a49e0efcef9a-S0 from framework 
ff5d03c7-8ace-4a
 c1-9805-a49e0efcef9a-
I0820 07:50:11.140281 18984 hierarchical.cpp:1500] Framework 
ff5d03c7-8ace-4ac1-9805-a49e0efcef9a- filtered agent 
ff5d03c7-8ace-4ac1-9805-a49e0efcef9a-S0 for 5secs
I0820 07:50:11.143219 18971 master.cpp:12615] Sending operation '' (uuid: 
92442653-a3ee-4107-af40-5265520d0471) to agent 
ff5d03c7-8ace-4ac1-9805-a49e0efcef9a-S0 at slave(1240)@172.17.0.2:39167 
(a6f681cf2c75)
I0820 07:50:11.143769 18974 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I0820 07:50:11.146616 18973 provider.cpp:481] Received APPLY_OPERATION event
I0820 07:50:11.146670 18973 provider.cpp:1295] Received UNRESERVE operation '' 
(uuid: 92442653-a3ee-4107-af40-5265520d0471)
I0820 07:50:11.154505 18992 hierarchical.cpp:1740] Performed allocation for 1 
agents in 1.230229ms
I0820 07:50:11.155087 18969 master.cpp:10432] Sending offers [ 
ff5d03c7-8ace-4ac1-9805-a49e0efcef9a-O6 ] to framework 
ff5d03c7-8ace-4ac1-9805-a49e0efcef9a- (default) at 
scheduler-b0e65a5f-97b3-4e6c-ac42-c42e2b7b34a8@172.17.0.2:39167
I0820 07:50:11.155699 18983 sched.cpp:934] Scheduler::resourceOffers took 
75678ns
I0820 07:50:11.173789 18971 http.cpp:1115] HTTP POST for 
/slave(1240)/api/v1/resource_provider from 172.17.0.2:46850
I0820 07:50:11.174675 18972 slave.cpp:8423] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 2a859ec5-d153-4dbf-b341-51e0fd80bd0d) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0820 07:50:11.174861 18972 slave.cpp:8876] Updating the state of operation 
with no ID (uuid: 2a859ec5-d153-4dbf-b341-51e0fd80bd0d) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I0820 07:50:11.174917 18972 slave.cpp:8630] Forwarding status update of 
operation with no ID (operation_uuid: 2a859ec5-d153-4dbf-b341-51e0fd80bd0d) for 
an operator API call
I0820 07:50:11.175410 18974 master.cpp:12271] Updating the state of operation 
'' (uuid: