Re: Review Request 58760: Added default secret resolver module.

2017-05-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/#review175323
---


Ship it!





src/secret/resolver.cpp
Lines 40 (patched)


C style comments?


- Vinod Kone


On May 16, 2017, 7:22 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58760/
> ---
> 
> (Updated May 16, 2017, 7:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added default secret resolver module.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt eef718d95b5d8e051a5094369dc9b4532bc307ff 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/secret/resolver.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58760/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58760: Added default secret resolver module.

2017-05-16 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/
---

(Updated May 16, 2017, 3:22 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Addressed Gilbert's comments.


Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
---

Added default secret resolver module.


Diffs (updated)
-

  src/CMakeLists.txt eef718d95b5d8e051a5094369dc9b4532bc307ff 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/secret/resolver.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/58760/diff/9/

Changes: https://reviews.apache.org/r/58760/diff/8-9/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 58760: Added default secret resolver module.

2017-05-14 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/#review174913
---


Fix it, then Ship it!





src/secret/resolver.cpp
Lines 76 (patched)


Newline above.



src/secret/resolver.cpp
Lines 78 (patched)


Newline above.


- Gilbert Song


On May 12, 2017, 10:52 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58760/
> ---
> 
> (Updated May 12, 2017, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added default secret resolver module.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/secret/resolver.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58760/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58760: Added default secret resolver module.

2017-05-12 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/
---

(Updated May 12, 2017, 1:52 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

rebased


Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
---

Added default secret resolver module.


Diffs (updated)
-

  src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/secret/resolver.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/58760/diff/8/

Changes: https://reviews.apache.org/r/58760/diff/7-8/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 58760: Added default secret resolver module.

2017-05-09 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/
---

(Updated May 9, 2017, 2:11 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Addressed Vinod's comments!


Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
---

Added default secret resolver module.


Diffs (updated)
-

  src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/secret/resolver.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/58760/diff/7/

Changes: https://reviews.apache.org/r/58760/diff/6-7/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 58760: Added default secret resolver module.

2017-05-08 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/#review174240
---


Fix it, then Ship it!





src/secret/resolver.cpp
Lines 40 (patched)


The comment about default resolver behavior in the previous review should 
be here instead.



src/secret/resolver.cpp
Lines 72 (patched)


new line above.


- Vinod Kone


On May 8, 2017, 10:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58760/
> ---
> 
> (Updated May 8, 2017, 10:19 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added default secret resolver module.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/secret/resolver.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58760/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58760: Added default secret resolver module.

2017-05-08 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/
---

(Updated May 8, 2017, 6:19 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

rebased


Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
---

Added default secret resolver module.


Diffs (updated)
-

  src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/secret/resolver.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/58760/diff/6/

Changes: https://reviews.apache.org/r/58760/diff/5-6/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 58760: Added default secret resolver module.

2017-05-05 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/
---

(Updated May 5, 2017, 8:32 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Added cmake changes.


Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
---

Added default secret resolver module.


Diffs (updated)
-

  src/CMakeLists.txt 89cbd3f5a93f4891e8272d3b1136059ab1069d01 
  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/secret/resolver.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/58760/diff/5/

Changes: https://reviews.apache.org/r/58760/diff/4-5/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 58760: Added default secret resolver module.

2017-05-05 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/
---

(Updated May 5, 2017, 6:38 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Rebased. Added `::create` method.


Summary (updated)
-

Added default secret resolver module.


Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description (updated)
---

Added default secret resolver module.


Diffs (updated)
-

  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/secret/resolver.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/58760/diff/4/

Changes: https://reviews.apache.org/r/58760/diff/3-4/


Testing
---


Thanks,

Kapil Arya