Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-17 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review191418
---


Ship it!




Ship It!

- Gilbert Song


On Nov. 17, 2017, 8:51 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
> 
> (Updated Nov. 17, 2017, 8:51 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
> https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-17 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/
---

(Updated Nov. 17, 2017, 4:51 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-8079
https://issues.apache.org/jira/browse/MESOS-8079


Repository: mesos


Description
---

Added checkpoint and recover capability for layers in provisioner.


Diffs (updated)
-

  include/mesos/slave/containerizer.proto 
689acfcbbb07f071b6195472118a7a7520a44abd 
  src/slave/containerizer/mesos/provisioner/paths.hpp 
466f5edab40732b0d8da4252a71fde9c2956e8e9 
  src/slave/containerizer/mesos/provisioner/paths.cpp 
268dbeb4b18374ef53bc73254bf20ce6830e384f 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
450a3b32d69d2882973a6ed4e94e169a0256056b 


Diff: https://reviews.apache.org/r/62997/diff/6/

Changes: https://reviews.apache.org/r/62997/diff/5-6/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-16 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review191283
---


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/provisioner.cpp
Line 44 (original), 44 (patched)


kill this line/



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Line 520 (original), 519 (patched)


one more space after `if`


- Gilbert Song


On Nov. 13, 2017, 10:20 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
> 
> (Updated Nov. 13, 2017, 10:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
> https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-13 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/
---

(Updated Nov. 14, 2017, 6:20 a.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-8079
https://issues.apache.org/jira/browse/MESOS-8079


Repository: mesos


Description
---

Added checkpoint and recover capability for layers in provisioner.


Diffs (updated)
-

  include/mesos/slave/containerizer.proto 
689acfcbbb07f071b6195472118a7a7520a44abd 
  src/slave/containerizer/mesos/provisioner/paths.hpp 
466f5edab40732b0d8da4252a71fde9c2956e8e9 
  src/slave/containerizer/mesos/provisioner/paths.cpp 
268dbeb4b18374ef53bc73254bf20ce6830e384f 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
450a3b32d69d2882973a6ed4e94e169a0256056b 


Diff: https://reviews.apache.org/r/62997/diff/5/

Changes: https://reviews.apache.org/r/62997/diff/4-5/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-13 Thread Gilbert Song 


> On Nov. 9, 2017, 9:25 p.m., Zhitao Li wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.cpp
> > Lines 531 (patched)
> > 
> >
> > This is the layerRootfs from store.
> > 
> > However, I do not think we should checkpoint "layer dir" instead here, 
> > as it is second guessing how store manages its internal directory 
> > structure, which breaks the current provisioner and store abstraction.

make sense to me!


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review190672
---


On Nov. 10, 2017, 11:33 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
> 
> (Updated Nov. 10, 2017, 11:33 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
> https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-13 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review190888
---


Fix it, then Ship it!




LGTM!


src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 51 (patched)


Move it right below `slave/paths.hpp`



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 514 (patched)


one more space after `foreach`



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 519 (patched)


kill this line



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 521 (patched)


return Failure("Failed to checkpoint layers to '" + path + "': " + 
checkpoint.error());


- Gilbert Song


On Nov. 10, 2017, 11:33 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
> 
> (Updated Nov. 10, 2017, 11:33 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
> https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-10 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/
---

(Updated Nov. 10, 2017, 7:33 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-8079
https://issues.apache.org/jira/browse/MESOS-8079


Repository: mesos


Description
---

Added checkpoint and recover capability for layers in provisioner.


Diffs (updated)
-

  include/mesos/slave/containerizer.proto 
689acfcbbb07f071b6195472118a7a7520a44abd 
  src/slave/containerizer/mesos/provisioner/paths.hpp 
466f5edab40732b0d8da4252a71fde9c2956e8e9 
  src/slave/containerizer/mesos/provisioner/paths.cpp 
268dbeb4b18374ef53bc73254bf20ce6830e384f 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
450a3b32d69d2882973a6ed4e94e169a0256056b 


Diff: https://reviews.apache.org/r/62997/diff/4/

Changes: https://reviews.apache.org/r/62997/diff/3-4/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-09 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review190672
---




src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 531 (patched)


This is the layerRootfs from store.

However, I do not think we should checkpoint "layer dir" instead here, as 
it is second guessing how store manages its internal directory structure, which 
breaks the current provisioner and store abstraction.


- Zhitao Li


On Oct. 27, 2017, 6:03 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
> 
> (Updated Oct. 27, 2017, 6:03 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
> https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-09 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review190665
---




src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 531 (patched)


are we checkpointing the layerRootfs dir? if it is the case, should we 
checkpoint the layer dir here? so that we can avoid the conversion in store.


- Gilbert Song


On Oct. 27, 2017, 11:03 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
> 
> (Updated Oct. 27, 2017, 11:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
> https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-07 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review190353
---




src/slave/containerizer/mesos/provisioner/paths.hpp
Line 55 (original), 59-60 (patched)


We should use `xxxPath()` consistently in this file. Could you add a TODO 
for refactoring?



src/slave/containerizer/mesos/provisioner/provisioner.hpp
Lines 170 (patched)


Should we add comments for removing `Option` after a deprecation cycle?



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 152-187 (patched)


do we really need the static functions? I think we can just do the 
checkpointing and read in the code since I dont see posibilities we will 
checkpoint twice in the near future.



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 185 (patched)


let's use state::checkpoint() instead.


- Gilbert Song


On Oct. 27, 2017, 11:03 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
> 
> (Updated Oct. 27, 2017, 11:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
> https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-10-27 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/
---

(Updated Oct. 27, 2017, 6:03 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Changes
---

Fix populating `info->layers` after provision


Bugs: MESOS-8079
https://issues.apache.org/jira/browse/MESOS-8079


Repository: mesos


Description
---

Added checkpoint and recover capability for layers in provisioner.


Diffs (updated)
-

  include/mesos/slave/containerizer.proto 
689acfcbbb07f071b6195472118a7a7520a44abd 
  src/slave/containerizer/mesos/provisioner/paths.hpp 
466f5edab40732b0d8da4252a71fde9c2956e8e9 
  src/slave/containerizer/mesos/provisioner/paths.cpp 
268dbeb4b18374ef53bc73254bf20ce6830e384f 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
450a3b32d69d2882973a6ed4e94e169a0256056b 


Diff: https://reviews.apache.org/r/62997/diff/3/

Changes: https://reviews.apache.org/r/62997/diff/2-3/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-10-26 Thread Zhitao Li 


> On Oct. 26, 2017, 11:45 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.hpp
> > Lines 170 (patched)
> > 
> >
> > why is it an `Option`?

Similar to `ContainerConfig`, we might be recovering backends launched before 
this patch?


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review189378
---


On Oct. 17, 2017, 5:04 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
> 
> (Updated Oct. 17, 2017, 5:04 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
> https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-10-26 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review189378
---




src/slave/containerizer/mesos/provisioner/provisioner.hpp
Lines 170 (patched)


why is it an `Option`?



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 415-417 (patched)


fix the indentation. two spaces to the right.



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Line 469 (original), 520 (patched)


Should we set the `layers`?


- Gilbert Song


On Oct. 17, 2017, 10:04 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> ---
> 
> (Updated Oct. 17, 2017, 10:04 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
> https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-10-17 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/
---

(Updated Oct. 17, 2017, 5:04 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-8079
https://issues.apache.org/jira/browse/MESOS-8079


Repository: mesos


Description
---

Added checkpoint and recover capability for layers in provisioner.


Diffs (updated)
-

  include/mesos/slave/containerizer.proto 
689acfcbbb07f071b6195472118a7a7520a44abd 
  src/slave/containerizer/mesos/provisioner/paths.hpp 
466f5edab40732b0d8da4252a71fde9c2956e8e9 
  src/slave/containerizer/mesos/provisioner/paths.cpp 
268dbeb4b18374ef53bc73254bf20ce6830e384f 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
450a3b32d69d2882973a6ed4e94e169a0256056b 


Diff: https://reviews.apache.org/r/62997/diff/2/

Changes: https://reviews.apache.org/r/62997/diff/1-2/


Testing
---


Thanks,

Zhitao Li