Re: Review Request 37853: Overlay filesystem provisioning backend

2016-07-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review141506
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 1, 2015, 5:26 a.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Dec. 1, 2015, 5:26 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cfe9d26 
>   src/Makefile.am fd38cfa 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 01d06eb 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> Basic test in provisioner_backend_tests.cpp.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-12-01 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review108544
---



src/Makefile.am (line 776)


Please align the backslashes. We use tabs (8 spaces) in Makefiles



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (lines 59 - 68)


This code is copy-pasted in test as well. Can we add a utility funciton in 
src/linux/fs.hpp|cpp instead?

```
namespace fs {
Try supported(const string& filesystem);
}
```



src/tests/containerizer/provisioner_backend_tests.cpp (lines 56 - 65)


See my comments above. Let's add a new test filter and skip this test if 
overlayfs is not supported. See examples in src/tests/environment.cpp



src/tests/containerizer/provisioner_backend_tests.cpp (line 109)


2 lines apart.


- Jie Yu


On Dec. 1, 2015, 5:26 a.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Dec. 1, 2015, 5:26 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cfe9d26 
>   src/Makefile.am fd38cfa 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 01d06eb 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> Basic test in provisioner_backend_tests.cpp.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-12-01 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review108504
---


Patch looks great!

Reviews applied: [37853]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 1, 2015, 5:26 a.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Dec. 1, 2015, 5:26 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cfe9d26 
>   src/Makefile.am fd38cfa 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 01d06eb 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> Basic test in provisioner_backend_tests.cpp.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-30 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Nov. 30, 2015, 10:01 p.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Changes
---

Fixed bug.


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  src/CMakeLists.txt cfe9d26 
  src/Makefile.am fd38cfa 
  src/slave/containerizer/mesos/provisioner/backend.cpp 01d06eb 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

Basic test in provisioner_backend_tests.cpp.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-30 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Dec. 1, 2015, 5:26 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  src/CMakeLists.txt cfe9d26 
  src/Makefile.am fd38cfa 
  src/slave/containerizer/mesos/provisioner/backend.cpp 01d06eb 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

Basic test in provisioner_backend_tests.cpp.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-30 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Nov. 30, 2015, 1:46 p.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  src/CMakeLists.txt cfe9d26 
  src/Makefile.am fd38cfa 
  src/slave/containerizer/mesos/provisioner/backend.cpp 01d06eb 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef 

Diff: https://reviews.apache.org/r/37853/diff/


Testing (updated)
---

Basic test in provisioner_backend_tests.cpp.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-30 Thread Mei Wan 


> On Nov. 23, 2015, 9:50 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp, line 36
> > 
> >
> > What's N.B.?
> > To me this is not really a desirable condition for users that has to 
> > prep all images to have sandbox_directory created. Can we at least add a 
> > TODO to say we want to create it here or somewhere upstream?

To be honest, I'm not too sure what this is. I was actually working off the 
bind backend code.


> On Nov. 23, 2015, 9:50 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 97
> > 
> >
> > Should we do this check in create?

Makes sense. Moved it to create.


- Mei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review107653
---


On Nov. 30, 2015, 1:46 p.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Nov. 30, 2015, 1:46 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cfe9d26 
>   src/Makefile.am fd38cfa 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 01d06eb 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> Basic test in provisioner_backend_tests.cpp.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-11-23 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review107653
---



src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (line 33)


Nit: We usually put the NOTE: beginning of the comment.



src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (line 34)


single images doesn't make much sense to me, I assume you're saying 
OverlayBackend doesn't support images with a single layer?



src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (line 36)


What's N.B.?
To me this is not really a desirable condition for users that has to prep 
all images to have sandbox_directory created. Can we at least add a TODO to say 
we want to create it here or somewhere upstream?



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 97)


Should we do this check in create?



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 100)


We use camel case.



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 117)


Let's use layers instead of image here.



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 122)


single quotes around the rootfs variable.



src/tests/containerizer/provisioner_backend_tests.cpp (line 55)


We need to run this in a system where Overlay fs is enabled right?
Can we add a check and disable in environment or in the test class?


- Timothy Chen


On Oct. 28, 2015, 3:58 a.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Oct. 28, 2015, 3:58 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6c7519b 
>   src/Makefile.am d6eb302 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 35ced4b 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 3347d58 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Oct. 28, 2015, 3:39 a.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Changes
---

removed binary files


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  src/CMakeLists.txt 6c7519b 
  src/Makefile.am d6eb302 
  src/slave/containerizer/mesos/provisioner/backend.cpp 35ced4b 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 3347d58 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

I haven't done any official testing. When I was working off Ian's branch, I 
tested it manually and the provisioning works.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Oct. 28, 2015, 3:58 a.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Changes
---

fixed indent


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  src/CMakeLists.txt 6c7519b 
  src/Makefile.am d6eb302 
  src/slave/containerizer/mesos/provisioner/backend.cpp 35ced4b 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 3347d58 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

I haven't done any official testing. When I was working off Ian's branch, I 
tested it manually and the provisioning works.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review104253
---


Patch looks great!

Reviews applied: [37853]

All tests passed.

- Mesos ReviewBot


On Oct. 28, 2015, 3:58 a.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Oct. 28, 2015, 3:58 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6c7519b 
>   src/Makefile.am d6eb302 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 35ced4b 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 3347d58 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Oct. 28, 2015, 3:35 a.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Changes
---

Started writing tests!


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  src/CMakeLists.txt 6c7519b 
  src/Makefile.am d6eb302 
  src/slave/.DS_Store PRE-CREATION 
  src/slave/containerizer/.DS_Store PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backend.cpp 35ced4b 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 3347d58 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

I haven't done any official testing. When I was working off Ian's branch, I 
tested it manually and the provisioning works.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-27 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review104245
---


Bad patch!

Reviews applied: [37853]

Failed command: ./support/apply-review.sh -n -r 37853

Error:
 2015-10-28 03:55:33 URL:https://reviews.apache.org/r/37853/diff/raw/ 
[12573/12573] -> "37853.patch" [1]
Successfully applied: Overlay filesystem provisioning backend

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Review: https://reviews.apache.org/r/37853
Checking 4 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
src/tests/containerizer/provisioner_backend_tests.cpp:34:  Weird number of 
spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
Total errors found: 1
Failed to commit patch

- Mesos ReviewBot


On Oct. 28, 2015, 3:39 a.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Oct. 28, 2015, 3:39 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6c7519b 
>   src/Makefile.am d6eb302 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 35ced4b 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 3347d58 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Oct. 11, 2015, 10:38 p.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Changes
---

Figured out how to upload diff. Sorry for the spam!


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  .DS_Store PRE-CREATION 
  3rdparty/libprocess/Makefile.am c764717 
  diff.txt PRE-CREATION 
  docs/app-framework-development-guide.md c7aa08d 
  docs/architecture.md PRE-CREATION 
  docs/c++-style-guide.md PRE-CREATION 
  docs/clang-format.md e8f593f 
  docs/committers.md a44333e 
  docs/containerizer.md PRE-CREATION 
  docs/documentation-guide.md PRE-CREATION 
  docs/doxygen-style-guide.md PRE-CREATION 
  docs/effective-code-reviewing.md ff6507c 
  docs/fetcher-cache-internals.md e8a68d1 
  docs/fetcher.md 36351a3 
  docs/frameworks.md PRE-CREATION 
  docs/home.md e7d6930 
  docs/images/containerizer_isolator_api.png PRE-CREATION 
  docs/markdown-style-guide.md PRE-CREATION 
  docs/mesos-architecture.md 439a56d 
  docs/mesos-c++-style-guide.md 0b61891 
  docs/mesos-containerizer.md ea19558 
  docs/mesos-documentation-guide.md 42ed95f 
  docs/mesos-doxygen-style-guide.md 1bd3b3d 
  docs/mesos-frameworks.md 60405b1 
  docs/mesos-markdown-style-guide.md fe9ffef 
  docs/mesos-presentations.md 2ce4b12 
  docs/mesos-roadmap.md 1f68ba0 
  docs/mesos-ssl.md 9df34db 
  docs/mesos-testing-patterns.md d0d92ff 
  docs/powered-by-mesos.md ed2cd37 
  docs/presentations.md PRE-CREATION 
  docs/roadmap.md PRE-CREATION 
  docs/scheduler-http-api.md PRE-CREATION 
  docs/scheduler_http_api.md de6cfc9 
  docs/ssl.md PRE-CREATION 
  docs/submitting-a-patch.md 78ffcfb 
  docs/testing-patterns.md PRE-CREATION 
  docs/tools.md 414decf 
  include/mesos/mesos.proto 4a16be1 
  include/mesos/v1/mesos.proto eadbc9d 
  site/.gitignore PRE-CREATION 
  site/Gemfile PRE-CREATION 
  site/Gemfile.lock PRE-CREATION 
  site/README.md PRE-CREATION 
  site/Rakefile PRE-CREATION 
  site/config.rb PRE-CREATION 
  site/doap.rdf PRE-CREATION 
  site/source/.htaccess PRE-CREATION 
  site/source/assets/css/bootstrap-responsive.min.css PRE-CREATION 
  site/source/assets/css/bootstrap-theme.css PRE-CREATION 
  site/source/assets/css/bootstrap-theme.min.css PRE-CREATION 
  site/source/assets/css/bootstrap.css PRE-CREATION 
  site/source/assets/css/bootstrap.min.css PRE-CREATION 
  site/source/assets/css/font-awesome-ie7.min.css PRE-CREATION 
  site/source/assets/css/font-awesome.min.css PRE-CREATION 
  site/source/assets/css/main.css PRE-CREATION 
  site/source/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
  site/source/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
  site/source/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
  site/source/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
  site/source/assets/img/airbnb_logo.png PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_contributions.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_aurora.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_cassandra.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_chronos.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_custom.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_hadoop.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_jenkins.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_jobserver.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_marathon.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_spark.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_framework_storm.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_howlong.png PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_howmanymachines.png 
PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_nps.png PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_poweredby.png PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_responses.png PRE-CREATION 
  site/source/assets/img/blog/communitysurvey_2014_wheredoyourun.png 
PRE-CREATION 
  site/source/assets/img/glyphicons-halflings-white.png PRE-CREATION 
  site/source/assets/img/glyphicons-halflings.png PRE-CREATION 
  site/source/assets/img/mesos_logo.png PRE-CREATION 
  site/source/assets/img/mesos_logo_dkblue.png PRE-CREATION 
  site/source/assets/img/mesoscon-2015-banner-small.png PRE-CREATION

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Oct. 11, 2015, 10:48 p.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  .DS_Store PRE-CREATION 
  src/CMakeLists.txt 828dbb6 
  src/Makefile.am d855cb8 
  src/slave/containerizer/provisioner/backend.cpp b5d9670 
  src/slave/containerizer/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/backends/overlay.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

I haven't done any official testing. When I was working off Ian's branch, I 
tested it manually and the provisioning works.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review102196
---


Bad patch!

Reviews applied: [37853]

Failed command: ./support/apply-review.sh -n -r 37853

Error:
 2015-10-11 23:00:17 URL:https://reviews.apache.org/r/37853/diff/raw/ 
[10053/10053] -> "37853.patch" [1]
error: cannot apply binary patch to '.DS_Store' without full index line
error: .DS_Store: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 11, 2015, 10:48 p.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Oct. 11, 2015, 10:48 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   .DS_Store PRE-CREATION 
>   src/CMakeLists.txt 828dbb6 
>   src/Makefile.am d855cb8 
>   src/slave/containerizer/provisioner/backend.cpp b5d9670 
>   src/slave/containerizer/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/backends/overlay.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Oct. 11, 2015, 11:02 p.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Changes
---

.DS_Store gave problems for compiling


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  src/CMakeLists.txt 828dbb6 
  src/Makefile.am d855cb8 
  src/slave/containerizer/provisioner/backend.cpp b5d9670 
  src/slave/containerizer/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/backends/overlay.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

I haven't done any official testing. When I was working off Ian's branch, I 
tested it manually and the provisioning works.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review102199
---


Patch looks great!

Reviews applied: [37853]

All tests passed.

- Mesos ReviewBot


On Oct. 11, 2015, 11:02 p.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Oct. 11, 2015, 11:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 828dbb6 
>   src/Makefile.am d855cb8 
>   src/slave/containerizer/provisioner/backend.cpp b5d9670 
>   src/slave/containerizer/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/backends/overlay.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-10 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review102163
---



src/Makefile.am (line 722)


Can we please add this to the `CMakeLists.txt` file in `src/`? Thanks!


- Alex Clemmer


On Oct. 6, 2015, 12:38 p.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Oct. 6, 2015, 12:38 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e698927 
>   src/slave/containerizer/provisioner/backend.cpp b5d9670 
>   src/slave/containerizer/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/backends/overlay.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-10-06 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

(Updated Oct. 6, 2015, 6:36 a.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.


Changes
---

I've corrected everything! Will start writing tests. Sorry this took me so long.


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs (updated)
-

  src/Makefile.am e698927 
  src/slave/containerizer/provisioner/backend.cpp b5d9670 
  src/slave/containerizer/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/backends/overlay.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

I haven't done any official testing. When I was working off Ian's branch, I 
tested it manually and the provisioning works.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-09-28 Thread Jie Yu 


> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/overlay.cpp, line 58
> > 
> >
> > You also want to check if overlay fs is supported or not. Not every 
> > linux kernel supports overlay fs.
> 
> Mei Wan wrote:
> How would I check this?

Well, i'll let you to figure this out :) Hint: google /proc/filesystems


> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/overlay.cpp, lines 110-114
> > 
> >
> > Could you please add a comment about the ordering the layers will be 
> > stacked.
> > 
> > I think we should add a document at the backend interface as well 
> > stating that layers are stacking in such a way that the front layer in the 
> > vector will be the bottom most layer (i.e., applied first).
> > 
> > The lowerdir here should actually reverse the order of the layers 
> > vector.
> > 
> > ```
> > The specified lower directories will be stacked beginning from the 
> > rightmost one and going left.  In the above example lower1 will be the top, 
> > lower2 the middle and lower3 the bottom layer.
> > ```
> 
> Mei Wan wrote:
> Where would I add this document? I could just add it to the flag?

You can just add that commments right above this code block.


> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/overlay.cpp, line 111
> > 
> >
> > I think you should be able to use strings::join here:
> > 
> > ```
> > strings::join(":", layers);
> > ```
> 
> Mei Wan wrote:
> The format would be dir1:dir2:dir3 etc. I'm just wondering is it possible 
> to have the semi colon only appear between the directories? If I'm thinking 
> about this correctly, strings::join will give me :dir1:dir2:dir3? Also since 
> I'm stacking the layers in reverse from the comment above, does this still 
> apply?

strings::join will give you dir1:dir2:dir3 (exactly what you want).


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review96763
---


On Aug. 27, 2015, 9:11 p.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Aug. 27, 2015, 9:11 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7b620ff 
>   src/slave/containerizer/provisioners/backend.cpp 2f7c335 
>   src/slave/containerizer/provisioners/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/backends/overlay.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-09-01 Thread Mei Wan 


> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/overlay.cpp, lines 101-103
> > 
> >
> > Hum, I'd like to understand why overlay backend cannot support 1 layer. 
> > Any reason?

The mount options for overlayfs either takes one lowerdir, one upperdir and one 
workdir, or at least 2 lowerdirs. It's just how the function works.


> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/overlay.cpp, line 111
> > 
> >
> > I think you should be able to use strings::join here:
> > 
> > ```
> > strings::join(":", layers);
> > ```

The format would be dir1:dir2:dir3 etc. I'm just wondering is it possible to 
have the semi colon only appear between the directories? If I'm thinking about 
this correctly, strings::join will give me :dir1:dir2:dir3? Also since I'm 
stacking the layers in reverse from the comment above, does this still apply?


> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/overlay.cpp, lines 110-114
> > 
> >
> > Could you please add a comment about the ordering the layers will be 
> > stacked.
> > 
> > I think we should add a document at the backend interface as well 
> > stating that layers are stacking in such a way that the front layer in the 
> > vector will be the bottom most layer (i.e., applied first).
> > 
> > The lowerdir here should actually reverse the order of the layers 
> > vector.
> > 
> > ```
> > The specified lower directories will be stacked beginning from the 
> > rightmost one and going left.  In the above example lower1 will be the top, 
> > lower2 the middle and lower3 the bottom layer.
> > ```

Where would I add this document? I could just add it to the flag?


> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioners/backends/overlay.cpp, line 58
> > 
> >
> > You also want to check if overlay fs is supported or not. Not every 
> > linux kernel supports overlay fs.

How would I check this?


- Mei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review96763
---


On Aug. 27, 2015, 9:11 p.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Aug. 27, 2015, 9:11 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7b620ff 
>   src/slave/containerizer/provisioners/backend.cpp 2f7c335 
>   src/slave/containerizer/provisioners/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/backends/overlay.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Review Request 37853: Overlay filesystem provisioning backend

2015-08-27 Thread Mei Wan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/
---

Review request for mesos.


Repository: mesos


Description
---

Implemented the overlay filesystem backend by layering the images as a 
read-only filesystem.


Diffs
-

  src/Makefile.am 7b620ff 
  src/slave/containerizer/provisioners/backend.cpp 2f7c335 
  src/slave/containerizer/provisioners/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/backends/overlay.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37853/diff/


Testing
---

I haven't done any official testing. When I was working off Ian's branch, I 
tested it manually and the provisioning works.


Thanks,

Mei Wan

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-08-27 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review96763
---


This looks great! Thanks Mei! I think the main thing left here is the test. You 
should be able to write some simple tests that test the overlay functionality 
(see the bind mount tests). Looking forward to the tests!


src/slave/containerizer/provisioners/backends/overlay.cpp (line 58)
https://reviews.apache.org/r/37853/#comment152403

You also want to check if overlay fs is supported or not. Not every linux 
kernel supports overlay fs.



src/slave/containerizer/provisioners/backends/overlay.cpp (line 98)
https://reviews.apache.org/r/37853/#comment152425

No need to use process:: prefix as you already have `using namespace 
process` above.

Please all such occurances in this file.



src/slave/containerizer/provisioners/backends/overlay.cpp (lines 101 - 103)
https://reviews.apache.org/r/37853/#comment152406

Hum, I'd like to understand why overlay backend cannot support 1 layer. Any 
reason?



src/slave/containerizer/provisioners/backends/overlay.cpp (lines 110 - 114)
https://reviews.apache.org/r/37853/#comment152428

Could you please add a comment about the ordering the layers will be 
stacked.

I think we should add a document at the backend interface as well stating 
that layers are stacking in such a way that the front layer in the vector will 
be the bottom most layer (i.e., applied first).

The lowerdir here should actually reverse the order of the layers vector.

```
The specified lower directories will be stacked beginning from the 
rightmost one and going left.  In the above example lower1 will be the top, 
lower2 the middle and lower3 the bottom layer.
```



src/slave/containerizer/provisioners/backends/overlay.cpp (line 111)
https://reviews.apache.org/r/37853/#comment152424

I think you should be able to use strings::join here:

```
strings::join(:, layers);
```


- Jie Yu


On Aug. 27, 2015, 9:11 p.m., Mei Wan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37853/
 ---
 
 (Updated Aug. 27, 2015, 9:11 p.m.)
 
 
 Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
 
 
 Bugs: MESOS-2971
 https://issues.apache.org/jira/browse/MESOS-2971
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Implemented the overlay filesystem backend by layering the images as a 
 read-only filesystem.
 
 
 Diffs
 -
 
   src/Makefile.am 7b620ff 
   src/slave/containerizer/provisioners/backend.cpp 2f7c335 
   src/slave/containerizer/provisioners/backends/overlay.hpp PRE-CREATION 
   src/slave/containerizer/provisioners/backends/overlay.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37853/diff/
 
 
 Testing
 ---
 
 I haven't done any official testing. When I was working off Ian's branch, I 
 tested it manually and the provisioning works.
 
 
 Thanks,
 
 Mei Wan