Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-19 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123973
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 91)


let's use networkConfig here to be consistent.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 65)


you can use ->empty() without 'get()'



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 70)


Ditto.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 104)


s/netConfig/networkConfig/



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 127)


s/netConfig/networkConfig/


- Jie Yu


On March 16, 2016, 7:25 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 16, 2016, 7:25 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-19 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123975
---


Fix it, then Ship it!




Ship It!


src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 50)


s/by `network/cni`/by the `network/cni`
s/there is no CNI plugins and
   network configurations loaded by it./since it has not loaded any CNI 
plugins or network configurations.


- Avinash sridharan


On March 16, 2016, 7:25 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 16, 2016, 7:25 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-18 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/
---

(Updated March 17, 2016, 5:47 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Implemented the framework and create() method of "network/cni" isolator.


Diffs (updated)
-

  src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44555/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/
---

(Updated March 16, 2016, 3:25 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Implemented the framework and create() method of "network/cni" isolator.


Diffs (updated)
-

  src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
  src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44555/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-16 Thread Qian Zhang 


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 48
> > 
> >
> > Let's remove this 'empty' check here since you hae the os::exists check 
> > below.
> 
> Qian Zhang wrote:
> They are for different purposes, `os::exist` is used to check if the 
> directory exists or not, and here 
> `flags.network_cni_plugins_dir.get().empty()` is used to check if operator 
> does not specify the value of `--network_cni_plugins_dir` (e.g., 
> "`--network_cni_plugins_dir=`") when starting agent.
> 
> Jie Yu wrote:
> ok, can you use flags.network_ci_plugin_dir->empty()?

`flags.network_ci_plugin_dir` is an `Option`, and I think there is 
no `empty()` method in `Option` class.


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 177-181
> > 
> >
> > Again, this check should be removed to support containers that do not 
> > specify NetworkInfo.
> 
> Qian Zhang wrote:
> We do support containers that do not specify NetworkInfo, please take a 
> look at the diff of https://reviews.apache.org/r/44514/, in `prepare()`, if 
> the container does not specify NetworkInfo, then it will not do anything 
> (just a no-op) and subsequently `isolate()` will not do anything for this 
> kind of container too.
> 
> So my idea is, if operator decides to use `network/cni` isolator, then 
> s/he must specify CNI network configuration and plugin which should be 
> acceptable since CNI isolator needs CNI network configuration and plugin 
> sounds a reasonable requirement to me. But for framework, they do not have to 
> launch container to join CNI network, if they do not want a container to join 
> any CNI networks, then just do not specify NetworkInfo or specify NetworkInfo 
> without `name` field, we should definitly support it.
> 
> Avinash sridharan wrote:
> I agree with Qian on this.  If the `network/cni` isolator is being used 
> then we "must" have associated network configs. If frameworks don't want to 
> use the cni network they can opt-out by not setting anything in the `name` 
> field for `NetworkInfo`.
> 
> Jie Yu wrote:
> ok, what I am thinking is that we made network/cni isolator the default 
> network isolator (like the default filesystem isolator). I think we need a 
> network isolator anyway because imagine a situation where no network isolator 
> is specified, but the framework specifies a name in the NetworkInfo, in that 
> case, we don't have a way to reject this task. Therefore, we can either build 
> a default network isolator which does nothing but reject containers that 
> specify networkInfo.name, or we make network/cni isolator the default, and 
> use it even if no cni plugins are specified by the operator (in that case, 
> it'll also reject any containers the specify a networkinfo.name). Does that 
> make sense?

Agree.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 15, 2016, 11:02 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 15, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-15 Thread Jie Yu 


> On March 11, 2016, 7:28 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 177-181
> > 
> >
> > Again, this check should be removed to support containers that do not 
> > specify NetworkInfo.
> 
> Qian Zhang wrote:
> We do support containers that do not specify NetworkInfo, please take a 
> look at the diff of https://reviews.apache.org/r/44514/, in `prepare()`, if 
> the container does not specify NetworkInfo, then it will not do anything 
> (just a no-op) and subsequently `isolate()` will not do anything for this 
> kind of container too.
> 
> So my idea is, if operator decides to use `network/cni` isolator, then 
> s/he must specify CNI network configuration and plugin which should be 
> acceptable since CNI isolator needs CNI network configuration and plugin 
> sounds a reasonable requirement to me. But for framework, they do not have to 
> launch container to join CNI network, if they do not want a container to join 
> any CNI networks, then just do not specify NetworkInfo or specify NetworkInfo 
> without `name` field, we should definitly support it.
> 
> Avinash sridharan wrote:
> I agree with Qian on this.  If the `network/cni` isolator is being used 
> then we "must" have associated network configs. If frameworks don't want to 
> use the cni network they can opt-out by not setting anything in the `name` 
> field for `NetworkInfo`.

ok, what I am thinking is that we made network/cni isolator the default network 
isolator (like the default filesystem isolator). I think we need a network 
isolator anyway because imagine a situation where no network isolator is 
specified, but the framework specifies a name in the NetworkInfo, in that case, 
we don't have a way to reject this task. Therefore, we can either build a 
default network isolator which does nothing but reject containers that specify 
networkInfo.name, or we make network/cni isolator the default, and use it even 
if no cni plugins are specified by the operator (in that case, it'll also 
reject any containers the specify a networkinfo.name). Does that make sense?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 15, 2016, 3:02 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 15, 2016, 3:02 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-15 Thread Jie Yu 


> On March 11, 2016, 7:28 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 48
> > 
> >
> > Let's remove this 'empty' check here since you hae the os::exists check 
> > below.
> 
> Qian Zhang wrote:
> They are for different purposes, `os::exist` is used to check if the 
> directory exists or not, and here 
> `flags.network_cni_plugins_dir.get().empty()` is used to check if operator 
> does not specify the value of `--network_cni_plugins_dir` (e.g., 
> "`--network_cni_plugins_dir=`") when starting agent.

ok, can you use flags.network_ci_plugin_dir->empty()?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 15, 2016, 3:02 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 15, 2016, 3:02 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-15 Thread Avinash sridharan 


> On March 11, 2016, 7:28 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77
> > 
> >
> > I think the CNI plugin should also support the case where the user does 
> > not specify a name for the network. In other words,  the CNI network 
> > isolator should support host network as well. So it's OK to have no plugins.
> 
> Qian Zhang wrote:
> I have two questions:
> 1. How are we going to define the design behavior of supporting host 
> network in CNI network isolator? I mean if user does not specify name in 
> NetworkInfo when launching task, what should CNI network isolator do in 
> `prepare()` and `isolate()`? And what if user even does not specify the whole 
> NetworkInfo in ContainerInfo? My thinking is, CNI network isolator should not 
> do anything in this case.
> 2. In the code below, I check whether the plugin binary specified in each 
> network config file exists under `--network_cni_plugins` or not, if here we 
> allow the directory specified by `--network_cni_plugins` to be empty, then I 
> should remove that check too, right? But that way, we can not bail out agent 
> in `create()` to let operator know the issue which will be left to launching 
> task.
> 
> Avinash sridharan wrote:
> For (1), I think what Jie was mentioning is to have the network/cni 
> isolator do a no-op. That is return `Nothing` . 
> 
> I think (1) and (2) are not related. Consider the case where an operator 
> specifies a bunch of network configs, and there are frameworks that want to 
> join these networks. But, there could be frameworks that want to run on the 
> host network. The frameworks that want to run on host network don't provide a 
> `name` making them default to the host network.
> 
> Qian Zhang wrote:
> OK, so for (1), we all agree that `network/cni` isolator should do a 
> no-op in that case.
> 
> And for 2), I understand the case you described which does make sense to 
> me. However my concern is, if the directory specified by 
> `--network_cni_plugins_dir` is empty (i.e., no any CNI plugins in this 
> directory) and there are a bunch of network config files under 
> `--network_cni_config_dir`, then in `create()` do we still need to check 
> whether the plugin binary specified in each network config file exists under 
> `--network_cni_plugins_dir`? If we do the check, then it will definitely fail 
> since there is no CNI plugins under `--network_cni_plugins_dir`, if we do not 
> do the check, that means a network config file with an inexistent plugin will 
> be loaded, then an error must happen when launching task to join such network.
> 
> Avinash sridharan wrote:
> Semantic check. We should bail out if we detect a bad config. A bad 
> config, is a malformed config or a config for which the plugin is not present 
> or the plugin is not executable. IN the case you mentioned missing plugin is 
> semantic failure and hence isolator should bail out. Not sure what the 
> problem is here?
> 
> Qian Zhang wrote:
> The problem is, in `create()`, how do we handle the case the directory 
> specified by `--network_cni_plugins_dir` is empty and there are a bunch of 
> network config files under `--network_cni_config_dir`? In this case, the 
> plugin in each network config file is not present because 
> `--network_cni_plugins_dir` is an empty directory, so do you mean we should 
> always bail out in this case?

Yes.


> On March 11, 2016, 7:28 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 177-181
> > 
> >
> > Again, this check should be removed to support containers that do not 
> > specify NetworkInfo.
> 
> Qian Zhang wrote:
> We do support containers that do not specify NetworkInfo, please take a 
> look at the diff of https://reviews.apache.org/r/44514/, in `prepare()`, if 
> the container does not specify NetworkInfo, then it will not do anything 
> (just a no-op) and subsequently `isolate()` will not do anything for this 
> kind of container too.
> 
> So my idea is, if operator decides to use `network/cni` isolator, then 
> s/he must specify CNI network configuration and plugin which should be 
> acceptable since CNI isolator needs CNI network configuration and plugin 
> sounds a reasonable requirement to me. But for framework, they do not have to 
> launch container to join CNI network, if they do not want a container to join 
> any CNI networks, then just do not specify NetworkInfo or specify NetworkInfo 
> without `name` field, we should definitly support it.

I agree with Qian on this.  If the `network/cni` isolator is being used then we 
"must" have associated network configs. If frameworks don't want to use the cni 
network they can opt-out by not setting anything in the `name` field for 
`NetworkInfo`.


- Avinash

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-15 Thread Qian Zhang 


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 177-181
> > 
> >
> > Again, this check should be removed to support containers that do not 
> > specify NetworkInfo.

We do support containers that do not specify NetworkInfo, please take a look at 
the diff of https://reviews.apache.org/r/44514/, in `prepare()`, if the 
container does not specify NetworkInfo, then it will not do anything (just a 
no-op) and subsequently `isolate()` will not do anything for this kind of 
container too.

So my idea is, if operator decides to use `network/cni` isolator, then s/he 
must specify CNI network configuration and plugin which should be acceptable 
since CNI isolator needs CNI network configuration and plugin sounds a 
reasonable requirement to me. But for framework, they do not have to launch 
container to join CNI network, if they do not want a container to join any CNI 
networks, then just do not specify NetworkInfo or specify NetworkInfo without 
`name` field, we should definitly support it.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 15, 2016, 11:02 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 15, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-15 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/
---

(Updated March 15, 2016, 11:02 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Implemented the framework and create() method of "network/cni" isolator.


Diffs (updated)
-

  src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
  src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 
  src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44555/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-14 Thread Qian Zhang 


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77
> > 
> >
> > I think the CNI plugin should also support the case where the user does 
> > not specify a name for the network. In other words,  the CNI network 
> > isolator should support host network as well. So it's OK to have no plugins.
> 
> Qian Zhang wrote:
> I have two questions:
> 1. How are we going to define the design behavior of supporting host 
> network in CNI network isolator? I mean if user does not specify name in 
> NetworkInfo when launching task, what should CNI network isolator do in 
> `prepare()` and `isolate()`? And what if user even does not specify the whole 
> NetworkInfo in ContainerInfo? My thinking is, CNI network isolator should not 
> do anything in this case.
> 2. In the code below, I check whether the plugin binary specified in each 
> network config file exists under `--network_cni_plugins` or not, if here we 
> allow the directory specified by `--network_cni_plugins` to be empty, then I 
> should remove that check too, right? But that way, we can not bail out agent 
> in `create()` to let operator know the issue which will be left to launching 
> task.
> 
> Avinash sridharan wrote:
> For (1), I think what Jie was mentioning is to have the network/cni 
> isolator do a no-op. That is return `Nothing` . 
> 
> I think (1) and (2) are not related. Consider the case where an operator 
> specifies a bunch of network configs, and there are frameworks that want to 
> join these networks. But, there could be frameworks that want to run on the 
> host network. The frameworks that want to run on host network don't provide a 
> `name` making them default to the host network.
> 
> Qian Zhang wrote:
> OK, so for (1), we all agree that `network/cni` isolator should do a 
> no-op in that case.
> 
> And for 2), I understand the case you described which does make sense to 
> me. However my concern is, if the directory specified by 
> `--network_cni_plugins_dir` is empty (i.e., no any CNI plugins in this 
> directory) and there are a bunch of network config files under 
> `--network_cni_config_dir`, then in `create()` do we still need to check 
> whether the plugin binary specified in each network config file exists under 
> `--network_cni_plugins_dir`? If we do the check, then it will definitely fail 
> since there is no CNI plugins under `--network_cni_plugins_dir`, if we do not 
> do the check, that means a network config file with an inexistent plugin will 
> be loaded, then an error must happen when launching task to join such network.
> 
> Avinash sridharan wrote:
> Semantic check. We should bail out if we detect a bad config. A bad 
> config, is a malformed config or a config for which the plugin is not present 
> or the plugin is not executable. IN the case you mentioned missing plugin is 
> semantic failure and hence isolator should bail out. Not sure what the 
> problem is here?

The problem is, in `create()`, how do we handle the case the directory 
specified by `--network_cni_plugins_dir` is empty and there are a bunch of 
network config files under `--network_cni_config_dir`? In this case, the plugin 
in each network config file is not present because `--network_cni_plugins_dir` 
is an empty directory, so do you mean we should always bail out in this case?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 9, 2016, 2:01 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 2:01 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-14 Thread Avinash sridharan 


> On March 11, 2016, 7:28 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77
> > 
> >
> > I think the CNI plugin should also support the case where the user does 
> > not specify a name for the network. In other words,  the CNI network 
> > isolator should support host network as well. So it's OK to have no plugins.
> 
> Qian Zhang wrote:
> I have two questions:
> 1. How are we going to define the design behavior of supporting host 
> network in CNI network isolator? I mean if user does not specify name in 
> NetworkInfo when launching task, what should CNI network isolator do in 
> `prepare()` and `isolate()`? And what if user even does not specify the whole 
> NetworkInfo in ContainerInfo? My thinking is, CNI network isolator should not 
> do anything in this case.
> 2. In the code below, I check whether the plugin binary specified in each 
> network config file exists under `--network_cni_plugins` or not, if here we 
> allow the directory specified by `--network_cni_plugins` to be empty, then I 
> should remove that check too, right? But that way, we can not bail out agent 
> in `create()` to let operator know the issue which will be left to launching 
> task.
> 
> Avinash sridharan wrote:
> For (1), I think what Jie was mentioning is to have the network/cni 
> isolator do a no-op. That is return `Nothing` . 
> 
> I think (1) and (2) are not related. Consider the case where an operator 
> specifies a bunch of network configs, and there are frameworks that want to 
> join these networks. But, there could be frameworks that want to run on the 
> host network. The frameworks that want to run on host network don't provide a 
> `name` making them default to the host network.
> 
> Qian Zhang wrote:
> OK, so for (1), we all agree that `network/cni` isolator should do a 
> no-op in that case.
> 
> And for 2), I understand the case you described which does make sense to 
> me. However my concern is, if the directory specified by 
> `--network_cni_plugins_dir` is empty (i.e., no any CNI plugins in this 
> directory) and there are a bunch of network config files under 
> `--network_cni_config_dir`, then in `create()` do we still need to check 
> whether the plugin binary specified in each network config file exists under 
> `--network_cni_plugins_dir`? If we do the check, then it will definitely fail 
> since there is no CNI plugins under `--network_cni_plugins_dir`, if we do not 
> do the check, that means a network config file with an inexistent plugin will 
> be loaded, then an error must happen when launching task to join such network.

Semantic check. We should bail out if we detect a bad config. A bad config, is 
a malformed config or a config for which the plugin is not present or the 
plugin is not executable. IN the case you mentioned missing plugin is semantic 
failure and hence isolator should bail out. Not sure what the problem is here?


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-14 Thread Qian Zhang 


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77
> > 
> >
> > I think the CNI plugin should also support the case where the user does 
> > not specify a name for the network. In other words,  the CNI network 
> > isolator should support host network as well. So it's OK to have no plugins.
> 
> Qian Zhang wrote:
> I have two questions:
> 1. How are we going to define the design behavior of supporting host 
> network in CNI network isolator? I mean if user does not specify name in 
> NetworkInfo when launching task, what should CNI network isolator do in 
> `prepare()` and `isolate()`? And what if user even does not specify the whole 
> NetworkInfo in ContainerInfo? My thinking is, CNI network isolator should not 
> do anything in this case.
> 2. In the code below, I check whether the plugin binary specified in each 
> network config file exists under `--network_cni_plugins` or not, if here we 
> allow the directory specified by `--network_cni_plugins` to be empty, then I 
> should remove that check too, right? But that way, we can not bail out agent 
> in `create()` to let operator know the issue which will be left to launching 
> task.
> 
> Avinash sridharan wrote:
> For (1), I think what Jie was mentioning is to have the network/cni 
> isolator do a no-op. That is return `Nothing` . 
> 
> I think (1) and (2) are not related. Consider the case where an operator 
> specifies a bunch of network configs, and there are frameworks that want to 
> join these networks. But, there could be frameworks that want to run on the 
> host network. The frameworks that want to run on host network don't provide a 
> `name` making them default to the host network.

OK, so for (1), we all agree that `network/cni` isolator should do a no-op in 
that case.

And for 2), I understand the case you described which does make sense to me. 
However my concern is, if the directory specified by 
`--network_cni_plugins_dir` is empty (i.e., no any CNI plugins in this 
directory) and there are a bunch of network config files under 
`--network_cni_config_dir`, then in `create()` do we still need to check 
whether the plugin binary specified in each network config file exists under 
`--network_cni_plugins_dir`? If we do the check, then it will definitely fail 
since there is no CNI plugins under `--network_cni_plugins_dir`, if we do not 
do the check, that means a network config file with an inexistent plugin will 
be loaded, then an error must happen when launching task to join such network.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 9, 2016, 2:01 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 2:01 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-14 Thread Avinash sridharan 


> On March 11, 2016, 7:28 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77
> > 
> >
> > I think the CNI plugin should also support the case where the user does 
> > not specify a name for the network. In other words,  the CNI network 
> > isolator should support host network as well. So it's OK to have no plugins.
> 
> Qian Zhang wrote:
> I have two questions:
> 1. How are we going to define the design behavior of supporting host 
> network in CNI network isolator? I mean if user does not specify name in 
> NetworkInfo when launching task, what should CNI network isolator do in 
> `prepare()` and `isolate()`? And what if user even does not specify the whole 
> NetworkInfo in ContainerInfo? My thinking is, CNI network isolator should not 
> do anything in this case.
> 2. In the code below, I check whether the plugin binary specified in each 
> network config file exists under `--network_cni_plugins` or not, if here we 
> allow the directory specified by `--network_cni_plugins` to be empty, then I 
> should remove that check too, right? But that way, we can not bail out agent 
> in `create()` to let operator know the issue which will be left to launching 
> task.

For (1), I think what Jie was mentioning is to have the network/cni isolator do 
a no-op. That is return `Nothing` . 

I think (1) and (2) are not related. Consider the case where an operator 
specifies a bunch of network configs, and there are frameworks that want to 
join these networks. But, there could be frameworks that want to run on the 
host network. The frameworks that want to run on host network don't provide a 
`name` making them default to the host network.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-12 Thread Qian Zhang 


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 48
> > 
> >
> > Let's remove this 'empty' check here since you hae the os::exists check 
> > below.

They are for different purposes, `os::exist` is used to check if the directory 
exists or not, and here `flags.network_cni_plugins_dir.get().empty()` is used 
to check if operator does not specify the value of `--network_cni_plugins_dir` 
(e.g., "`--network_cni_plugins_dir=`") when starting agent.


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 53
> > 
> >
> > Ditto on removing this check.

Ditto.


> On March 12, 2016, 3:28 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77
> > 
> >
> > I think the CNI plugin should also support the case where the user does 
> > not specify a name for the network. In other words,  the CNI network 
> > isolator should support host network as well. So it's OK to have no plugins.

I have two questions:
1. How are we going to define the design behavior of supporting host network in 
CNI network isolator? I mean if user does not specify name in NetworkInfo when 
launching task, what should CNI network isolator do in `prepare()` and 
`isolate()`? And what if user even does not specify the whole NetworkInfo in 
ContainerInfo? My thinking is, CNI network isolator should not do anything in 
this case.
2. In the code below, I check whether the plugin binary specified in each 
network config file exists under `--network_cni_plugins` or not, if here we 
allow the directory specified by `--network_cni_plugins` to be empty, then I 
should remove that check too, right? But that way, we can not bail out agent in 
`create()` to let operator know the issue which will be left to launching task.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---


On March 9, 2016, 2:01 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 2:01 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-11 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123192
---




src/slave/containerizer/mesos/isolators/network/cni.hpp (lines 81 - 82)


I guess storing the protobuf is not sufficient because the JSON might 
contain plugin specific information.

I would suggest we define a `NetworkConfigInfo` nested type here:
```
struct NetworkConfigInfo
{
  std::string path;
  cni::NetworkConfig config;
};

hashmap networkConfigInfos;
```



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 48)


Let's remove this 'empty' check here since you hae the os::exists check 
below.



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 53)


Ditto on removing this check.



src/slave/containerizer/mesos/isolators/network/cni.cpp (lines 73 - 77)


I think the CNI plugin should also support the case where the user does not 
specify a name for the network. In other words,  the CNI network isolator 
should support host network as well. So it's OK to have no plugins.



src/slave/containerizer/mesos/isolators/network/cni.cpp (lines 100 - 102)


No need for this check. We can always rely on the parse function below.



src/slave/containerizer/mesos/isolators/network/cni.cpp (lines 177 - 181)


Again, this check should be removed to support containers that do not 
specify NetworkInfo.



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 186)


2 lines apart. Please fix all places.



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 189)


'{' should be in the next line. Please fix it in all places.


- Jie Yu


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-11 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123163
---


Ship it!




Ship It!

- Avinash sridharan


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-11 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123164
---


Ship it!




- Avinash sridharan


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-11 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review123162
---


Ship it!




Ship It!

- Avinash sridharan


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/#review122714
---



Patch looks great!

Reviews applied: [44004, 44200, 44549, 44555]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 9, 2016, 6:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44555/
> ---
> 
> (Updated March 9, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the framework and create() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44555/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-08 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44555/
---

Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4759
https://issues.apache.org/jira/browse/MESOS-4759


Repository: mesos


Description
---

Implemented the framework and create() method of "network/cni" isolator.


Diffs
-

  src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
  src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
  src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44555/diff/


Testing
---

make check


Thanks,

Qian Zhang