Re: Review Request 53330: Tracked layers and pull latency in docker store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/#review202153 --- FAIL: Failed to apply the current review. Failed command: `python.exe .\support\apply-reviews.py -n -r 53330` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/53330 Relevant logs: - [apply-review-53330-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/53330/logs/apply-review-53330-stdout.log): ``` error: patch failed: src/slave/containerizer/mesos/provisioner/docker/store.cpp:19 error: src/slave/containerizer/mesos/provisioner/docker/store.cpp: patch does not apply ``` - Mesos Reviewbot Windows On April 30, 2018, 9:23 p.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53330/ > --- > > (Updated April 30, 2018, 9:23 p.m.) > > > Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6451 > https://issues.apache.org/jira/browse/MESOS-6451 > > > Repository: mesos > > > Description > --- > > This patch added several metrics for docker store: > - a counter for number of layers pulled > - a gauge for total number of layers > - a timer for pull latency distribution in the last hour > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/paths.hpp > 232c027f8f96da0cb30b957bce4607d3695050d2 > src/slave/containerizer/mesos/provisioner/docker/paths.cpp > cd684b33eb308ce1eeb4539a5b2d51985d835db7 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 > > > Diff: https://reviews.apache.org/r/53330/diff/4/ > > > Testing > --- > > Use mesos-execute to pull several different images, and verified following > counters in agent's metrics/snapshot: > ``` > curl localhost:5051/metrics/snapshot | jq . | grep > containerizer/mesos/docker_pull > "containerizer/mesos/docker_store/layers_pulled": 47, > "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, > "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, > "containerizer/mesos/docker_store/pull_ms/p": 12528.3066648832, > "containerizer/mesos/docker_store/pull_ms": 4550.814976, > "containerizer/mesos/docker_store/pull_ms/count": 4, > "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, > "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, > "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, > "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, > "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, > "containerizer/mesos/docker_store/layers": 47, > ``` > > > Thanks, > > Zhitao Li > >
Re: Review Request 53330: Tracked layers and pull latency in docker store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/ --- (Updated April 30, 2018, 2:23 p.m.) Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. Bugs: MESOS-6451 https://issues.apache.org/jira/browse/MESOS-6451 Repository: mesos Description --- This patch added several metrics for docker store: - a counter for number of layers pulled - a gauge for total number of layers - a timer for pull latency distribution in the last hour Diffs - src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2 src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7 src/slave/containerizer/mesos/provisioner/docker/store.cpp 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 Diff: https://reviews.apache.org/r/53330/diff/4/ Testing --- Use mesos-execute to pull several different images, and verified following counters in agent's metrics/snapshot: ``` curl localhost:5051/metrics/snapshot | jq . | grep containerizer/mesos/docker_pull "containerizer/mesos/docker_store/layers_pulled": 47, "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, "containerizer/mesos/docker_store/pull_ms/p": 12528.3066648832, "containerizer/mesos/docker_store/pull_ms": 4550.814976, "containerizer/mesos/docker_store/pull_ms/count": 4, "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, "containerizer/mesos/docker_store/layers": 47, ``` Thanks, Zhitao Li
Re: Review Request 53330: Tracked layers and pull latency in docker store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/ --- (Updated April 11, 2017, 8:29 p.m.) Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. Bugs: MESOS-6451 https://issues.apache.org/jira/browse/MESOS-6451 Repository: mesos Description --- This patch added several metrics for docker store: - a counter for number of layers pulled - a gauge for total number of layers - a timer for pull latency distribution in the last hour Diffs (updated) - src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2 src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7 src/slave/containerizer/mesos/provisioner/docker/store.cpp 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 Diff: https://reviews.apache.org/r/53330/diff/4/ Changes: https://reviews.apache.org/r/53330/diff/3-4/ Testing --- Use mesos-execute to pull several different images, and verified following counters in agent's metrics/snapshot: ``` curl localhost:5051/metrics/snapshot | jq . | grep containerizer/mesos/docker_pull "containerizer/mesos/docker_store/layers_pulled": 47, "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, "containerizer/mesos/docker_store/pull_ms/p": 12528.3066648832, "containerizer/mesos/docker_store/pull_ms": 4550.814976, "containerizer/mesos/docker_store/pull_ms/count": 4, "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, "containerizer/mesos/docker_store/layers": 47, ``` Thanks, Zhitao Li
Re: Review Request 53330: Tracked layers and pull latency in docker store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/#review167448 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Nov. 7, 2016, 4:41 a.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53330/ > --- > > (Updated Nov. 7, 2016, 4:41 a.m.) > > > Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6451 > https://issues.apache.org/jira/browse/MESOS-6451 > > > Repository: mesos > > > Description > --- > > This patch added several metrics for docker store: > - a counter for number of layers pulled > - a gauge for total number of layers > - a timer for pull latency distribution in the last hour > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/paths.hpp > 232c027f8f96da0cb30b957bce4607d3695050d2 > src/slave/containerizer/mesos/provisioner/docker/paths.cpp > cd684b33eb308ce1eeb4539a5b2d51985d835db7 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 > > > Diff: https://reviews.apache.org/r/53330/diff/3/ > > > Testing > --- > > Use mesos-execute to pull several different images, and verified following > counters in agent's metrics/snapshot: > ``` > curl localhost:5051/metrics/snapshot | jq . | grep > containerizer/mesos/docker_pull > "containerizer/mesos/docker_store/layers_pulled": 47, > "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, > "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, > "containerizer/mesos/docker_store/pull_ms/p": 12528.3066648832, > "containerizer/mesos/docker_store/pull_ms": 4550.814976, > "containerizer/mesos/docker_store/pull_ms/count": 4, > "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, > "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, > "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, > "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, > "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, > "containerizer/mesos/docker_store/layers": 47, > ``` > > > Thanks, > > Zhitao Li > >
Re: Review Request 53330: Tracked layers and pull latency in docker store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/#review155129 --- Patch looks great! Reviews applied: [53105, 53330] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 7, 2016, 4:41 a.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53330/ > --- > > (Updated Nov. 7, 2016, 4:41 a.m.) > > > Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6451 > https://issues.apache.org/jira/browse/MESOS-6451 > > > Repository: mesos > > > Description > --- > > This patch added several metrics for docker store: > - a counter for number of layers pulled > - a gauge for total number of layers > - a timer for pull latency distribution in the last hour > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/paths.hpp > 232c027f8f96da0cb30b957bce4607d3695050d2 > src/slave/containerizer/mesos/provisioner/docker/paths.cpp > cd684b33eb308ce1eeb4539a5b2d51985d835db7 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 > > Diff: https://reviews.apache.org/r/53330/diff/ > > > Testing > --- > > Use mesos-execute to pull several different images, and verified following > counters in agent's metrics/snapshot: > ``` > curl localhost:5051/metrics/snapshot | jq . | grep > containerizer/mesos/docker_pull > "containerizer/mesos/docker_store/layers_pulled": 47, > "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, > "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, > "containerizer/mesos/docker_store/pull_ms/p": 12528.3066648832, > "containerizer/mesos/docker_store/pull_ms": 4550.814976, > "containerizer/mesos/docker_store/pull_ms/count": 4, > "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, > "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, > "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, > "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, > "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, > "containerizer/mesos/docker_store/layers": 47, > ``` > > > Thanks, > > Zhitao Li > >
Re: Review Request 53330: Tracked layers and pull latency in docker store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/ --- (Updated Nov. 7, 2016, 4:41 a.m.) Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. Changes --- Rebase. Bugs: MESOS-6451 https://issues.apache.org/jira/browse/MESOS-6451 Repository: mesos Description --- This patch added several metrics for docker store: - a counter for number of layers pulled - a gauge for total number of layers - a timer for pull latency distribution in the last hour Diffs (updated) - src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2 src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7 src/slave/containerizer/mesos/provisioner/docker/store.cpp 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 Diff: https://reviews.apache.org/r/53330/diff/ Testing --- Use mesos-execute to pull several different images, and verified following counters in agent's metrics/snapshot: ``` curl localhost:5051/metrics/snapshot | jq . | grep containerizer/mesos/docker_pull "containerizer/mesos/docker_store/layers_pulled": 47, "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, "containerizer/mesos/docker_store/pull_ms/p": 12528.3066648832, "containerizer/mesos/docker_store/pull_ms": 4550.814976, "containerizer/mesos/docker_store/pull_ms/count": 4, "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, "containerizer/mesos/docker_store/layers": 47, ``` Thanks, Zhitao Li
Re: Review Request 53330: Tracked layers and pull latency in docker store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/#review154978 --- Bad patch! Reviews applied: [53330, 53105] Failed command: ./support/apply-review.sh -n -r 53105 Error: 2016-11-04 20:15:28 URL:https://reviews.apache.org/r/53105/diff/raw/ [1733/1733] -> "53105.patch" [1] error: patch failed: src/slave/containerizer/docker.hpp:125 error: src/slave/containerizer/docker.hpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/15951/console - Mesos ReviewBot On Nov. 4, 2016, 5:16 p.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53330/ > --- > > (Updated Nov. 4, 2016, 5:16 p.m.) > > > Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6451 > https://issues.apache.org/jira/browse/MESOS-6451 > > > Repository: mesos > > > Description > --- > > This patch added several metrics for docker store: > - a counter for number of layers pulled > - a gauge for total number of layers > - a timer for pull latency distribution in the last hour > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/paths.hpp > 232c027f8f96da0cb30b957bce4607d3695050d2 > src/slave/containerizer/mesos/provisioner/docker/paths.cpp > cd684b33eb308ce1eeb4539a5b2d51985d835db7 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > e192f86a1848b373f3aa73d29688a96375cac313 > > Diff: https://reviews.apache.org/r/53330/diff/ > > > Testing > --- > > Use mesos-execute to pull several different images, and verified following > counters in agent's metrics/snapshot: > ``` > curl localhost:5051/metrics/snapshot | jq . | grep > containerizer/mesos/docker_pull > "containerizer/mesos/docker_store/layers_pulled": 47, > "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, > "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, > "containerizer/mesos/docker_store/pull_ms/p": 12528.3066648832, > "containerizer/mesos/docker_store/pull_ms": 4550.814976, > "containerizer/mesos/docker_store/pull_ms/count": 4, > "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, > "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, > "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, > "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, > "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, > "containerizer/mesos/docker_store/layers": 47, > ``` > > > Thanks, > > Zhitao Li > >
Re: Review Request 53330: Tracked layers and pull latency in docker store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/ --- (Updated Nov. 4, 2016, 5:16 p.m.) Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. Summary (updated) - Tracked layers and pull latency in docker store. Bugs: MESOS-6451 https://issues.apache.org/jira/browse/MESOS-6451 Repository: mesos Description (updated) --- This patch added several metrics for docker store: - a counter for number of layers pulled - a gauge for total number of layers - a timer for pull latency distribution in the last hour Diffs (updated) - src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2 src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7 src/slave/containerizer/mesos/provisioner/docker/store.cpp e192f86a1848b373f3aa73d29688a96375cac313 Diff: https://reviews.apache.org/r/53330/diff/ Testing (updated) --- Use mesos-execute to pull several different images, and verified following counters in agent's metrics/snapshot: ``` curl localhost:5051/metrics/snapshot | jq . | grep containerizer/mesos/docker_pull "containerizer/mesos/docker_store/layers_pulled": 47, "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, "containerizer/mesos/docker_store/pull_ms/p": 12528.3066648832, "containerizer/mesos/docker_store/pull_ms": 4550.814976, "containerizer/mesos/docker_store/pull_ms/count": 4, "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, "containerizer/mesos/docker_store/layers": 47, ``` Thanks, Zhitao Li
