[GitHub] [spark] cloud-fan commented on a change in pull request #26763: [SPARK-30125][SQL] Remove PostgreSQL dialect
cloud-fan commented on a change in pull request #26763: [SPARK-30125][SQL] Remove PostgreSQL dialect URL: https://github.com/apache/spark/pull/26763#discussion_r354297985 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -52,9 +52,9 @@ grammar SqlBase; } /** - * When true, the behavior of keywords follows ANSI SQL standard. + * When true, ANSI SQL parsing mode is enabled. */ - public boolean SQL_standard_keyword_behavior = false; Review comment: I think `SQL_standard_keyword_behavior` is better. Can we keep it? ANSI is too vague here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26684: [SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables.
cloud-fan commented on issue #26684: [SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables. URL: https://github.com/apache/spark/pull/26684#issuecomment-562118359 LGTM except https://github.com/apache/spark/pull/26684/files#r354117018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] aokolnychyi commented on a change in pull request #26751: [SPARK-30107][SQL] Expose nested schema pruning to all V2 sources
aokolnychyi commented on a change in pull request #26751: [SPARK-30107][SQL]
Expose nested schema pruning to all V2 sources
URL: https://github.com/apache/spark/pull/26751#discussion_r354287169
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScanBuilder.scala
##
@@ -68,6 +68,10 @@ case class ParquetScanBuilder(
// All filters that can be converted to Parquet are pushed down.
override def pushedFilters(): Array[Filter] = pushedParquetFilters
+ override def pruneColumns(requiredSchema: StructType): Unit = {
+this.requiredSchema = requiredSchema
+ }
Review comment:
Basically, the default implementation in `FileScanBuilder` is pruning only
top-level attributes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] aokolnychyi commented on a change in pull request #26751: [SPARK-30107][SQL] Expose nested schema pruning to all V2 sources
aokolnychyi commented on a change in pull request #26751: [SPARK-30107][SQL]
Expose nested schema pruning to all V2 sources
URL: https://github.com/apache/spark/pull/26751#discussion_r354286601
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScanBuilder.scala
##
@@ -68,6 +68,10 @@ case class ParquetScanBuilder(
// All filters that can be converted to Parquet are pushed down.
override def pushedFilters(): Array[Filter] = pushedParquetFilters
+ override def pruneColumns(requiredSchema: StructType): Unit = {
+this.requiredSchema = requiredSchema
+ }
Review comment:
I think data sources should do their best to prune whatever they can.
Here is a quote from `SupportsPushDownRequiredColumns`:
> Implementation should try its best to prune the unnecessary columns or
nested fields, but it's also OK to do the pruning partially, e.g., a data
source may not be able to prune nested fields, and only prune top-level columns.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
AmplabJenkins removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562109597 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114900/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562109750 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114898/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562109742 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562109750 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114898/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
AmplabJenkins removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562109592 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
SparkQA removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562098036 **[Test build #114900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114900/testReport)** for PR 26767 at commit [`a7876a0`](https://github.com/apache/spark/commit/a7876a014ba55765b722ed4783a2c9b7b259ecd6). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562109742 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
SparkQA commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562109516 **[Test build #114900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114900/testReport)** for PR 26767 at commit [`a7876a0`](https://github.com/apache/spark/commit/a7876a014ba55765b722ed4783a2c9b7b259ecd6). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
AmplabJenkins commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562109597 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114900/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
AmplabJenkins commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562109592 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
SparkQA removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562027185 **[Test build #114898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114898/testReport)** for PR 25001 at commit [`9feb25d`](https://github.com/apache/spark/commit/9feb25dfc724ed50b4891067f2e61608d8ef99a9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562109222 **[Test build #114898 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114898/testReport)** for PR 25001 at commit [`9feb25d`](https://github.com/apache/spark/commit/9feb25dfc724ed50b4891067f2e61608d8ef99a9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] aokolnychyi commented on a change in pull request #26751: [SPARK-30107][SQL] Expose nested schema pruning to all V2 sources
aokolnychyi commented on a change in pull request #26751: [SPARK-30107][SQL]
Expose nested schema pruning to all V2 sources
URL: https://github.com/apache/spark/pull/26751#discussion_r354285161
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala
##
@@ -76,28 +78,48 @@ object PushDownUtils extends PredicateHelper {
* @return the created `ScanConfig`(since column pruning is the last step of
operator pushdown),
* and new output attributes after column pruning.
*/
- // TODO: nested column pruning.
def pruneColumns(
scanBuilder: ScanBuilder,
relation: DataSourceV2Relation,
- exprs: Seq[Expression]): (Scan, Seq[AttributeReference]) = {
+ projects: Seq[NamedExpression],
+ filters: Seq[Expression]): (Scan, Seq[AttributeReference]) = {
scanBuilder match {
+ case r: SupportsPushDownRequiredColumns if
SQLConf.get.nestedSchemaPruningEnabled =>
+val rootFields = SchemaPruning.identifyRootFields(projects, filters)
+val prunedSchema = if (rootFields.nonEmpty) {
Review comment:
This check was needed to detect if any nested column was requested. The old
rule would not apply otherwise. Here, the situation is different as we need to
prune top-level columns even if no nested attributes are requested.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated de
AmplabJenkins removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562107598 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114902/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecat
SparkQA removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562100729 **[Test build #114902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114902/testReport)** for PR 26765 at commit [`1243bff`](https://github.com/apache/spark/commit/1243bff2b4010959b7cca92a0644407414017576). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated de
AmplabJenkins removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562107587 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warn
SparkQA commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562107556 **[Test build #114902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114902/testReport)** for PR 26765 at commit [`1243bff`](https://github.com/apache/spark/commit/1243bff2b4010959b7cca92a0644407414017576). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecatio
AmplabJenkins commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562107587 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecatio
AmplabJenkins commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562107598 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114902/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] hagerf commented on issue #26762: [SPARK-30131] add array_median function
hagerf commented on issue #26762: [SPARK-30131] add array_median function URL: https://github.com/apache/spark/pull/26762#issuecomment-562107475 @srowen Ok, I see. If it's really that restrictive then users can use other functions for this, even though I think it could be a popular addition, used by many. So should I close this PR or ask some other peoples opinion on the matter? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562106176 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114897/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562106166 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562106166 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562106176 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114897/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
SparkQA commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562105644 **[Test build #114897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114897/testReport)** for PR 26412 at commit [`a44948e`](https://github.com/apache/spark/commit/a44948eccea4ac3f033248babe84c8ab6792d5e0). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
SparkQA removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562021793 **[Test build #114897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114897/testReport)** for PR 26412 at commit [`a44948e`](https://github.com/apache/spark/commit/a44948eccea4ac3f033248babe84c8ab6792d5e0). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562103931 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19725/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562103926 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562103926 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562103931 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19725/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562103454 **[Test build #114903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114903/testReport)** for PR 26712 at commit [`17c91f4`](https://github.com/apache/spark/commit/17c91f4f3ae9dcf5babe1cdc646d1ca0aa66d53c). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] amanomer commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
amanomer commented on a change in pull request #26712: [SPARK-29883][SQL]
Improve error messages when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r354274300
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -618,19 +618,36 @@ object FunctionRegistry {
}
throw new AnalysisException(invalidArgumentsMsg)
}
-Try(f.newInstance(expressions : _*).asInstanceOf[Expression]) match {
- case Success(e) => e
- case Failure(e) =>
-// the exception is an invocation exception. To get a meaningful
message, we need the
-// cause.
-throw new AnalysisException(e.getCause.getMessage)
+try {
+ f.newInstance(expressions : _*).asInstanceOf[Expression]
+} catch {
+ // the exception is an invocation exception. To get a meaningful
message, we need the
+ // cause.
+ case e: Exception => throw new
AnalysisException(e.getCause.getMessage)
}
}
}
(name, (expressionInfo[T](name), builder))
}
+ private def expressionWithAlias[T <: Expression](name: String)
+ (implicit tag: ClassTag[T]): (String, (ExpressionInfo, FunctionBuilder))
= {
+val constructors = tag.runtimeClass.getConstructors
+ .filter(_.getParameterTypes.head == classOf[String])
+assert(constructors.length == 1)
+val builder = (expressions: Seq[Expression]) => {
+ try {
+constructors.head.newInstance(name.toString,
expressions.head).asInstanceOf[Expression]
Review comment:
It works. Updated in latest commit. cc @cloud-fan
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] amanomer commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
amanomer commented on a change in pull request #26712: [SPARK-29883][SQL]
Improve error messages when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r354274300
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -618,19 +618,36 @@ object FunctionRegistry {
}
throw new AnalysisException(invalidArgumentsMsg)
}
-Try(f.newInstance(expressions : _*).asInstanceOf[Expression]) match {
- case Success(e) => e
- case Failure(e) =>
-// the exception is an invocation exception. To get a meaningful
message, we need the
-// cause.
-throw new AnalysisException(e.getCause.getMessage)
+try {
+ f.newInstance(expressions : _*).asInstanceOf[Expression]
+} catch {
+ // the exception is an invocation exception. To get a meaningful
message, we need the
+ // cause.
+ case e: Exception => throw new
AnalysisException(e.getCause.getMessage)
}
}
}
(name, (expressionInfo[T](name), builder))
}
+ private def expressionWithAlias[T <: Expression](name: String)
+ (implicit tag: ClassTag[T]): (String, (ExpressionInfo, FunctionBuilder))
= {
+val constructors = tag.runtimeClass.getConstructors
+ .filter(_.getParameterTypes.head == classOf[String])
+assert(constructors.length == 1)
+val builder = (expressions: Seq[Expression]) => {
+ try {
+constructors.head.newInstance(name.toString,
expressions.head).asInstanceOf[Expression]
Review comment:
It works
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562101300 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114896/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecatio
AmplabJenkins commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562101263 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecatio
AmplabJenkins commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562101270 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19724/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
AmplabJenkins removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562101290 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated de
AmplabJenkins removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562101270 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19724/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562101300 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114896/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated de
AmplabJenkins removed a comment on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562101263 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
AmplabJenkins commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562101290 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
SparkQA commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562100700 **[Test build #114896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114896/testReport)** for PR 26412 at commit [`c84d46e`](https://github.com/apache/spark/commit/c84d46ea6d384dcb1f442ca54abad48e59c92bb3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
SparkQA removed a comment on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-562019209 **[Test build #114896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114896/testReport)** for PR 26412 at commit [`c84d46e`](https://github.com/apache/spark/commit/c84d46ea6d384dcb1f442ca54abad48e59c92bb3). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warn
SparkQA commented on issue #26765: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings URL: https://github.com/apache/spark/pull/26765#issuecomment-562100729 **[Test build #114902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114902/testReport)** for PR 26765 at commit [`1243bff`](https://github.com/apache/spark/commit/1243bff2b4010959b7cca92a0644407414017576). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on issue #26762: [SPARK-30131] add array_median function
srowen commented on issue #26762: [SPARK-30131] add array_median function URL: https://github.com/apache/spark/pull/26762#issuecomment-562098756 Yes, those are pretty different use cases; `approx_median` would also not compute a median over a whole column, and indeed, would be prohibitive enough to compute that I think we assume it isn't desirable vs a pretty tight bound on the median. (IIRC there are helper aggregator classes you can use to do it anyway) The other `array_*` functions are typically there for Hive parity and otherwise would be something users just apply a UDF for. It's not crazy, just think opinion has turned against adding things that aren't in Hive or standard SQL from here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
AmplabJenkins commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562098603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19722/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operations writ
AmplabJenkins commented on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operations write to different partitions in the same table. URL: https://github.com/apache/spark/pull/25863#issuecomment-562098553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19723/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operati
AmplabJenkins removed a comment on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operations write to different partitions in the same table. URL: https://github.com/apache/spark/pull/25863#issuecomment-562098546 Build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operati
AmplabJenkins removed a comment on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operations write to different partitions in the same table. URL: https://github.com/apache/spark/pull/25863#issuecomment-562098553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19723/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
AmplabJenkins removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562098603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19722/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
AmplabJenkins commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562098595 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operations writ
AmplabJenkins commented on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operations write to different partitions in the same table. URL: https://github.com/apache/spark/pull/25863#issuecomment-562098546 Build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
AmplabJenkins removed a comment on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562098595 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
SparkQA commented on issue #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767#issuecomment-562098036 **[Test build #114900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114900/testReport)** for PR 26767 at commit [`a7876a0`](https://github.com/apache/spark/commit/a7876a014ba55765b722ed4783a2c9b7b259ecd6). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operations write to d
SparkQA commented on issue #25863: [SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and support concurrent file source write operations write to different partitions in the same table. URL: https://github.com/apache/spark/pull/25863#issuecomment-562098039 **[Test build #114901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114901/testReport)** for PR 25863 at commit [`0433977`](https://github.com/apache/spark/commit/04339772144651c35efc98649db1872c6cf9bcc5). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] hagerf commented on issue #26762: [SPARK-30131] add array_median function
hagerf commented on issue #26762: [SPARK-30131] add array_median function URL: https://github.com/apache/spark/pull/26762#issuecomment-562097725 Yes, of course. But we have the prefix `approx` because calculating exact median over a whole dataset is difficult to do efficiently. So users who want an exact median are forced to use rdds, or UDF etc on arrays if the data fits in an array. My point was: there is no exact median or percentile functionality at all in Spark. This would help for some subset of those use cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zhengruifeng opened a new pull request #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array
zhengruifeng opened a new pull request #26767: [SPARK-29914][ML][FOLLOWUP] CountVectorizer del big attribute array URL: https://github.com/apache/spark/pull/26767 ### What changes were proposed in this pull request? CountVectorizer del big attribute array ### Why are the changes needed? Previous discussion is [here](https://github.com/apache/spark/pull/26547) > vocabulary is a big number, for example 1 << 18 by default. We will keep a big attribute array here. ### Does this PR introduce any user-facing change? No ### How was this patch tested? existing testsuites This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script
srowen commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script URL: https://github.com/apache/spark/pull/26757#discussion_r354258794 ## File path: build/sbt ## @@ -66,7 +66,7 @@ Usage: $script_name [options] -sbt-dir path to global settings/plugins directory (default: ~/.sbt) -sbt-bootpath to shared boot directory (default: ~/.sbt/boot in 0.11 series) -ivy path to local Ivy repository (default: ~/.ivy2) - -mem set memory options (default: $sbt_mem, which is $(get_mem_opts $sbt_mem)) + -mem set memory options (default: $sbt_default_mem, which is $(get_mem_opts $sbt_default_mem)) Review comment: This doesn't update to 1.3.4 at all, no. (Moving to sbt 1.x is a fairly significant change; I couldn't get it to work a year ago) The script here is bits and pieces of an old sbt 0.x script. This is just fixing the mem message, and happens to mimic some lines from a newer sbt script. Incidentally, I kind of would like to remove the build/mvn and build/sbt scripts anyway. It works fine with recent mvn and I don't think build tools are hard to install for developers. Although installing sbt locally installs a new version, it still does understand the 0.13-based build. I don't know how much people are attached to this 'built in' wrapper, and I don't feel strongly about. Of course I'd also like to stop supporting 2 builds and would remove sbt. But that may wait until we face problems keeping the current one working with Scala 2.13.x or something. These are both quite separate issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on issue #26762: [SPARK-30131] add array_median function
srowen commented on issue #26762: [SPARK-30131] add array_median function URL: https://github.com/apache/spark/pull/26762#issuecomment-562091119 That's a pretty different function: it computes a quantile over the whole data set. This is a function of a single array value. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal URL: https://github.com/apache/spark/pull/26537#issuecomment-562086114 thanks, @HyukjinKwon for your suggestion. I have drafted a proposal here. http://apache-spark-developers-list.1001551.n3.nabble.com/PROPOSAL-Support-ANSI-type-real-numeric-as-synonyms-for-float-decimal-td28475.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
cloud-fan commented on a change in pull request #26712: [SPARK-29883][SQL]
Improve error messages when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r354248459
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -618,19 +618,36 @@ object FunctionRegistry {
}
throw new AnalysisException(invalidArgumentsMsg)
}
-Try(f.newInstance(expressions : _*).asInstanceOf[Expression]) match {
- case Success(e) => e
- case Failure(e) =>
-// the exception is an invocation exception. To get a meaningful
message, we need the
-// cause.
-throw new AnalysisException(e.getCause.getMessage)
+try {
+ f.newInstance(expressions : _*).asInstanceOf[Expression]
+} catch {
+ // the exception is an invocation exception. To get a meaningful
message, we need the
+ // cause.
+ case e: Exception => throw new
AnalysisException(e.getCause.getMessage)
}
}
}
(name, (expressionInfo[T](name), builder))
}
+ private def expressionWithAlias[T <: Expression](name: String)
+ (implicit tag: ClassTag[T]): (String, (ExpressionInfo, FunctionBuilder))
= {
+val constructors = tag.runtimeClass.getConstructors
+ .filter(_.getParameterTypes.head == classOf[String])
+assert(constructors.length == 1)
+val builder = (expressions: Seq[Expression]) => {
+ try {
+constructors.head.newInstance(name.toString,
expressions.head).asInstanceOf[Expression]
Review comment:
how about `newInstance((name.toString +: expressions): _*)`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562074456 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114899/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562074440 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562074440 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562074422 **[Test build #114899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114899/testReport)** for PR 26712 at commit [`3c87222`](https://github.com/apache/spark/commit/3c8722239d22e576cb9b7925ab55e0443c687942). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562074456 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114899/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
SparkQA removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562072806 **[Test build #114899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114899/testReport)** for PR 26712 at commit [`3c87222`](https://github.com/apache/spark/commit/3c8722239d22e576cb9b7925ab55e0443c687942). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
SparkQA commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562072806 **[Test build #114899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114899/testReport)** for PR 26712 at commit [`3c87222`](https://github.com/apache/spark/commit/3c8722239d22e576cb9b7925ab55e0443c687942). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562070140 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19721/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins removed a comment on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562070135 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562070135 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
AmplabJenkins commented on issue #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias URL: https://github.com/apache/spark/pull/26712#issuecomment-562070140 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19721/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan
amanomer commented on issue #26734: [SPARK-30099][SQL] Improve Analyzed Logical Plan URL: https://github.com/apache/spark/pull/26734#issuecomment-562067688 https://github.com/apache/spark/blob/332e252a1448a27cfcfc1d1d794f7979e6cd331a/sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala#L135-L154 Hi @cloud-fan @hvanhovell @adipola , I think we can optimize this code as, if some query fails in analysis phase and throws AnalysisException. Further phases of planning will also fail so we can avoid constructing the plan for them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system
AmplabJenkins removed a comment on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-562065772 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system
AmplabJenkins commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-562065786 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114895/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system
AmplabJenkins removed a comment on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-562065786 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114895/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system
AmplabJenkins commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-562065772 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system
SparkQA removed a comment on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-562016839 **[Test build #114895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114895/testReport)** for PR 24132 at commit [`bb5f2b8`](https://github.com/apache/spark/commit/bb5f2b8e5bc00223c8b45d358f49b550c72a84a0). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system
SparkQA commented on issue #24132: [SPARK-27189][CORE] Add Executor metrics and memory usage instrumentation to the metrics system URL: https://github.com/apache/spark/pull/24132#issuecomment-562065001 **[Test build #114895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114895/testReport)** for PR 24132 at commit [`bb5f2b8`](https://github.com/apache/spark/commit/bb5f2b8e5bc00223c8b45d358f49b550c72a84a0). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] hagerf commented on issue #26762: [SPARK-30131] add array_median function
hagerf commented on issue #26762: [SPARK-30131] add array_median function URL: https://github.com/apache/spark/pull/26762#issuecomment-562059403 @HyukjinKwon I added some links, I think they should be relevant. We already have `approxQuantile` but then this would be an exact function, limited to arrays. This function only calculates median, which is the (probably) the most common use case. I can extend it to support exact quantiles, if people think that would be better. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] amanomer commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
amanomer commented on a change in pull request #26712: [SPARK-29883][SQL]
Improve error messages when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r354207829
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -618,19 +618,36 @@ object FunctionRegistry {
}
throw new AnalysisException(invalidArgumentsMsg)
}
-Try(f.newInstance(expressions : _*).asInstanceOf[Expression]) match {
- case Success(e) => e
- case Failure(e) =>
-// the exception is an invocation exception. To get a meaningful
message, we need the
-// cause.
-throw new AnalysisException(e.getCause.getMessage)
+try {
+ f.newInstance(expressions : _*).asInstanceOf[Expression]
+} catch {
+ // the exception is an invocation exception. To get a meaningful
message, we need the
+ // cause.
+ case e: Exception => throw new
AnalysisException(e.getCause.getMessage)
}
}
}
(name, (expressionInfo[T](name), builder))
}
+ private def expressionWithAlias[T <: Expression](name: String)
+ (implicit tag: ClassTag[T]): (String, (ExpressionInfo, FunctionBuilder))
= {
+val constructors = tag.runtimeClass.getConstructors
+ .filter(_.getParameterTypes.head == classOf[String])
+assert(constructors.length == 1)
+val builder = (expressions: Seq[Expression]) => {
+ try {
+constructors.head.newInstance(name.toString,
expressions.head).asInstanceOf[Expression]
Review comment:
> is it possible to do newInstance(name.toString, expressions: _*)?
No, compilation error.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
HyukjinKwon commented on a change in pull request #26537: [SPARK-29587][SQL]
Support SQL Standard type real as float(4) numeric as decimal
URL: https://github.com/apache/spark/pull/26537#discussion_r354188577
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##
@@ -2154,17 +2154,17 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
case ("smallint" | "short", Nil) => ShortType
case ("int" | "integer", Nil) => IntegerType
case ("bigint" | "long", Nil) => LongType
- case ("float", Nil) => FloatType
+ case ("float" | "real", Nil) => FloatType
Review comment:
So seems the key difference between DEICMAL and NUMERIC are:
> implementation-defined decimal precision equal to or greater than the
value of the specified precision.
Decimal can have _at least_ specified precision (which means can have more)
whereas numeric should have exactly specified precision.
Spark's decimal satisfy both so I think NUMERIC as a synonym of DECIMAL
makes sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas
HyukjinKwon commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas URL: https://github.com/apache/spark/pull/24405#discussion_r354183693 ## File path: docs/sql-data-sources-avro.md ## @@ -240,6 +240,14 @@ Data source options of Avro can be set via: function from_avro + +writerSchema Review comment: Yeah, actually `writerSchema` name is super confusing to me. Can we use `actualSchema`? I would prefer this one more. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas
HyukjinKwon commented on issue #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas URL: https://github.com/apache/spark/pull/24405#issuecomment-562039688 @giamo, sorry it took long. very close to go. Can you address the comments? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26766: [SPARK-30138][SQL]Separate configuration key of max iterations for analyzer and optimizer
AmplabJenkins removed a comment on issue #26766: [SPARK-30138][SQL]Separate configuration key of max iterations for analyzer and optimizer URL: https://github.com/apache/spark/pull/26766#issuecomment-562035708 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26766: [SPARK-30138][SQL]Separate configuration key of max iterations for analyzer and optimizer
AmplabJenkins commented on issue #26766: [SPARK-30138][SQL]Separate configuration key of max iterations for analyzer and optimizer URL: https://github.com/apache/spark/pull/26766#issuecomment-562036142 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26766: [SPARK-30138][SQL]Separate configuration key of max iterations for analyzer and optimizer
AmplabJenkins commented on issue #26766: [SPARK-30138][SQL]Separate configuration key of max iterations for analyzer and optimizer URL: https://github.com/apache/spark/pull/26766#issuecomment-562035708 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script
yaooqinn commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script URL: https://github.com/apache/spark/pull/26757#discussion_r354177570 ## File path: build/sbt ## @@ -66,7 +66,7 @@ Usage: $script_name [options] -sbt-dir path to global settings/plugins directory (default: ~/.sbt) -sbt-bootpath to shared boot directory (default: ~/.sbt/boot in 0.11 series) -ivy path to local Ivy repository (default: ~/.ivy2) - -mem set memory options (default: $sbt_mem, which is $(get_mem_opts $sbt_mem)) + -mem set memory options (default: $sbt_default_mem, which is $(get_mem_opts $sbt_default_mem)) Review comment: Not really aiming to resync, `declare sbt_default_mem=1024` is exists in the script `sbt-launch-lib.bash` of `sbt 0.13.18`, we might have not copied it before. metioned `sbt 1.3.4` here, just to keep up to date. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script
yaooqinn commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script URL: https://github.com/apache/spark/pull/26757#discussion_r354177915 ## File path: build/sbt ## @@ -66,7 +66,7 @@ Usage: $script_name [options] -sbt-dir path to global settings/plugins directory (default: ~/.sbt) -sbt-bootpath to shared boot directory (default: ~/.sbt/boot in 0.11 series) -ivy path to local Ivy repository (default: ~/.ivy2) - -mem set memory options (default: $sbt_mem, which is $(get_mem_opts $sbt_mem)) + -mem set memory options (default: $sbt_default_mem, which is $(get_mem_opts $sbt_default_mem)) Review comment: ``` declare init_sbt_version="0.13.18" declare sbt_default_mem=1024 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script
yaooqinn commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script URL: https://github.com/apache/spark/pull/26757#discussion_r354177570 ## File path: build/sbt ## @@ -66,7 +66,7 @@ Usage: $script_name [options] -sbt-dir path to global settings/plugins directory (default: ~/.sbt) -sbt-bootpath to shared boot directory (default: ~/.sbt/boot in 0.11 series) -ivy path to local Ivy repository (default: ~/.ivy2) - -mem set memory options (default: $sbt_mem, which is $(get_mem_opts $sbt_mem)) + -mem set memory options (default: $sbt_default_mem, which is $(get_mem_opts $sbt_default_mem)) Review comment: Not really aiming to resync, `declare sbt_default_mem=1024` is exists in the script `sbt-launch-lib.bash` of `sbt 0.13.18`, we might have not copied it before. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] fuwhu opened a new pull request #26766: [SPARK-30138][SQL]Separate configuration key of max iterations for analyzer and optimizer
fuwhu opened a new pull request #26766: [SPARK-30138][SQL]Separate configuration key of max iterations for analyzer and optimizer URL: https://github.com/apache/spark/pull/26766 ### What changes were proposed in this pull request? separate the configuration keys "spark.sql.optimizer.maxIterations" and "spark.sql.analyzer.maxIterations". ### Why are the changes needed? Currently, both Analyzer and Optimizer use conf "spark.sql.optimizer.excludedRules" to set the max iterations to run, which is a little confusing. It is clearer to add a new conf "spark.sql.analyzer.excludedRules" for analyzer max iterations. ### Does this PR introduce any user-facing change? no ### How was this patch tested? Existing unit tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres
yaooqinn commented on a change in pull request #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#discussion_r354170836 ## File path: sql/core/src/test/resources/sql-tests/results/datetime.sql.out ## @@ -100,64 +100,294 @@ struct +struct -- !query 11 output -2001-10-05 +2019-01-01 -- !query 12 -select 7 + date '2001-09-28' +select timestamp '2019-01-01\t' -- !query 12 schema -struct +struct -- !query 12 output -2001-10-05 +2019-01-01 00:00:00 -- !query 13 -select date '2001-10-01' - 7 +select timestamp'2011-11-11 11:11:11' + interval '2' day -- !query 13 schema -struct +struct -- !query 13 output -2001-09-24 +2011-11-13 11:11:11 -- !query 14 -select date '2001-10-01' - date '2001-09-28' +select timestamp'2011-11-11 11:11:11' - interval '2' day -- !query 14 schema -struct +struct -- !query 14 output -3 days +2011-11-09 11:11:11 -- !query 15 -select date'2020-01-01' - timestamp'2019-10-06 10:11:12.345678' +select date'2011-11-11 11:11:11' + interval '2' second -- !query 15 schema -struct +struct -- !query 15 output -2078 hours 48 minutes 47.654322 seconds +2011-11-11 -- !query 16 -select timestamp'2019-10-06 10:11:12.345678' - date'2020-01-01' +select date'2011-11-11 11:11:11' - interval '2' second -- !query 16 schema -struct +struct -- !query 16 output --2078 hours -48 minutes -47.654322 seconds +2011-11-10 -- !query 17 -select date '2019-01-01\t' +select '2011-11-11' - interval '2' day -- !query 17 schema -struct +struct Review comment: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDTIMinus.java#L111-121 ```scala // Allowed operations: // IntervalYearMonth - IntervalYearMonth = IntervalYearMonth // Date - IntervalYearMonth = Date (operands not reversible) // Timestamp - IntervalYearMonth = Timestamp (operands not reversible) // IntervalDayTime - IntervalDayTime = IntervalDayTime // Date - IntervalYearMonth = Timestamp (operands not reversible) // Timestamp - IntervalYearMonth = Timestamp (operands not reversible) // Timestamp - Timestamp = IntervalDayTime // Date - Date = IntervalDayTime // Timestamp - Date = IntervalDayTime (operands reversible) // Date - Int = Date ``` Hive's behavior is more convictive, we can check this later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562027185 **[Test build #114898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114898/testReport)** for PR 25001 at commit [`9feb25d`](https://github.com/apache/spark/commit/9feb25dfc724ed50b4891067f2e61608d8ef99a9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562024945 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19720/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562024934 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562024945 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19720/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
