[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206140527
  
I see the problem. 

```
[error] 
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:266:
 value contains is not a member of Option[String]
[error] assert(desc.viewText.contains("SELECT * FROM tab1"))
[error]  ^
[error] 
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:267:
 value contains is not a member of Option[String]
[error] assert(desc.viewOriginalText.contains("SELECT * FROM tab1"))
[error]  ^
[error] 
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:293:
 value contains is not a member of Option[String]
[error] assert(desc.viewText.contains("SELECT * FROM tab1"))
[error]  ^
[error] 
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:294:
 value contains is not a member of Option[String]
[error] assert(desc.viewOriginalText.contains("SELECT * FROM tab1"))
[error]  ^
[error] four errors found
[error] Compile failed at Apr 5, 2016 10:59:09 PM [10.502s]
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206140754
  
Will fix it using a PR with [HOT]. Sorry for it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206139977
  

https://amplab.cs.berkeley.edu/jenkins/job/spark-master-compile-maven-scala-2.10/
 ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206138869
  
Or I need to do it in my local environment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206138089
  
Sure. Could you show me how to find the build log? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206137008
  
@gatorsmile Seems scala 2.10 build is broken. Can you take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/12169


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206126467
  
Merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206100034
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55072/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206100033
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206099910
  
**[Test build #55072 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55072/consoleFull)**
 for PR 12169 at commit 
[`93e51b4`](https://github.com/apache/spark/commit/93e51b4a31c166fd48627575cef856b5d044f9dc).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206071828
  
**[Test build #55072 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55072/consoleFull)**
 for PR 12169 at commit 
[`93e51b4`](https://github.com/apache/spark/commit/93e51b4a31c166fd48627575cef856b5d044f9dc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206061371
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55049/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206061368
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206060792
  
**[Test build #55049 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55049/consoleFull)**
 for PR 12169 at commit 
[`e5a8de7`](https://github.com/apache/spark/commit/e5a8de7b94a980f183e262e998456f64189c3e3c).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `s\"its class is $`
  * `  s\"Unable to generate an encoder for inner class `$`
  * `case class UnresolvedGenerator(name: String, children: 
Seq[Expression]) extends Generator `
  * `case class UnresolvedDeserializer(deserializer: Expression, 
inputAttributes: Seq[Attribute])`
  * `case class FunctionResource(resourceType: FunctionResourceType, uri: 
String)`
  * `trait FunctionResourceLoader `
  * `case class CatalogFunction(`
  * `case class CreateFunction(`
  * `case class DropFunction(`
  * `case class StreamingRelation(dataSource: DataSource, sourceName: 
String, output: Seq[Attribute])`
  * `case class StreamingExecutionRelation(source: Source, output: 
Seq[Attribute]) extends LeafNode `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206037747
  
**[Test build #55049 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55049/consoleFull)**
 for PR 12169 at commit 
[`e5a8de7`](https://github.com/apache/spark/commit/e5a8de7b94a980f183e262e998456f64189c3e3c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[andrewor14]

Github user andrewor14 commented on a diff in the pull request:

https://github.com/apache/spark/pull/12169#discussion_r58632645
  
--- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala 
---
@@ -215,11 +215,20 @@ class HiveSqlAstBuilder extends SparkSqlAstBuilder {
 
   /**
* Create or replace a view. This creates a [[CreateViewAsSelect]] 
command.
+   *
+   * For example:
+   * {{{
+   *   CREATE VIEW [IF NOT EXISTS] [db_name.]view_name
+   *   [(column_name [COMMENT column_comment], ...) ]
+   *   [COMMENT view_comment]
+   *   [TBLPROPERTIES (property_name = property_value, ...)]
+   *   AS SELECT ...;
+   * }}}
*/
   override def visitCreateView(ctx: CreateViewContext): LogicalPlan = 
withOrigin(ctx) {
 // Pass a partitioned view on to hive.
--- End diff --

this needs to be deleted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206037824
  
LGTM we just need to make tests pass now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206037592
  
Build is broken I think. retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206017548
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206017535
  
**[Test build #55031 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55031/consoleFull)**
 for PR 12169 at commit 
[`e5a8de7`](https://github.com/apache/spark/commit/e5a8de7b94a980f183e262e998456f64189c3e3c).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `s\"its class is $`
  * `  s\"Unable to generate an encoder for inner class `$`
  * `case class UnresolvedGenerator(name: String, children: 
Seq[Expression]) extends Generator `
  * `case class UnresolvedDeserializer(deserializer: Expression, 
inputAttributes: Seq[Attribute])`
  * `case class FunctionResource(resourceType: FunctionResourceType, uri: 
String)`
  * `trait FunctionResourceLoader `
  * `case class CatalogFunction(`
  * `case class CreateFunction(`
  * `case class DropFunction(`
  * `case class StreamingRelation(dataSource: DataSource, sourceName: 
String, output: Seq[Attribute])`
  * `case class StreamingExecutionRelation(source: Source, output: 
Seq[Attribute]) extends LeafNode `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206017552
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55031/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206015294
  
**[Test build #55031 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55031/consoleFull)**
 for PR 12169 at commit 
[`e5a8de7`](https://github.com/apache/spark/commit/e5a8de7b94a980f183e262e998456f64189c3e3c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206013206
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206001541
  
Build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-206001545
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55027/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/12169#discussion_r58616584
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -553,9 +553,13 @@ class SparkSqlAstBuilder extends AstBuilder {
*   ALTER TABLE table ADD [IF NOT EXISTS] PARTITION spec [LOCATION 
'loc1']
*   ALTER VIEW view ADD [IF NOT EXISTS] PARTITION spec
* }}}
+   *
+   * ALTER VIEW ... DROP PARTITION ... is not supported because the 
concept of partitioning
+   * is associated with physical tables
*/
   override def visitAddTablePartition(
   ctx: AddTablePartitionContext): LogicalPlan = withOrigin(ctx) {
+if (ctx.VIEW != null) throw new ParseException(s"Unsupported 
partitioned view", ctx)
--- End diff --

Will do it now. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205959612
  
Looks pretty good, just a minor comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[andrewor14]

Github user andrewor14 commented on a diff in the pull request:

https://github.com/apache/spark/pull/12169#discussion_r58600702
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -553,9 +553,13 @@ class SparkSqlAstBuilder extends AstBuilder {
*   ALTER TABLE table ADD [IF NOT EXISTS] PARTITION spec [LOCATION 
'loc1']
*   ALTER VIEW view ADD [IF NOT EXISTS] PARTITION spec
* }}}
+   *
+   * ALTER VIEW ... DROP PARTITION ... is not supported because the 
concept of partitioning
+   * is associated with physical tables
*/
   override def visitAddTablePartition(
   ctx: AddTablePartitionContext): LogicalPlan = withOrigin(ctx) {
+if (ctx.VIEW != null) throw new ParseException(s"Unsupported 
partitioned view", ctx)
--- End diff --

I think @yhuai prefers to say something like `Operation not allowed: 
partitioned views` for the message


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205892839
  
Thanks for the review! @hvanhovell 

Also cc @yhuai @andrewor14 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205855786
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205855791
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54983/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205855383
  
**[Test build #54983 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54983/consoleFull)**
 for PR 12169 at commit 
[`140f859`](https://github.com/apache/spark/commit/140f85998953f1d945df4f318ac0a88d197583cd).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205808491
  
**[Test build #54983 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54983/consoleFull)**
 for PR 12169 at commit 
[`140f859`](https://github.com/apache/spark/commit/140f85998953f1d945df4f318ac0a88d197583cd).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205699757
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54959/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205699750
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205698876
  
**[Test build #54959 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54959/consoleFull)**
 for PR 12169 at commit 
[`b6c1601`](https://github.com/apache/spark/commit/b6c1601815c4fc74b1d8aa74ff57f5d72c88526c).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/12169#discussion_r58495982
  
--- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -75,17 +75,17 @@ statement
 | ALTER TABLE tableIdentifier NOT STORED AS DIRECTORIES
#unstoreTable
 | ALTER TABLE tableIdentifier
 SET SKEWED LOCATION skewedLocationList 
#setTableSkewLocations
-| ALTER TABLE tableIdentifier ADD (IF NOT EXISTS)?
+| ALTER kind=TABLE tableIdentifier ADD (IF NOT EXISTS)?
--- End diff --

Thanks! Will do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/12169#discussion_r58493735
  
--- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -75,17 +75,17 @@ statement
 | ALTER TABLE tableIdentifier NOT STORED AS DIRECTORIES
#unstoreTable
 | ALTER TABLE tableIdentifier
 SET SKEWED LOCATION skewedLocationList 
#setTableSkewLocations
-| ALTER TABLE tableIdentifier ADD (IF NOT EXISTS)?
+| ALTER kind=TABLE tableIdentifier ADD (IF NOT EXISTS)?
--- End diff --

Minor: we don't really need kind. We can also just check for the existance 
of the VIEW keyword, e.g.: `ctx.VIEW != null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205664381
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54958/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205664309
  
**[Test build #54958 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54958/consoleFull)**
 for PR 12169 at commit 
[`181c817`](https://github.com/apache/spark/commit/181c8173b8ea4aba631e9330d8450f47a9396648).
 * This patch **fails MiMa tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205664375
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205662059
  
**[Test build #54959 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54959/consoleFull)**
 for PR 12169 at commit 
[`b6c1601`](https://github.com/apache/spark/commit/b6c1601815c4fc74b1d8aa74ff57f5d72c88526c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12169#issuecomment-205658050
  
**[Test build #54958 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54958/consoleFull)**
 for PR 12169 at commit 
[`181c817`](https://github.com/apache/spark/commit/181c8173b8ea4aba631e9330d8450f47a9396648).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

[gatorsmile]

GitHub user gatorsmile opened a pull request:

https://github.com/apache/spark/pull/12169

[SPARK-14396] [SQL] Throw Exceptions for DDLs of Partitioned Views

 What changes were proposed in this pull request?

Because the concept of partitioning is associated with physical tables, we 
disable all the supports of partitioned views, which are defined in the 
following three commands in [Hive DDL 
Manual](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/AlterView):
```
ALTER VIEW view DROP [IF EXISTS] PARTITION spec1[, PARTITION spec2, ...];

ALTER VIEW view ADD [IF NOT EXISTS] PARTITION spec;

CREATE VIEW [IF NOT EXISTS] [db_name.]view_name [(column_name [COMMENT 
column_comment], ...) ]
  [COMMENT view_comment]
  [TBLPROPERTIES (property_name = property_value, ...)]
  AS SELECT ...;
```
 
An exception is thrown when users issue any of these three DDL commands.

 How was this patch tested?
Added test cases for parsing create view and changed the existing test 
cases to verify if the exceptions are thrown.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gatorsmile/spark viewPartition

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12169


commit 181c8173b8ea4aba631e9330d8450f47a9396648
Author: gatorsmile 
Date:   2016-04-05T05:34:49Z

throw exceptions for  DDLs of partitioned views




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org