[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-115561728 Ok, I will close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen closed the pull request at: https://github.com/apache/spark/pull/6515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114744788 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114745145 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114744960 cc @JoshRosen will this substantially increase build time due to maven? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114745108 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114792514 [Test build #35650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35650/console) for PR 6515 at commit [`6b4d6bd`](https://github.com/apache/spark/commit/6b4d6bd6dea66a45ac2817fc711dd8d761439e22). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114792548 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114745333 [Test build #35650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35650/consoleFull) for PR 6515 at commit [`6b4d6bd`](https://github.com/apache/spark/commit/6b4d6bd6dea66a45ac2817fc711dd8d761439e22). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-115018376 I've thought about this a bit and I'm not sure that ErrorProne offers us a huge win unless it's run as part of every build. I think the advantage of ErrorProne over FindBugs is that it's fast, returns few false-positives, and integrates into everyday builds. I think that we lose a lot of these advantages if we guard its use behind a separate Jenkins trigger phrase or build profile / flag; if we have to manually trigger it, then I feel that we might as well run FindBugs instead. I don't think that we can necessarily justify adding 10 minutes of build time to the pull request builder in order to run these tests, since the cost/benefit ratio there seems low. _However_, I'd be interested to see if there's a way to compile _just_ the Java sources with this, but that might not be possible given the Scala - Java interdependencies in our code base. In light of all of this, I think that we might want to put this on hold for now and revisit later once we have more flexible Jenkins triggering logic or the ability to run the pull request builder tests using Maven. Thanks for working on this and sorry that we're probably not going to be able to pull it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114974061 The last test seemed to take only `152m`, which is around the average. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114956452 Run this check would take about ten minutes on my laptop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114630902 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114631306 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114631412 [Test build #35584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35584/consoleFull) for PR 6515 at commit [`d5feed2`](https://github.com/apache/spark/commit/d5feed242fb43bb4bea05852c8e7cbce563941f6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114636320 @yijieshen note that this doesn't merge cleanly with master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114631322 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114718441 @andrewor14, thanks for retesting this. I would merge this ASAP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114416807 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114722967 @andrewor14, the latest commit merge cleanly with master now, mind reviewing it as well as triggering the test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-114666597 [Test build #35584 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35584/console) for PR 6515 at commit [`d5feed2`](https://github.com/apache/spark/commit/d5feed242fb43bb4bea05852c8e7cbce563941f6). * This patch **passes all tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-11434 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-112411907 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-111429204 Also note the `[UnnecessaryStaticImport] Using static imports for types is unnecessary` conflict with a scaladoc walk around: [SPARK-7726](https://github.com/apache/spark/pull/6260/files) (`UnnecessaryStaticImport ` is also a warning by default.) /Users/yijie/code/spark/network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/OpenBlocks.java:28: error: [UnnecessaryStaticImport] Using static imports for types is unnecessary import static org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type; ^ (see http://errorprone.info/bugpattern/UnnecessaryStaticImport) Did you mean 'import org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;'? /Users/yijie/code/spark/network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/StreamHandle.java:24: error: [UnnecessaryStaticImport] Using static imports for types is unnecessary import static org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type; ^ (see http://errorprone.info/bugpattern/UnnecessaryStaticImport) Did you mean 'import org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;'? /Users/yijie/code/spark/network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/RegisterExecutor.java:26: error: [UnnecessaryStaticImport] Using static imports for types is unnecessary import static org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type; ^ (see http://errorprone.info/bugpattern/UnnecessaryStaticImport) Did you mean 'import org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;'? /Users/yijie/code/spark/network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/UploadBlock.java:28: error: [UnnecessaryStaticImport] Using static imports for types is unnecessary import static org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type; ^ (see http://errorprone.info/bugpattern/UnnecessaryStaticImport) Did you mean 'import org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type;'? 4 errors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-111434507
/Users/yijie/code/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/BaseRow.java:143:
error: [TypeParameterUnusedInFormals] Declaring a type parameter that is only
used in the return type is a misuse of generics: operations on the type
parameter are unchecked, it hides unsafe casts at invocations of the method,
and it interacts badly with method overload resolution
public T T getAs(int i) {
^
(see http://errorprone.info/bugpattern/TypeParameterUnusedInFormals)
Did you mean 'public Object getAs(int i) {'?
/Users/yijie/code/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/BaseRow.java:148:
error: [TypeParameterUnusedInFormals] Declaring a type parameter that is only
used in the return type is a misuse of generics: operations on the type
parameter are unchecked, it hides unsafe casts at invocations of the method,
and it interacts badly with method overload resolution
public T T getAs(String fieldName) {
^
(see http://errorprone.info/bugpattern/TypeParameterUnusedInFormals)
Did you mean 'public Object getAs(String fieldName) {'?
2 errors
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-111426953
Not sure if it was too strict to level up `EqualsHashCode: Classes that
override equals should also override hashCode.` from warning to error.
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/ChunkFetchSuccess.java:65:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/RpcResponse.java:54:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/RpcRequest.java:63:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/ChunkFetchRequest.java:52:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/RpcFailure.java:54:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
/Users/yijie/code/spark/network/common/src/main/java/org/apache/spark/network/protocol/ChunkFetchFailure.java:56:
error: [EqualsHashCode] Classes that override equals should also override
hashCode.
public boolean equals(Object other) {
^
(see http://errorprone.info/bugpattern/EqualsHashCode)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-111434925 Perhaps it's time to reconsider whether we should level up all the `warnings` to `error` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-109544645 @rxin, can you help me to review the latest commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-109255206 @JoshRosen , I've made error prone check inside `dev/lint-java` and also put it into `dev/run-tests`. Since error prone can only be hooked into `compile` and `test-compile` goals in Maven's lifecycle, we need to run at least `mvn test-compile` to ensure it checks both src/main/java and src/test/java, so it may take more times than other `lint`, is this OK? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108936871 @aarondav, I've moved the callback.wait into `while (callback0.success == null callback0.failure == null) ` loops since it seems like just waiting for either success or failure, and in this way we could guard against spurious wakeups. Please check the commit above to see if I made mistakes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108938615 @vanzin , it seems no variable to check [here](https://github.com/yijieshen/spark/blob/errorprone/network/common/src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java#L278-278), so I just suppress `WaitNotInLoop` Error, am I right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108967544 @yijieshen sounds right; it's a test anyway, so adding a variable to check there sounds like overkill. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108629717 [Test build #34124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34124/consoleFull) for PR 6515 at commit [`db95a36`](https://github.com/apache/spark/commit/db95a363fb95b5ca0dcbaf27b1bf27763131962e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108628832 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108628815 @harishreedharan @vanzin @srowen maybe the change from #6600 will fail here :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108628806 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108652391 [Test build #34124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34124/consoleFull) for PR 6515 at commit [`db95a36`](https://github.com/apache/spark/commit/db95a363fb95b5ca0dcbaf27b1bf27763131962e). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108652418 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-108628724 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107870235 @rxin, just turned on all the mature checkers from warning into error in the latest commit, implementing `lint` now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107279699 Thanks @yijieshen. Just tried this locally and worked. Can you change the report level from warning to error, and fix the few instances of warnings? The reason is I don't think it'd be very useful to run this at warning level, since there are so many warning messages that people will just ignore. The only way to make this useful is to fail the build if there are violations. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107280681 Since this is now guarded behind a special Maven profile, we should also make sure to update the Jenkins build to run with this enabled. AFAIK the Jenkins Maven builds don't actually run through run-tests-jenkins so we'll have to log in and make the changes via the Jenkins admin panel. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107288251 @JoshRosen, since the profile is tightly coupled with `compile` `test-compile` goals in maven, is it OK to run `mvn package` in `bin/run-tests`? e.g. in `lint-java`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107287257 @rxin, in error prone, some checks are `on` by default, and others are experimental and `off` by default. Each of the checks is considered with a `Severity level`, some are `ERROR` such as DEADException, mean while others are considered `WARNING`. So you mean we could make all the `on` `WARNING` checks as `on` `ERROR` first, and fix them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107074328 Jenkins, retest this please. On Saturday, May 30, 2015, Yijie Shen notificati...@github.com wrote: How can I ask Jenkins to retest it? â Reply to this email directly or view it on GitHub https://github.com/apache/spark/pull/6515#issuecomment-107054378. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107085777 [Test build #33815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33815/consoleFull) for PR 6515 at commit [`2d58b76`](https://github.com/apache/spark/commit/2d58b76e8e08fd490339da7ed9d057321949390e). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107085786 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107077638 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107077751 [Test build #33815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33815/consoleFull) for PR 6515 at commit [`2d58b76`](https://github.com/apache/spark/commit/2d58b76e8e08fd490339da7ed9d057321949390e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107077624 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107087027 @yijieshen how do I run this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107077167 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106993985 Test more Error bug patterns manually, work as expected. However, after an error report, if no `mvn clean` called before next `mvn package`, and not changing the buggy code, `maven-compiler-plugin` would just think all classes are up to date and not report the error again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106994629 Not that sure how lint-java works. If I understand correctly, in lint-java, we should run error prone separately like what lint-scala does? If so, seems not possible this moment, since error prone can only tightly coupled with maven's `compile` and `test-compile`, refer to issue: https://github.com/google/error-prone/issues/337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106994189 Got it - as long as it is fine on Jenkins, I think it is OK. We can rely on Jenkins to do this anyway. One thing to add is lint-java file in /dev folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106994699 Ah ok. So the only way to run this is to use mvn compile? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107113240 @rxin, just add -Pep-tests when running mvn package I've turned on warnings in the second commit since it's optional and I assume run this deliberately would love to see all the warnings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106996096 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106997413 [Test build #33802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33802/consoleFull) for PR 6515 at commit [`46ef7e5`](https://github.com/apache/spark/commit/46ef7e599c930b7fd5cc0881f99f254ab90cf722). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107010067 [Test build #33802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33802/consoleFull) for PR 6515 at commit [`46ef7e5`](https://github.com/apache/spark/commit/46ef7e599c930b7fd5cc0881f99f254ab90cf722). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107010071 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106994994 I think so, would keep an eye on this and create lint-java if possible later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106997021 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106997001 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/6515#discussion_r31380059 --- Diff: pom.xml --- @@ -1226,7 +1226,16 @@ encodingUTF-8/encoding maxmem1024m/maxmem forktrue/fork +compilerIdjavac-with-errorprone/compilerId --- End diff -- Can this be put in a profile? I'm slightly concerned about pushing the entire build through a different compiler just for this tool. It's easy to make this selectable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on a diff in the pull request: https://github.com/apache/spark/pull/6515#discussion_r31381670 --- Diff: pom.xml --- @@ -1226,7 +1226,16 @@ encodingUTF-8/encoding maxmem1024m/maxmem forktrue/fork +compilerIdjavac-with-errorprone/compilerId --- End diff -- move it into a profile and turned on the compiler warnings since the profile itself is optional. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-107054378 How can I ask Jenkins to retest it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106990571 Jenkins, ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
GitHub user yijieshen opened a pull request: https://github.com/apache/spark/pull/6515 [SPARK-7938][BUILD]Use Google ErrorProne during Maven build of Spark [Error Prone](http://errorprone.info) augment the compilerâs type analysis and hooks into standard build, aiming at detecting Java code mistakes immediately after they are made. This PR hooks ErrorProne into maven-compiler-plugin to enable code analysis at maven's compile test-compile phases. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yijieshen/spark errorprone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/6515.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6515 commit 46ef7e599c930b7fd5cc0881f99f254ab90cf722 Author: Yijie Shen henry.yijies...@gmail.com Date: 2015-05-30T04:49:13Z Use Google ErrorProne into Maven build of Spark --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106990363 Thanks, @yijieshen. Have you tried running this locally and see what was produced? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106991739 Thanks. Can you manually inject a bug into some Java code to see if it reports that correctly? If those are all the warnings, I'd just update the code to remove the warnings, and then turn warnings on as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106990693 @rxin, I've tried locally, when compiler's warning are suppressed by default, nothing error occurs. When I turned on the warnings, it only warns on spurious wakeups of a test class, I would paste them here later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106992110 @rxin, I have insert [DeadException](http://errorprone.info/bugpattern/DeadException) `new Exception()`which is considered as ERROR in error prone, it reports correctly. Will test all the ERROR bug patterns manually to make sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106992204 No need to test all of them. As long as one works ... :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106990453 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7938][BUILD]Use Google ErrorProne durin...
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6515#issuecomment-106990886 @rxin: /Users/yijie/code/spark/network/common/src/test/java/org/apache/spark/network/RequestTimeoutIntegrationSuite.java:114: warning: [WaitNotInLoop] Object.wait() should always be called in a loop callback0.wait(FOREVER); ^ (see http://errorprone.info/bugpattern/WaitNotInLoop) /Users/yijie/code/spark/network/common/src/test/java/org/apache/spark/network/RequestTimeoutIntegrationSuite.java:122: warning: [WaitNotInLoop] Object.wait() should always be called in a loop callback1.wait(4 * 1000); ^ (see http://errorprone.info/bugpattern/WaitNotInLoop) /Users/yijie/code/spark/network/common/src/test/java/org/apache/spark/network/RequestTimeoutIntegrationSuite.java:162: warning: [WaitNotInLoop] Object.wait() should always be called in a loop callback0.wait(FOREVER); ^ (see http://errorprone.info/bugpattern/WaitNotInLoop) /Users/yijie/code/spark/network/common/src/test/java/org/apache/spark/network/RequestTimeoutIntegrationSuite.java:174: warning: [WaitNotInLoop] Object.wait() should always be called in a loop callback1.wait(FOREVER); ^ (see http://errorprone.info/bugpattern/WaitNotInLoop) /Users/yijie/code/spark/network/common/src/test/java/org/apache/spark/network/RequestTimeoutIntegrationSuite.java:222: warning: [WaitNotInLoop] Object.wait() should always be called in a loop callback0.wait(2 * 1000); ^ (see http://errorprone.info/bugpattern/WaitNotInLoop) /Users/yijie/code/spark/network/common/src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java:277: warning: [WaitNotInLoop] Object.wait() should always be called in a loop lock.wait(10 * 1000); ^ (see http://errorprone.info/bugpattern/WaitNotInLoop) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
