Re: [ros-dev] Setup on an extended partition
Am 30.04.2015 um 19:51 schrieb stack exchange: I implemented this functionallity, so the installer can now create one or more logical partitions and can also install it there. There are two issues though: 1. When multiple logical drives exist and they are deleted the installer crashes. This is IMO just a minor problem, because you can still install, yu just have to think ahead of what you want. I will look into this later. 2. This is IMO the more important issue. I verified with a GParted ISO the partitions and they are corrupted. At first I thought I did something wrong, but after working on this for several weeks now I'm not so convinced anymore. When I dump the partition table with my code, it looks exactly as the dump that it would generate when I create the same layout with gparted, so it should work. So my assumption is that the implementation in NtDeviceIoControlFile(IOCTL_DISK_SET_DRIVE_LAYOUT) may be the cause. On the other hand, when I create only primary partitions (which the existing code can do) then gparted doesn't report any errors, so it may only be the case when dealing with logical partitions. In my JIRA issue (https://jira.reactos.org/browse/CORE-9641) I reported four problems with this patch. Two of them are now fixed with the patch that I attached. This is the issue that setup crashed when deleting logical partitions, and the other one was that you couldn't create a logical partition by pressing ENTER, you had to use the 'L' key and create it manually first. In my opinion the problems of this issue are resolved with that. The other two problems (can't boot from a logical partition and corrupted partition layout when using logical partitions) are seperate items and I would rather create a seperate issue for each of them. From my side I would say that this issue can be closed (after accepting the patch and testing it). mfg, Gerhard ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Setup on an extended partition
Am 01.05.2015 um 21:02 schrieb Minas Abrahamyan: Does your code only install on the extended partition? Haven't you looked at that kernel part (ntoskrnl) that loads the OS, or maybe did something there? Yes, it installs on the logical partition now. It can't boot though, because it crashes to the debugger. I suppose that is because of the kernel issue involved, but I hadn't looked at that yet. I wanted to work on the issues that I described, before I take a look at the kernel code. I hate to have code with bugs, and the partitions should be correct when inspecting with gparted, so this is what I wanted to look at next. I mounted the volume in linux though and the files look ok. ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Setup on an extended partition
Hi, Thanks for working on that, it was long time anybody is touching here (in spite of it is very important part, as I described); Please share your work in form of patch in Jira, as attachment, and I will look at it; You are right in that there is a problem with ROS organizing the patch reception and/ or adoption. And a question: Does your code only install on the extended partition? Haven't you looked at that kernel part (ntoskrnl) that loads the OS, or maybe did something there? Regards, -M On Thu, Apr 30, 2015 at 9:51 PM, stack exchange sparh...@gmx.at wrote: Am 05.04.2015 um 10:36 schrieb Minas Abrahamyan: 2 This feature is extreamely useful for any Windows user-- especially for ones with busy all primary partitions: 2 backup partitions, one C: and one just anything other, Linux or OsX - and you very need extended partition to keep Reactos 3 This feature is extreamely needed for just any real-life (==real hardware) Reactos tester and developer: see p.2 Plus starting from extended partition will allow to have multiple copies of reactos installations, which is bread and water for testers. The fact this feature is absent just shows where real-life usage by testers of Ros is: just nowhere. I implemented this functionallity, so the installer can now create one or more logical partitions and can also install it there. There are two issues though: 1. When multiple logical drives exist and they are deleted the installer crashes. This is IMO just a minor problem, because you can still install, yu just have to think ahead of what you want. I will look into this later. 2. This is IMO the more important issue. I verified with a GParted ISO the partitions and they are corrupted. At first I thought I did something wrong, but after working on this for several weeks now I'm not so convinced anymore. When I dump the partition table with my code, it looks exactly as the dump that it would generate when I create the same layout with gparted, so it should work. So my assumption is that the implementation in NtDeviceIoControlFile(IOCTL_DISK_SET_DRIVE_LAYOUT) may be the cause. On the other hand, when I create only primary partitions (which the existing code can do) then gparted doesn't report any errors, so it may only be the case when dealing with logical partitions. The question is now, should I upload the current code as a patch as it is right now, with these known issues, or should I try to fix it completely before I upload it? If I should upload it, I wonder how long it usually takes until it is commited to the repository, because I submitted a patch in this areay a month ago, which still has not made it to SVN. Or when/how do you get write access to SVN? ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Setup on an extended partition
Am 05.04.2015 um 10:36 schrieb Minas Abrahamyan: 2 This feature is extreamely useful for any Windows user-- especially for ones with busy all primary partitions: 2 backup partitions, one C: and one just anything other, Linux or OsX - and you very need extended partition to keep Reactos 3 This feature is extreamely needed for just any real-life (==real hardware) Reactos tester and developer: see p.2 Plus starting from extended partition will allow to have multiple copies of reactos installations, which is bread and water for testers. The fact this feature is absent just shows where real-life usage by testers of Ros is: just nowhere. I implemented this functionallity, so the installer can now create one or more logical partitions and can also install it there. There are two issues though: 1. When multiple logical drives exist and they are deleted the installer crashes. This is IMO just a minor problem, because you can still install, yu just have to think ahead of what you want. I will look into this later. 2. This is IMO the more important issue. I verified with a GParted ISO the partitions and they are corrupted. At first I thought I did something wrong, but after working on this for several weeks now I'm not so convinced anymore. When I dump the partition table with my code, it looks exactly as the dump that it would generate when I create the same layout with gparted, so it should work. So my assumption is that the implementation in NtDeviceIoControlFile(IOCTL_DISK_SET_DRIVE_LAYOUT) may be the cause. On the other hand, when I create only primary partitions (which the existing code can do) then gparted doesn't report any errors, so it may only be the case when dealing with logical partitions. The question is now, should I upload the current code as a patch as it is right now, with these known issues, or should I try to fix it completely before I upload it? If I should upload it, I wonder how long it usually takes until it is commited to the repository, because I submitted a patch in this areay a month ago, which still has not made it to SVN. Or when/how do you get write access to SVN? ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Setup on an extended partition
Upload the patch to JIRA, create a new issue entry if none exists for this. It's the preferred way to contribute to the project. People only get write access after they have proved themselves with writing patches, and the team trusts them to have some minimal quality and behaviour standards. ;P We have few knowledgeable developers so the process sometimes takes a bit of time. If we missed a patch, feel free to join IRC and slap some of us there. On 30 April 2015 at 19:51, stack exchange sparh...@gmx.at wrote: Am 05.04.2015 um 10:36 schrieb Minas Abrahamyan: 2 This feature is extreamely useful for any Windows user-- especially for ones with busy all primary partitions: 2 backup partitions, one C: and one just anything other, Linux or OsX - and you very need extended partition to keep Reactos 3 This feature is extreamely needed for just any real-life (==real hardware) Reactos tester and developer: see p.2 Plus starting from extended partition will allow to have multiple copies of reactos installations, which is bread and water for testers. The fact this feature is absent just shows where real-life usage by testers of Ros is: just nowhere. I implemented this functionallity, so the installer can now create one or more logical partitions and can also install it there. There are two issues though: 1. When multiple logical drives exist and they are deleted the installer crashes. This is IMO just a minor problem, because you can still install, yu just have to think ahead of what you want. I will look into this later. 2. This is IMO the more important issue. I verified with a GParted ISO the partitions and they are corrupted. At first I thought I did something wrong, but after working on this for several weeks now I'm not so convinced anymore. When I dump the partition table with my code, it looks exactly as the dump that it would generate when I create the same layout with gparted, so it should work. So my assumption is that the implementation in NtDeviceIoControlFile(IOCTL_DISK_SET_DRIVE_LAYOUT) may be the cause. On the other hand, when I create only primary partitions (which the existing code can do) then gparted doesn't report any errors, so it may only be the case when dealing with logical partitions. The question is now, should I upload the current code as a patch as it is right now, with these known issues, or should I try to fix it completely before I upload it? If I should upload it, I wonder how long it usually takes until it is commited to the repository, because I submitted a patch in this areay a month ago, which still has not made it to SVN. Or when/how do you get write access to SVN? ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Setup on an extended partition
On 06-04-2015 05:55, Thomas Mueller wrote: Then I would need a boot loader that would trick FreeDOS and ReactOS, whichever was being booted, that its partition was the first on the disk, even if it was the second. Hi, I think that that tricking thing only works as long as the OS is using an external API to access the disk. When the OS uses real drivers, no one can trick it. Unless it is the PCI or the physical drive itself that supports the tricking. JJ ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Setup on an extended partition
from Minas Abrahamyan: This misfunctionality has 2 pieces: Reactos unable to start kernel from extended partition, and the installer inability to handle extended partitions 1 MS NT+ supports installing onto the extended partition for ages, including, yes, Windows 7 So this is requirement if only speaking from formal point of view 2 This feature is extreamely useful for any Windows user-- especially for ones with busy all primary partitions: 2 backup partitions, one C: and one just anything other, Linux or OsX - and you very need extended partition to keep Reactos 3 This feature is extreamely needed for just any real-life (==real hardware) Reactos tester and developer: see p.2 Plus starting from extended partition will allow to have multiple copies of reactos installations, which is bread and water for testers. The fact this feature is absent just shows where real-life usage by testers of Ros is: just nowhere. Having hard disks partitioned GPT prevents me from even testing ReactOS. But if ReactOS could be installed to a GPT partition, there is the risk that it could run awry and mess the disk including other OS installations. It would be good if ReactOS could be installed to USB stick, better still if ReactOS could be built and installed to a USB stick straight from the build system. FreeBSD and NetBSD have this capability. There might be a lower risk to the rest of the system from ReactOS on a USB stick than on a hard disk, especially if ReactOS has immature GPT support. Conceivably I could order a low-price refurbished small SATA hard disk, install in a Sabrent USB 2.0 and eSATA enclosure, but using eSATA, and use that for ReactOS, FreeDOS and possibly OpenBSD too. Then I would need a boot loader that would trick FreeDOS and ReactOS, whichever was being booted, that its partition was the first on the disk, even if it was the second. Tom ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
