Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
Closed #2691. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#event-10753425349 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
Superseded by #2733. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#issuecomment-1777132805 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
@dmnks commented on this pull request. > @@ -647,7 +647,7 @@ AT_SETUP([xml format]) AT_KEYWORDS([query]) RPMTEST_CHECK([ RPMDB_INIT -runroot rpm -qp --xml data/RPMS/hello-2.0-1.x86_64.rpm +runroot rpm -qp --xml /data/RPMS/hello-2.0-1.x86_64.rpm Fix for the above: https://github.com/rpm-software-management/rpm/pull/2695 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#discussion_r1345784102 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
@dmnks commented on this pull request. > @@ -647,7 +647,7 @@ AT_SETUP([xml format]) AT_KEYWORDS([query]) RPMTEST_CHECK([ RPMDB_INIT -runroot rpm -qp --xml data/RPMS/hello-2.0-1.x86_64.rpm +runroot rpm -qp --xml /data/RPMS/hello-2.0-1.x86_64.rpm Indeed, this is another example of something that could've gone in separately. In fact, I'll start submitting these little changes now, before this PR is undrafted. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#discussion_r1345402104 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
@pmatilai commented on this pull request. > @@ -647,7 +647,7 @@ AT_SETUP([xml format]) AT_KEYWORDS([query]) RPMTEST_CHECK([ RPMDB_INIT -runroot rpm -qp --xml data/RPMS/hello-2.0-1.x86_64.rpm +runroot rpm -qp --xml /data/RPMS/hello-2.0-1.x86_64.rpm These relative -> absolute path changes look like something that could be applied regardless of this change. Most path usage in the tests is absolute anyhow, these mostly just look out of the place now, but could be remnants from the days where we actually ran some stuff outside the test-root. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#pullrequestreview-1656881464 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
There's also at least commit a25d881f287e67568c15a87c9fc9a2c4acc0650e embedded in here. So yep, please rebase before a closer look. Rebasing before submitting a PR is usually a good idea. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#issuecomment-1746323721 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
@pmatilai commented on this pull request. > @@ -1,6 +1,4 @@ -# Use our top-level targets as an ordering clue to cmake: the project -# needs to be built before we can populate anything... -get_property(TOP_TARGETS DIRECTORY .. PROPERTY BUILDSYSTEM_TARGETS) +set(RPM_TARGETS librpm librpmio librpmbuild librpmsign) It's also a good example of bad (variable) naming in the original version: being top-level had nothing to do with it, it was the tools we were after. Had the variable been called "TOOLPROGS" or such from the start, it probably would've been far more obvious as to why it's not working now. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#discussion_r1345340162 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
@pmatilai commented on this pull request. > @@ -1,6 +1,4 @@ -# Use our top-level targets as an ordering clue to cmake: the project -# needs to be built before we can populate anything... -get_property(TOP_TARGETS DIRECTORY .. PROPERTY BUILDSYSTEM_TARGETS) +set(RPM_TARGETS librpm librpmio librpmbuild librpmsign) Submitted as #2692 now. And whenever you run into mysteries like that, just ask :sweat_smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#discussion_r1345337173 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
@dmnks commented on this pull request. > @@ -1,6 +1,4 @@ -# Use our top-level targets as an ordering clue to cmake: the project -# needs to be built before we can populate anything... -get_property(TOP_TARGETS DIRECTORY .. PROPERTY BUILDSYSTEM_TARGETS) +set(RPM_TARGETS librpm librpmio librpmbuild librpmsign) Oh, this explains that little mystery of "why on earth doesn't this TOP_TARGETS work for me as expected" :smile: I actually settled on that having been broken from the start and just patched it quickly this way, with the thought of investigating a bit more afterwards. And yes, this would've gone to a separate commit in this PR as well :smile: So yup, feel free to fix, I'll then just rebase. Thanks :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#discussion_r1345326049 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add OCI mktree backend (PR #2691)
@pmatilai commented on this pull request. > @@ -1,6 +1,4 @@ -# Use our top-level targets as an ordering clue to cmake: the project -# needs to be built before we can populate anything... -get_property(TOP_TARGETS DIRECTORY .. PROPERTY BUILDSYSTEM_TARGETS) +set(RPM_TARGETS librpm librpmio librpmbuild librpmsign) After a brief wtf moment, I see that I broke the top level target fetch in commit 86d99a1d20bbebfeb4427c99b1bb1053029c3317. Oof. But this is a fine example of what should've gone into a separate PR as soon as noticed because this has nothing to do with the change in *this* PR. I'll fix since it's me who broke it in the first place. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2691#pullrequestreview-1656827186 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
