Re: [sage-combinat-devel] unable to install (fixed)
Dear Justin, Travis, Andrew, On Sun, Oct 14, 2012 at 07:42:46AM -0700, Justin Kerney wrote: > I've been unable to get combinat to install. I installed sage-5.3-OSX-64bit- > 10.6, and then tried to install combinat by running: > > sage -combinat install ... > errors during apply, please fix and refresh partition_options-ts.patch > Abort Thanks Justin for the detailed report! This should be fixed now (tested on 5.3 and 5.4.rc1). Cheers, Nicolas Travis: your patch needed a trivial rebase which I allowed myself to do and push. Andrew: I had to guard out your patch tableaux-combinatorics-am.patch which needs a less trivial rebase. -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] unable to install (fixed)
Thanks Nicolas! Best, Travis On Sunday, October 14, 2012 1:43:53 PM UTC-7, Nicolas M. Thiery wrote: > > Dear Justin, Travis, Andrew, > > On Sun, Oct 14, 2012 at 07:42:46AM -0700, Justin Kerney wrote: > > I've been unable to get combinat to install. I installed > sage-5.3-OSX-64bit- > > 10.6,�and then tried to install combinat by running: > > � > > sage -combinat install > ... > > errors during apply, please fix and refresh partition_options-ts.patch > > Abort > > Thanks Justin for the detailed report! This should be fixed now > (tested on 5.3 and 5.4.rc1). > > Cheers, > Nicolas > > Travis: your patch needed a trivial rebase which I allowed myself to > do and push. > > Andrew: I had to guard out your patch tableaux-combinatorics-am.patch > which needs a less trivial rebase. > > -- > Nicolas M. Thi�ry "Isil" > > http://Nicolas.Thiery.name/ > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/CWaK7Ns_1GEJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] unable to install (fixed)
Hi Travis, The conflicts in my patch were caused by inconsistent uses of _repr_ and __repr__ between our patches in partition.py. My understanding from http://www.sagemath.org/doc/developer/coding_in_python.html is that in sage we should always use _repr_. Does everyone agree? If so then I could fix this up in #13072 which wold no doubt propagate conflicts further down the queue in your patches and in my patches. Alternatively, you cold just change it in your patch? As our patches are both touching partition.py it's probably a good idea to check that my patch still applies before pushing. Perhaps I should also open a ticket describing my tableau combinatorics patch and move it up this patch is finished (although I should go over the documentation...), even if the reason for writing this patch is not yet in the queue... Cheers, Andrew -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/R8D4CFA6TsEJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] unable to install (fixed)
On Sun, Oct 14, 2012 at 05:46:17PM -0700, Andrew Mathas wrote: > The conflicts in my patch were caused by inconsistent uses of _repr_ and > __repr__ between our patches in partition.py. > > My understanding from http://www.sagemath.org/doc/developer/ > coding_in_python.html is that in sage we should always use _repr_. Does > everyone agree? +1 Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] unable to install (fixed)
Thank you! It installs fine now. On Monday, October 15, 2012 7:43:53 AM UTC+11, Nicolas M. Thiery wrote: > > Dear Justin, Travis, Andrew, > > On Sun, Oct 14, 2012 at 07:42:46AM -0700, Justin Kerney wrote: > > I've been unable to get combinat to install. I installed > sage-5.3-OSX-64bit- > > 10.6,�and then tried to install combinat by running: > > � > > sage -combinat install > ... > > errors during apply, please fix and refresh partition_options-ts.patch > > Abort > > Thanks Justin for the detailed report! This should be fixed now > (tested on 5.3 and 5.4.rc1). > > Cheers, > Nicolas > > Travis: your patch needed a trivial rebase which I allowed myself to > do and push. > > Andrew: I had to guard out your patch tableaux-combinatorics-am.patch > which needs a less trivial rebase. > > -- > Nicolas M. Thi�ry "Isil" > > http://Nicolas.Thiery.name/ > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/fRRnH5M2Wu4J. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] unable to install (fixed)
Hey Andrew, I will just change it in my patch since mine is (will be) making a fair amount of change to partition.py. Also, I'm operating under the assumption that #13072 and #13074 will be merged long before mine is done. I also believe all of your patches are ahead of partition_options-ts.patch, so the conflicts are my responsibility to fix. Nicolas, a quick question, I'm going to create a new ticket for partition_options-ts.patch, should I have #5439 list that as a dependency or just make a reference to it? Best, Travis On Sunday, October 14, 2012 5:46:17 PM UTC-7, Andrew Mathas wrote: > > Hi Travis, > > The conflicts in my patch were caused by inconsistent uses of _repr_ and > __repr__ between our patches in partition.py. > > My understanding from > http://www.sagemath.org/doc/developer/coding_in_python.html is that in > sage we should always use _repr_. Does everyone agree? If so then I could > fix this up in #13072 which wold no doubt propagate conflicts further down > the queue in your patches and in my patches. Alternatively, you cold just > change it in your patch? > > As our patches are both touching partition.py it's probably a good idea to > check that my patch still applies before pushing. Perhaps I should also > open a ticket describing my tableau combinatorics patch and move it up this > patch is finished (although I should go over the documentation...), even if > the reason for writing this patch is not yet in the queue... > > Cheers, > Andrew > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/l-_TLoNqbP4J. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] unable to install (fixed)
Hi Travis! On Mon, Oct 15, 2012 at 02:37:10PM -0700, Travis Scrimshaw wrote: > Nicolas, a quick question, I'm going to create a new ticket for > partition_options-ts.patch, should I have #5439 list that as a dependency or > just make a reference to it? Just make a list of the related patches in the description of #5439. By the way, you may want to dub this ticket a "task" rather than a "defect". Cheers, Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
