[sage-devel] Re: drop python2 compatibility in 9.1 ?

2020-01-14 Thread Matthias Koeppe 
On Tuesday, January 14, 2020 at 12:01:42 PM UTC-5, Frédéric Chapoton wrote:
>
> So here is my proposal.
>
> * Starting from now, we allow ourselves to move on, using 9.1 betas and 
> further releases for external python3 updates, including switch to 
> ipython7, which seems to me the most urgent matter. But we also do not 
> introduce python3-only code in our own code base if we can avoid it.
>
> * Concerning semantic versioning, I would advocate to use 10.0 as the 
> first release where all compatibility code will be removed, hence pure py3. 
> This may take some time, given the sparse work force. Once done, we allow 
> ourself to use python3-only syntax in our own codebase, such as "yield 
> from".
>
> Therefore, we can use 9.1, 9.2 and so on until somebody™ does the job of 
> cleaning up sagemath codebase from remains of py2-only code.
>
> I have tried to make a balanced and reasonable proposal. Applause or 
> scream at your will.
>

I agree with all of this.  

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/44fe2a96-99b2-4ebb-8128-4ddae3e76f2a%40googlegroups.com.

Re: [sage-devel] Re: drop python2 compatibility in 9.1 ?

2020-01-14 Thread Matthias Koeppe 
On Tuesday, January 14, 2020 at 8:01:18 PM UTC-5, Michael Orlitzky wrote:
>
>
>   1. Branch off the 9.0 release 
>   2. Drop compatibility in 9.1 
>   3. Proceed as normal 
>   4. If there are any major bugs found in 9.1, backport the fix to 
>  the 9.0 branch, and release a 9.0.1 that supports python-2.x. 
>
> Mathematical bug fixes that merge clean and pass the tests could also 
> make the cut, but ideally step (4) would require little work. This would 
> buy users a few more months of python2 compatibility, and lets the rest 
> of us move on. 
>

I agree that there needs to be a 9.0 maintenance branch – if only to be the 
designated upstream for distributors that want to keep maintaining a py2 
version of sage. 
 

> The main downside is that this relies solely on the release manager to 
> merge bugfix tickets twice, into both release branches. So if he thinks 
> this is a waste of time (understandable), then it's a non-starter. 
>

The maintenance branch could also be maintained by another developer. 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/c232c89b-b45a-4465-a9e9-03ca8a240c6d%40googlegroups.com.

Re: [sage-devel] Re: drop python2 compatibility in 9.1 ?

2020-01-14 Thread Michael Orlitzky 
On 1/14/20 12:01 PM, Frédéric Chapoton wrote:
> 
> [A] It seems to me that the conclusion of the vote is rather clear, and
> that we should not feel obliged to make 9.1 compilable with python2.
> 

Since I'm not on that list yet, one thing is for sure: there are going
to be two consecutive versions of sage, one where python-2.x works, and
one where it doesn't. Users won't care too much which versions those are
unless there's a feature or bugfix that they need in the new version --
they can just use the old one.

Most projects solve this with multiple release branches. When you break
backwards-compatibility in a major way, you keep the previous version
(before the break) in a separate branch, and backport critical fixes to
it for a limited time. It's not how the sage release process works, but
I don't see why we couldn't do it this once, to keep everyone happy:

  1. Branch off the 9.0 release
  2. Drop compatibility in 9.1
  3. Proceed as normal
  4. If there are any major bugs found in 9.1, backport the fix to
 the 9.0 branch, and release a 9.0.1 that supports python-2.x.

Mathematical bug fixes that merge clean and pass the tests could also
make the cut, but ideally step (4) would require little work. This would
buy users a few more months of python2 compatibility, and lets the rest
of us move on.

The main downside is that this relies solely on the release manager to
merge bugfix tickets twice, into both release branches. So if he thinks
this is a waste of time (understandable), then it's a non-starter.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/ab573d83-ab79-4bdc-1e23-36f411e26a44%40orlitzky.com.

Re: [sage-devel] Protocol for when you see a ticket describing a bug that doesn't seem to exist in the current version

2020-01-14 Thread Nils Bruin 
On Tuesday, January 14, 2020 at 10:08:36 AM UTC-8, Dima Pasechnik wrote:
>
> set the milestone to duplicate/invalid/wontfix 
> and give it positive review, with an explanation in a comment. 
>

Depending how striking the claimed bug is, it might be inspiration for a 
good doctest, in which case the ticket can be used to actually "fix" the 
documentation. 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/bc396fe7-27f0-4e52-ad9c-c2749e972247%40googlegroups.com.

[sage-devel] Re: drop python2 compatibility in 9.1 ?

2020-01-14 Thread Nils Bruin 
On Tuesday, January 14, 2020 at 9:01:42 AM UTC-8, Frédéric Chapoton wrote:
>
> So here is my proposal.
>
> * Starting from now, we allow ourselves to move on, using 9.1 betas and 
> further releases for external python3 updates, including switch to 
> ipython7, which seems to me the most urgent matter. But we also do not 
> introduce python3-only code in our own code base if we can avoid it.
>
>
I think for development and stability, we should take heed of the fact that 
trac has some recent tickets addressing issues with py3 that are only being 
uncovered now. The reality is that prior to 9.0, sage/py3 got only very 
limited testing outside doctests and developers working on it. Doctests by 
no means cover the full functionality of sage, and I would expect that in 
the next few months a lot more issues will be found. I'd be a little 
hesitant dropping py2 support under those conditions: being able to drop 
back on py2 in these situations for a while seems like a decent mitigation 
strategy, and would probably help with debugging.

I think similar thinking led to the original proposed and published 
strategy on the wiki, and it still makes sense. In practice, sage/py3 is 
not really a proven product yet; just because people won't start really 
using it until there's actually an official release with it.

 I appreciate the good intentions of "not introducing py3-only code in our 
own code-base if we can avoid it", but how much does that help? If there's 
one such change in a file that gets loaded into sage upon start-up, or 
which needs to be parsed during build, the possibility of running sage on 
py2 is gone, isn't it?

I agree it's perhaps frustrating that the process of moving sage from py2 
to py3 hasn't completed with py2 falling out of support, but having a first 
official release based on py3, while being the biggest step (and a big 
applause for everybody who contributed to this herculean task!) is 
unfortunately not the completion. The bug reporting and fixing that follows 
it shouldn't just be ignored.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/87ad6da2-851b-4b3a-9bde-a9bd4f51660d%40googlegroups.com.

Re: [sage-devel] Protocol for when you see a ticket describing a bug that doesn't seem to exist in the current version

2020-01-14 Thread Mahathi Vempati 
Okay, will do. Thanks!

On Tue 14 Jan, 2020, 11:38 PM Dima Pasechnik,  wrote:

> set the milestone to duplicate/invalid/wontfix
> and give it positive review, with an explanation in a comment.
>
> On Tue, Jan 14, 2020 at 5:53 PM Mahathi Vempati 
> wrote:
> >
> > Precisely the title.
> >
> > How do you go about closing a ticket if a described bug doesn't seem to
> exist anymore?
> >
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "sage-devel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to sage-devel+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/81d6f5ba-230d-4b1b-8845-f242fbc56d55%40googlegroups.com
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/CAAWYfq2zs3SyUS%2BU%3DDbvun4M1NkSvjw-RJBCJrUCv9c502miXQ%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CADusGCyT_ps0C6%3DXBT%2B86pmb60Gkqz6ytNOhvCmQ1%3D_6NQnS6Q%40mail.gmail.com.

Re: [sage-devel] Protocol for when you see a ticket describing a bug that doesn't seem to exist in the current version

2020-01-14 Thread Dima Pasechnik 
set the milestone to duplicate/invalid/wontfix
and give it positive review, with an explanation in a comment.

On Tue, Jan 14, 2020 at 5:53 PM Mahathi Vempati  wrote:
>
> Precisely the title.
>
> How do you go about closing a ticket if a described bug doesn't seem to exist 
> anymore?
>
>
> --
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/81d6f5ba-230d-4b1b-8845-f242fbc56d55%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAAWYfq2zs3SyUS%2BU%3DDbvun4M1NkSvjw-RJBCJrUCv9c502miXQ%40mail.gmail.com.

[sage-devel] Protocol for when you see a ticket describing a bug that doesn't seem to exist in the current version

2020-01-14 Thread Mahathi Vempati 
Precisely the title.

How do you go about closing a ticket if a described bug doesn't seem to 
exist anymore?


-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/81d6f5ba-230d-4b1b-8845-f242fbc56d55%40googlegroups.com.

Re: [sage-devel] Coercions of polynomials

2020-01-14 Thread David Roe 
On Tue, Jan 14, 2020 at 11:32 AM Travis Scrimshaw 
wrote:

> So one thing I thought of that could be a problem is this:
>
> ZZ['x'] --> ZZ['x,y']['x']
>
> or more generally anytime there are repeated variable names. Actually, in
> this case, I feel the default should be to go into the base ring rather
> than the final ring, but another option would be to just error out and say
> it is ambiguous.
>

I think an error is best.  Users can always use lists if they really want
to do something like this.
David


>
> Best,
> Travis
>
>
> On Tuesday, January 14, 2020 at 11:13:51 PM UTC+10, David Roe wrote:
>>
>>
>>
>> On Tue, Jan 14, 2020 at 2:31 AM Vincent Delecroix <20100.d...@gmail.com>
>> wrote:
>>
>>> Maybe you want
>>>
>>> sage: T(S.flattening_morphism()(f))
>>> a*x + b*x + a*y + b*y
>>>
>>>
>>> Le 14/01/2020 à 08:22, Travis Scrimshaw a écrit :
>>> > Hi everyone,
>>> > I wanted to know if this is a deliberate behavior or a bug:
>>> >
>>> > sage: R. = ZZ[]
>>> > sage: S. = R[]
>>> > sage: T = ZZ['a,b,x,y']
>>> > sage: f = (x+y)*(a+b)
>>> > sage: T(f)
>>> > ...
>>> > TypeError: not a constant polynomial
>>> >
>>> > I understand that there should not be a coercion from S to T, but I
>>> feel
>>> > like we should be able to have conversions (anytime the variables of S
>>> are
>>> > a subset of those of T). I have a vague recollection that this used to
>>> > work, but I wouldn't know the last version I tried to do this. What do
>>> you
>>> > think?
>>>
>>
>> I agree that T(f) should work.
>> David
>>
>>
>>> >
>>> > Thanks,
>>> > Travis
>>> >
>>> >
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "sage-devel" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to sage-...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/sage-devel/d8edc2b6-4732-f523-ba1c-71001a3aac99%40gmail.com
>>> .
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/fbb0a228-daaa-4b67-9aef-368005972c1c%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAChs6_m_wYOiRJVK4o9UPJkX51myyQNb3tznb4Cmo982UN8o1A%40mail.gmail.com.

Re: [sage-devel] Re: drop python2 compatibility in 9.1 ?

2020-01-14 Thread William Stein 
Strong *applause* from me.  (This is a very hard problem and I continue to
be amazed and greatly appreciate what everybody has done related to Python3
support in Sage!)

On Tue, Jan 14, 2020, 9:01 AM Frédéric Chapoton 
wrote:

> This has been a long discussion already. Let me try to summarize. My
> question was :
>
>   *Do you agree that sage release 9.1 (and most of the 9.1.betas) will
> not be kept compatible with Python 2 ?*
>
> Some people give a more or less clear *positive* answer :
>
> Chapoton, Bissey, Gourgoulhon, Kaufmann, Novoseltsev, Koeppe, Mantysalo,
> Rojas, Isuru, Stein, Dunfield, Pasechnik (*12*)
>
> Some people give a strong *negative* answer :
>
> Bruin, Bray (*2*)
>
> Some people did not answer the question in a clear way, but still said
> *something* :
>
> Palmieri, Roe, King, Crisman, Delecroix, Scrimshaw, Kliem, Labbé, Braun (
> *9*)
>
> Among them, I would say that maybe 5 people were rather negative on the
> question.
>
> I hope that I have not forgotten anybody or misinterpreted wildly.
>
> [A] It seems to me that the conclusion of the vote is rather clear, and
> that we should not feel obliged to make 9.1 compilable with python2.
>
> ==> I have therefore changed the controversial wiki page, to make only the
> statement that 9.0 is compilable with python2. No more promise for the
> future.
>
> [B] I understand and approve the concerns about our user base. We should
> really try harder to listen more and help people that are simple users.
>
> So here is my proposal.
>
> * Starting from now, we allow ourselves to move on, using 9.1 betas and
> further releases for external python3 updates, including switch to
> ipython7, which seems to me the most urgent matter. But we also do not
> introduce python3-only code in our own code base if we can avoid it.
>
> * Concerning semantic versioning, I would advocate to use 10.0 as the
> first release where all compatibility code will be removed, hence pure py3.
> This may take some time, given the sparse work force. Once done, we allow
> ourself to use python3-only syntax in our own codebase, such as "yield
> from".
>
> Therefore, we can use 9.1, 9.2 and so on until somebody™ does the job of
> cleaning up sagemath codebase from remains of py2-only code.
>
> I have tried to make a balanced and reasonable proposal. Applause or
> scream at your will.
>
> Frederic
>
>
>
>
>
>
> Le dimanche 5 janvier 2020 20:44:10 UTC+1, Frédéric Chapoton a écrit :
>>
>> Hello,
>>
>> I would like to suggest that the sooner we drop Python 2 support the
>> better. We still need to handle the upgrade to ipython7 and the
>> compatibility with python 3.8. All this will be made very difficult if we
>> insist on maintaining a codebase that is both compatible with python 2 and
>> python 3.
>>
>> So, please vote :
>>
>>
>>
>> Frédéric
>>
>>
>>
>> --
> You received this message because you are subscribed to a topic in the
> Google Groups "sage-devel" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/sage-devel/vYlbnAwKATM/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/9db91206-3a7c-434a-8b07-7656e5b5f458%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CACLE5GDNNBsnmQeDSDor16N8CO_v1P-PV1T9ovRcLPskA7b7%2BQ%40mail.gmail.com.

[sage-devel] Re: drop python2 compatibility in 9.1 ?

2020-01-14 Thread Frédéric Chapoton 
This has been a long discussion already. Let me try to summarize. My 
question was :

  *Do you agree that sage release 9.1 (and most of the 9.1.betas) will not 
be kept compatible with Python 2 ?*

Some people give a more or less clear *positive* answer :

Chapoton, Bissey, Gourgoulhon, Kaufmann, Novoseltsev, Koeppe, Mantysalo, 
Rojas, Isuru, Stein, Dunfield, Pasechnik (*12*)

Some people give a strong *negative* answer :

Bruin, Bray (*2*)

Some people did not answer the question in a clear way, but still said 
*something* :

Palmieri, Roe, King, Crisman, Delecroix, Scrimshaw, Kliem, Labbé, Braun (*9*
)

Among them, I would say that maybe 5 people were rather negative on the 
question.

I hope that I have not forgotten anybody or misinterpreted wildly.

[A] It seems to me that the conclusion of the vote is rather clear, and 
that we should not feel obliged to make 9.1 compilable with python2.

==> I have therefore changed the controversial wiki page, to make only the 
statement that 9.0 is compilable with python2. No more promise for the 
future.

[B] I understand and approve the concerns about our user base. We should 
really try harder to listen more and help people that are simple users.

So here is my proposal.

* Starting from now, we allow ourselves to move on, using 9.1 betas and 
further releases for external python3 updates, including switch to 
ipython7, which seems to me the most urgent matter. But we also do not 
introduce python3-only code in our own code base if we can avoid it.

* Concerning semantic versioning, I would advocate to use 10.0 as the first 
release where all compatibility code will be removed, hence pure py3. This 
may take some time, given the sparse work force. Once done, we allow 
ourself to use python3-only syntax in our own codebase, such as "yield 
from".

Therefore, we can use 9.1, 9.2 and so on until somebody™ does the job of 
cleaning up sagemath codebase from remains of py2-only code.

I have tried to make a balanced and reasonable proposal. Applause or scream 
at your will.

Frederic






Le dimanche 5 janvier 2020 20:44:10 UTC+1, Frédéric Chapoton a écrit :
>
> Hello,
>
> I would like to suggest that the sooner we drop Python 2 support the 
> better. We still need to handle the upgrade to ipython7 and the 
> compatibility with python 3.8. All this will be made very difficult if we 
> insist on maintaining a codebase that is both compatible with python 2 and 
> python 3.
>
> So, please vote :
>
>
>
> Frédéric
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/9db91206-3a7c-434a-8b07-7656e5b5f458%40googlegroups.com.

Re: [sage-devel] Coercions of polynomials

2020-01-14 Thread Travis Scrimshaw 
So one thing I thought of that could be a problem is this:

ZZ['x'] --> ZZ['x,y']['x']

or more generally anytime there are repeated variable names. Actually, in 
this case, I feel the default should be to go into the base ring rather 
than the final ring, but another option would be to just error out and say 
it is ambiguous.

Best,
Travis


On Tuesday, January 14, 2020 at 11:13:51 PM UTC+10, David Roe wrote:
>
>
>
> On Tue, Jan 14, 2020 at 2:31 AM Vincent Delecroix <20100.d...@gmail.com 
> > wrote:
>
>> Maybe you want
>>
>> sage: T(S.flattening_morphism()(f))
>> a*x + b*x + a*y + b*y
>>
>>
>> Le 14/01/2020 à 08:22, Travis Scrimshaw a écrit :
>> > Hi everyone,
>> > I wanted to know if this is a deliberate behavior or a bug:
>> > 
>> > sage: R. = ZZ[]
>> > sage: S. = R[]
>> > sage: T = ZZ['a,b,x,y']
>> > sage: f = (x+y)*(a+b)
>> > sage: T(f)
>> > ...
>> > TypeError: not a constant polynomial
>> > 
>> > I understand that there should not be a coercion from S to T, but I feel
>> > like we should be able to have conversions (anytime the variables of S 
>> are
>> > a subset of those of T). I have a vague recollection that this used to
>> > work, but I wouldn't know the last version I tried to do this. What do 
>> you
>> > think?
>>
>
> I agree that T(f) should work.
> David
>  
>
>> > 
>> > Thanks,
>> > Travis
>> > 
>> > 
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "sage-devel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to sage-...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/sage-devel/d8edc2b6-4732-f523-ba1c-71001a3aac99%40gmail.com
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/fbb0a228-daaa-4b67-9aef-368005972c1c%40googlegroups.com.

Re: [sage-devel] Server side hook denies push

2020-01-14 Thread Mahathi Vempati 
That worked, yes.
Thank you!

On Tue, Jan 14, 2020 at 4:15 PM Dima Pasechnik  wrote:

> On Tue, Jan 14, 2020 at 10:31 AM Mahathi Vempati 
> wrote:
> >
> > yes, I authenticated with an ssh key.
> > Is this an authentication issue? I had assumed there was some issue with
> my code that a hook was not letting pass.
>
> It seems that you never had any git branches successfully
> pushed to trac.sagemath.org
> - so it could be authentication problem.
> T
> he branch should start from "u/gh-Tinkidinki/" it seems, given that
> your username is gh-Tinkidinki.
>
>
> >
> > On Tue, Jan 14, 2020 at 2:44 PM Dima Pasechnik 
> wrote:
> >>
> >>
> >>
> >> On Tue, 14 Jan 2020, 08:58 Mahathi Vempati, 
> wrote:
> >>>
> >>> So, I committed some code and was attempting to push it to the sage
> server when I got this message. How do I find what hook in remote denied my
> push and why it is being denied?
> >>>
> >>> ```
> >>> remote: FATAL: W
> refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
> sage gh-Tinkidinki DENIED by fallthru
> >>> remote: error: hook declined to update
> refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
> >>> To trac.sagemath.org:sage.git
> >>>  ! [remote rejected]   HEAD ->
> u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
> (hook declined)
> >>> error: failed to push some refs to 'g...@trac.sagemath.org:sage.git'
> >>> ```
> >>
> >>
> >> how do you authenticate to git server?
> >> Usually you would upload an ssh key.
> >>
> >>>
> >>> (Cross-posting from the Zulip server because I believe the google
> groups are more active?)
> >>>
> >>> Thank you
> >>> Mahathi
> >>>
> >>> --
> >>> You received this message because you are subscribed to the Google
> Groups "sage-devel" group.
> >>> To unsubscribe from this group and stop receiving emails from it, send
> an email to sage-devel+unsubscr...@googlegroups.com.
> >>> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/75de2ba6-bed2-4222-878f-968a2ac08a02%40googlegroups.com
> .
> >>
> >> --
> >> You received this message because you are subscribed to the Google
> Groups "sage-devel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send
> an email to sage-devel+unsubscr...@googlegroups.com.
> >> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/CAAWYfq3ZFRamRxNE%2Bz7F%2Bnkn0QycSf1-fDwd2LejhRGFf5ETKQ%40mail.gmail.com
> .
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "sage-devel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to sage-devel+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/CADusGCy71p%3D0a2oxr95ojBe3pM7WhnY6DyRD-t3R8RV6F3TtYQ%40mail.gmail.com
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/CAAWYfq0YiJ7ETz19s4tbm0BRnctfP_7LDGn718f77jkbi-2pSw%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CADusGCxjpXc9FQrojUTTRS8S%3DQHu_UAR_140E4EdYYL54V0_Eg%40mail.gmail.com.

Re: [sage-devel] Coercions of polynomials

2020-01-14 Thread David Roe 
On Tue, Jan 14, 2020 at 2:31 AM Vincent Delecroix <20100.delecr...@gmail.com>
wrote:

> Maybe you want
>
> sage: T(S.flattening_morphism()(f))
> a*x + b*x + a*y + b*y
>
>
> Le 14/01/2020 à 08:22, Travis Scrimshaw a écrit :
> > Hi everyone,
> > I wanted to know if this is a deliberate behavior or a bug:
> >
> > sage: R. = ZZ[]
> > sage: S. = R[]
> > sage: T = ZZ['a,b,x,y']
> > sage: f = (x+y)*(a+b)
> > sage: T(f)
> > ...
> > TypeError: not a constant polynomial
> >
> > I understand that there should not be a coercion from S to T, but I feel
> > like we should be able to have conversions (anytime the variables of S
> are
> > a subset of those of T). I have a vague recollection that this used to
> > work, but I wouldn't know the last version I tried to do this. What do
> you
> > think?
>

I agree that T(f) should work.
David


> >
> > Thanks,
> > Travis
> >
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/d8edc2b6-4732-f523-ba1c-71001a3aac99%40gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAChs6_n_dyf7JGer5wBvUY5KK0XUjLDRVdHQETZyQmzsH0CLKg%40mail.gmail.com.

Re: [sage-devel] drop python2 compatibility in 9.1 ?

2020-01-14 Thread Dima Pasechnik 
On Sun, Jan 5, 2020 at 7:44 PM Frédéric Chapoton  wrote:
>
> Hello,
>
> I would like to suggest that the sooner we drop Python 2 support the better. 
> We still need to handle the upgrade to ipython7 and the compatibility with 
> python 3.8. All this will be made very difficult if we insist on maintaining 
> a codebase that is both compatible with python 2 and python 3.
>
> So, please vote :
>
> Do you agree that sage release 9.1 (and most of the 9.1.betas) will not be 
> kept compatible with Python 2 ?

As far as I am concerned, the sooner py2 is dropped on the "main"
branches, the better.

This does not preclude making separate maintenance releases for py2, if need be.



>
> Frédéric
>
>
>
> --
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/692fc332-d9e6-4e6a-80fe-2e89cf0b488f%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAAWYfq1BQ0xLtRo%2B-h3_zRJt-%3DQGQ3yHpvM%3DzNugbJf9m4aQRQ%40mail.gmail.com.

Re: [sage-devel] Server side hook denies push

2020-01-14 Thread Dima Pasechnik 
On Tue, Jan 14, 2020 at 10:31 AM Mahathi Vempati  wrote:
>
> yes, I authenticated with an ssh key.
> Is this an authentication issue? I had assumed there was some issue with my 
> code that a hook was not letting pass.

It seems that you never had any git branches successfully
pushed to trac.sagemath.org
- so it could be authentication problem.
T
he branch should start from "u/gh-Tinkidinki/" it seems, given that
your username is gh-Tinkidinki.


>
> On Tue, Jan 14, 2020 at 2:44 PM Dima Pasechnik  wrote:
>>
>>
>>
>> On Tue, 14 Jan 2020, 08:58 Mahathi Vempati,  wrote:
>>>
>>> So, I committed some code and was attempting to push it to the sage server 
>>> when I got this message. How do I find what hook in remote denied my push 
>>> and why it is being denied?
>>>
>>> ```
>>> remote: FATAL: W 
>>> refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
>>>  sage gh-Tinkidinki DENIED by fallthru
>>> remote: error: hook declined to update 
>>> refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
>>> To trac.sagemath.org:sage.git
>>>  ! [remote rejected]   HEAD -> 
>>> u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
>>>  (hook declined)
>>> error: failed to push some refs to 'g...@trac.sagemath.org:sage.git'
>>> ```
>>
>>
>> how do you authenticate to git server?
>> Usually you would upload an ssh key.
>>
>>>
>>> (Cross-posting from the Zulip server because I believe the google groups 
>>> are more active?)
>>>
>>> Thank you
>>> Mahathi
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups 
>>> "sage-devel" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to sage-devel+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/sage-devel/75de2ba6-bed2-4222-878f-968a2ac08a02%40googlegroups.com.
>>
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "sage-devel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to sage-devel+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/sage-devel/CAAWYfq3ZFRamRxNE%2Bz7F%2Bnkn0QycSf1-fDwd2LejhRGFf5ETKQ%40mail.gmail.com.
>
> --
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/CADusGCy71p%3D0a2oxr95ojBe3pM7WhnY6DyRD-t3R8RV6F3TtYQ%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAAWYfq0YiJ7ETz19s4tbm0BRnctfP_7LDGn718f77jkbi-2pSw%40mail.gmail.com.

Re: [sage-devel] Server side hook denies push

2020-01-14 Thread Mahathi Vempati 
yes, I authenticated with an ssh key.
Is this an authentication issue? I had assumed there was some issue with my
code that a hook was not letting pass.

On Tue, Jan 14, 2020 at 2:44 PM Dima Pasechnik  wrote:

>
>
> On Tue, 14 Jan 2020, 08:58 Mahathi Vempati,  wrote:
>
>> So, I committed some code and was attempting to push it to the sage
>> server when I got this message. How do I find what hook in remote denied my
>> push and why it is being denied?
>>
>> ```
>> remote: FATAL: W
>> refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
>> sage gh-Tinkidinki DENIED by fallthru
>> remote: error: hook declined to update
>> refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
>> To trac.sagemath.org:sage.git
>>  ! [remote rejected]   HEAD ->
>> u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
>> (hook declined)
>> error: failed to push some refs to 'g...@trac.sagemath.org:sage.git'
>> ```
>>
>
> how do you authenticate to git server?
> Usually you would upload an ssh key.
>
>
>> (Cross-posting from the Zulip server because I believe the google groups
>> are more active?)
>>
>> Thank you
>> Mahathi
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "sage-devel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to sage-devel+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/sage-devel/75de2ba6-bed2-4222-878f-968a2ac08a02%40googlegroups.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/CAAWYfq3ZFRamRxNE%2Bz7F%2Bnkn0QycSf1-fDwd2LejhRGFf5ETKQ%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CADusGCy71p%3D0a2oxr95ojBe3pM7WhnY6DyRD-t3R8RV6F3TtYQ%40mail.gmail.com.

Re: [sage-devel] Re: drop python2 compatibility in 9.1 ?

2020-01-14 Thread Timo Kaufmann 
Am Montag, 13. Januar 2020 17:33:56 UTC+1 schrieb E. Madison Bray:
>
> On Sat, Jan 11, 2020 at 9:24 AM Antonio Rojas  > wrote: 
> > 
> > El viernes, 10 de enero de 2020, 14:54:24 (UTC+1), E. Madison Bray 
> escribió: 
> >> 
> >> That seems like the obvious approach to me.  As it is I've long felt 
> >> that Sage should be more flexible in its dependencies where 
> >> possible/necessary.  With most Python packages it's easy as most have 
> >> a .__version__ and its not so hard to define some variable 
> >> like IS_RPY_2 and just have two separate branches.  I have things like 
> >> that all over the place in other packages to support e.g. different 
> >> Numpy versions or work around version-specific bugs. 
> > 
> > 
> > I've opened https://trac.sagemath.org/ticket/28988 for rpy. But at this 
> point the major issues are python 3.8 and ipython 7, and I don't see how 
> one could support several versions of them without forking hundreds of 
> doctests. Both updates require multi-thousand-lines patches, due to changes 
> in dict sorting and hashes. 
>
> That remains a fault of over-reliance on doctests.


What else should we rely on? Also, doctests are not the only things that 
fail with current python3 libraries.

I don't think 
> downstream packaging is a good enough reason to push sage to rush 
> things in such a way that is not well-communicated to the user 
> community.  If you need to have a multi-thousand-line patch then so be 
> it.  A patch is a patch. 
>

That is unfortunate. I agree that "a patch is a patch", but in my view the 
conclusion should be the opposite: Upstream should strive for no patches to 
be necessary (except maybe to work around very distro-specific quirks). No 
5000 line patches and no 5 line patches.

For me this decision means that sage on nixos will likely be stuck on 
python2 for a while, and I can only hope that the python2 infrastructure 
keeps working for long enough.

I still don't understand the reasoning here. From my point of view (which 
is of course biased), keeping python2 compatibility has a huge downside. At 
the same time, keeping it has very little upside. The main reasoning seems 
to be to give users time to update their code. But the value-addition of 
keeping python2 in newer sage versions vs just telling users to use 8.9 / 
9.0 with python2 seems very small to me. On the contrary, newer features 
being python3 exclusive might give a good incentive for updating. Otherwise 
we just postpone the problem until we finally do drop support.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/2568ce65-4c70-469c-abf3-50e4b6c5ab10%40googlegroups.com.

Re: [sage-devel] Server side hook denies push

2020-01-14 Thread Dima Pasechnik 
On Tue, 14 Jan 2020, 08:58 Mahathi Vempati,  wrote:

> So, I committed some code and was attempting to push it to the sage server
> when I got this message. How do I find what hook in remote denied my push
> and why it is being denied?
>
> ```
> remote: FATAL: W
> refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
> sage gh-Tinkidinki DENIED by fallthru
> remote: error: hook declined to update
> refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
> To trac.sagemath.org:sage.git
>  ! [remote rejected]   HEAD ->
> u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
> (hook declined)
> error: failed to push some refs to 'g...@trac.sagemath.org:sage.git'
> ```
>

how do you authenticate to git server?
Usually you would upload an ssh key.


> (Cross-posting from the Zulip server because I believe the google groups
> are more active?)
>
> Thank you
> Mahathi
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/75de2ba6-bed2-4222-878f-968a2ac08a02%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAAWYfq3ZFRamRxNE%2Bz7F%2Bnkn0QycSf1-fDwd2LejhRGFf5ETKQ%40mail.gmail.com.

[sage-devel] Server side hook denies push

2020-01-14 Thread Mahathi Vempati 
So, I committed some code and was attempting to push it to the sage server 
when I got this message. How do I find what hook in remote denied my push 
and why it is being denied? 

```
remote: FATAL: W 
refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
 
sage gh-Tinkidinki DENIED by fallthru
remote: error: hook declined to update 
refs/heads/u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
To trac.sagemath.org:sage.git
 ! [remote rejected]   HEAD -> 
u/Tinkidinki/have_the_sage_version_number_present_on_every_page_of_the_documentation
 
(hook declined)
error: failed to push some refs to 'g...@trac.sagemath.org:sage.git'
```

(Cross-posting from the Zulip server because I believe the google groups 
are more active?)

Thank you
Mahathi

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/75de2ba6-bed2-4222-878f-968a2ac08a02%40googlegroups.com.