RE: building from james head
> If I do a cvs diff I don't see anything different (diff invoked at 20:49 > Paris time). Look again. My changes were all complete by 14:09 EDT. > I replaced the cornerstone-xxx-1.0.jar with corenerstone-xxx-api-1.0.jar > and corenerstone-xxx-impl-1.0.jar. I agree with your premise, but if you look at build.xml the way it is right now (http://cvs.apache.org/viewcvs/james-server/build.xml?annotate=1.138), the API and IMPL jars are all listed when making the SAR. The project classpath doesn't care about separation. It just wants whatever jar(s) it needs. In this case, entries like: are symbolic references to the API jars defined in the properties file. > > Commons Pool was actually v1.0.1, so I renamed that jar. > Renamed or replaced? The jar I committed was 1.0 from ibiblio. Replaced. The one we had already been using was an unlabeled v1.0.1, downloaded from the Jakarta Commons release area. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: building from james head
Richard O. Hammer wrote: > This is valid source as far as the Java language is concerned. > InetNetwork is not an inner class, but rather is another class > in the same package. Correct. > While it is customary to put each class in its own file > this is not required by Java standards. Unnecessary for what is currently just a helper class in that package. See JLS 6.6.4. > But, from scanning the Exception message which you attach, this > practice seems to violate a design assumption of Avalon. Actually, no. What I've seen is that the class somehow gets built into build/classes, but is not copied into the packaging. Anytime I have seen this, doing a build.sh clean followed by a rebuild clears it up. > I suspect you could make InetNetwork into an inner class simply > by moving the closing brace of class NetMatcher down below the > closing brace of InetNetwork. That might fly, and might even > have been intended, if no class but NetMatcher uses reference > to InetNetwork. No, that would be bad. InetNetwork does not want an enclosing instance. Stephen was correct that if it were to be an inner class (which it did not need to be, but harms none in James and handles the packaging bug), it should be static. -- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: building from james head
> The class org.apache.james.util.NetMatcher includes references to the > inner class InetNetwork. It isn't an inner class. Nor is it a public class. The language and usage are perfectly legal. See section 6.6.4 of the Java Language Specification. ref: http://java.sun.com/docs/books/jls/first_edition/html/6.doc.html#36060 The bug is a packaging error that I have seen from time to time with Ant, and which always seems to be resolved by doing a clean build. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: building from james head
Noel J. Bergman wrote: Stephen, In the meantime I'm be committing updates to the build.xml so we are all in sync. I hadn't committed my changes because I couldn't get things to work here, but I believe that I had everything you do. I'll commit now so that we're not stepping on each other. Please review, and let me know if you see any problems. If I do a cvs diff I don't see anything different (diff invoked at 20:49 Paris time). I replaced the cornerstone-xxx-1.0.jar with corenerstone-xxx-api-1.0.jar and corenerstone-xxx-impl-1.0.jar. The reason for this is that I would like to set the context for talking you guys into a seperation of impl from api so that we can move towards greater reusability of james. But that's another subject. Commons Pool was actually v1.0.1, so I renamed that jar. Renamed or replaced? The jar I committed was 1.0 from ibiblio. Is the project.class.path value used at runtime, or only at compile time? Compile time only. Stephen. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Stephen J. McConnell mailto:[EMAIL PROTECTED] http://www.osm.net Sent via James running under Merlin as an NT service. http://avalon.apache.org/sandbox/merlin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: building from james head
This is valid source as far as the Java language is concerned.
InetNetwork is not an inner class, but rather is another class in the
same package. While it is customary to put each class in its own file
this is not required by Java standards.
But, from scanning the Exception message which you attach, this
practice seems to violate a design assumption of Avalon.
Although I have not tried this, I suspect you could make InetNetwork
into an inner class simply by moving the closing brace of class
NetMatcher down below the closing brace of InetNetwork. That might
fly, and might even have been intended, if no class but NetMatcher
uses reference to InetNetwork.
Rich Hammer
Hillsborough, N.C.
Stephen McConnell wrote:
This one is interesting:
The class org.apache.james.util.NetMatcher includes references to the
inner class InetNetwork. However, if we look at the source we see that
InetNetwork is not defined as an inner class (at least not in a way I am
familiar with).
What we have is :
public class NetMatcher
{
// stuff
}
class InetNetwork
{
// stuff
}
// more stuff
Ok - it compiles but is this really a valid source?
Stephen.
Internal error during kernel instantiation.
---
Exception: org.apache.avalon.merlin.kernel.KernelException
Message: Deployment failure.
Cause: org.apache.avalon.activation.appliance.DeploymentException
Message: Composite deployment failure in block: [block:/james]
Cause: org.apache.avalon.activation.lifecycle.LifecycleException
Message: Unable to create a new component instance in appliance
[/james/spool] due to a component deployment failure.
Cause: org.apache.avalon.activation.lifecycle.LifecycleException
Message: Component initiated initialization failure.
Cause: java.lang.NoClassDefFoundError
Message: org/apache/james/util/InetNetwork
stack trace --
java.lang.NoClassDefFoundError: org/apache/james/util/InetNetwork
at
org.apache.james.transport.matchers.AbstractNetworkMatcher.init(AbstractNetworkMatcher.java:95)
at org.apache.mailet.GenericMatcher.init(GenericMatcher.java:154)
at
org.apache.james.transport.MatchLoader.getMatcher(MatchLoader.java:108)
at
org.apache.james.transport.JamesSpoolManager.initialize(JamesSpoolManager.java:212)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.applyInitialization(DefaultAppliance.java:952)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.newInstance(DefaultAppliance.java:637)
at
org.apache.avalon.activation.lifestyle.impl.SingletonLifestyleHandler.resolve(SingletonLifestyleHandler.java:
94)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.resolve(DefaultAppliance.java:585)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.resolve(DefaultAppliance.java:571)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.deploy(DefaultAppliance.java:520)
at
org.apache.avalon.activation.appliance.impl.DefaultBlock.deploy(DefaultBlock.java:625)
at
org.apache.avalon.activation.appliance.impl.BlockThread.run(BlockThread.java:111)
---
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: building from james head
Stephen, > In the meantime I'm be committing updates to the build.xml so we are all > in sync. I hadn't committed my changes because I couldn't get things to work here, but I believe that I had everything you do. I'll commit now so that we're not stepping on each other. Please review, and let me know if you see any problems. Commons Pool was actually v1.0.1, so I renamed that jar. Is the project.class.path value used at runtime, or only at compile time? --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: building from james head
Hi:
Have just committed a change to NetMatcher. I moved the InetNetwork
class to be a proper inner class of NetMatcher and changed it to a
static class. I have not idea if this is what was intended - but now it
compiles *and* James runtime works.
Stephen.
Stephen McConnell wrote:
This one is interesting:
The class org.apache.james.util.NetMatcher includes references to the
inner class InetNetwork. However, if we look at the source we see
that InetNetwork is not defined as an inner class (at least not in a
way I am familiar with).
What we have is :
public class NetMatcher
{
// stuff
}
class InetNetwork
{
// stuff
}
// more stuff
Ok - it compiles but is this really a valid source?
Stephen.
Internal error during kernel instantiation.
---
Exception: org.apache.avalon.merlin.kernel.KernelException
Message: Deployment failure.
Cause: org.apache.avalon.activation.appliance.DeploymentException
Message: Composite deployment failure in block: [block:/james]
Cause: org.apache.avalon.activation.lifecycle.LifecycleException
Message: Unable to create a new component instance in appliance
[/james/spool] due to a component deployment failure.
Cause: org.apache.avalon.activation.lifecycle.LifecycleException
Message: Component initiated initialization failure.
Cause: java.lang.NoClassDefFoundError
Message: org/apache/james/util/InetNetwork
stack trace --
java.lang.NoClassDefFoundError: org/apache/james/util/InetNetwork
at
org.apache.james.transport.matchers.AbstractNetworkMatcher.init(AbstractNetworkMatcher.java:95)
at org.apache.mailet.GenericMatcher.init(GenericMatcher.java:154)
at
org.apache.james.transport.MatchLoader.getMatcher(MatchLoader.java:108)
at
org.apache.james.transport.JamesSpoolManager.initialize(JamesSpoolManager.java:212)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.applyInitialization(DefaultAppliance.java:952)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.newInstance(DefaultAppliance.java:637)
at
org.apache.avalon.activation.lifestyle.impl.SingletonLifestyleHandler.resolve(SingletonLifestyleHandler.java:
94)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.resolve(DefaultAppliance.java:585)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.resolve(DefaultAppliance.java:571)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.deploy(DefaultAppliance.java:520)
at
org.apache.avalon.activation.appliance.impl.DefaultBlock.deploy(DefaultBlock.java:625)
at
org.apache.avalon.activation.appliance.impl.BlockThread.run(BlockThread.java:111)
---
--
Stephen J. McConnell
mailto:[EMAIL PROTECTED]
http://www.osm.net
Sent via James running under Merlin as an NT service.
http://avalon.apache.org/sandbox/merlin
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: building from james head
This one is interesting:
The class org.apache.james.util.NetMatcher includes references to the
inner class InetNetwork. However, if we look at the source we see that
InetNetwork is not defined as an inner class (at least not in a way I am
familiar with).
What we have is :
public class NetMatcher
{
// stuff
}
class InetNetwork
{
// stuff
}
// more stuff
Ok - it compiles but is this really a valid source?
Stephen.
Internal error during kernel instantiation.
---
Exception: org.apache.avalon.merlin.kernel.KernelException
Message: Deployment failure.
Cause: org.apache.avalon.activation.appliance.DeploymentException
Message: Composite deployment failure in block: [block:/james]
Cause: org.apache.avalon.activation.lifecycle.LifecycleException
Message: Unable to create a new component instance in appliance
[/james/spool] due to a component deployment failure.
Cause: org.apache.avalon.activation.lifecycle.LifecycleException
Message: Component initiated initialization failure.
Cause: java.lang.NoClassDefFoundError
Message: org/apache/james/util/InetNetwork
stack trace --
java.lang.NoClassDefFoundError: org/apache/james/util/InetNetwork
at
org.apache.james.transport.matchers.AbstractNetworkMatcher.init(AbstractNetworkMatcher.java:95)
at org.apache.mailet.GenericMatcher.init(GenericMatcher.java:154)
at
org.apache.james.transport.MatchLoader.getMatcher(MatchLoader.java:108)
at
org.apache.james.transport.JamesSpoolManager.initialize(JamesSpoolManager.java:212)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.applyInitialization(DefaultAppliance.java:952)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.newInstance(DefaultAppliance.java:637)
at
org.apache.avalon.activation.lifestyle.impl.SingletonLifestyleHandler.resolve(SingletonLifestyleHandler.java:
94)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.resolve(DefaultAppliance.java:585)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.resolve(DefaultAppliance.java:571)
at
org.apache.avalon.activation.appliance.impl.DefaultAppliance.deploy(DefaultAppliance.java:520)
at
org.apache.avalon.activation.appliance.impl.DefaultBlock.deploy(DefaultBlock.java:625)
at
org.apache.avalon.activation.appliance.impl.BlockThread.run(BlockThread.java:111)
---
--
Stephen J. McConnell
mailto:[EMAIL PROTECTED]
http://www.osm.net
Sent via James running under Merlin as an NT service.
http://avalon.apache.org/sandbox/merlin
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: building from james head
Seems that commons-pool is required but not included in the lib directory. Have fixed this and am moving on with testing. Stephen. Stephen McConnell wrote: Earlier today I tested James against a local version of the james CVS using the final cornerstone builds. That worked fine and James built and run without problem. Following that I started to put in place the changes to the james build.xml and validate against the latest state of James HEAD. However, I'm running into some problems. First of all - commons-dbcp is referenced somewhere but not included in the lib directory. I corrected that by dowbnloading the 1.0 release and that problem dissapeared. However, I left with the following compilation error: [javac] F:\dev\james-server\src\java\org\apache\james\util\dbcp\JdbcDataSource.java:111: cannot access org.apache.co mmons.pool.impl.GenericObjectPool [javac] file org\apache\commons\pool\impl\GenericObjectPool.class not found [javac] connectionPool.setTestOnBorrow(true); [javac] ^ Any suggestions? In the meantime I'm be committing updates to the build.xml so we are all in sync. Stephen. -- Stephen J. McConnell mailto:[EMAIL PROTECTED] http://www.osm.net Sent via James running under Merlin as an NT service. http://avalon.apache.org/sandbox/merlin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
building from james head
Earlier today I tested James against a local version of the james CVS using the final cornerstone builds. That worked fine and James built and run without problem. Following that I started to put in place the changes to the james build.xml and validate against the latest state of James HEAD. However, I'm running into some problems. First of all - commons-dbcp is referenced somewhere but not included in the lib directory. I corrected that by dowbnloading the 1.0 release and that problem dissapeared. However, I left with the following compilation error: [javac] F:\dev\james-server\src\java\org\apache\james\util\dbcp\JdbcDataSource.java:111: cannot access org.apache.co mmons.pool.impl.GenericObjectPool [javac] file org\apache\commons\pool\impl\GenericObjectPool.class not found [javac] connectionPool.setTestOnBorrow(true); [javac] ^ Any suggestions? In the meantime I'm be committing updates to the build.xml so we are all in sync. Stephen. -- Stephen J. McConnell mailto:[EMAIL PROTECTED] http://www.osm.net Sent via James running under Merlin as an NT service. http://avalon.apache.org/sandbox/merlin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
