[jira] Commented: (SOLR-204) Let solrconfig.xml configure the SolrDispatchFilter to handle /select
[ https://issues.apache.org/jira/browse/SOLR-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492505 ] Yonik Seeley commented on SOLR-204: --- I wanted to try this out to see what sendError() output looks like, but the patch isn't applying cleanly. $ patch -p0 c:/dl/SOLR-204* (Stripping trailing CRs from patch.) patching file src/test/test-files/solr/conf/solrconfig.xml (Stripping trailing CRs from patch.) patching file src/webapp/WEB-INF/web.xml (Stripping trailing CRs from patch.) patching file src/webapp/src/org/apache/solr/servlet/SolrDispatchFilter.java Hunk #1 FAILED at 56. 1 out of 1 hunk FAILED -- saving rejects to file src/webapp/src/org/apache/solr/ servlet/SolrDispatchFilter.java.rej (Stripping trailing CRs from patch.) patching file src/webapp/src/org/apache/solr/servlet/SolrRequestParsers.java (Stripping trailing CRs from patch.) patching file example/solr/conf/solrconfig.xml Hunk #1 succeeded at 231 (offset 8 lines). Let solrconfig.xml configure the SolrDispatchFilter to handle /select - Key: SOLR-204 URL: https://issues.apache.org/jira/browse/SOLR-204 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Assigned To: Ryan McKinley Attachments: SOLR-204-HandleSelect.patch, SOLR-204-HandleSelect.patch The major reason to make everythign use the SolrDispatchFilter is that we would have consistent error handling. Currently, SolrServlet spits back errors using: PrintWriter writer = response.getWriter(); writer.write(msg); and the SolrDispatchFilter spits them back using: res.sendError( code, ex.getMessage() ); Using sendError lets the servlet container format the code so it shows up ok in a browser. Without it, you may have to view source to see the error. Aditionaly, SolrDispatchFilter is more decerning about including stack trace. It only includes a stack trace of 500 or an unknown response code. Eventually, the error should probably be formatted in the requested format - SOLR-141. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-204) Let solrconfig.xml configure the SolrDispatchFilter to handle /select
[ https://issues.apache.org/jira/browse/SOLR-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492508 ] Ryan McKinley commented on SOLR-204: sendError lets the web app decide how to format the response body. Typically they put HTML with the status code, with a footer saying the Jetty or Resin This is what you get to configure with: error-page exception-typejava.lang.Exception/exception-type location/error/location /error-page error-pageerror-code404/error-codelocation/error/location/error-page etc Let solrconfig.xml configure the SolrDispatchFilter to handle /select - Key: SOLR-204 URL: https://issues.apache.org/jira/browse/SOLR-204 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Assigned To: Ryan McKinley Attachments: SOLR-204-HandleSelect.patch, SOLR-204-HandleSelect.patch, SOLR-204-HandleSelect.patch The major reason to make everythign use the SolrDispatchFilter is that we would have consistent error handling. Currently, SolrServlet spits back errors using: PrintWriter writer = response.getWriter(); writer.write(msg); and the SolrDispatchFilter spits them back using: res.sendError( code, ex.getMessage() ); Using sendError lets the servlet container format the code so it shows up ok in a browser. Without it, you may have to view source to see the error. Aditionaly, SolrDispatchFilter is more decerning about including stack trace. It only includes a stack trace of 500 or an unknown response code. Eventually, the error should probably be formatted in the requested format - SOLR-141. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-204) Let solrconfig.xml configure the SolrDispatchFilter to handle /select
[
https://issues.apache.org/jira/browse/SOLR-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492511
]
Yonik Seeley commented on SOLR-204:
---
OK cool, for something like an undefined field, it looks fine:
undefined field catdsfgsdg
But for something like a query parsing error, the only pointer to *what* the
error is is in the stack trace, and you don't get that back. You just get:
Error parsing Lucene query
The logs show:
SEVERE: org.apache.lucene.queryParser.ParseException: Cannot parse 'foo:*': '*'
or '?' not allowed as first character in WildcardQuery
at org.apache.lucene.queryParser.QueryParser.parse(QueryParser.java:149)
at org.apache.solr.search.QueryParsing.parseQuery(QueryParsing.java:94)
at
org.apache.solr.request.StandardRequestHandler.handleRequestBody(StandardRequestHandler.java:85)
at
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:77)
Hmmm, but I think this is an exception issue:
In QueryParsing.java:
} catch (ParseException e) {
SolrCore.log(e);
throw new SolrException(400,Error parsing Lucene query,e);
}
should probably be something more like:
throw new SolrException(400,Query parsing error: + e.getMessage() ,e);
Let solrconfig.xml configure the SolrDispatchFilter to handle /select
-
Key: SOLR-204
URL: https://issues.apache.org/jira/browse/SOLR-204
Project: Solr
Issue Type: Improvement
Reporter: Ryan McKinley
Assigned To: Ryan McKinley
Attachments: SOLR-204-HandleSelect.patch,
SOLR-204-HandleSelect.patch, SOLR-204-HandleSelect.patch
The major reason to make everythign use the SolrDispatchFilter is that we
would have consistent error handling. Currently,
SolrServlet spits back errors using:
PrintWriter writer = response.getWriter();
writer.write(msg);
and the SolrDispatchFilter spits them back using:
res.sendError( code, ex.getMessage() );
Using sendError lets the servlet container format the code so it shows up
ok in a browser. Without it, you may have to view source to see the error.
Aditionaly, SolrDispatchFilter is more decerning about including stack trace.
It only includes a stack trace of 500 or an unknown response code.
Eventually, the error should probably be formatted in the requested format -
SOLR-141.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-204) Let solrconfig.xml configure the SolrDispatchFilter to handle /select
[ https://issues.apache.org/jira/browse/SOLR-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492512 ] Ryan McKinley commented on SOLR-204: should probably be something more like: throw new SolrException(400,Query parsing error: + e.getMessage() ,e); Yes, the other change is that errors for RequestDispatcher only print the stack trace if it is =500, 400 (bad request) assumes the message will contain a user useful response. Let solrconfig.xml configure the SolrDispatchFilter to handle /select - Key: SOLR-204 URL: https://issues.apache.org/jira/browse/SOLR-204 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Assigned To: Ryan McKinley Attachments: SOLR-204-HandleSelect.patch, SOLR-204-HandleSelect.patch, SOLR-204-HandleSelect.patch The major reason to make everythign use the SolrDispatchFilter is that we would have consistent error handling. Currently, SolrServlet spits back errors using: PrintWriter writer = response.getWriter(); writer.write(msg); and the SolrDispatchFilter spits them back using: res.sendError( code, ex.getMessage() ); Using sendError lets the servlet container format the code so it shows up ok in a browser. Without it, you may have to view source to see the error. Aditionaly, SolrDispatchFilter is more decerning about including stack trace. It only includes a stack trace of 500 or an unknown response code. Eventually, the error should probably be formatted in the requested format - SOLR-141. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
