[ https://issues.apache.org/jira/browse/SOLR-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492505 ]
Yonik Seeley commented on SOLR-204: ----------------------------------- I wanted to try this out to see what sendError() output looks like, but the patch isn't applying cleanly. $ patch -p0 < c:/dl/SOLR-204* (Stripping trailing CRs from patch.) patching file src/test/test-files/solr/conf/solrconfig.xml (Stripping trailing CRs from patch.) patching file src/webapp/WEB-INF/web.xml (Stripping trailing CRs from patch.) patching file src/webapp/src/org/apache/solr/servlet/SolrDispatchFilter.java Hunk #1 FAILED at 56. 1 out of 1 hunk FAILED -- saving rejects to file src/webapp/src/org/apache/solr/ servlet/SolrDispatchFilter.java.rej (Stripping trailing CRs from patch.) patching file src/webapp/src/org/apache/solr/servlet/SolrRequestParsers.java (Stripping trailing CRs from patch.) patching file example/solr/conf/solrconfig.xml Hunk #1 succeeded at 231 (offset 8 lines). > Let solrconfig.xml configure the SolrDispatchFilter to handle /select > --------------------------------------------------------------------- > > Key: SOLR-204 > URL: https://issues.apache.org/jira/browse/SOLR-204 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > Assigned To: Ryan McKinley > Attachments: SOLR-204-HandleSelect.patch, SOLR-204-HandleSelect.patch > > > The major reason to make everythign use the SolrDispatchFilter is that we > would have consistent error handling. Currently, > SolrServlet spits back errors using: > PrintWriter writer = response.getWriter(); > writer.write(msg); > and the SolrDispatchFilter spits them back using: > res.sendError( code, ex.getMessage() ); > Using "sendError" lets the servlet container format the code so it shows up > ok in a browser. Without it, you may have to view source to see the error. > Aditionaly, SolrDispatchFilter is more decerning about including stack trace. > It only includes a stack trace of 500 or an unknown response code. > Eventually, the error should probably be formatted in the requested format - > SOLR-141. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.