[ https://issues.apache.org/jira/browse/SOLR-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492512 ]
Ryan McKinley commented on SOLR-204: ------------------------------------ > > should probably be something more like: > throw new SolrException(400,"Query parsing error: " + e.getMessage() ,e); > Yes, the other change is that errors for RequestDispatcher only print the stack trace if it is >=500, 400 (bad request) assumes the message will contain a user useful response. > Let solrconfig.xml configure the SolrDispatchFilter to handle /select > --------------------------------------------------------------------- > > Key: SOLR-204 > URL: https://issues.apache.org/jira/browse/SOLR-204 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > Assigned To: Ryan McKinley > Attachments: SOLR-204-HandleSelect.patch, > SOLR-204-HandleSelect.patch, SOLR-204-HandleSelect.patch > > > The major reason to make everythign use the SolrDispatchFilter is that we > would have consistent error handling. Currently, > SolrServlet spits back errors using: > PrintWriter writer = response.getWriter(); > writer.write(msg); > and the SolrDispatchFilter spits them back using: > res.sendError( code, ex.getMessage() ); > Using "sendError" lets the servlet container format the code so it shows up > ok in a browser. Without it, you may have to view source to see the error. > Aditionaly, SolrDispatchFilter is more decerning about including stack trace. > It only includes a stack trace of 500 or an unknown response code. > Eventually, the error should probably be formatted in the requested format - > SOLR-141. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.