[jira] Commented: (SOLR-560) Convert JDK logging to SLF4J
[ https://issues.apache.org/jira/browse/SOLR-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12634885#action_12634885 ] Grant Ingersoll commented on SOLR-560: -- AIUI, the LICENSE file needs to contain all licenses. NOTICES needs to contain notices, and not licenses. I don't think it needs to be duplicated. Convert JDK logging to SLF4J Key: SOLR-560 URL: https://issues.apache.org/jira/browse/SOLR-560 Project: Solr Issue Type: Wish Reporter: Ryan McKinley Assignee: Ryan McKinley Fix For: 1.4 Attachments: slf4j-api-1.5.0.jar, slf4j-jdk14-1.5.0.jar, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch After lots of discussion, we should consider using SLF4j to enable more flexibility in logging configuration. See: http://www.nabble.com/Solr-Logging-td16836646.html http://www.nabble.com/logging-through-log4j-td13747253.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-560) Convert JDK logging to SLF4J
[ https://issues.apache.org/jira/browse/SOLR-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12632049#action_12632049 ] Yonik Seeley commented on SOLR-560: --- bq. Now that we are into 1.4, I would like to commit this soon... +1 Convert JDK logging to SLF4J Key: SOLR-560 URL: https://issues.apache.org/jira/browse/SOLR-560 Project: Solr Issue Type: Wish Reporter: Ryan McKinley Assignee: Ryan McKinley Attachments: slf4j-api-1.5.0.jar, slf4j-jdk14-1.5.0.jar, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch After lots of discussion, we should consider using SLF4j to enable more flexibility in logging configuration. See: http://www.nabble.com/Solr-Logging-td16836646.html http://www.nabble.com/logging-through-log4j-td13747253.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-560) Convert JDK logging to SLF4J
[ https://issues.apache.org/jira/browse/SOLR-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12602874#action_12602874 ] Ryan McKinley commented on SOLR-560: I removed this from the 1.3 list... Hopefully we can add it just after the 1.3 release so we have plenty of time to know if it is an ok choice. Convert JDK logging to SLF4J Key: SOLR-560 URL: https://issues.apache.org/jira/browse/SOLR-560 Project: Solr Issue Type: Wish Reporter: Ryan McKinley Assignee: Ryan McKinley Attachments: slf4j-api-1.5.0.jar, slf4j-jdk14-1.5.0.jar, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch After lots of discussion, we should consider using SLF4j to enable more flexibility in logging configuration. See: http://www.nabble.com/Solr-Logging-td16836646.html http://www.nabble.com/logging-through-log4j-td13747253.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-560) Convert JDK logging to SLF4J
[ https://issues.apache.org/jira/browse/SOLR-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12597503#action_12597503 ] David Smiley commented on SOLR-560: --- I've been using this with JUL and Log4j just fine. I made tweaks to the JSP so that it would compile. Applying the patch didn't work for me because it had references to unexpanded $Id$ in the source yet my checkout had them expanded. So I did a replace-all regexp on all the source to unexpand these down to just $Id$ and then I could apply the patch. Convert JDK logging to SLF4J Key: SOLR-560 URL: https://issues.apache.org/jira/browse/SOLR-560 Project: Solr Issue Type: Wish Reporter: Ryan McKinley Fix For: 1.3 Attachments: slf4j-api-1.5.0.jar, slf4j-jdk14-1.5.0.jar, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch After lots of discussion, we should consider using SLF4j to enable more flexibility in logging configuration. See: http://www.nabble.com/Solr-Logging-td16836646.html http://www.nabble.com/logging-through-log4j-td13747253.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SOLR-560) Convert JDK logging to SLF4J
FYI, I will take a look at this next week (just in case you are wondering why I haven't since I was the one making the noise). On May 6, 2008, at 11:32 AM, Sean Timm (JIRA) wrote: [ https://issues.apache.org/jira/browse/SOLR-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12594603 #action_12594603 ] Sean Timm commented on SOLR-560: Thanks for taking a look at SOLR-554, Patrick. I did test the log level selector with this SLF4J patch and it works fine as is. It might be desirable to change the log level names in the log level selector to match the names in SLF4J however. From the SLF4J FAQ: SLF4J is only a facade, meaning that it does not provide a complete logging solution. Operations such as [...] setting logging levels cannot be performed with SLF4J. Convert JDK logging to SLF4J Key: SOLR-560 URL: https://issues.apache.org/jira/browse/SOLR-560 Project: Solr Issue Type: Wish Reporter: Ryan McKinley Fix For: 1.3 Attachments: slf4j-api-1.5.0.jar, slf4j-jdk14-1.5.0.jar, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch After lots of discussion, we should consider using SLF4j to enable more flexibility in logging configuration. See: http://www.nabble.com/Solr-Logging-td16836646.html http://www.nabble.com/logging-through-log4j-td13747253.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-560) Convert JDK logging to SLF4J
[ https://issues.apache.org/jira/browse/SOLR-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12594603#action_12594603 ] Sean Timm commented on SOLR-560: Thanks for taking a look at SOLR-554, Patrick. I did test the log level selector with this SLF4J patch and it works fine as is. It might be desirable to change the log level names in the log level selector to match the names in SLF4J however. From the SLF4J FAQ: SLF4J is only a facade, meaning that it does not provide a complete logging solution. Operations such as [...] setting logging levels cannot be performed with SLF4J. Convert JDK logging to SLF4J Key: SOLR-560 URL: https://issues.apache.org/jira/browse/SOLR-560 Project: Solr Issue Type: Wish Reporter: Ryan McKinley Fix For: 1.3 Attachments: slf4j-api-1.5.0.jar, slf4j-jdk14-1.5.0.jar, SOLR-560-slf4j.patch, SOLR-560-slf4j.patch After lots of discussion, we should consider using SLF4j to enable more flexibility in logging configuration. See: http://www.nabble.com/Solr-Logging-td16836646.html http://www.nabble.com/logging-through-log4j-td13747253.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-560) Convert JDK logging to SLF4J
[
https://issues.apache.org/jira/browse/SOLR-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12594136#action_12594136
]
Ryan McKinley commented on SOLR-560:
I attached a quick patch to convert to SLF4j. I have not fully tested to make
sure the default behavior is the same as it was before, but a quick look at the
example seems reasonable.
This changed:
log.finest - log.trace
log.fine - log.debug
log.warning - log.warn
log.severe - log.error
(info stays the same)
The only bit I was not sure how to translate is in SolrRequestParsers.java:
{code:java}
log.throwing(getClass().getName(), getTransformer, tce);
{code}
for now, i just used:
{code:java}
log.error( getClass().getName() + getTransformer, tce );
{code}
Additionally, wherever I noticed it, I used slf4j style formatters:
http://www.slf4j.org/faq.html#logging_performance
but we may want to make a more through review
Convert JDK logging to SLF4J
Key: SOLR-560
URL: https://issues.apache.org/jira/browse/SOLR-560
Project: Solr
Issue Type: Wish
Reporter: Ryan McKinley
Fix For: 1.3
Attachments: slf4j-api-1.5.0.jar, slf4j-jdk14-1.5.0.jar,
SOLR-560-slf4j.patch
After lots of discussion, we should consider using SLF4j to enable more
flexibility in logging configuration.
See:
http://www.nabble.com/Solr-Logging-td16836646.html
http://www.nabble.com/logging-through-log4j-td13747253.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
