Re: [Spacewalk-devel] Action scheduling on ported pages
On Tue, Jan 28, 2014 at 06:57:25AM -0500, Jan Dobes wrote: Nevermind, you don't have to fix it. I already corrected your patch and pushed it to master. Thanks. :) -- Bo Maryniuk SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer His entire job career were upgraded by the company to a shell script. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
Hi, Michael.
On Wed, Jan 22, 2014 at 04:01:23PM +0100, Michael Mraka wrote:
- SSM/Configuration/Enable: The message 'You may schedule rhncfg*
package...'
should stay above the date picker as it was originally.
Done.
- The original text before the date picker ('You may schedule the package
installations to take place as soon as possible, or no sooner than a
specified time') suggests that the action might not take place
immediately
while with new wording 'Schedule at' users would expect the action is
going
to happen right after confirmation. I'd prefer something with
similar meaning to the original.
Done. Since we removed as soon as possible checkbox, the same fashion we
did
to the label: Schedule no sooner than a specified time. :)
Take care.
Hello Bo,
I reviewed your patch and there are still some issues.
- The text on SSM/Configuration/Enable is now above Date Picker and that's fine.
- You changed the message, but there is a typo :) (s/that/than)
- You added colon next to the message but I can see it only on
SSM/Configuration/Enable, on other pages (I checked Packages related pages) is
the message without it.
- Something else colon related :) - on Packages install/remove/verify... pages
(and not SSM) I noticed the old message as a hint (line with gray font) under
Date Picker, it's nice but there is a colon redundant.
Regards,
--
Jan Dobes
Satellite Engineering, Red Hat
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
Hi, Michael.
On Wed, Jan 22, 2014 at 04:01:23PM +0100, Michael Mraka wrote:
- SSM/Configuration/Enable: The message 'You may schedule rhncfg* package...'
should stay above the date picker as it was originally.
Done.
- The original text before the date picker ('You may schedule the package
installations to take place as soon as possible, or no sooner than a
specified time') suggests that the action might not take place immediately
while with new wording 'Schedule at' users would expect the action is going
to happen right after confirmation. I'd prefer something with
similar meaning to the original.
Done. Since we removed as soon as possible checkbox, the same fashion we did
to the label: Schedule no sooner than a specified time. :)
Take care.
--
Bo Maryniuk
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
I am not young enough to know everything.
asap-removal-patches.tar.bz2
Description: application/bzip-compressed-tar
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
Bo Maryniuk wrote:
% On Wed, Jan 08, 2014 at 01:12:06PM +0100, Michael Mraka wrote:
% % Could be. But it doesn't answer my questions. I'm asking for timeframe
% % because this is one of the blockers for Spacewalk 2.1 release and we
% % have to decide whether wait for it or not.
% %
% % OK, that sounds reasonable. Then I will make some more patches that will
% % synchronize the rest of the pages with the current Date picker. Then we
will
% % introduce the new Date picker (as a tag, so it will instantly replace
% % everything). Fair enough?
%
% Yes, that will solve it.
%
% Michael,
% what is the status here reviewing it, please?
Hello Bo,
I'm sorry it took me very long to review it. It looks good, just two notes:
- SSM/Configuration/Enable: The message 'You may schedule rhncfg* package...'
should stay above the date picker as it was originally.
- The original text before the date picker ('You may schedule the package
installations to take place as soon as possible, or no sooner than a
specified time') suggests that the action might not take place immediately
while with new wording 'Schedule at' users would expect the action is going
to happen right after confirmation. I'd prefer something with
similar meaning to the original.
Regards,
--
Michael Mráka
Satellite Engineering, Red Hat
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
On Wed, Jan 08, 2014 at 01:12:06PM +0100, Michael Mraka wrote: % Could be. But it doesn't answer my questions. I'm asking for timeframe % because this is one of the blockers for Spacewalk 2.1 release and we % have to decide whether wait for it or not. % % OK, that sounds reasonable. Then I will make some more patches that will % synchronize the rest of the pages with the current Date picker. Then we will % introduce the new Date picker (as a tag, so it will instantly replace % everything). Fair enough? Yes, that will solve it. Hi, here is a first patch that synchronizes the rest of the pages with the current Date picker. While doing that, I found few forms are shredded and displayed wrong, so the patch fixing that will come from the side of Twitter Bootstrap saga. Thanks! -- Bo Maryniuk SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer You have delighted us long enough. remove-asap-checkbox.patch.bz2 Description: application/bzip ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
Hello Bo, % but until it's done % (consistently across all the pages) you should keep the old style. % % Then why to make the efforts tripple times? Let's sync it with the rest of the % pages instead? You already agreed that the current way is not simple and, in % fact, duplicates the functionality. There should be always only one date % input, set to now by default. How you can possibly get confused with this? As you wrote previously you postponed finishing the changes. Are you working on it again or not? If yes go ahead, if not please make it compatible with other pages. % Otherwise it is the same as you would say It is possible to port Perl to % Java, but until it is done, let's continue invest in Perl code. :-/ I strongly disagree. It is the same as I'd say Port Perl to Java but always keep interface compatible regardless which technology it's based on. % This is also possible and again until it's done you should keep % consistency with old pages. % % Please see above. This is why you call them old. :) % % % The feature was a bit postponed since we had first to get TB3 working. :-) Now % % it is there, so new UI is coming, of course. % % % % Could please take a look and update the pages so they follow original % % workflow? % % By 'the feature' you mean new date picker or pop-up confirmation stuff? % Do you have a timeframe for their implementation? % % Of course. And we already did that here, BTW. Looks super-awesome and you will % *love* it. :) Could be. But it doesn't answer my questions. I'm asking for timeframe because this is one of the blockers for Spacewalk 2.1 release and we have to decide whether wait for it or not. % And this is also why we kept the old way JSPs in under-done state in % previous code only because we yet had no Twitter Bootstrap there. Adding 3rd % party JavaScript libraries would be also a big mistake. The old things are % anyway will die. And this is also why we had started Twitter Bootstrap in % general: to have simpler, better, more responsive UI, yet standardized. So % again, I honestly see no reasons to continue the old way duplicating the % efforts, especially if we already have modern way. Regards, -- Michael Mráka Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
% Could be. But it doesn't answer my questions. I'm asking for timeframe % because this is one of the blockers for Spacewalk 2.1 release and we % have to decide whether wait for it or not. % % OK, that sounds reasonable. Then I will make some more patches that will % synchronize the rest of the pages with the current Date picker. Then we will % introduce the new Date picker (as a tag, so it will instantly replace % everything). Fair enough? Yes, that will solve it. Regards, -- Michael Mráka Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
% First of them: the original schedule date picker on contains two choices % - Schedule action as soon as possible % - Schedule action for no sooner than: date select % while new contains only % - Schedule action for no sooner than date select % % Because it is the same thing: as soon as possible is basically now, which is % already defined in the date picker. There is no need to duplicate the same % thing twice. % % Although we may discuss which one is better and whether it's worth of % changing it, for now I'd primarily prefer to keep it consistent across % all the pages. % % Actually, we were discussing to removing the option as soon as possible from % other pages to keep it consistent. :-) Yes, it's possible to simplify date picker on other pages but until it's done (consistently across all the pages) you should keep the old style. % The second and IMHO major issue is - the original page (and all other pages) % implement two phase confirmation. % % The confirmation won't be any longer a bulky separate JSP page with all the % hassle involved, but a little neat Twitter Bootstrap-based modal pop-up % instead. This is also possible and again until it's done you should keep consistency with old pages. % The feature was a bit postponed since we had first to get TB3 working. :-) Now % it is there, so new UI is coming, of course. % % Could please take a look and update the pages so they follow original % workflow? By 'the feature' you mean new date picker or pop-up confirmation stuff? Do you have a timeframe for their implementation? Regards, -- Michael Mráka Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
Hi, Michael, I am back. :) On Tue, Jan 07, 2014 at 11:43:18AM +0100, Michael Mraka wrote: Yes, it's possible to simplify date picker on other pages Of course. This is what we all want, ultimately: a simplicity and better UI. but until it's done (consistently across all the pages) you should keep the old style. Then why to make the efforts tripple times? Let's sync it with the rest of the pages instead? You already agreed that the current way is not simple and, in fact, duplicates the functionality. There should be always only one date input, set to now by default. How you can possibly get confused with this? Otherwise it is the same as you would say It is possible to port Perl to Java, but until it is done, let's continue invest in Perl code. :-/ This is also possible and again until it's done you should keep consistency with old pages. Please see above. This is why you call them old. :) % The feature was a bit postponed since we had first to get TB3 working. :-) Now % it is there, so new UI is coming, of course. % % Could please take a look and update the pages so they follow original % workflow? By 'the feature' you mean new date picker or pop-up confirmation stuff? Do you have a timeframe for their implementation? Of course. And we already did that here, BTW. Looks super-awesome and you will *love* it. :) And this is also why we kept the old way JSPs in under-done state in previous code only because we yet had no Twitter Bootstrap there. Adding 3rd party JavaScript libraries would be also a big mistake. The old things are anyway will die. And this is also why we had started Twitter Bootstrap in general: to have simpler, better, more responsive UI, yet standardized. So again, I honestly see no reasons to continue the old way duplicating the efforts, especially if we already have modern way. -- Bo Maryniuk SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer I'm smiling. This should scare you. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
On Thu, Dec 19, 2013 at 11:15:13AM +0100, Michael Mraka wrote: First of them: the original schedule date picker on contains two choices - Schedule action as soon as possible - Schedule action for no sooner than: date select while new contains only - Schedule action for no sooner than date select Because it is the same thing: as soon as possible is basically now, which is already defined in the date picker. There is no need to duplicate the same thing twice. Although we may discuss which one is better and whether it's worth of changing it, for now I'd primarily prefer to keep it consistent across all the pages. Actually, we were discussing to removing the option as soon as possible from other pages to keep it consistent. :-) The second and IMHO major issue is - the original page (and all other pages) implement two phase confirmation. The confirmation won't be any longer a bulky separate JSP page with all the hassle involved, but a little neat Twitter Bootstrap-based modal pop-up instead. The feature was a bit postponed since we had first to get TB3 working. :-) Now it is there, so new UI is coming, of course. Could please take a look and update the pages so they follow original workflow? Yes, sure. However, right now I am on vacations and will look at it next year. :) Happy New Year and Merry Christmas! -- Bo Maryniuk SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer A conclusion is the place where you got tired of thinking. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Action scheduling on ported pages
Hello Bo, recently come across two pages - SSM Errata (/rhn/systems/ssm/ListPatches.do) and SSM Misc Reboot (/rhn/systems/ssm/misc/RebootSystem.do) - which you've converted from pxt to java. Both pages works fine but there're small yet important differences between them and the other action scheduling pages. First of them: the original schedule date picker on contains two choices - Schedule action as soon as possible - Schedule action for no sooner than: date select while new contains only - Schedule action for no sooner than date select Although we may discuss which one is better and whether it's worth of changing it, for now I'd primarily prefer to keep it consistent across all the pages. The second and IMHO major issue is - the original page (and all other pages) implement two phase confirmation. I mean e.g. on system Software Packages List / Remove (/rhn/systems/details/packages/PackageList.do) you can select packages and click Remove which gets you to a confirmation page (/rhn/systems/details/packages/RemoveConfirm.do) where you can pick the date and click Confirm. The new pages have date picker and Apply right on them and there's no Confirm page. Which is, again, inconsistent with the other pages and it removes the _emergency cord_ which is dangerous especially for actions that can't be undone (like reboot systems). Could please take a look and update the pages so they follow original workflow? Thanks a lot, -- Michael Mráka Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
